From patchwork Wed Mar 24 17:33:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161915 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B305C433F1 for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 631FA61A1D for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237206AbhCXRem (ORCPT ); Wed, 24 Mar 2021 13:34:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237254AbhCXReV (ORCPT ); Wed, 24 Mar 2021 13:34:21 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92B09C061763 for ; Wed, 24 Mar 2021 10:34:10 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id e14so16030841ejz.11 for ; Wed, 24 Mar 2021 10:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sGXBjiCFdgwpvHzqPWC3/RPSg9lntmzEIWbK3MkoU6U=; b=V3k9oO55MjjZsX1qHzmUi4k1DuLQl/bW1r8/NSBz9AV1Y59ZREKF/pGfgheG7lx+v4 ggpEUOSwS5OX9re9xERe7vz6yaR6zNOGOGIoxTjMzzSMe/9TDCqIJPIa+tq6f9xiDTP/ MhFgQYSPl1ZFZzi7W2P7tpdnGXsyp1a5aUMRXu5o5SW3KHNDfQjSfYbHUoASovtIH/XS /8f4lsEyvKnASydlj2+jRntf/Onsc1qrDdsOJj4rJSrdV1F6Y+KsUZzns6e65XeuupoR HhVN5Rlwcx6YvF38ClCmMpvgRZdQV0NFa0wfXCKK79EkRefOifnO6VMA00c1onOviab4 uNGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sGXBjiCFdgwpvHzqPWC3/RPSg9lntmzEIWbK3MkoU6U=; b=DBQnjOpXpINSCr+UpzQsFfWfKKvJCH0zoRakkJH36s0ezky9PVRwYv1N9nOa6u7Loj Y4DGgO8ZaQrJATWxMuDEX7rsel1ZAHtRxUD6XiipssXmUI66fpOd54ljNXO4xKUQWwPu G6go4akQpyotG1Tw//N2djHou3wHJ2W7HLPZuj2LNqKascwrrwYWYw6PSlROEcFvT8yB +yoXfwDeaxfh37BZS5I3UrKyAikj2lm0UX/7C9hkbzF3Fx4oQeqXXJtu9gPfrbw0k7/W 1PMaXqZSvkkZ/PuCHoP/cZFMzu+CyxuQER/cwwEx7QcnSmKXnBJlSuNpIhfwL81+ON3N 9igA== X-Gm-Message-State: AOAM532ZEuj910P40y5PlOdsw8Z2iHokNqFKA7hPOJkafhp6v+m3kpTe fg5QHoos/AAbZAfY46qizI6ZgmUZXXXQbQ== X-Google-Smtp-Source: ABdhPJwCM4qapUK3Em/x+G38ky1Ltx5JRSDQ/uZ3IWpyDINUgpkRcfHgaHTT/NjdsDcbmFXyrEOHsw== X-Received: by 2002:a17:906:f9db:: with SMTP id lj27mr4964835ejb.399.1616607249278; Wed, 24 Mar 2021 10:34:09 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:08 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 01/25] HID: intel-ish-hid: Remove unused variable 'err' Date: Wed, 24 Mar 2021 17:33:40 +0000 Message-Id: <20210324173404.66340-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp/client.c: In function ‘ishtp_cl_disconnect’: drivers/hid/intel-ish-hid/ishtp/client.c:266:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp/client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c index 1cc157126fce7..c81a1f8a92685 100644 --- a/drivers/hid/intel-ish-hid/ishtp/client.c +++ b/drivers/hid/intel-ish-hid/ishtp/client.c @@ -263,7 +263,6 @@ EXPORT_SYMBOL(ishtp_cl_unlink); int ishtp_cl_disconnect(struct ishtp_cl *cl) { struct ishtp_device *dev; - int err; if (WARN_ON(!cl || !cl->dev)) return -ENODEV; @@ -283,7 +282,7 @@ int ishtp_cl_disconnect(struct ishtp_cl *cl) return -ENODEV; } - err = wait_event_interruptible_timeout(cl->wait_ctrl_res, + wait_event_interruptible_timeout(cl->wait_ctrl_res, (dev->dev_state != ISHTP_DEV_ENABLED || cl->state == ISHTP_CL_DISCONNECTED), ishtp_secs_to_jiffies(ISHTP_CL_CONNECT_TIMEOUT)); From patchwork Wed Mar 24 17:33:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161901 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 161E0C433DB for ; Wed, 24 Mar 2021 17:35:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5B61619F3 for ; Wed, 24 Mar 2021 17:35:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237170AbhCXRej (ORCPT ); Wed, 24 Mar 2021 13:34:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237209AbhCXReL (ORCPT ); Wed, 24 Mar 2021 13:34:11 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C72DC0613DF for ; Wed, 24 Mar 2021 10:34:11 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id e14so16030899ejz.11 for ; Wed, 24 Mar 2021 10:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tQ98DqDCgp3VpW9J5G14oAPOoDjqdZPJlI/Mwh4Jc20=; b=A/dLEQ9uqTQQWDf+7m1HxFqs9w2URyTdEjwP4HueRVEUEatZ8pYoCvHmFemsWVs9d7 i/DOxyZUkBOR2x9Tp9Oxx2iUas5mjtYD+WtHclWhipLhDzuX6kQiMNqlBiuBttAssi2/ 3fkSdK2UqkJsS1XgsxuzwQH8GSmuJ788TgPlQE2All5vCLHGoFzxQGzCPs21YgGt6yZE OENgn3K7kKtgFXgccsbt4RKXlVvbsIL3brWTgpYq6ciFhPtpN6iam1J8cXdy5JOon7/r ILH7NlB3ivsps1WTPT9VZBpr/TpPKE6etLm9d5/8QPpWR7E6CurDEAbyjtAXsKqQCxGN 1F5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tQ98DqDCgp3VpW9J5G14oAPOoDjqdZPJlI/Mwh4Jc20=; b=ppcsjacMmmHMwEYSB2Xd4I3eW+SR7sSEj0AP125wqR830Ua2ufLhaWb9eZQjAx/SjI dUx4y1pQr6caxuOzReAwrf3iN/B7wDT3eMI+HodnwLIlGWYu8kv2U/TkQRCisFJPrxlW +CoeQyBhNN6VQayXy+p1iJ6s4FzdeXAFn91sRvyVCfHm/Zk16j4l0jj+3Y7B+/iG8zH4 2lfVAKn+MQL/PHSSvLm21+QEUpTT8y7SeKXwkemTpoSyF8y4CyGafYDH7QTYPW93rcsB +Cb+NHhCGuV7rfRHqwElCj3EGhT35y+mXeu6VaJjMsUOlXV2mmnE4ycIhFg9khbSIwih ciLw== X-Gm-Message-State: AOAM5332FZRPQjzpG72uDH/rSG7KkRIXAXwh6JYgfh4jizs6GlY5rVYt hXeNJhJmezpfbiDdqBWZ33xlAw== X-Google-Smtp-Source: ABdhPJxYd5PUfyNZIS4zpjgDLCdEncag5+bFQ6PaVo8gsvofMOve1KaZeAUJPzuvz6cPq6tcBPXTEg== X-Received: by 2002:a17:906:938f:: with SMTP id l15mr4872399ejx.15.1616607250150; Wed, 24 Mar 2021 10:34:10 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:09 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Daniel Drubin , linux-input@vger.kernel.org Subject: [PATCH 02/25] HID: ishtp-hid-client: Move variable to where it's actually used Date: Wed, 24 Mar 2021 17:33:41 +0000 Message-Id: <20210324173404.66340-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/hid/intel-ish-hid/ishtp-hid.c:11: drivers/hid/intel-ish-hid/ishtp-hid.h:24:21: warning: ‘hid_ishtp_guid’ defined but not used [-Wunused-const-variable=] Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Daniel Drubin Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 +++++ drivers/hid/intel-ish-hid/ishtp-hid.h | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index 0f1b5283bab42..24599280105d8 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c @@ -11,6 +11,11 @@ #include #include "ishtp-hid.h" +/* ISH Transport protocol (ISHTP in short) GUID */ +static const guid_t hid_ishtp_guid = + GUID_INIT(0x33AECD58, 0xB679, 0x4E54, + 0x9B, 0xD9, 0xA0, 0x4D, 0x34, 0xF0, 0xC2, 0x26); + /* Rx ring buffer pool size */ #define HID_CL_RX_RING_SIZE 32 #define HID_CL_TX_RING_SIZE 16 diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.h b/drivers/hid/intel-ish-hid/ishtp-hid.h index 5ffd0da3cf1fa..e2423f7d2b547 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid.h +++ b/drivers/hid/intel-ish-hid/ishtp-hid.h @@ -20,11 +20,6 @@ extern void (*hid_print_trace)(void *unused, const char *format, ...); #define hid_ishtp_trace(client, ...) \ (hid_print_trace)(NULL, __VA_ARGS__) -/* ISH Transport protocol (ISHTP in short) GUID */ -static const guid_t hid_ishtp_guid = - GUID_INIT(0x33AECD58, 0xB679, 0x4E54, - 0x9B, 0xD9, 0xA0, 0x4D, 0x34, 0xF0, 0xC2, 0x26); - /* ISH HID message structure */ struct hostif_msg_hdr { uint8_t command; /* Bit 7: is_response */ From patchwork Wed Mar 24 17:33:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161907 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C51C433E6 for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E80E619F3 for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237203AbhCXRej (ORCPT ); Wed, 24 Mar 2021 13:34:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237216AbhCXReM (ORCPT ); Wed, 24 Mar 2021 13:34:12 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 659BAC0613DE for ; Wed, 24 Mar 2021 10:34:12 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id w3so34249323ejc.4 for ; Wed, 24 Mar 2021 10:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FHkipYTKnSstTFJnbmdtyQKucMWsrejAj9mUW3hzYUM=; b=dUF0+KwB9tywOuOSJN7KHib9Kyj/mxSFofYtmO0WjMyKiP1sOnIX73pcL5dWCmsJvx 4XuYOG5Uck0eRnIJVqUgu2yed2C3XXiIXIfET9I2tdgDTq7zte11+1x//fPLnqF4epmm K4sR2dWrF2TYT3KRMkKnZ2d1H/DI63sKsZwulreFHlLVjFTzCqtjIrQJ6W9u/z4PqyAb 0nGssOXfQAeqCcSqd5RtE+UcFkOHDHjZ9wI3yV7hyqbaxlHTuX1L/NGKq1SjC/X3r66F Hl0QVM0NwpgDQ9MYhrI/ovFk65C15grVvKJDOBB+9ID5q/SeVNwJnPqp+Y9FgcM2gAGt LCkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FHkipYTKnSstTFJnbmdtyQKucMWsrejAj9mUW3hzYUM=; b=X7HWxAT894rPqOSgNuOqZ/AMb+1vhiPqoHhQjeakj62wocSI/jRosKGCeIfS1tm56H +Enn2FwweEwk3DR6aAgQ3rAx74YCGd9hl/oveGlJcnVFpByNV7TU79naS4Jqx/sHVNb0 wLknF1dq6SLTUYo7VYRaQeepf6OlW1bXWPvQD55+LmbwKuEvmcayYARtlFJkfKa7zA7S 3kWn9UbNHH6h8p88mWRgwZJ3HMea3nkzMTx7VKuQ3sW/iSd1BiKt4IVfQm5WR7Cd0WNC 3kRLCzlt3WD48wCLx1vM/6CEYOOmmasbOqmQmjMxd7vU+eOmWYUAIrStVjr8/M69dj8l onTQ== X-Gm-Message-State: AOAM530Zbt/uTzvxMhjohg/tGCBiJOftvWCo0bcbJD+af/Y4mbQE/4en YeoVQYQ5QQCVA6gsvpHnJCr5Aw== X-Google-Smtp-Source: ABdhPJxeSr7aEdRF1BRPbkJkacLU9X6tluwT/TI5/mx4dRxSDXbOALvCJ/ejHQJz5B880dDFOCSAhw== X-Received: by 2002:a17:907:7785:: with SMTP id ky5mr4814480ejc.133.1616607251078; Wed, 24 Mar 2021 10:34:11 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:10 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Zhang Lixu , Kai-Heng Feng , Daniel Drubin , linux-input@vger.kernel.org Subject: [PATCH 03/25] HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' Date: Wed, 24 Mar 2021 17:33:42 +0000 Message-Id: <20210324173404.66340-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ipc/pci-ish.c: In function ‘ish_resume_handler’: drivers/hid/intel-ish-hid/ipc/pci-ish.c:264:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Zhang Lixu Cc: Kai-Heng Feng Cc: Daniel Drubin Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c index 06081cf9b85a2..61efc30ed9afb 100644 --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c @@ -261,7 +261,6 @@ static void __maybe_unused ish_resume_handler(struct work_struct *work) struct pci_dev *pdev = to_pci_dev(ish_resume_device); struct ishtp_device *dev = pci_get_drvdata(pdev); uint32_t fwsts = dev->ops->get_fw_status(dev); - int ret; if (ish_should_leave_d0i3(pdev) && !dev->suspend_flag && IPC_IS_ISH_ILUP(fwsts)) { @@ -273,7 +272,7 @@ static void __maybe_unused ish_resume_handler(struct work_struct *work) /* Waiting to get resume response */ if (dev->resume_flag) - ret = wait_event_interruptible_timeout(dev->resume_wait, + wait_event_interruptible_timeout(dev->resume_wait, !dev->resume_flag, msecs_to_jiffies(WAIT_FOR_RESUME_ACK_MS)); From patchwork Wed Mar 24 17:33:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161903 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E48C433E5 for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 713D261A1A for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237291AbhCXRek (ORCPT ); Wed, 24 Mar 2021 13:34:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237218AbhCXReN (ORCPT ); Wed, 24 Mar 2021 13:34:13 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E63DC0613DE for ; Wed, 24 Mar 2021 10:34:13 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id x21so28581054eds.4 for ; Wed, 24 Mar 2021 10:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Uk7zBDuxVird9hlwDlzfVR+OTGmQfb7Ta2eddUi7FDk=; b=oMG1f/lilaXJuU+qkI5svIKpq2nZYEjtZdaiC7WToDBB3y0uP4crnOWItZmd5KHr5M ppBNbO7xGEW0qeTEQOMaSVI/NxrQc9apoBqcvRZQskDcbbUdclF4xs3yQIqeSp1BlvXI RLon93Usg8XWJgzObbNwpqiYQZhxnf8Mzx0Fe9+MLPXZSgyTMO2vJB3fwOtCjpw9ql3S xg2KWjw5PGYNVlkfzDr0/tIIR1Nx3VwX68bC1omsXKzxxge0Ikrzizz5hioI2BbjOrUw +ogMVa7xQSDpbXnAexotvhGqPai6VH9Jp9stvVdBDxfdhNFgSITW6aN5pafh0WKfGnrO Bkdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Uk7zBDuxVird9hlwDlzfVR+OTGmQfb7Ta2eddUi7FDk=; b=n284D9SB7BPy72poyZz4cEv71htYsXUfhWMQwUl3ppe8w7AdrIysfFhApnCK5J2mZE KrFg8Knf4k3xfUepyPjYDZGfmpGvcS2kfe8IzMjegGgwuJyu+JVRLu3GTkYbX4L6tSR5 qRVPJ0uss05gbMxcYb2tQ7UZPcfG/4BsYvPppCXySJodoinChS7r3SGBaVFXk7Sz/UKo VTMzh8GP44aG7VNhX4sF5ytw6OSZ507iFTcOuA6k/3WxNzv7Qd2ZPryAtZToeG8b9bz5 VlapLbb3Hgo3WG4x/MP6xOE9z5Ey8y1RG9j5iF5xwjEQxaGYUVYEUf/VQaXtFC3pVze9 7eqA== X-Gm-Message-State: AOAM5320Icnhf2yGYwP/6BZ9MZYFwjaUrAURJLaVD3j2LTsClkL46k+b BFkUU2stufz+LXGcUK7ODX0KTA== X-Google-Smtp-Source: ABdhPJzEcz7kA6LloIrNljqPtpYDplJZAPeUfdrb6FoajItVxIad1HesJK9UA1useQFk8yXszTAC9w== X-Received: by 2002:aa7:d54c:: with SMTP id u12mr4872746edr.234.1616607252099; Wed, 24 Mar 2021 10:34:12 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:11 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , =?utf-8?q?Uwe_Kleine-K?= =?utf-8?q?=C3=B6nig?= , linux-input@vger.kernel.org Subject: [PATCH 04/25] HID: intel-ish: Supply some missing param descriptions Date: Wed, 24 Mar 2021 17:33:43 +0000 Message-Id: <20210324173404.66340-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp/bus.c:173: warning: Function parameter or member 'fw_client' not described in 'ishtp_get_fw_client_id' drivers/hid/intel-ish-hid/ishtp/bus.c:845: warning: Function parameter or member 'device' not described in 'ishtp_device' drivers/hid/intel-ish-hid/ishtp/bus.c:858: warning: Function parameter or member 'device' not described in 'ishtp_get_pci_device' drivers/hid/intel-ish-hid/ishtp/bus.c:871: warning: Function parameter or member 'cl_device' not described in 'ishtp_trace_callback' drivers/hid/intel-ish-hid/ishtp/bus.c:884: warning: Function parameter or member 'dev' not described in 'ish_hw_reset' Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: "Uwe Kleine-König" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp/bus.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c index ffc9ce5c86ee6..c1c7d5356208d 100644 --- a/drivers/hid/intel-ish-hid/ishtp/bus.c +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c @@ -164,6 +164,7 @@ EXPORT_SYMBOL(ishtp_fw_cl_get_client); /** * ishtp_get_fw_client_id() - Get fw client id + * @fw_client: firmware client used to fetch the ID * * This interface is used to reset HW get FW client id. * @@ -835,6 +836,7 @@ int ishtp_use_dma_transfer(void) /** * ishtp_device() - Return device pointer + * @device: ISH-TP client device instance * * This interface is used to return device pointer from ishtp_cl_device * instance. @@ -851,6 +853,7 @@ EXPORT_SYMBOL(ishtp_device); * ishtp_get_pci_device() - Return PCI device dev pointer * This interface is used to return PCI device pointer * from ishtp_cl_device instance. + * @device: ISH-TP client device instance * * Return: device *. */ @@ -862,6 +865,7 @@ EXPORT_SYMBOL(ishtp_get_pci_device); /** * ishtp_trace_callback() - Return trace callback + * @cl_device: ISH-TP client device instance * * This interface is used to return trace callback function pointer. * @@ -875,6 +879,7 @@ EXPORT_SYMBOL(ishtp_trace_callback); /** * ish_hw_reset() - Call HW reset IPC callback + * @dev: ISHTP device instance * * This interface is used to reset HW in case of error. * From patchwork Wed Mar 24 17:33:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161909 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E30A5C433E4 for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC46261A0A for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237245AbhCXRek (ORCPT ); Wed, 24 Mar 2021 13:34:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237226AbhCXReO (ORCPT ); Wed, 24 Mar 2021 13:34:14 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 500D1C0613DE for ; Wed, 24 Mar 2021 10:34:14 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id bx7so28564881edb.12 for ; Wed, 24 Mar 2021 10:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YX2rXBybL20wXzWEgbJFWLYt9DGgkwCmYeXkOpQbl+4=; b=Bfp57e1lQCY5EFWX4luD5N2fEWYpccMVTLKliRDQiNa6NB9MeuKuVW/OnZAxt3gryp 87Myoc7DNQFoZSRfyQDVUc6ww4tJE7LQmZWMF7uBiQFF0zFIfruv5I0pTSvWtCWqkAme Br+V0yd4e9SUTg2fPyk+z2nvqy+EeFUtkJdGHUyz7CtXqfBCF4uZkIyDkhQv145f7Q1T 5TjjYkcNVGcAEjJoTI+EnZFyqXZU/Gk0+38r2/geqhI20tLUZU1um5zEwsCnO0kgPAoB +jobYECsruYUzK/2mZ3qRQURK3G4u2uezIik7Q8hsWPTJo0gEBNh8C5TvxICZBnwN75v arSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YX2rXBybL20wXzWEgbJFWLYt9DGgkwCmYeXkOpQbl+4=; b=Q3tG8RLUb5EtNThYVVe0x3TPq38EC9H18gnZNxFxdrC3wAZGmzxwPFLwDv9NdT37GH lPCnMziEtdjJl3809GidtoTD/HbPhjH1J+MBhc3/luxwGgrzqQ4HyaKeR6NsIsQG1CF2 gPzP5I/FTh+tkdQn5wHW8TnLoD8JnbE67EiyxZtvIPZPB5GjgBxSOnMFSC3jW1tf01PA rIjWLeS/k//+xDwaxqUXEJx1IzUMWCdSmG8QZQyXOMPZtzu5bmaNweQv3KbFfSjOA4A9 GQxQG8giZZhq/GeQCLAP9V3eBc+BFpfGmZ+Bx3lXA6PndF2j5SRjtWDbyD2TADAnbVQH Ophg== X-Gm-Message-State: AOAM533vQxioGuyzqcGntOmCNR7Vu9Sn6TOrG6sN2BwgcwSsssC+FaoK bUOHsdYra52EpR12X8Q6sfsVow== X-Google-Smtp-Source: ABdhPJwCPqXP3jqO62z9IUUGkbePEAMenKTIuU1I7W2tHc5o4gR44zrdACq+n9DNpRRywppISA6OkA== X-Received: by 2002:a05:6402:142:: with SMTP id s2mr4677887edu.2.1616607253067; Wed, 24 Mar 2021 10:34:13 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:12 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 05/25] HID: intel-ish: Fix a naming disparity and a formatting error Date: Wed, 24 Mar 2021 17:33:44 +0000 Message-Id: <20210324173404.66340-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp/hbm.c:409: warning: expecting prototype for ishtp_client_disconnect_request(). Prototype was for ishtp_hbm_fw_disconnect_req() instead drivers/hid/intel-ish-hid/ishtp/hbm.c:433: warning: wrong kernel-doc identifier on line: Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c b/drivers/hid/intel-ish-hid/ishtp/hbm.c index dbfae60f26216..9c031a06e4c40 100644 --- a/drivers/hid/intel-ish-hid/ishtp/hbm.c +++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c @@ -398,7 +398,7 @@ static void ishtp_hbm_cl_connect_res(struct ishtp_device *dev, } /** - * ishtp_client_disconnect_request() - Receive disconnect request + * ishtp_hbm_fw_disconnect_req() - Receive disconnect request * @dev: ISHTP device instance * @disconnect_req: disconnect request structure * @@ -430,7 +430,7 @@ static void ishtp_hbm_fw_disconnect_req(struct ishtp_device *dev, } /** - * ishtp_hbm_dma_xfer_ack(() - Receive transfer ACK + * ishtp_hbm_dma_xfer_ack() - Receive transfer ACK * @dev: ISHTP device instance * @dma_xfer: HBM transfer message * From patchwork Wed Mar 24 17:33:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161911 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1210C433E9 for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B622261A20 for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237226AbhCXRek (ORCPT ); Wed, 24 Mar 2021 13:34:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237238AbhCXReP (ORCPT ); Wed, 24 Mar 2021 13:34:15 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 937D3C0613E1 for ; Wed, 24 Mar 2021 10:34:15 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id e7so28504956edu.10 for ; Wed, 24 Mar 2021 10:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YVoLbq8RBXUfihLEoAO2RhgjiaRVSJgl/YQpPYdz058=; b=F+iJ9M+WInt+IZa6vVqUUZZZXKjhcQ0sePVfsAX4epZi6SWJVwwuoO49lpEpWsG1B4 lKTGk75uroceeGyvtgjjYpPiujSmq/LW9HLYXMjM0earEN+yrwXDAj9NnLOb+WVywr0E OihBB1Ah5Y+zYcknMsE9vNN7NU+z3C60+eoaaYCl/YU9INj8EwOoX8ifSB03NMHEefq3 /1U3MTbAvW7ffjBahhaiMpWExcRT0HxVlOb4shQrt6UVPCrPlcrAF3Dfoa6Vx6HmEYjV 3nQXYNopEpnO8Qzbnfdkla5KC38yLS6Y+r2C9Ghawi14bY0tK9CVh7OD8mP5/Y1usLIK 4D/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YVoLbq8RBXUfihLEoAO2RhgjiaRVSJgl/YQpPYdz058=; b=Bq9wsHqktObNkcXr8+icAfuUbi4NEOfIEhAE24ZmIY0BVUHtLirUczR/SXZe3rRyzA SIhtSVtzwPaeqHRSrTeyd4f1+2YrSGCf3cK7xmEynmI48OC/wBHx7iAde1R4iePymSnW +XipKRrgX2xrvaDNDT4d+CrHekTi/QCjgv7bKBETjteLqlcJjDIGQN3hqKjc72m4cAsO tESFHkwVxAqzAfvik3omPI54CdsKTxOZdbzYQfEOC+H6Lnc1Sn//FJ92Vt9Q2BNO0Ad7 ZLfgIAAoH5oPxDxHuKjOZhlIr0pPPRekVELZZ2Q70UEqRtbAQeHGmgfaCA5vHX0R21oj 5oGA== X-Gm-Message-State: AOAM533AbzE1GClAoEnhRU/r45VSFMUZJ95ABH42qWOMKnr/Y2UH9UKO qLZdwhaiNC4V3Rf46TcAKguMvg== X-Google-Smtp-Source: ABdhPJxRZif/QlzU41cuhZx3aHLwJ3xCFIf1WIBnnn5M/mUI6grvUz+kGd+AImbr0OB4afgXt35r3g== X-Received: by 2002:a05:6402:3587:: with SMTP id y7mr4901632edc.54.1616607254314; Wed, 24 Mar 2021 10:34:14 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:13 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , message to , linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Date: Wed, 24 Mar 2021 17:33:45 +0000 Message-Id: <20210324173404.66340-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: message to Cc: linux-usb@vger.kernel.org Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/usbhid/usbkbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c index d5b7a696a68c5..d0c640be8a885 100644 --- a/drivers/hid/usbhid/usbkbd.c +++ b/drivers/hid/usbhid/usbkbd.c @@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = { * new key is pressed or a key that was pressed is released. * @led: URB for sending LEDs (e.g. numlock, ...) * @newleds: data that will be sent with the @led URB representing which LEDs - should be on + * should be on * @name: Name of the keyboard. @dev's name field points to this buffer * @phys: Physical path of the keyboard. @dev's phys field points to this * buffer From patchwork Wed Mar 24 17:33:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161931 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1866CC43381 for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F417C61A21 for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237316AbhCXReo (ORCPT ); Wed, 24 Mar 2021 13:34:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237266AbhCXRe1 (ORCPT ); Wed, 24 Mar 2021 13:34:27 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A652C0613E0 for ; Wed, 24 Mar 2021 10:34:16 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id b16so28606423eds.7 for ; Wed, 24 Mar 2021 10:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hkSdOt3A8I2Fl/7qWj25aivbAO5QAKQ9HatKpk+E2jU=; b=r4NVGvRoC9XVcVeanMTdxp0FAJKtWFQXEPwv4kHm5tjVuVBSyDHj3QivdYQWMF0tq8 dtdHKWEuMJJAvdRNeFcVBoIAbg+JYx6gXTlfzFK7JY4SlM9TznIcT3sQgWz4a0hxcify oO2RlpOJlbLOxc/fpjQqH7gqZ9N9xgfYqCn/LuqDct4CPbIvAFPgtvgHk1VFaGD42B7i eOHQbOoKn2hBOtHW6Vfnaiw4KeRTDPzx+ieq0nhTUsphHXXAlSUcCR8hQNyp+GlClgXJ BIeXDhqE9qltMwMDLmyQiUAfcSrDob94Oewr7j8BA2HC5oZYong8c5AKFSPtc4RuMBKh sGTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hkSdOt3A8I2Fl/7qWj25aivbAO5QAKQ9HatKpk+E2jU=; b=WU5i0az7s04lkItnpQFgLOmTzi/nKIzQ6uKfH0ZW62EdZqxr7NaSm786vyZnGIcVPf hKa9qL3bETkqexunIVFb66E6Qxk/7i2vb2pJB+Yc/KH7dks6kpC7HDztcxeGm+6b4SpR 4KxSBC2PNuzLfxWerYYpz+UJpqFzjc2RFKu1RyJ1qXKC/+SGT8rqlXZWckM9W51Q9zqV D/kre252vIICt7nNq2CMA1Hd7rI0XfGFDY1NvG+KeADEjrrVXx/qO5XUaL7NEAM75GUs bN5UVTtH5sOw9NmTKqCbBIq8WoAv+BSqVRGuBXaMy1Tf8YazLkNJ8DJUPQ40fpTKmmKa wJRA== X-Gm-Message-State: AOAM531r24cXZIe7v2G+XPATaDoaoCBpaXHaReKggXN/emXaKETgStt8 QnY8rTVbFDcz+1zaD6JvsB+o6g== X-Google-Smtp-Source: ABdhPJzhsZ6kPNHj3Ti0TayNFxlvxcAyRChykT0uVkzBwnmqmHXKhV/PDQE3vF9jU+xnd0x29VyIRQ== X-Received: by 2002:a05:6402:c0f:: with SMTP id co15mr4579118edb.373.1616607255355; Wed, 24 Mar 2021 10:34:15 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:14 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 07/25] HID: intel-ish-hid: Fix a little doc-rot Date: Wed, 24 Mar 2021 17:33:46 +0000 Message-Id: <20210324173404.66340-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp/client.c:121: warning: Function parameter or member 'cl_device' not described in 'ishtp_cl_allocate' drivers/hid/intel-ish-hid/ishtp/client.c:121: warning: Excess function parameter 'dev' description in 'ishtp_cl_allocate' Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Lee Jones Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c index c81a1f8a92685..585a5c4066cb3 100644 --- a/drivers/hid/intel-ish-hid/ishtp/client.c +++ b/drivers/hid/intel-ish-hid/ishtp/client.c @@ -111,7 +111,7 @@ static void ishtp_cl_init(struct ishtp_cl *cl, struct ishtp_device *dev) /** * ishtp_cl_allocate() - allocates client structure and sets it up. - * @dev: ishtp device + * @cl_device: ishtp client device * * Allocate memory for new client device and call to initialize each field. * From patchwork Wed Mar 24 17:33:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161929 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EEFAC433ED for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AD9261A2E for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237238AbhCXRel (ORCPT ); Wed, 24 Mar 2021 13:34:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237242AbhCXReR (ORCPT ); Wed, 24 Mar 2021 13:34:17 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 869C4C0613E1 for ; Wed, 24 Mar 2021 10:34:17 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id h10so28530863edt.13 for ; Wed, 24 Mar 2021 10:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E7/N3FVykAR22YhzUhZ15csg3vPH/3PyPAZDl2mJTyE=; b=VxIkrCxesyL14UeRs78vWlRa0oQXxXoxEI3HDGKMmeRkyUyy62wrRUC0w+4rynV6NY Ll5Rif5st8hCJyM8cC5Uk2fs4HmA72rZFok6HzR70YSH2FDLHt+9VQ2xQh/Nys9MlSxC P+PkpKSImwmZzOg3gBSgTPm8tYQidd6bJoT35BpgZHxu1t89/h/jNmRuH8LGfqALRXNj GuXNxRk90IrloCGke9ercsKjjKupoV7R3RawwgaIqClYUTfdx3wdABc4Zi84J1zQ6ErP QsDWP1QchO8lm4ioxgoQdnPwCcYH+TXz+vrXYv8VDQtcFiTAUShLkUZ8cg1+EXS+5uj2 Lhbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E7/N3FVykAR22YhzUhZ15csg3vPH/3PyPAZDl2mJTyE=; b=WGUumVfqnRjVgj1ybRnH/brTLsFWolRtpj/kb2z+lCE2VPMpOP/KJ184ija9bgWo2c rshpQgfZGE0lGLX4E1LByD280qdfv4yrOQ8BK10l3lBAFOxbXCGAmP3Tvz4cCvWuWpCm tIohEfzuWgMAuqee/gBB636xM5r9DYTw2/EESRi5J5v8t5ICSiAhf7qppCBJ1k92gLL0 W9vOIvDRKO7lEH1KRMn3J4fdXd8JiBQCrNUyX67BjViletofa3H4pi1efDdImgHFFohu j9muh15OuePheynwmeYDW8Y/YwP2amfwsoxeSjX9OC1LYCfu/BZIFi3K0ETDMXK/Wto6 /oYw== X-Gm-Message-State: AOAM530uLEtFs8rcUwzOvVOc1goz3R1i4/SRUQBhx4B5KU84NGgSadJk AAzk/Pc82dw8QDBMg0ShX3BkOQ== X-Google-Smtp-Source: ABdhPJylv30JqRZMzBDUUnpDl1vh1UfuC6zxexY7SFcPJS3j7MrLyWiG3W7ZVfKXIThRWIH3JDu2mA== X-Received: by 2002:a50:fc94:: with SMTP id f20mr4711938edq.370.1616607256236; Wed, 24 Mar 2021 10:34:16 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:15 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Anssi Hannula , linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses Date: Wed, 24 Mar 2021 17:33:47 +0000 Message-Id: <20210324173404.66340-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'dev' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'effect_id' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'value' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: expecting prototype for value times(). Prototype was for pidff_playback() instead drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'pidff' not described in 'pidff_find_effects' drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'dev' not described in 'pidff_find_effects' drivers/hid/usbhid/hid-pidff.c:1005: warning: expecting prototype for Find the implemented effect types(). Prototype was for pidff_find_effects() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Anssi Hannula Cc: linux-usb@vger.kernel.org Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/usbhid/hid-pidff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index fddac7c72f645..ea126c50acc3b 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -505,7 +505,7 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n) HID_REQ_SET_REPORT); } -/** +/* * Play the effect with effect id @effect_id for @value times */ static int pidff_playback(struct input_dev *dev, int effect_id, int value) @@ -997,7 +997,7 @@ static int pidff_find_special_fields(struct pidff_device *pidff) return 0; } -/** +/* * Find the implemented effect types */ static int pidff_find_effects(struct pidff_device *pidff, From patchwork Wed Mar 24 17:33:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161913 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D043C433EC for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12F3C619DC for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237297AbhCXRel (ORCPT ); Wed, 24 Mar 2021 13:34:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237246AbhCXReT (ORCPT ); Wed, 24 Mar 2021 13:34:19 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9340C0613DE for ; Wed, 24 Mar 2021 10:34:18 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id dm8so28614528edb.2 for ; Wed, 24 Mar 2021 10:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7SaTEj4RTZdOjBa5WGjzyPtQsvCc3pHayG7DFxx2S1o=; b=cfvDkL+QyMuw03bMTs6Zs1dlBvGt1Szs9b0ItOn88asw3tEJ23o32vAG2nprNZIdY1 /siEXJ/WQ8IqsSQyHcx1I0iR8lM5ytepWCfZ29b/VYmt5xsuClfsffRlGXXu2Ao3HHGK /A8xxJjIyM0rcKZqZwu6XmEoTk4TTyJ2Pm/stY03leBC8SaxMY4rLiVl3GaragheVwx7 3rbUlxvMarIcrjo/mUpLDK5Z/Lg5c4WtfbXqflVOhoFvc5QFC2Xmizv/u3gsUUPRfNCj MetuLv7tHhqHdP7LNuSsWRgUoSkHggypVZdw9HUkN5rWvkx8uFyiMPZbRJ8K40dglx00 oqKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7SaTEj4RTZdOjBa5WGjzyPtQsvCc3pHayG7DFxx2S1o=; b=svY7jdGpMj0hB9NIIDIMtTPD85xYk5BBStuI3p/D5zlByzbfMnHy4xPqb2yUpb05lA Gc80Jv9Ae9r8x1XrCH6VRyZ4vCxHB4SQq8pI/n1dskrG64C5U/rxwcD2rR9yKKAaHOey 1MMwDwNlGNhmjbwxuxwyrLJ7BlFBQn66qK2/u3HI+tkYub2e6utgcvIJr16yjZyVWGMB /ER7ZdU8xnGGQ3T5pHKcmK3PK2dFFYVJU2clzslZ3q0PHZOMxr6cSc8At+/JQy67L+Pm wU+0A9OKLNHD1G/jDLMFFYE0o5Tvz3pSsI+u7toOwlAexdRGw6vSvx1NSkSQz7G18kqD OPBQ== X-Gm-Message-State: AOAM532oLQrPUSF9ArLyKOz1c4drQxCrtxwv4Jn2K13/YvmHjHdYEaLz YCvBWfeJ2coB8F25v1qDEc67IA== X-Google-Smtp-Source: ABdhPJzbP13FGjsMEuWXswh25w1dlfhwzJLC/jdccNUJbOu/BhohpWlvimC9u+JtsVmFJmWdMQLkOQ== X-Received: by 2002:a05:6402:c8:: with SMTP id i8mr4729387edu.57.1616607257536; Wed, 24 Mar 2021 10:34:17 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:17 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Henrik Rydberg , Masaki Ota , linux-input@vger.kernel.org Subject: [PATCH 09/25] HID: hid-alps: Correct struct misnaming Date: Wed, 24 Mar 2021 17:33:48 +0000 Message-Id: <20210324173404.66340-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-alps.c:113: warning: expecting prototype for struct u1_data. Prototype was for struct alps_dev instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Henrik Rydberg Cc: Masaki Ota Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 6b665931147df..2b986d0dbde46 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -74,7 +74,7 @@ enum dev_num { UNKNOWN, }; /** - * struct u1_data + * struct alps_dev * * @input: pointer to the kernel input device * @input2: pointer to the kernel input2 device From patchwork Wed Mar 24 17:33:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161921 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E5CC433F7 for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AA9A619DC for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237300AbhCXRem (ORCPT ); Wed, 24 Mar 2021 13:34:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237249AbhCXReV (ORCPT ); Wed, 24 Mar 2021 13:34:21 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7E52C0613E1 for ; Wed, 24 Mar 2021 10:34:19 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id hq27so34234846ejc.9 for ; Wed, 24 Mar 2021 10:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0mHXiyIAT3Jh+7rnIdNGX8xbXKM1ZM1Cw7hVW7vTCR8=; b=Np7Gqczcop2BAEOd5KsbvKOQIFPBBvyW4fHzsHJIWw9CZVh9CHsbDZVXATtKxFQe4X FCZOLULtAcRCBn9wftuKxPYlPRKKw3AuTm9e+FyvheDqQp0XkO6yJ25C2UFNL/PDJ145 2jx08WTp3s4SVB4VLDqFw+tSEshmMWlPQbe2T6IZCaiiYIxSKRuSaglF2LlJgyr0MCCE tED9Y59bYKPKBFa4fqdIDsNMAzpV9/JPPJnoLYkkWd4eF3tTznwA80sgSoRToN2GQEB7 rScsTfTymhFL6z29hJ+RiLjIA89Flk0EfnncTjR01q2TBpEMYZYMWHZW2i18oSTqkq/c yOJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0mHXiyIAT3Jh+7rnIdNGX8xbXKM1ZM1Cw7hVW7vTCR8=; b=DSw5F2kWz/yv+qnOutnBfFhfb7Bu+JL+Bnmb8r7k9NtBFCsRx3ERVgbLqymyP8wBMl nywnhw+ztpI7G0WjTaYEUkeLhI+6ccixU0Q+GEOotw32qWqG+Q6ZCeiNKzL+C+V6T4mf 0m0MN4IArSN1auHHO/vKgj/ZxR8r9lUPkOv7fbNfcWYhBnQ1fkdWm5Gg2LKwyjbqCrM9 HJn7v7xkeZ7sVqNpjBjSMna68litIAk1NPXiu3wGhFQUkNm1cTF+V5XqJ0i24OQIRxBR fyZDza5rvGddUGNYINvzffaRdOxIEO9pRvHQwgvctd5sx4tlZ3Rj7S6qx3YU7RvZ8J1d 7VBw== X-Gm-Message-State: AOAM532N9VSf0SgceS3f4RuqUzw6sd9jJ6zIZ/5K9DcHF8S+eTO+UeCl Ln1wRwn5RrBvQAjGMZlUZXgKBA== X-Google-Smtp-Source: ABdhPJweP98nVFVaq6z1Lu6W/z3sWDeNKQ9W/fuGYpW716/w8Y+LTsbEFyB1kmzbGXH/ejLGt9anwQ== X-Received: by 2002:a17:906:9bc5:: with SMTP id de5mr5019149ejc.284.1616607258539; Wed, 24 Mar 2021 10:34:18 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:18 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 10/25] HID: intel-ish-hid: Fix potential copy/paste error Date: Wed, 24 Mar 2021 17:33:49 +0000 Message-Id: <20210324173404.66340-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/hid/intel-ish-hid/ishtp-hid.c:11: drivers/hid/intel-ish-hid/ishtp-hid.c:263: warning: expecting prototype for ishtp_hid_probe(). Prototype was for ishtp_hid_remove() instead Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c index 393bed0abee99..14c271d7d8a94 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid.c @@ -254,7 +254,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev, } /** - * ishtp_hid_probe() - Remove registered hid device + * ishtp_hid_remove() - Remove registered hid device * @client_data: client data pointer * * This function is used to destroy allocatd HID device. From patchwork Wed Mar 24 17:33:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161925 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E7ABC43445 for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CE9461A33 for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237327AbhCXReq (ORCPT ); Wed, 24 Mar 2021 13:34:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237281AbhCXRec (ORCPT ); Wed, 24 Mar 2021 13:34:32 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC811C0613E2 for ; Wed, 24 Mar 2021 10:34:20 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id hq27so34234924ejc.9 for ; Wed, 24 Mar 2021 10:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dvVvI/0Wq9ZseHcmz0Zvsivscrc/Hml5KLcDLhGdq8Q=; b=Ukahjcp2pYWVcf0OSw8nTogJxbXbky2HnwP/sSbn6pPCP6dKZRkaxMLJUUILGQ5Lzz 6j51TlmXH+mFznwr/GhPbjxVGeOB06WAbLC74BucxOT8+YThLCrjhUTW6pVqjeVis1mz leRbrOLEWsRk+z14ugjrFolBWWQBV+eji17lQI7LETqBZFgU/W/hx8o/sAKXUudUjRVH YSGD5Ql0v1TPhibnfKvfgUaSbquq59UeTyyRWJ8+jhWU8CxiGH44BxJAX937cvBnfH49 +YHBNO2QZ+5FH+03V4vGg+z73KVVQTFCa5BSRTSMEnD24KVQP88ZRhSmGSacUapPq+TV 884Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dvVvI/0Wq9ZseHcmz0Zvsivscrc/Hml5KLcDLhGdq8Q=; b=fuoJ2bBPP2QVUQTvWxNsnDNN4CBVFhCmHVnp/8gDjAO/vpeouWub4d5qJmfQxAf6EM HFCtOO7/jkG9piWpeNodB5Sh30TK2uSI0nw4v8ZdvX70TECHahYhALR9wDZGVtZ9ies1 rz3y67yjDSENkIXMfx6J02JoteJfrKpEfdyH9mL5KnCBukIiyb9tIPYvmTdUKT0aoh6L 4o9RrD9LqtRGxUEoInfcrg5ujEoG32PYqtseI9lOPqI+pijSlPZTfjVyRXeZeBzlalU3 lMNk54QMhct6oUK2mlqhOAz89c7FJ6G6hVAEGqQwRHnTUskCBzc/JQtwkJTon8M87bUL Q13g== X-Gm-Message-State: AOAM532ELU1t8tcQe0vKlun28JZ+4IgStS9Vyyp6UT9+H8D74KfUizfm ZMVdpNxX6U0ATs0mgsaJG6qJdA== X-Google-Smtp-Source: ABdhPJw8Ct2xTGYdqYWfRhdWGor3peSqkXgdcOxKyfINiVvm40BgUlu59vvN+DDb/3CYGQA1GAUyTw== X-Received: by 2002:a17:906:a1c8:: with SMTP id bx8mr4861222ejb.381.1616607259456; Wed, 24 Mar 2021 10:34:19 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:19 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Vojtech Pavlik , Michael Haboustak , linux-input@vger.kernel.org Subject: [PATCH 11/25] HID: hid-core: Fix incorrect function name in header Date: Wed, 24 Mar 2021 17:33:50 +0000 Message-Id: <20210324173404.66340-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-core.c:2142: warning: expecting prototype for store_new_id(). Prototype was for new_id_store() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Vojtech Pavlik Cc: Michael Haboustak Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 097cb1ee31268..0ae9f6df59d10 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2129,7 +2129,7 @@ struct hid_dynid { }; /** - * store_new_id - add a new HID device ID to this driver and re-probe devices + * new_id_store - add a new HID device ID to this driver and re-probe devices * @drv: target device driver * @buf: buffer for scanning device ID data * @count: input size From patchwork Wed Mar 24 17:33:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161919 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A2CFC433F2 for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4246461A1A for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237306AbhCXRen (ORCPT ); Wed, 24 Mar 2021 13:34:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237255AbhCXReW (ORCPT ); Wed, 24 Mar 2021 13:34:22 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB00CC0613E4 for ; Wed, 24 Mar 2021 10:34:21 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id r12so34260845ejr.5 for ; Wed, 24 Mar 2021 10:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jT5mq2PVJro8RJoZfCHvbV6Psl3qGToHSXPsuh3akL8=; b=X3UPgjPgFuM1gjv4AoGn5rlNFmUuKPcJ9/K+JgE/TaEr4FikUQ2AOLnZ0f1D3dFWkO Lfo2zRYe3JZZyNjqx+TxmWJhxYrB7dpXdbjutZVeW0tthmHNzl6mrksr46tcWWnmwATF ncSS5UBWHAghGditDfEQJ6H9oLYfXOT2VtT0ifw/FZXWT/0tkSpJwlxCHTf3WwPOnITf UBUWbkec7eDKnhpM6IJ9Ehyqqlrsulsp/guBbxhRttwBQnSkj4tZvs3uuBm1A+ynrxbt tjrSIPruC3JH2YQavrW3dx3OQEb38lQyAm4AxdTjqKOT6SLFM1UwkQujLn3IcDphMxRX ePFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jT5mq2PVJro8RJoZfCHvbV6Psl3qGToHSXPsuh3akL8=; b=lzzj7vzHcdJBOXx1Yrpe22ZV/vPebXgGX8CwINo+Q3HnivKsSet/ZUz4w3+lQm7Lqk XNQeCahjEemdRWkWQXs7CLYJTuU3Av2ij+oxnaHhCdtRHmdVqUeBblY9PQT9emRd8R7B NR6wD1J5dB2kbKa6QKmxXTKw18w2TRZ4z5W8hKYo2wanLqRaIgX4j7vs8epD76zEaBne cL+LmfIr/mB10QdVJLQkrMvg3InAIkc6T2wMiSO895wZ3HXBDW/7bGLoCYUk0d4KU995 183bwLTztIjsWS4nM7bW3E8lVCBnzvEZjLNz9JssaxTgzxKIYUINxSSETFZ0vyBG8Yiw 3EQw== X-Gm-Message-State: AOAM530PVjkcEHYi7/IVT5uzU+mAyS0BUF7yCAEJN3wcQzoV8ew9K6q5 m/lcc0J5p1M9tYSvFLf18NBRZw== X-Google-Smtp-Source: ABdhPJz3o4iYoCxJd4MRAsh+biBbB2paZewNpbtr9zi3t+MfqwEdxrwnaGcNQTMLUTDZAXMe6t9Zew== X-Received: by 2002:a17:906:1182:: with SMTP id n2mr5052937eja.234.1616607260457; Wed, 24 Mar 2021 10:34:20 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:19 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Zhang Lixu , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , linux-input@vger.kernel.org Subject: [PATCH 12/25] HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in header Date: Wed, 24 Mar 2021 17:33:51 +0000 Message-Id: <20210324173404.66340-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ipc/ipc.c:553: warning: expecting prototype for ish_fw_reset_work_fn(). Prototype was for fw_reset_work_fn() instead Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Zhang Lixu Cc: "Krzysztof Wilczyński" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c index 47bbeb8b492b0..9037816e2bf74 100644 --- a/drivers/hid/intel-ish-hid/ipc/ipc.c +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c @@ -544,7 +544,7 @@ static int ish_fw_reset_handler(struct ishtp_device *dev) #define TIMEOUT_FOR_HW_RDY_MS 300 /** - * ish_fw_reset_work_fn() - FW reset worker function + * fw_reset_work_fn() - FW reset worker function * @unused: not used * * Call ish_fw_reset_handler to complete FW reset From patchwork Wed Mar 24 17:33:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161917 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F39FBC433FB for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA4D061A26 for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237310AbhCXRen (ORCPT ); Wed, 24 Mar 2021 13:34:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237070AbhCXRe0 (ORCPT ); Wed, 24 Mar 2021 13:34:26 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2AE4C0613E7 for ; Wed, 24 Mar 2021 10:34:22 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id w3so34250199ejc.4 for ; Wed, 24 Mar 2021 10:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rL2mdk6qmLyu4l9CO1LjB/Fy6Q7Estk6EutMx9RWcNQ=; b=cGfmb9Ahj4GoVdknRK5zBEm0WRV/rmSsCFJCDiQqtA6qYIzMEz1WKGh1kDUOyYxQON J3KH9Lv/o/PxeWE72TIy+zT4wy4Yqh5zR+/9F2zLduHYhpBRk7kygdVtFMEQdEuL70Z+ GebqGQtq7UCn8M6FWc385+DryjwLfMyS3ejU4qMo6qGspPGwsuB8tzUcr3f7vmedDepo s6uqVzuGZNym0/kEkc3Yj/rmDC9gNaa1oJNBFemtHcHiz3+3PeByXXq1VnHtEPoP4yyV x845RvkxhV0krjmMg5hb9q81wOkjLP02ocX7jxRG3GD7vsT/iNFWLyx4QW6IBTJ1pQTQ dVrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rL2mdk6qmLyu4l9CO1LjB/Fy6Q7Estk6EutMx9RWcNQ=; b=OGqeBADBFAA+sIRyWXQYsBaVPOigrDD2tCWdAob8PGcHyoDgDvGbgmv6ZWRw1Lr23e yq0eb5dryeQXm2GSGu2PF4MoaZXPxmVR038+VHcCEchdDNIsoUQ+dbyI9tCn8OVm2wyd 2c42G0gI/SXrxdQevqTLbI0jdZSFIVR7KS7HiMO6OMr/U78lKEEeyktsoeFszwtvjZmX fRLOeJNAwM8QKfFAFhCYby9qRvYwhVnP3zHa/GFt5o3zJo5/M1+bRMfTjNMxfs5GgE/Y SHf86pFJ+MqrDThXbvmsVGo6sDjyhwIDjv5CT//F5J4xECW2Jl2ypHjEtuVg7d3pasWV gJbA== X-Gm-Message-State: AOAM531b0V/dBSwmgY2zmMMHqA4QwZBrUe0KVUNqDL6CXbfDRNmQksaB qzGtxJYjwXLQLr+BOrZzxX1qSw== X-Google-Smtp-Source: ABdhPJwf02ng7fpjFAextXu71pHqM94bIT0ggGpD3yLNfVBOz2yVq6Lvqj/SEV4Q1l09yryl7SL5dw== X-Received: by 2002:a17:906:f896:: with SMTP id lg22mr4809036ejb.124.1616607261450; Wed, 24 Mar 2021 10:34:21 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:21 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Daniel Drubin , linux-input@vger.kernel.org Subject: [PATCH 13/25] HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() Date: Wed, 24 Mar 2021 17:33:52 +0000 Message-Id: <20210324173404.66340-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp-hid-client.c:36: warning: expecting prototype for report_bad_packets(). Prototype was for report_bad_packet() instead Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Daniel Drubin Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index 24599280105d8..042a7091802dd 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c @@ -23,7 +23,7 @@ static const guid_t hid_ishtp_guid = #define cl_data_to_dev(client_data) ishtp_device(client_data->cl_device) /** - * report_bad_packets() - Report bad packets + * report_bad_packet() - Report bad packets * @hid_ishtp_cl: Client instance to get stats * @recv_buf: Raw received host interface message * @cur_pos: Current position index in payload From patchwork Wed Mar 24 17:33:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161923 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAD21C433F4 for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 939AB61A15 for ; Wed, 24 Mar 2021 17:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237207AbhCXReo (ORCPT ); Wed, 24 Mar 2021 13:34:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237260AbhCXRe1 (ORCPT ); Wed, 24 Mar 2021 13:34:27 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5758C0613E8 for ; Wed, 24 Mar 2021 10:34:23 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id u21so16273792ejo.13 for ; Wed, 24 Mar 2021 10:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KfriQXFxUvhVGCpwETjq8GWLI1DKoZwsNAe/TYwrv1c=; b=IuGQSm9ZOkoRlOIJfQSFYzPFECEl3x3bg7hp3Q5AREVd+EhDLiDTCzl2LNWOSMW30t gx1htkH4xis3A44H8pUUpnay3+rlpTBlKtCh3NE8lTwvZy7EuPtNttqsXCST9o0h9r+0 5dC86DEnkcg1dIS8CHteR8/fT7nEKESUvlW439cTYEZ2I8GLcKsH3Mcm5k8OgKJhCYW6 YKU/oAT7O44FCeD3Z/3QAkAMP0K7rxLecHNpg/nYyUulnOGCphHyJ4UOVCDzi1cKEp4W WTb5DoBfYnd6c7WDaOUJOUPZ7zNsfYOKZ5Fd5ytilNiEPZDC7tlVwXyIt4wbPMG14DIS GQbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KfriQXFxUvhVGCpwETjq8GWLI1DKoZwsNAe/TYwrv1c=; b=PGzRr+oVT9EIy02viQPqhVaAw4GfO5VHR0yAFyGBw7kz4ZYzsVPe4w9LF01sYpyBp9 fe9F6DNMQsQmo+SQaL+wpOdF7+HcNim1K4eXFgXqMODPbVvM+szUqPhKf662RwTY2esX VN1wv+gz+c3ctTjvj4pDeNNYkaiJgpfaKnr67OeRGstqfPX3wVBLepzDpXB779iBHFT3 /p1+ALhF4wFEeFmAkBWIH7UT9J9MpKn3AUk2qN9b1yfgw3A94Mq1UVLgR4r2/+9go/xa +fFreZDyVsWu4E3uwmDu7UhgaLlA88sIMI8lQY71w7uv5W/wWIqZjo9d2KhobOoN5ZCr emCA== X-Gm-Message-State: AOAM533mLdZ2qwBPLXFBpEZTRWvOIKXQJHaAQxgPZ+3YFMojFwMUxpW8 y8CDdqfDyhNYhcwJM8lVoaYsqg== X-Google-Smtp-Source: ABdhPJzFIus/MG+W6lLos8k0at8stD86NQsJlQa6l9bHKFEG9wvE4jSPSwAB86c7XlEyc1bfasMciA== X-Received: by 2002:a17:906:b4c:: with SMTP id v12mr4966203ejg.330.1616607262431; Wed, 24 Mar 2021 10:34:22 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:22 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 14/25] HID: hid-kye: Fix incorrect function name for kye_tablet_enable() Date: Wed, 24 Mar 2021 17:33:53 +0000 Message-Id: <20210324173404.66340-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-kye.c:666: warning: expecting prototype for Enable fully(). Prototype was for kye_tablet_enable() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-kye.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c index c8b40c07eca69..f46616390a984 100644 --- a/drivers/hid/hid-kye.c +++ b/drivers/hid/hid-kye.c @@ -655,7 +655,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc, } /** - * Enable fully-functional tablet mode by setting a special feature report. + * kye_tablet_enable() - Enable fully-functional tablet mode by setting a special feature report. * * @hdev: HID device * From patchwork Wed Mar 24 17:33:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161937 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C42C43459 for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 565E361A1D for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237321AbhCXReo (ORCPT ); Wed, 24 Mar 2021 13:34:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237263AbhCXRe1 (ORCPT ); Wed, 24 Mar 2021 13:34:27 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6B3BC0613EE for ; Wed, 24 Mar 2021 10:34:24 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id u5so34252480ejn.8 for ; Wed, 24 Mar 2021 10:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NvG+DHxLWGqXLwCLHTxA35O2VaR78VX0X5hX1fU7v18=; b=HPyYRRGgq42DngHKdoEos7QCdzcGobUlfGRsMEkLTPONOCuw/ToZVKKZSNVGuLSZBw UgaPnE453P1VMWH5/ETJmqYKWGTzod2qRqHdZkBdVHgD7b9lwBPZZRSQYHBhU6wnOwLz IyydOsrIyUBajSfhvj2uBZjZLEXJIRdM8ahqu6d1wwebZDoint8OZdHq02nSa5lEMMp5 grv1EFyPVxsDcZuTFvxI5UEvsInVDJeayNsFiaGo+Kqpy9nqcYNrTpHG8Vz8JIkg7vkQ 1NJpCEXpUoeYOjdQs5fmiMuWy2h1StCCBesKCRw+2ZiQEk8FLaYgfZ/7+jUT8iNd6p4B eWbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NvG+DHxLWGqXLwCLHTxA35O2VaR78VX0X5hX1fU7v18=; b=pFQa4anZbYUVckroT3zVz9x2sepKar1cgQELnE7cFv+Ykr9HnHBbOzd2qt5EnFxtRL fiFEhU7qFQKlRJSyDY+ZFPViNy9g1XKfPdzCR2GQ3TH6oofwHQTRakaeYhN9zZ+i6TYe pvsH0+0pSHZu5PxUoNIRxrr6JilwONOwMY02tUqy1JeDK8Mv+U9s6jBl0yeWF8UgigTf Ai7LsRGCXk9jKPWoItwBcElkNwCuzZF97+11UR6pXPhXmrm7aPY8X4X0x/C5le9wBD9u ImF0d3paZmTKcEgp7zuleJ91qk4x0NnD8gNewX7pr6RkJQQ8zuncobnAFA5I9c2HycfM kdSQ== X-Gm-Message-State: AOAM533tP+Ca5sAxyRZIHmLh8KHI9R+cVkkNRHQSGc0XeP1NpzG5ob50 NetbpxWpJgtFSwCZG5mQB6vcyQ== X-Google-Smtp-Source: ABdhPJyBA3HSTenTt2vSJARLv+6C0hFj5J3+3BZROY0ANdguJmjmq6NCR/oQwpAwRRLMiiPru0sUWw== X-Received: by 2002:a17:906:f0d0:: with SMTP id dk16mr5031350ejb.48.1616607263384; Wed, 24 Mar 2021 10:34:23 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:22 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Bruno_Pr=C3=A9mont?= , Jiri Kosina , Benjamin Tissoires , "L. Vinyard, Jr" , linux-input@vger.kernel.org Subject: [PATCH 15/25] HID: hid-picolcd_core: Remove unused variable 'ret' Date: Wed, 24 Mar 2021 17:33:54 +0000 Message-Id: <20210324173404.66340-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-picolcd_core.c: In function ‘picolcd_raw_event’: drivers/hid/hid-picolcd_core.c:332:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: "Bruno Prémont" Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: "L. Vinyard, Jr" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-picolcd_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c index 1b5c63241af05..bbda231a7ce30 100644 --- a/drivers/hid/hid-picolcd_core.c +++ b/drivers/hid/hid-picolcd_core.c @@ -329,7 +329,6 @@ static int picolcd_raw_event(struct hid_device *hdev, { struct picolcd_data *data = hid_get_drvdata(hdev); unsigned long flags; - int ret = 0; if (!data) return 1; @@ -342,9 +341,9 @@ static int picolcd_raw_event(struct hid_device *hdev, if (report->id == REPORT_KEY_STATE) { if (data->input_keys) - ret = picolcd_raw_keypad(data, report, raw_data+1, size-1); + picolcd_raw_keypad(data, report, raw_data+1, size-1); } else if (report->id == REPORT_IR_DATA) { - ret = picolcd_raw_cir(data, report, raw_data+1, size-1); + picolcd_raw_cir(data, report, raw_data+1, size-1); } else { spin_lock_irqsave(&data->lock, flags); /* From patchwork Wed Mar 24 17:33:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161933 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ABBAC433FC for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18E0B61A1D for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237270AbhCXReq (ORCPT ); Wed, 24 Mar 2021 13:34:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237269AbhCXRe3 (ORCPT ); Wed, 24 Mar 2021 13:34:29 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2EB3C061786 for ; Wed, 24 Mar 2021 10:34:25 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id b7so34261747ejv.1 for ; Wed, 24 Mar 2021 10:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GplnaeoWUVj8YBA4hvKiO7ws+s2Csp6NEYWiX1mt5gw=; b=VHClLwAUzIb8iYeiAyEWXQru4R64ocooDxkmzS9YKD4aB311JjvITE3MmWSogieYag hRpDGdiOkCUTx9cPzBhC71za1sKvJ7t0ZphkRRsFrIjQPPaXz7x5AlZmRSGy1c5vhqGs kaAsZP4fqtKbuLLH7gYc83Gm+IZ7M5Icp7D/QqJrr2CmnfNtFAyyDskXEmRLAiADqw6i FqRP/52eFpkYV9FFFh/TmOdbiWypa6c/8hWLjXWw1nIlDamHHxkvrCCphAs0qnSmJfOu UPklZqyk98vshn1njj+OyITrLhuR8MTMYRWM/Kngvkc+s2vNrrPqtSzCmfZeyyI/oW8H y6og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GplnaeoWUVj8YBA4hvKiO7ws+s2Csp6NEYWiX1mt5gw=; b=sqvitEJrBljaGmNimB7vwi/H5szm6xF1LklXT2r4/eZN2Pa4C+01a3V38YtM4HPYZe CUTpOJZtuHHNFOy1vcZaGS/sFdV7ph/ueH6NHUWHtEEAtoyt3xpqqBtOTOWgLdMUBHp1 6Mm7wKzOP/FwLM5ettrywjryz2V7gUAyxzzCyRuo9svg3cK5rN0OvJ+i1FLYEOuFnRZr dOqYUy/zv8eGKg9gNv+q5VB3f5RA1EvUB4iwRIFsPRZJ0q3Msvx83/7xnxMmobu5XFAJ GEjw6CIVfpegxUCTzp5s01Pcd774psxLdt6D7jbw6vcrNks/FBx1OslHWXZmtesS7Ppi K8Rg== X-Gm-Message-State: AOAM531WJJpAud3BfFa8n522GkXta816AvrNRUZKGaL+SBYndvRypu8p tBMTidd4IBQZeEqjWzy34N0KIA== X-Google-Smtp-Source: ABdhPJyYu4OfJkDB02jrt02iTBQ1rdz4gwaiw4naFpRztIkA+MXS3Kxc9cXKU1EuXCk8F2b2bXzHmw== X-Received: by 2002:a17:906:b297:: with SMTP id q23mr4986590ejz.315.1616607264319; Wed, 24 Mar 2021 10:34:24 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:23 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Henrik Rydberg , Lopez Casado , linux-input@vger.kernel.org Subject: [PATCH 16/25] HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses Date: Wed, 24 Mar 2021 17:33:55 +0000 Message-Id: <20210324173404.66340-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'hidpp' not described in 'hidpp_send_message_sync' drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'message' not described in 'hidpp_send_message_sync' drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'response' not described in 'hidpp_send_message_sync' drivers/hid/hid-logitech-hidpp.c:275: warning: expecting prototype for and something else(). Prototype was for hidpp_send_message_sync() instead drivers/hid/hid-logitech-hidpp.c:427: warning: wrong kernel-doc identifier on line: drivers/hid/hid-logitech-hidpp.c:470: warning: Function parameter or member 'input_dev' not described in 'hidpp_scroll_counter_handle_scroll' drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'hidpp' not described in 'hidpp_touchpad_fw_items_set' drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'feature_index' not described in 'hidpp_touchpad_fw_items_set' drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'items' not described in 'hidpp_touchpad_fw_items_set' drivers/hid/hid-logitech-hidpp.c:1894: warning: expecting prototype for send a set state command to the device by reading the current items(). Prototype was for hidpp_touchpad_fw_items_set() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Henrik Rydberg Cc: Lopez Casado Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-logitech-hidpp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index d459e2dbe6474..d598094dadd0c 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -261,7 +261,7 @@ static int __hidpp_send_report(struct hid_device *hdev, return ret == fields_count ? 0 : -1; } -/** +/* * hidpp_send_message_sync() returns 0 in case of success, and something else * in case of a failure. * - If ' something else' is positive, that means that an error has been raised @@ -423,7 +423,7 @@ static inline bool hidpp_report_is_connect_event(struct hidpp_device *hidpp, (report->rap.sub_id == 0x41)); } -/** +/* * hidpp_prefix_name() prefixes the current given name with "Logitech ". */ static void hidpp_prefix_name(char **name, int name_length) @@ -454,6 +454,7 @@ static void hidpp_prefix_name(char **name, int name_length) * hidpp_scroll_counter_handle_scroll() - Send high- and low-resolution scroll * events given a high-resolution wheel * movement. + * @input_dev: Pointer to the input device * @counter: a hid_scroll_counter struct describing the wheel. * @hi_res_value: the movement of the wheel, in the mouse's high-resolution * units. @@ -1884,7 +1885,7 @@ struct hidpp_touchpad_fw_items { uint8_t persistent; }; -/** +/* * send a set state command to the device by reading the current items->state * field. items is then filled with the current state. */ From patchwork Wed Mar 24 17:33:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161927 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68837C43446 for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45A55619EC for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237263AbhCXRep (ORCPT ); Wed, 24 Mar 2021 13:34:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237270AbhCXRe3 (ORCPT ); Wed, 24 Mar 2021 13:34:29 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D385BC061788 for ; Wed, 24 Mar 2021 10:34:26 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id b7so34261840ejv.1 for ; Wed, 24 Mar 2021 10:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QyPG1WEqZFTBuDaWcANV4HkcWu30kB5AaRBOC44dMcU=; b=x34RZDCkoRcSFIBBxVgvp+zHfS6nJJrdmtFvrYSb1iqICIoh6VlPMSgqm1epY4jDhD QvZgdgquPJPb6Ry6SqX2sDNO//7WzUnOwXU41yX2Xbp7vI7bCmyC6UKbsgniS3hkiDwe 2DZRVPfs0FMdC31pWIKDHB8mOm6/GWeQ+jyknqeIT5fNY1vqtHLvGQn8L0yS6qlxrn9A QKoBS9npWrI9cw0OOkwrdhJ15m/vg5dPpCLua01KkkpDV15EsGyQJI7E3LL6zE3QT2pz VDnuKc5KOCvoFrnwOdeVB5tqJV7/3XAWFoAmnx94nvioCq/tvQjEZKe6OfhQhgoTxu1a WNuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QyPG1WEqZFTBuDaWcANV4HkcWu30kB5AaRBOC44dMcU=; b=nYyRrz+n7l7B7l/c9R8TUlqBWEmfDEQdxMIokUjOKOf1pV1z8jQz9JUeLsTNNkIdZF xBv8iRd7P224Y9vByG9lKbSGzxAkDrmWDFixjrpqFGfGTSdJAjOfvN+bKgaaPkO4XPPK C0kMb1g+uwuDOf0nlFXK92q1pFP5gPBVCUtU3lOTt6EyMlEw7+9Hb98WOzWkwj3pzKv4 Gk9zNukrYx2uuIyqmyIKfwUYHG+7FWdlj6NE+I263jUDCHyLhdq2r4itN3VJFuev5r5q X0PWZBFw1Qc3WDnwk+6XFTzTAMvLfPbG9UYxJ9Z6ayr6lS8OI0mq4mNo2epCLZAnqqw8 CNfw== X-Gm-Message-State: AOAM532yVD/BP8DvSMEGeMA+widduYaUBTU1CBFpTwmTOavH7z2nJ9vW 9BnTNuqIXj6ZfudNikTJDO3Zi4p+pDzCrA== X-Google-Smtp-Source: ABdhPJwRwrC8EEYenWLs4RGZ9Kg2dyDeJq/LMFkNo2BqT3C9pBFeEJizZTNkRQh0YmvZI4K++sB9AQ== X-Received: by 2002:a17:906:d114:: with SMTP id b20mr4911433ejz.449.1616607265313; Wed, 24 Mar 2021 10:34:25 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:24 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 17/25] HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs Date: Wed, 24 Mar 2021 17:33:56 +0000 Message-Id: <20210324173404.66340-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-uclogic-rdesc.c:645: warning: wrong kernel-doc identifier on line: Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-uclogic-rdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-uclogic-rdesc.c b/drivers/hid/hid-uclogic-rdesc.c index bf5da6de7bba9..6dd6dcd09c8bc 100644 --- a/drivers/hid/hid-uclogic-rdesc.c +++ b/drivers/hid/hid-uclogic-rdesc.c @@ -641,7 +641,7 @@ const __u8 uclogic_rdesc_pen_v2_template_arr[] = { const size_t uclogic_rdesc_pen_v2_template_size = sizeof(uclogic_rdesc_pen_v2_template_arr); -/** +/* * Expand to the contents of a generic buttonpad report descriptor. * * @_padding: Padding from the end of button bits at bit 44, until From patchwork Wed Mar 24 17:33:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161935 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D714C4345A for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C10A61A1D for ; Wed, 24 Mar 2021 17:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237331AbhCXReq (ORCPT ); Wed, 24 Mar 2021 13:34:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237274AbhCXRec (ORCPT ); Wed, 24 Mar 2021 13:34:32 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD5AAC061763 for ; Wed, 24 Mar 2021 10:34:31 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id e14so16032485ejz.11 for ; Wed, 24 Mar 2021 10:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5ncqrjTAWBMAuIT+QNk4MgUhfbKLtj8kt+uo2wlM/dg=; b=PISlI40CQm3nn/6AYfPh4VAEVaX46+vrAoFPGv+FIfCNbX/dfRhw301twvFcF1W7fp tJIZiI1/hYX5yIk8M4FF7wWW6kjhjE6qnW1AWg0BpiQ2WfxcHRiN92YdT2Al5w+8qgZI TOIeIxu7+z5JK86KZppnoQWi6aoUzAe27/XauJtm3RZE5TcoBeTV1zPaXGJbVFx1SVq9 cXpzQRQbpPs/CLRZzi8A/DR37PBtQQklruvPt3JBN53GYwHWBdtQL0S1CPqxyW9xWR+c 7LGEsPWhvyo5jil0JJA9C0QS0S4je/Ks+68bJ/U8S3LwVbMiTPp+8B9W0qD/vVM6DPa8 03pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5ncqrjTAWBMAuIT+QNk4MgUhfbKLtj8kt+uo2wlM/dg=; b=or4qOmZDw+YQaroSXmIwKVSZo8D+gfWJ446AaJ/BVlrzevCd0HHQcJBaC1+/e8Mzll p6AB9wY9SfiSNn93G+XKgGq/PlvtlmdeElSGLagSN9+3myXX+JJ0NmrzGaTISvmS0J/n N0Quv+EKFk8CU7FSIsCiVCLSrjPfgXxz4Bh3iInUHnTRSlAG8Kgz91YLG7gLIZ/UqwhA WiLDCFb3bmppyR0M+aQIedQB8zyUNJIu+ddr1dHDrSc6KxicN28uijlOrBs5F6XxZHUe ds15mr/KKVE/5GOvst5bB8PU1psNViGkliO7wV4Ro+YgZeMXVHu7s+OibF6HcdRWo9Yd UUHA== X-Gm-Message-State: AOAM532pqdzhYP77wlxzT79M5LUfVvrjsRKiymy66Druc7oe27kz1X/N GS3DWFjJ55DAq0MXqJYAKAn1VQ== X-Google-Smtp-Source: ABdhPJwoWLddMYQprFC2QnlJ4CHKIY3FK362cwfc9slhyDWW/PZ3XNOqAY34ntweYwyIWvqZBmovqw== X-Received: by 2002:a17:906:51c3:: with SMTP id v3mr4959484ejk.497.1616607270465; Wed, 24 Mar 2021 10:34:30 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:26 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Maxime Coquelin , Alexandre Torgue , Dario Pagani , Kim Kuparinen , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses Date: Wed, 24 Mar 2021 17:33:57 +0000 Message-Id: <20210324173404.66340-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-thrustmaster.c:23: warning: Incorrect use of kernel-doc format: * These interrupts are used to prevent a nasty crash when initializing the drivers/hid/hid-thrustmaster.c:26: warning: cannot understand function prototype: 'const u8 setup_0[] = ' drivers/hid/hid-thrustmaster.c:49: warning: cannot understand function prototype: 'struct tm_wheel_info ' drivers/hid/hid-thrustmaster.c:62: warning: wrong kernel-doc identifier on line: drivers/hid/hid-thrustmaster.c:84: warning: cannot understand function prototype: 'struct __packed tm_wheel_response ' drivers/hid/hid-thrustmaster.c:143: warning: wrong kernel-doc identifier on line: drivers/hid/hid-thrustmaster.c:202: warning: Function parameter or member 'urb' not described in 'thrustmaster_model_handler' drivers/hid/hid-thrustmaster.c:202: warning: expecting prototype for Called by the USB subsystem when the wheel responses to our request(). Prototype was for thrustmaster_model_handler() instead drivers/hid/hid-thrustmaster.c:265: warning: wrong kernel-doc identifier on line: Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Maxime Coquelin Cc: Alexandre Torgue Cc: Dario Pagani Cc: Kim Kuparinen Cc: linux-input@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones --- drivers/hid/hid-thrustmaster.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c index bfcd08759ba09..4f9c0642e816b 100644 --- a/drivers/hid/hid-thrustmaster.c +++ b/drivers/hid/hid-thrustmaster.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * When connected to the machine, the Thrustmaster wheels appear as * a «generic» hid gamepad called "Thrustmaster FFB Wheel". * @@ -19,7 +19,7 @@ #include #include -/** +/* * These interrupts are used to prevent a nasty crash when initializing the * T300RS. Used in thrustmaster_interrupts(). */ @@ -36,7 +36,7 @@ static const unsigned int setup_arr_sizes[] = { ARRAY_SIZE(setup_3), ARRAY_SIZE(setup_4) }; -/** +/* * This struct contains for each type of * Thrustmaster wheel * @@ -49,7 +49,7 @@ static const unsigned int setup_arr_sizes[] = { struct tm_wheel_info { uint16_t wheel_type; - /** + /* * See when the USB control out packet is prepared... * @TODO The TMX seems to require multiple control codes to switch. */ @@ -58,7 +58,7 @@ struct tm_wheel_info { char const *const wheel_name; }; -/** +/* * Known wheels. * Note: TMX does not work as it requires 2 control packets */ @@ -72,7 +72,7 @@ static const struct tm_wheel_info tm_wheels_infos[] = { static const uint8_t tm_wheels_infos_length = 4; -/** +/* * This structs contains (in little endian) the response data * of the wheel to the request 73 * @@ -82,7 +82,7 @@ static const uint8_t tm_wheels_infos_length = 4; */ struct __packed tm_wheel_response { - /** + /* * Seems to be the type of packet * - 0x0049 if is data.a (15 bytes) * - 0x0047 if is data.b (7 bytes) @@ -93,7 +93,7 @@ struct __packed tm_wheel_response struct __packed { uint16_t field0; uint16_t field1; - /** + /* * Seems to be the model code of the wheel * Read table thrustmaster_wheels to values */ @@ -122,7 +122,7 @@ struct tm_wheel { struct usb_ctrlrequest *change_request; }; -/** The control packet to send to wheel */ +/* The control packet to send to wheel */ static const struct usb_ctrlrequest model_request = { .bRequestType = 0xc1, .bRequest = 73, @@ -139,7 +139,7 @@ static const struct usb_ctrlrequest change_request = { .wLength = 0 }; -/** +/* * On some setups initializing the T300RS crashes the kernel, * these interrupts fix that particular issue. So far they haven't caused any * adverse effects in other wheels. @@ -191,7 +191,7 @@ static void thrustmaster_change_handler(struct urb *urb) hid_warn(hdev, "URB to change wheel mode seems to have failed with error %d\n", urb->status); } -/** +/* * Called by the USB subsystem when the wheel responses to our request * to get [what it seems to be] the wheel's model. * @@ -261,7 +261,7 @@ static void thrustmaster_remove(struct hid_device *hdev) hid_hw_stop(hdev); } -/** +/* * Function called by HID when a hid Thrustmaster FFB wheel is connected to the host. * This function starts the hid dev, tries to allocate the tm_wheel data structure and * finally send an USB CONTROL REQUEST to the wheel to get [what it seems to be] its