From patchwork Thu Apr 1 10:26:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yingliang X-Patchwork-Id: 12177717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E084C433B4 for ; Thu, 1 Apr 2021 10:24:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FE58610CF for ; Thu, 1 Apr 2021 10:24:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FE58610CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=N9yLJct2MOi4BfZKMR6APb5XV2Gn8JPJqFIA+el7V10=; b=ViXdh+Lq9rpsMfksazPRy+CZes TJB+K38A1QcwfmFCwqvIELaHc7ZBqjLbewtJoZd9mCwDpxl5yrtvikG7QIYGXWzqmxw8iRSle/YKz shRTNrz06vlPk5lYClpZc2uVBBWlmFM5cc4BXeNbQShCF2BeoNvjf7Y3BGyzYiNiIUb2d9Kg2ipMj w4A6Q/v5okr2t05bfd2ebW4gj+weYUirQUgULwIMkOzUDf1g25QfPQkM+crsCS1SHhCmUihF4jUnn jY57VyZbl91ZxfIMfHMYVSDgeC+VleLWx6sT2VZQPya+JhZyRCk0dshaC8TMzyP+1j3ofsIA9ZpLt sugeymTA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRuTt-009Ccf-91; Thu, 01 Apr 2021 10:23:17 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRuTj-009CaH-1L for linux-arm-kernel@lists.infradead.org; Thu, 01 Apr 2021 10:23:09 +0000 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4F9zhg3rMVzNrWR; Thu, 1 Apr 2021 18:20:19 +0800 (CST) Received: from huawei.com (10.175.103.91) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Thu, 1 Apr 2021 18:22:56 +0800 From: Yang Yingliang To: , , CC: , Subject: [PATCH -next] media: imx-pxp: remove redundant dev_err call in pxp_probe() Date: Thu, 1 Apr 2021 18:26:07 +0800 Message-ID: <20210401102607.1554006-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_112307_429103_B038ACB3 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is an error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Philipp Zabel --- drivers/media/platform/imx-pxp.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c index 08d76eb05ed1..13bc88e9358e 100644 --- a/drivers/media/platform/imx-pxp.c +++ b/drivers/media/platform/imx-pxp.c @@ -1654,11 +1654,8 @@ static int pxp_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); dev->mmio = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(dev->mmio)) { - ret = PTR_ERR(dev->mmio); - dev_err(&pdev->dev, "Failed to map register space: %d\n", ret); - return ret; - } + if (IS_ERR(dev->mmio)) + return PTR_ERR(dev->mmio); irq = platform_get_irq(pdev, 0); if (irq < 0)