From patchwork Sat Apr 10 05:00:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 12195337 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ABF9C433ED for ; Sat, 10 Apr 2021 05:04:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEBA86115B for ; Sat, 10 Apr 2021 05:04:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEBA86115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gBqAm9yO23hVhRiFAyBo+qLlqyBp2g0RFrAiUpH7h3E=; b=EaX0mMYfsEnVlMk2aH9vZfvcK nyxDgKmBfFdOVkNvqu58UnSXPpalX24HzlIn9mLWdkYoggFhqBfUkzdhOdYThNGb4M63aavepMl+o 3n2+zJt1pIEZZrGzsxb7Vd8f8fETS5jED8p9r0JMoyPLkiquyoVOgMsds96Zx5cM/2/PLT3+FLDsq P7lSrMRJ0CuQcvumQtSchFoTNtLv3H78FeoC52msqYa61/IDp2gEN9sxiA/7bWOEXzU+5Or3Hqkpe e1FRbSQHb6pcHtwG+TDvCpVPGMI5v0gyEV6pWAURx9rysbwvK1UmzwaZy8p1JoLDtDfkekEyqL0l7 6qlKArKUg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lV5l9-002AJT-Eh; Sat, 10 Apr 2021 05:02:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5kv-002AI8-1f for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 05:02:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=gk/+cUxEFhkA5Sr23xDJi6lyVwLgABo9cNglBLLd61g=; b=wvyH94DZ0EvXhUbJWC+ktHaxHf M60hVTd8FQswmUEkPTNGis5VnG+VJ7GuASoPsdQgpyrllLsd8G3N6JFVHDm21x0xn5jezw/ytkHfO zIToA82t4rGK9bjg/NP3MOgUpk54oX92tcmZygIBPwVlB2ADIvLfTX0EHmYbg8F/kHthPP98Zqej2 j8dknlKOPHBZ/yFvc7oZIuj23diO/I/SldWdoWJnskcdKW53r+87XwS412te6PTGUcMkc4OOCFvBm Snvot557AJ5KBUmMoyw0Yz069KjWHjF1eIiMMz/KeUDbnghuMvwdLBf+4e5CLt0vWlg3GOi4jweD1 nDkpw4Ag==; Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5ks-004w1N-Lg for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 05:01:59 +0000 Received: by mail-pj1-x102a.google.com with SMTP id nm3-20020a17090b19c3b029014e1bbf6c60so32218pjb.4 for ; Fri, 09 Apr 2021 22:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gk/+cUxEFhkA5Sr23xDJi6lyVwLgABo9cNglBLLd61g=; b=MHzX+bH5wAfGsTIjjMgZ8+J+KG3d/2OycnIBTrqE+sj5TI+m4n+qeglu+BSY7rzm3T wSJav4Gf2niOUp07dCN9UESr6hR3WpXQKkkNC60faX4rS7I5gkWj++iprL/Da9rxq4L0 p4fRX6PTRW8N3HZz/MdHzaZlBO1Lg4r+b2+AFjukrfmXuJJ+3mOPgBi8hh6lSr9nRiU2 hen5YX24paXB7psi3qAo+H4VpW4CJsbPujw3EoKMAByFRKiaKsKxP7eBTCJImdmdEyBm kS655LqURaDNKL+WsSrKgJ4vgofVtftfQklTVSH8Xu0L9CEpznSlhuYqFRp2hWay8Dvi L9Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gk/+cUxEFhkA5Sr23xDJi6lyVwLgABo9cNglBLLd61g=; b=m3Ep+77QrTsZ9ToP47ddgZLfQUh8XWPIQ9g54jjL6PPhvVcDE05tnHdo603GxV8fpn C6UIB6a1JoHFH7Vkv+FqdU0ngD96YUSEit7eRsRq5jpKRtRfjFIC7op2JHsmtRuCdhj2 RYieJqS8To7OUk2iFHLPmYqq49svE7CywrJlKrmOlTi4bvWZj+qpyIaBssuJAknHKhga NmkCeJVvPJwFQci8Fmy60lyGL8GseO8wpH92VtEm9hegQvQHp5sOKinGBm40J7h6Zg5/ 7wG6OVSBu78A8Bkhm+vKfZWh3aLmPIk9NxWBH853Ql78MZDBQuvL7RXdcLcfnvOoCpc0 VhWg== X-Gm-Message-State: AOAM533C4cV1nfrLhYCkrssQTAIb/lMgB7axibYUVRSA+uRQtJMyWa7Q Yt38wu0TJvaMyFdlvv2lEu0hlQ== X-Google-Smtp-Source: ABdhPJyPq0oOx2MfQ6NZ/w5udW4Rm+IrpgcyDCfR8yJ1J6lY1i5dHLanogygyBkXcCFG/6Pj5C0hyg== X-Received: by 2002:a17:90b:1e0b:: with SMTP id pg11mr17539430pjb.146.1618030917907; Fri, 09 Apr 2021 22:01:57 -0700 (PDT) Received: from localhost ([116.206.101.232]) by smtp.gmail.com with ESMTPSA id u18sm3607677pfm.4.2021.04.09.22.01.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 22:01:57 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Al Grant , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Clark Cc: Leo Yan Subject: [PATCH v3 1/6] perf arm-spe: Remove unused enum value ARM_SPE_PER_CPU_MMAPS Date: Sat, 10 Apr 2021 13:00:41 +0800 Message-Id: <20210410050046.5394-2-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210410050046.5394-1-leo.yan@linaro.org> References: <20210410050046.5394-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_220158_732079_FFDA5717 X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The enum value 'ARM_SPE_PER_CPU_MMAPS' is never used so remove it. Signed-off-by: Leo Yan --- tools/perf/util/arm-spe.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/util/arm-spe.h b/tools/perf/util/arm-spe.h index 98d3235781c3..105ce0ea0a01 100644 --- a/tools/perf/util/arm-spe.h +++ b/tools/perf/util/arm-spe.h @@ -11,7 +11,6 @@ enum { ARM_SPE_PMU_TYPE, - ARM_SPE_PER_CPU_MMAPS, ARM_SPE_AUXTRACE_PRIV_MAX, }; From patchwork Sat Apr 10 05:00:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 12195339 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7565C433B4 for ; Sat, 10 Apr 2021 05:04:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 602446115B for ; Sat, 10 Apr 2021 05:04:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 602446115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gVCW/gwc7MojJGO3mpTl+EOCynoOZIJ/VqmrdKT0NuM=; b=YeuCx0y2BScIBUt9PIibyzhzd 9Xv0/XQbW4ceIUwjQrr2nXjT65N88bGEo/rcQ18mKNQcpBqdmgFgZVMtpr9cZLUN48SES7pPa6fQk v7Wbl1aAU+I4eG/Dz+QrEnlRtOUS37ZZ6zNG+TyXBnlr20k++NaBXS1tlbPK0zsfYD0r6jtCVb6I1 lZKICkcGHW41PaFw9tg9xWrU+CsfwrCakqKlOWo9UbKf3t/YQg5dzmbu4VdYaokQn0VO2FA629JJT fo5Mdx3tiyu0T104g4pFmtJsO8aTQuKpgXjRnBgqyqQ0WafGhmO3I/EdQYTORXOgDu6Fy3MlPxyYx 74j3onwtQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lV5lN-002AKU-OX; Sat, 10 Apr 2021 05:02:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5ky-002AIn-3O for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 05:02:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Rr39OeUgAUE/zL2Re4duZZEa5vKLOQM6kQLTh7tScK8=; b=gcXuKWWGcacR+aZ06h61aqm3Rz 1BFDLWlRm/Dkiu/16wq3aGrtl6tQIkRTF7HqQ2OnLurQZ5L8no6ZTGRYgfgfuV00fbajMSZF3NX7g d5I+EMOkp5aglUxras9sVFMbP44zZQsNN5IkJWDXDMHPDK0s10shN6QQSeMUuy1Ea5UYYRslF8pJu tt0cPop28hzt2o+cVgHc+mPGN3eWB3O8lhPyaG8FdfL5f+TVqKuNMhpwBEGJ0djN8H68faERTMMpq dly0BouFbwRFpNKCc5EafUOSR4vjlx8UcKU+E6r+dc45BAWfaeQES1AgU9m40Krp0gOvt6vqFvwdp 0jd4deOQ==; Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5kv-004w1u-Jo for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 05:02:02 +0000 Received: by mail-pf1-x42f.google.com with SMTP id l123so5560306pfl.8 for ; Fri, 09 Apr 2021 22:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Rr39OeUgAUE/zL2Re4duZZEa5vKLOQM6kQLTh7tScK8=; b=mINjDvAHHVh1O4zkRj+iHdyYCFtS7jbrIGpsBxx4uKroKny8iXqjlsuIlwKLdNxMN3 xIUGM7XUqggVL7HP6NTs+ZuWvOAAq76BEEB9CaOIeOuDFuHPt4UIFapLDiCsDE698Sjc VIeNYQNozfvSTEcAELPTLrbcrCyB89B98PLE9G85o97nIbJqjttFiIwqzUkSRxasYE1z e5xRl2RRSJugMcOU86gC6o8UhU8qYI9jbVATSqERk8qe0AfWWPxw/mgv3aeUoeQrr/8F FAB1g5i1BofWJ5O5F1go3GH42uozR/YaZkN1noaa6zGZyYXgSNUpj+ECaSXygJcAGbzp p4VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Rr39OeUgAUE/zL2Re4duZZEa5vKLOQM6kQLTh7tScK8=; b=Wv+AMfluDGHDWlBCBud8Sv11BfrQxe5+sBNUwvbrbUHxC8mKfHWm4auGHpger7TF3r rmOvXKe4UisDA4dUg2alVrIe3w0lSDQMx2uBW/QkdbEq3wU00qqbt24dZhEMDLAH8+Ce zDyMHxDZZ4JJPCdkZMEv7mwarE2nZnG196Io9KU+hRP8OjAX4++kSLxnK2om+XJNY9M9 EyKMnFS6bDNEL4OvDGt/6F3+8RUmGUj6L2+h4EFbFSzz48fuVF5teN7xuYo6AmVXe2SV iTohY+4AWhIa90W9LXlnrPUc2nOO4B8271iEZv+lXVlcnErDzPwPEAix9OJVdGmk4v73 mrJg== X-Gm-Message-State: AOAM531OodpEqeY8EatQHDUS3C0KNlKJD6cgGWvb3H1iLc+kGtFg4AMo v5dkQ/hilZGyIXJwbssgFat93Q== X-Google-Smtp-Source: ABdhPJyprIBWHqiL9ovXm2yBqVIPHjJrqOrnCm0lrQTGI+6wf/QZKVn7x+eQtNILgShxMjAqc4KRyQ== X-Received: by 2002:aa7:8e0d:0:b029:214:a511:d88b with SMTP id c13-20020aa78e0d0000b0290214a511d88bmr15490846pfr.2.1618030920823; Fri, 09 Apr 2021 22:02:00 -0700 (PDT) Received: from localhost ([116.206.101.232]) by smtp.gmail.com with ESMTPSA id i9sm4214984pjh.9.2021.04.09.22.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 22:02:00 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Al Grant , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Clark Cc: Leo Yan Subject: [PATCH v3 2/6] perf arm-spe: Save clock parameters from TIME_CONV event Date: Sat, 10 Apr 2021 13:00:42 +0800 Message-Id: <20210410050046.5394-3-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210410050046.5394-1-leo.yan@linaro.org> References: <20210410050046.5394-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_220201_657659_AAA1CDEC X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org During the recording phase, "perf record" tool synthesizes event PERF_RECORD_TIME_CONV for the hardware clock parameters and saves the event into the data file. Afterwards, when processing the data file, the event TIME_CONV will be processed at the very early time and is stored into session context. This patch extracts these parameters from the session context and saves into the structure "spe->tc" with the type perf_tsc_conversion, so that the parameters are ready for conversion between clock counter and time stamp. Signed-off-by: Leo Yan --- tools/perf/util/arm-spe.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c index 2539d4baec44..b48816d5c0b4 100644 --- a/tools/perf/util/arm-spe.c +++ b/tools/perf/util/arm-spe.c @@ -26,6 +26,7 @@ #include "symbol.h" #include "thread.h" #include "thread-stack.h" +#include "tsc.h" #include "tool.h" #include "util/synthetic-events.h" @@ -45,6 +46,8 @@ struct arm_spe { struct machine *machine; u32 pmu_type; + struct perf_tsc_conversion tc; + u8 timeless_decoding; u8 data_queued; @@ -1027,6 +1030,22 @@ int arm_spe_process_auxtrace_info(union perf_event *event, spe->pmu_type = auxtrace_info->priv[ARM_SPE_PMU_TYPE]; spe->timeless_decoding = arm_spe__is_timeless_decoding(spe); + + /* + * The synthesized event PERF_RECORD_TIME_CONV has been handled + * ahead and the parameters for hardware clock are stored in + * the session context. Passes these parameters to the structure + * perf_tsc_conversion in "spe->tc", which is used for later + * conversion between clock counter and timestamp. + */ + spe->tc.time_shift = session->time_conv.time_shift; + spe->tc.time_mult = session->time_conv.time_mult; + spe->tc.time_zero = session->time_conv.time_zero; + spe->tc.time_cycles = session->time_conv.time_cycles; + spe->tc.time_mask = session->time_conv.time_mask; + spe->tc.cap_user_time_zero = session->time_conv.cap_user_time_zero; + spe->tc.cap_user_time_short = session->time_conv.cap_user_time_short; + spe->auxtrace.process_event = arm_spe_process_event; spe->auxtrace.process_auxtrace_event = arm_spe_process_auxtrace_event; spe->auxtrace.flush_events = arm_spe_flush; From patchwork Sat Apr 10 05:00:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 12195341 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E14C433ED for ; Sat, 10 Apr 2021 05:04:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE5C06115B for ; Sat, 10 Apr 2021 05:04:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE5C06115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DRkjEGcwi44ZBgLzyBAzw/nNqdK4aPTG7vIV07roNxM=; b=O5xVsLay0kVCT5i+7n7wZm5Qp x/kcPpQ+T+/YFTCcbw+EimyzTv85jWTCTu0azEg9x7NbU63Z3gaBRcEEJ5UvZ1YmjLqa4FLFP644s 8SWdDn6cKC60SaLFRTn47D7ns1lxzNe3clXn4dFI3MLTKS7XHqTJUaMKuX2eLsOFsO0jnSQenuOQG v3TLs0Hoccw+KjA5GsO1HamKOgVsvam7OLaYs51ax6cO43N8EoS9x0tVcVmlX0VfAhRrXhxtxssVT pFjg0oioJJlA8S8iebfwTfQSP+Czk3qnBhBGXis/RVGv5MhbeLx80Ty6cCAhXn8coBJ+iF5AsOdpk obC+vdLBw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lV5lc-002AN1-9G; Sat, 10 Apr 2021 05:02:44 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5l1-002AJG-KG for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 05:02:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=S2eMAvnU/VPv1tOaH24j1fTs/20qgersR7UfBpgGUfc=; b=SupUm23FQaRt2prssGmo9/6Ded lrX7TCy3J7IB9vhQm0k9908pSMmZ4QjXqrmPB/uwFaRV/FUO9uPn9SJ5OhnSKqySbxE0E8e7+5WKR jtRPHt22S4at9EtHat6w98W2L5jSTOolrFsISyL+q6PxRyrY8FSk8E1lcIDvMBDDF+AR9efomxdmN 425MNum6T68RsbefMeRWIQd30nusuN8kcmliXVfUl3vPBLpSqSlUkCBn3uD+cz30/o+PjretAu7Bj nZH9LmZJIY4eFHJCHg46lnaz/5V5o5tdZoHVm9x3YNnGEJ5IX82OW+GR3d/hAAbTv4RLUilp7zaaD z6o4auCw==; Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5kz-004w2P-79 for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 05:02:06 +0000 Received: by mail-pf1-x42e.google.com with SMTP id o123so5571102pfb.4 for ; Fri, 09 Apr 2021 22:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S2eMAvnU/VPv1tOaH24j1fTs/20qgersR7UfBpgGUfc=; b=GeWCfq8v7BKxOeZLMYA4WMw4ttCARZDuEUue4sfCkBPbzNy/Y0VbbK58tw20qjz4ol YA0CgSmlDd/lLZLavVzWqr9upF621I0KZXY6aZuw1u/LwmULAoLlWpFEGm53M129TOIG 99ce6ZNEUC2SZw4QB6YP3qqBTvQzUrPnKjnoZl4VnhseUos8vIe1xswrMBPvSuc1FFUs xjySAnINzI02vCM5rJ0q+7myQi9k+4MnL+61/AAhlyehFCEJ16ji5dWOEQ5En8e+ilb3 pSnfLTQAXXxqyo8qqquv4OpGTKPmchAvQzNTo7H67emxXtzI/l8MAW282BbcOTpEEhRk pKGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S2eMAvnU/VPv1tOaH24j1fTs/20qgersR7UfBpgGUfc=; b=Vsy+JnfNqmJdp66GuvcYIznhgNT99/dcseubVFE7pL+3HKApnNdBDrwkaL3+Nj/Ver uIur93XFndx2kYXCpjxWDo7UG4E8r2pcz319tvTu3xIoxa8cXwZdzGamt3X178Zdd0Fy ISbVEKKMI/IN18OBwtfGgNeakTnvvrf+fAWITFE2buMIjN8XT5A+AJpwoESLgU30IrYE 1W8wA0eItQ09skQqVQz3vJg5LFmm0wN8Yn2PqScBjXB90jI27BZpeUE1KtNfTqKFTQ26 ZITShsjDh2hTgAGH/TjinwEq9wNOX3KuUNxm934UtG1/WecGzzKbbSydbK4Z3IKQ0bH6 Fugg== X-Gm-Message-State: AOAM531sBhJBi2aXPJscSF1PW9dmD3Rrc4VqmaRhu7SrJR4RSHCAd2yc D8gCLfQTWPy6LCWvHodCan487w== X-Google-Smtp-Source: ABdhPJzS+S0dzrXM99O8/UPWV3kxKBMLsMGFfEVyW9mZ6F+83Vt8JVXNF3v1JCkFDeEm4SwiHBCVTQ== X-Received: by 2002:a62:db43:0:b029:244:3c4c:6b90 with SMTP id f64-20020a62db430000b02902443c4c6b90mr11294634pfg.59.1618030924319; Fri, 09 Apr 2021 22:02:04 -0700 (PDT) Received: from localhost ([116.206.101.232]) by smtp.gmail.com with ESMTPSA id w1sm4232233pgh.26.2021.04.09.22.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 22:02:03 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Al Grant , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Clark Cc: Leo Yan Subject: [PATCH v3 3/6] perf arm-spe: Convert event kernel time to counter value Date: Sat, 10 Apr 2021 13:00:43 +0800 Message-Id: <20210410050046.5394-4-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210410050046.5394-1-leo.yan@linaro.org> References: <20210410050046.5394-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_220205_264432_43C50C3C X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When handle a perf event, Arm SPE decoder needs to decide if this perf event is earlier or later than the samples from Arm SPE trace data; to do comparision, it needs to use the same unit for the time. This patch converts the event kernel time to arch timer's counter value, thus it can be used to compare with counter value contained in Arm SPE Timestamp packet. Signed-off-by: Leo Yan --- tools/perf/util/arm-spe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c index b48816d5c0b4..f66e10c62473 100644 --- a/tools/perf/util/arm-spe.c +++ b/tools/perf/util/arm-spe.c @@ -669,7 +669,7 @@ static int arm_spe_process_event(struct perf_session *session, } if (sample->time && (sample->time != (u64) -1)) - timestamp = sample->time; + timestamp = perf_time_to_tsc(sample->time, &spe->tc); else timestamp = 0; From patchwork Sat Apr 10 05:00:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 12195343 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 775D5C433ED for ; Sat, 10 Apr 2021 05:04:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F9E86115B for ; Sat, 10 Apr 2021 05:04:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F9E86115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2U8qcdCj0KsVSJi77A9UhNVOS7oZ5GXZQ6hhRGN6H4Q=; b=ldOxAGqaLKhlRwpvrVmTXh7Yn cA44Je8xQjipvncdNu6Ti22qJbLIEQgtrbAd6whmabBVztjN6HSbaJ6poFj7DP8TGPyZLUujjp43H c5KSL9lFdkDJwmSmxqkI0i/vIaoQS2itiQjKB7GCSSAg6w8iFk3NDY/LMIh0cUuUo5NrWdY6HYc+y ObH+xb54soL0RimeXL2x2P0maOavTtyk2i/l2DJpRiGAkLnzQvKo2Bo+G8aAV+cY+aRiopoWQZGpU WqmK61HmHZUcN3HfwOnnSzhtCIPTRRbnG46EikLJGBcfN56bIoo2iDX9OnYTyVpuyP76At7T/PD6G 5aXgnZNEA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lV5lq-002APC-0P; Sat, 10 Apr 2021 05:02:58 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5l4-002AJH-2g for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 05:02:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=ldonlZ9vwUBTltfCI1GiIsYf2KMOuo8USr97TAcSYMM=; b=z4xftUIuD2S4TdFga9zVptd3MM NoXJUQefi2xiIPq5TSfcyV/UPsv8XRs3os8F+f8RrqseGnUfN6QStbFSCERWcRErpJbcIkA8zMcJY gka8Oywjudjq0WUTJRCmW1RVtJh3EOGuTyDukXW7oeH+KJ0LOxV0k9oj5spAgzr/bec4Clg29TVid xum/T0nwYCOywXZwh0t4K1z9IRqQILcipCJxsZ/by1pP4srAgW781KyuOzbgAeRUIaRYp/0D29mv6 i5q3UmEtsBif5wqsxnMbZiGJ2pUSHMyv7HCzhM4Mnw6e0hBoDcDKFcV7WP+NdeTtifU+QaF29bq6W DmNsmerw==; Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5l1-004w2v-Mw for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 05:02:08 +0000 Received: by mail-pj1-x1033.google.com with SMTP id r13so102603pjf.2 for ; Fri, 09 Apr 2021 22:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ldonlZ9vwUBTltfCI1GiIsYf2KMOuo8USr97TAcSYMM=; b=bjtDPNSTZO0aYZ6szvGPFul2u9l0UGtVTr0fsrIW0qLHl+vyvUt5AdgJ28cKf18QJD EZZGou8FY0gOzpgucSM2oSKCujcH8syC6a5HJqpQqIuVG1iCO8iK0ljVohnrxNpOajP3 +PYOpKVAegAAXLDyC/HENvHS55X1rzDRjMfZ2U2f0bPCXHD/ndNskdjaz4piHxFkfo8u J32FYP2PmyW/k3Szsi+puuRDB15/e+qXZle8J3yNXW068FcdBC+U3mYzLGqO8Uxi22ks nu4Qkf/NQGupFwDfpgFN0ILKL6nVHF0bo2+ufLPA8WOgZmS41YlESNmuNANYIcUkuJbl Y+rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ldonlZ9vwUBTltfCI1GiIsYf2KMOuo8USr97TAcSYMM=; b=fPB2DuPaHthauRZS/L2aYzPuMJiPE+W9N/03ZqTCvGSfGb1V4XN+vTnYwsN22qFNFp xIGRpgvWQ6kmSbuQyO8DrJt8zxlMpTkOrBpYX0yTWpZDY+tnK8IstELnvxv85Kk7RVjC HtjQA4JvS5gWBIRV1vpUHC6clSX+LV9QAI6o3KQWuLSIjjRPvDGwoAibYEnCXhEqrT47 jS3LTJ7rFm9Enk92fz8NDT8FBKjQgb/N9GHggkVnagva9z8DteMqvsypctQ74vyB31Zm zcutlpGysBcDYcaehusqmlW3ofS2WvuZdsJY9K5Yjm69205FUd2z6z2CmGwGiKbqRi++ jtxg== X-Gm-Message-State: AOAM532oJbYYg0EqYnr87Uh0DvEviAq43frAtEoucDCYXx8/Ae0e5Nno V0NFlMuEM9A2XSdZpB1lWO6ODw== X-Google-Smtp-Source: ABdhPJyyi5ok+gdSArX8iIPD5OsC8Noiegn+PZFOSCbd3tpHsLX04I5N3GHQ3deKmp6BSCQ7+hKL0w== X-Received: by 2002:a17:902:7594:b029:e8:c21b:76aa with SMTP id j20-20020a1709027594b02900e8c21b76aamr16120415pll.37.1618030927227; Fri, 09 Apr 2021 22:02:07 -0700 (PDT) Received: from localhost ([116.206.101.232]) by smtp.gmail.com with ESMTPSA id c15sm3608092pfi.207.2021.04.09.22.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 22:02:06 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Al Grant , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Clark Cc: Leo Yan Subject: [PATCH v3 4/6] perf arm-spe: Assign kernel time to synthesized event Date: Sat, 10 Apr 2021 13:00:44 +0800 Message-Id: <20210410050046.5394-5-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210410050046.5394-1-leo.yan@linaro.org> References: <20210410050046.5394-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_220207_765365_BED699A5 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In current code, it assigns the arch timer counter to the synthesized samples Arm SPE trace, thus the samples don't contain the kernel time but only contain the raw counter value. To fix the issue, this patch converts the timer counter to kernel time and assigns it to sample timestamp. Signed-off-by: Leo Yan --- tools/perf/util/arm-spe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c index f66e10c62473..ec7df83b50fd 100644 --- a/tools/perf/util/arm-spe.c +++ b/tools/perf/util/arm-spe.c @@ -234,7 +234,7 @@ static void arm_spe_prep_sample(struct arm_spe *spe, struct arm_spe_record *record = &speq->decoder->record; if (!spe->timeless_decoding) - sample->time = speq->timestamp; + sample->time = tsc_to_perf_time(record->timestamp, &spe->tc); sample->ip = record->from_ip; sample->cpumode = arm_spe_cpumode(spe, sample->ip); From patchwork Sat Apr 10 05:00:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 12195345 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F029C433B4 for ; Sat, 10 Apr 2021 05:04:58 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11D70610CF for ; Sat, 10 Apr 2021 05:04:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11D70610CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q8GVY9xsqb9DV35nw+TmnBRqdiguQeu+XvIKIUOsYPc=; b=PL7S3njUgfEwZUmijgy6mjWfG pCbOM2bUjuWWqTzbl6+zr/f5IzNe3i7PfUYJb3YBqM0vKC2Y0M7r5SdELWoUT4+VU5ScrW4Cl8FkC yuxguhVQqZs33DUg3V3RipMNuiDqDoKl7eUlEG23bcPLT3DHBPAjxK/3EVEvz1ifyuMaRDwfTbbUS QjKHtFOZt67TD/U8qVpxOl7b5BVfXlIfy9CeMEEeaQFIG53cDW3/cz+/nqrrApdQyauo2nuFO+6xe dl0HRy+Rjll275jqdx6m/7Fca+yCvCq0z0q90M+ZkkqpjA9Aa2AJz602x06yiUF1whOmgugki22PS POKNUrdxg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lV5m1-002ARq-Ms; Sat, 10 Apr 2021 05:03:09 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5l8-002AJS-5Y for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 05:02:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Oe35wE+BbVYSlAv6bLKQWBrNW+CpBkb1nP7qyvMaXOo=; b=kQNnMulb0MVtzLgaAOIVhdIjXh DnRhr/BoolSO6g+HQRBkMUMjpUixzQlwsBuG1XOqv6qGWZNdYSF+MFHRPCZnfnRzvhXBAcvi9uMKv 2jwB1hVzAI7rYnnBA1Ly4nTQ7CBrsIiDESJZ4m18CkKSqJNUi8gT3R4ohCuyFF9Fe0mrIZy1YW7Nt poxAdT+uqP+uoUIWqmJ+yQNkbuz0DDxbXI7mn0VGL/S4BKx3KOL9f8K9AcsCmJ0KzBKOsmB41S9ve Jc9PLqoWU2xHprOqBuM7amoyLpd33sZMy8ZRCYLL5caIv4MgmUjUbCdPN2tEmxliOP47Gja5AmM2R vqLQenPw==; Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5l5-004w3S-IZ for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 05:02:12 +0000 Received: by mail-pg1-x52f.google.com with SMTP id l76so5380876pga.6 for ; Fri, 09 Apr 2021 22:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Oe35wE+BbVYSlAv6bLKQWBrNW+CpBkb1nP7qyvMaXOo=; b=dakQ+7hDI1n5d61cGeZvMd84eX85QsLx2hO+uFeKBPnbmiVnsshDUV+1ujTxrB+ObS 27ata5OTwKYpGKcNnkH7DDnZHEgUZXdMbeRoIkllbxeK2e2a5iRNksB/dchRn+fzZHIZ 90FwUQJghrprLe3oqW/j0/+ORgd1031GGlouMIAZfmlaU7jUhCRDvq17abgU2UgZ8ziw CkWnCuY9l9tWfd2bU3lq7n2Td08gtCtxr3IDdTrdtYrV0WbODywdgtR9MOq8thijUJGs RnzWkJoN7Rml8Nf+TxcdGOXnoU54aqq8aWGwptPjHqD+b4uWPiHMPrA8rGkyqMRLhmvg +jhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Oe35wE+BbVYSlAv6bLKQWBrNW+CpBkb1nP7qyvMaXOo=; b=F7uhxH0LiaQp+5j/FGqQZAGYmMtRLBtW4X67IsJHB6Rrvqe3PXwRRA62VT9l+WR3We oecY4XifPLKOdSwBiiSygcXE3l6aRLbSIIQjvfC9VF+0k/Zsi4dA2sPR5zHMV5OYyh9T Ke90ikcF5xCfNUHfrk297sNACzJPsCL9duW38aYgw0LemdUkF5tNmaA2pYW0toFwaI4T Hvd70JWuu/YvhGH+0r/kNAHV1q9ePJPAfhkDa6m7PEeK1nvC+Gg1D3NIn7Gt8OIXBFjT o195jSgeAa4jL4KmiRiy+gtAP/skPymHwtm8H2lsvgtvaqlz82lcyC1B1n5ausN2wcmy 0aAQ== X-Gm-Message-State: AOAM5310SJVL/bt043+ygxrNtxFscjjbQmWz73TsQtIHhg2dYhJYiP0W qw6e9gv3muBtrJ7wrUtFzuYInw== X-Google-Smtp-Source: ABdhPJyXSvyNZhwpBbAQW3KabH8C0q+ZCfDMdRyhi/bsjFI7/yMNIIdibN0V/+JBs2oG8luUqhJ6uA== X-Received: by 2002:a62:1757:0:b029:23e:9917:7496 with SMTP id 84-20020a6217570000b029023e99177496mr15395996pfx.51.1618030930814; Fri, 09 Apr 2021 22:02:10 -0700 (PDT) Received: from localhost ([116.206.101.232]) by smtp.gmail.com with ESMTPSA id w18sm3575933pjh.19.2021.04.09.22.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 22:02:10 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Al Grant , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Clark Cc: Leo Yan Subject: [PATCH v3 5/6] perf arm-spe: Bail out if the trace is later than perf event Date: Sat, 10 Apr 2021 13:00:45 +0800 Message-Id: <20210410050046.5394-6-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210410050046.5394-1-leo.yan@linaro.org> References: <20210410050046.5394-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_220211_631199_0B14001D X-CRM114-Status: GOOD ( 21.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It's possible that record in Arm SPE trace is later than perf event and vice versa. This asks to correlate the perf events and Arm SPE synthesized events to be processed in the manner of correct timing. To achieve the time ordering, this patch reverses the flow, it firstly calls arm_spe_sample() and then calls arm_spe_decode(). By comparing the timestamp value and detect the perf event is coming earlier than Arm SPE trace data, it bails out from the decoding loop, the last record is pushed into auxtrace stack and is deferred to generate sample. To track the timestamp, everytime it updates timestamp for the latest record. Signed-off-by: Leo Yan --- tools/perf/util/arm-spe.c | 37 ++++++++++++++++++++++++++++++++++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c index ec7df83b50fd..8facda81a06c 100644 --- a/tools/perf/util/arm-spe.c +++ b/tools/perf/util/arm-spe.c @@ -434,12 +434,36 @@ static int arm_spe_sample(struct arm_spe_queue *speq) static int arm_spe_run_decoder(struct arm_spe_queue *speq, u64 *timestamp) { struct arm_spe *spe = speq->spe; + struct arm_spe_record *record; int ret; if (!spe->kernel_start) spe->kernel_start = machine__kernel_start(spe->machine); while (1) { + /* + * The usual logic is firstly to decode the packets, and then + * based the record to synthesize sample; but here the flow is + * reversed: it calls arm_spe_sample() for synthesizing samples + * prior to arm_spe_decode(). + * + * Two reasons for this code logic: + * 1. Firstly, when setup queue in arm_spe__setup_queue(), it + * has decoded trace data and generated a record, but the record + * is left to generate sample until run to here, so it's correct + * to synthesize sample for the left record. + * 2. After decoding trace data, it needs to compare the record + * timestamp with the coming perf event, if the record timestamp + * is later than the perf event, it needs bail out and pushs the + * record into auxtrace heap, thus the record can be deferred to + * synthesize sample until run to here at the next time; so this + * can correlate samples between Arm SPE trace data and other + * perf events with correct time ordering. + */ + ret = arm_spe_sample(speq); + if (ret) + return ret; + ret = arm_spe_decode(speq->decoder); if (!ret) { pr_debug("No data or all data has been processed.\n"); @@ -453,10 +477,17 @@ static int arm_spe_run_decoder(struct arm_spe_queue *speq, u64 *timestamp) if (ret < 0) continue; - ret = arm_spe_sample(speq); - if (ret) - return ret; + record = &speq->decoder->record; + /* Update timestamp for the last record */ + if (record->timestamp > speq->timestamp) + speq->timestamp = record->timestamp; + + /* + * If the timestamp of the queue is later than timestamp of the + * coming perf event, bail out so can allow the perf event to + * be processed ahead. + */ if (!spe->timeless_decoding && speq->timestamp >= *timestamp) { *timestamp = speq->timestamp; return 0; From patchwork Sat Apr 10 05:00:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 12195347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474E3C433ED for ; Sat, 10 Apr 2021 05:05:32 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D66AE610CF for ; Sat, 10 Apr 2021 05:05:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D66AE610CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HKucDscG6dG1s0L33mwB+B9igINJrKgG4cchLy8VGiQ=; b=n4D+Ycy55tYQIymPCNy/2ea1F VddDFwluQlJECP6++TKDyplpI8yBAAJ1VuKh5U4GCe/29PHBIC/+bH77baQ4dIWZoy+XFgxWxx2rM ryvDE2QUStR5umFhMp/sW74kS34IRB6ddSjg3FYZexpU2gV4ObHZ52m2j+79mjRjCtBPdvsQzjvhN T12JhK38zd7PC3Nl9jiSnSvGcH+yScoz0dTYsugsQHwLWtBSxIdSPO6SQmNLHgAD2yMql1XKLH4Of btGy+ggExIv0GfW4Hut6HG81U5LDaw3xNeRRFYhc9MIRcvgSanLnnF/OdWjQpgRuymAi1PTdz89xX LqR5/cMtg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lV5mK-002AXp-GL; Sat, 10 Apr 2021 05:03:28 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5lA-002AJb-Sc for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 05:02:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=/FRqUqvNjs79TnDqfwRoRqULHUSQK3XkQp9fw1XE/Ss=; b=z2TVKuJ6cNFIQrd3Foi1MIOz/p vMf9oUOBiVIl4s0xfS5H9gQi8V7xtJvVupdbLsFTPO7Z9q6mrQL75Mto3mDXR35ReIN5eilUOHZL7 rPo6QaLtnjfq5RgaJmWqHEN9SgByNi8NnXgNxeccTWp/9XcUcFJFKhFrGiwYO4M3jKHEJhjK/Ppgl mLzE+YZT0B6avuYr3rMkI+GsKLQG7ffLjWgdW4+zGSZTed4/4hcRktuB5Hq8kWVtwsybFgKr4b0UQ 2nV7inzgKGc54QI/+wRA953uQyen9PJt6Yimkc4/7Ya/cBTwVyM9FQd+JhAiBq284NT73okwWkD4A sUzhyUlw==; Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV5l8-004w3z-FO for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 05:02:15 +0000 Received: by mail-pg1-x52e.google.com with SMTP id p12so5374838pgj.10 for ; Fri, 09 Apr 2021 22:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/FRqUqvNjs79TnDqfwRoRqULHUSQK3XkQp9fw1XE/Ss=; b=uLb+rAlP0rliUZ9kzB8VvMlZWsMmWz7FMZN7x1QXRzTkgffgWxG5QtRMR10sqWiuZ/ m3xOzH8wdXgp+yujnDOKeVUszCevlHvsVE6qz3EIG8ghEBNI5sm5R6BOuflfVT21wRXr y802OYRVR6Qg+7WqWMtnrC5ZX47iKttoZDh9hCERu46Ak55sHYL6PJZsXesF1InV2xBY MrH98RZ1bRgbd6HrN9XgBEkmX1R5ZpRfZkOaSPHGN0PBvFSf3VTybMONajbwgjHJtbiV ojXjkVry+/QAb/diVs0MQDZVjWgcEOtT9j0QsMpr6j+K4SKWwZXVs0MTHofzQ5G1Maer 6NyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/FRqUqvNjs79TnDqfwRoRqULHUSQK3XkQp9fw1XE/Ss=; b=QC2v+fAU/0qZsOzAQY/EA/1B9JP8tVzL2iegdDicAKYy24hr+0uQh9yvfMHzmHorRh HR1anrcdh01S1lZ/bG+F5NHqjzdp/ecJOHV4lGzqPmX3qHyEBERIf+4LzRAqIPCmOSte IRcd8a389BhhPRnwsHWPH8moHPY/u4kchflDoGLecU1GC6T56LkqBSzJMVUlzYX9uTdd DYK481Tc5PNNCfSeH+4tSiV6EBucAisH9UXu5tGF+YtgH0k76nvGH1oBpRHKtv1gfs5c 3N/1M0qfgUFRoywSJHmOWV0CuvCJ8XD51WAsnT+B9oqA4pjh1dCV+OIoZLAnrqVaxC3e LsUg== X-Gm-Message-State: AOAM532sYg4+l413wAITdD/kNYPDWy1eUfJP8l1VNWTUx3WGJOuPDZLM 6T7A4G1BfpPwjrgY5SYj+P/LVA== X-Google-Smtp-Source: ABdhPJxPDNjwlwFKTNRs6KKYQT7AO5Ydc9sRTph0uNM4ScrRD/fIuoA8TtPbGVL4lAopQ9VJidLVtw== X-Received: by 2002:a62:7917:0:b029:23f:594:e289 with SMTP id u23-20020a6279170000b029023f0594e289mr15293911pfc.1.1618030933682; Fri, 09 Apr 2021 22:02:13 -0700 (PDT) Received: from localhost ([116.206.101.232]) by smtp.gmail.com with ESMTPSA id k69sm4398112pga.45.2021.04.09.22.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 22:02:13 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Al Grant , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Clark Cc: Leo Yan Subject: [PATCH v3 6/6] perf arm-spe: Don't wait for PERF_RECORD_EXIT event Date: Sat, 10 Apr 2021 13:00:46 +0800 Message-Id: <20210410050046.5394-7-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210410050046.5394-1-leo.yan@linaro.org> References: <20210410050046.5394-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_220214_529582_DD479E10 X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When decode Arm SPE trace, it waits for PERF_RECORD_EXIT event (the last perf event) for processing trace data, which is needless and even might cause logic error, e.g. it might fail to correlate perf events with Arm SPE events correctly. So this patch removes the condition checking for PERF_RECORD_EXIT event. Signed-off-by: Leo Yan --- tools/perf/util/arm-spe.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c index 8facda81a06c..5e98a29fcbdb 100644 --- a/tools/perf/util/arm-spe.c +++ b/tools/perf/util/arm-spe.c @@ -717,11 +717,7 @@ static int arm_spe_process_event(struct perf_session *session, sample->time); } } else if (timestamp) { - if (event->header.type == PERF_RECORD_EXIT) { - err = arm_spe_process_queues(spe, timestamp); - if (err) - return err; - } + err = arm_spe_process_queues(spe, timestamp); } return err;