From patchwork Sun Nov 25 20:52:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Torsten_B=C3=B6gershausen?= X-Patchwork-Id: 10696997 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0C6081750 for ; Sun, 25 Nov 2018 20:52:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E623629A35 for ; Sun, 25 Nov 2018 20:52:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D665E29A3F; Sun, 25 Nov 2018 20:52:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7883C29A35 for ; Sun, 25 Nov 2018 20:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726145AbeKZHo0 (ORCPT ); Mon, 26 Nov 2018 02:44:26 -0500 Received: from mout.web.de ([212.227.15.3]:38815 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725863AbeKZHo0 (ORCPT ); Mon, 26 Nov 2018 02:44:26 -0500 Received: from macce.fritz.box ([195.198.252.176]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MAdrf-1gFDh11flj-00BvOI; Sun, 25 Nov 2018 21:52:28 +0100 To: Git Mailing List , szeder.dev@gmail.com From: =?utf-8?q?Torsten_B=C3=B6gershausen?= Subject: t5570 shaky for anyone ? Message-ID: <9d4e5224-9ff4-f3f8-519d-7b2a6f1ea7cd@web.de> Date: Sun, 25 Nov 2018 21:52:23 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 Content-Language: en-US X-Provags-ID: V03:K1:VL1epcWgprmllPyw26e1V7R+pFu4E/ln1KC9H3lp9bexqF2wndf GzEb/41Of9L5MfIDpB0V/PEXMYiR1bue8XUkoFimc1HZGk0hHtLgLfIjhUrCYLOtw25T2XQ CJJurcU16Gd+6UwoxBAYrHZXhNevEPLfPiCrPGKHB9YUneWsresVkz2olCy6XbJgzi9jcFT p4p67kAyvv3+tKjPsRQyg== X-UI-Out-Filterresults: notjunk:1;V03:K0:cDHHKiG3I0A=:eYWwYyyJQVeX11QLddhG4a FKffCD0NE5QnXE/qN7UKxRxwDrXM9wre+Q/tGd+BTk+Xnx6qBsmPrPMKtJ/uIPylEWbA23/PK cytGhjjeB22mDAbzTVIawwATAmmcBT63CW7x3y0r8gnxJ0kGyzkzs5LBD85u+Z9RHxFCgXanl EgF4CFC/cGr1wnjQK1BRIYJISXLx5k/6BCGonSCGH8DkY0vTBZBFjCvkKiWm1kwvl3CvPNR7l 7KUeBCL/37DcfDdHBQZ5KiC/Xt9tYeFO9NSQL30iCrr7aCG7gX6LBrobLGTJuO9qdFu0JWaZj QJ2y2Xs+8M3foaJPNWsszo4UMJ0BQ1RyyzOlSzRXAckUDmja+YagHPq2CsACT+3/tCBYpLdz0 rtKVRNMKDC+s+UTttZnZLjVSCsVdhW6idVT/N8AdNNqg3vRmig/A7/vRqr1RM92d+GQB5rBzO yQ8X78nwyisSI83lMoj1K45/xtreZTtykIxBBohpN1aG1smMa9tK3Vz6MHUEBBZjIu0scPjQb +P2hPP7xeEg7m8P1giNcklWHdk1l9516QkMQaT1QHfcKBopka3dlCFWgvRyRtECwd0rheETly IQ8lrCTfjVHfBAiAVpTuwm4Z6uQNT24+eWOFWgxUdhbrjnRUQjqJNQBrhanoROuxJNRVV+kzy rqbj9/tyBcB8Ei/O0ezSrTkKdtiyN+mmURrndZxwY2iVr62mB3YzODyjaQpbHuwY6xI7EVHlm pKVInS3etjnbG+V1jTeuJ15v2SHlR5BhdoWGEEY/Vpm5My4hEaOSnEBPjkEaR/J7nLGaXJqmB GM28die/AK/u6of+UTQw9SAnBJKtKoyNblZBpUNBXsrVYAGfGoszBVCRceuujl404mPzZMGuc 9o7VptNWFnnmKwTBK42RwrcBtRC400ooZxVZvFeTz1M+hG2WPXePlfP4GQeYWA Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After running the "Git 2.20-rc1" testsuite here on a raspi, the only TC that failed was t5570. When the "grep" was run on daemon.log, the file was empty (?). When inspecting it later, it was filled, and grep would have found the "extended.attribute" it was looking for. The following fixes it, but I am not sure if this is the ideal solution. ---------------- A slightly better approach may be to use a "sleep on demand": + ( grep -i -q extended.attribute daemon.log || sleep 1 ) && diff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh index 7466aad111..e259fee0ed 100755 --- a/t/t5570-git-daemon.sh +++ b/t/t5570-git-daemon.sh @@ -192,6 +192,7 @@ test_expect_success 'daemon log records all attributes' ' GIT_OVERRIDE_VIRTUAL_HOST=localhost \ git -c protocol.version=1 \ ls-remote "$GIT_DAEMON_URL/interp.git" && + sleep 1 && grep -i extended.attribute daemon.log | cut -d" " -f2- >actual && test_cmp expect actual '