From patchwork Thu May 6 01:04:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241377 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06BEFC433ED for ; Thu, 6 May 2021 00:35:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 735EA61185 for ; Thu, 6 May 2021 00:35:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 735EA61185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bs2ZY70HI0tRXLHd3k5v93Fj7viOZ7quu6nLb9R412g=; b=oOMiCYu+uqFb8uVLsexO8GQmT m4iEzLS4iPbEHf9CzldojFr19VEaRb8jdO41HotZ3dgaahpFJuYV5CUu1a2xBD4B+2fScEbZWLYWl neDWhtxQ+YSs0eDH2eMp4wmsZ1c7P5ZpSrhs8Pj9h8H4h86U7fBRJ9BPyl7+tM/e+5hT+LFc6ow7D ZkR+RlZYYpVH1qNWADAReKJvYnfPfc/zC9nfgeeDghnSbiVD7wy+8ixlQnABG4qgWDW8xcIZh9OSG Yfj+j77yjtInn8IqYjefMYzK2MMcgI+eXETwSh1i/mnwCTvQwBl6Axa0u8hd7VEFv53HUG9aI8qQA NZyQUSyhw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRwi-002hZR-Hq; Thu, 06 May 2021 00:32:52 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRwU-002hYN-5B for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:32:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=2sU24wCij+bCWA90Y3hrt6CYeamERlm28szKtI5l3qg=; b=fiYpMF1hv4SSpnllrnilZxkbyI hDcdNr7E+nd8zPO9I/l/lHTQMc/S8YlmwajrG5lhJeUeYfPZRL36GvyYNa8HPl5oI8bAPSFYefiCW QjKPROk8q3p9I0Mmrn+6vlVnmidZRCvvs4gU5wwqi8mmVKQf0iOi2+zsciPAE8dw9uwKDZJEHQrpq QkdgoTXHgssMRFeTMckjKkAN3dDGi35IzseFXuww+NyYZNSNhiyog2yd/qHLW6oz2SzA5WgnYc2n9 h4p0ZbfUGnE3GgRkeO2a93NB+l/nzDj857QBHuZhjXb5roiCujJnN5SLVa6CXtt52rK3MoGQ1uEk/ CYRzSflw==; Received: from mail-eopbgr20047.outbound.protection.outlook.com ([40.107.2.47] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRwR-005RBN-Mw for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:32:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c5o4+i3zxUvAMQqR5jaCCW14d5oHdu4ZZ/yfQEe7nXf5jsnqNKylWRV5Xsxl9fS3JlWcRAvgwjAqJdYGneaiGX9XyFv+PZd+AJ3R/Tw4ZXf8gBnBRyOuu0bjWt14iBFzt/0T6GcYZwmfFcoE4Yc659skEEBGTYNe4xlfb1vnPRrbDor6J6lNwZPZn4E1UHGvjINn4dOMTxs0FZIkFQwvCsEA+exGKgQUJ1LAdyLmgTMc92faVn2LbcEbTGdVAg/+dy3kz9QnRtiBetuw8Wr5zgpjo3QC3JcrPnlNIBSkQR9nQ+EjhXPm850j6liuC46bhlAGD1S22NTh22C6qqZG7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2sU24wCij+bCWA90Y3hrt6CYeamERlm28szKtI5l3qg=; b=lfnSE19wmbF+uwUhtBnNaFQFdOejsoR3hHCzjZ2Ofgv3qkJAYsaU2ixeo8J2jd51+B7Vu53+d4M03+t0b2RvDjXi6t30hAynEYU6UGKbrNpnzZbF2qndUdHBBRui7jaEzKW8Zou6D1jYc+boVmhpEglAXytTRaXW0iwmm4pEh9Q5znvHJYKWe7RRygjd1U26yr3h9S2/nrJh4FV/bGUdsjMkBJPRmWIVULD61uXG/PPGGO+ZqjUGAMYMqnpQp3deVyaiC6ZauRLcguHwYlTm3NidwgsOGPdrxSa35eS06f+PGHJD2n6TliQ58epW/CILpGOuPzxjkQKQcp2XO/KdhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2sU24wCij+bCWA90Y3hrt6CYeamERlm28szKtI5l3qg=; b=hGXtKpjXiW8jTZ7Twz+7UWLHdFqsfqarz9Q/OxSjN7FQzk86varIMqBv+CUs5zOP2N+80BeF7kEq6hHVinvKda3pm10rkD5pcrGBQIuriWUH9YOdfAcPmHhLNnJ1eH6Q+l/bVJHGDPrSb00j5+5FFTxRLVaLh4oslLMVD2Vlkv0= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB8PR04MB6714.eurprd04.prod.outlook.com (2603:10a6:10:10e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Thu, 6 May 2021 00:32:32 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:32:32 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V2 01/13] soc: imx: gpcv2: move to more ideomatic error handling in probe Date: Thu, 6 May 2021 09:04:28 +0800 Message-Id: <20210506010440.7016-2-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:32:26 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa1b76e4-455f-4456-64da-08d910266fac X-MS-TrafficTypeDiagnostic: DB8PR04MB6714: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qEGDS01sxetlKHvgOK9VKO0Vex89pkefOBt63IflfFwwYUrm4myvfmqqVyJIbdh7I3hvf6gonOmqPZ3ZJmk/Y00eo8FNWURSZ8TbnkLnqas1yDNNQNZxs6x0WkvmQ+P6H26erK4P1vo8QZ4GV2wfCEgy2XX0hAN2I6CWc/+a1lp2PzQq7zkq8JQ3Q7FPQl71EikGYEPKC2rF5W7xnRGwzNbPqB2zQX0Aty6/sm8nfqma+/GsdobI+JvlaugCJ4WPd05I0npn3lygIg2bLOZCeviCHr+Q+I9PZ0PBr1FpH3SftuO+ipsTyy33eg2HnH9aqEIJNZMUPCgmdDRZ3Lg6St34beL0g+yjslqXz/aeOT0Q8tUm6mCA0jkoPRqH3Et/wWUUWX57gr9eZV4PLuOgbe/08ysv2gR6I4earSY2uPh7/CstR+D0I8mwlqcAzQhT/TPMKFYJBl2m0VXOYM9z/YZeSFx5DSWL2GHDerv5ycYErwpgmhpkUX5dt5lVRSJrXiAcNvdoLF3b+qm+wgTHKoAZjFvxKf/hYkd2+QABFyyx1ROxSksh/WR+qrz/8Ryd88elon6z+3dbB7Xo5/D+sPmwYl6PzO8SdE9JsajOH0AfOoftXpzQGh5o2FAuwmGom/jSR+zH02CGu/kfETCTAhfTEUICjJMGeKRgQoICBek= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(52116002)(86362001)(2616005)(16526019)(83380400001)(956004)(6506007)(8936002)(5660300002)(7416002)(6512007)(6486002)(316002)(186003)(4326008)(2906002)(478600001)(26005)(1076003)(38350700002)(38100700002)(8676002)(66946007)(66476007)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: X+sxRkR3/kmdhxg61nkyUf5OhprK8RXBMfWt11uZ1tK8OqRhddnKkrW7dNZ++lPkokGMW0g054wBN2E054rUAn7zRCpzH66pFdgqKZ6eI1/uwczW4Rl6tuu6A6KUxNz+D33r3D1bLTc2mtymht7XKWlF2ye08/8Z779WH/8hSsFoOn4QBA66OQiGF4xEzbJ6FK/OWRPfqwzkyexfzWS1WhSoStW1rmzDRfVosQAKGUmhOV8xOR92xnZ32El3ZP95U+q/qttS9IBJj3AlZg9uBsGrIMRyoRKMrf12JUKes59lUlDeW8o9yWfLIsPgYWDLaBnuV/6qXbf087gcSRcE4F2nYW7nWVp9IVQe8wRHOpUvvj5Ey3Q/FESGGFIzvuuJzvCfgiEaWOumWWe+hvUHE7bpJvU9x/XDM88hTEn/P8awSJT7FN9UmqjDmnFC38JN2Ya4Wxr8xYxvVMcX30QWefAaKjmtEhfJk+HfX/zbyWrJ+NeuZsWaxkMORI3mJeNfj0j3vQlfoJdULVbNWik9MlNVSiHtM4lgMW+omAgBHRAVIx8ps9ZmT3Eh3TlXqLv60wNtMyGgWMr5EyJG33aQdAgHTBF+3yV9iqI1o7OZmhdvHq1NeX5kVH0EcXIBQ9qFTIewzROxkCL0043SDRifKRDf9v+BbDEUR3MUAcH1q3JE5bDDQShy2fQPaCF8zouyrKR0Sy8QlgvoEpdXeqv6lg81hcFwgXXmoJP8STIA8LpjGfe9iocks3CJ7DOYPA1cZ0bTFE4sX7cKKd53+gYvzuWcUCmqQgn+3HPwnhroexy+3Qusq/S2HObHAAQ5Vs/p20hJ4gtiMuB1wic/J+M1BjiyAUfrkd8XRAcVXYVzvRNO1NFo2g1JxLuvJMNw0kvu+yaCKqvTAJqHdVGj/gAJb+CsNlVmW950Y4KrCrCZrmm7ILw2Td4JtEM+3iEv0TPAFJGnWO14P0BiI3BMFdHHa+CN455HHsmL8svesydzzAES5XTiLNnYuo4JZNoY/gDt/Mtqt7NRE8oNOJj0YwCKVGvMIs5oc/dOfWz1f8wY9uPoOoON0xSCbJDZotbfkaBvjAeaebvGy5LFnQvF3oDJpanHHPbI5Hh66Sn9bLB/ZfHJqGSsrBp2WTJl3Y/FVxSjSa7F9OpfDPAE1dUE+riYk8YcgeA5P+m1bXzV2BLoFdKyY69UaYoPXN+/lNRCy3yA9XJPCrLVOavSSUo+0TDPSj5h0DRj5vnPL7n3HhA1ONAh0JUROTEYWMttu9nV80GVQAzdBe2YoiGZRKmt4+YMmWZJ0fKycLBX7rtbpohXOn9LyKqal7sp5JmPHBz6IIbm X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa1b76e4-455f-4456-64da-08d910266fac X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:32:32.1724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q9wO72W6NQMrYeB9RMCBABeUE0WcRIkvoFOH9HqcPMp6c5fUCkGX81qIUOiqjuNTScmzXlkILXqbK4BB9dWScA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6714 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173235_772632_AE9C5413 X-CRM114-Status: GOOD ( 10.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach Switch to "goto out..." error handling in domain driver probe to avoid repeating all the error paths. Reviewed-by: Marek Vasut Reviewed-by: Frieder Schrempf Tested-by: Adam Ford Signed-off-by: Lucas Stach Signed-off-by: Peng Fan --- drivers/soc/imx/gpcv2.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index db7e7fc321b1..512e6f4acafd 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -502,18 +502,23 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) ret = pm_genpd_init(&domain->genpd, NULL, true); if (ret) { dev_err(domain->dev, "Failed to init power domain\n"); - imx_pgc_put_clocks(domain); - return ret; + goto out_put_clocks; } ret = of_genpd_add_provider_simple(domain->dev->of_node, &domain->genpd); if (ret) { dev_err(domain->dev, "Failed to add genpd provider\n"); - pm_genpd_remove(&domain->genpd); - imx_pgc_put_clocks(domain); + goto out_genpd_remove; } + return 0; + +out_genpd_remove: + pm_genpd_remove(&domain->genpd); +out_put_clocks: + imx_pgc_put_clocks(domain); + return ret; } From patchwork Thu May 6 01:04:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241381 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C999C433B4 for ; Thu, 6 May 2021 00:35:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95758613E3 for ; Thu, 6 May 2021 00:35:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95758613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2sL+BHpZ+ejeWM1hnLeHFzTJr2BtlKjYtS4uSeaX3is=; b=fhzj1p2OGRBlp6nOJKCZlqHUs /6CZ1aRZ8yAzUVx5I9AOGcOjWY0CBij5nhZa+9ZtuK4NgkpLcDXd3SSpjgC4dEdiyhCSFB9gHsSGk Vo04lDxny0zkDkbEIEmxuYKlomV0/LJhexo+n8UBltsUzM6maVxdXajEnjO596KXsPPgSKwTh2+oz pxFkxHqSON63QReYsR1RM7YUCzh+UOcb3iJwCC3tLLSTaAvZ8eAcBBkwc1uMhrbip7h4+2JZVVJ6W ABZWOZrrwPcQPHEFejgHIQNBwxqgyFc4BuJ2l81OvesnzTYPHo2SoMi/n3lul4PnfBaWVKdzN5VRI nLrsWXfqw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRwt-002haP-Be; Thu, 06 May 2021 00:33:04 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRwa-002hYr-4K for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:32:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=ADvY3uwR0b4YnAaDRJ1VfVXAKRvif228LknCs1wLTJ0=; b=liZgNHGIHXtmNSoqY89cEnBpsN Qg5OTm3yiJts6VKU61hNFK6t560CBJPzNQ8EGR9xku+vxgGc4QKc8wZSeOCJ/qlaKL8fXDcsXuqxP KMtnKjaJS3xqmNHXfdswbW/RfTSBzXR8JRsLE1+QAaPB8xqFZBSfrSiEPHiFcKODDlmXpHwnrNObp 2cB+apWvh93Y5PyZhKUGt9rjvfX8sKrRGczF2vY5rxwyMCwO7qBB2rCXyhHpIGezinNNQO+Ox2BoG wdkRQaaOAYci8R+D7t56d18wJkveM2pSmn9ia9b/yU56XpnW0vJFCy/CUgqHhx01U86R2cYC19O5o 85Z+AVWw==; Received: from mail-eopbgr20056.outbound.protection.outlook.com ([40.107.2.56] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRwX-005RCf-JZ for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:32:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZADEeQdLglSaL/hYbojkXhGdtBBuV3ZLxckBqBWWD6S9ErUDBphx2pa88nEhO0ix8blVgaKeFc3i2qO+LAn9CUQHYhq9JsYUGVE0BUnJlt1/I5zfiggHw6Pu+S+QsJYD+k8T6QPOfV6YI8quWPw2j6bonxa0AQe5//YjH68mZ0xtulPNg5qPiYRBysxWcBTNkTubPLwEqh+7l0iQgQxeIy/oxWg+ANTZlnKBg2R10LTFVlQa2Emohbg8WSbrLVbbYeXcUeMMUL3DZ3FDc9tcDiPeMQBVIpVGFPvBv51a97CNCEX0RoZSbNjBLz65URZ8lN7eI+09WC88ZzpNohtSjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ADvY3uwR0b4YnAaDRJ1VfVXAKRvif228LknCs1wLTJ0=; b=VfmUv8TXd5eoXT6Wn4ypRxbKSAKzXVrN6YcD0YMu9COMOoD7eLxikhR9I7vg6n+JzJ3p9c3xMuUZSiox+sgnlVw46Hrn+ypmm3s1SAwWyQ8Fw8nLqseUXkpenspevrj+LmkTm/fbQ/eS2DYTX5xbvnVa5C6kIuHOjXw1NU83adqHARs/ExqFWKhHnbR/Z1YF2gRbkswRaBdHeFworrfvgs/lpYyFccpnRWb76+dRQxAXLasrhdYMaeNDMnNqSqRfWkOQpzEZVk/d/3o+XLU5a9P4xRxB6Suo3SjbvlVZ5ka4tvldVGWE62UNzTAj9PphjQsnm6DzueVl7ZUaNlPw/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ADvY3uwR0b4YnAaDRJ1VfVXAKRvif228LknCs1wLTJ0=; b=CSX6Sw3ITVDGlxopuMgrtU5Vf9RMyDa8LsrMatsMqGA/CNUgQURliXweRiH6gVFcqrejTAcVVAIx5XBzN05l89UT/N/v007pvsiRnqPPPY+mdWarzKf4q6yfFM9ta0mvNvXkGcnUFiqNA8OXM4skr1muIULuw//2/NXceMP6mEA= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB8PR04MB6714.eurprd04.prod.outlook.com (2603:10a6:10:10e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Thu, 6 May 2021 00:32:38 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:32:38 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH V2 02/13] soc: imx: gpcv2: move domain mapping to domain driver probe Date: Thu, 6 May 2021 09:04:29 +0800 Message-Id: <20210506010440.7016-3-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:32:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52674c07-794e-4e3b-6846-08d910267327 X-MS-TrafficTypeDiagnostic: DB8PR04MB6714: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lu2fuerzQFj8VSdi9AJuGDiirS6TmuBus/9gpJ4cClv3a8gP3D1xe0fnzzGwWrC9EXVH4XNSAFE+xgXDbWQlabmUTRlyrBUrhDwYe+3hslFMIaDnFc+WLsvZ6J4I2Twl8wo59neUUAO3lSHRWnY2t7pK9TKN5zdDJEFHBGCASQL+AQNa9/MULOF7dUX/2Jq2sfW8yz49IP8pbBo148Q6sYySa4A7K5HHFCyk7ua7KaNDt1Iu8sLFUt5PnAJj7I8qRExLKNBvmV03WNoI+AxS+63zPqq9Y4yBmrJVnc98R7jcHZovWiZk9ILACvFY17BNXoqrE9LdhoGOHYR/VYb8WJvpPRAoPjYTaJo6dJClHqa9lrp+0d4FennUQBjlOypxt73nCNNlVE/lC0eFDz1Hv2/XXRpiSCSyLKX93PpBT/WiiKJxI1CVFk2qWZSGRcX7aa6eEJrJc/mML50ArLYe6NdcnH6wX5DVkUlKRdVJbOnHtQ3AiKIHkDy1Ni/HP86Qz2IeX1arDXlHkPjuiRbJqGvzAsHVUtcqRCojCUJ3kpPytHs7n1lMaGtCb+UADsY0GknPn80VqdqnExrt2otg2d22BhtXlDeCL5amFXt8Pm1RaGn6tX7uiM2L9vb35pGvXlbkb2MXRJTyAENoU/yj6byL/mKgSB3b4gk7G5qLuYw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(52116002)(86362001)(2616005)(16526019)(83380400001)(956004)(6506007)(8936002)(5660300002)(7416002)(6512007)(6486002)(316002)(186003)(4326008)(2906002)(6666004)(478600001)(26005)(1076003)(38350700002)(38100700002)(8676002)(66946007)(66476007)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: a5olukok6RZzZYdsxBopaTnUMiVjGYp04yUOJD0zOiBZ0xFypyiAlBWjJ2b41UVyx4xIHyO6poabt0HySAxykyoQoqXBhuQ/BriOvNw3DOouWzmVwqMe51YsdopUaxMewRWOsT5Hit94PqKoTcrgGaukGqkQgzlm8KIPfnOSYC1Ml35N9WKBTfedl3nGQ5F7rb1Fp45VFR/wippKWty6PF/rglnGGe+sBYmcpoZLD0hTpkihwkF8vx5KKMh3b9NDhrpVrtpnSbbZWTgasWShJ5IvYnlx184M5qXKJ2Dcamn+k1StI8AzG4W7p0+3dqHWvznNt5Sy/c3a9HlpICM74I6HnWL+CrRppsVK0cJdIa/WkslUeaY07oTTaP3r+6UW5Z6uXqry1bhPMl41Pq3pHPTM9Hrm91OqEWNyDtGI+w0IXmTKAA4t2g8L1Fx8yf12q/Mj3cVrThNoAcn7FzdJUVbpL1pqSBPS1YuxyIpvqiZCSAF4bXJ1lOORrsZKYy/iSGigIPmZH4Ou+b7j3bnU5QzEU5BU3ZRco8/q9LTXnEfo1O+UsOlooAj9/4jKKTSDTybf9mdZNa3i64cuIEJtujmBq3x89HiX4VI3inKaQoHyhn36dH9aiY/oiyOj3ofwOmPPmkuZUvYqgna1r2ULLve8WX8BicSkYqEy2QFNelbhHnt8UF7ZpjytXB+6aQM5f3ewCbMWn85MS7qjzS+yJdXQycUBbKOjiaXgKNeyfEWOxXhYZ/e5u0L69/VjG9YnrrYPz4HtjBkanzWcVSzJyB5UlhRqCm1lZhB1HWWjWhEcuSAUCIwKVZoQN7JElfzz+9iKUUeH/Vf7M9//u0TXVTdm6HTfcAqpTwvXWjJiuke4DXVZo8h5VRHw9q8gWXVHlwy2uAe7wJMHartOk+QzN4YbH2xY/Io5nVgrs126OxDNW/dGylM1jEDu6YcUjs8V4Rhuc/zPewTuXrYp+DN0IcP47TdalTAWwnhrGELiWNHwkkRE/D4o49m/vGMMQ7JPCF5tWdPXHkhHYFqo3OFRtTN4VL+PqzV7m0bWWups8MAx3hseZt+4aEBAb14tvn81Y3enSOfsmFxlXJWSmXWFEBp8JGuqkY9w5dWbtv5CGBI50gQt+kzYDhN6p/QMnj2ae+bm54aHEarNRDHDlegx3MgBbkchbnAWylBeEd7dSGXOofPB0aqaO5UG/+yP+Z0ezY+8nfLU5HsJK7zB2wyNjbjHxOMoPs1PHHJH83G0sn5MmqeDrUjvyboQFpdxpTEp8Pl7Sg+8qRho+edL1RMhHzg0e9JmJwx9uKj4mnW/CEK1qGCya7U8w41kA3APo/Hc X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52674c07-794e-4e3b-6846-08d910267327 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:32:37.8179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xJ00Ep4Nj0LED5kc/cnI7pm8Zcz/Ir2egiBZYADXvDnmUw/+Vfej0IUUdnwKgNRy6fx0rBWsI7HapHhrpjiUVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6714 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173241_668688_153EC76A X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach As long as the power domain driver is active we want power control over the domain (which is what the mapping bit requests), so there is no point in whacking it for every power control action, simply set the bit in driver probe and clear it when the driver is removed. Reviewed-by: Frieder Schrempf Signed-off-by: Lucas Stach --- drivers/soc/imx/gpcv2.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 512e6f4acafd..552d3e6bee52 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -140,14 +140,11 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, int i, ret = 0; u32 pxx_req; - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, - domain->bits.map, domain->bits.map); - if (has_regulator && on) { ret = regulator_enable(domain->regulator); if (ret) { dev_err(domain->dev, "failed to enable regulator\n"); - goto unmap; + return ret; } } @@ -203,9 +200,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, /* Preserve earlier error code */ ret = ret ?: err; } -unmap: - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, - domain->bits.map, 0); + return ret; } @@ -499,10 +494,13 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) if (ret) return dev_err_probe(domain->dev, ret, "Failed to get domain's clocks\n"); + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, domain->bits.map); + ret = pm_genpd_init(&domain->genpd, NULL, true); if (ret) { dev_err(domain->dev, "Failed to init power domain\n"); - goto out_put_clocks; + goto out_domain_unmap; } ret = of_genpd_add_provider_simple(domain->dev->of_node, @@ -516,7 +514,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) out_genpd_remove: pm_genpd_remove(&domain->genpd); -out_put_clocks: +out_domain_unmap: + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, 0); imx_pgc_put_clocks(domain); return ret; @@ -528,6 +528,10 @@ static int imx_pgc_domain_remove(struct platform_device *pdev) of_genpd_del_provider(domain->dev->of_node); pm_genpd_remove(&domain->genpd); + + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, 0); + imx_pgc_put_clocks(domain); return 0; From patchwork Thu May 6 01:04:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE00C433B4 for ; Thu, 6 May 2021 00:35:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27DF7610FB for ; Thu, 6 May 2021 00:35:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27DF7610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J9zJTY1aW1JsGfT8cCeceqvH0aA4nrpz/EVp7Y24FAo=; b=TELxNflbMWLK7ne0TROlnYMPh Djw7HTklP3vpDqerpfHsg24MEnSygBXC7vjqoNae0KyAgACG/ynu9SMDX+ZIVn5rX2z/e7Nx+cpKk WwoCJY1v1jpsJPPZ02mrQGzgnfrtBglwvr9sVOCQXOscdOeNZelaSOw2RpliPr7YzfpiuFwhaKO9q OE61Qjf2T90/Oja2lT41cA2NwyJ7PbxShiwU21USR2yRCrcy7+kFLcLDrLoC8VwfMTrenW6PixnRE B1Uow0/09d9s492i+EdO7SxZNBToQZsFWaoPmcawnRraw3H4xUwfAT22BKrgvaeZUt9+iv93fbydI qgw2zajaA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRx9-002hcR-1c; Thu, 06 May 2021 00:33:19 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRwg-002hZN-61 for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:32:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=apTgxsDDu7MmEcc1j3aB7YJcbDuiEFS3xchs7nSKczA=; b=JOZhoEU0uZcFZNs4XLPg9gopRi t/4TI2DIpSI+Y7AkRMIf3JHC6ti2BB/Aof70z5ZCfbVJkEfpiE9AKdKASj5hlnf+q3jG7/9t7/Hkh GjKyEaptBU6BxgefozfI0uXhgdU/ZWvjzJ+zqjDw28ohuGspd6PfcFF4YR5f61s8gTObBjJTv3RWP QfwXkggY1Dqvd4KvhDfP+Tds6p85DJLX5zr3375Ozwo4OMgu8Hj9dliOrECzNzNveFsyXYZrDoQCQ 6sJOWiq2OgqbH6ArFcm903FdKVArPutck/4K2PEcdO2YricDltngQ/qWOhAnVTGFqUIv4FFukjEdO q4va9DRw==; Received: from mail-eopbgr20076.outbound.protection.outlook.com ([40.107.2.76] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRwd-005RDO-Ia for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:32:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fEPPGOli8yVX4SxOc7Luw1uXvCLyVg9cJNOwYQ7BW8LhVZi9v19qqR1lCEt250XO1Cd5oZYvb6sTv9E2PX2EQAIWULnzNSmFsgdnehElkOtapXFSKRQzsI43sO4LUC4sI5z3X9ZuZry5EkUfpjtpTOWfjG5hMNJN+Eb4E4POhQC5oqHZP31tAkZFM++KUDEYZYdywZXK0nWMbL3IzP11+f5MI7XTSqsuUZlh+dJkvTwRr51VgMlZ7Xuz4DSh6ylXfDQcBRo0k0+0r6xSww4H2hKkFYE/95CmOL1tb6TnEmu5qSjS60PzsO45aHutEs0s6ZAjUuYd/bRmIjqGKsfHpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=apTgxsDDu7MmEcc1j3aB7YJcbDuiEFS3xchs7nSKczA=; b=RloQX0x8+P7ZKIERieEikpJhgQUW/zplub5Q5UGlyxTym6ji4j+9VR+WC94TKb59xjFQy28DG9cEOW4aQzl+zsOPgNzh+kn+5INTGhNa1IhWUFnPCRR0M7FrpYkb6moWUAtT7T1Y+g7ebd4NQywOx72DdHj/soLuRIM4a4oD4dQHqiS1j7w8tohjpD/4MrsoWWCaOH3ripieRiu/xJy7xWEfR1XOw7WTPgc98qVWKFL+SFnUC/zi4QRjchMxdZnr3OYU99o7j7aBedgWG3aHV/aHQM9d/nxQQ21d2cn1y+gSqB2aehESBlHzcbljRSa5jfOhfwXPQ7vg4PYs/zIh9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=apTgxsDDu7MmEcc1j3aB7YJcbDuiEFS3xchs7nSKczA=; b=hmh1i0ilG1J56Usi/FeyAOCm6Nb7+icxXZnR7OQXYCiLqgZiIVC7k0CKVW22ilEUeC77C04YoBeLziTbCS0RlYjRF4Sw5kFlrYA4mK/N68zoddgFDg5K4j8jJqx5UuYvrA8yMZq9M3f+CBAojDTph7oToRAj1QioJv5UCIbdcyE= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB8PR04MB6714.eurprd04.prod.outlook.com (2603:10a6:10:10e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Thu, 6 May 2021 00:32:43 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:32:43 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V2 03/13] soc: imx: gpcv2: switch to clk_bulk_* API Date: Thu, 6 May 2021 09:04:30 +0800 Message-Id: <20210506010440.7016-4-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:32:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 319fef44-8fcd-4f5e-8586-08d9102676a8 X-MS-TrafficTypeDiagnostic: DB8PR04MB6714: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9qfVRVEx5RTJjucKIRwFcryt64gm46Ur0J2oDFmyAwOeFolBAw6utaAVrMiNbKqszOP7JXrnSyMBl5SGK5gYYON8IHua1ye8I6jnjNfHqHTQf240+JHHzotvwnH/V9/FPs2OsrO03XpVaiJEkpRMkdsnahzZXHZ8UBs8S/5E0kj2EqltEQrMe07VUoGhcmAirzEXY2c8esbyNmC/a73hfiBR52bm/0K2Iks2si09mBRutpEyhrrJUNP3fRc+Q2cqMJkZ1FrDTLkmwRWVupMwnDKzaTm07Plvq6HjloJdUoBIINH+nZ943q24tJesm2DcGOGoBJ01MEGOW/HmQjqhQWqKuue2C1a5OOiaWtGjaOUQQEzN3uSp+NHwmMwJASwg+xaPFTyuxsTDbv34z9gxC9uChlZgA9Vh7ENbqXtdqXM44XHSG2miuNWWJBdK9JEmoIgvfIemNlbedymiCCEMVLcq/N/9HADZRBLxhNlhTluEePkO4jdkI7NVe2lIDvf+6NKax3JqCGa12wtRCHuHRwn1Zrr589f1+a/KeYzed9wQmhBwsE1zlkl01qaEyyiYv0rn/Tyy2DKaJwYuvPEIgrcO+BjDVAYj20t6AUta+xd1ZFkCrlz8tLn8AfCxXuWeZfYW5BvYHJS548oGn2/e8BOy3klM0bdmP1DmWXWu5k4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(52116002)(86362001)(2616005)(16526019)(83380400001)(956004)(6506007)(8936002)(5660300002)(7416002)(6512007)(6486002)(316002)(186003)(4326008)(2906002)(6666004)(478600001)(26005)(1076003)(38350700002)(38100700002)(8676002)(66946007)(66476007)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: khQvWkyiFUE1bGK1YOOy7zGeMZpt9XOBpcN/15aIdUImJHiONlmrePxfhmPzyiTL7ICD6bXNUSL7QExqFaExGMr6CBk7PN2JyveA00vzdaprpaiB+dOhKwBI+w+WVQZM548IittYhi7lMAQeV4PctsU0l4AdjCXtJpBwRHyqc3hhdOKAaPfCjVLNy3J8jBNazSYTVcmwjiv341XNAPbHXVAlySf5YBw5hgMeRpBXogmqtiZ09ox8YURld6mGRWL7XxXaKPtpxCLaHF9boFa8By+gNe6il8T6EbvObGWqyOIeUOnRwIUjQY9DHSjbkJV8iRQtqWQoqr4JZByEmlikxhBdZdzMTXUr7O6W1Zm9xBJvfnbxPZFrrwgbnCbEFoeqMDoSrqQtVkNgFnzsZz5IvYPV54kEp2GIxKrN51hPqfOR5umqE6lA+mA9W1UN7jA79pbKUDsLR9y0jTAwLCDkSdHLAshwnNjLjfYQpwElxVpqs3dnUssO2T6nC+CAkVqzMowv0U/6M/eTTCXsDAdvBGRarxKjWWURuCl22/Di//8miNfthB9BkQEbJXGnFG0y9jvyZY7gz5kykuQwrlMyTNVhH3b/lV3b0sx7PTG070oo+Okrgz7jrLB7ksnJkk71u5qoZycRMmsRp/Dj6DMkc38C4l4u+0cmfluMBnOMX6G7TifQ0dkcvCj1NYK11Y/ykyjvxDqiRVHzriHEzQXst3cZju4DRg213g2SYfH10leahxAFbIR5pwhUWpaABgA74odl/jy0mrWme1RpkAtuayT2G0zoyZjHFiZj4B5GTL785f360pApx8H2vKjgvOdZoAZ5qKqYI8kjXcqNpACjUXPI3LdvAw0O/s4fOj3iaTNbyT82uxoli6wSGMr1AWOBzzHrdBn9un0tBhaFUX0c5YtvtmNmYVTxWrIpPpGwnqjmMbWteCBBJCe4MmkHxcAV1jPmVcF0CBmC+pWh9OgcF+ch1TciMYrwIK3V65Wpd6nHnakp8xcc+QMBNkRhveX5X1DegW2AcMCc5xeTxcKaNolR7RpHRSSrOYnsr9FFx2OMY//mzLn/V+IyvdmX/VcG2prWx9/N4KMNr2/5wLYHm6ucGB7byU6XY/PAIzS5W4fALvaORthZ8pv3qtsvvEiE+WIah1GgY9eMHIaM7i4TYLm96mIjOUIB1T8SFSl3BzxHFaCrrJCEjK1SEeS1zsYbdFMHcMseX7K2rB2OeWrRMedSJzOHCDHBBI9/J5+DJ4s9ijgrzs9CRbJ7wF80YLMaQy/7XTzS/ncbPE0PPd1RjXBb/i0aztxsuH49G/9xa8Q1ctYaZRGcYcZK67EOu4In X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 319fef44-8fcd-4f5e-8586-08d9102676a8 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:32:43.7142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zt7XZJr5QR16dyunlHdbcARM0CtGKt8mxoNqYCHzgold+iJFT1up/9vcMV4xB4lpR2I3SVyY9G66bGJLgy/JZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6714 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173247_640677_D5371FC1 X-CRM114-Status: GOOD ( 17.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach Use clk_bulk API to simplify the code a bit. Also add some error checking to the clk_prepare_enable calls. Signed-off-by: Lucas Stach Signed-off-by: Peng Fan Reviewed-by: Frieder Schrempf --- drivers/soc/imx/gpcv2.c | 60 +++++++++-------------------------------- 1 file changed, 12 insertions(+), 48 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 552d3e6bee52..4222b6e87e7c 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -100,13 +100,11 @@ #define GPC_PGC_CTRL_PCR BIT(0) -#define GPC_CLK_MAX 6 - struct imx_pgc_domain { struct generic_pm_domain genpd; struct regmap *regmap; struct regulator *regulator; - struct clk *clk[GPC_CLK_MAX]; + struct clk_bulk_data *clks; int num_clks; unsigned int pgc; @@ -149,8 +147,12 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, } /* Enable reset clocks for all devices in the domain */ - for (i = 0; i < domain->num_clks; i++) - clk_prepare_enable(domain->clk[i]); + ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks); + if (ret) { + dev_err(domain->dev, "failed to enable reset clocks\n"); + regulator_disable(domain->regulator); + return ret; + } if (enable_power_control) regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), @@ -187,8 +189,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, GPC_PGC_CTRL_PCR, 0); /* Disable reset clocks for all devices in the domain */ - for (i = 0; i < domain->num_clks; i++) - clk_disable_unprepare(domain->clk[i]); + clk_bulk_disable_unprepare(domain->num_clks, domain->clks); if (has_regulator && !on) { int err; @@ -438,41 +439,6 @@ static const struct imx_pgc_domain_data imx8m_pgc_domain_data = { .reg_access_table = &imx8m_access_table, }; -static int imx_pgc_get_clocks(struct imx_pgc_domain *domain) -{ - int i, ret; - - for (i = 0; ; i++) { - struct clk *clk = of_clk_get(domain->dev->of_node, i); - if (IS_ERR(clk)) - break; - if (i >= GPC_CLK_MAX) { - dev_err(domain->dev, "more than %d clocks\n", - GPC_CLK_MAX); - ret = -EINVAL; - goto clk_err; - } - domain->clk[i] = clk; - } - domain->num_clks = i; - - return 0; - -clk_err: - while (i--) - clk_put(domain->clk[i]); - - return ret; -} - -static void imx_pgc_put_clocks(struct imx_pgc_domain *domain) -{ - int i; - - for (i = domain->num_clks - 1; i >= 0; i--) - clk_put(domain->clk[i]); -} - static int imx_pgc_domain_probe(struct platform_device *pdev) { struct imx_pgc_domain *domain = pdev->dev.platform_data; @@ -490,9 +456,10 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) domain->voltage, domain->voltage); } - ret = imx_pgc_get_clocks(domain); - if (ret) - return dev_err_probe(domain->dev, ret, "Failed to get domain's clocks\n"); + domain->num_clks = devm_clk_bulk_get_all(domain->dev, &domain->clks); + if (domain->num_clks < 0) + return dev_err_probe(domain->dev, domain->num_clks, + "Failed to get domain's clocks\n"); regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, domain->bits.map); @@ -517,7 +484,6 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) out_domain_unmap: regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, 0); - imx_pgc_put_clocks(domain); return ret; } @@ -532,8 +498,6 @@ static int imx_pgc_domain_remove(struct platform_device *pdev) regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, 0); - imx_pgc_put_clocks(domain); - return 0; } From patchwork Thu May 6 01:04:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241385 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5342AC433ED for ; Thu, 6 May 2021 00:35:56 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1D5C610FB for ; Thu, 6 May 2021 00:35:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1D5C610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DeYsGbsXGC36QEyi8LQPaWAVXIoxiMeBHljoOCHLk4M=; b=PNMrM55JqxHExh2hENMy0tGoy f2bm1X9ZmNXNmr0ofuVsMBJNxMgTbv6+uqPdV3oyQblXYCUqTi1DbROxyEW21LwAkudl+Bahdu68u B4SVmhZ9gWtxjKfDo0cKNg6Jnhpw77jGZmNAAqiDCMpy2ObaFDtGS3bOIyJX/x3GUMem2idN+7Z4z gdSk7j7SZoIUQ1jsOwTZGme84q0W6VVGLmzksKxoYzgHxzy/CDdRk+PpEZAbdUILnaxOg35uwEi/x 4cYHylfGa3MJE1xnwVzSpQ/qCSMJAMBPW1YEiMXhnhwaNPzt90fIIKCg3xgXqA2VEqOeHalpTDFYn iEUXn70oQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRxL-002heH-6y; Thu, 06 May 2021 00:33:31 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRwm-002hZn-9h for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:32:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=0mZ6vcOiimt4RdacuwvqYWbCLBRHliQj+5FIXt7LMJQ=; b=cah6YfRZ6XM1Pg9mhDtC9brzEX uSeCONeOe2x09G+HPCzPQHfYrjgRVq8G/ZRWRFOQhdgBSKGiF71hTB6qJoRjDVF18AwbjGH8zy5fh XGlTZ9Jyt794GtzF3OkNlLCLCXUjVpgIMMwA59UKIpKFDSpaz6mUe2gpIfv/aDmYEWM9FYzFMEwAi VcSg9VvA+PTkgvPD3u2XzNGvzM9aAR4ql+7xZn+c7zutwx1KwxOUrxmaOAFQ+rULaVqeulW9UiWNm KlhgZ8LzD6DK0PUeZ47UbBzy07WlpThSgp8YZFdjmxEGbSKsjRl719bhmXLJfdbBYG+B6X9ZWr8gl PaKj7C+A==; Received: from mail-eopbgr20065.outbound.protection.outlook.com ([40.107.2.65] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRwj-005RDu-Es for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:32:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XN3KD0jnvWfypqQxnZLlIx7cNq98SW3Zq7hETIXzZzWkv5lqwViaqJPp1teawOXBvD11Cztf6OIXOGSy14m44l9tMlJY6QkUdGt1DikNNdXFxVSx3seipBU1QCSIOu55mRdG6ezjZxOMmT/2zzFJWBgZSdbiAhnJxzvmYKpA7xOMefbxeo/CeJL49njjUGKLxW9FzjupzNzeI1cJRqVVzj2+HtmLtERdkgBm+M8zbIf7KIHX2XGuAwFM0XyNFTy7iqr9Mu6q3W7ExHTn7HfUPAU+0A9uykWu8a9YrLUWbi7IwbU25fI37bi3l64Rw2Dx4UfUDX4n4sDLyO9q3AGEVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0mZ6vcOiimt4RdacuwvqYWbCLBRHliQj+5FIXt7LMJQ=; b=bVb9HwCLRhDjChB7uzAswUghJw9BgXTHPwMumezpWFEVt0E2MviVEaMQdMcWLn/P+9FmKSCJJqbd8IAEneakxf/VM4MH4Mw4HrDB9RjSayZkJ2MOyVfVTUD2h6CxPW+Obco7dQbG5mDcccYOexg0eH8g9uGR5KZFRzMh4dNs6xJymxEtojhttuRbQUsPwlIu3iZfUsz/OVS6Gh0NWXwk9+oCtJoASCeuFvZX6j0pc1klkM2LN+fvgwKhctqnjY0UpwXbyxacrO2pQXEWUkbPHyEHs2XumMnoQJPaQVzc5s1aAcRorq/6nLjE3DI4h+ihVO1CeaZRCYAh/9w8+MFyEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0mZ6vcOiimt4RdacuwvqYWbCLBRHliQj+5FIXt7LMJQ=; b=K6h5fGUo+TFtYzvea+/uhQBgoQy7O66YA19CsJV/4pv/Qgqc3F/RhxbaGf5rPX/cnzYNu9AR6ZyhvsxPtfvrEo9/lF0nXqt6rPTCNJe7JgMckrNjS3zCOwm8qnuxoRdfJwDLrGIC8A6Mq4blz27bT2VJh8aZIuQ711BVuL7eDr0= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB8PR04MB6714.eurprd04.prod.outlook.com (2603:10a6:10:10e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Thu, 6 May 2021 00:32:49 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:32:49 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V2 04/13] soc: imx: gpcv2: split power up and power down sequence control Date: Thu, 6 May 2021 09:04:31 +0800 Message-Id: <20210506010440.7016-5-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:32:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e58bcc7-f08d-447b-2929-08d910267a2b X-MS-TrafficTypeDiagnostic: DB8PR04MB6714: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KzUs41WO6iqCsIGvcffJ+lrSMR1VX2vWlnvtWDLLsUlEq90MJYrmMajtcBVAxrv+zVrjvIpujbDXJAhvHwJ6NK6xycpINrdLYs5uGxGuswcUcDzi0L0kiU4tYTr6sfa9fws86SwOM5J11EfBDKs+aWMksxKWl5Sldir/sJDydcCDOPDw4ZGuD9xfRQkD0508drZEerNowdjZ8Sy376lkje+81ESBvlU+LcRBsyf8zKptf6qXlelwvbWkuYUYX4md80WJZNU56qJ9Ny1yGE/JVuCBb9KD7eIo3SCj7s7srz+2diZF8dSocmt4ckQQmEPo/nIvCqfV76ODEinXwqKHEyiwTHmr0FDqBDYRA6QNzBQpa8J9liNnd8jGO3lXsjifDKbI4fGpyvKn6MIEidZQOy9o5v5WFpHdc4t5beY2laVmGEYL/JLUKHMWpoR57rI5QldrN8VQDOHph5RKJzV6WVXmvVU9ndIxWOG5e4rEn6UOvehtc4y7yG90uGgJmMYNW6tib+PCC3BDYoSkeoipEv3mcCTFfnd+Tswn9s/OglLWKIz7W/OJX31RWwC7C1L0EMJzzqjb57yo984tAIsaQtkcBTmiim6IbOnth/v2R8cyoer8GfL0bVb447V0jtKyF5sZ0yPvLcXXaeSF8zQWLHrJ42UQpGU2deaCW4ODNLI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(52116002)(86362001)(2616005)(16526019)(83380400001)(956004)(6506007)(8936002)(5660300002)(7416002)(6512007)(6486002)(316002)(186003)(4326008)(2906002)(6666004)(478600001)(26005)(1076003)(38350700002)(38100700002)(8676002)(66946007)(66476007)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: vVbE5KaEvxZluLV53FETNKlQwMbi3mlcUHzgI+R4LMnEkb5lxfyxv5E8XJ7Vg09QJXjEeBLiGeERPKYojVKBzdIkGrJ5wghcSvRAfyQLFpIGIxT2ee5U8rNPNvdAemiFL2W7FB20mnxRH9ZmD2h8yqJ09owiVTIL6kUDA3M00AGp8CNXnU1JnREjpLQeK7/zRjC6aeuWP4aLheAPEI1hBFlf541fqcC3ff+Q4oTr/97ITDKTG1t5Sc7KYuN39bOe8Q7Cne1K5O64ibUodiRQG5giR4EhxmWZ5JKCT+eYO7crKEVq+Y6GqEbaUGPIXekLe4LPgBPuEfktwN24wM8NDOLia3m3EqXUYfWazoTIQoKKBKCX+lcDoVkv2jlnLmH+gWMtU55VH/sSfBIW7ICB8wDgiLqLiw4seiX8cDf8vEXgn0Gf2biSjLGitgy6WvxOKbpPPc5FIg1U3L6icy2BjdxTWdKZEv3Jh775xxZGQICK/IGtUbnGou+EKvr78UUB1pJQZ1rI6WPgCsBHWtAwbsFFFgrSVV9ZMViLL6FI3w6swpUocYkyQJUO14fOISc88ZqvQNzINKi0QvI7G6Ls2sUISkwJiTPfY4ArSBHEOZKiMGwSp9FquoJ8nV+F5EHQyLWzjRda68LXm9sudmixL34paay1jTWHlAeKtg8dn7oRJzygaLX3H9wpm4OanmMpC8lQzlzlvZZAwgEYldf8sAR1E4gWOX3es5/bpgtKsNKUITyzToa3FgmtugNwFjOA0+D0fq5QxD5hlj/MCzpsJFlRBPVLcEm8ze2WPMk5i3tviPcuxwluo/2Ep6cJAS1eZO4im/yjNGerdqG0brbYf9STbssZC3/KJ7ZRtgm2N9Ni662HtRtUYQlpROTb2dWIxrzsim4L2EZ5jQ/Axnn3YK1H74CvjlAKvRWaav07cAshQfhazkJxIvvHbXG4Z9DxCdzXEVKcijQKscbCMKtK6yXYbXSggMWlzg/BIf0syK+3Gp3xYFhtIckA2q2/aE8I+/pLYgpwe1oDdi2Gc5cfmyRsozDcQ1ZkU4h1vH8g0N+sDlOx0G7kbdn3n93IxRphxktiq0IxbYM+YI6LYuPjAhyqQ6mouX5E4qwElisMdXIIq2gfM11nHN5qOpDZN9TWmPdfwKSWOVDXWlGHuHMjCj3ruFALaPtmUadrybP2SxxwG1aRF+hEc4KbvAMmkeJFLHfICahJq6b8CsMI5oa8Gey87xJ69obvYl9+xTncGhZXG53pUzYHHVgRW9wTTe+hUr6Y4waZNtZdn6yHCUM+nMHSi/ErcOJ2/qwfMYBDP/ud7avw9/bCt74yLAS+OGOk X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e58bcc7-f08d-447b-2929-08d910267a2b X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:32:49.5825 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7TPKqiIG8HB7ta0vUMlFdXHZW/j3dR+jN9TfmP8wz/0BvWtQraf/qIg5q8nd7M8HdQ9xfjvhF7GuGXaMucdFWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6714 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173253_531418_343BE081 X-CRM114-Status: GOOD ( 23.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach The current mixed function to control both power up and power down sequences is very hard to follow and already contains some sequence errors like triggering the ADB400 handshake at the wrong time due to this. Split the function into two, which results in slightly more code, but is way easier to get right. Signed-off-by: Lucas Stach Signed-off-by: Peng Fan Reviewed-by: Frieder Schrempf --- drivers/soc/imx/gpcv2.c | 141 ++++++++++++++++++++++++---------------- 1 file changed, 86 insertions(+), 55 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 4222b6e87e7c..bcf1f338b0bf 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -125,20 +125,19 @@ struct imx_pgc_domain_data { const struct regmap_access_table *reg_access_table; }; -static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, - bool on) +static inline struct imx_pgc_domain * +to_imx_pgc_domain(struct generic_pm_domain *genpd) { - struct imx_pgc_domain *domain = container_of(genpd, - struct imx_pgc_domain, - genpd); - unsigned int offset = on ? - GPC_PU_PGC_SW_PUP_REQ : GPC_PU_PGC_SW_PDN_REQ; - const bool enable_power_control = !on; - const bool has_regulator = !IS_ERR(domain->regulator); - int i, ret = 0; - u32 pxx_req; - - if (has_regulator && on) { + return container_of(genpd, struct imx_pgc_domain, genpd); +} + +static int imx_pgc_power_up(struct generic_pm_domain *genpd) +{ + struct imx_pgc_domain *domain = to_imx_pgc_domain(genpd); + u32 reg_val; + int ret; + + if (!IS_ERR(domain->regulator)) { ret = regulator_enable(domain->regulator); if (ret) { dev_err(domain->dev, "failed to enable regulator\n"); @@ -150,69 +149,101 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks); if (ret) { dev_err(domain->dev, "failed to enable reset clocks\n"); - regulator_disable(domain->regulator); - return ret; + goto out_regulator_disable; } - if (enable_power_control) - regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), - GPC_PGC_CTRL_PCR, GPC_PGC_CTRL_PCR); - - if (domain->bits.hsk) - regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, - domain->bits.hsk, on ? domain->bits.hsk : 0); - - regmap_update_bits(domain->regmap, offset, + /* request the domain to power up */ + regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, domain->bits.pxx, domain->bits.pxx); - /* * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait * for PUP_REQ/PDN_REQ bit to be cleared */ - ret = regmap_read_poll_timeout(domain->regmap, offset, pxx_req, - !(pxx_req & domain->bits.pxx), + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, + reg_val, !(reg_val & domain->bits.pxx), 0, USEC_PER_MSEC); if (ret) { dev_err(domain->dev, "failed to command PGC\n"); - /* - * If we were in a process of enabling a - * domain and failed we might as well disable - * the regulator we just enabled. And if it - * was the opposite situation and we failed to - * power down -- keep the regulator on - */ - on = !on; + goto out_clk_disable; } - if (enable_power_control) - regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), - GPC_PGC_CTRL_PCR, 0); + /* disable power control */ + regmap_clear_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), + GPC_PGC_CTRL_PCR); + + /* request the ADB400 to power up */ + if (domain->bits.hsk) + regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, + domain->bits.hsk, domain->bits.hsk); /* Disable reset clocks for all devices in the domain */ clk_bulk_disable_unprepare(domain->num_clks, domain->clks); - if (has_regulator && !on) { - int err; + return 0; - err = regulator_disable(domain->regulator); - if (err) - dev_err(domain->dev, - "failed to disable regulator: %d\n", err); - /* Preserve earlier error code */ - ret = ret ?: err; - } +out_clk_disable: + clk_bulk_disable_unprepare(domain->num_clks, domain->clks); +out_regulator_disable: + if (!IS_ERR(domain->regulator)) + regulator_disable(domain->regulator); return ret; } -static int imx_gpc_pu_pgc_sw_pup_req(struct generic_pm_domain *genpd) +static int imx_pgc_power_down(struct generic_pm_domain *genpd) { - return imx_gpc_pu_pgc_sw_pxx_req(genpd, true); -} + struct imx_pgc_domain *domain = to_imx_pgc_domain(genpd); + u32 reg_val; + int ret; -static int imx_gpc_pu_pgc_sw_pdn_req(struct generic_pm_domain *genpd) -{ - return imx_gpc_pu_pgc_sw_pxx_req(genpd, false); + /* Enable reset clocks for all devices in the domain */ + ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks); + if (ret) { + dev_err(domain->dev, "failed to enable reset clocks\n"); + return ret; + } + + /* request the ADB400 to power down */ + if (domain->bits.hsk) + regmap_clear_bits(domain->regmap, GPC_PU_PWRHSK, + domain->bits.hsk); + + /* enable power control */ + regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), + GPC_PGC_CTRL_PCR, GPC_PGC_CTRL_PCR); + + /* request the domain to power down */ + regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, + domain->bits.pxx, domain->bits.pxx); + /* + * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait + * for PUP_REQ/PDN_REQ bit to be cleared + */ + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, + reg_val, !(reg_val & domain->bits.pxx), + 0, USEC_PER_MSEC); + if (ret) { + dev_err(domain->dev, "failed to command PGC\n"); + goto out_clk_disable; + } + + /* Disable reset clocks for all devices in the domain */ + clk_bulk_disable_unprepare(domain->num_clks, domain->clks); + + if (!IS_ERR(domain->regulator)) { + ret = regulator_disable(domain->regulator); + if (ret) { + dev_err(domain->dev, "failed to disable regulator\n"); + return ret; + } + } + + return 0; + +out_clk_disable: + clk_bulk_disable_unprepare(domain->num_clks, domain->clks); + + return ret; } static const struct imx_pgc_domain imx7_pgc_domains[] = { @@ -590,8 +621,8 @@ static int imx_gpcv2_probe(struct platform_device *pdev) domain = pd_pdev->dev.platform_data; domain->regmap = regmap; - domain->genpd.power_on = imx_gpc_pu_pgc_sw_pup_req; - domain->genpd.power_off = imx_gpc_pu_pgc_sw_pdn_req; + domain->genpd.power_on = imx_pgc_power_up; + domain->genpd.power_off = imx_pgc_power_down; pd_pdev->dev.parent = dev; pd_pdev->dev.of_node = np; From patchwork Thu May 6 01:04:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241389 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C5FC433B4 for ; Thu, 6 May 2021 00:36:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3998A61185 for ; Thu, 6 May 2021 00:36:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3998A61185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JMmQXZIbtPpGxPFozAJNLyBp23dOiJNeSS3gJpPeKrI=; b=FGRDfnXjYIXiVUGaPoe1EHUcO VPovihN9k+NYhXByi0AfCIQdncOwzCj9tViEe/3B2ngHBkeXh0gbzKvy9bzCaVzLQBXsMTryqwC6P qEDL7/1uasovlt63CemwjLdMRHyoeJx0Vbte5zEA3aouXHUYnW8Aj6IljfdVT4JpfZF0jDUJgOOZl voibSrQHki9Mn5bj+c/DGa+NxeXN4FVr9Mwl47UgHSDBM3CjJWhBX7M554CL++FFp7hNL4W0dD7sk cnhr+pfygm/XyKZKgCmbBvs+N4blDHzZdKQrcjyW6pSbZdX208gfwMmp++Xk0b5zBCM0ubGLAKvB9 ZzdeSGwAQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRxb-002hhU-1Y; Thu, 06 May 2021 00:33:47 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRws-002haJ-Hg for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:33:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=q/CcXJHisbeEwQiC/2wjiV7K18Cl5ppySJigRd1zH7w=; b=LgE0mPmJVkeL0PsPFOowFnc6U3 66iMEBAIU50QVw8zoAjYmRmU0C02tU9u4NARc0fzhBKaW9zzG0AXaCOw8XszHDqKjZRXYlZllP05E uucODNPzcPcEUl/KLsNyxYkqgzG08DFsrsj4iDk47P7L2G9WLYkYo+cbzB3Lm5MMYGuQK9lXVGjku hRZqP0FFHlUfVyPg2O5aqpJaII9fRy2Z23pAvyKKN5+O0fa86SG5brSb1etyeYHFM0O8UIpxHKCg5 sQ1inMyD9Q8IcLgHloPnL1hTYdnZbqCZfCcWVXeHt9JIS2s9op5v6NO5FMWU2nScGsLRdvgeW4xCi 47u8Cgdg==; Received: from mail-eopbgr20084.outbound.protection.outlook.com ([40.107.2.84] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRwp-005REV-SD for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:33:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YLu3TTq2O+xZ6+KrWmK6BirYUvlg+dld1G2tEID737V7KV3NlqRz+d0cb90ngzL+/kGoD13brJkSnEGY7j4MO1j2pC3CuwqwUFHy7jkQdMRzzHMbdQXqiSaYBEciLyOyey7rBE8/TRFU3I/7p3A/U8Zp57u+pOsnvoBX+wT9H+WOcR4A4369w2pIdFXWrt+6d757NNlzpR1WCVDEgEwAmNCzE35T7QKian9Ai2RbjNs6vWrkp4958/4ZSsaT2EISLs4g/IOgSXD+2whPHGGuk2nYA7n4q5YxmjW9mcrBD1vhKMsRHBRzIxBNGu4EK4vx1rIE0kzD8waRMAge2Klq3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q/CcXJHisbeEwQiC/2wjiV7K18Cl5ppySJigRd1zH7w=; b=Z3MX7OWkJ/roFUAa6vbuM3lmvv56aofhNyLb8xqpj0ReG3Tbj6N83b9kSq+FFYyVBAOc9PBVBLEC1y510fS6FUuwTaba9WRZBYCFVA0RIvaWpYXs8FHi7l2FkD5bGtcxKfqnqgvIHwbu5aPGOJMQJQUTnetY8mjhaFZAoSzxQLBmujPxeWVPLNbmxHaZBTFFJ0FNSpFarUTUNwoY78Xq5c+3zWASxe1tgBN4nGEQdP3t3L8KNv+da//DwFp54Qnu0uZmEssHuPTdr0ERt7sMEG8nvVNJT9ZAi0W3c8X+ztQMXnYLJSuaQfsOVVoujz5p9UIiql2v3JwUruxCI93MHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q/CcXJHisbeEwQiC/2wjiV7K18Cl5ppySJigRd1zH7w=; b=lONkOHviDhDV7gh9x99u5e/KIR85sKeMPHsuGUKYy5KFPCRbsEYsKjmyvy8Dg1kumzw5LuY9aM5z7f11TtNTDv/jZYK5/nmNdZPWCrgThtYARjlKvRzQDClcVK4ckt7mPcx6ejOjURmR0el3121o6Q4Am0uki3X/eO/VF9oHs/c= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB8PR04MB6714.eurprd04.prod.outlook.com (2603:10a6:10:10e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Thu, 6 May 2021 00:32:55 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:32:55 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com Subject: [PATCH V2 05/13] soc: imx: gpcv2: wait for ADB400 handshake Date: Thu, 6 May 2021 09:04:32 +0800 Message-Id: <20210506010440.7016-6-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:32:50 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88484de8-c52a-4572-d2af-08d910267d87 X-MS-TrafficTypeDiagnostic: DB8PR04MB6714: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DSdaWgE6s1d/n0Dduakx6YJbLcgvG8HJMdvv+laVL3cJiwx+HOc01dxvkszrzoXmICMogrMeo9ARxEUF2lntGmOb+1jN07dRseLSi+88gfliDEwJiqnIlh6eyrVkIxh1orvIVtnvrMmupV/vQapQsmJuhsnoQOBET5FKRLUoLFa/WAjpQSJBgPMqEiehpc9ZqytGUkNQZ/IqcL9fjA0wmWpEm4Hys9WN3/Ojvr8Ca3dkU4tGLac1HzIqkwd7ONlxPmhHiQxc2XL5DP0lMcDuBPm3LCvPtnGulK/5dLTTW9wPAKfvCar9eTDuzCUGadgToA82AU+UseyMpbhCGqf5a3PWCpMmEBolWJmihGcUJL+X4T5p7/oLMsIlDviaGKSDV0sBT+g+9ZKq8M0DaQB42+Ag6Y5Qh8KOxnG4PzXSVDzI3JAZKaVKwftMttrgAp7Rp7JLnjXlEX0QERmBqN1pFukWN0uTg/dqlRtQVfFYDyarAVRH4HlJQRJgzvSXuJDbdn825yh1qJnbM9RascL4brl+oC3+x0Jm5Xut1YWh828on4W9JKyuDFEt/878a9ok+J66uc0c9p65Da9CSxb2Uzflpld0TMU/mrC4KJvCwbCiERbeA4sWZTpyt+Gqlj1/qhsQzYMuvuVMFlQx1PaUUlB/b65fVvZP9DKPK8rjoR0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(52116002)(86362001)(2616005)(16526019)(83380400001)(956004)(6506007)(8936002)(5660300002)(7416002)(6512007)(6486002)(316002)(186003)(4326008)(2906002)(6666004)(478600001)(26005)(1076003)(38350700002)(38100700002)(8676002)(66946007)(66476007)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 2A+hf/bt3UeHua9nYYAtsOlEoGzStDfMkGC70O6sjO/4tiVfEzhdO7qlN507fZ+yNd8GVsIgTPOqLHlPW7Dq5fkV0hATVRJor95j8HpJG+Mmdf6aiYtrZ8roqsxVt/7G50Czhephll6n34FNb0aT2TbBOzaECoOSYWWEOqsBbu2DeQbS0HC+o6GDb97rAO5UM74lj0wNZrgcuq+qSxkXvFkOWRQlqkEjAm0VyqX4BrCUEpgCyENPJ+QgkvHXOtdjt6cvoXQyHTiMZsLS4aQr6xtD6Ncpxkfgr1cQqpk3t02GeOf5ASd9NmcYU5Svse3Fnyyq0ffXW676xvVDG2f9FLdV3iSiAxNMmY9uZvQEQ5aK/xHPkCIYQlR86h2Ut+YY5eDnDeUox8H3mM/6mvzygftqNhn6FXU5neXrtztVb/41xNBhtGUSEyB9v6ntFuUNxhPTNmLPRxSq0ag4nFWKe/aQG5yVRVsHekbARdTFAEvLJAfC5uoJkK7gzD2g3TS82kFig3K47eG2vAHeuvWhwop3RNMEMJFwGTEb+ccmEGM8aZV4YpVk1Mv43b2slJWKP/D26ZDYjCdpJSIBndnGByMSFEWgs1noi2eyTysZBVq1TqUQfLFllC5p4C6JTcOdLl3JRA5TTAciX2U1h+u3515cW876w4K6FWGUtVvHZIWzq8HuqCvr8QR5qXhRhyXRV95gw4CW83Xjmw0UrvFQejXtxFpVj6OepL0MK4Y6TFyklS72PkVhEv1SgYm6j9fVRZn9lD8hRJU0+En3TO0KYksfWNl6wmQS4At3Cauf2Pq9QDqpGJtxQYa3qmiNHOlwPimdqY4FavQwyA/1pcEHsZHhn3x0iZEydfn1L4fFcnJZeRVOAO7gQGGrJtPccgp9DC4LSpeM0bpi0ioYx0KP85w+oNH8WryEKGjLCZtuMmMKrx4Fc8KnMyT5XiJuyJ4p7dTsFQMxLxHkOcVlOF+G03qlwTvqzHFDygKH6kZ9bHb9aLfX1sl59WxAFcC30qs/1PKCPxyNTv8oibMEN/oWqrawTpdfXbat2ymxVWJmG9Jkp19bdWMQui1MciorSwsoIrOTwsCIxpkpx8ozQiVuzdiOhJ6pTnRgEHcxSubJ7mbjx0mLPH6h0MqnavClKnmkM3dq8VrAvp1S25ih+o3g4v083pd6MGOTqUgeS/O9k+7ILMI3ivEtFVvJXhhYvTQS1mQ1j1M1+HbM0FOb/7y9wRn+OR5Q8m/0IVG9IaRJD7yxfCYmsGXDH7+zIfftndEAV/oVT+Ic1x0ePPVIBrjfL7BsOy6Kt641Y2/eIsUOZxi07yUMrsNI5gs0Lym+enB1 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88484de8-c52a-4572-d2af-08d910267d87 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:32:55.3029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MEeaSbagTpYBw8xuQEvf+5OqP4RXAmAobvc9U/BoXWy1KzXGw9cOCMdfWQyoHZ7qtjautiumuBeCe0i0cnqmDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6714 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173259_945953_8EDB10A4 X-CRM114-Status: GOOD ( 19.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach New reference manuals show that there is actually a status bit for the ADB400 handshake. Add a poll loop to wait for the ADB400 to acknowledge our request. [Peng Fan: i.MX8MM has blk ctl module, the handshake can only finish after setting blk ctl. The blk ctl driver will set the bus clk bit and the handshake will finish there. we just add a delay and suppose the handshake will finish after that.] Signed-off-by: Lucas Stach --- drivers/soc/imx/gpcv2.c | 47 ++++++++++++++++++++++++++++++++++------- 1 file changed, 39 insertions(+), 8 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index bcf1f338b0bf..558b8b8af9af 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -69,6 +69,9 @@ #define GPC_PU_PWRHSK 0x1fc +#define IMX8M_GPU_HSK_PWRDNACKN BIT(26) +#define IMX8M_VPU_HSK_PWRDNACKN BIT(25) +#define IMX8M_DISP_HSK_PWRDNACKN BIT(24) #define IMX8M_GPU_HSK_PWRDNREQN BIT(6) #define IMX8M_VPU_HSK_PWRDNREQN BIT(5) #define IMX8M_DISP_HSK_PWRDNREQN BIT(4) @@ -112,7 +115,8 @@ struct imx_pgc_domain { const struct { u32 pxx; u32 map; - u32 hsk; + u32 hskreq; + u32 hskack; } bits; const int voltage; @@ -172,9 +176,23 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) GPC_PGC_CTRL_PCR); /* request the ADB400 to power up */ - if (domain->bits.hsk) + if (domain->bits.hskreq) { regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, - domain->bits.hsk, domain->bits.hsk); + domain->bits.hskreq, domain->bits.hskreq); + + /* + * ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, reg_val, + * (reg_val & domain->bits.hskack), 0, + * USEC_PER_MSEC); + * Technically we need the commented code to wait handshake. But that needs + * the BLK-CTL module BUS clk-en bit being set. + * + * There is a separate BLK-CTL module and we will have such a driver for it, + * that driver will set the BUS clk-en bit and handshake will be triggered + * automatically there. Just add a delay and suppose the handshake finish + * after that. + */ + } /* Disable reset clocks for all devices in the domain */ clk_bulk_disable_unprepare(domain->num_clks, domain->clks); @@ -204,9 +222,19 @@ static int imx_pgc_power_down(struct generic_pm_domain *genpd) } /* request the ADB400 to power down */ - if (domain->bits.hsk) + if (domain->bits.hskreq) { regmap_clear_bits(domain->regmap, GPC_PU_PWRHSK, - domain->bits.hsk); + domain->bits.hskreq); + + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, + reg_val, + !(reg_val & domain->bits.hskack), + 0, USEC_PER_MSEC); + if (ret) { + dev_err(domain->dev, "failed to power down ADB400\n"); + goto out_clk_disable; + } + } /* enable power control */ regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), @@ -369,7 +397,8 @@ static const struct imx_pgc_domain imx8m_pgc_domains[] = { .bits = { .pxx = IMX8M_GPU_SW_Pxx_REQ, .map = IMX8M_GPU_A53_DOMAIN, - .hsk = IMX8M_GPU_HSK_PWRDNREQN, + .hskreq = IMX8M_GPU_HSK_PWRDNREQN, + .hskack = IMX8M_GPU_HSK_PWRDNACKN, }, .pgc = IMX8M_PGC_GPU, }, @@ -381,7 +410,8 @@ static const struct imx_pgc_domain imx8m_pgc_domains[] = { .bits = { .pxx = IMX8M_VPU_SW_Pxx_REQ, .map = IMX8M_VPU_A53_DOMAIN, - .hsk = IMX8M_VPU_HSK_PWRDNREQN, + .hskreq = IMX8M_VPU_HSK_PWRDNREQN, + .hskack = IMX8M_VPU_HSK_PWRDNACKN, }, .pgc = IMX8M_PGC_VPU, }, @@ -393,7 +423,8 @@ static const struct imx_pgc_domain imx8m_pgc_domains[] = { .bits = { .pxx = IMX8M_DISP_SW_Pxx_REQ, .map = IMX8M_DISP_A53_DOMAIN, - .hsk = IMX8M_DISP_HSK_PWRDNREQN, + .hskreq = IMX8M_DISP_HSK_PWRDNREQN, + .hskack = IMX8M_DISP_HSK_PWRDNACKN, }, .pgc = IMX8M_PGC_DISP, }, From patchwork Thu May 6 01:04:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E0AC433B4 for ; Thu, 6 May 2021 00:36:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C877E610FB for ; Thu, 6 May 2021 00:36:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C877E610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nT5BlAh3nAtAu+2gAGY16KZNPtmnWPICtGWeGk7VxXA=; b=L7SLffa/lHA6ksXCDC7Jdu2dD GAgBQe5U1nRV1vQ+0oBaOkV8/GsX4+VxhWj1VEUa3jKpCRFo2AFp+AuTFSpnYDzmjIKpzyRKJU0Ip mplsYaNQdaVlImmlmfhevbBvh+pLJ5OfNU6yf1g576FX6lBABI0Si0+NCwyBLrVB9bG9OJqy0laKa uJVS50MVBXx/jbWStnbB797mAJVKRoVK97Hwpv/ykRBBsJkskaLDpd3/KALLTZ29kV7P/bq+ygE+H ZL2QgObNRaS8bluhy/EauTsNpqwhvB9DUZ/1VDN9ksagqLf4XtEkUK/ZmoQA5ZeC3eT2EplVryUFy 4aOYmIHLg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRxq-002hlo-Kr; Thu, 06 May 2021 00:34:03 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRwz-002hbF-4l for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:33:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=OyfMB8r6y6e3V9+dQWnesa3DiUzqhYHZf4kj7QTAb04=; b=YZCdiMC3yZuq7Yt5NGAIkQTOm3 CwBNsrryqSrU75UVNQPOPfCKwPHpGKUgE8JBaPDpuGFU90thjwS2qSl6Z24chFxxQKkBlkFkZP4vJ FNM7uvlEvCcglVQPGbirKRNoLNOm0iAOszzJ92AREhOLn6OxpjwtRat4CdUJCRzDQbsGCxRL6wQnp U5PjZ83WewiKB3fFioaFzGqTH3BP7MYihlNWVeGiNndPw29ecq/V0zndCjqwZcWym7D+9GdMftFYA 44J38AJoSfvRAd7tBMBixRhfiza3VyBEoHQoxxOInq13QSwQLlwhMWsdMOQp/OzHT9ZdkAHMR9KPk wnuer+TA==; Received: from mail-eopbgr20071.outbound.protection.outlook.com ([40.107.2.71] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRww-005RFK-J3 for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:33:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqEHVFTHqaNFuJCP780dPk9GXnBqGVSNp7tQ0sCibr/e4IBePvpilzFDPgkvn3/MdzSMf9XKAt669Iu+s5KTGWmdjsLOqv34qrqAfzDy4VOpgHO2XbMZkCKF2ny7r+H4OmH0/xHXO2Yy4tIk3wtPybf4V1afSrWusP910TNfkwWrFVQdUCMbbGk2BbKOdjgZTGRDhogLjOzWCNj16lVB4LEZRrH2gy7LDIiap/nDEVucZ0ahW697zqy6igXhlTjBy2JWEo16AmgF+msxj/qVNDcFfMWEDBlIUeBSGhGaFilza8IznGA2BTXsFQouIMvyBmOPranQhIRO+NhFZvzdWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OyfMB8r6y6e3V9+dQWnesa3DiUzqhYHZf4kj7QTAb04=; b=lsBBFCDJGRdPZCTWBoR2+1dgGbYE+N8TEmgv+IpjZ3MfotuszTu/l3VYxjh+Yf+tj+28JghRbC0RBSbKH7Z3J/a+1x+Fm/s9Z+VtobiJo2Qt4M5D5En4F9bbPBtXC2chO+RQTunuH4q2AU+HBFOAOQbEARgDzzBew8X4dhaMnXs8XookF/+vReVp6Z8lTTebG3EIImjYgfpFCL76woEeYKG+x5ZCCv7RIRFsNLMr83JgAQSYbWrNzUbc5wU0CmLaXnbhtxd1+aJQhWJ1+8g5ejzUi15AdIbUa1tleLaLdoIq53A6vGsZLJzxzBRv/92L3pPDmuJrmqrQkwibhnkgug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OyfMB8r6y6e3V9+dQWnesa3DiUzqhYHZf4kj7QTAb04=; b=XDUeRL0UatMYjc0+Ze9CHQ38iaHY+pDogbUmPMY2d2iW7KtwGOw9GI+PW8q1dMoLH33SmEILGBnMi0aqwHzeabe6z7o1WzRW1h5wP9RCotnEiv4p7CdNUrU56P5o7yyKhfUePHcG66YjgxriqQKQxOxqBQHI62pm72I/1agZfVg= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB8PR04MB6714.eurprd04.prod.outlook.com (2603:10a6:10:10e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Thu, 6 May 2021 00:33:01 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:33:01 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V2 06/13] soc: imx: gpcv2: add runtime PM support for power-domains Date: Thu, 6 May 2021 09:04:33 +0800 Message-Id: <20210506010440.7016-7-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:32:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 89d91e13-68cb-4c03-d508-08d91026811d X-MS-TrafficTypeDiagnostic: DB8PR04MB6714: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:454; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VEFGGptBTdRuj0qN+pVK+M44Ssa5f+ivy60HTtJOsPYnJiUpm0Km/1wqTE1+Ri4XuJfLLfCM/r8hnubbih5hBCyr6dAr3hBZKJhaPaPAIspUbrGpNeUQklEppr3VJLPew3/MYnJPZu6rNABm7k6aVujHPz4cmb6c8Ij83ZhJU85JW7M2FKBtbaPeY2s7Bezv16YISY+UhjPv79QK6ziUsAhOoRW+dE+pEN505XZ2GcFmlLIBp8O+4xJgWSz//UOJY8XYofhiaBZhtwI//hxdT+6eGMw648lkWYbYV4M0VAIvdvIYng6R32tmmRHgTOUXx0hcrHypZ8VyLjwzLKIf+ji7hrxigpdmJHd99rBVEDcGHANRUofPVA7JeGAXU3wUDl/jKA+0cZpW0XxBW13Wln1LN6cT6yzEwssOxOvvoZXxcKv2YRp1aLRFO3jicNxrgDsbGhaCd3dWtzwSIvFNb/zWpHkqua28m3agQj/u4vB7BcVowrFanIqLJx1JjoS4fpr5IBVcIHmc2rifErl+y6Fc5GJtK6KJhGfEE1qqPdCHKQKb9MhaWs6V7o0CAHCRMNSNFc77W1EW4ds3E7UCjdv7b+R3SjiyeslwkHvCn/DPOD9k9GLkF74lACeYWdc50A8ZIdm1M5/ptxXIDKww8j/6y8MdTmbXE3y1GDL7ZTg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(52116002)(86362001)(2616005)(16526019)(83380400001)(956004)(6506007)(8936002)(5660300002)(7416002)(6512007)(6486002)(316002)(186003)(4326008)(2906002)(6666004)(478600001)(26005)(1076003)(38350700002)(38100700002)(8676002)(66946007)(66476007)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ARYJzd9hXwJCKVpMHZFCmlM2Q7gdxiXXH+qKmRcDLNGRAH0JXIZFWrdkwKw3gt7oGARD8NBIJD38IQKVquZK9WTeWPH08rf3TnYeWxLWh2G0Nk4eVXDRlk4UAID2kvQ3sKbd4AGTcEZ8WCpg+I4a3wDamzO5qNdWlrhmQvy4TyASR0TJxMrmR8d8eHOhg80JLHks+mJCxxttBu8C66J8y14uS9ysmPsNK8GX3P6KR4mHXBYsxD5bwGlwMGl4j+UWliTqzaiV17k6mEJnRYAyicAZGLnJuGMCVvsD7TzWGO5NFuwMmYc59Tj19pLNVSNH/RRWb2op+OGmi36WOSQlvq/6J86OGbNC8kjVjZbgLVvPF19nMiz4oGRkeOwOYcLwTxls1WUwMWAZOt7W5/ObQhpKR06IMhIxtuJ+ZJfn+JLCdzkrImcIZg24qKQqLhlTBWqTY3wmPFoewwdfy1UgQ+8m/M4hrUBGPmM2albjacV6uSkZFffU+3aoMCTKtj7KyhMKXRMbFC4wdo23JyjYZ9L7IHY5jE5jj2+PdVlcOX5Ay/rdkEyhsDj3GDHkhcQ6Cf4balHRp10bCO/2RVjNbzW3QA5mZ8XrsXyAl0ANGRkw/cwtOSi0+OryWdFutG8mH5mFsiEQ1O3tMwSWMvAmUMDp23zwix/EqfaQqUrao2xQfnvmArw2VyA9PEZIbxwUpEGr6JN91oddri34e+FaGKr0bF8CCJpVsC6HXPIKxG/eqvyvvPKLSVq1ldsjxUQ6E7D1/NesNXGwbfFEZ1aNjAJ18Yqcx4q3K51RCpckJhhxJqtw8Jc4Yv0fCsPgmM0S0S5c61VOEWkJeBmflOqlX/LvP2hOz0bKq7988+PZJLwIJ1dC6LZ066yTA859NRkeSA3QeIuDIFEO3o374tBHeedIm5NuUG+BLWIRJBM3qkV6ieK6Z3XcvkQD7AOj1tby2MdjtdRIgymusG07Ms5q25U+qkGfD+9939bNd2OBEYO+k8EgoCn5vyduAhcwQGSZdxR/2B0SIiv96B27ga5BMhoQileaaDUukRLO8bkvkWRX/QgsBw4gnGoghAWkNMkLMqiqb4PUX89Elsy2uIwypBECOgW5yUQF1JOkpS4/cVwqBQmztjFX8hMEY7KwesScUXvnr4VTXn5nj2nbakvJtsbEpJrCxEwBL8DaxnbpVrvEr1esnR6qNXuDjYRT0epN9zxKisXmW7LJgpBH7iNMNdbXc8YcR0LRmOEnUx5YXzhWz0F1cxadgOdgvtb9vMYcQ3JgrpKe3naimjNtRav1+LSu7L9oEh4FcR1sW/hfNNMQRlX/RMHZZHYRajRuhOet X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89d91e13-68cb-4c03-d508-08d91026811d X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:33:01.2982 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RbkY/iFpY5FgPtfRnGCBpILdbzgbTHrZ+YfUBmblvtpNpBpE7a9Tj73UtJrU63NABzIQsNWMtlKpkT1cxXTy5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6714 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173306_654719_CEAE6F84 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach This allows to nest domains into other power domains and have the parent domain powered up/down as required by the child domains. Reviewed-by: Frieder Schrempf Signed-off-by: Lucas Stach Signed-off-by: Peng Fan --- drivers/soc/imx/gpcv2.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 558b8b8af9af..bfea8560cb64 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -141,11 +142,17 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) u32 reg_val; int ret; + ret = pm_runtime_get_sync(domain->dev); + if (ret < 0) { + pm_runtime_put_noidle(domain->dev); + return ret; + } + if (!IS_ERR(domain->regulator)) { ret = regulator_enable(domain->regulator); if (ret) { dev_err(domain->dev, "failed to enable regulator\n"); - return ret; + goto out_put_pm; } } @@ -204,6 +211,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) out_regulator_disable: if (!IS_ERR(domain->regulator)) regulator_disable(domain->regulator); +out_put_pm: + pm_runtime_put(domain->dev); return ret; } @@ -266,6 +275,8 @@ static int imx_pgc_power_down(struct generic_pm_domain *genpd) } } + pm_runtime_put(domain->dev); + return 0; out_clk_disable: @@ -523,6 +534,8 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) return dev_err_probe(domain->dev, domain->num_clks, "Failed to get domain's clocks\n"); + pm_runtime_enable(domain->dev); + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, domain->bits.map); @@ -546,6 +559,7 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) out_domain_unmap: regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, 0); + pm_runtime_disable(domain->dev); return ret; } @@ -560,6 +574,8 @@ static int imx_pgc_domain_remove(struct platform_device *pdev) regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, domain->bits.map, 0); + pm_runtime_disable(domain->dev); + return 0; } From patchwork Thu May 6 01:04:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05B58C433B4 for ; Thu, 6 May 2021 00:49:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6233C610C8 for ; Thu, 6 May 2021 00:49:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6233C610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WbZ6wfmv9YObxe+m2BMNGRMSXwMOzo/x5qpF82G7PZY=; b=qi6DIasjcNA4PqIoDW8G8v9Xq 7+rYLbJj8eRWQy7Io03kixBqOzMX0Ln7r/0UiP2eDrPiBpFOrQRfLYfygeeToxJQuL2gjpgPeMf26 UfCo8XGsGmpW/8wn45LtvDo+8lOYQeTNtx71fvVYeaW/pz7U5CxxFxSPECdnm1iuYXEF6lOZEZnZ4 WlSTO3MXP242MoOTXxGK263bEQK+FyIs+vVQo9nZ/E0VcJJ5xo2d0Xk4QwtUuWzo3WOudYZWK6UQA jqPC5cvb+n7FplfkbFv4AmbP/isj/SzNyMP8vp1ysqoPMKb1w2xIRhyhyDwfE5/n7NazVtDxNdj9W Tof4KDxLA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leSBK-002l25-KV; Thu, 06 May 2021 00:47:59 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leSBG-002l1r-7y for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:47:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=h7+Zv4gz8BeNScjIZFS/TAvZShU1paVfL4jFrmQcdUY=; b=l1jvipvpy/EKc/xRuL8q+GsFw/ y4Ng7Gw/Fr3wTQ4Dq+MQIKMLu1TgMlRzHOUD+mQURCXdOEH8h7/xFouv0u8/ep8oesj/W4Vc17pJ0 0zQmke1kubZ+bXPki7A5GfjWkwtBtA5KcD4NfrwejP5o6yULsXqYp8pVoymfJ81VNLxb5w9EJvsQs gg9TYl6Dey9rXd0W7jYge9JYBnl7SuyrhNYKRnh38K8mcqUw/mhyLKrgHKKzR6k3tvuFYb6B4uibM 2dNnBtg5vpcgptoMORnuNsFVjnPwSF6BGeDppApdaOrwBnRbA0QtYRYvyuRRIwY7SpxOYRuK7ETwt +ONwix8g==; Received: from mail-eopbgr10060.outbound.protection.outlook.com ([40.107.1.60] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leSBD-005Rtj-CQ for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:47:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hMo5myKfbR+gnsEWEdcRSjNvJUf7F3YN+SkAVNKAcmKYQ9DIwxHW6Zj/Op8f4hAXZD4//CIzJuejDHeuS/ymnLAYRPmGflkykNnJz6/G44Ohspim3fBnYKXuMy3lr/iaR7p4JpelmeHtqFPRRN3wYUB8o3csLEXrwNvVdUXBGsy4n76Mam4kKMQZde+hkNDIigGjEqiLEBnZkVMbZPFLqQ4H1PmUlzXqlvmlo4IZ8jgztoGA25knZLcVCC0lU6ilgmfxkYaizZwGKOvseRp2x/uQtZc1emIOZ0SQD/Etv2TO+FIHxo2ZsByqWK/ET4+H5BqQNrHpON881xj4JceDaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h7+Zv4gz8BeNScjIZFS/TAvZShU1paVfL4jFrmQcdUY=; b=WhYeLFBDJ7I5xF07NS76BHafymUBsMw7LUDwJewvZj8dJpXNhCl9vITqZL9oJ8gXsAsWVKzw+3WySmX5oHu+SGnqKJzEVaHIVE0bkCvBhb2ApV/dU9eIMCuLhB0/VsmdOlh8iLpvLS7uPnKE9LFWmC6mUfqjiPQR4QHmUbpZan97OM1aew/6ugGJKLKhzoXCmP3/PV33/xOei+c2Fj683/Lgfci2SoYUr5T5Fw4Bd7P+ZZrvNQzKdxebma3nAdTBNt6JGsd7KTvl+dJwppBodkP9heAe6cqMsBHUCGNFJJio0vnMiWSF7fEdsl+hYpIHjfauJkPPNO4NAXnyil9piw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h7+Zv4gz8BeNScjIZFS/TAvZShU1paVfL4jFrmQcdUY=; b=gMglgxpBPmGaJNrp9rnGoYzA2Ea7qVF66jldKtrL5CHy3EJFbSBYeCqYcruLyXBGoNa+nICrepet+i1O0s3Mg5504v0awI+lZN0NwM8mLuiLfFzm1p0/mAEhogpgzDSpBafXg90Hul4qKjMuHnD5DhC/Mb3/L9z9aGJ4wK+AReU= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DBBPR04MB7884.eurprd04.prod.outlook.com (2603:10a6:10:1f2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.41; Thu, 6 May 2021 00:33:07 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:33:07 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V2 07/13] soc: imx: gpcv2: allow domains without power-sequence control Date: Thu, 6 May 2021 09:04:34 +0800 Message-Id: <20210506010440.7016-8-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:33:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: afb9b3e3-abc8-4b5d-555c-08d9102684b0 X-MS-TrafficTypeDiagnostic: DBBPR04MB7884: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Btb+mv5ukdmc+M2wLfR/xrirp7YWY9R5c9iMlZ9DEJjqeH6AkKo4EhyOvhN3qGLaWq6nx6bnm7S01jBXM9C48I66X6wWCTggKD4toeCWk6ntlqYE7LT8vQTXi0BF+OBE8elE2+SR0WQGce61oTlUCmx/fXf3UiJ997EY8MspdJINaq7pileDJxFpafM6dxVKrz8ngzU+vKgqsibieeeO2suZXMMWPxHeSZMxXy10AMr+Mfsay1IXEzzqFdTkmAsGCjE5rFBKrQw2XWxhZ58J6091s7HQiLn3Clc3e9cLpVr4RxP904eiW44DUQUjz79THAgUxH0QfF9sZiE9ZinzYjOJuHbFBVqnKaLO+5IstbXB7Idns/8J041tzMiCnZkqFLEFuUhBQ+0PJVvZQRUywtbiKXkdswffWOhqllJvTILr/Gtyo3yfeY0b3DJuigqFFRwsZpru2f5Wzs8kdBdnR7XHjqFgl024PNBBRKmt9q8rp7aHFnrDLn3BNqXGi8nqJ/3tF+YngqIcOME44DhIFEPvfQ2lB3AzRUrjzpSISuE5tKUpcpkOwv+8FGtka/EQQVYPwRF15XJKNc95sM5vIcGVIxfRFqO2NX0r5aJvMCuipNPeP+GlZ6JkoVJ3jCKYqx3b0LixOk4mKQQyptugpoO2rLhyyV3zqkjX9HHhSmg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(52116002)(186003)(6666004)(5660300002)(6512007)(478600001)(2906002)(1076003)(26005)(6506007)(16526019)(6486002)(83380400001)(956004)(8936002)(86362001)(8676002)(38350700002)(316002)(38100700002)(66946007)(66476007)(2616005)(66556008)(4326008)(7416002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 7Fs/2aGZT2ARViQlQaoEJ7PcxI9E9dzFmntFQnTw2JymJezYCLgC9lRQnyXmJLI/DDrP2DoSEF696AkFZsD+uV8a4+i2SQ5lmNtZIRbOwLVegvmWEcNcG4aoeI82H+tqG/6rk3Q6QO1rBUn+CWlP6H4gp2mHCKTNE2bHb2HDTfOsWuJ4ibr94GmmPZFZEO4fGgT6vIQ1K62y7UTcolEaRnENWLwa+J3FhyjLlcjajqn4ar+mpCrTphYacbMxWX46tQ7i/Be+pjONjQ2siz3V53gCSeMukn7uK1ZBgFsXwD3L08K21gSzBbXKIe0SjELvQIrzGhWV90sWIzvHxKqnfyLRui049ZUlFrsRP9gKxi0uS+Q7YJd2jbWbcxNttFZP2CQ5rhkLEMRGfpDvo2JdAfDoaI1+bkH8dV9GLM+7R++7lNQ461hpKngW1CzrH+YiWKCdnziCpSlHE/qx9Dqgx3e0O5xhK/6M/xjtpPWmfVCVI87uyEjwlFQf0+yqh6E7Z4RUIT4d+Ib8pAPrqJYRj2w8+AnDPhyi5/5yKZxRRzDGCzEJ0nnt0nXmOgQ18peZUWXmrS8mvL/5UECOnT2Prl2/yEoRyZgAUzLq2MhNarcOtp2qIpjxQLbRy/COW+wy2VrhDIG4438Dpeuk3wPLnq8ZhAzqRo2XJYrJwiDj9GxLqxFvYmIWMiEU6uVB9Z+M2iLRAm1/lt7tP4IX9g57p3HJ2omoWer3t8iyUHhdYTh93fytmqqvZV2OqFRuAU7uWJxfuE3NShJCdEgLJ39h2P/FSVledohSJEs5d4A24+1Hf7attul2BVhW60sRYOKTcdYch4gy6OJku3tsHOclq0E1xdkbP0oK6GKpGYZX8S3AiSR9JKVXn2zoC7ODacEc/9P7DCBFdGXf0FzFgHWcH1pHwEJ7uAb+PtX1YT22VvK/c2m4Alxn50G1TFzlFgBSfjFBQMkN8j1YTyo8GgTzPB1Dv7YcUhJUNnXTSdVk3zeJhKDgZR7/FS/0H0huxdvioBeL4OvXBnrlfojPo/V2VljOxJjxI95CYUhsV+YRSNTvhIum6WFP36K43oim32P/nkNfdlUnSnOuTn7bIzspfmg4rQDXSQiA8SiSLETAMzKlW221PtMBgLnwNUDU3fgx6SNryF37z+outLbGqrW1OmHQk2JHwjskcoXv7xcwleU3OMPV6tR/qnetbieJGqEf2Rt1neSxvvw30IuMrfxOAj03+BE5TkzIjsA/WyibVO1cip2zV289k4SKy4+pd3kNBAYKeFMmeP8lTVJ6c/P0tp4xwfUDVQ2W5TFDy2wXYdO+QKR/AMcEOV0yR/r0mzJc X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: afb9b3e3-abc8-4b5d-555c-08d9102684b0 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:33:07.3374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HV5mEZq/3QzcDZQVZeV8OBQBfAd90Fj6B4ZE5glYbUrHPGwoSgZr33feAGBmRbatts/1u6F10VeQWfrChxwYWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7884 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_174751_432595_ACFED8C7 X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach Some of the PGC domains only control the handshake with the ADB400 and don't have any power sequence controls. Make such domains work by allowing the pxx and map bits to be empty and skip all actions using those controls. Reviewed-by: Frieder Schrempf Signed-off-by: Lucas Stach Signed-off-by: Peng Fan --- drivers/soc/imx/gpcv2.c | 89 +++++++++++++++++++++++------------------ 1 file changed, 49 insertions(+), 40 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index bfea8560cb64..0428f0eddee0 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -163,24 +163,27 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) goto out_regulator_disable; } - /* request the domain to power up */ - regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, - domain->bits.pxx, domain->bits.pxx); - /* - * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait - * for PUP_REQ/PDN_REQ bit to be cleared - */ - ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, - reg_val, !(reg_val & domain->bits.pxx), - 0, USEC_PER_MSEC); - if (ret) { - dev_err(domain->dev, "failed to command PGC\n"); - goto out_clk_disable; - } + if (domain->bits.pxx) { + /* request the domain to power up */ + regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, + domain->bits.pxx, domain->bits.pxx); + /* + * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait + * for PUP_REQ/PDN_REQ bit to be cleared + */ + ret = regmap_read_poll_timeout(domain->regmap, + GPC_PU_PGC_SW_PUP_REQ, reg_val, + !(reg_val & domain->bits.pxx), + 0, USEC_PER_MSEC); + if (ret) { + dev_err(domain->dev, "failed to command PGC\n"); + goto out_clk_disable; + } - /* disable power control */ - regmap_clear_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), - GPC_PGC_CTRL_PCR); + /* disable power control */ + regmap_clear_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), + GPC_PGC_CTRL_PCR); + } /* request the ADB400 to power up */ if (domain->bits.hskreq) { @@ -245,23 +248,26 @@ static int imx_pgc_power_down(struct generic_pm_domain *genpd) } } - /* enable power control */ - regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), - GPC_PGC_CTRL_PCR, GPC_PGC_CTRL_PCR); - - /* request the domain to power down */ - regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, - domain->bits.pxx, domain->bits.pxx); - /* - * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait - * for PUP_REQ/PDN_REQ bit to be cleared - */ - ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, - reg_val, !(reg_val & domain->bits.pxx), - 0, USEC_PER_MSEC); - if (ret) { - dev_err(domain->dev, "failed to command PGC\n"); - goto out_clk_disable; + if (domain->bits.pxx) { + /* enable power control */ + regmap_update_bits(domain->regmap, GPC_PGC_CTRL(domain->pgc), + GPC_PGC_CTRL_PCR, GPC_PGC_CTRL_PCR); + + /* request the domain to power down */ + regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PDN_REQ, + domain->bits.pxx, domain->bits.pxx); + /* + * As per "5.5.9.4 Example Code 4" in IMX7DRM.pdf wait + * for PUP_REQ/PDN_REQ bit to be cleared + */ + ret = regmap_read_poll_timeout(domain->regmap, + GPC_PU_PGC_SW_PDN_REQ, reg_val, + !(reg_val & domain->bits.pxx), + 0, USEC_PER_MSEC); + if (ret) { + dev_err(domain->dev, "failed to command PGC\n"); + goto out_clk_disable; + } } /* Disable reset clocks for all devices in the domain */ @@ -536,8 +542,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) pm_runtime_enable(domain->dev); - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, - domain->bits.map, domain->bits.map); + if (domain->bits.map) + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, domain->bits.map); ret = pm_genpd_init(&domain->genpd, NULL, true); if (ret) { @@ -557,8 +564,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) out_genpd_remove: pm_genpd_remove(&domain->genpd); out_domain_unmap: - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, - domain->bits.map, 0); + if (domain->bits.map) + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, 0); pm_runtime_disable(domain->dev); return ret; @@ -571,8 +579,9 @@ static int imx_pgc_domain_remove(struct platform_device *pdev) of_genpd_del_provider(domain->dev->of_node); pm_genpd_remove(&domain->genpd); - regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, - domain->bits.map, 0); + if (domain->bits.map) + regmap_update_bits(domain->regmap, GPC_PGC_CPU_MAPPING, + domain->bits.map, 0); pm_runtime_disable(domain->dev); From patchwork Thu May 6 01:04:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58949C433B4 for ; Thu, 6 May 2021 00:49:47 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D746F610C8 for ; Thu, 6 May 2021 00:49:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D746F610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Pr6+x5vP7Gi3DnpHpY/DahG0ABdjDAuOzrzksaYSv9I=; b=jrVJMR1PLe0mprJRoDth4DMt2 q88mPdcTYyjiuAktXRmBUS3N+cZCXxAWUCyUYWR0H8mBtqhWGLrmG2I/lPXAEId5IwE124uUBsVjN 9fmjgvrGSGhwdD1CjsCGkcSMqGPRc1pSpzFKoNht6FR25R4mJ489devBsO6wCIvQ080+6U7vL8KGZ Zsj9ckgq0owycV6bQxvxIh+/SuqDroE44f1HS+2lNY7jYILe27HkmoQJ2hxNNfJ7btb6BKctNTfJ6 VoaqtPLtSH6QVaHmczGUQgat9zbacUup5FPnmmp43NNek5QR9++By9TrSAXzhkWAluma1i1x3+N67 qezrlueZg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leSBY-002l3x-1f; Thu, 06 May 2021 00:48:13 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leSBN-002l2H-Gu for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:48:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=JFkEvPEwerxpXRsOXrSUzxy2F/JitvdWDQyJlv7Y9W8=; b=mP+7aR8YSHKuM0g0XRoAVntpyj ammxDNH3Or2BJhMTN+8fsy8L1Qc8azyJClUIgBQJ1HKbHvwWZ/NM/eYR8r4bQXGJQj2rldRzvaZrw ZLPzyVAu1dvBaNZkrqo1fjgeh3klvkZeWAhBcjqJJdg4V68IWa50Gapx/uqqRvw38PyiaZvEGW4V/ WgPNoyoYplsGGFRVV14edeXZT1rrri115SNUDbKpIWP/+pgMcCjG8SRy/fxrMdNFHzOZ5WW29cUVX ucSz1mSFf3CooWdnjZCg13kfPg8tDD9aGsqoxaKOtTBPQsliiQ5K5gnXQNr7j50MmpY4XaKWexp74 KYy7TdoA==; Received: from mail-eopbgr10062.outbound.protection.outlook.com ([40.107.1.62] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leSBK-005RuK-VK for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:48:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LQYnMurrsQ9a9Sk5H9GFELuv6PfDqUkg7PCXEYCIAekWXcdqFbpRE5kqm23ceECOWG2U15dLhy+eSsWdHYlsElZ2ibZi+Zpr2CNK1IfdZpr6L9n4N64WTwvSfs/vETlwRLxSM5xhSO5xdUtIIsfVKfpjxaMsxYjsR4UJQmzxWbKG4eFu9V0PR4bFBRQKjNw3PhEKR69kSMJpiRcT5FP3WAPQlYQfe3xjR68j9guLXZjF7u1piVePMg2WsuSbUZc0EidNraGsmxLNQjymNF0FUsEiQV8ay3+PKYXuECtmhNDNarqLJ9edRW+qYOkoSmor4aO0Tli4ieAApzjXmhvwPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JFkEvPEwerxpXRsOXrSUzxy2F/JitvdWDQyJlv7Y9W8=; b=Y2xKhse/D6bw3XyPa9Vku8lGNSBX1+0NOurrOUThp0UHnOvLdc0XG1g0zTZmHyGAXPoHORyYL5xDnNqukt5Mnhbapqliv5tE02kwfx7X4MH0Ev0zcUf58HxeJDs89WgXnS55y0TPVGu31UT6VnsXv6DTd+fwDphn3SSXYthz3xLFUkfyU0cyAv7ZFiH0KFBZRwiEzeEZWbZ0w7Bn9uz0jOhDebzTumxyZREeS5YxKDvkYoWIM/LaHKmiS24lMgHTGb1f4ajRtieWtcuKWlmg2RFH9J6kKRXzbSgdXirLsmGCKNSTAE69Dx43tX045gGnfJ7Q83rTIlAB+EIwpnJ2Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JFkEvPEwerxpXRsOXrSUzxy2F/JitvdWDQyJlv7Y9W8=; b=hfU2W2+Y2DUf2FMqveFMuXVYUHojhRD6S/lZAM0xz7dBCAZJUaEimfYztHDkYXqCqaj81MiH/imorZywpk5QEIBKDBwqLFJULwdJVEDMVJOkvebA13ZbrcIqOr3zckHMt/tr857fffvvQuGgVWxlxl7TJ+QWMx/BQBh1fGCKz9M= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DBBPR04MB7884.eurprd04.prod.outlook.com (2603:10a6:10:1f2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.41; Thu, 6 May 2021 00:33:13 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:33:13 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V2 08/13] dt-bindings: imx: gpcv2: add support for optional resets Date: Thu, 6 May 2021 09:04:35 +0800 Message-Id: <20210506010440.7016-9-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:33:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 868959f2-6bf3-485e-57af-08d910268846 X-MS-TrafficTypeDiagnostic: DBBPR04MB7884: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C0nCm4nzR7eTaEIgRVJC4RnpDW9+1Ajg1f/mchI7iGeQCQ5anWF87LRNf7yO6493q+wLO2gS13ma0qNHtU5DXb4pDwAycD87dnTJmWPbnt/aXlUrKcAv3gjWEfBxCEVQA2yblwmVdX/kINdLTpp3+QRDh+960ghLJnPnJeVdbcUG0X/vKAmRsz5EFwcrG+/yzdv6jd0AU/6vkv389O5ulNTPcR1EFE4xOsi1+xJkOz8G8HAnOCg0AEnOnU2s/OqvWnMV0I9aTZsNRT2wcjtt38uYvuSkt3OfTfWcqBhETkHHRYvhA9JCE9He58CQr0wkKcWOD7/JuevXjA0p0pj/JYlNx7cFiGN+fs1CoxxHco+Fy55iRm9Ktrd7NCJLVZ6sXUL3E3+M8EKBDqG8HNSrTgj0rSYEnD0rYBWRwNP/0+QTnwnq/BwH+1lmZo3J3bgmNK7Y9j/ekFeBguxOY7MbTeda/BaG/uZN/cwlJLGkQgwc9t4noQ6vp6CCMEOuRVq4OK1w1zmycjMI6wM4jy4oz+idd5OXKijapyhhBvc37wykeRL4EAezVIr3HqP05cIk35+JX2sbzNhEPWWmgDVhnShdkvqzyiAv3fdI4AbCaONFXdKPXk9LHc9Nrn7pw62Os1Fzyw8dq1L++AnBzJR0LA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(52116002)(186003)(6666004)(5660300002)(6512007)(478600001)(2906002)(1076003)(26005)(6506007)(16526019)(6486002)(83380400001)(956004)(8936002)(86362001)(8676002)(38350700002)(316002)(38100700002)(66946007)(66476007)(2616005)(66556008)(4326008)(7416002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: v0UdMTXAE4knzquRUQR5dx6puHp7h+OTV/oBlqqVbdenV8K3vRMUvuZV5y0JEpDq1ER/TH/Xbt6WZPgce34t+3cHqsXkBPGHuRsknPmCtjmQgp9QZD/q15mSGpzOAr3qf/LbdeI0A9ns+p1TqPT1ksC7/3gZTlScUpi1WAFoWBDkip+gE3eXVG6DWic1ZL9ZZIoS4KVmJuzfu9ZQxv9hWPsXXC959mBsWtHKJ1vdOE8gI/13ABjUjphGiQMCw9vbeb99DXhtsFOr9pqOLQpzdmUATova8NY3Z2AbVRr27f+puEDwCyX3BpVQGT4XMC2nJuTLLb9eY78cBLq7Jow/SEP6zTwDhR7Ou/PbgMxGiZvPpiI1zuisAQWT/wQaWhIb5xSZyvOxM/p7T0BfQJz5CF1U4KaSaxeZKz7cUH4tKb9pwTwftduGsy+cSFrr7PQvjvr7RpQtE/u/5AFgYwX5zjQRvrJVuYYc2iN51C8eb+iXRPcXEjweYUscy7CVBWKLStJPh3GMuekmYjJRgVoXChKWuJaPzvgmRp0e7iNrCzWQFFQqI++jh26DWxnOM1LnIUwksEuo99AVv1DB04VCSd5lLzlHuq57wqw1slV8J6VV5Ud8zCjxHuL9LAGX1e3JweU2sS8LKd3lsqCkQjVXyH/FpO2GySAPkP/PPWF2IfgOC5K6g2P2rfhL4U88HQwEhOgTsxjlSdmt1wyVx3Zpf4jz2LC/lYcnQdfNpnB79tMCaqYI31u9ODx4wV44hY4K5syJScUfYSnge+qwb2iZt2QjUHo9rjzJXQt6vDWbs+872XG85ETCJZ0HXD5YtuNtdSCPOJ/7jUF5DoYJN5L1wPqFQ3kvQFz0RCdWB/0Wm6ncbFXylE3OaNj7wocrOpR0ySaf8VWfgjaNTD0NhzRs0O4rJplPBnf7M+WhSbmufR+/vsJ64TrPQfj65oczrcsL2u472O2Uq+vMSxi5L+h6KntyOUPVzZdNxfn8uQgBKsiaEwGqLqvf77QKih4llbxznf3WTiO1qWYc9ajFVd/kr1Nn+iLMqp01uOpRI2ZgPCFmbnCJBuhzFG8y154xjDOlZtp10WnziELjZGi6cATCFQmJEkxSungltIYIZYP3XQDDMn22Yu+xDn6rCZWEedQnSpXQHWdaxHl3UFlVrcVHhImT2itCQy25OaBTiEjhy7FBvyBo/0D3OzaVE7MCmlGhENJF0NZx6IUAw/aUHw9J26xfAEcV4ix+qmMFgJflb22kxCm5L/taiXTqR/0codAKelaMQUgCItmjCq0V/7GBxs8BB54DndydsK9WyzwshJsFC3DcNlIxLwCpkEiRlq+b X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 868959f2-6bf3-485e-57af-08d910268846 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:33:13.3187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5r/nmpAdsokCs/N4DN9t2TN+HK060bOCQz5Uf7yIY7i0lmsVCZDiqfRenVZ5V8H9zxEiVpJDyl4wnwX9+/rKqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7884 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_174759_017845_419B6027 X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach For some domains the resets of the devices in the domain are not automatically triggered. Add an optional resets property to allow the GPC driver to trigger those resets explicitly. The resets belong to devices located inside the power domain, which need to be held in reset across the power-up sequence. So we have no means to specify what each reset is in a generic power-domain binding. Same situation as with the clocks in this binding actually. Signed-off-by: Lucas Stach Signed-off-by: Peng Fan --- Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml index a96e6dbf1858..4330c73a2c30 100644 --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml @@ -66,6 +66,13 @@ properties: power-supply: true + resets: + description: | + A number of phandles to resets that need to be asserted during + power-up sequencing of the domain. + minItems: 1 + maxItems: 4 + required: - '#power-domain-cells' - reg From patchwork Thu May 6 01:04:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241387 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62FBDC433ED for ; Thu, 6 May 2021 00:36:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D65A2610FB for ; Thu, 6 May 2021 00:36:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D65A2610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9rEpqkshMG6azGrUuu4CH39lslZZuNZcHhtzAdWPyp0=; b=Ngh7zlYcND9IqrxqKd+4UdDti O+Lbj8/bNqNkMzmrkyktWstHkX0JJaMstySjPgUuYo/JDknr7YbeREjKlnyhXIECC09UhRPBkv5c1 SZH945faA2HzOIcA9AZCwRuTUNpCs/+8Di8/FXptelNyRoDOhUzgylWvz3INix6nJcf8G5/RaZWCz JUF8Q+9xGn1c6bJYCKFJvPzwXPEGYoahniiSPLZcPooOR9GaTJzrFV0/9tpgw1NaYKKfIUXQijvx8 CG0xMCrN78OfFfY+DK7+8r+phWT2BrwSv2saq1gwNx5pv8aYQNmk0te+hW4S/6CvRaQCQbfojXH+a pcsAtDYzg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRyA-002hqZ-6Z; Thu, 06 May 2021 00:34:22 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRxF-002hdK-IP for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:33:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=IPE/rxdTRtEJdBlQ2Ie6VPB8afos6/Z8WEhpD5L4zBM=; b=EzmD9YiBAcHr1QJ6NUgZr3/+Xm MNKQK9vZpjqFV8d+Mb8VxkT5KbUd5fJSwLbfvxkYZ8A0IvYEoMHhSjOQ0F87dK+uTO3j3zXqo22RW dF9L3CzGMXfVXqSzwube2y8MJhpXkS0sg+iQN8xLCKyUOqHBHMtN2v7xbOAiCbP4bqIrOXDYwEN0i 5meNPt7uFKMS231JN0ErAqWx1YdQTydPXJyZFEzhz8vJFKzFjLgPyk4HJLmi8qcKYuoI/e36eXPTO dI2TujjstuqI4/xI0NQFiGcCcco6HcVOtSM5DLkU5X0cg2HYJl37HBYarVbNNujjLyYgTSEIlJ0ug CzfVakCA==; Received: from mail-eopbgr00089.outbound.protection.outlook.com ([40.107.0.89] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRxC-005RGt-UC for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:33:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=meT8QILuKZFejbT9JuxQO+nIRiu4eD1MwMXlJ652q/guEX95JjzWDn5UJis5Nz7Dy2TTMgc9rYKQ3ZxiPPJUw9c++BnPmsp6mbPmGE58MBNF2IS/GjKlbSmO5h7jW2s/6WnIpdLZlKWelUngsoyyF37nXBMnFA4ZVGv2qahJyt7RDKkOEsmFCJNfETOwh2iV1rlh9rPnWiQQhGp75WiHSR7Npi4L6NdJ6DPY7sOHeY+76J52YWLGh6a3H8TP1jAe/IUdXM1+jaWkp4VJHhyJjzsvd9IygmophqBZ3P9AYjbPcDHFIOG0ElHkWJMBbcqVpqacFlLNoMuZQF6/+Znp0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IPE/rxdTRtEJdBlQ2Ie6VPB8afos6/Z8WEhpD5L4zBM=; b=AfQt1lta/wseO6XRTANjhN/dxIAn+hszSS0gQJOJNVNH6gGokEMhjGFxHe9F6aXwsdeX0e7mzMQt8cjDY8ETZ95b9UDu1Qv1NkNePqPx3WBTGR5jiAwowBvFfO9w88Fs3ozscuGbgoTCyBMARpKcwzY3P+oiphhiTN1ZTn5h4t4QH8FHV8dZFEvU4XTfJM5cOioyqqsKH+0MVjX4PmZrWrgkTUiQ9JZgIODexsHe+idZ97tiI3cLE75qJXs2IlUT+Ef8/SaFQSstNhw4DCJmQIh1HE+KW00baCkfVhSWG3/SZ1UHrnmqSeZ2cJgfsTX+zXY6gqeDTHQXuwplMFcxaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IPE/rxdTRtEJdBlQ2Ie6VPB8afos6/Z8WEhpD5L4zBM=; b=h8CZRH2kRbMoLYcInqHIN4az1maEeMq0SxdxNjVrIFml9MDDD64jkfqxV95b1VQBqjXTAuUpV3eSSgw44CuiDbVpipf9h3TZWN7QBYGki6bm/lQhjsQGiiwfrCE2J5+4xJEuWcFWo9A1AGVmVZ5LuwwhAkRCy5cJuWE9L6djKuo= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB8PR04MB6714.eurprd04.prod.outlook.com (2603:10a6:10:10e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Thu, 6 May 2021 00:33:19 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:33:19 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V2 09/13] soc: imx: gpcv2: add support for optional resets Date: Thu, 6 May 2021 09:04:36 +0800 Message-Id: <20210506010440.7016-10-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:33:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6a886ec2-1d8f-4762-8175-08d910268bd3 X-MS-TrafficTypeDiagnostic: DB8PR04MB6714: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /khaKrQHtmBtGiRMl/kOajzuoxpoO+loJaNnEeNuE0+aUaDNdp3J9SLpaIb5cjab4SLpyqM5UsAM9CdtVIDq5vKg/ix8IDPzm9+mdT6m3mTV2MHn0xuS1gykFThKPFGBDJHlc6yro/+05BfohwMaTXQe5cQdIl1gm67I0QnKDOFlee4mlsIT55PirkNSmmoPbisT51bKdP6MEpiHwRerxmeHBQ33YZN214xf+RuR6jZnaVJqMHm+mP3TfaRs9wupd9U4bBrQpzE6XLKImaqiT5oRfWpoBHddqq4It9qfOnDUT7xJtyWt8R+Z/VfKrApQBr/OAgWlxNesf5T3YZzSg3Pf9UttVCMjH7q1PrIxTGE9xfJtWDPA2ASvOINOtgXGRv0xrIQsNeIqmK5hEYxxWAFAGFekT9yMoB/5E2fvwYQPZ7NJ5JQg5O4vYO9CY5RLSAy7OdiQspKzDp4m46N3ZStkTA6HNoeIXadCAd/c9DYS3rVZponkfE8xdI/NhegH+VRFRr2OnD4yz7vhFlshRROFH/YneyBEWNnlQePP/MtOCC25dH9RUaxbnuPCbAzaX60qXI+AwDCEbkt316rOpOZsCThvRXszDQ1vE3Elkj9Ih65FftjlQj3WI2OkmTRvaiGfpRJH6HDFCsSzsM+Www== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(52116002)(86362001)(2616005)(16526019)(83380400001)(956004)(6506007)(8936002)(5660300002)(7416002)(6512007)(6486002)(316002)(186003)(4326008)(2906002)(6666004)(478600001)(26005)(1076003)(38350700002)(38100700002)(8676002)(66946007)(66476007)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: FP5hNO/ts8C2Wjwj7yHv3AByHjgIFPVDHAB9UrBtSOLzpiRXjqn9VFtzL7j1tg0QWIfV9wnrM2ZReZOy2JhcuA/HCQ8j72hmQkf61zu0tyEF1snmK6LlC10rfEn7sC93icFLYrcZ2QseZ8JWtjJcM5mjmBi+D+ARGbSE/n8wzR2Z0GUhz8iRPrN50Fzk5F79Zp0COg9o5P7Q4JfDr60Ul70dH2ljSJrkNtM/Zf9W5tXvw+K/XzaVSyYbeWVlxg76WkG+r5GXwtHhBTkcqP3UjglyxiH6FdnQA91dGP0NBhi6PtiQniVUBfNX5C0ESJjJ2vVX+DbItXl9nIqvxn3ROKb3kKCwJufKDri5QpkIBAxx4KQdsbq0S0F9Nn1ksaaSiiBRwgWXt/tU3+O96gNfFmNrTSUo6trzHhNKDwuKZweGoi8q8uDr8UWNiTqTzVykL2mUs75bpJxC1KQtPIZFkU4c7c9/tvRz9DCf8r9OLN94x26PnsiCo7SeaxZWDONzDe8li0aYphuC7YtdVNQ9qMcl5JkaLljpVBpCCc9EMTGaAMvfxkQcNRpsQd36u5jgGTwWirBFQuEIeZkI0EKO6jOflTy5Y0iNSH1gnibhK/Qp0AD26C2ML2mzn/fNUaU5b5iVVZ5KFkVB5x2eAZjf3X4GJvv9ES+ML8ix9HktbHTnz2tK0NSqAp32L6+l+UiD9us1w79tqpzQ3eaARfHLE5WTMVlT4mVoTd8mjBsZ6ltQgPrVvvOvs4EtghD+1X0mAZI2OX9roYd1hrbhso4X57mdKngbD7mpvJ8fI0f1ZlJB6JbJUNiT/W4OaW8dasiC7epx1wcJv6qnOtLsaaZC0a5KxKf2md/rNIo+W38RBwSkT/yK3FJckMok9khQPNJTFszzx6ZKatrVmad9LT/A4OX/rznsFOZfwX5wQXLQRabXc56Nr0dUkgDBxeMvKHAMYoErZ7GeQCttwBbdWvvstXC2INEziB4o6NlRRT7SnTjD79rGQ2piqRSNf0feMxxZHsxHVABJ71UgxypQME5h+ALtbgU+bCHfqV2Ddi8X7Qn53VcSID979YIuQavK9mOtvmei4NiExm90ghvjclK9paqUlgOUadBhADYLui/IioPcheeXF0p9cY735g26OL33oeosybpSaPmDNg//ENcXTKCKtc3C7sjEs1BbjILxq+9SBTrP1X6Aq9CNeVE/CTBxDbeTTbG/akoxjyuiWmS27KpxrKOX+mDgm18HFp81yX9EjSEeUnH8wie0pJprDnlm0rSGZpglGal9cZ+J+dP228e1QluAtat7P/EnDF9Zgn+WC+rtyO4aUwHDLdn+92HG X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a886ec2-1d8f-4762-8175-08d910268bd3 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:33:19.2070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MfZHTaw/JSjlELj6noDYjTujdl35PR7uoagyCCg1yMXJWyTvqRd4HEGRHHbJlwsW6+coJvuyd9xdrnY39qs0zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6714 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173322_998281_D99365E8 X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach Normally the reset for the devices inside the power domain is triggered automatically from the PGC in the power-up sequencing, however on i.MX8MM this doesn't work for the GPU power domains. Add support for triggering the reset explicitly during the power up sequencing. Reviewed-by: Frieder Schrempf Signed-off-by: Lucas Stach Signed-off-by: Peng Fan --- drivers/soc/imx/gpcv2.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 0428f0eddee0..341c2352ca08 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -108,6 +109,7 @@ struct imx_pgc_domain { struct generic_pm_domain genpd; struct regmap *regmap; struct regulator *regulator; + struct reset_control *reset; struct clk_bulk_data *clks; int num_clks; @@ -163,6 +165,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) goto out_regulator_disable; } + reset_control_assert(domain->reset); + if (domain->bits.pxx) { /* request the domain to power up */ regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, @@ -185,6 +189,11 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) GPC_PGC_CTRL_PCR); } + /* delay for reset to propagate */ + udelay(5); + + reset_control_deassert(domain->reset); + /* request the ADB400 to power up */ if (domain->bits.hskreq) { regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, @@ -540,6 +549,11 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) return dev_err_probe(domain->dev, domain->num_clks, "Failed to get domain's clocks\n"); + domain->reset = devm_reset_control_array_get_optional_exclusive(domain->dev); + if (IS_ERR(domain->reset)) + return dev_err_probe(domain->dev, PTR_ERR(domain->reset), + "Failed to get domain's resets\n"); + pm_runtime_enable(domain->dev); if (domain->bits.map) From patchwork Thu May 6 01:04:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E3F4C433ED for ; Thu, 6 May 2021 00:36:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA7C861185 for ; Thu, 6 May 2021 00:36:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA7C861185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o9J+Ys6TqPXn4BUZAioaozwSmdGDvS8f77VEIQTQXx4=; b=UqwmWGMdCYHOY5QgsXBGzsSwL 8pz2sVP2I8NDZGinNeUdTnfUkH1tWnXr+ecLoM2TE4SroJvyAcpVglDliZAvgHmr85EotJ4FUv7mI iKKv9LOMVs6igJhui9sH2kbJMKK5m2WjdsV9We/VQEtDnm/U7qj/2KFgYy236LDHBmfZDgRao9t3u hGGz4/rSaQjh2D/Gd26HLadwvKZorB4sB7MrVOvhyFHRZ7cMczj5TccKCExVuvc4AfMEopJ2b/75E D1G5bN57EGPO2mFUEL+MYNqDeIG/6wWrVdwOHDIXTiWxscpT1BzvJJTpZxsOIus3CRSs1hmreYRi/ 5/XVC+d1A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRyX-002hzN-PJ; Thu, 06 May 2021 00:34:47 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRxL-002heI-Gu for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:33:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=AyP6g3OPDClmOeD3tHdWsdhbk0hjNCDKpZrmsGGZj88=; b=t0Du/iKGlSDIdOtMDIKEGI0i5f jqOTGXiTDKRjOtVMnxPW30b5TUjCBWsdnzpFQ5Tb4i5q4npV7k6pi9hEuurAHbieBjh7Rii0hkPez 3rDgZjecyw4PKvFQ0C9Y3Uiv6sTMX1o19zmd6WtXMBRJjPITMEltl6hIHiWWAhsP1AB8Vf5KYXC8y 2hpElmWnJQ302PsaotPCpYDkA6/79BkzSu1/7HSVR/3kNc6gzGtFPwLbbUjnq4M9QbtJcTsA6bP/z ppqVZuA/EKq4qleXLdlswGAvyvdxN7yh5FyiSqXeVk3bekS/HrAAxYVRZYdChxCXJc+titd/RhOAC wRFjhvCw==; Received: from mail-eopbgr70087.outbound.protection.outlook.com ([40.107.7.87] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRxJ-005RHa-18 for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:33:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dTzrwxLBs4DA4zt+K9kND2WD8634Yj2yKhWCun70WJwxLWdrtQjAWOP1i1X/haVPL5EaNL1fyuzsqAM2BvcSEz+EueCaDQJbOW40NwF1+acnLi6ESfVo00id7vTwqTayXN7QKLFV17Dik9oWTTCHAvXRnuBfL0COxwrFl8i0Sp/7IMU8TsX39sGKu5eRHVns//NxhpPdvxkjtXEffn3dSGs3e8Hw5cGutJb+fmsKSGWp0VQMyTafRaxYxdOX7lLkLCcXH6Tt0RhYETxHs3OZKC8ZONEWRW3Jd9Q0iI2BPFDraAWAEUbrnLTLicNJU4fDuV1aOw5L2cCOzA50e0bh1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AyP6g3OPDClmOeD3tHdWsdhbk0hjNCDKpZrmsGGZj88=; b=oAVdyTsx/ZNrBlhTKJEbE1q/GfoQwwivA9Bxh9ZobXew3tJojOHNU7i8g5v8U7+1yHWVRVEK9QIuXk0s8q5CrDN86SYJdYlmGCRuXXI3ml7WrOUTiBbL3vfixv8rUj2KIpcxk5dlXU4+BGE6Tbv/Vd9+arD44SuDonGF1UtRCFg9a2fjb3oNtYUoXmGppLGVrQnxOS0A7v8knhyOnHZ017otNq7eNbasOR4ltlVT61ERoHV6RNcKhQClyuBTmIUmkYQbj6uJdYM4ggs6OiJ27dUz5uXZ/xVraA72OEVni/IrvF0m/hryIcMafP5/Ndcko56r6QtQOYUpfHYzuYyYTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AyP6g3OPDClmOeD3tHdWsdhbk0hjNCDKpZrmsGGZj88=; b=Bv/sFq8iFbC93UnPXOeAtDI0tZmEpQu8GBM4ijScJ4tGJl1tR6UtJq3akdQlyE5ijSTjH4QNlg0CFJXVIOSo0mEcMGXLIFW/JgqbQUqUwAr3KaVWL3uexnlZXTrbjVgBcNx/gaDpaofe1CtOd7S+OhyU6HBEDCMuOxzcl4BxX5o= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DBBPR04MB7884.eurprd04.prod.outlook.com (2603:10a6:10:1f2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.41; Thu, 6 May 2021 00:33:25 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:33:25 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Rob Herring , Peng Fan Subject: [PATCH V2 10/13] dt-bindings: power: add defines for i.MX8MM power domains Date: Thu, 6 May 2021 09:04:37 +0800 Message-Id: <20210506010440.7016-11-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:33:19 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f1e58be-a93a-4883-ae85-08d910268f79 X-MS-TrafficTypeDiagnostic: DBBPR04MB7884: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:497; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wjl6X7ji3zTDieMCNiRm2PZZdmv+RPF075MshrL26arFCNJK8R/yKY9zdC6J+1O05i7zXL4CzAAaG8JS4HJZNqIzAfMEQLT62EwiUnphoewYvj1E6Yz/fo/UT9doKSMQFtuYlcfg+N1juh+KBHT1VjNAX2nFCVbZK5NDaYSMlj57Yb478NQvspxZ40ExFuNTkCnSDQDjnc79BtW1Rm6r+BWWyAQK1XfNwGzKFnhhkt1/dV/MotXd27X0+z1n0FR4YCYfx3KcgOVrBj/NrjIiofnQD3cLg5Lqj7HNgsL3M8vVILuyeXKKVMysSP8QKhADaqGP8gB1Mp8uCJee3IWfE7TTwbl0909fIPAX13APkA6UprjsMgv9qsoiSt+fZ1EMPJXPTS6Xoava29yuKAgc0r369Vj37tDCVhclCthwTJxQOg6xPXBKW6C1qJGWcX0K3gTPsLvMzZVfYb31411PqWWDRTQtHDLWI2/5EgmhZ1ihCkNxi0oxKeuCMuYcwMEnAcCyCwRU7Rf+yI2jxaVez+INfD/RIsCVnMa6AepBopJVrPIkm0v+RBeg0yPkuZYN5eOw+dkFCtGTuXEDnpLKFl6ImzPqSKf6QLMIbXqR0ntYAHgw9WukefUfqTu65DeSSmlvBbdmYh8vDPwKMfS7fw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(52116002)(186003)(54906003)(6666004)(5660300002)(6512007)(478600001)(2906002)(1076003)(26005)(6506007)(16526019)(6486002)(83380400001)(956004)(8936002)(86362001)(8676002)(38350700002)(316002)(38100700002)(66946007)(66476007)(2616005)(66556008)(4326008)(7416002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 1n0qLdXBhYXJaKaTps9NWHfgeed1um7IcOT6OohzxDMNVF/ntoBwHAVzbU9xCxxXcWqMW+E5Bj7QyJ/6d/UVDfoQra5xze90NrOhZozy7OQJCCgDRMBzFFqaJIajPB0lGKfpZb/gOezOJjB8+g5/FAOJRKeKfK2+N9Abqg6FJBwEXmGDLpxt/ZfZyFIDbjC6zH0T+SjIxnkQRy4JMZ2iNYqFhsTlqB5GwqMMRB3jlTRTUO/C7bTcMxLoPYuyUjyXPlVVMLJK0QVWoWyW8/zjpoUcU7CaQl62iVv/ix7RNGyyGdWLFQJcezXkyjmAs32y73uupIB6+xnKSTJci7DYjaple94PEhSVyp86gu46R4lcFxXep02z6JitvVLkJQBUMMSSEJArmLrb98ZX4jmkRuMbi3vyjfRHJw/Egrev70C7TssiT+Kucuv2Gc1IbR+HsrLF0znhI05go3NYsxfIQ3syyWirCjnmVeRES5KQxLvgmqBttAkmSMkS92ab4DOnu/eLOt2El6VjZZDOwxbyhpwiKc2uI+blk6xBmRiW9KteSgPWRTRu8qz/2GU1H9abzIx+vZqGeUSvNNcGJiyUlsF0/KgV49CcUAtW4Ju12oJQX8dpTjbLZjom98qTUdto7DyvAu5dSNwUfXCXd3n+RUMlnStNlR/k0jvTBv7yFdwvdric78YtBgEU/o33c+opqunhfUeuHb7tbMVWAe6ZPGltpA6vtWTAwjTIGMY6a3I4VrbrtvdgPOv+w4zOkGnCyPqqU4aTCIMuGoXPa01U8b7VyiexCq2KJcwDSNi13ceviSoasV6FzCsHWc/QrxK0IBrjyB8d+qvpasaUWSFiYAg94ykMC1EnMzymtn7lCdqAbqhlPTvxbvr6qjiGtnEz2RfalbJkw1zeUA6HeslAHLEYvA5n8sTijZKPefyxugoYoxKH7ZzIz2PFMJN1wiremb1I8epBObOUdGDAt+0KKmgEjUqsOiaei3QKQ/irrV5QP1h88vS3CXGsfvIHGsVmI8bqTLVHEsHIDMtm352BPjQxmD9DGlfGXqwdT5gP88fne9Apt8PukNJOaqP90tGn65VejFpA5cMIi1oRlaSDgm/RnZOY1Sm05g9GKqQJBX6mauqEuwfBmvHvz3R76dJ+wKDH9Xy7PcUs+KHf332VCeD/8maa3IcJVOnH/R/aSUq/vL/C7P43V8Pm6p9AriC31LpQh2jQIck8nC5PEHghDGtzv6PAYRUFZGIt8N+ljG0Sygl2bZ57/d0C8SqQw9tEH9FFz9rxRQ0Ud/zVNSOg2czp8n8w5ZVq5RCExwO1M30AhaSW2SNJQQC/daJLhPH1 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f1e58be-a93a-4883-ae85-08d910268f79 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:33:25.3543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EE/jafwHPmezqnJ4V3GqDTcUErJXxkqBSGhIx/us6GeR99RvUQ35VjKgxpb2SCBRQmtk0/lnE8Lgpavf8VlwaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7884 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173329_096995_EA02FEC4 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach Adding defines for i.MX8MM GPC power domains. Acked-by: Rob Herring Signed-off-by: Lucas Stach Signed-off-by: Peng Fan --- .../bindings/power/fsl,imx-gpcv2.yaml | 2 ++ include/dt-bindings/power/imx8mm-power.h | 22 +++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 include/dt-bindings/power/imx8mm-power.h diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml index 4330c73a2c30..d3539569d45f 100644 --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml @@ -26,6 +26,7 @@ properties: enum: - fsl,imx7d-gpc - fsl,imx8mq-gpc + - fsl,imx8mm-gpc reg: maxItems: 1 @@ -54,6 +55,7 @@ properties: Power domain index. Valid values are defined in include/dt-bindings/power/imx7-power.h for fsl,imx7d-gpc and include/dt-bindings/power/imx8m-power.h for fsl,imx8mq-gpc + include/dt-bindings/power/imx8mm-power.h for fsl,imx8mm-gpc maxItems: 1 clocks: diff --git a/include/dt-bindings/power/imx8mm-power.h b/include/dt-bindings/power/imx8mm-power.h new file mode 100644 index 000000000000..fc9c2e16aadc --- /dev/null +++ b/include/dt-bindings/power/imx8mm-power.h @@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ +/* + * Copyright (C) 2020 Pengutronix, Lucas Stach + */ + +#ifndef __DT_BINDINGS_IMX8MM_POWER_H__ +#define __DT_BINDINGS_IMX8MM_POWER_H__ + +#define IMX8MM_POWER_DOMAIN_HSIOMIX 0 +#define IMX8MM_POWER_DOMAIN_PCIE 1 +#define IMX8MM_POWER_DOMAIN_OTG1 2 +#define IMX8MM_POWER_DOMAIN_OTG2 3 +#define IMX8MM_POWER_DOMAIN_GPUMIX 4 +#define IMX8MM_POWER_DOMAIN_GPU 5 +#define IMX8MM_POWER_DOMAIN_VPUMIX 6 +#define IMX8MM_POWER_DOMAIN_VPUG1 7 +#define IMX8MM_POWER_DOMAIN_VPUG2 8 +#define IMX8MM_POWER_DOMAIN_VPUH1 9 +#define IMX8MM_POWER_DOMAIN_DISPMIX 10 +#define IMX8MM_POWER_DOMAIN_MIPI 11 + +#endif From patchwork Thu May 6 01:04:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241395 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18EE0C433B4 for ; Thu, 6 May 2021 00:37:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 465C061185 for ; Thu, 6 May 2021 00:37:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 465C061185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tDWVk0+uJm/BrUt7S1TNtE3yUquQN4kmriKtfOvCZK4=; b=o7yB8uG1B/Kpr652CsGyQxppH Ms5i+6AsqRl0gXG+sTMnE1rUl3WcY7U5mj4MW6ZBfE3ae0AatGvXdNv/4Z25TiIM3kqn/LPWsA58k e35WKMoU6b0G07jLcnjJlM2RwP9+UDYURFVLa2Rs+uJ4hHtmsKq9kk0j5tvBzbwSYJqwd5raw7W7k YP31l9MY05zM1vKajvVDLwl2XnYs72v95KTMrqGdZLNI7645ESzmamBJF090gEiiuSFFnTH5iI/1v Wq1BB8FkO0pqS9c87nZzqO0muBumeSgT4urBsS9mUPNgBLcBQpGh3Azgs/R0j8PMJe6ts/XDE8Yf7 Z7/nMQ/lw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRz1-002iI7-0c; Thu, 06 May 2021 00:35:15 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRxR-002hfS-K2 for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:33:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=y3VprvqBD9QxOKS2rHjd+ExdVQ6idh0VaqPtCNL/eC4=; b=U58OLILEkDiEP29OSj75ZLwuHO v9qIUOL75jM6pPPChvheHTWwXI9IhNkcFTwzpba1SP+JDwmPzTfwaBgkSl/lWx9TQvlCP+I2XfJlz HuFEQe2iaaeMVwWIZP2hStm9XqB6g9t6wky2NoI5/PdCZrPDooZPIuTM6QUDqDkbFqGHoYsYg5HXN 7ds1TzwcmuyrfSyIxeGlNN6Hb665W7VD9itp0a/ob4WgSrz89KVPVUnXRD7Ffuza/g4lzHrfPpjiW 3Aq27IDaIiP/99kn6lMTukDcnBCFheV+hG+CprKJf5C0Dq4QDPWpH49fpERJjLfdTHTLdtY5Icmay fH+98uQg==; Received: from mail-db8eur05on2055.outbound.protection.outlook.com ([40.107.20.55] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRxO-005RID-KY for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:33:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SrpNRnnK9HVvkQRNCWr6J2BUyteK2kz8QvKy4V3dOjmWuDXOmr3Pxe/ERUsJuXFkA1m6AdoLTpNjrRflOk7D7fsknqEmRlYZIEdiF6f5+A85RS6rnIxvGHgowqfwzNvR2JlLyQoQT83Fy5+VC/7NUK6fkZKcRmt4uWv4DbmoCxrxK89zz9bWaSJTsl1/EpdlOyVr4ZStplphUw9Sp5ONKCrMTBjCZGzitVWSAxypqcxSdjeVKs2yc5CXEwF5RVcamfxwm8GU7Pk0Q2LrZdaMqJ0bw5zmR/oEMUTJltPlI0s/r2JwGI9fU4MFE8HWSB4ees2tOFqqgiwqivPGbJnMmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y3VprvqBD9QxOKS2rHjd+ExdVQ6idh0VaqPtCNL/eC4=; b=iZwqwDVzu/Q8y9M8uf7xD28WAAl0RMs0UNVzKJoh6i1EzEVnFmQQds+4hxY2KybbwnBnn+XShJTD7fBMZudFF9nBndtM1DL8FyX1sy6+jgQKxT189GD0SoZfjuuojl13aCk9bU15RYG9ErhyW53cxUtye38YKQZ/ahi7qZDcItypOpT5AQRhv/DQtn5ruTXqcGqVz2DbSKsg6p8eUrPI5Nasa68fuYjuF5gBkEJcRKRq38UfMgb7JimHWFvGWn4zkTxSx9SVysgDnZP2w3KUwHlkoHAzvzAcK/JKVmbWQ5/D8E7OWMz8okkz+HSzgFE7/+48ekN+bzzv9EKWuAusfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y3VprvqBD9QxOKS2rHjd+ExdVQ6idh0VaqPtCNL/eC4=; b=mmV4SLN359/DgEhRquG4VFAIZYgG6GVpkAYYOC7fNzgcRLG6D0F5cheMYH5ZFfxb+ENE1M9eFCj8cSAHxFAOQ/teUkCDOaST9l7X4hn+AZLumpL9jUgqPLItd7wF4KB0Ap/cc0DRPJnWfDgj2Ge7/S5HtX9xnmSrZYT2nIzaWcI= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DBBPR04MB7884.eurprd04.prod.outlook.com (2603:10a6:10:1f2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.41; Thu, 6 May 2021 00:33:31 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:33:31 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V2 11/13] soc: imx: gpcv2: add support for i.MX8MM power domains Date: Thu, 6 May 2021 09:04:38 +0800 Message-Id: <20210506010440.7016-12-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:33:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9af523be-845e-4737-d8ab-08d9102692fd X-MS-TrafficTypeDiagnostic: DBBPR04MB7884: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r/MwgXWiR4K6Rpg2rcQKhNEUqE+WCvrI8h6pba09id07NVfBRFkxZX1ChSSIuOsj7369V67rxDaCTe47npgUyByEBOsiHOrVYV8kufrccVGlqb0IEjd3SYdwJu7KSkMW32fWBj699EqdT8gfA+9yCOOB6hfYwYf7AI/8F9nH19cDz6Z1IlDsLQVD9kgYRd7l1n5vXHXQm1yl5UD69GB79WCWqmUXoMqFJS2Ahp3ySRCZe2psrGFrKKzzqGKTBQP6+uIVNnD2R8kDGf2IEtR+B5jpSdjzp3OCZ2MK/IUm2734qXRsDSz1V6sXG67kugTce7Oz7qC/v+YINSvIXiiKO0od/Oz5thWUprm+LlLzc2KvdheC4UfYczApkjdFzOSKqBcvw0dm5hDlNT82K8dTXW1LcOkXPvbCuhXnx0OXkV+a6BGGoqLQkRur0QchdfFfJJc+YExhuygWPda15uYmXKSrB8UuZPf332rGrV7PTcvAxRj7KX8Fw179rL1y69loAAYPPfn9u2qGvJ6Ju8MtFkh+oRf7s2JnB6Deb+3cGaTe/CaIuanokUuUbB/WCsbH5tVbZzhUaOGEdqHZcramYU5jZEWYD+Ul4JbB0t6WOx/pIpTs2ncp9ySwAOIzboRDZJdLuQxDUJEou4AxE8dH5Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(52116002)(186003)(6666004)(5660300002)(6512007)(478600001)(2906002)(1076003)(26005)(6506007)(16526019)(6486002)(83380400001)(956004)(8936002)(86362001)(8676002)(38350700002)(316002)(38100700002)(66946007)(66476007)(2616005)(66556008)(4326008)(7416002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 3i/omY/Pg0418+3xqdN8zkp0tiBzCWZUEfuvQCa4Y2hff6V14bn4vNcjb9VPL4kdxJFGFWfKqCueufP3HVr+DEAFZ/AyAHcYAYR/f3vArosomKc3CuwwgFfCjTP5ne+n1qKDwBB/iNiLNjMR4Y1pZb9MKo63wN0Iq0F9T0MVKD7iOd+lcZAF4qyZ/MWT2MGOBfe8U6o52Zns8TIzXa7N5f+LLhJaciDNkmSAWbRqlSoSI6UbWMNnL/bCLZdE2xTzP4wD/b6aTwrtmkMxxTqSS17f/t3K18u7h52QdQo81Y5sCj2A5D4vubCdu+3/vc9EVP+cLzbtFT+D9pEOwe651GNtuboTO/yxCMjlAJShDma/072b7Lzqak8RWjVUqkVwscm5+JcWG0Rty6rHUrCUxXfl5aBNHuMSspUm0ptnRLE2numwhRxWZ/XZTZcsG3L+96BbPTCMhOY5l6czOArTjlE6FFj5BrUJI/vBnpO/5S6P6AAtSZRZPyzMV9qT0XJXltCGeFiv0ui/DSEd5R+spRrvr3UpJsOw869tCB9JCK6VyyYvaXrW5GZwm0NVFOfzP9wMKq9LY3f18YAIL2ANGuwXe0L1ATB9orQ6DWanXIEWhQBTRa7eFab3eP0b/8vhhNXpDAGPnFRqDrjImOk1LwR0ElBgT2LGjtYN3gt+ZcwAbLzlQMReSR0Uu/p9Xjo9i6C+4T8Ta25ZJD3DeD4aMvhOC6AciqurNs+KkQLovJ/lDFZZ56SYtt8ILKHbv6/4u4Gn0AzCagUyIEG++HB1qaFBFv3pxg6NsiMk/FsGt2a2ae8yyhsifMmDS+V9f6Tc1jUORQuqO7zISzQS3GSo3DTBDhymshA6OZaxG9p4Qhl2VSQW5MeBa+hatVgL8x/vf7ocs6EFQUSgdK0uQ7N6I/Rc9Hgy0DrHjdsMI5n5G5EmPHDcpWiNEd0c02BIUDEPgUXH0i8sdAGd85zNHyvMoaET8oSq6gJBrR3MPln/yAQKCdwZeWyB6+bBOvv8Hm5JsRV6fTCKwrXRgfdGIt0OGozL0PIaDGvEz5jUhalnG2HsDywnGVPaokJZyUMaT2/88cp9MaqHqx0UGgGzuSo4/zW/wq6z3nsaIfLwN68cNQLqG5absPVfGjc0JfCBoA042VtVyCEQZzVv3kCAhOf6RdwoHtzLja1ynsBI6f4c5MG/y6na/Fv7SXsSfgyGYFMqc38oqAGWjh28u+1kVTUrRe7PnzuE0QORUr3mpjlpHhZL4rfnoQp093OZAeQDvhXhutH1sYpBFeywEb9L98aPP31f5rkEej0g5qhW7c5aGyE2XD5Af5NPSZ8QBR6+Y+Yp X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9af523be-845e-4737-d8ab-08d9102692fd X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:33:31.2616 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nutk7V6/n4KB7sAeuK6DMcXNuh1YNUXDkwFG2ClUaRw+8PqKFKMGvss+gDUKbstNjjfHljHV52GSceFgUKUPlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7884 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173334_827766_1B9CC522 X-CRM114-Status: GOOD ( 13.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach This adds support for the power domains found on i.MX8MM. The 2D and 3D GPU domains are abstracted as a single domain in the driver, as they can't be powered up/down individually due to a shared reset. Reviewed-by: Frieder Schrempf Signed-off-by: Lucas Stach Signed-off-by: Peng Fan --- drivers/soc/imx/gpcv2.c | 168 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 168 insertions(+) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 341c2352ca08..b9437d6d82a6 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -19,6 +19,7 @@ #include #include #include +#include #define GPC_LPCR_A_CORE_BSC 0x000 @@ -44,6 +45,19 @@ #define IMX8M_PCIE1_A53_DOMAIN BIT(3) #define IMX8M_MIPI_A53_DOMAIN BIT(2) +#define IMX8MM_VPUH1_A53_DOMAIN BIT(15) +#define IMX8MM_VPUG2_A53_DOMAIN BIT(14) +#define IMX8MM_VPUG1_A53_DOMAIN BIT(13) +#define IMX8MM_DISPMIX_A53_DOMAIN BIT(12) +#define IMX8MM_VPUMIX_A53_DOMAIN BIT(10) +#define IMX8MM_GPUMIX_A53_DOMAIN BIT(9) +#define IMX8MM_GPU_A53_DOMAIN (BIT(8) | BIT(11)) +#define IMX8MM_DDR1_A53_DOMAIN BIT(7) +#define IMX8MM_OTG2_A53_DOMAIN BIT(5) +#define IMX8MM_OTG1_A53_DOMAIN BIT(4) +#define IMX8MM_PCIE_A53_DOMAIN BIT(3) +#define IMX8MM_MIPI_A53_DOMAIN BIT(2) + #define GPC_PU_PGC_SW_PUP_REQ 0x0f8 #define GPC_PU_PGC_SW_PDN_REQ 0x104 @@ -67,6 +81,19 @@ #define IMX8M_PCIE1_SW_Pxx_REQ BIT(1) #define IMX8M_MIPI_SW_Pxx_REQ BIT(0) +#define IMX8MM_VPUH1_SW_Pxx_REQ BIT(13) +#define IMX8MM_VPUG2_SW_Pxx_REQ BIT(12) +#define IMX8MM_VPUG1_SW_Pxx_REQ BIT(11) +#define IMX8MM_DISPMIX_SW_Pxx_REQ BIT(10) +#define IMX8MM_VPUMIX_SW_Pxx_REQ BIT(8) +#define IMX8MM_GPUMIX_SW_Pxx_REQ BIT(7) +#define IMX8MM_GPU_SW_Pxx_REQ (BIT(6) | BIT(9)) +#define IMX8MM_DDR1_SW_Pxx_REQ BIT(5) +#define IMX8MM_OTG2_SW_Pxx_REQ BIT(3) +#define IMX8MM_OTG1_SW_Pxx_REQ BIT(2) +#define IMX8MM_PCIE_SW_Pxx_REQ BIT(1) +#define IMX8MM_MIPI_SW_Pxx_REQ BIT(0) + #define GPC_M4_PU_PDN_FLG 0x1bc #define GPC_PU_PWRHSK 0x1fc @@ -78,6 +105,17 @@ #define IMX8M_VPU_HSK_PWRDNREQN BIT(5) #define IMX8M_DISP_HSK_PWRDNREQN BIT(4) + +#define IMX8MM_GPUMIX_HSK_PWRDNACKN BIT(29) +#define IMX8MM_GPU_HSK_PWRDNACKN (BIT(27) | BIT(28)) +#define IMX8MM_VPUMIX_HSK_PWRDNACKN BIT(26) +#define IMX8MM_DISPMIX_HSK_PWRDNACKN BIT(25) +#define IMX8MM_HSIO_HSK_PWRDNACKN (BIT(23) | BIT(24)) +#define IMX8MM_GPUMIX_HSK_PWRDNREQN BIT(11) +#define IMX8MM_GPU_HSK_PWRDNREQN (BIT(9) | BIT(10)) +#define IMX8MM_VPUMIX_HSK_PWRDNREQN BIT(8) +#define IMX8MM_DISPMIX_HSK_PWRDNREQN BIT(7) +#define IMX8MM_HSIO_HSK_PWRDNREQN (BIT(5) | BIT(6)) /* * The PGC offset values in Reference Manual * (Rev. 1, 01/2018 and the older ones) GPC chapter's @@ -100,6 +138,20 @@ #define IMX8M_PGC_MIPI_CSI2 28 #define IMX8M_PGC_PCIE2 29 +#define IMX8MM_PGC_MIPI 16 +#define IMX8MM_PGC_PCIE 17 +#define IMX8MM_PGC_OTG1 18 +#define IMX8MM_PGC_OTG2 19 +#define IMX8MM_PGC_DDR1 21 +#define IMX8MM_PGC_GPU2D 22 +#define IMX8MM_PGC_GPUMIX 23 +#define IMX8MM_PGC_VPUMIX 24 +#define IMX8MM_PGC_GPU3D 25 +#define IMX8MM_PGC_DISPMIX 26 +#define IMX8MM_PGC_VPUG1 27 +#define IMX8MM_PGC_VPUG2 28 +#define IMX8MM_PGC_VPUH1 29 + #define GPC_PGC_CTRL(n) (0x800 + (n) * 0x40) #define GPC_PGC_SR(n) (GPC_PGC_CTRL(n) + 0xc) @@ -527,6 +579,121 @@ static const struct imx_pgc_domain_data imx8m_pgc_domain_data = { .reg_access_table = &imx8m_access_table, }; +static const struct imx_pgc_domain imx8mm_pgc_domains[] = { + [IMX8MM_POWER_DOMAIN_HSIOMIX] = { + .genpd = { + .name = "hsiomix", + }, + .bits = { + .pxx = 0, /* no power sequence control */ + .map = 0, /* no power sequence control */ + .hskreq = IMX8MM_HSIO_HSK_PWRDNREQN, + .hskack = IMX8MM_HSIO_HSK_PWRDNACKN, + }, + }, + + [IMX8MM_POWER_DOMAIN_PCIE] = { + .genpd = { + .name = "pcie", + }, + .bits = { + .pxx = IMX8MM_PCIE_SW_Pxx_REQ, + .map = IMX8MM_PCIE_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_PCIE, + }, + + [IMX8MM_POWER_DOMAIN_OTG1] = { + .genpd = { + .name = "usb-otg1", + }, + .bits = { + .pxx = IMX8MM_OTG1_SW_Pxx_REQ, + .map = IMX8MM_OTG1_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_OTG1, + }, + + [IMX8MM_POWER_DOMAIN_OTG2] = { + .genpd = { + .name = "usb-otg2", + }, + .bits = { + .pxx = IMX8MM_OTG2_SW_Pxx_REQ, + .map = IMX8MM_OTG2_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_OTG2, + }, + + [IMX8MM_POWER_DOMAIN_GPUMIX] = { + .genpd = { + .name = "gpumix", + }, + .bits = { + .pxx = IMX8MM_GPUMIX_SW_Pxx_REQ, + .map = IMX8MM_GPUMIX_A53_DOMAIN, + .hskreq = IMX8MM_GPUMIX_HSK_PWRDNREQN, + .hskack = IMX8MM_GPUMIX_HSK_PWRDNACKN, + }, + .pgc = IMX8MM_PGC_GPUMIX, + }, + + [IMX8MM_POWER_DOMAIN_GPU] = { + .genpd = { + .name = "gpu", + }, + .bits = { + .pxx = IMX8MM_GPU_SW_Pxx_REQ, + .map = IMX8MM_GPU_A53_DOMAIN, + .hskreq = IMX8MM_GPU_HSK_PWRDNREQN, + .hskack = IMX8MM_GPU_HSK_PWRDNACKN, + }, + .pgc = IMX8MM_PGC_GPU2D, + }, +}; + +static const struct regmap_range imx8mm_yes_ranges[] = { + regmap_reg_range(GPC_LPCR_A_CORE_BSC, + GPC_PU_PWRHSK), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_MIPI), + GPC_PGC_SR(IMX8MM_PGC_MIPI)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_PCIE), + GPC_PGC_SR(IMX8MM_PGC_PCIE)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_OTG1), + GPC_PGC_SR(IMX8MM_PGC_OTG1)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_OTG2), + GPC_PGC_SR(IMX8MM_PGC_OTG2)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_DDR1), + GPC_PGC_SR(IMX8MM_PGC_DDR1)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_GPU2D), + GPC_PGC_SR(IMX8MM_PGC_GPU2D)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_GPUMIX), + GPC_PGC_SR(IMX8MM_PGC_GPUMIX)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_VPUMIX), + GPC_PGC_SR(IMX8MM_PGC_VPUMIX)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_GPU3D), + GPC_PGC_SR(IMX8MM_PGC_GPU3D)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_DISPMIX), + GPC_PGC_SR(IMX8MM_PGC_DISPMIX)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_VPUG1), + GPC_PGC_SR(IMX8MM_PGC_VPUG1)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_VPUG2), + GPC_PGC_SR(IMX8MM_PGC_VPUG2)), + regmap_reg_range(GPC_PGC_CTRL(IMX8MM_PGC_VPUH1), + GPC_PGC_SR(IMX8MM_PGC_VPUH1)), +}; + +static const struct regmap_access_table imx8mm_access_table = { + .yes_ranges = imx8mm_yes_ranges, + .n_yes_ranges = ARRAY_SIZE(imx8mm_yes_ranges), +}; + +static const struct imx_pgc_domain_data imx8mm_pgc_domain_data = { + .domains = imx8mm_pgc_domains, + .domains_num = ARRAY_SIZE(imx8mm_pgc_domains), + .reg_access_table = &imx8mm_access_table, +}; + static int imx_pgc_domain_probe(struct platform_device *pdev) { struct imx_pgc_domain *domain = pdev->dev.platform_data; @@ -710,6 +877,7 @@ static int imx_gpcv2_probe(struct platform_device *pdev) static const struct of_device_id imx_gpcv2_dt_ids[] = { { .compatible = "fsl,imx7d-gpc", .data = &imx7_pgc_domain_data, }, + { .compatible = "fsl,imx8mm-gpc", .data = &imx8mm_pgc_domain_data, }, { .compatible = "fsl,imx8mq-gpc", .data = &imx8m_pgc_domain_data, }, { } }; From patchwork Thu May 6 01:04:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241397 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B9BC433ED for ; Thu, 6 May 2021 00:37:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6248A61222 for ; Thu, 6 May 2021 00:37:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6248A61222 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OUQLBf68VyZ9kSPGg9haUgJfNW4kyL85VAjTsrlcU8k=; b=Myws1q6+H7Yud169ltqCkO/SD rFv4Xy/P0AfyTZr6OyTrjgQMtnc/+CD8LusSyAyQY+EjvP4ET8b8MZACzP6D7UI+yji0KIIH42UNc ++B6sTUSfNYFS92lfecEFyCtqHucqxPjRKUcMWFKT9LZ4CfgW2v+2g4Nx3SPNstwIYgDclmZGuA5L jgcjyl78322YzjXtnf6bJtFaTBH4YVN1AhOt3iC4HTpmBc+P3K6FjsM1zT7fhOKXNUrQM2rpWrXlB bUWW7N0ElPyd6Pc7stIv7/s0mEwILhZjSxRxwUfyH5cjqU2n5toWMuVv6Y2AFGkbeJ94KSkPhj3q9 NZ+DCTQWw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRzh-002iYS-0k; Thu, 06 May 2021 00:35:58 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRxW-002hga-VS for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:33:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=yL/asDHNmpVzOan3dx6XGuq6dIgJP6YAMNLDtHh4+Mg=; b=niUsXGwHGLhkw1bCrZbFkAghps O2tpTQdIffSM+hNcekQEhFAkQKzxYBVMhX/vUb2TjuTBvuLxNbSOyMpdvonnANHbbawGa/n3QKdR/ VG0aeEM1HOta/Euqxz8E1J6zVnA/mDtODSMO/MlaWQYmHmb2WNeXooU9YwzwYzBlKTNn+qi/2Su8b cUw3pRu78ShrzDXi1f2nDnjLB/nYWN+afJNZe5JMB5qBzeZXKv/825R9OnydPkf+ixUp5hm06Ia3i fXoD8d+0XMR6XXJTR9+MqrF7ABAgX0rzmzSiPRlgxzAAJCRY36ey9GWmTVErPf19Yg7s9yC1oBPxc wmCKK7EA==; Received: from mail-db8eur05on2054.outbound.protection.outlook.com ([40.107.20.54] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRxU-005RJk-Eb for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:33:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IAenk7iNxGQtiDPmCfP0toLq9c6u14osiUXEbFdwTAXiOp0Lo8O2POWV+7Wed66+RoqBmbKtVZ5tSIBvzROOvuz18Ezd0pW/ixOc7aXVYdCFv2B65Af/HLmApqm8UCA9STrL/Gs6Znr+qwNn6snefo7F3VdQ0n3vAZpQf1MCbl/9WLwA3ynalE/M2v5/Yh8Q/B4vfDkha6ibdHHqQxrM7BZWv7ca2sL7PDP6zy+KAhzmjQBYwK2RAiB51BYczGwTxXikodyQejz8ugom8RngVrNxwsKnZzhpphrJ74JMH3sgO9cNxXJMmN0MjDXe2TwljqYVXuY3ZfgEZttUnub+8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yL/asDHNmpVzOan3dx6XGuq6dIgJP6YAMNLDtHh4+Mg=; b=oOChd55zxgxmjDWA3QDMVIAA75k9NFzyKHGDhObaux+bKYpF3SyAZwDNMIUblHIMKvliMNd9x7fQCy3c5Azs8/8ZUSng1M0Oa7w1vfqCB4PuzmdfeQhCZLO3yh6W2rXKEUWT+bMdZElmSTlavQZhe9/7dS77jYaKq+IsEs97y8Ikke9RcyFtYfvkgrzsHpW3gny8SHwM4J7i0M7Hc7h5eJ7ny7Lw6SsQD2tGQ1atYKj4qx23vc9vJOL56CgNH1VjaVar+foV33PEFXTB+rY1gpVQ2Ry2IdXVLvG+bqqS549UvLypc1HWCd2W8WxcswPptWf2rlqs4STh5oO8XsYsPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yL/asDHNmpVzOan3dx6XGuq6dIgJP6YAMNLDtHh4+Mg=; b=Ey7/ZFa389045fewt5nEWwmbcoxVKaicf166rJQ3BsQDlfTbxh9HoEIBe56wBPiY1oPBnib2RgLUUqoADaOiVqxBvgeoNGLnWR5JxcvaiCgdFAmTI3YjfHa7UsghOjEZUIvZfALBq7stCcGVyM4Jh1ecKakpjBjqROJ0MFMFQRk= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DBBPR04MB7884.eurprd04.prod.outlook.com (2603:10a6:10:1f2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.41; Thu, 6 May 2021 00:33:37 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:33:37 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V2 12/13] soc: imx: gpcv2: Add support for missing i.MX8MM VPU/DISPMIX power domains Date: Thu, 6 May 2021 09:04:39 +0800 Message-Id: <20210506010440.7016-13-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:33:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c44ea74c-23b4-4bc2-e89a-08d910269684 X-MS-TrafficTypeDiagnostic: DBBPR04MB7884: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 03ywReONRs8f8+vwzutPFRUaTk1W9SsxXF3wyWz/vR6fi89zn7deaNRnKevbWJn60F4jZuXFB1p2eiOsX4572d1vqocxYtIVcBW32PtaAKaRZQfYGXQJbsLdLIejnXVEZam+xMlxrzQ4D22ZrG+LgMlyNheKBE9w9d1hu38Fqojlb73H+DC4DqYQLZdr97s7n6y4A+B6+p3wgnfvwQoHJN6wrKQjJXsDRzFSSbhslz32+ksMBFjVVwh6/ZWi1uAZp9rxrsEn5v3gYQkTBcKU0lVllrdzrDumMIqkoNad9RmgvwTFqgUXQnF6OSMuvPRnxNGswnlBGipqymglOxzWZa+RGzvjHbN2bi0L1cU8crk57s6aC6VqY6Anzpd5/95/g5ZA71BPAtkhKMsr5yoMGU6TXv9q5wqoIE4gYUTYEuvAMcAgvSQ7GB0TUoxB94ztuVT1nsyMjypA23AQzY83js9yei04zl4kG30L9aGckc1PtXUEx+Pl63PJASBk7eXBeqqN09kLhfk0uVnxT95eeCX528dVNg8u47ILOEGETXcBPa9fqzVjgbI5oCLOUztkRiFO54zh98tv5E6UJfNTwnRwqlQrOEjlQB4ZhnCN7SeOfyki4Wlosx2w5+cnaRv+OUJkova3Nyk/yMWZ9EKSeg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(52116002)(186003)(5660300002)(6512007)(478600001)(2906002)(1076003)(26005)(6506007)(16526019)(6486002)(956004)(8936002)(86362001)(8676002)(38350700002)(316002)(38100700002)(66946007)(66476007)(2616005)(66556008)(4326008)(7416002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: HoEXSTjtA2zycLZgVUdMRZHakq2TDrrWPHiq4zRBNwRbCj0Dt+KKV8PBC7w7wZInfICrSa4XJi80wD5+L9tK7f9N5VJlrq6TJ99w10VLJokCd15J46cxv+lSyJKpEzJsDE6cW295dguibGsDnxTz4b0pD2YSIcX5ys37r4glSWZ+K9GHpfemjnfXwzwni0L73IJQn46RxYF1GvplLmiS8SBlezxdF1PNzP1gAe/sHJ+Im2GTLmj2T1X/CFcOdWJ5xys3CusJpNLOf0PY09d3jMmRfQX/9nZsFL/R4at58DpIB6bTM5kIbpwkzYoEdswapjY6IwFCqPRxVMH/azDOyLQzbwVVseJqxDPP9Xd87hs4CRft6fUaAXkIpaqV70hdIjVGAE5JV7eiAykWYSoyQhgB4XYB9UDxpQXSiKuYymYaQxk9ONeZ53sCImfGHJAGTERHRzdbj8uEiMzmiLhcezN7EodlNt6n/qj2A/wrSDEud76sooq1KTVZI/RurGRfTK1lVhDGFdwmtZQsi9sWaa6gud92ro2YWRA4V42Znk45TtjqC+H9nwQEVdUCJhxUmVqbBRsrsp7A/dxGQzS78E8YRFLr16mR8byyuDoSPHe3Px+mcPBKjzAJ8UAYWd5wYcEXVmuI0e3pJVpCfua1rN1uYLwI2wHYPtfUf7Y+iPP/I5JZBbSMEN1eaYEAdPKPTSkxetA6PWySoZJ5B73UpOlBnDrGdwVslBEjzqIXvdq03V2+wgkne5mdzrt6OjSqoaDJtSFA+S6RQNrArQswg+aolA3cnnFDKP1MjHY/WYipeAN0GEpG6W965N5HklFDDP8wf9/060b7RP5VHYVQCARvZa3BC8KXjzzT1/QBFqkuMwq6dWMHHJYs/GokC4vUUVpORcFDXBA1KKMmvObz91ICACXZlzIc6/R63ET1+fjf5ubGe+nq7O+BGkCPW4/sgWwjLxACkDdyg/mFZHBdncyPHjkAIktLFtTUoT2xQI8TY3G/vORIkkw0Gb+1rVFWjBrnOKTin5Y4eTMHjDaENw4jKW53VmF78b5LdYeo13rTzZNSU60emX8rjNciaLxIFZ87X2RZN+AuV8rVgphUJ3ueIcravf1tmnLIA715lp+JgsMbHcF8bgvvfGvf7xUwJouj/zBhsRl50AW/hbzdsg83P3NzWLgpQ4nZWYpYCa7vfCdK+33UvB/UzgblJbFESRiDVoX0LU9YNWhuSQEUBigUywgF183kJtpKhZPsZsiybSch8fjt9N9z0Tck6q8C3RRdwWBOa4LzmOJfQ2P7jIoRPOF+tRrmWcW/boY140GeavXdSYkzF64W641IQoGI X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c44ea74c-23b4-4bc2-e89a-08d910269684 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:33:37.1609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1TeEmWnwlLnv8IQy3Dso0F/QdTML2HlfFKlsAIqNsZ91HbJOnxQ2eTDEYEGOjkCb7XmN5e+btULPW6GTj9BMTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7884 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173340_512874_F5E9C140 X-CRM114-Status: UNSURE ( 9.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lucas Stach With the BLK-CTL driver now in place, let's add the missing domains. Signed-off-by: Lucas Stach Signed-off-by: Frieder Schrempf Signed-off-by: Peng Fan --- drivers/soc/imx/gpcv2.c | 70 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index b9437d6d82a6..65b562cbcc6d 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -650,6 +650,76 @@ static const struct imx_pgc_domain imx8mm_pgc_domains[] = { }, .pgc = IMX8MM_PGC_GPU2D, }, + + [IMX8MM_POWER_DOMAIN_VPUMIX] = { + .genpd = { + .name = "vpumix", + }, + .bits = { + .pxx = IMX8MM_VPUMIX_SW_Pxx_REQ, + .map = IMX8MM_VPUMIX_A53_DOMAIN, + .hskreq = IMX8MM_VPUMIX_HSK_PWRDNREQN, + .hskack = IMX8MM_VPUMIX_HSK_PWRDNACKN, + }, + .pgc = IMX8MM_PGC_VPUMIX, + }, + + [IMX8MM_POWER_DOMAIN_VPUG1] = { + .genpd = { + .name = "vpu-g1", + }, + .bits = { + .pxx = IMX8MM_VPUG1_SW_Pxx_REQ, + .map = IMX8MM_VPUG1_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_VPUG1, + }, + + [IMX8MM_POWER_DOMAIN_VPUG2] = { + .genpd = { + .name = "vpu-g2", + }, + .bits = { + .pxx = IMX8MM_VPUG2_SW_Pxx_REQ, + .map = IMX8MM_VPUG2_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_VPUG2, + }, + + [IMX8MM_POWER_DOMAIN_VPUH1] = { + .genpd = { + .name = "vpu-h1", + }, + .bits = { + .pxx = IMX8MM_VPUH1_SW_Pxx_REQ, + .map = IMX8MM_VPUH1_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_VPUH1, + }, + + [IMX8MM_POWER_DOMAIN_DISPMIX] = { + .genpd = { + .name = "dispmix", + }, + .bits = { + .pxx = IMX8MM_DISPMIX_SW_Pxx_REQ, + .map = IMX8MM_DISPMIX_A53_DOMAIN, + .hskreq = IMX8MM_DISPMIX_HSK_PWRDNREQN, + .hskack = IMX8MM_DISPMIX_HSK_PWRDNACKN, + }, + .pgc = IMX8MM_PGC_DISPMIX, + }, + + [IMX8MM_POWER_DOMAIN_MIPI] = { + .genpd = { + .name = "mipi", + }, + .bits = { + .pxx = IMX8MM_MIPI_SW_Pxx_REQ, + .map = IMX8MM_MIPI_A53_DOMAIN, + }, + .pgc = IMX8MM_PGC_MIPI, + }, }; static const struct regmap_range imx8mm_yes_ranges[] = { From patchwork Thu May 6 01:04:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 12241399 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEFACC433B4 for ; Thu, 6 May 2021 00:38:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F4DD61185 for ; Thu, 6 May 2021 00:38:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F4DD61185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QUJoKxDG64o9Wf/qhaUGAg4hKgjVpD4QrX0GflDQr1o=; b=apLd6DFPOe4wQ96yvOJNpv75m 62dsra5WRzvC6jrmp+HT9y+lNe/FJNxh+QtOh8FXj9W3mhOYdi9DIDdsAH4VB3i/f3yeMGcly50YD BDOgNGJjT6mglG48o+XAoOIIxwRQjLPshY+ayM+Rcy8kdaXiat0nPJ5QDvvtHyESo0rQJY5Fc243Y Zd8KAIUZErdw9JXFBDhzHfL685jNMVlL3Hu5LiQz22QZ+at5MWbRrWnXzzIhmNQJ2Ay/JvZd/eY1l xJM1THwELIbLeVAH34pXhGG1kOSKWDFwwxMxNzdy6OXN+iogInaHortEW4lTsjDeClJYUSp2K2JEs QyQX6CyVA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leS0K-002ilZ-9E; Thu, 06 May 2021 00:36:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRxd-002hiM-4v for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 00:33:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=c6QVYSOpg6OI1/lGSqpz04ydUyaxyFOFKNDWb1So/pQ=; b=fRqfHH0V/ZDSLgKwwSuTQAsKt7 4OCrLrWWBfL3rn615SC+2mXtmH433LJRztv1n4qugKrO76hd1m32trWXs588sFMwfuu34O8WCDu2O RREVdLSdGsVs6KiJnJ4I0fQmbqbcS0xN2OiXbJ6AHn8WcchTqeSfwXPebzo7CQad1kcGVgri+pTmR 37p+uadJmM3orXCup8Kb297PD7MSA0OBB+VirUZx9Tx+CGbca4c61zW+FHKU2uWoNsbmGR5CtnI5q deo+vo/19/+ZaBzaN3jRYnaOCpa0KytdA8sewJ3AUJZshqKq/tiIPW0aqA1cd47NU07txH1KSSeVh eumUCpkQ==; Received: from mail-eopbgr70057.outbound.protection.outlook.com ([40.107.7.57] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRxa-005RKA-MM for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 00:33:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RTy8d+ri+g8KtOR9TSGcWsBavpP98lCZlBpicVipRMaxs0vVHd7f+LXMBEKOyRddf3D8AZ5/CSBbvUWK1f0vM9CsikaOIGFe+GdqP90tFeL6QH7BXgnfyS1FOQ0rWV0GbWrbCDs5OmpFvts68OI45FuUduImSWmF/4vkBnRfSBnZTU5VIELXa+Z+qnXTtOrc31BYcNs/SnCriU8TjewZsgo0nu5A2oGKX2EG/8ux4xrbsmVVwlO/Lijj+4Rd2LWuBTEoJ/hAwheryWyZy4QCqJrCmO4CcClTHnXTkMMOYUx2aD2R8h7OzF/Gu0G83jsjH4FHyucrq1KYcbSRBb//SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c6QVYSOpg6OI1/lGSqpz04ydUyaxyFOFKNDWb1So/pQ=; b=APoWUDAm//vX0OHrMZO+j57TR97g0aIu9XU+wSUJQ6TVQjuDYkcFL9ZDCPKKkUXUDtBkOVnsHrOj9KyTT6D1RNn2FZ+fQqId+VYE+cwTYSToih4efLcAzc4o1zuKZMBCX27hscGL/Rye8CM8zexd3/g7n4WADkvh5LPTxtzz54v8qOFJu2cNty8W791p+BcpgCb0QPiCID0unkUMSdoZC6juq65+bn9PmXA/GzaIsDSKg+JdvG811M+hI1FXw19pSEdS6IsKuWTLp80uBwBBZhFmmXJr7ZBT9evwBRAxwTaMD1nqbRCefnSd9PhL5RxjHO/mp7OfCdzVJcDg8xbcQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c6QVYSOpg6OI1/lGSqpz04ydUyaxyFOFKNDWb1So/pQ=; b=H6TVB0V06c+VYLqainKwsCWYsBG8/RHC3H0r3gUPPYs1V26w5LIP0Zp3+j2I0vGDS7dU3Fu1d2Ux8awcHLLL3IMaVGb8wM8w2yGAMTG/SEbgKo1G7dZaaRljiLNmX95HJgV5y3xNwLekUiav7nGzgOURePpyAhOgFyjenUvDyPw= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DBBPR04MB7884.eurprd04.prod.outlook.com (2603:10a6:10:1f2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.41; Thu, 6 May 2021 00:33:43 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::45b9:c993:87ec:9a64%8]) with mapi id 15.20.4065.039; Thu, 6 May 2021 00:33:43 +0000 From: "Peng Fan (OSS)" To: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Subject: [PATCH V2 13/13] soc: imx: gpcv2: move reset assert after requesting domain power up Date: Thu, 6 May 2021 09:04:40 +0800 Message-Id: <20210506010440.7016-14-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210506010440.7016-1-peng.fan@oss.nxp.com> References: <20210506010440.7016-1-peng.fan@oss.nxp.com> X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SGAP274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Thu, 6 May 2021 00:33:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7b7ea42-8fcf-4f5a-c3e7-08d910269a1a X-MS-TrafficTypeDiagnostic: DBBPR04MB7884: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ll1AA/PQqs0bIx/rHNwxAP1TkIW1uQgzdK7zy69RawoQaxgD+2uB60vce3ol8OeB2+fpZ1ZhWGEwPT/SAAu7A7nsVZ2UCLCotUtX4EtPCT6LOXJLFned0ptBL4EBBqSw4pj0/QBsCdfhhCykEVDDsQ9ABONcV6286PyxIO8p5MaFboY4CKbmft4fZx6AD1p3ztGNO1+cS8ZoNlMJZGqg75VQHLXPfBIkHblBoHZJ6wrAAjIhgRwjCyrbIv8t/KQuJhMBHMsEVP3LOh1U81Fg20MaYZdSemVkEvRn2J/6Ee4+0CLV/1NXChBJas1RR5tkveHNLbCUPDcriLmrxPJ237GsN84tVTzzQlVk3O3szmCHNOjx0Rqrn2/XMF9SK6rTUTVSZa9byJUhUQSNVXGuewPtaDVE7CqyOLrf/ci+OWUuIoP2HYsiseko998UwD8lYcpdKt5DPz9Yyd3AXFbnvADfomNuNQXqONeyEfy258zcyjrhK0Pul59578nYQIs6zNdh0lS0zI44iKJqCkr5mNt6/siD9LrxmYxtJ+AyhSUWgSjh1O6/pcje/9sb5dLBJgZJPBFjeCUBDF4EfUnGmiqDYxebHRhV6J8hYRecpHEfwqA3rHvXegoE/lojR+1Ipfv4jmGdj3H3iF9WlVT8gA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(52116002)(186003)(6666004)(5660300002)(6512007)(478600001)(2906002)(1076003)(26005)(6506007)(16526019)(6486002)(83380400001)(956004)(8936002)(86362001)(8676002)(38350700002)(316002)(38100700002)(66946007)(66476007)(2616005)(66556008)(4326008)(7416002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 3ueNzCKQDATkcM5cgDMx56GgmzrJufEddYLBRBbn3h83zG8jj9yHFpz2p01/LmT9xKRaTjUhw7Ef4w9GsBPr9/ZwWyv5r33wLChZHpZGAEekNZS09DAoqcVezq1B6mpJTv+RcNXOZ6itSlPRh3rCPFvoFzxGjD1Kn8Zhq1w6FjyvAoqFTYDpqZReBLt8E7OcwalVkkLZGsYjU4Q4l5F9+OYkLwSPj4gaf2b7d+/RT3Ij8WiFoz1GkMfJVD4XB3vA+bucjZvC1zScdSFQU9nAMp3u4t3Vw8KRlYDMDgxQTuOPRWVUQL2az0Ji50UNK9PnQpGKcbijd9Gr91zON6PgflREhjcaCvIpQQX6z0HpT5lziT1vCubGfLfbFBaH8PhBEg/8p4bl/lvTTcUdwNK5n4AVS8e9wGH1vO68mnpQofNSOU3A5wV/Kxqx+mXMo9jv8oYy1Z50k/roHkEblucRxRQJwrsKHOGkmNmm62bhcKwKY2tb4D+NQDk4wEMP/ZCZkJlT529rj/6e6+vFelHsYVX/a1ZSAp5LevZWXAS/V6lkxuiRgPZ5FPQNAkGTH3zIRULIT8GABzArb5k0H+BBOokWefuqmZX5wmVPqEaRqs4/6AHcTvt3wF0yEOwjbQqG2+urCdBP6Qrz9+fKZnF8OR/L0HfI0QIkaSqZE2seYZR/zqW+e9YLnlYGF+H2vuVifs4Xjznh8DFS8jOhDiicFsys9msxwhtquY9ELhEYvXA0XnOj3zTJR515snXclMU3ZIDwUspmbKEsfJJH4Q0fvFsgP+472Oz/rVycTKpXRUutvn5ZLcL3wCS0aUcFBULQew20dFY2x4z3f+7zlE2QRdd5RLgPXI/bGBDCol43n5C5kV52KXAF0mmePgsJHJ/MO6cioPi8wwnHC6hK6YXhpz+PbcH/dRNAZFtJiIZTKZnV4YXGtkb0n+S9u6KXVm9wNu34D6ag2GbsBcGWzwUXFpGJwnkn6bJIDlE6bhXS7IXrRrgiozA97dy3RuFz2J/mdNNqczg9ECOCMqTS0V83WzlXlGeKIltap9slArF2Q46OjFcB7h0uBTOD/vVyYJRvoXPo8Ns7Y6j4MepxcoU5nLYH785ZWr0/QzlmW7JszQPL2N1CuuBeQaBstsvmmAomkoWjAQFVjGgohwsZ8+tOetbpzpGyXAVz8GZ0KeAM8p7R6DJAQGTpM/ZG+Bfjz8z9IwD03GMqor5K/FczfC0hiIQDHcA/Wyzo7qFKl4vyEP5HtcqMDtBBW6ijUVTe+XgFaPp1gxagna23yjFZrwRDtxiAxa1o3hxbKZJoyOZnnJ9vOUnEprcUCavOgTfsAlvT X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7b7ea42-8fcf-4f5a-c3e7-08d910269a1a X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2021 00:33:43.2911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q5iysvq/Y3rx7FyuaFopXWoZGZMV3O7psWAeBC8GjFaleWApUH5h4/oyrZ/7VC7tMXM6U98gAiTomQ1ANxDt9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7884 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_173346_755703_0C21B8C6 X-CRM114-Status: GOOD ( 11.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan The i.MX8MM VPU power up sequence is a bit special, it must follow: 1. request power up 2. reset assert 3. reset deassert This change in this patch will not affect other domains, because the power domain default is in asserted state, unless bootloader deassert the reset. It also applies to GPU power domain. Signed-off-by: Peng Fan Reviewed-by: Frieder Schrempf Tested-by: Frieder Schrempf --- drivers/soc/imx/gpcv2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 65b562cbcc6d..325a34833ffa 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -217,8 +217,6 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) goto out_regulator_disable; } - reset_control_assert(domain->reset); - if (domain->bits.pxx) { /* request the domain to power up */ regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, @@ -241,6 +239,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) GPC_PGC_CTRL_PCR); } + reset_control_assert(domain->reset); + /* delay for reset to propagate */ udelay(5);