From patchwork Tue May 11 09:49:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen (ThunderTown)" X-Patchwork-Id: 12250833 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65636C433B4 for ; Tue, 11 May 2021 12:36:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 136BA6191C for ; Tue, 11 May 2021 12:36:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 136BA6191C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=BrVt1zvXtHTdXcYQOtx7GW5qzrqH1IpfqR6Aup8Jku0=; b=Fv6xWGLz38dFelkl8bIE5w/iBF Bn/x8hIfC0QGeuEXUfLDhvxvFD9FVo+EacrTC/Wc+zoFkIecbsrkaDmgSMfVaa/n5UpZoPiz+5HKr xnYaXtTNFYh4ZQ1LaTxe1Wu+k2lPCkFSbYLpYOViuhCP9bEJOC2qVgGKmxijQg1Cp+U9CTnfPs92r qQuMxjeHrTU4N0egj7RmuH7p+49aJW7c44K8pE5cAGr0lNY/6lxU6ooJnSEU/b4iEGE/yLFT9UMFN hqKjj4TXSWE7sKzcdDCRcVJ0L0my981XV9GevD7xhiqiVc7ZmpVnslTtery+kFGYbH7G68DTB7tmR y3TFyJXQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgRat-00HPdK-Jo; Tue, 11 May 2021 12:34:35 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgP1N-00GlIQ-BJ for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 09:49:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=N9irwbda8DIj0jleaelEFgXJ1C0WA3cF+vmFC7xcJ3A=; b=SfIf56pdOvSJEl9yrzzsLH/rB0 3fZTRIllYR0Xew3QkZp9q5E+3Hdcwj6uY63TRVnvpenaRe9Hi3CO/L9dxNqIT1sX8Hoq3yk6uhP+y ynOHybIDrfoESJxURdMLKO/w5ty0XmhyYz61OoXq9h7gkoJuHMVrhZRuM67b1LTNYSkgsr3PV77r7 TMW+mO1BjJnk61rZ6ZvyF+Y87KDjum41GUnXroXGuIeTyYfnhkccw9g74ryBH+KKPBYe8IX8Hoz6a 0CTDr7tbW8o1oVLgBlPJlnVaHi3rZAsbP1FsVXVJNLYdPgq+tU3nt1qh0QmjbIgeKkLSw+FCjdtDB IQcwdlTg==; Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgP1K-009Rez-LX for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 09:49:44 +0000 Received: from dggeml701-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FfY402HwbzYk9j; Tue, 11 May 2021 17:47:12 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggeml701-chm.china.huawei.com (10.3.17.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 11 May 2021 17:49:24 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 11 May 2021 17:49:24 +0800 From: Zhen Lei To: Claudiu Beznea , Sebastian Reichel , Nicolas Ferre , "Alexandre Belloni" , Ludovic Desroches , linux-pm , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] power: reset: at91-sama5d2_shdwc: Remove redundant error printing in at91_shdwc_probe() Date: Tue, 11 May 2021 17:49:19 +0800 Message-ID: <20210511094919.4885-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_024942_892210_CB6E5CA1 X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/power/reset/at91-sama5d2_shdwc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c index 125e592af445e32..d8ecffe72f165cb 100644 --- a/drivers/power/reset/at91-sama5d2_shdwc.c +++ b/drivers/power/reset/at91-sama5d2_shdwc.c @@ -351,10 +351,8 @@ static int __init at91_shdwc_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); at91_shdwc->shdwc_base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(at91_shdwc->shdwc_base)) { - dev_err(&pdev->dev, "Could not map reset controller address\n"); + if (IS_ERR(at91_shdwc->shdwc_base)) return PTR_ERR(at91_shdwc->shdwc_base); - } match = of_match_node(at91_shdwc_of_match, pdev->dev.of_node); at91_shdwc->rcfg = match->data;