From patchwork Tue May 11 20:08:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tedd Ho-Jeong An X-Patchwork-Id: 12252009 X-Patchwork-Delegate: luiz.dentz@gmail.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 984D5C433B4 for ; Tue, 11 May 2021 20:08:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5966D613AF for ; Tue, 11 May 2021 20:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbhEKUJx (ORCPT ); Tue, 11 May 2021 16:09:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhEKUJw (ORCPT ); Tue, 11 May 2021 16:09:52 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 280DBC061574 for ; Tue, 11 May 2021 13:08:46 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id gj14so12282969pjb.5 for ; Tue, 11 May 2021 13:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=3qZDwzy2nMHUs6TgK3apG4VfEIUTtWnOQyxOVKFgvAo=; b=Z1nWu/sw6Uu4OPDVvbMeRVRXSUsvyDhIx3Wu6qjgTB9rJxzYjG1fTnptUDHdN7ciF4 3FJncFv7CKmUP8YICn50Jd0XG8mgislGTp7T1z5Mgf+0HrO0hbfPQ2kMS+8x/y1+0BEz LlK/suf94sRI1cJYNxfVfHEb8ZRxpGfcR0rs1taj13JW+3VuI3VIjwUkFFWBXu1nI6lY vBba79MuIAQslyNayKCsN2B3r4RheKTmD9/vYI/xaELGGDMc7wpRt8rXj+p5smCAwfsV UlN+6QJ6y06IHEsipRb6QY85C1ljlPfw4p0mmtRejX6jiRz/vrJDePflOKnr2iIi/ThH QycA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=3qZDwzy2nMHUs6TgK3apG4VfEIUTtWnOQyxOVKFgvAo=; b=L7W0UVRDIpoip5HixMa4/8odU2MkG1P5E8jCQXUrRJNPP6eyDoEBjrXBPxtvPsnqc1 o++Ge9o8RkCXkP0FgAS84A0oOD4y8zUlaOIBaGhsdr/xlcL1h+VvgavNPMz6N715hIRv F5luBHGlqipB2sb0VRNTYN0eUb5RZuK/8HRZ0cyOGxbJODoMl6FJYHkAQjn0YLFkQ02r wUTsPLhofDglwAxgKq4BBlkvsRFHtosRWb5h0tTIh8n3MYphScyQOIYgkgXkZPhmBXBq fyHreRQkpjdoWzFsXF5XOvkyfVqxzNvvMl5OJpHIol3XfWnHuRt1fHdU48aptLt+c3qA 43sw== X-Gm-Message-State: AOAM532e/2LXN36W8OysZxANEQBzVUAPNNSrUfaPRJWbuoQKckGnx0os WRNuscHLyOkVe6QlcNEurqoUdKYu0twAZQ== X-Google-Smtp-Source: ABdhPJxgS4907vMnqBtlScEA4x0c8/GGQyjAV/kYmWn9Ns0a7dgznTXOGx2muPv1JgwZnzQtxXUc/A== X-Received: by 2002:a17:90a:d493:: with SMTP id s19mr7050714pju.200.1620763725320; Tue, 11 May 2021 13:08:45 -0700 (PDT) Received: from han1-mobl3.hsd1.or.comcast.net ([2601:1c0:6a01:d830::512a]) by smtp.gmail.com with ESMTPSA id u15sm2835224pju.44.2021.05.11.13.08.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 13:08:44 -0700 (PDT) From: Tedd Ho-Jeong An To: linux-bluetooth@vger.kernel.org Subject: [BlueZ PATCH v2 1/2] config: Show error if rst2man not found when manpages are enabled Date: Tue, 11 May 2021 13:08:42 -0700 Message-Id: <20210511200843.1741595-1-hj.tedd.an@gmail.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Tedd Ho-Jeong An This patch adds a check if the conversion tool is installed when the manpages is enabled, and show error if it is not installed. --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index f445589b0..2b044f8e5 100644 --- a/configure.ac +++ b/configure.ac @@ -328,6 +328,9 @@ AC_ARG_ENABLE(manpages, AC_HELP_STRING([--enable-manpages], [enable_manpages=${enableval}]) if (test "${enable_manpages}" != "no"); then AC_CHECK_PROGS(RST2MAN, [rst2man rst2man.py], "no") + if (test "${RST2MAN}" = "no" ); then + AC_MSG_ERROR([rst2man is required]) + fi fi AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" = "yes") AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" = "yes" && test "${RST2MAN}" != "no") From patchwork Tue May 11 20:08:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tedd Ho-Jeong An X-Patchwork-Id: 12252011 X-Patchwork-Delegate: luiz.dentz@gmail.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D48CBC43460 for ; Tue, 11 May 2021 20:08:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95345613AF for ; Tue, 11 May 2021 20:08:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbhEKUJy (ORCPT ); Tue, 11 May 2021 16:09:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhEKUJy (ORCPT ); Tue, 11 May 2021 16:09:54 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DB7EC06174A for ; Tue, 11 May 2021 13:08:46 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id i14so16562892pgk.5 for ; Tue, 11 May 2021 13:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=kqbM3kWuOznR/ZIgxhkTbOwibb3NYp28QJ/EMs1kcFc=; b=m8hr+/CnmSHY/Y7veQFi7ung9gjDGbpSyQopyuPr7/tqRVlg947hIwThBbnX4xI/1D eIV6BYdJSHIB/EhvnXf1BWAqViCGnSLy3O6slSoj0ZRSfVTPaoKgDBHPUljfszZE3TVn Ozo11w5+F5kqrHOf09oFdCWvP3Spj0DxCLTnxbrvfNo73q+/Ck6dsNISN1pjlY8ldNpU tAO9NNA8+pGDQuAU/EKXWJ+TldmcnzBNtlIMuZgrR2TX5ZyfxYemZ7JeC34XrFEXd/e6 2LV54FprSkr6wiPRlZC8L2vzEBCg4ZoatdcXaV38dcGqxsh6voXPgsUQc7W81q2TjHRO qYgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kqbM3kWuOznR/ZIgxhkTbOwibb3NYp28QJ/EMs1kcFc=; b=UsA1gPDvGEDLCOQMowNVndkAH3j5NBEXuvBiYKKxbX7JBzj/NiQH6PUhGHSIINo2cJ oi9FRcygGy9bAenzsxXxojxJF5Eg1jO0yoOOSf4WZUlRT+SgF2UXLJtLukoipv6Svgyr wV0iW6nO0E6/Cj6KGdhH+4M26Yg6G0EB4/uKiS0+zSG19q8gC6PKRyTBegdlaDttlL4c RoPPOpftMMuD//O3T3kmyb1USL/olhZvKaI8Q1J+NqRioCBNbcIXmkrVntwRt1UHNooy GtnUQymy09WaytUebW9A5zVJVEbz2Du2C137P7H4tFrwzIslj04qDaEHK4iKtG1B8rl3 PEZw== X-Gm-Message-State: AOAM531Vx8AOLf8pyFlBefr6Fq6GNFll6vZzw5+h0koiCBgqSsve/OE4 IaYlzjLsRaujKqJhS752ysDdcghkN/BdNg== X-Google-Smtp-Source: ABdhPJzVzxcI2LPDwnSiHFaVtK+CnIiMsZBZ/vW5dblhaEqkFlCq81UcbeHfVdN5MRrChQ/TZwK92w== X-Received: by 2002:a63:eb10:: with SMTP id t16mr33430860pgh.393.1620763726065; Tue, 11 May 2021 13:08:46 -0700 (PDT) Received: from han1-mobl3.hsd1.or.comcast.net ([2601:1c0:6a01:d830::512a]) by smtp.gmail.com with ESMTPSA id u15sm2835224pju.44.2021.05.11.13.08.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 13:08:45 -0700 (PDT) From: Tedd Ho-Jeong An To: linux-bluetooth@vger.kernel.org Subject: [BlueZ PATCH v2 2/2] config: Change the config option for manpages Date: Tue, 11 May 2021 13:08:43 -0700 Message-Id: <20210511200843.1741595-2-hj.tedd.an@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210511200843.1741595-1-hj.tedd.an@gmail.com> References: <20210511200843.1741595-1-hj.tedd.an@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Tedd Ho-Jeong An The current config option for manpages provided by the configure.ac alwasys enables the manpages whether 'enable-manpages' option is specified or not. To clarify the expected behavior, this patch changes the manpages option to 'disable-manpages' so the manpages are alwasy enabled unless the '--disable-manpages' option is specified. --- configure.ac | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 2b044f8e5..5157da1b5 100644 --- a/configure.ac +++ b/configure.ac @@ -323,8 +323,8 @@ AC_ARG_ENABLE(datafiles, AC_HELP_STRING([--disable-datafiles], [enable_datafiles=${enableval}]) AM_CONDITIONAL(DATAFILES, test "${enable_datafiles}" != "no") -AC_ARG_ENABLE(manpages, AC_HELP_STRING([--enable-manpages], - [enable building of manual pages]), +AC_ARG_ENABLE(manpages, AC_HELP_STRING([--disable-manpages], + [disable building of manual pages]), [enable_manpages=${enableval}]) if (test "${enable_manpages}" != "no"); then AC_CHECK_PROGS(RST2MAN, [rst2man rst2man.py], "no") @@ -332,8 +332,8 @@ if (test "${enable_manpages}" != "no"); then AC_MSG_ERROR([rst2man is required]) fi fi -AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" = "yes") -AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" = "yes" && test "${RST2MAN}" != "no") +AM_CONDITIONAL(MANPAGES, test "${enable_manpages}" != "no") +AM_CONDITIONAL(RUN_RST2MAN, test "${enable_manpages}" != "no" && test "${RST2MAN}" != "no") AC_ARG_ENABLE(testing, AC_HELP_STRING([--enable-testing], [enable testing tools]),