From patchwork Sat May 15 18:08:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12259941 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB75C433ED for ; Sat, 15 May 2021 18:08:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17AA16138C for ; Sat, 15 May 2021 18:08:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17AA16138C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4281F6B00A6; Sat, 15 May 2021 14:08:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B1126B00A7; Sat, 15 May 2021 14:08:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2040B6B00A8; Sat, 15 May 2021 14:08:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id D6BBE6B00A6 for ; Sat, 15 May 2021 14:08:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 72FF68249980 for ; Sat, 15 May 2021 18:08:26 +0000 (UTC) X-FDA: 78144250212.10.62EF50A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 3052440002D6 for ; Sat, 15 May 2021 18:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621102105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aKsk6i3/AcPOA1FDdiM7ybPhYixn/WIVj8Y6N8Em2O4=; b=f3LK++fbsS/QM94R5+/rNozMD9owV+1tQX7y0XlEhKwq/PCNA20ZPv/R0nnDg3ZI+Cr/Ra IpNEVUHpjClFwm9pUO2Zpp1PisM6+9sQi5p065azE296ZJGybJmfnCp0n4r0mmVrJJfv/N q77dp3Zv47PUdjoZLNdPH1bs3deUT0I= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-Y3E7cL4XPOWQbXwnK6hKVA-1; Sat, 15 May 2021 14:08:23 -0400 X-MC-Unique: Y3E7cL4XPOWQbXwnK6hKVA-1 Received: by mail-qk1-f200.google.com with SMTP id d18-20020a05620a2052b02902eabc6fa35eso1688460qka.17 for ; Sat, 15 May 2021 11:08:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aKsk6i3/AcPOA1FDdiM7ybPhYixn/WIVj8Y6N8Em2O4=; b=MDmhdEX/zi6v+zT7GDCKgLjNfoqvEhY3yDbLbucDX1/2oJzQO7ia/1hMFO+cZA7MeB ewlnl52JRlFtaaSpwXDy7/xolEO03XWmu77Vvz00x1WocmqGXtqn4LxaFQEZReLVtngr 6ZRCy93swl2r2GwyF8TMy9DSJVyFZ1TVC9ZDnTDjlZdutgbyl8up/CBLwfhiDihHuXCj pS7BxPCuCg7+jbbe/mW8eoWk5A35RLizUW7bOOhDV3QLRJi268vHQsPjTQe5bjeLPi17 H/lt5Pp/nheTJNJSTrreik+z8cJ/akzjyS5wew0crGxWh8XtTl3dpaxtCZ3zLLJQ4E/S grWQ== X-Gm-Message-State: AOAM531PCy+9bggIArEZGS+TMR3gv5ooVqcZUEmhytL1TZMxpTnZd1R5 5TuJIbdqqIQu8rUooBR9JpRR5Y3NLkHDMlHuzILBC9DwWYYjE5fp1u+hiKp0vsxsLHbcMy6lxt2 +wGpRshJ3vNs= X-Received: by 2002:a05:620a:70c:: with SMTP id 12mr48841211qkc.377.1621102103299; Sat, 15 May 2021 11:08:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4CXbqhsIWD582+pI4RG7TvZ8VWHBXUesXUmDk/mAu6AENSbH1WXcDTDji9uFTVYi6/lASfA== X-Received: by 2002:a05:620a:70c:: with SMTP id 12mr48841197qkc.377.1621102103150; Sat, 15 May 2021 11:08:23 -0700 (PDT) Received: from localhost.localdomain.com (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id y13sm7027430qkj.84.2021.05.15.11.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 11:08:22 -0700 (PDT) From: trix@redhat.com To: dennis@kernel.org, tj@kernel.org, cl@linux.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] percpu: initialize best_upa variable Date: Sat, 15 May 2021 11:08:17 -0700 Message-Id: <20210515180817.1751084-1-trix@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f3LK++fb; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf10.hostedemail.com: domain of trix@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=trix@redhat.com X-Stat-Signature: 7xz86dtwcpf878ey9rbe4goiecu1h4qd X-Rspamd-Queue-Id: 3052440002D6 X-Rspamd-Server: rspam02 X-HE-Tag: 1621102104-850030 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Tom Rix Static analysis reports this problem percpu.c:2945:6: warning: Assigned value is garbage or undefined upa = best_upa; ^ ~~~~~~~~ best_upa may not be set, so initialize it. Signed-off-by: Tom Rix --- mm/percpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/percpu.c b/mm/percpu.c index a257c3efdf18b..6578b706fae81 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -2916,6 +2916,7 @@ static struct pcpu_alloc_info * __init __flatten pcpu_build_alloc_info( * Related to atom_size, which could be much larger than the unit_size. */ last_allocs = INT_MAX; + best_upa = max_upa; for (upa = max_upa; upa; upa--) { int allocs = 0, wasted = 0;