From patchwork Wed Nov 28 09:29:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 10702123 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4ACB513AD for ; Wed, 28 Nov 2018 09:30:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B2772CE6B for ; Wed, 28 Nov 2018 09:30:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F7BF2CE6E; Wed, 28 Nov 2018 09:30:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CEAB22CE6C for ; Wed, 28 Nov 2018 09:30:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727778AbeK1Ua6 (ORCPT ); Wed, 28 Nov 2018 15:30:58 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:45411 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727678AbeK1Ua5 (ORCPT ); Wed, 28 Nov 2018 15:30:57 -0500 Received: by mail-pg1-f194.google.com with SMTP id y4so9232258pgc.12 for ; Wed, 28 Nov 2018 01:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bZfZFWO8LVzOeMYPieoDTbNggt+PEiM2bxAXF77bHsI=; b=WMDgsZWolkQsoERl+MdBz0avaFGJ5YhHTtfSzrjl9JJkHYMEzR4TRtej616H/kvPoL W9j4i0NtBjQgAKvPVh1/XBEV82kr1ZhlFuA3ZWNPtSNYdNSXG7hNz7kj0pYFbwWDLTAz XfBxYFNvhGCzzCvS+Og9FulVJMqigqgjPIBVI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bZfZFWO8LVzOeMYPieoDTbNggt+PEiM2bxAXF77bHsI=; b=cDPFFA2k0PPpTLnpQjrjsOT6o6Qb4kvITms7k2/usG14TYxCuq4QZ4wrTI37bFWieH OUcZuWZE9K9nYuyORQcqMDTVOmeGlIZsekn3Un1xTSgeGwUqpfnrfaZFn91Tj4yt9taR qLdwD2F6E9SNrgnUypRdca40Cv59JHcBhB3XHoyZp54aCG/h2DuajWb03tKJW423+JZj c4S7eHJ8zQbmCLVTAcyyrQWliwOVobfY/Q1ViRzNsJaO5wLO9iXbXMW1PbBOXjrSXlHc e4aXWuDMYeegBRmNBJcSCZxNqOr0hlECAb6uRx2OxaFeqjM1aRFZO5x02wZjwSpoVkK9 ldtg== X-Gm-Message-State: AA+aEWZV272I2Qi5QR6di4b34hojUuO8M6FPO54hCm08Vvy9/tWDWoOZ a8Vp9eeBshs3Y14zIVaSg7fSEA== X-Google-Smtp-Source: AFSGD/XV4jsXigI2p3fC9If+Tm7pBoVjiB0eBEexvS8sarPOwafw9wxmFI8L8aFLOtyKhImoKDzgtg== X-Received: by 2002:a63:f1f:: with SMTP id e31mr145184pgl.274.1543397398353; Wed, 28 Nov 2018 01:29:58 -0800 (PST) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:b852:bd51:9305:4261]) by smtp.gmail.com with ESMTPSA id e128sm7870444pfe.67.2018.11.28.01.29.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Nov 2018 01:29:57 -0800 (PST) From: "Hsin-Yi, Wang" To: linux-arm-kernel@lists.infradead.org Cc: Chunfeng Yun , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [V2] usb/mtu3: power down device ip at setup Date: Wed, 28 Nov 2018 17:29:53 +0800 Message-Id: <20181128092953.41541-1-hsinyi@chromium.org> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20181128060412.630-1-hsinyi@chromium.org> References: <20181128060412.630-1-hsinyi@chromium.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Originally, when dr_mode is USB_DR_MODE_HOST, it didn't power down device ip, so host ip sleep will fail at ssusb_host_disable. Power down device ip at ssusb_host_setup. Signed-off-by: Hsin-Yi, Wang --- drivers/usb/mtu3/mtu3_plat.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c index 46551f6d16fd..cdef66141e20 100644 --- a/drivers/usb/mtu3/mtu3_plat.c +++ b/drivers/usb/mtu3/mtu3_plat.c @@ -200,6 +200,12 @@ static void ssusb_ip_sw_reset(struct ssusb_mtk *ssusb) mtu3_setbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL0, SSUSB_IP_SW_RST); udelay(1); mtu3_clrbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL0, SSUSB_IP_SW_RST); + + /* + * device ip is default power-on in fact + * power down device ip, otherwise ip-sleep will fail + */ + mtu3_setbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL2, SSUSB_IP_DEV_PDN); } /* ignore the error if the clock does not exist */