From patchwork Thu May 27 15:40:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Srinivas, Vidya" X-Patchwork-Id: 12284639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E28C4707F for ; Thu, 27 May 2021 15:49:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44452610FC for ; Thu, 27 May 2021 15:49:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44452610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DDB2E6E07B; Thu, 27 May 2021 15:49:38 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 648186E07B; Thu, 27 May 2021 15:49:38 +0000 (UTC) IronPort-SDR: 6tYuUy1VIX1qefZkzBcAAtygUhqxOM5rYKR9Sgj6YIyxI2YpOSt+WwysBXUsxTeQBhBiY7O0ey RNdSzee9eH1A== X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="182423181" X-IronPort-AV: E=Sophos;i="5.83,334,1616482800"; d="scan'208";a="182423181" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 08:49:31 -0700 IronPort-SDR: oo3iAMUd2p+GszcGbnxXZ7AfQvvQR5B+LG0uMv0mjffK4EHOXbmITP3NINnWNmsCSYs9lvsaX9 jRX8yD8123OA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,334,1616482800"; d="scan'208";a="436594311" Received: from vsrini4-xps-8920.iind.intel.com (HELO localhost.localdomain) ([10.223.163.28]) by orsmga007.jf.intel.com with ESMTP; 27 May 2021 08:49:28 -0700 From: Vidya Srinivas To: intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org Date: Thu, 27 May 2021 21:10:36 +0530 Message-Id: <1622130036-7270-1-git-send-email-vidya.srinivas@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: markyacoub@chromium.org, charlton.lin@intel.com MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Without wait for vblank, CRC mismatch is seen between big and small CRC on few Gen11 systems. Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f Signed-off-by: Vidya Srinivas --- tests/kms_big_fb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index b2027b6b9d1b..7d78ff829d41 100644 --- a/tests/kms_big_fb.c +++ b/tests/kms_big_fb.c @@ -254,6 +254,7 @@ static void unset_lut(data_t *data) static bool test_plane(data_t *data) { igt_plane_t *plane = data->plane; + igt_display_t *display = &data->display; struct igt_fb *small_fb = &data->small_fb; struct igt_fb *big_fb = &data->big_fb; int w = data->big_fb_width - small_fb->width; @@ -337,16 +338,17 @@ static bool test_plane(data_t *data) igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); - + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset); igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc); igt_plane_set_fb(plane, big_fb); igt_fb_set_position(big_fb, plane, x, y); igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height); + igt_plane_set_size(plane, data->width, data->height); igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); - + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset); igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc); igt_plane_set_fb(plane, NULL);