From patchwork Fri May 28 15:11:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12287225 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB9B5C47087 for ; Fri, 28 May 2021 15:11:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA349610A5 for ; Fri, 28 May 2021 15:11:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236122AbhE1PMe (ORCPT ); Fri, 28 May 2021 11:12:34 -0400 Received: from mga07.intel.com ([134.134.136.100]:63747 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231845AbhE1PMe (ORCPT ); Fri, 28 May 2021 11:12:34 -0400 IronPort-SDR: FYjCoiiZswcV8d66JjmYq0dk3hPVjfb+ZeYgqmUkEUT/h4//Y6uaaDMJ6e0xK+wboSf1bsNDte WCs84WNr3QDQ== X-IronPort-AV: E=McAfee;i="6200,9189,9998"; a="266856777" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="266856777" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 08:10:57 -0700 IronPort-SDR: VHLb01vnaADt6BTuH/Zt1mA5K8mBSrxkhU0bABsh5CNh5WothktFYarZBpEaJdpFxCSS9QUgni zpMjNofwM0Ww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="548614851" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 28 May 2021 08:10:55 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2C0613B6; Fri, 28 May 2021 18:11:18 +0300 (EEST) From: Andy Shevchenko To: Oleksij Rempel , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Eugen Hristev , Dmitry Torokhov , Andy Shevchenko Subject: [PATCH v2 1/2] Input: resistive-adc-touch - describe parameters in kernel doc Date: Fri, 28 May 2021 18:11:12 +0300 Message-Id: <20210528151113.85943-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Validation script is not happy: resistive-adc-touch.c:53: warning: Function parameter or member 'x_plate_ohms' not described in 'grts_state' resistive-adc-touch.c:53: warning: Function parameter or member 'ch' not described in 'grts_state' Describe parameters in kernel doc to make it happy. Fixes: fb082cd59afa ("Input: resistive-adc-touch - add support for z1 and z2 channels") Signed-off-by: Andy Shevchenko --- drivers/input/touchscreen/resistive-adc-touch.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/resistive-adc-touch.c b/drivers/input/touchscreen/resistive-adc-touch.c index 0939c0e97efb..0353400c559a 100644 --- a/drivers/input/touchscreen/resistive-adc-touch.c +++ b/drivers/input/touchscreen/resistive-adc-touch.c @@ -35,16 +35,18 @@ enum grts_ch_type { /** * struct grts_state - generic resistive touch screen information struct + * @x_plate_ohms: resistance of the X plate * @pressure_min: number representing the minimum for the pressure * @pressure: are we getting pressure info or not * @iio_chans: list of channels acquired * @iio_cb: iio_callback buffer for the data * @input: the input device structure that we register * @prop: touchscreen properties struct + * @ch: channels that are defined for the touchscreen */ struct grts_state { - u32 pressure_min; u32 x_plate_ohms; + u32 pressure_min; bool pressure; struct iio_channel *iio_chans; struct iio_cb_buffer *iio_cb; From patchwork Fri May 28 15:11:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12287223 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 924A5C4708C for ; Fri, 28 May 2021 15:11:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 741B8611C2 for ; Fri, 28 May 2021 15:11:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234676AbhE1PMe (ORCPT ); Fri, 28 May 2021 11:12:34 -0400 Received: from mga07.intel.com ([134.134.136.100]:63747 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbhE1PMe (ORCPT ); Fri, 28 May 2021 11:12:34 -0400 IronPort-SDR: n0mj7xxzTmAVs/Z210EZDPLJ6GkF4zo9ySUHpi/adTw9B8zKfkG1Nsi9NSDxSGuk0orhhcS5hG OG6U7WDNYYSw== X-IronPort-AV: E=McAfee;i="6200,9189,9998"; a="266856779" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="266856779" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 08:10:58 -0700 IronPort-SDR: Nm2G5GFOzHzqxBNit1dQzutVjWxu269j+yJxxvSj/ZxJrty1mLACwS8V8rVOSMWAnySt3aPW1H D8rEbDQ80iQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="615783892" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 28 May 2021 08:10:56 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 417294F8; Fri, 28 May 2021 18:11:19 +0300 (EEST) From: Andy Shevchenko To: Oleksij Rempel , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Eugen Hristev , Dmitry Torokhov , Andy Shevchenko Subject: [PATCH v2 2/2] Input: resistive-adc-touch - replace OF headers with proper ones Date: Fri, 28 May 2021 18:11:13 +0300 Message-Id: <20210528151113.85943-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210528151113.85943-1-andriy.shevchenko@linux.intel.com> References: <20210528151113.85943-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org The driver is actually OF independent and doesn't need anything from OF (*). Replace OF headers with mod_devicetable.h and property.h. *) use of of_match_ptr() is actually wrong here, since it may provoke a compiler to warn about unused variable. Signed-off-by: Andy Shevchenko --- drivers/input/touchscreen/resistive-adc-touch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/resistive-adc-touch.c b/drivers/input/touchscreen/resistive-adc-touch.c index 0353400c559a..ea1884fb49a1 100644 --- a/drivers/input/touchscreen/resistive-adc-touch.c +++ b/drivers/input/touchscreen/resistive-adc-touch.c @@ -13,10 +13,10 @@ #include #include #include +#include #include -#include -#include #include +#include #define DRIVER_NAME "resistive-adc-touch" #define GRTS_DEFAULT_PRESSURE_MIN 50000 @@ -307,7 +307,7 @@ static struct platform_driver grts_driver = { .probe = grts_probe, .driver = { .name = DRIVER_NAME, - .of_match_table = of_match_ptr(grts_of_match), + .of_match_table = grts_of_match, }, };