From patchwork Fri May 28 20:23:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 12287499 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 267EFC47087 for ; Fri, 28 May 2021 20:22:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01E24613B5 for ; Fri, 28 May 2021 20:22:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229593AbhE1UYE (ORCPT ); Fri, 28 May 2021 16:24:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:40638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbhE1UYD (ORCPT ); Fri, 28 May 2021 16:24:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A3C7D6139A; Fri, 28 May 2021 20:22:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622233348; bh=5re2MKgn5nTgc6z6Y4UjVE6+Qn8hJ/F2jLPD8BSqhYY=; h=Date:From:To:Cc:Subject:From; b=fITFSG+lMurpbDMmhbtvoMlncj90plNSX9yBQoU+A0R/5nZGRnU52eIA7mqeJNyFh /8DPlHOD3xtGq/TmYbVA8KedyqfuCUD8y9OQUU+HNS0bMcty3OgmUF1vNqValBxx4l mbEMZQUaZVOiFau6hPVfFNT+lmD3Q0IQGJjV1hp43PCL4ElazyqTHeiY9pi1P7/cfF tMU5nn3rpCo0RoISWet7IazqILa0U557eisibZIY4J660xJYGmVrg7S51o0F96uMii hfAv83BzogFtBkPYoIet4u+9/8NcFYDpxzdAmZcsQgSjiXm3F5Fur1lHnSFof+kWfC iGxJdVkcwf5pw== Date: Fri, 28 May 2021 15:23:27 -0500 From: "Gustavo A. R. Silva" To: Heiner Kallweit , "David S. Miller" , Jakub Kicinski Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH][next] r8169: Fix fall-through warning for Clang Message-ID: <20210528202327.GA39994@embeddedor> MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva Acked-by: Heiner Kallweit --- JFYI: We had thousands of these sorts of warnings and now we are down to just 25 in linux-next. This is one of those last remaining warnings. drivers/net/ethernet/realtek/r8169_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 1663e0486496..64f94a3fe646 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4115,6 +4115,7 @@ static unsigned int rtl_quirk_packet_padto(struct rtl8169_private *tp, case RTL_GIGA_MAC_VER_61: case RTL_GIGA_MAC_VER_63: padto = max_t(unsigned int, padto, ETH_ZLEN); + break; default: break; }