From patchwork Wed Jun 2 02:28:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen (ThunderTown)" X-Patchwork-Id: 12292703 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C71FC47080 for ; Wed, 2 Jun 2021 02:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED827613AD for ; Wed, 2 Jun 2021 02:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbhFBCbT (ORCPT ); Tue, 1 Jun 2021 22:31:19 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2834 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbhFBCbT (ORCPT ); Tue, 1 Jun 2021 22:31:19 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FvtCS5LzfzWptN; Wed, 2 Jun 2021 10:24:52 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 2 Jun 2021 10:29:35 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 2 Jun 2021 10:29:34 +0800 From: Zhen Lei To: Bartlomiej Zolnierkiewicz , Tomi Valkeinen , Greg Kroah-Hartman , dri-devel , linux-fbdev , linux-kernel CC: Zhen Lei Subject: [PATCH 1/1] video: fbdev: sm501fb: use DEVICE_ATTR_RO macro Date: Wed, 2 Jun 2021 10:28:34 +0800 Message-ID: <20210602022834.10693-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Zhen Lei --- drivers/video/fbdev/sm501fb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c index 6a52eba645596a4..d26afcfec4239aa 100644 --- a/drivers/video/fbdev/sm501fb.c +++ b/drivers/video/fbdev/sm501fb.c @@ -1238,8 +1238,8 @@ static int sm501fb_show_regs(struct sm501fb_info *info, char *ptr, * show the crt control and cursor registers */ -static ssize_t sm501fb_debug_show_crt(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t fbregs_crt_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct sm501fb_info *info = dev_get_drvdata(dev); char *ptr = buf; @@ -1250,15 +1250,15 @@ static ssize_t sm501fb_debug_show_crt(struct device *dev, return ptr - buf; } -static DEVICE_ATTR(fbregs_crt, 0444, sm501fb_debug_show_crt, NULL); +static DEVICE_ATTR_RO(fbregs_crt); /* sm501fb_debug_show_pnl * * show the panel control and cursor registers */ -static ssize_t sm501fb_debug_show_pnl(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t fbregs_pnl_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct sm501fb_info *info = dev_get_drvdata(dev); char *ptr = buf; @@ -1269,7 +1269,7 @@ static ssize_t sm501fb_debug_show_pnl(struct device *dev, return ptr - buf; } -static DEVICE_ATTR(fbregs_pnl, 0444, sm501fb_debug_show_pnl, NULL); +static DEVICE_ATTR_RO(fbregs_pnl); static struct attribute *sm501fb_attrs[] = { &dev_attr_crt_src.attr,