From patchwork Thu Jun 3 06:53:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kulkarni, Vandita" X-Patchwork-Id: 12296427 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F6EEC47096 for ; Thu, 3 Jun 2021 07:11:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A5BD60FE9 for ; Thu, 3 Jun 2021 07:11:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A5BD60FE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE9AD6F400; Thu, 3 Jun 2021 07:11:25 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 578156F400 for ; Thu, 3 Jun 2021 07:11:25 +0000 (UTC) IronPort-SDR: Td/qCQP3N2qcvweajWo6h1Cq4Oi/WMutaQHwMUGkP1p4KHRC94U0aS3JOsm1CrZLa3vrL1wZ6X IporqNu7ciVw== X-IronPort-AV: E=McAfee;i="6200,9189,10003"; a="225279086" X-IronPort-AV: E=Sophos;i="5.83,244,1616482800"; d="scan'208";a="225279086" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2021 00:11:24 -0700 IronPort-SDR: rLCzqH1Kyls2cUAG85ZDtWECDOWgK9F+j4y1ZpZyK1mZWjC+boNgyr6dr+6ZymspJfLN3RLM7m SfuWEkO1hc5w== X-IronPort-AV: E=Sophos;i="5.83,244,1616482800"; d="scan'208";a="446190831" Received: from vandita-desktop.iind.intel.com ([10.223.74.52]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 03 Jun 2021 00:11:22 -0700 From: Vandita Kulkarni To: intel-gfx@lists.freedesktop.org Date: Thu, 3 Jun 2021 12:23:56 +0530 Message-Id: <20210603065356.15435-1-vandita.kulkarni@intel.com> X-Mailer: git-send-email 2.21.0.5.gaeb582a MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH] drm/i915/dsc: Remove redundant checks in DSC disable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" There can be a chance that pre os has enabled DSC and driver's compute config would not need dsc to be enabled, in such case if we check on compute config's compression state to disable, we might end up in state mismatch. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_vdsc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c index 19cd9531c115..b05a96011d93 100644 --- a/drivers/gpu/drm/i915/display/intel_vdsc.c +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c @@ -1161,10 +1161,6 @@ void intel_dsc_disable(const struct intel_crtc_state *old_crtc_state) struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc); struct drm_i915_private *dev_priv = to_i915(crtc->base.dev); - if (!(old_crtc_state->dsc.compression_enable && - old_crtc_state->bigjoiner)) - return; - intel_de_write(dev_priv, dss_ctl1_reg(old_crtc_state), 0); intel_de_write(dev_priv, dss_ctl2_reg(old_crtc_state), 0); }