From patchwork Thu Jun 10 03:00:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 12311651 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF5CC48BCD for ; Thu, 10 Jun 2021 03:04:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75BFF61420 for ; Thu, 10 Jun 2021 03:04:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75BFF61420 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=RxMnMQlVT+q2O+G+QRW6IGX1laeVO4dxbNNMIR3YVLU=; b=C202SvnvbSsotB wpvmyg1tb/P8TB8TdgknAK3vAYlUFGbJnltXz5vqeE4RPWSgdQfnvzntUKnnoZK0i9IPW86+IsJ7D VojNGds9oLP0q/OjnHgqvSHweIdjF3AUyhUG9FiJq3AbVntLydSuzaWRoKR8q+G/XiuCGqtITwokP I1FVtzJ1xdAyU+Zy/dwMJ2nsp7Vq8QZHJks+d/WCTa8TxRyJmFV/efYZniE62P1C8ZSrRgbR798EU obpeWdbhEy8i2nyWJpP63nzM1qsBY36pE8vTb9TWVylUJKZ06kN5HwjyMmWl6VhVkU8n+RNvu0zTS KBo0PMXqXrWvsrudU8Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrAxx-00GatH-L4; Thu, 10 Jun 2021 03:02:46 +0000 Received: from mail-pj1-f41.google.com ([209.85.216.41]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrAxr-00Garw-Lp for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 03:02:41 +0000 Received: by mail-pj1-f41.google.com with SMTP id m13-20020a17090b068db02901656cc93a75so2849893pjz.3 for ; Wed, 09 Jun 2021 20:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/8ibD6cQOjhaJXZZr2PzLWT0t0cHU41OsDeIEIeHwvk=; b=K4auMbfs7bES5EGJD02j5sl9z3PZ0Ov5AeACVWNt7t+M9Z+Te+BI/oSrfnGDeA63+v EwVaKsVsKcOl9uOOqUJtquiW9nA0PhECGxIaerfC+uyLFzZjmbvrkWVAJME3jloSJCZt Qal1MqXrV1wRpRKZ65YdYXDiQOSDDJuEYwFJfLAvij4asR/teM/nIUV8vW/yWq8jqI0G SVbrZfDRXYLcDbZxHvRoQUfuIbB+2DYXxmfd0osSFJwp6TTRa8bJyGxsLbm1ZsysrzR4 QvFb7w1wwTi3H6a1oKsmf2p7Cy+ejrfxtUqOMkLFUVesoYvciNezwZfBFrecWwjLGwac IFCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=/8ibD6cQOjhaJXZZr2PzLWT0t0cHU41OsDeIEIeHwvk=; b=MfH7Yod8gZA3vMXOCGjbshmC1s2ikt2CCaqdZlPTAsQEmiQCc8/Q1LI9izYL0jBg4g hio0LVgYr2K66hNj88H/XGLNvyljirzoYeJpY1MzMaa4duHfuM1L87Gsrbne/VuWIZtc fIm2fCpfD9kFvHFpXp54myOWAL+LoT8Y4CRfrZlaRkYwfB1yo+YN8NcAAAcQ25nRlRhI QSqTIe5vU1t3SCs11lLwreKNptyYIRlQeHRQsbbh6vY3iMHhhO3ZoXzKG5UDpjVjimBA 2kmysKs9gXASXr/FG7tTiIYTwynrVQ9rLCC2mX6ZQeyVQ+xETefYvBKE/Wld8f+x26gU j0lw== X-Gm-Message-State: AOAM531azN+GgMs/JlnGHHiqY0rL5QX6KW3gQpH5Soqnom5zps0V8uFc 4cYtcig8RgZOcCq1lF/5g4c= X-Google-Smtp-Source: ABdhPJxPh+WNijaxuHCwr3/HM9pIKneYtLj8bcVNhZhX3Povq5muQ95sHwTqFyC3MwvvYPE80kYVxQ== X-Received: by 2002:a17:90a:ea86:: with SMTP id h6mr979071pjz.71.1623294096376; Wed, 09 Jun 2021 20:01:36 -0700 (PDT) Received: from localhost.localdomain ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id s7sm60358pfh.57.2021.06.09.20.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 20:01:35 -0700 (PDT) From: Joel Stanley To: Fabio Estevam , Peter Chen , Arnd Bergmann , Felipe Balbi Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] usb: gadget: fsl: Re-enable driver for ARM SoCs Date: Thu, 10 Jun 2021 12:30:35 +0930 Message-Id: <20210610030035.76864-1-joel@jms.id.au> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_200239_770753_EAF66878 X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") dropped the ARCH_MXC dependency from USB_FSL_USB2, leaving it depending solely on FSL_SOC. FSL_SOC is powerpc only; it was briefly available on ARM in 2014 with commit cfd074ad8600 ("ARM: imx: temporarily remove CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be enabled on ARM platforms. This appears to be a mistake as arm64's ARCH_LAERSCAPE and arm32 SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs: arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the ARM platforms, and with COMPILE_TEST. Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") Signed-off-by: Joel Stanley --- drivers/usb/gadget/udc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig index 8c614bb86c66..b32cea2fb99f 100644 --- a/drivers/usb/gadget/udc/Kconfig +++ b/drivers/usb/gadget/udc/Kconfig @@ -90,7 +90,7 @@ config USB_BCM63XX_UDC config USB_FSL_USB2 tristate "Freescale Highspeed USB DR Peripheral Controller" - depends on FSL_SOC + depends on FSL_SOC || ARCH_LAYERSACPE || SOC_LS1021A || COMPILE_TEST help Some of Freescale PowerPC and i.MX processors have a High Speed Dual-Role(DR) USB controller, which supports device mode.