From patchwork Tue Jun 15 20:02:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 12322799 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EC82C48BE5 for ; Tue, 15 Jun 2021 20:03:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACBC061246 for ; Tue, 15 Jun 2021 20:03:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACBC061246 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 51D056B006E; Tue, 15 Jun 2021 16:03:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D86A6B0070; Tue, 15 Jun 2021 16:03:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 395006B0071; Tue, 15 Jun 2021 16:03:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 05FBF6B006E for ; Tue, 15 Jun 2021 16:03:34 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8C81F180AD806 for ; Tue, 15 Jun 2021 20:03:34 +0000 (UTC) X-FDA: 78257033148.36.83ED04A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 943A4554 for ; Tue, 15 Jun 2021 20:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=0+mQ8s7h6R8v84qiFQbhUBHtD7Ib1P92OwZ72Iiafv8=; b=HkagqO/wqfq1QsCnM/lIs7LORL BXDFNqAO0cpBB6uS5J8f/vM0ImaK/6k7k/Fk0tdEf8twSXN7KzY0tfy/E823eSwqS13/IFdo7zzSA 83Go3Vo9SqUUdzz1XbG2BEbqBVoXbNonS6VHjK90kqDDdS9cTa+r7DD7DlOxJ1qikORRUAHCspj2V T/I1H0BCwCUP68Mutgi2f85gMyQ+hILV/cHaF1blHMDjtGlBKI2mFILhYPXq3AuP+lWSWYe7Lm3am qlocUPUn6MmNunbIKmHtz+mXmRWlrNr24hPgDcKr+4fSH0aGRjx1DTTbHU59QdBv5RRlWClU6Q4Z6 8gg62MjA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltFH1-007Ca7-54; Tue, 15 Jun 2021 20:03:08 +0000 From: "Matthew Wilcox (Oracle)" To: akpm@linux-foundation.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 1/5] mm writeback,cgroup: Fix documentation Date: Tue, 15 Jun 2021 21:02:38 +0100 Message-Id: <20210615200242.1716568-2-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210615200242.1716568-1-willy@infradead.org> References: <20210615200242.1716568-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 943A4554 X-Stat-Signature: hwyo5awzrfnkpxd863fkd4pha4er6zd3 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="HkagqO/w"; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1623787401-538857 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a static function, so it doesn't need kernel-doc. Also remove the inaccurate comment about the locking. Signed-off-by: Matthew Wilcox (Oracle) --- mm/backing-dev.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index 52eaeee40da3..271f2ca862c8 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -645,15 +645,12 @@ static void cgwb_bdi_unregister(struct backing_dev_info *bdi) mutex_unlock(&bdi->cgwb_release_mutex); } -/** - * cleanup_offline_cgwbs - try to release dying cgwbs +/* + * cleanup_offline_cgwbs_workfn - try to release dying cgwbs * * Try to release dying cgwbs by switching attached inodes to the nearest * living ancestor's writeback. Processed wbs are placed at the end * of the list to guarantee the forward progress. - * - * Should be called with the acquired cgwb_lock lock, which might - * be released and re-acquired in the process. */ static void cleanup_offline_cgwbs_workfn(struct work_struct *work) { From patchwork Tue Jun 15 20:02:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 12322801 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E926C48BE5 for ; Tue, 15 Jun 2021 20:04:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E1F9A61246 for ; Tue, 15 Jun 2021 20:03:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1F9A61246 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6CA676B0070; Tue, 15 Jun 2021 16:03:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67B616B0071; Tue, 15 Jun 2021 16:03:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 542486B0072; Tue, 15 Jun 2021 16:03:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 20F0D6B0070 for ; Tue, 15 Jun 2021 16:03:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A73FE181AC9C6 for ; Tue, 15 Jun 2021 20:03:58 +0000 (UTC) X-FDA: 78257034156.26.5146A63 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 39775FF for ; Tue, 15 Jun 2021 20:03:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=yQob+NSiw0U11+6ZlVT3byTGLO3y80zBeSOou0mxcRM=; b=e57c93unMhEX5Ol350FtGHduRC XS3Y0iITGJwV8/+YbvnsK+O5VDp++0zKOizv2vlSCh1TndPUzyYX9RRkbLUp+KOLN/mNVadwd+mdh 0lqEuPOCBSvqecXElRxg+FIQNp7ni44vW9qIdv9aH9bQW38DJo+5jND8a+ESW7lwk5YCsjVmEqR6A PpEe3HKhNI2wncyE7My+JltFLwGYXH/4TjyeOF+5mxSs0mw6zCn3ZVvbL3YvynVs3cQkFq8yKb7da lnGO6pcXdaUAWBHRj3/5ZLJPk+aiDyOrRnxDQFZ7FbDJO1ua23gV+o4Dk5sF06CHWdppZXHFZmbZ6 X9lVazDw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltFHL-007CbH-J4; Tue, 15 Jun 2021 20:03:24 +0000 From: "Matthew Wilcox (Oracle)" To: akpm@linux-foundation.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 2/5] Fix hugetlb_basepage_index missing prototype warning Date: Tue, 15 Jun 2021 21:02:39 +0100 Message-Id: <20210615200242.1716568-3-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210615200242.1716568-1-willy@infradead.org> References: <20210615200242.1716568-1-willy@infradead.org> MIME-Version: 1.0 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=e57c93un; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 39775FF X-Stat-Signature: 6mjh461phqegudwa7hkcww8mgigwbkm3 X-HE-Tag: 1623787425-181058 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: -Wmissing-prototypes requires that the prototype actually be in scope, not just previously seen. Move it outside page_to_pgoff(). Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Hugh Dickins --- include/linux/pagemap.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 5f0582de24e7..c4b1514818ff 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -585,16 +585,16 @@ static inline pgoff_t page_to_index(struct page *page) return pgoff; } +extern pgoff_t hugetlb_basepage_index(struct page *page); + /* * Get the offset in PAGE_SIZE (even for hugetlb pages). * (TODO: hugetlb pages should have ->index in PAGE_SIZE) */ static inline pgoff_t page_to_pgoff(struct page *page) { - if (unlikely(PageHuge(page))) { - extern pgoff_t hugetlb_basepage_index(struct page *page); + if (unlikely(PageHuge(page))) return hugetlb_basepage_index(page); - } return page_to_index(page); } From patchwork Tue Jun 15 20:02:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 12322803 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5119C48BDF for ; Tue, 15 Jun 2021 20:04:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 52DA6600EF for ; Tue, 15 Jun 2021 20:04:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52DA6600EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E91BD6B006C; Tue, 15 Jun 2021 16:04:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E420D6B0071; Tue, 15 Jun 2021 16:04:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D31856B0072; Tue, 15 Jun 2021 16:04:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id A0C1A6B006C for ; Tue, 15 Jun 2021 16:04:31 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 335E68249980 for ; Tue, 15 Jun 2021 20:04:31 +0000 (UTC) X-FDA: 78257035542.39.6768C75 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 9CEAFA00024C for ; Tue, 15 Jun 2021 20:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=/K2Rbrzi1/a5V8QQAme7rORjMQWprXhWq5HBHnlzt3E=; b=s/N+K1g5DM8AgZGy7u1xVvIxeh Bk5azVJ9VdGx43q6LOhrQoz3bNZtGuh1POvg8pTRyNm5tDrk9b1CmA1ks5IEf7NmLEebU6j5r7ZpH UW+UqcP4XtWXKoqWUGNVulaEspPqno9A+llqvZEPQ9uMvthGGc0wOoNvMcPaylE7lpR2AsLvAJ1O2 8TN+HTheOcqzTg6qRFrTz+n/e9PDnwHo5+E6J2z5lsV9EliBu2+LN5GhfOoTVh+7HgGVMkNZJ9M76 OY2E6iKBM5xnxtCXn/2T8sgua8djG+O6OJ481TNrHxiVB1W1a6ngetvTMNzULUrsrYZXHZLsI3eRg 2ucRcIVw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltFHh-007CcK-Or; Tue, 15 Jun 2021 20:03:47 +0000 From: "Matthew Wilcox (Oracle)" To: akpm@linux-foundation.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 3/5] mm/thp: Fix strncpy warning Date: Tue, 15 Jun 2021 21:02:40 +0100 Message-Id: <20210615200242.1716568-4-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210615200242.1716568-1-willy@infradead.org> References: <20210615200242.1716568-1-willy@infradead.org> MIME-Version: 1.0 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="s/N+K1g5"; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: 17e6skujts8km51zmeca6iurcbwjypcw X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9CEAFA00024C X-HE-Tag: 1623787462-205156 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Using MAX_INPUT_BUF_SZ as the maximum length of the string makes fortify complain as it thinks the string might be longer than the buffer, and if it is, we will end up with a "string" that is missing a NUL terminator. It's trivial to show that 'tok' points to a NUL-terminated string which is less than MAX_INPUT_BUF_SZ in length, so we may as well just use strcpy() and avoid the warning. Signed-off-by: Matthew Wilcox (Oracle) --- mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 503c8e1aecc6..d513b0cd1161 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3101,7 +3101,7 @@ static ssize_t split_huge_pages_write(struct file *file, const char __user *buf, tok = strsep(&buf, ","); if (tok) { - strncpy(file_path, tok, MAX_INPUT_BUF_SZ); + strcpy(file_path, tok); } else { ret = -EINVAL; goto out; From patchwork Tue Jun 15 20:02:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 12322805 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CE5C48BDF for ; Tue, 15 Jun 2021 20:05:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 24B4161246 for ; Tue, 15 Jun 2021 20:05:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24B4161246 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B0E676B006C; Tue, 15 Jun 2021 16:05:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE5356B006E; Tue, 15 Jun 2021 16:05:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D4C16B0070; Tue, 15 Jun 2021 16:05:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id 698ED6B006C for ; Tue, 15 Jun 2021 16:05:35 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0BB7F5850 for ; Tue, 15 Jun 2021 20:05:35 +0000 (UTC) X-FDA: 78257038230.34.3337713 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 84C71801936E for ; Tue, 15 Jun 2021 20:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=kn2mpUgOpu0H9qCE2/fjaqVI5HP12MIwSjzCbMAMWds=; b=l9lU2swTLL45Xs81s0vVlkC2uJ lWUzyr0j2Y8TAtxA47nf/NT0dC1Nsf8DaBokNPnMY+fdZn91hA7OT/fCMqm+xrbqUKDrvWHQ+7J8j NBREATXqlg6C8vNe2LnV1b9b74vYFuOMR9YWExE7EdckQLsItK6K1453K55GXaO33EvzdBlh73W4u Wtf6kZtn9TBspoWdSqwwHS31VLbArXd/aTRP7+LUX0p/dDnWr6ZEzvY+A3UB1oYEJ7wHmUVYunCZg Eme6y1nbyKlfwPU0ztVS1b1Mo7YYhnTdzf4MKzKiGiLNpiG+nplekhMMgFRGxzmsmDCV+dNNqh709 qEbTacig==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltFI7-007CeG-Us; Tue, 15 Jun 2021 20:04:22 +0000 From: "Matthew Wilcox (Oracle)" To: akpm@linux-foundation.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 4/5] mm/sparse-vmemmap: Fix documentation warning Date: Tue, 15 Jun 2021 21:02:41 +0100 Message-Id: <20210615200242.1716568-5-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210615200242.1716568-1-willy@infradead.org> References: <20210615200242.1716568-1-willy@infradead.org> MIME-Version: 1.0 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=l9lU2swT; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: 6ioj6g67zosaf6hahjpfn75eqc1rtx76 X-Rspamd-Queue-Id: 84C71801936E X-Rspamd-Server: rspam06 X-HE-Tag: 1623787525-435587 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: vmemmap_remap_walk is a struct, not a function, and needs to be marked accordingly. Signed-off-by: Matthew Wilcox (Oracle) --- mm/sparse-vmemmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index 693de0aec7a8..66740a79fe4e 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -35,7 +35,7 @@ #include /** - * vmemmap_remap_walk - walk vmemmap page table + * struct vmemmap_remap_walk - walk vmemmap page table * * @remap_pte: called for each lowest-level entry (PTE). * @reuse_page: the page which is reused for the tail vmemmap pages. From patchwork Tue Jun 15 20:02:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 12322807 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4983EC48BE5 for ; Tue, 15 Jun 2021 20:06:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EFC6E613B3 for ; Tue, 15 Jun 2021 20:06:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFC6E613B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 911D36B006E; Tue, 15 Jun 2021 16:06:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C2E86B0070; Tue, 15 Jun 2021 16:06:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B0DB6B0071; Tue, 15 Jun 2021 16:06:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 499986B006E for ; Tue, 15 Jun 2021 16:06:00 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DEA72DDE0 for ; Tue, 15 Jun 2021 20:05:59 +0000 (UTC) X-FDA: 78257039238.23.AE3335C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 4103DC005A20 for ; Tue, 15 Jun 2021 20:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=re1MTawONZjFlPXmpjEjCNJd4iGUcMIlGVL9RzGpkqg=; b=HCf7Nfu49Bpul4V+cVtPXbmbzH V7TpahDpuZqY3NaykL6Jzie/th2qOv+cFZgN2FlIs0rFVZq2pWEVBoKAWqr5mlfGK7mhGoXwBzsI6 ygffH5mbJQcOXKXM8O/ihEY8lPB7HQabSY4awioBcftO1FOUO0AeX+unOvNwWVDQ/HuOuF8QfAKQD hyDz+LchGpHS6z6McAf5ZGH2BvTnIz14G6bV5z3k4nS9PYqmc/eP8JGEnkkL4iSLLolD+f+rEginj Vq3T/mY7hL/c7TvLwSU//677yD+i2Km9uCw4WSOtdgcs4yH5klgu+cgoTa+PbLhGMNeujRVs7B8Mw KL8Zv5Yg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltFIg-007Cg4-HV; Tue, 15 Jun 2021 20:04:55 +0000 From: "Matthew Wilcox (Oracle)" To: akpm@linux-foundation.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH 5/5] mm: Fix alloc_vmemmap_page_list documentation warning Date: Tue, 15 Jun 2021 21:02:42 +0100 Message-Id: <20210615200242.1716568-6-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210615200242.1716568-1-willy@infradead.org> References: <20210615200242.1716568-1-willy@infradead.org> MIME-Version: 1.0 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HCf7Nfu4; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4103DC005A20 X-Stat-Signature: fiopocq8takndcw3ko9qkifyq3uink1g X-HE-Tag: 1623787549-344186 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This simple typo generates two warnings from kernel-doc. Signed-off-by: Matthew Wilcox (Oracle) --- mm/sparse-vmemmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index 66740a79fe4e..a3aa275e2668 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -272,7 +272,7 @@ static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, * @end: end address of the vmemmap virtual address range that we want to * remap. * @reuse: reuse address. - * @gpf_mask: GFP flag for allocating vmemmap pages. + * @gfp_mask: GFP flag for allocating vmemmap pages. */ int vmemmap_remap_alloc(unsigned long start, unsigned long end, unsigned long reuse, gfp_t gfp_mask)