From patchwork Wed Jun 16 19:54:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 12325835 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D41C48BE6 for ; Wed, 16 Jun 2021 19:54:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BABE26135C for ; Wed, 16 Jun 2021 19:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233170AbhFPT41 (ORCPT ); Wed, 16 Jun 2021 15:56:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233112AbhFPT4X (ORCPT ); Wed, 16 Jun 2021 15:56:23 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BBA8C06175F for ; Wed, 16 Jun 2021 12:54:13 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id y15so3080443pfl.4 for ; Wed, 16 Jun 2021 12:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ta3RbqOIn8BZORbiR4sH2Jl3iefLLCl3kYqOTHV1WDg=; b=QrkdJQqzr0NXGF3lxt9ugTPrUAhMSlDlW2SJ9fsA+KH7cm92Li7mXBFD4Wkcsn+sBO h8sV1XrNnlfzD0rRV96WfNd0eu5gQQ49QyP9rH5ggr4oiClHxuS+xESkSA1cO4kpL2IZ KTEQwm3qKh8NbOrUh0BV80kglJ0Di9sVT+K1o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ta3RbqOIn8BZORbiR4sH2Jl3iefLLCl3kYqOTHV1WDg=; b=RZKk5idXok/Tm/KMJFSYwHcnbELpfWk/MDxMJTBQ4OoMEtRxoZx2XOABKfQPbeGAeE CBnDVOwiyEL8XMODdiqAuueGLEDUxWcsSUleE0RMbHnq0Nxzgqv1eo1ufYm5Acp3gbkD +ejIvlKa/Is/p+PXu+r8xy3eeIW3fxuIRQILJ7YIcohJw2jUosr3A99K/4DKBDiHNxIc ZyPydsRK00njFyIP/3OBYx6fIUqTiljbVqadloSTHwphSIxv/N0BN7OCN8EIXTxapxXF 3YThRVc5yQsrTZqY4+9+HVKi/K4bI4F8PSfAy/q/+4MBvgWhI5WWiy6Mhgg3yUQkuo1z xF3A== X-Gm-Message-State: AOAM533g1CUzLqhcBEzfIaMs2j2FwS8GLa9CgCLWCFHuo1oloW605YXq iKTH3F38tAKDGKVoQIbDc7ciOA== X-Google-Smtp-Source: ABdhPJyV+Ew0riI0HXcKYe6MIMC6k+k3ndOX4eMCoUivqhy2b7e4mAVzoRSDmJfa0dGNcFL/NH1rSg== X-Received: by 2002:a63:e043:: with SMTP id n3mr1310592pgj.106.1623873252926; Wed, 16 Jun 2021 12:54:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c184sm2794609pfa.38.2021.06.16.12.54.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 12:54:12 -0700 (PDT) From: Kees Cook To: netdev@vger.kernel.org Cc: Kees Cook , Kalle Valo , "David S. Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH] ath11k: Avoid memcpy() over-reading of he_cap Date: Wed, 16 Jun 2021 12:54:10 -0700 Message-Id: <20210616195410.1232119-1-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Patch-Hashes: v=1; h=sha256; g=a0cab8be0bd22cb947a89c25d20b00b86ac2fb47; i=eJo4iKawiWzp/TGJDTmVIE2lOKR+PQjNu4KYQ5F00YM=; m=+6EB5srPoGi1D7Om5kP3HXtskB0VIFJiBD3X5t+nWWw=; p=fNBF6uun0+FYmLLA4u44niS95J1JvHuPRqCzmoIK3D4= X-Patch-Sig: m=pgp; i=keescook@chromium.org; s=0x0x8972F4DFDC6DC026; b=iQIzBAABCgAdFiEEpcP2jyKd1g9yPm4TiXL039xtwCYFAmDKVuIACgkQiXL039xtwCbTbRAAj9W ByUby95Dh+bLBWJHMugD4XSE2xrtVClsmeigQTMJnmvAxy08rlzrjqIoG+amV8BauQFvk6jc/zFZX 0u4vjIF7f9p65oQ4fBw9YlvkbHTVPqDgO8952UQ1F7Q9gVB1L1Fyz3lIFUkEl3raJljKDCOaEnPee CMZ9iDO61/WRyFCY/iXQ2ofLoOIevL+Fc/TqZPLX7dKZjSwpLrLzw6BrGPNdvc2GyBQqmy5qIHJt9 kT2K2w2QmATu1iZvTmsxAykWfJeoGhIK9yydYRgXatZDNBEI0Ad1XQ0YKllOVCHZWEyaXekZi7iWk VpyL1Z2mLn2zto3be8ZZLOUrKk5xI60KFnmhv1aPWu6YxL/4y6ELEK0qfIl2VZ518wt/jw3uY3nul 4kvV/wG7UFBhRhwt/A7Wi0yV0C6IXgswZga/1vHxfIGHl82M54CyCGEIWtYoC8J0raeshqamo1bbI R7SKkItM6CdhAB5PTlBjy+2XTAYs5SwqCf8SLdwU8pujY/0zvFmrL8P2vbFcrVyAgaZ4R3GBP8vci SyUAlI2nAP3Qy3y/MeVF+n6mLNY7vY28SI9ethoHlKWaZ9cGfLB3bHo2QLSfbEYeilPEM1L9RhDQH m2EL6AmnX8+pqOSu0Pqyd6RHXXtB6rxa4Z35r3ed+A0kQ/L1XchTO6mEVFXyTw0w= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memcpy(), memmove(), and memset(), avoid intentionally writing across neighboring array fields. Since peer_he_cap_{mac,phy}info and he_cap_elem.{mac,phy}_cap_info are not the same sizes, memcpy() was reading beyond field boundaries. Instead, correctly cap the copy length and pad out any difference in size (peer_he_cap_macinfo is 8 bytes whereas mac_cap_info is 6, and peer_he_cap_phyinfo is 12 bytes whereas phy_cap_info is 11). Signed-off-by: Kees Cook --- drivers/net/wireless/ath/ath11k/mac.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index 9d0ff150ec30..b1178a0b7fc3 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -1314,10 +1314,16 @@ static void ath11k_peer_assoc_h_he(struct ath11k *ar, arg->he_flag = true; - memcpy(&arg->peer_he_cap_macinfo, he_cap->he_cap_elem.mac_cap_info, - sizeof(arg->peer_he_cap_macinfo)); - memcpy(&arg->peer_he_cap_phyinfo, he_cap->he_cap_elem.phy_cap_info, - sizeof(arg->peer_he_cap_phyinfo)); + memcpy_and_pad(&arg->peer_he_cap_macinfo, + sizeof(arg->peer_he_cap_macinfo), + he_cap->he_cap_elem.mac_cap_info, + sizeof(he_cap->he_cap_elem.mac_cap_info), + 0); + memcpy_and_pad(&arg->peer_he_cap_phyinfo, + sizeof(arg->peer_he_cap_phyinfo), + he_cap->he_cap_elem.phy_cap_info, + sizeof(he_cap->he_cap_elem.phy_cap_info), + 0); arg->peer_he_ops = vif->bss_conf.he_oper.params; /* the top most byte is used to indicate BSS color info */