From patchwork Thu Jun 24 03:58:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Billy Tsai X-Patchwork-Id: 12340893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26988C48BDF for ; Thu, 24 Jun 2021 04:39:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D275A613C2 for ; Thu, 24 Jun 2021 04:39:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D275A613C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=DTSoNL7hmDIoGF2RBUW0FdwhBxc1tfHATOycAie2PWU=; b=SrTEq4lz8EmV17 aJJCLW3dQGRCRyG2iyS1XCytGfCw/35Gi4dOhFVgQ7I20sZqYqUCHHc9Q+hk/oO1Eiw8VSHQ80yAh u04tjNcdL8UDzXmcaCrckgM18qHtWIWPkPaG5TvTnRFCdMAzGbJ+tE3pA/oSk97wki3Of9Bno5rmR YCjmdF7gfIVQmipm6sf61CHom1Vf2lxCs7b7AmNv/0WQzcPMRirmyO1Hj897j5V7gY/0cgMB4sGBB J/O5QPKsMuva7CaEfFGPEAx6KOKis/a6aXRbBzlGcmKSm1OJzA01Yr2R7nGv7G5zhUPgr6Vp37DXf iZR43vIeWXY6g4sFwX6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwH87-00Ci9E-EV; Thu, 24 Jun 2021 04:38:19 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwH85-00Ci8X-Ad for linux-arm-kernel@bombadil.infradead.org; Thu, 24 Jun 2021 04:38:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=ChM3cfUYABMUAcKgElvS2mEpQ9vtYiGG0qwrLcuC/08=; b=YQXQlkizmvpQ94IoCKZ27bvezn 8xAmVcAUcenXYrki54LhdYABTpdFJXpBnvYMXdKSHKih9sY5fk/iT6jyoc93BNx73yQwVnsrVk/cU 8vvsCzu2Pcrit9T8GBQsUteicBPbgKac5vVT3wZq6SdXYhnnO6zc1W1C5gQe2qTrlYKWOmjoOtrJH sk53U7y15B6yso/95ArwyqQ1sDbFwdF8Tf/7kvaGwOvo9BlTDcZl2g/1KnaU2qVB+DaIrNwqpDHnf /9Rx4p9xwU7MHhLI3ef7+yMJEOMSCf6h8Y7BTiLUI2ZD/DoKu8LyItHHbh4dNsgW6574tvh6wtjcN 5E33PGgQ==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwGUa-00B7go-U4 for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 03:57:39 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 15O3gSQj076749; Thu, 24 Jun 2021 11:42:28 +0800 (GMT-8) (envelope-from billy_tsai@aspeedtech.com) Received: from BillyTsai-pc.aspeed.com (192.168.2.149) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 24 Jun 2021 11:57:15 +0800 From: Billy Tsai To: , , , , , , , CC: Subject: [PATCH] hwmon: (aspeed-pwm-tacho) Using falling edge. Date: Thu, 24 Jun 2021 11:58:21 +0800 Message-ID: <20210624035821.25375-1-billy_tsai@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [192.168.2.149] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 15O3gSQj076749 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_045736_394634_582342CB X-CRM114-Status: UNSURE ( 9.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The tach shouldn't use both edges to measure. When the tach input duty cycle isn't 50% the return value will inaccurate. Signed-off-by: Billy Tsai --- drivers/hwmon/aspeed-pwm-tacho.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c index 3d8239fd66ed..0a70a0e22acf 100644 --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -158,7 +158,7 @@ * 10: both * 11: reserved. */ -#define M_TACH_MODE 0x02 /* 10b */ +#define M_TACH_MODE 0x00 /* 10b */ #define M_TACH_UNIT 0x0210 #define INIT_FAN_CTRL 0xFF