From patchwork Mon Jun 28 10:01:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 12347583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40502C49EB9 for ; Mon, 28 Jun 2021 10:02:42 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D94B61260 for ; Mon, 28 Jun 2021 10:02:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D94B61260 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.147771.272714 (Exim 4.92) (envelope-from ) id 1lxo67-00061q-TR; Mon, 28 Jun 2021 10:02:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 147771.272714; Mon, 28 Jun 2021 10:02:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lxo67-00061j-QN; Mon, 28 Jun 2021 10:02:35 +0000 Received: by outflank-mailman (input) for mailman id 147771; Mon, 28 Jun 2021 10:02:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lxo66-0005wp-Gw for xen-devel@lists.xenproject.org; Mon, 28 Jun 2021 10:02:34 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 09cc351c-5b7e-4cef-bfed-25fc7fb7c0d6; Mon, 28 Jun 2021 10:02:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09cc351c-5b7e-4cef-bfed-25fc7fb7c0d6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1624874551; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zX7r6xlS7TNdyxVtVDnfSmlYIWmjPsGRxGAv5/JWNnQ=; b=FQwU2ap1wo1uKbFhE/luE3zbRumfwRGYdMT7OW85PR5BK7dY2k8TSfqn fGGFPTbVGr3aNICDrsEtUQjh3lX3Wd3bq84oJfqlKXEZpbZXxO8Y6u4EX JBsyWgz+Tl4ubkzm/3IHSVCu0+r1hM8D7fUg1ChCVzLzE/5GwXvILpp8q 4=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: n5gxZFmaZzav9i0hIZl6nPfPEGi8RDin+0d1osdGIO9tE8G3j0M9He1JPF7G9H2IvGPKw83T1U A6UH24O+f00PcCPWCc6sZeX1iVp59pZhUk/3NwXrwYdbKlOJZu4szhcH7VfzHzeww7u5OFJtk+ 4JXUpikLrykFlgjnTYTNQfMCQt3d2Ps1kSuR2JI/WYhLWiK9BbwAu3WRhWhWmpFW2iUHwnv+lR eYPVrJG+V20/qqWc2c5qsn20oEhkdasNJ/iaB2PWio9UcyZJ0qTlvXrEViRrUCEpNpp3LZf7c7 4r4= X-SBRS: 5.1 X-MesageID: 46798712 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:LM1oV6uo0TSbWDEt5CaUj1xL7skDcNV00zEX/kB9WHVpmszxra +TdZMgpHjJYVcqKQgdcL+7WZVoLUmwyXcx2/hyAV7AZniDhILLFuFfBOLZqlWKcREWtNQtsJ uIG5IObuEYZmIVsS+V2mWF+q4bsbq6zJw= X-IronPort-AV: E=Sophos;i="5.83,305,1616472000"; d="scan'208";a="46798712" From: Anthony PERARD To: CC: Anthony PERARD , Ian Jackson , Wei Liu , Juergen Gross Subject: [XEN PATCH 1/2] libxl: Replace short-form boolean for QEMU's -vnc Date: Mon, 28 Jun 2021 11:01:56 +0100 Message-ID: <20210628100157.5010-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210628100157.5010-1-anthony.perard@citrix.com> References: <20210628100157.5010-1-anthony.perard@citrix.com> MIME-Version: 1.0 f3f778c81769 forgot one boolean parameter. Fixes: f3f778c81769 ("libxl: Replace QEMU's command line short-form boolean option") Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk --- tools/libs/light/libxl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 5b01cf284163..7670e403a90f 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1324,7 +1324,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, vncarg = GCSPRINTF("127.0.0.1:%d", vnc->display); if (vnc->passwd && vnc->passwd[0]) { - vncarg = GCSPRINTF("%s,password", vncarg); + vncarg = GCSPRINTF("%s,password=on", vncarg); } if (libxl_defbool_val(vnc->findunused)) { From patchwork Mon Jun 28 10:01:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 12347585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E63C2B9F4 for ; Mon, 28 Jun 2021 10:02:47 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84C246121E for ; Mon, 28 Jun 2021 10:02:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84C246121E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.147772.272726 (Exim 4.92) (envelope-from ) id 1lxo6D-0006Lv-6a; Mon, 28 Jun 2021 10:02:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 147772.272726; Mon, 28 Jun 2021 10:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lxo6D-0006Lo-2Z; Mon, 28 Jun 2021 10:02:41 +0000 Received: by outflank-mailman (input) for mailman id 147772; Mon, 28 Jun 2021 10:02:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lxo6B-0005wp-Gv for xen-devel@lists.xenproject.org; Mon, 28 Jun 2021 10:02:39 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ef78c4ea-94b6-4a83-90a9-67fc60d55536; Mon, 28 Jun 2021 10:02:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef78c4ea-94b6-4a83-90a9-67fc60d55536 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1624874554; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UFTvpVdfNxrP+bv4AAuRgBxIwdYxDQVjcOfg33auNmM=; b=SPrxiYJ/2NRLD/c1MVWnAm0GakSn4oiEYTE8FPb5yiqv059TqXasGUX3 lSBZiMlfzimG9HJmSK7hwNk9+HprKx2d/MbtIQRgTABRF0BcwUV8TnMQ8 DtVfeIaI6aOUdayssaovIuRLCRZyAK1M1KdJfnfOMQNB36fSJ43j2BBa6 g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 4EIA5kcW1I6IqWbB+qeCtYNw3oo2Q9HJXNiY2CMTTgZnDDEBM/SV7FaV2HZJ+QYny5PXW8Mg9u 80tq3JTLTo+MI3tw7fY9RxlYYOT8A1JuChY+OxJCMvv8bYnptTOpeJ6UR4BGSRjz6qR/1xSTKI K/T/Zg310ZGzxbnRaDtDFCVY5pUJpZnRuJ1qo72owudqVogHXZWQk9MeiSPZS8INyYbt+qkG+T fDWZuJZj83Gx1snThFk3/Mv3569pUL38t7Lb4JmIMn1FXoNP/2Z0h27C5kEUe7xpK9ipXhhrOf 1YU= X-SBRS: 5.1 X-MesageID: 46798714 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:UPF/eatQEQe/qgrHq7XYEzf+7skDTtV00zEX/kB9WHVpmszxra 6TdZMgpHnJYVcqKQkdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79 YFT0EXMqyIMbEQt6fHCWeDfOrIuOP3kpyVuQ== X-IronPort-AV: E=Sophos;i="5.83,305,1616472000"; d="scan'208";a="46798714" From: Anthony PERARD To: CC: Anthony PERARD , Ian Jackson , Wei Liu , Juergen Gross Subject: [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device Date: Mon, 28 Jun 2021 11:01:57 +0100 Message-ID: <20210628100157.5010-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210628100157.5010-1-anthony.perard@citrix.com> References: <20210628100157.5010-1-anthony.perard@citrix.com> MIME-Version: 1.0 Usage of 'scsi-disk' device is deprecated and removed from QEMU, instead we need to use 'scsi-hd' for hard drives. See QEMU 879be3af49 (hw/scsi: remove 'scsi-disk' device) Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk --- tools/libs/light/libxl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 7670e403a90f..dbd3c7f278f9 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1972,7 +1972,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, &drive_id), flexarray_vappend(dm_args, "-drive", drive, - "-device", GCSPRINTF("scsi-disk,drive=%s,scsi-id=%d", + "-device", GCSPRINTF("scsi-hd,drive=%s,scsi-id=%d", drive_id, disk), NULL); continue;