From patchwork Mon Jul 5 13:54:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Programmingkid X-Patchwork-Id: 12359141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58108C07E99 for ; Mon, 5 Jul 2021 13:56:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5A9761263 for ; Mon, 5 Jul 2021 13:56:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5A9761263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0P5A-0002Pc-R4 for qemu-devel@archiver.kernel.org; Mon, 05 Jul 2021 09:56:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0P3V-00014y-Kh for qemu-devel@nongnu.org; Mon, 05 Jul 2021 09:54:37 -0400 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]:46615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0P3U-00020V-4S for qemu-devel@nongnu.org; Mon, 05 Jul 2021 09:54:37 -0400 Received: by mail-qv1-xf32.google.com with SMTP id g15so5868675qvi.13 for ; Mon, 05 Jul 2021 06:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=LbvrBxtF0N6wyl7nFcuT1QdGTNRdy6hVdSgYSkKa3Kk=; b=J6u5aSeVK8sdsPMqKThTlGgaROai2Ju5KVmTebvGXX78KFcIj+rQU0UZYOb8tWKAcN rM0CdbAzQYuE7fHCik5qKPEtAX+ImMUJwXUID7LCHbVJFRoQJ1nvvXWni7/98wElZJch qzV6PS0XYJOn8KN4DdJI5cYLvrEWVnSjSQAM3GGG4crM0bd20AhODZD3fPYAasVrOju+ 4zNuftG8fSKgB3foGkSXPlP7SBZc3uLBM1Qc/tXHM5X1wgwirv3a2pW3oVYKa+NY+Nzw W0tTgjLQx8d4XSpFxdiwb6reuH1v3ljUrE7FnMfbhEIuaNaZ2r2yHEAZL282Cd6cAmD3 nUhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=LbvrBxtF0N6wyl7nFcuT1QdGTNRdy6hVdSgYSkKa3Kk=; b=WT0aFIZkz3R5G+K4jlX2y/imeB2lj2LjMeoBenerdEUQYA3hnH2Y2T2B7A74rz20NY spOKCr95H5IEgZ9TUS2epKPFsAZJqukSrdYytIfDngEKZD0NIVf+II+afuZHsHiEc3Hh cU+NJPTGX02aMLcFR5l7vqsBuLxpSEajm5KCwvTjf1E4hth+4Jg5QQv2WvxHnnF3WOU7 6miXcIyKOmmiUth9Y5+N+ITuOaiZEHKXrxH8/fDp2k+at/wvjCLrHF35AFWu7bx6pr9e Itb1oDV6nUYawzEqQcIqkl6aS56EffLUqxxyag6vHAOT6GI/DRrzifoNvzD7TA8E4CpK 1viw== X-Gm-Message-State: AOAM532FVF3essRmKKEwyUrE7tyWw0oleZUW1bwY+71EOOqj87MTeQeZ WpDHUslSF1Ae/VKRvwda7oY= X-Google-Smtp-Source: ABdhPJy6ohtVh3Oghye/c0n1tFakFJmYaY24xLt/RhhFkFPRAVLCsmQ2cdsueEtN9sG4pww+fdq6eQ== X-Received: by 2002:a05:6214:da3:: with SMTP id h3mr4359233qvh.31.1625493275212; Mon, 05 Jul 2021 06:54:35 -0700 (PDT) Received: from [192.168.0.6] (d149-67-175-105.try.wideopenwest.com. [67.149.105.175]) by smtp.gmail.com with ESMTPSA id o66sm5530006qkd.60.2021.07.05.06.54.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jul 2021 06:54:34 -0700 (PDT) From: Programmingkid Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: [PATCH] Set icon for QEMU binary on Mac OS Message-Id: <325BA2AF-B4F5-4134-BF90-63282E0B2A46@gmail.com> Date: Mon, 5 Jul 2021 09:54:34 -0400 To: Paolo Bonzini , QEMU devel list X-Mailer: Apple Mail (2.3654.40.0.2.32) Received-SPF: pass client-ip=2607:f8b0:4864:20::f32; envelope-from=programmingkidx@gmail.com; helo=mail-qv1-xf32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Paolo, I was told you were the one who I should send this patch to. Please let me know if you feel otherwise. Before switching the build system over to Meson, an icon was added to the QEMU binary on Mac OS. This patch adds back that feature. Signed-off-by: John Arbuckle --- meson.build | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/meson.build b/meson.build index f00b7754fd..7f534f4e75 100644 --- a/meson.build +++ b/meson.build @@ -2183,6 +2183,26 @@ foreach target : target_dirs link_args: link_args, gui_app: exe['gui']) +# set QEMU's icon on Mac OS +if targetos == 'darwin' + newiconpart1 = custom_target('Icon for ' + exe_name + ' - part 1', + depends : emulator, + input : emulator, + output : 'new icon for ' + exe_name + ' - 1', + command : ['Rez', '-append', + meson.source_root() + '/pc-bios/qemu.rsrc', '-o', + meson.current_build_dir() / exe['name']], + build_by_default : true) + + custom_target('Icon for ' + exe_name + ' - part 2', + depends : newiconpart1, + input : emulator, + output : 'new icon for ' + exe_name + ' - 2', + command : ['SetFile', '-a', 'C', + meson.current_build_dir() / exe['name']], + build_by_default : true) +endif + if exe_sign emulators += {exe['name'] : custom_target(exe['name'], install: true,