From patchwork Tue Jul 20 12:41:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minas Harutyunyan X-Patchwork-Id: 12388191 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C47F1C07E95 for ; Tue, 20 Jul 2021 12:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 965276113C for ; Tue, 20 Jul 2021 12:41:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbhGTMA4 (ORCPT ); Tue, 20 Jul 2021 08:00:56 -0400 Received: from smtprelay-out1.synopsys.com ([149.117.73.133]:57584 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbhGTMAx (ORCPT ); Tue, 20 Jul 2021 08:00:53 -0400 Received: from mailhost.synopsys.com (mdc-mailhost2.synopsys.com [10.225.0.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mailhost.synopsys.com", Issuer "SNPSica2" (verified OK)) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 05C7045E95; Tue, 20 Jul 2021 12:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1626784890; bh=tcUF+fY1A0iv1tKpGAeaj9fgtXIdHaLpHihvNPeGoWY=; h=Date:From:Subject:To:Cc:From; b=l2VZv+Mqx41ZBXjxSP/JeIBb6s10ulCoQ90ZxAIKQmk7tqpNYB0xMQYTI1k1sOmkL c+aKMFDDkj5O9t3i02Z6n0I4K8VVXhjjc6+e95IeyKbn9d/m34O2z9KZTNbr0FH2CM fvvslNYZaBI+FRRvTKON7V3io+62ua/KEX9TuQjv0SJlfT3+CEdzmDgifHnBwPgqoS JBwLcazq9wa78TWfeG0GA9/3qlaUFG2+TZEEt0Fzf1r4KXRMiQEM47hHwu/NSgWM/U y689h4vAwlNnSF/7ckKh07fdFZE/OJhqwRoKUwfZCBvAz8j0YsPK7/KilMucPdYcj3 QdKs+X/rZsC0w== Received: from Armenia_lab (armenia_lab.internal.synopsys.com [10.116.75.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mailhost.synopsys.com (Postfix) with ESMTPSA id F0E9AA005C; Tue, 20 Jul 2021 12:41:25 +0000 (UTC) Received: by Armenia_lab (sSMTP sendmail emulation); Tue, 20 Jul 2021 05:41:24 -0700 Date: Tue, 20 Jul 2021 05:41:24 -0700 Message-Id: <967bad78c55dd2db1c19714eee3d0a17cf99d74a.1626777738.git.Minas.Harutyunyan@synopsys.com> X-SNPS-Relay: synopsys.com From: Minas Harutyunyan Subject: [PATCH v4] usb: dwc2: gadget: Fix sending zero length packet in DDMA mode. To: Felipe Balbi , Greg Kroah-Hartman , Minas Harutyunyan , Paul Zimmerman , linux-usb@vger.kernel.org, Mian Yousaf Kaukab , Gregory Herrero Cc: John Youn , Minas Harutyunyan , Robert Baldyga Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Sending zero length packet in DDMA mode perform by DMA descriptor by setting SP (short packet) flag. For DDMA in function dwc2_hsotg_complete_in() does not need to send zlp. Tested by USBCV MSC tests. Fixes: f71b5e2533de ("usb: dwc2: gadget: fix zero length packet transfers") Signed-off-by: Minas Harutyunyan --- Changes in v4: - In DDMA mode should go forward to move status OUT phase Changes in v3: - Updated mail recipient list Changes in v2: - Minor typo correction in comments drivers/usb/dwc2/gadget.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) base-commit: 00a738b86ec0c88ad4745f658966f951cbe4c885 diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index c581ee41ac81..807c3cfec8e9 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2749,12 +2749,14 @@ static void dwc2_hsotg_complete_in(struct dwc2_hsotg *hsotg, return; } - /* Zlp for all endpoints, for ep0 only in DATA IN stage */ + /* Zlp for all endpoints in non DDMA, for ep0 only in DATA IN stage */ if (hs_ep->send_zlp) { - dwc2_hsotg_program_zlp(hsotg, hs_ep); hs_ep->send_zlp = 0; - /* transfer will be completed on next complete interrupt */ - return; + if (!using_desc_dma(hsotg)) { + dwc2_hsotg_program_zlp(hsotg, hs_ep); + /* transfer will be completed on next complete interrupt */ + return; + } } if (hs_ep->index == 0 && hsotg->ep0_state == DWC2_EP0_DATA_IN) {