From patchwork Fri Jul 30 04:13:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Lapkin X-Patchwork-Id: 12410363 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 101C6C4338F for ; Fri, 30 Jul 2021 04:14:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E557160FD7 for ; Fri, 30 Jul 2021 04:14:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230181AbhG3EOT (ORCPT ); Fri, 30 Jul 2021 00:14:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229465AbhG3EOT (ORCPT ); Fri, 30 Jul 2021 00:14:19 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61788C061765; Thu, 29 Jul 2021 21:14:14 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id q17-20020a17090a2e11b02901757deaf2c8so12744471pjd.0; Thu, 29 Jul 2021 21:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AoyWEpL0YVaQE9+ONyJr4LFablmBYJyxFXjy9TOBNNM=; b=e4g8fCwQWSMiPKyMS3xOy0kn8ySE15HVD9klYxHd0iWkDDCAhg5u1WiUT7OZgaoWOz WP4rgRiC7L3WdQL/FXiN6QIMaK9Iu60ECweg38Nqysz/PxliK2vQG7UngRyZabypHCoy jB5gdbbQJRakgljm3aaHZBlDj6JqC69f1zIw88Y6Pqpla906qN3Ny0mPSgHWbWcbu+93 tiSM0FfmpwjET5hATIpcxPJcvkLZ6awmz8H4wt3S5gdua4HVJto2VRUumnAawsznE6Ss skxEt/Lp3eVLaV2U3mfw0Sl2nmByonaf0My4XQRa5f6+Fbr+/0stDORGFfRgRSr7A3nL ZpEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AoyWEpL0YVaQE9+ONyJr4LFablmBYJyxFXjy9TOBNNM=; b=ffz/ULDX9QWaDqlaZ9AixEol1dl75mZZ8FtmL+EbJw2DvowBE9IfKW+X5cSHxZuCPD R6FSIr99im8NL+jAaDHuJT++elOn8nv8sgk9TX0HxDucUpiNYDyuDzBStU+ks/ukViqS ww6dqVBcq7/R0lFBKAbNZfYvrdTg4HL6C4qJhPrCd0zjowasSzkGijq7qdPZ/UX1pWQB crTiXV9hfWjnJ2ywszJ7xi1Wl94nXM8DQwLq9pzR78RYoUc6ACnb7+XmJH02OKti7nQN q+FTheVVKwglQksCI+gPgFHDeoR8IvBicO3BVkjyGbyzGBwGDcWHnFGZzDA+pUK2XELP 9FPg== X-Gm-Message-State: AOAM530FhTyAjJIYwPb8PJOFOTzTx0oppoFYd4SJ2gMcOcKOyQKcycC2 P9iBKq6ob9mx11et46VnbnM= X-Google-Smtp-Source: ABdhPJwx/PToy3FwF3WwEtnts+RJLI8IjXehkAeFuBJIPYUzM3QTFrLsAXSHWvmAw5W+PHEUysy22g== X-Received: by 2002:a05:6a00:26d0:b029:32d:7d40:5859 with SMTP id p16-20020a056a0026d0b029032d7d405859mr593191pfw.76.1627618454004; Thu, 29 Jul 2021 21:14:14 -0700 (PDT) Received: from localhost.localdomain (104.194.74.249.16clouds.com. [104.194.74.249]) by smtp.gmail.com with ESMTPSA id x4sm440943pfb.27.2021.07.29.21.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 21:14:13 -0700 (PDT) From: Artem Lapkin X-Google-Original-From: Artem Lapkin To: narmstrong@baylibre.com Cc: wim@linux-watchdog.org, linux@roeck-us.net, khilman@baylibre.com, jbrunet@baylibre.com, christianshewitt@gmail.com, martin.blumenstingl@googlemail.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, art@khadas.com, nick@khadas.com, gouwa@khadas.com Subject: [PATCH v4 1/3] watchdog: meson_gxbb_wdt: add nowayout parameter Date: Fri, 30 Jul 2021 12:13:53 +0800 Message-Id: <20210730041355.2810397-2-art@khadas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210730041355.2810397-1-art@khadas.com> References: <20210730041355.2810397-1-art@khadas.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Add nowayout module parameter Signed-off-by: Artem Lapkin Reviewed-by: Guenter Roeck --- drivers/watchdog/meson_gxbb_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c index 5a9ca10fbcfa..5aebc3a09652 100644 --- a/drivers/watchdog/meson_gxbb_wdt.c +++ b/drivers/watchdog/meson_gxbb_wdt.c @@ -29,6 +29,11 @@ #define GXBB_WDT_TCNT_SETUP_MASK (BIT(16) - 1) #define GXBB_WDT_TCNT_CNT_SHIFT 16 +static bool nowayout = WATCHDOG_NOWAYOUT; +module_param(nowayout, bool, 0); +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default=" + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); + struct meson_gxbb_wdt { void __iomem *reg_base; struct watchdog_device wdt_dev; @@ -175,6 +180,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) data->wdt_dev.max_hw_heartbeat_ms = GXBB_WDT_TCNT_SETUP_MASK; data->wdt_dev.min_timeout = 1; data->wdt_dev.timeout = DEFAULT_TIMEOUT; + watchdog_set_nowayout(&data->wdt_dev, nowayout); watchdog_set_drvdata(&data->wdt_dev, data); /* Setup with 1ms timebase */ From patchwork Fri Jul 30 04:13:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Lapkin X-Patchwork-Id: 12410365 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C2DC4338F for ; Fri, 30 Jul 2021 04:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3EA060FD7 for ; Fri, 30 Jul 2021 04:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230340AbhG3EOY (ORCPT ); Fri, 30 Jul 2021 00:14:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230241AbhG3EOX (ORCPT ); Fri, 30 Jul 2021 00:14:23 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93975C061765; Thu, 29 Jul 2021 21:14:19 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id q17-20020a17090a2e11b02901757deaf2c8so12744731pjd.0; Thu, 29 Jul 2021 21:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CedIVTVLdu/lypJPj4Dg+lxWwqXrdBZt0BeM9wWDGz8=; b=jZ6MhW4oRJotCzmn9yT9MzAXcuBUV4+57oKI8XRLcj5BfUBrWhl+uwGd7F82BKF8pf 2c65NwcMmRf/nSdIRKYUcqzqhtpou4abeb4Ybc+mn06aHa/21n5HQeCL2pKcGd57TBxz ZBYpPZbt4axbS0We7eLYBb9y490YVQkggWcgf+PFyov6L+VmI0HdFmqNt34ih3C0VqDK N6US9Tbo10ixo3qPxXM47CupTy23gPjLzUlmkaA95zzCItYAd4TQyEb8tc6I99/Fz9Pk diUucro3uDhnpqsaxEXmbvJJs0NUwZn426AKrqMZROSxvv20o5uRKGsBIQXEqMpo4lgP Z4/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CedIVTVLdu/lypJPj4Dg+lxWwqXrdBZt0BeM9wWDGz8=; b=uVWTxgt9KzcPQqxkQxolNX7k7eCXrrErMDpTxIMjUwi96kL1xOEVlJr9eam4Sn0mkz 5M3jXWb+bi38FM4vlKmFwv+/xuSxqNL6QT9PgVzpCB1d1x11pV5kCWPZv1ocToHkVh9J YNcpelmaGbUQw383PS4Wj5GHykjGMXItysNk4XSUAyCYQbqD5hQT2Kh1YtZVJvmGbJUC jtycAhpWRppBdojsdRvyPCfOEPCGsQNTKyFSoMWCmmfyahF0IAdaX6oltpeBtc+CHMAQ O5M1jDhsLZGns38ay3vO8XkT+GezrOjUlKnW7DmvZp/4jzD/hW1WACUogREm9d/7+0ag Z/Gw== X-Gm-Message-State: AOAM530czSEzmGn5hV0PpYKnF2Y2ZhgSdfOoI2h4TLBZ/63fj79vSvG4 /vnAyRoFxseRWMsu4tRAFog= X-Google-Smtp-Source: ABdhPJy3kNbcx3oc1mWZ4cBWSGRz4ql7ZJ9dNzE7MfbESnJvcd7q99M/D3ctid0xDHHp5sx1BUSIlw== X-Received: by 2002:a05:6a00:1352:b029:331:afed:38b5 with SMTP id k18-20020a056a001352b0290331afed38b5mr793450pfu.5.1627618459222; Thu, 29 Jul 2021 21:14:19 -0700 (PDT) Received: from localhost.localdomain (104.194.74.249.16clouds.com. [104.194.74.249]) by smtp.gmail.com with ESMTPSA id x4sm440943pfb.27.2021.07.29.21.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 21:14:18 -0700 (PDT) From: Artem Lapkin X-Google-Original-From: Artem Lapkin To: narmstrong@baylibre.com Cc: wim@linux-watchdog.org, linux@roeck-us.net, khilman@baylibre.com, jbrunet@baylibre.com, christianshewitt@gmail.com, martin.blumenstingl@googlemail.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, art@khadas.com, nick@khadas.com, gouwa@khadas.com Subject: [PATCH v4 2/3] watchdog: meson_gxbb_wdt: add timeout parameter Date: Fri, 30 Jul 2021 12:13:54 +0800 Message-Id: <20210730041355.2810397-3-art@khadas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210730041355.2810397-1-art@khadas.com> References: <20210730041355.2810397-1-art@khadas.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Add timeout module parameter Signed-off-by: Artem Lapkin Reviewed-by: Guenter Roeck --- drivers/watchdog/meson_gxbb_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c index 5aebc3a09652..945f5e65db57 100644 --- a/drivers/watchdog/meson_gxbb_wdt.c +++ b/drivers/watchdog/meson_gxbb_wdt.c @@ -34,6 +34,11 @@ module_param(nowayout, bool, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); +static unsigned int timeout; +module_param(timeout, uint, 0); +MODULE_PARM_DESC(timeout, "Watchdog heartbeat in seconds=" + __MODULE_STRING(DEFAULT_TIMEOUT) ")"); + struct meson_gxbb_wdt { void __iomem *reg_base; struct watchdog_device wdt_dev; @@ -180,6 +185,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) data->wdt_dev.max_hw_heartbeat_ms = GXBB_WDT_TCNT_SETUP_MASK; data->wdt_dev.min_timeout = 1; data->wdt_dev.timeout = DEFAULT_TIMEOUT; + watchdog_init_timeout(&data->wdt_dev, timeout, dev); watchdog_set_nowayout(&data->wdt_dev, nowayout); watchdog_set_drvdata(&data->wdt_dev, data); From patchwork Fri Jul 30 04:13:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Lapkin X-Patchwork-Id: 12410367 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7FAEC4338F for ; Fri, 30 Jul 2021 04:14:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5C0060FD7 for ; Fri, 30 Jul 2021 04:14:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbhG3EOa (ORCPT ); Fri, 30 Jul 2021 00:14:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230518AbhG3EO3 (ORCPT ); Fri, 30 Jul 2021 00:14:29 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8640FC0613D3; Thu, 29 Jul 2021 21:14:25 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id k1so9501247plt.12; Thu, 29 Jul 2021 21:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=THlXvdugKjy738Af7uzCz/sE8sNAleTeISkp07PWT4A=; b=H35Ors0FFD34qtaXeNIP4c1cwPkkHP4ht1nwzgRtEWswKY8aa7wM0bzDdrblMnMRiE Fcuxs+17mCV4wQSM7/e6+MN730M2l6A5Jb0b0SuEHDsezAOw/q21R86m+3D9jXMRLrco Y0HtifeTjE6szdCS6sbtte1nvlYq8DLuhUDzhzxzzOMlZwzF23VOCxGx/FxAfVrcdZe0 YTuS0LMXEgs/i3yBPygZylVqAYYj4xioM36QXq+RXoBBwQM/vHbhNwjQX28zMUtfyplX iRGU3qcPingRUYPqlWeh86+yOmTZgC1hcdKt+xURMvWVXmoE+JvLGPJuo40vDaR7vTPC twaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=THlXvdugKjy738Af7uzCz/sE8sNAleTeISkp07PWT4A=; b=UrnG2xEozui4Md0usRuJsYc8pHmy7oFx7xdAIBoNEOKmpEXUza8lH3ubmdMOq3S3wQ EsA/MU4xkXE8eIfJCDUJStJTxcGMe7eubHTqy11+NOPfJK+6uH+7rTuUQRz4NPd63hLD MqDC9TLfd72YVf7Z14FCI+bhk6LUN8KNN2X7fbH2x1kEk5LlGlbg+mHZ1rTzuN63LWvq x+T31v3CKulUeN/VvcLXol2Vo3H6J82rRR0HlVyqb8x3Mw1QsnlkRzr0QYC+hZ6XXySA CRqxo1hqfEVJRIG7VVQi8mpoLjPihS2B1nq4dU9KeamkjRkYYa1ql5Mka7xmdYw/1c3F LKBQ== X-Gm-Message-State: AOAM5327IuzJpEmZjnS7AYjg4k+8jmkmFNXu7pFYNul3Ob3o3ShQ0uv/ h8YW2Mr+KMixqkYzLwJUfkY= X-Google-Smtp-Source: ABdhPJxvMMQTQ8ZucVsWnf6w8qPI5/FCghjRAAqBf7VfGnkGVfCSZ1aInLllbvRQCIWqY/rqbG7lDQ== X-Received: by 2002:a63:1f5c:: with SMTP id q28mr527713pgm.114.1627618465126; Thu, 29 Jul 2021 21:14:25 -0700 (PDT) Received: from localhost.localdomain (104.194.74.249.16clouds.com. [104.194.74.249]) by smtp.gmail.com with ESMTPSA id x4sm440943pfb.27.2021.07.29.21.14.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 21:14:24 -0700 (PDT) From: Artem Lapkin X-Google-Original-From: Artem Lapkin To: narmstrong@baylibre.com Cc: wim@linux-watchdog.org, linux@roeck-us.net, khilman@baylibre.com, jbrunet@baylibre.com, christianshewitt@gmail.com, martin.blumenstingl@googlemail.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, art@khadas.com, nick@khadas.com, gouwa@khadas.com Subject: [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot Date: Fri, 30 Jul 2021 12:13:55 +0800 Message-Id: <20210730041355.2810397-4-art@khadas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210730041355.2810397-1-art@khadas.com> References: <20210730041355.2810397-1-art@khadas.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Remove watchdog_stop_on_reboot() Meson platform still have some hardware drivers problems for some configurations which can freeze device on shutdown/reboot stage and i think better to have reboot warranty by default. I feel that it is important to keep the watchdog running during the reboot sequence, in the event that an abnormal driver freezes the reboot process. This is my personal opinion and I hope the driver authors will agree with my proposal, or just ignore this commit if not. https://lore.kernel.org/linux-watchdog/20210729072308.1908904-1-art@khadas.com/T/#t Signed-off-by: Artem Lapkin --- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c index 945f5e65db57..d3c9e2f6e63b 100644 --- a/drivers/watchdog/meson_gxbb_wdt.c +++ b/drivers/watchdog/meson_gxbb_wdt.c @@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); - watchdog_stop_on_reboot(&data->wdt_dev); return devm_watchdog_register_device(dev, &data->wdt_dev); }