From patchwork Fri Jul 30 06:18:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Tso X-Patchwork-Id: 12410435 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39EC5C4338F for ; Fri, 30 Jul 2021 06:18:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A97560F4B for ; Fri, 30 Jul 2021 06:18:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237370AbhG3GSs (ORCPT ); Fri, 30 Jul 2021 02:18:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237398AbhG3GSq (ORCPT ); Fri, 30 Jul 2021 02:18:46 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8239AC0613D5 for ; Thu, 29 Jul 2021 23:18:41 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id f17-20020a170902ab91b029012c3bac8d81so7042004plr.23 for ; Thu, 29 Jul 2021 23:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=GiuZxc2vIiLi2GqaesW3uMQvAdi+WLEB0SZDBvMyFBc=; b=foRUqLVlSjmizeJNocTQye6ZVD67JVkh3FdovVxhNjH/zTyA+gDaWirmQ648Vicltl 7Wjn9luTlCmJb9MASEjDbju5cJnELhETFLPwR8J/c2PBblG4zzf9ICys3tOj1lBDOKYG bUjvulpTDKezUyAzu2oLm8yn4+AuEcevzuiV2NdnaWsEHYgeaghIOTgXdxq6vjd+Kgfx GJiB2EXr45j2UvVUOI8S+U+F/bRNeZXrxVYGnyZB1BDy7DPTbWHzW/J2W+66G7hOSW8e jGMeFz8BEqXG1keUgJASuuxOF2bhzSkW4y1pxYr7JpmdZeac6eKEdG7GMM8wZ8XpMJg9 AP6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=GiuZxc2vIiLi2GqaesW3uMQvAdi+WLEB0SZDBvMyFBc=; b=ukCsrewjHJDcIRfIUGULsoPRcheGR02gC9Fe3NUsXR+/4Jz6NwdziOZalCSMUa8Q3v CIKxSwgKdeDEQw7DR2L61ullpo4YkgJTkuDqf75F5O1BHPrF7u16ZOUdfE4amkLnW73U EBhzIQezW1BpGEndp1ltZN1BFn2JMG0rjSW/fDSxYcG/ofQuVopanZXjdWEHISfO41MB ipytB7RH42f+to28S59gQK0u2GV6UZJ2K96BLUwPb6j5IYiMNDHx7nWXA9JP07ITO0la +njYurZQkGlrrEep7d1fiqrsncUnU5tSsfrIrWmnZm6Tp5hwrbvw/nG4TZJl03gPesKW xDag== X-Gm-Message-State: AOAM533yz0pdAHmlmF/XJnDrgux849ozCm+3xzzapfFQ1bMyW94bm4HT krnHisU6mSTw24SjZUglEoBsqp6FKjw+ X-Google-Smtp-Source: ABdhPJxRLZzV90fv+eOS9sQCQta4PC7QWfahHEWOZkvZSOVQpALydjuegoahhKh4WJqZv3fZ2bva2yaJud8+ X-Received: from kyletso.ntc.corp.google.com ([2401:fa00:fc:202:6892:a74:4970:a062]) (user=kyletso job=sendgmr) by 2002:aa7:8246:0:b029:39a:1e0a:cd48 with SMTP id e6-20020aa782460000b029039a1e0acd48mr1408472pfn.14.1627625920974; Thu, 29 Jul 2021 23:18:40 -0700 (PDT) Date: Fri, 30 Jul 2021 14:18:31 +0800 In-Reply-To: <20210730061832.1927936-1-kyletso@google.com> Message-Id: <20210730061832.1927936-2-kyletso@google.com> Mime-Version: 1.0 References: <20210730061832.1927936-1-kyletso@google.com> X-Mailer: git-send-email 2.32.0.554.ge1b32706d8-goog Subject: [PATCH v4 1/2] dt-bindings: connector: Add pd-supported property From: Kyle Tso To: linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, robh+dt@kernel.org Cc: badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kyle Tso Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Set "pd-unsupported" property if the Type-C connector has no power delivery support. Signed-off-by: Kyle Tso --- .../devicetree/bindings/connector/usb-connector.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml index 92b49bc37939..21ec470117a6 100644 --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml @@ -111,6 +111,10 @@ properties: - 1.5A - 3.0A + pd-unsupported: + description: Set this property if the Type-C connector has no power delivery support. + type: boolean + # The following are optional properties for "usb-c-connector" with power # delivery support. source-pdos: From patchwork Fri Jul 30 06:18:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Tso X-Patchwork-Id: 12410437 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC6FC4320E for ; Fri, 30 Jul 2021 06:18:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BB4961057 for ; Fri, 30 Jul 2021 06:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237472AbhG3GSv (ORCPT ); Fri, 30 Jul 2021 02:18:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237424AbhG3GSt (ORCPT ); Fri, 30 Jul 2021 02:18:49 -0400 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62E66C061765 for ; Thu, 29 Jul 2021 23:18:45 -0700 (PDT) Received: by mail-pj1-x104a.google.com with SMTP id v2-20020a17090ac902b0290176b4310aaeso12869108pjt.2 for ; Thu, 29 Jul 2021 23:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=vN+OEO181SClZgiUn0HIzb45EPj9Fg0vWWzg9TNlgDI=; b=qvBe3LMbilAGu75LGbifhe0RQCMPjBuHCLQOuHlfcaTWR8c1hJephPrGUIAz4PfRAx RJeyNix8uY9ScWu1FSpQ0tPyglaP0Px6cADd/Y1Gzb4HOxVqe+sV7XSpV/GR4SKddqqF Ww4NkW0Qiv8qFHev5gBOaK3lXMYunzuKJ48ckmYSySqsiHwoEHNZzjDUUK+nMJKSqNgS mMcMaRn39iOnBKusiggRVFpaCDNhaDJHUEGoyzrh9CLsbDLXMuqTRJoxl6XUKysbuUlu Bu0c/PKZCdLDYkXlPuzyKH2IzySoFP1g98JFNOjuCcqnImQHwDwGLr04/teMr8eE12Dw 0WjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=vN+OEO181SClZgiUn0HIzb45EPj9Fg0vWWzg9TNlgDI=; b=hYEzYZYkolpfz02p77FRdXBriLY61ozFSRbeIAplY0H5CWaA4ZdQUWQ29b8osqnYmE Doh0s+LV5NGCCEPgOc8d0KaZ2DpDi6M6Vn+2b1weg32mPEA35JSPt/ErHzDGBN+BHgdE sCMs/Wn0zxTNZpZ5Fr/dGCpxx3wzz6uRUh53y2WWpHvzroj3bkvIkj7xYDkuXlCZ6odB UrTcmMkomCVZPEJc8wvx6TBXrND+IrPqd34HvJHt/5UsgGw9+dqSOZQWJLV8wc9Vz9D5 fe1HfcMAQXreDlXz7rqNDiw0z2bRxzaZs7ihxptdbPAhAPLCssLAs8b/01ZdZcEmoBAT cEIg== X-Gm-Message-State: AOAM532RDnWiF2bAlhhaB8jsk4ru/sb22lMtJZueeHBPxRQuabo3MeFD kWY39i/1MTNfXZEq3wTc88o4yUlXf3z7 X-Google-Smtp-Source: ABdhPJzn4tbE6VWNrUJoSdKQS5KtE8C5E2vDRVft+G1Qu8oRRaKUaTYOfzNus61tpbAAGwWRaa72uzx07ARG X-Received: from kyletso.ntc.corp.google.com ([2401:fa00:fc:202:6892:a74:4970:a062]) (user=kyletso job=sendgmr) by 2002:a17:903:30c3:b029:12c:1bf3:68d7 with SMTP id s3-20020a17090330c3b029012c1bf368d7mr1066471plc.73.1627625924877; Thu, 29 Jul 2021 23:18:44 -0700 (PDT) Date: Fri, 30 Jul 2021 14:18:32 +0800 In-Reply-To: <20210730061832.1927936-1-kyletso@google.com> Message-Id: <20210730061832.1927936-3-kyletso@google.com> Mime-Version: 1.0 References: <20210730061832.1927936-1-kyletso@google.com> X-Mailer: git-send-email 2.32.0.554.ge1b32706d8-goog Subject: [PATCH v4 2/2] usb: typec: tcpm: Support non-PD mode From: Kyle Tso To: linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, robh+dt@kernel.org Cc: badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kyle Tso Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Even if the Type-C controller supports PD, it is doable to disable PD capabilities with the current state machine in TCPM. Without enabling RX in low-level drivers and with skipping the power negotiation, the port is eligible to be a non-PD Type-C port. Use new flags whose values are populated from the device tree to decide the port PD capability. Adding "pd-unsupported" property in device tree indicates that the port does not support PD. If PD is not supported, the device tree property "typec-power-opmode" shall be added to specify the advertised Rp value if the port supports SRC role. Signed-off-by: Kyle Tso Reviewed-by: Guenter Roeck --- changes since v3: - commit msg updated - removed unnecessary empty lines - re-factored the code of reading device tree properties and the error handling - removed unnecessay variable initialization - modified the comments drivers/usb/typec/tcpm/tcpm.c | 87 +++++++++++++++++++++++++++-------- 1 file changed, 68 insertions(+), 19 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 5b22a1c931a9..faea1bf9dce0 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -316,6 +316,7 @@ struct tcpm_port { struct typec_partner *partner; enum typec_cc_status cc_req; + enum typec_cc_status src_rp; /* work only if pd_supported == false */ enum typec_cc_status cc1; enum typec_cc_status cc2; @@ -323,6 +324,7 @@ struct tcpm_port { bool attached; bool connected; + bool pd_supported; enum typec_port_type port_type; /* @@ -815,6 +817,9 @@ static enum typec_cc_status tcpm_rp_cc(struct tcpm_port *port) int nr_pdo = port->nr_src_pdo; int i; + if (!port->pd_supported) + return port->src_rp; + /* * Search for first entry with matching voltage. * It should report the maximum supported current. @@ -3568,9 +3573,11 @@ static int tcpm_src_attach(struct tcpm_port *port) if (ret < 0) return ret; - ret = port->tcpc->set_pd_rx(port->tcpc, true); - if (ret < 0) - goto out_disable_mux; + if (port->pd_supported) { + ret = port->tcpc->set_pd_rx(port->tcpc, true); + if (ret < 0) + goto out_disable_mux; + } /* * USB Type-C specification, version 1.2, @@ -3600,7 +3607,8 @@ static int tcpm_src_attach(struct tcpm_port *port) out_disable_vconn: tcpm_set_vconn(port, false); out_disable_pd: - port->tcpc->set_pd_rx(port->tcpc, false); + if (port->pd_supported) + port->tcpc->set_pd_rx(port->tcpc, false); out_disable_mux: tcpm_mux_set(port, TYPEC_STATE_SAFE, USB_ROLE_NONE, TYPEC_ORIENTATION_NONE); @@ -3804,6 +3812,20 @@ static enum typec_pwr_opmode tcpm_get_pwr_opmode(enum typec_cc_status cc) } } +static enum typec_cc_status tcpm_pwr_opmode_to_rp(enum typec_pwr_opmode opmode) +{ + switch (opmode) { + case TYPEC_PWR_MODE_USB: + return TYPEC_CC_RP_DEF; + case TYPEC_PWR_MODE_1_5A: + return TYPEC_CC_RP_1_5; + case TYPEC_PWR_MODE_3_0A: + case TYPEC_PWR_MODE_PD: + default: + return TYPEC_CC_RP_3_0; + } +} + static void run_state_machine(struct tcpm_port *port) { int ret; @@ -3914,6 +3936,10 @@ static void run_state_machine(struct tcpm_port *port) if (port->ams == POWER_ROLE_SWAP || port->ams == FAST_ROLE_SWAP) tcpm_ams_finish(port); + if (!port->pd_supported) { + tcpm_set_state(port, SRC_READY, 0); + break; + } port->upcoming_state = SRC_SEND_CAPABILITIES; tcpm_ams_start(port, POWER_NEGOTIATION); break; @@ -4161,7 +4187,10 @@ static void run_state_machine(struct tcpm_port *port) current_lim = PD_P_SNK_STDBY_MW / 5; tcpm_set_current_limit(port, current_lim, 5000); tcpm_set_charge(port, true); - tcpm_set_state(port, SNK_WAIT_CAPABILITIES, 0); + if (!port->pd_supported) + tcpm_set_state(port, SNK_READY, 0); + else + tcpm_set_state(port, SNK_WAIT_CAPABILITIES, 0); break; } /* @@ -4389,7 +4418,8 @@ static void run_state_machine(struct tcpm_port *port) tcpm_set_vbus(port, true); if (port->ams == HARD_RESET) tcpm_ams_finish(port); - port->tcpc->set_pd_rx(port->tcpc, true); + if (port->pd_supported) + port->tcpc->set_pd_rx(port->tcpc, true); tcpm_set_attached_state(port, true); tcpm_set_state(port, SRC_UNATTACHED, PD_T_PS_SOURCE_ON); break; @@ -5898,6 +5928,7 @@ EXPORT_SYMBOL_GPL(tcpm_tcpc_reset); static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle *fwnode) { + const char *opmode_str; const char *cap_str; int ret; u32 mw, frs_current; @@ -5932,22 +5963,37 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, return ret; port->typec_caps.type = ret; port->port_type = port->typec_caps.type; + port->pd_supported = !fwnode_property_read_bool(fwnode, "pd-unsupported"); port->slow_charger_loop = fwnode_property_read_bool(fwnode, "slow-charger-loop"); if (port->port_type == TYPEC_PORT_SNK) goto sink; - /* Get source pdos */ - ret = fwnode_property_count_u32(fwnode, "source-pdos"); - if (ret <= 0) - return -EINVAL; + /* Get Source PDOs for the PD port or Source Rp value for the non-PD port */ + if (port->pd_supported) { + ret = fwnode_property_count_u32(fwnode, "source-pdos"); + if (ret == 0) + return -EINVAL; + else if (ret < 0) + return ret; - port->nr_src_pdo = min(ret, PDO_MAX_OBJECTS); - ret = fwnode_property_read_u32_array(fwnode, "source-pdos", - port->src_pdo, port->nr_src_pdo); - if ((ret < 0) || tcpm_validate_caps(port, port->src_pdo, - port->nr_src_pdo)) - return -EINVAL; + port->nr_src_pdo = min(ret, PDO_MAX_OBJECTS); + ret = fwnode_property_read_u32_array(fwnode, "source-pdos", + port->src_pdo, port->nr_src_pdo); + if (ret) + return ret; + ret = tcpm_validate_caps(port, port->src_pdo, port->nr_src_pdo); + if (ret) + return ret; + } else { + ret = fwnode_property_read_string(fwnode, "typec-power-opmode", &opmode_str); + if (ret) + return ret; + ret = typec_find_pwr_opmode(opmode_str); + if (ret < 0) + return ret; + port->src_rp = tcpm_pwr_opmode_to_rp(ret); + } if (port->port_type == TYPEC_PORT_SRC) return 0; @@ -5961,6 +6007,11 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, if (port->typec_caps.prefer_role < 0) return -EINVAL; sink: + port->self_powered = fwnode_property_read_bool(fwnode, "self-powered"); + + if (!port->pd_supported) + return 0; + /* Get sink pdos */ ret = fwnode_property_count_u32(fwnode, "sink-pdos"); if (ret <= 0) @@ -5977,9 +6028,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, return -EINVAL; port->operating_snk_mw = mw / 1000; - port->self_powered = fwnode_property_read_bool(fwnode, "self-powered"); - - /* FRS can only be supported byb DRP ports */ + /* FRS can only be supported by DRP ports */ if (port->port_type == TYPEC_PORT_DRP) { ret = fwnode_property_read_u32(fwnode, "new-source-frs-typec-current", &frs_current);