From patchwork Mon Aug 2 17:42:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ojaswin Mujoo X-Patchwork-Id: 12414483 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCCDC4338F for ; Mon, 2 Aug 2021 17:44:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E458860FC0 for ; Mon, 2 Aug 2021 17:44:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E458860FC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z6fSZ+DRdRyqC5J/VQLbUIR83MeMb5w5xawrcDl8eVo=; b=caP2ZbO7zsVXHv 7dWKzNDaN5GR/NMoo2W3uCAjHlv3eRWTPhGfGr44E56kWy+shJUBeIa5zyLFqdK7Do5AZxhNqsgEM x+00ZQpoI3IJFZ9vZv5XBD2LObDBU40uRqz3spT3UKM0FhIj+I112H78T0F5lh87bpMJJ9+VB7wub DcNznnJvItTE/XQQVI+jDbGdNKZa/vLP0Yz4NVkGSRu0WM/LzgpZL/7XmE7g3QzVReDXPdR5gjewX Ibt0s5NnVrrS15nmQ5nlk+F2A7Az/Rb1UYljC5z3kmUAfTT1OQU9eqDoh0x0G9rLuDd+P+M13DQeF TDeBD4r8NG2az3lCfYsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAbxW-00HMuC-Qh; Mon, 02 Aug 2021 17:42:38 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAbxL-00HMrv-Qc for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 17:42:29 +0000 Received: by mail-pl1-x632.google.com with SMTP id c16so20479515plh.7 for ; Mon, 02 Aug 2021 10:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i80N/1f6I9wdo5J4KuddrAU0X8MTRP2GIMmztLtoIXU=; b=dGRKSl5y/DAV6pEvoYVK6BG58CjupMxOQQIPOWYGfyHlYASZDB/q3o/kekVW2nc9Qs 9Q1geTJnsUiJcnSpdR6Kh5W4t2ooclWjzzmmJdL+Mlny6kcI/26xxP6ETd/MKXbFCrbz kCGIc6azYoMKmlqVPqepJ7LyLwJUMiQ4QdL21YGKs0C+baAdLk9yV6hHisS+UaVBJgTy jRhawnWQ4QPQCfr1odXFelfzdMU9r77iYlfE2GhNjPuQuYJPc86XKQG8ycoS/FCFrRcB SakrFlaWQvQ2jvwF/zgKQfabUEForM4wxSZZwblfyD6LDmHQLl+062TEDaHelSbO8/WY INBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i80N/1f6I9wdo5J4KuddrAU0X8MTRP2GIMmztLtoIXU=; b=JwAEXqnwx3w5iOeCx1caNSqG82bEv8ASMeDDpdYbijW+NRctWPGKz47CcFhIc9BlXI pHjk2ipBU5iHvhuyRU4oKsgPLR/38irv/oSYtYFgm0+dCJkiu2MoPHisPQnsqGuJeue2 +5ILKZpUOlXfvRSYp/5NPWA1tqPybywP7C38ebrzt+u3sWMEy2FBgHzMT6GJ0Sr7q1+d GfM874UFQvCOrXyoFEc5EFKdkzA+jtf9oWVI2bOPBOHeD/KmhTqgC2gr5kuNZ97futXO vPPOccwS6XnNVhl70o+B9jTochUf9m+QBVpA/h1HUgeNb+E4j3pvWC1KXbuCWlr9fxb5 LnFw== X-Gm-Message-State: AOAM530b91nRWfpGf9fJ4AjpzwTaJkr/6NHDkGVmKhUrtH2Y/WLQ+oLa ChLv8I7MhLRFvYbTA+r2Phs= X-Google-Smtp-Source: ABdhPJyNmS/nD79RXC2wA494+zIcRoWi3FD/Y1aWTiFT7lJSDXNXoNm96xqRMGkGxWKjxyMTmMwwQQ== X-Received: by 2002:a65:6a0d:: with SMTP id m13mr1664908pgu.356.1627926146900; Mon, 02 Aug 2021 10:42:26 -0700 (PDT) Received: from localhost.localdomain ([122.161.50.148]) by smtp.googlemail.com with ESMTPSA id t30sm14449236pgl.47.2021.08.02.10.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 10:42:26 -0700 (PDT) From: Ojaswin Mujoo To: nsaenz@kernel.org, gregkh@linuxfoundation.org, stefan.wahren@i2se.com Cc: dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] staging: vchiq: Set $CONFIG_BCM2835_VCHIQ to imply $CONFIG_VCHIQ_CDEV Date: Mon, 2 Aug 2021 23:12:10 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_104227_907090_6CE88350 X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Before $CONFIG_VCHIQ_CDEV was defined, the vchiq cdev used to be created unconditionally when CONFIG_BCM2835_VCHIQ=y. When an earlier commit introduced the new config, its default behavior was set to disabled, which might surprise some unsuspecting users. Hence, modify CONFIG_BCM2835_VCHIQ to imply CONFIG_VCHIQ_CDEV Signed-off-by: Ojaswin Mujoo --- drivers/staging/vc04_services/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig index 63caa6818d37..ad44b80f13ca 100644 --- a/drivers/staging/vc04_services/Kconfig +++ b/drivers/staging/vc04_services/Kconfig @@ -13,6 +13,7 @@ if BCM_VIDEOCORE config BCM2835_VCHIQ tristate "BCM2835 VCHIQ" + imply VCHIQ_CDEV help Kernel to VideoCore communication interface for the BCM2835 family of products. From patchwork Mon Aug 2 17:42:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ojaswin Mujoo X-Patchwork-Id: 12414487 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E71C4338F for ; Mon, 2 Aug 2021 17:44:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC32C60FC0 for ; Mon, 2 Aug 2021 17:44:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC32C60FC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TLQQb2wkYt5bsdW4al4iJO9YDXO1N72JoyzmVlfb5+U=; b=gFztQU8VWzisJP 316zbb3vlCAbUxl+jTRpteUxUWFCibXIH+QC3tbGuiYQrNtR2I8ZsNf5VDvFZwKfQhcLFvkTENjS8 qvCv+uVQ+NKcg9xS13LQMILZc+JP9H3qtlc57kw1/B6xmCRrq2KdOypGeTT4Ga1nIWJ0RPsL7wCsD 3ZOdznO9rgcsQFL0SIvwdiKlnP3X3QgYpCEbuIrOUkQOgcXKJcvTl6a6JACi6/z0rCH8QNTEiIqJn 9YxqEbbW3OVM34TfPrellJ8m1Y3CwHfL6CS5Ij+7pW8OzklRGJo6XDVh0XnuWcVskWH1QXbcBsAjU k2JxZbPoszUCbq8UDhGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAbxh-00HMuZ-1O; Mon, 02 Aug 2021 17:42:49 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAbxP-00HMsr-NN for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 17:42:33 +0000 Received: by mail-pl1-x62e.google.com with SMTP id k2so2949905plk.13 for ; Mon, 02 Aug 2021 10:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/MV1SqfZDqSjnKYz3E5OcXaLSAPtXM8imp3PF9KeJ6w=; b=JLNcDLdrJL4Msy1I++J0coVrrw04XRKQKYLkrVQqlvV7ynZR3/mzLHiZCIutzaJb/F +ga2yTsO+R0O01s3DtrT6d8eGglUWa7zoEblGB/j7Hpd7wnGwlaFeU5Q2ylrngArPeSP fw5NIqB4ld6FaVXXNsaHstiIGrWnRJoD+pkMJn7W84+HQmoT9+keyvMLx0y95J3ToNWO Z+gld0gS1P3k8Y5pD2vy13mp8Gsuyy4roBADyo+Kvmgx8si/PHgZ9/fZ2gvtJMhpJnjx 3NK1acO0PUswo45s3fMsvt4UVtocvYsRVR9ujZ6qhquvGeQpitN4wDJPEunYkHeM5NFt sIHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/MV1SqfZDqSjnKYz3E5OcXaLSAPtXM8imp3PF9KeJ6w=; b=Lv2HCri2sZxLFz131KWHjjUU8WAs3N400MwbrUbApPCalNNxh22lY7OkjMAf6ZU5A5 pFJ+XxkorIOi84ylqkdMv08JMfLkyd0JfifUy9GFnVlItrwTGsfAfMd91GX29I7yTo1H aWm0A0rShXJGO69Z8t6RDsIUrIJTVef+A8p1JDfPu3ouj9fdjajYHfDdJnvilQegE2rD F+Y/w6+q5f9VP8TVFKn9lawUnJglJY91TKJRZbZgz+ej71IoGKAG8EV/e/L6f361uZ64 nfNzxtWMhAg7I3pQt+KhKF9vqIZJMQ036Nlaw586m1/x2QVpvqFzdVl/QmhbIELJfA+5 Yoag== X-Gm-Message-State: AOAM531sfY7WrHQDEzXwRoRbYBY1f0dCO9LPGlurFcJFzKadbeU+8Eh2 4xB8c9fU9FK9DkarEpZEsENmNa86BmQ= X-Google-Smtp-Source: ABdhPJx7XEJBaMfGMfcOgPNafXYpdRUXlETAutPhyUdStQehHy49ljO14dC6oz1k7NaQYbovuLfBXw== X-Received: by 2002:a17:90b:1297:: with SMTP id fw23mr18066334pjb.115.1627926150679; Mon, 02 Aug 2021 10:42:30 -0700 (PDT) Received: from localhost.localdomain ([122.161.50.148]) by smtp.googlemail.com with ESMTPSA id t30sm14449236pgl.47.2021.08.02.10.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 10:42:30 -0700 (PDT) From: Ojaswin Mujoo To: nsaenz@kernel.org, gregkh@linuxfoundation.org, stefan.wahren@i2se.com Cc: dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] staging: vchiq: Add details to Kconfig help texts Date: Mon, 2 Aug 2021 23:12:11 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_104231_808153_7BF8D9A9 X-CRM114-Status: GOOD ( 17.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add some details to the Kconfig definitions of $CONFIG_VCHIQ_CDEV and $CONFIG_BCM2835_VCHIQ to help make the motive behind the configs a bit more clear. Signed-off-by: Ojaswin Mujoo --- drivers/staging/vc04_services/Kconfig | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig index ad44b80f13ca..cb7c82403dbf 100644 --- a/drivers/staging/vc04_services/Kconfig +++ b/drivers/staging/vc04_services/Kconfig @@ -15,18 +15,27 @@ config BCM2835_VCHIQ tristate "BCM2835 VCHIQ" imply VCHIQ_CDEV help - Kernel to VideoCore communication interface for the - BCM2835 family of products. - Defaults to Y when the Broadcom Videocore services - are included in the build, N otherwise. + Broadcom BCM2835 and similar SoCs have a VPU called VideoCore. This config + enables the VCHIQ driver, which implements a messaging interface between + the kernel and the firmware running on VideoCore. Other drivers use this + interface to communicate to the VPU. More specifically, the VCHIQ driver is + used by audio/video and camera drivers as well as for implementing MMAL + API, which is in turn used by several multimedia services on the BCM2835 + family of SoCs. + Defaults to Y when the Broadcom Videocore services are included in + the build, N otherwise. if BCM2835_VCHIQ config VCHIQ_CDEV bool "VCHIQ Character Driver" help - Enable the creation of VCHIQ character driver to help - communicate with the Videocore platform. + Enable the creation of VCHIQ character driver. The cdev exposes ioctls used + by userspace libraries and testing tools to interact with VideoCore, via + the VCHIQ core driver (Check BCM2835_VCHIQ for more info). + This can be set to 'N' if the VideoCore communication is not needed by + userspace but only by other kernel modules (like bcm2835-audio). If not + sure, set this to 'Y'. endif