From patchwork Mon Aug 9 20:35:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Shtylyov X-Patchwork-Id: 12427261 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1776C4338F for ; Mon, 9 Aug 2021 20:35:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 908A960F02 for ; Mon, 9 Aug 2021 20:35:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236294AbhHIUfi (ORCPT ); Mon, 9 Aug 2021 16:35:38 -0400 Received: from mxout04.lancloud.ru ([45.84.86.114]:34102 "EHLO mxout04.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231509AbhHIUfi (ORCPT ); Mon, 9 Aug 2021 16:35:38 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 1CDFE20CB558 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: [PATCH v2 4/9] usb: gadget: udc: s3c2410: add IRQ check From: Sergey Shtylyov To: , Greg Kroah-Hartman , Felipe Balbi References: <47bacc02-4e34-3208-779c-7072a6261782@omp.ru> Organization: Open Mobile Platform CC: Krzysztof Kozlowski , , Message-ID: Date: Mon, 9 Aug 2021 23:35:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <47bacc02-4e34-3208-779c-7072a6261782@omp.ru> Content-Language: en-US X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The driver neglects to check the result of platform_get_irq()'s call and blithely passes the negative error codes to request_irq() (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original error code. Stop calling request_irq() with the invalid IRQ #s. Fixes: 188db4435ac6 ("usb: gadget: s3c: use platform resources") Signed-off-by: Sergey Shtylyov Reviewed-by: Krzysztof Kozlowski Acked-by: Felipe Balbi --- drivers/usb/gadget/udc/s3c2410_udc.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) Index: usb/drivers/usb/gadget/udc/s3c2410_udc.c =================================================================== --- usb.orig/drivers/usb/gadget/udc/s3c2410_udc.c +++ usb/drivers/usb/gadget/udc/s3c2410_udc.c @@ -1784,6 +1784,10 @@ static int s3c2410_udc_probe(struct plat s3c2410_udc_reinit(udc); irq_usbd = platform_get_irq(pdev, 0); + if (irq_usbd < 0) { + retval = irq_usbd; + goto err_udc_clk; + } /* irq setup after old hardware state is cleaned up */ retval = request_irq(irq_usbd, s3c2410_udc_irq,