From patchwork Wed Aug 11 20:27:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Hutchings X-Patchwork-Id: 12431893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DA5C4320A for ; Wed, 11 Aug 2021 20:27:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F09F60FC3 for ; Wed, 11 Aug 2021 20:27:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231481AbhHKU2U (ORCPT ); Wed, 11 Aug 2021 16:28:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbhHKU2U (ORCPT ); Wed, 11 Aug 2021 16:28:20 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03EBBC0613D3 for ; Wed, 11 Aug 2021 13:27:56 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id gs8so6692493ejc.13 for ; Wed, 11 Aug 2021 13:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mind.be; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=/fBXwRi3zHoXySC63co3Zg3PXm2L8vBGwxoAcufUXkE=; b=avVBCPDaLVUmDViSx3YbB7UlpUecmw+Dl9WLOuSsCFc3QzOCGYgUgykxq+RoRi/DKR gqM/V0uhDSZc4p781wOzqvPleRfs+SCh2cm8+S3Jy52lh23ZmYKZp8gPU5M7thqgI4/Q qcrPNbWgSK0DEGtyRfSboba8TsiKYluB7z7JDHpQIq34IclPX/CCn7Fbc9dxX2ni0wNO YKvpQxhQ3rOyNYGXqn9kaYax6gHNdMzbeF7Ixh5pB3m7Z5bFxGYEu94GzAhCVNmCnP1O DQQof8Gckr5sQQpheRhbuy/lFhXTNO4gWsdFDDNq7lTET0h1eg8ET0ug7t56RwlHZlUg A25Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=/fBXwRi3zHoXySC63co3Zg3PXm2L8vBGwxoAcufUXkE=; b=J8z7Ec83az6d35C4aRZr6TF6YNxN0D9cQe8g6nIsuqHMJlmxeN+BdBEix6ISzIZjvg nofm/cNjff/hHjx13OgjU8ApNmTlBd3mtC0JzC+xKbuw2HaQ3qQBRaRS4VpUIDXqiZMh FdlzQDRv/PbdcuZuV9QqyiZlEFOp6MWLfhw8hI0JxWWsgprP/V8/5qxXE+v5C1bgS53/ 6Fjvl0cYNd311mKJSajW70RObjpZ4AXOJtI4BPFJcZWmyvY0qCfrEuI+VtMy9tt8IWPu D2B3pCGfauIyWoAAoiDR2wUmRRvpexs8DaCFSttCt15DPLuX71mbwy3QeVemtXTIIhkT P20g== X-Gm-Message-State: AOAM531FHsEG66FdXLxgIFxksdGxCvtuYhutdzYQm2YH8DroCHgfftju gq6aViIgPbJ7Om7kOD1r0FV2Dg== X-Google-Smtp-Source: ABdhPJza6hhstiptmW8MZiHRPpoG6hxDjeyvEurzf5TaW7W6YwdRbkysNloYH4rSzqWFA9FpnqxTUQ== X-Received: by 2002:a17:906:1f82:: with SMTP id t2mr277207ejr.499.1628713674568; Wed, 11 Aug 2021 13:27:54 -0700 (PDT) Received: from cephalopod (168.7-181-91.adsl-dyn.isp.belgacom.be. [91.181.7.168]) by smtp.gmail.com with ESMTPSA id q9sm142191ejf.70.2021.08.11.13.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Aug 2021 13:27:54 -0700 (PDT) Date: Wed, 11 Aug 2021 22:27:52 +0200 From: Ben Hutchings To: Grygorii Strashko , Santosh Shilimkar , Kevin Hilman Cc: linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org Subject: [PATCH] gpio: omap: Enable software fallback for long debounce periods Message-ID: <20210811202751.GB18930@cephalopod> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org omap2_set_gpio_debounce() currently returns -EINVAL if the debounce period is too long to be handled in hardware. gpiolib provides a software fallback, but it is used only if the driver returns -ENOTSUPP. * Enable the software fallback by using the expected error code * Downgrade the log message about this from info to debug, since the error is now handled Signed-off-by: Ben Hutchings Reviewed-by: Tony Lindgren --- drivers/gpio/gpio-omap.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index ca23f72165ca..93812480dd0a 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -190,7 +190,7 @@ static int omap2_set_gpio_debounce(struct gpio_bank *bank, unsigned offset, if (enable) { debounce = DIV_ROUND_UP(debounce, 31) - 1; if ((debounce & OMAP4_GPIO_DEBOUNCINGTIME_MASK) != debounce) - return -EINVAL; + return -ENOTSUPP; } l = BIT(offset); @@ -887,9 +887,9 @@ static int omap_gpio_debounce(struct gpio_chip *chip, unsigned offset, raw_spin_unlock_irqrestore(&bank->lock, flags); if (ret) - dev_info(chip->parent, - "Could not set line %u debounce to %u microseconds (%d)", - offset, debounce, ret); + dev_dbg(chip->parent, + "Could not set line %u debounce to %u microseconds (%d)", + offset, debounce, ret); return ret; }