From patchwork Sat Aug 14 14:27:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tang Bin X-Patchwork-Id: 12436733 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B71FC4338F for ; Sat, 14 Aug 2021 14:29:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42A1C60EE2 for ; Sat, 14 Aug 2021 14:29:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 42A1C60EE2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cmss.chinamobile.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=uaH1vvqau5mUiTLxsJ8oaE0Asd87pthqnQQQyzYNZiA=; b=eLx2Pc008mHvdE 95q88Z6I8K5UxpkN8ly/zuG8ibM7pjjE4teV60RXGdUDN01LZAoEUfwfnCiCtVOzNAJLloqFCkCWi y1qxsKno4YeBMd8PCDasTHaMjspqe7z4NQgHIMQut/RV2XFggaurj5dd5W8MMSrN0acIrujB5JmqF yFRc4LR0g03bDN/MhwbJUxMHcjDmCk71z+uMGJhLw03kSZTCCTP0pQ8OevaT7wJ3F4o7R1S8GwXJX S1cigU7rvaqfjleYb2MPUcJmbWpqGnOJW+C6lemDAqtSUsW6eudOojJSjPKK7KVGXbw7izZuAaZZK raxnp9gohtsijb2k4Uog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEudI-00EHUH-WB; Sat, 14 Aug 2021 14:27:33 +0000 Received: from cmccmta3.chinamobile.com ([221.176.66.81]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEudD-00EHTH-7b for linux-arm-kernel@lists.infradead.org; Sat, 14 Aug 2021 14:27:29 +0000 Received: from spf.mail.chinamobile.com (unknown[172.16.121.11]) by rmmx-syy-dmz-app10-12010 (RichMail) with SMTP id 2eea6117d2b5ed0-8d01a; Sat, 14 Aug 2021 22:27:02 +0800 (CST) X-RM-TRANSID: 2eea6117d2b5ed0-8d01a X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.22.250.151]) by rmsmtp-syy-appsvr06-12006 (RichMail) with SMTP id 2ee66117d2b0886-2b22d; Sat, 14 Aug 2021 22:27:02 +0800 (CST) X-RM-TRANSID: 2ee66117d2b0886-2b22d From: Tang Bin To: wim@linux-watchdog.org, linux@roeck-us.net, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com Cc: linux-watchdog@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tang Bin , Zhang Shengju Subject: [PATCH] watchdog: stm32_iwdg: drop superfluous error message Date: Sat, 14 Aug 2021 22:27:41 +0800 Message-Id: <20210814142741.7396-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210814_072727_784103_26CC4A5A X-CRM114-Status: UNSURE ( 8.13 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the function stm32_iwdg_probe(), devm_platform_ioremap_resource has already contained error message, so drop the redundant one. Co-developed-by: Zhang Shengju Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin Reviewed-by: Guenter Roeck --- drivers/watchdog/stm32_iwdg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c index a3436c296..570a71509 100644 --- a/drivers/watchdog/stm32_iwdg.c +++ b/drivers/watchdog/stm32_iwdg.c @@ -237,10 +237,8 @@ static int stm32_iwdg_probe(struct platform_device *pdev) /* This is the timer base. */ wdt->regs = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(wdt->regs)) { - dev_err(dev, "Could not get resource\n"); + if (IS_ERR(wdt->regs)) return PTR_ERR(wdt->regs); - } ret = stm32_iwdg_clk_init(pdev, wdt); if (ret)