From patchwork Tue Aug 17 00:56:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Chancellor X-Patchwork-Id: 12439575 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5BC5C4338F for ; Tue, 17 Aug 2021 00:56:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0DEA60E76 for ; Tue, 17 Aug 2021 00:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233057AbhHQA52 (ORCPT ); Mon, 16 Aug 2021 20:57:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:47794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237878AbhHQA5G (ORCPT ); Mon, 16 Aug 2021 20:57:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 49CAE60295; Tue, 17 Aug 2021 00:56:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629161794; bh=PZEqmmXTePsChi5KMOXAzQ2pjVA+gkv4uVHb6dEQmR4=; h=From:To:Cc:Subject:Date:From; b=oE8+h4N0apb1QwiiGwm6Ly2Vv4mTTTmNTb9Eg7nZt/wuny1dStOLqNj9o/DfhIMSG r1V3NRRqLaEe9Py9180huQAnMYuE1mQerpwVJB/yYracCprXmkCZaJJ7zbZuIlelct xgKYEa6nRE44ARKljlPQ8hI1EPFKtfZAWwhoGAkfEWc/Jj1B7oqlzWzBAdvrknVDap 1Z/obUo1f1G682Si77/25mzgLz69ympSRSZm1wdZBTzjkVEZQf1zTmD8XieE2TXzej PNGPqPSZr/EfwZy3FocHn21Mv32DPUMafflLkehIfbdYtxRi+ab7CTadXQK2CQvmzU S6TptVWTfZqgg== From: Nathan Chancellor To: "Gustavo A. R. Silva" , Linus Torvalds Cc: Kees Cook , Nick Desaulniers , Masahiro Yamada , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor Subject: [PATCH] kbuild: Enable -Wimplicit-fallthrough for clang 14.0.0+ Date: Mon, 16 Aug 2021 17:56:24 -0700 Message-Id: <20210817005624.1455428-1-nathan@kernel.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Patchwork-Bot: notify Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Clang prior to 14.0.0 warns when a fallthrough annotation is in an unreachable spot, which can occur when IS_ENABLED(CONFIG_...) in a conditional statement prior to the fallthrough annotation such as if (IS_ENABLED(CONFIG_...)) break; fallthrough; which to clang looks like break; fallthrough; if CONFIG_... is enabled due to the control flow graph. Example of the warning in practice: sound/core/pcm_native.c:3812:3: warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough] fallthrough; ^ Warning on unreachable annotations makes the warning too noisy and pointless for the kernel due to the nature of guarding some code on configuration options so it was disabled in commit d936eb238744 ("Revert "Makefile: Enable -Wimplicit-fallthrough for Clang""). This has been resolved in clang 14.0.0 by moving the unreachable warning to its own flag under -Wunreachable-code, which the kernel will most likely never enable due to situations like this. Enable -Wimplicit-fallthrough for clang 14+ so that issues such as the one in commit 652b44453ea9 ("habanalabs/gaudi: fix missing code in ECC handling") can be caught before they enter the tree. Link: https://github.com/ClangBuiltLinux/linux/issues/236 Link: https://github.com/llvm/llvm-project/commit/9ed4a94d6451046a51ef393cd62f00710820a7e8 Signed-off-by: Nathan Chancellor Reported-by: kernel test robot Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor --- Makefile | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) base-commit: a2824f19e6065a0d3735acd9fe7155b104e7edf5 diff --git a/Makefile b/Makefile index c19d1638da25..91a4a80409e1 100644 --- a/Makefile +++ b/Makefile @@ -797,11 +797,17 @@ KBUILD_CFLAGS += -Wno-gnu # source of a reference will be _MergedGlobals and not on of the whitelisted names. # See modpost pattern 2 KBUILD_CFLAGS += -mno-global-merge + +# Warn about unmarked fall-throughs in switch statement. +# Clang prior to 14.0.0 warned on unreachable fallthroughs with +# -Wimplicit-fallthrough, which is unacceptable due to IS_ENABLED(). +# https://bugs.llvm.org/show_bug.cgi?id=51094 +ifeq ($(shell test $(CONFIG_CLANG_VERSION) -ge 140000; echo $$?),0) +KBUILD_CFLAGS += -Wimplicit-fallthrough +endif else # Warn about unmarked fall-throughs in switch statement. -# Disabled for clang while comment to attribute conversion happens and -# https://github.com/ClangBuiltLinux/linux/issues/636 is discussed. KBUILD_CFLAGS += $(call cc-option,-Wimplicit-fallthrough=5,) endif