From patchwork Mon Aug 23 19:45:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 12453491 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EA43C4338F for ; Mon, 23 Aug 2021 19:45:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E4C5F613D5 for ; Mon, 23 Aug 2021 19:45:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E4C5F613D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5FAE78D0002; Mon, 23 Aug 2021 15:45:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 582568D0001; Mon, 23 Aug 2021 15:45:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4238C8D0002; Mon, 23 Aug 2021 15:45:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 238A98D0001 for ; Mon, 23 Aug 2021 15:45:15 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BAE7B18EC2 for ; Mon, 23 Aug 2021 19:45:14 +0000 (UTC) X-FDA: 78507374148.39.3CB9267 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf14.hostedemail.com (Postfix) with ESMTP id 47F2E6001982 for ; Mon, 23 Aug 2021 19:45:08 +0000 (UTC) Received: from zn.tnic (p200300ec2f07d9004625a010a35f3837.dip0.t-ipconnect.de [IPv6:2003:ec:2f07:d900:4625:a010:a35f:3837]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 40FB61EC0464; Mon, 23 Aug 2021 21:45:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1629747902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=7KwRhm2sTocXwEJarLiY5c63owI3J860DzvYo8UM4I8=; b=ZMOl0Uklc7bTZqwVps5ltCyOrz0+FYqz+dpP/aACFQ5Dos6WO4MgcEOy3r0FBiZjU+kJ+5 N0XA+EgVhoccBaK31KeyV4yvoOZ6kurVQy4BmaOX4gvBTG52GczLHUiF4GOTbuMVEr85yf 6fDl9R5iUfEDGLSzg2RsxzO59rtBet8= Date: Mon, 23 Aug 2021 21:45:44 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: [PATCH] x86/sev: Remove do_early_exception() forward declarations Message-ID: References: <20210820151933.22401-1-brijesh.singh@amd.com> <20210820151933.22401-14-brijesh.singh@amd.com> <815a054a-b0a2-e549-8d1c-086540521979@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <815a054a-b0a2-e549-8d1c-086540521979@amd.com> Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=ZMOl0Ukl; dmarc=temperror reason="query timed out" header.from=alien8.de (policy=temperror); spf=pass (imf14.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 47F2E6001982 X-Stat-Signature: ajxqyymtoqx8pzfgo3e7yhpjt631ig9f X-HE-Tag: 1629747908-160893 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 23, 2021 at 01:56:06PM -0500, Brijesh Singh wrote: > thanks, I will merge this in next version. Thx. One more thing I stumbled upon while staring at this, see below. Can you add it to your set or should I simply apply it now? Thx. --- From: Borislav Petkov Date: Mon, 23 Aug 2021 20:01:35 +0200 Subject: [PATCH] x86/sev: Remove do_early_exception() forward declarations There's a perfectly fine prototype in the asm/setup.h header. Use it. No functional changes. Signed-off-by: Borislav Petkov --- arch/x86/kernel/sev.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c index a6895e440bc3..700ef31d32f8 100644 --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -96,9 +97,6 @@ struct ghcb_state { static DEFINE_PER_CPU(struct sev_es_runtime_data*, runtime_data); DEFINE_STATIC_KEY_FALSE(sev_es_enable_key); -/* Needed in vc_early_forward_exception */ -void do_early_exception(struct pt_regs *regs, int trapnr); - static void __init setup_vc_stacks(int cpu) { struct sev_es_runtime_data *data; @@ -240,9 +238,6 @@ static noinstr struct ghcb *__sev_get_ghcb(struct ghcb_state *state) return ghcb; } -/* Needed in vc_early_forward_exception */ -void do_early_exception(struct pt_regs *regs, int trapnr); - static inline u64 sev_es_rd_ghcb_msr(void) { return __rdmsr(MSR_AMD64_SEV_ES_GHCB);