From patchwork Thu Aug 26 18:28:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 12460459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D934BC432BE for ; Thu, 26 Aug 2021 18:28:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B39FE60FDA for ; Thu, 26 Aug 2021 18:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241980AbhHZS3A (ORCPT ); Thu, 26 Aug 2021 14:29:00 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:43068 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235411AbhHZS27 (ORCPT ); Thu, 26 Aug 2021 14:28:59 -0400 Received: from pop-os.home ([90.126.253.178]) by mwinf5d32 with ME id mJU92500D3riaq203JU9Qo; Thu, 26 Aug 2021 20:28:10 +0200 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Thu, 26 Aug 2021 20:28:10 +0200 X-ME-IP: 90.126.253.178 From: Christophe JAILLET To: jic23@kernel.org, lars@metafoo.de, ardeleanalex@gmail.com, andy.shevchenko@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH v2] iio: adc128s052: Simplify 'adc128_probe()' Date: Thu, 26 Aug 2021 20:28:08 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Turn 'adc128_probe()' into a full resource managed function to simplify the code. This way, the .remove function can be removed. Doing so, the only 'spi_get_drvdata()' call is removed and the corresponding 'spi_set_drvdata()' can be removed as well. Suggested-by: Alexandru Ardelean Signed-off-by: Christophe JAILLET Reviewed-by: Alexandru Ardelean --- Compile tested only. When reviewing, pay special attention to the 'spi_set_drvdata()' call removal. I recently introduced a regression with a too aggressive cleanup like that. This patch should be applied after https://lore.kernel.org/linux-iio/f33069f0-601b-4bbb-3766-026f7a161912-39ZsbGIQGT5GWvitb5QawA@public.gmane.org/T/#meb792dcd6540f87d9ae041660ca4738a776e924a v1 --> v2: Simplify 'adc128_disable_regulator()' --- drivers/iio/adc/ti-adc128s052.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c index e1afdb775100..3143f35a6509 100644 --- a/drivers/iio/adc/ti-adc128s052.c +++ b/drivers/iio/adc/ti-adc128s052.c @@ -132,13 +132,6 @@ static const struct iio_info adc128_info = { .read_raw = adc128_read_raw, }; -static void adc128_disable_regulator(void *data) -{ - struct regulator *reg = data; - - regulator_disable(reg); -} - static int adc128_probe(struct spi_device *spi) { struct iio_dev *indio_dev; @@ -158,6 +151,8 @@ static int adc128_probe(struct spi_device *spi) adc = iio_priv(indio_dev); adc->spi = spi; + spi_set_drvdata(spi, indio_dev); + indio_dev->name = spi_get_device_id(spi)->name; indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->info = &adc128_info; @@ -172,13 +167,23 @@ static int adc128_probe(struct spi_device *spi) ret = regulator_enable(adc->reg); if (ret < 0) return ret; - ret = devm_add_action_or_reset(&spi->dev, adc128_disable_regulator, adc->reg); - if (ret) - return ret; mutex_init(&adc->lock); - return devm_iio_device_register(&spi->dev, indio_dev); + ret = iio_device_register(indio_dev); + + return ret; +} + +static int adc128_remove(struct spi_device *spi) +{ + struct iio_dev *indio_dev = spi_get_drvdata(spi); + struct adc128 *adc = iio_priv(indio_dev); + + iio_device_unregister(indio_dev); + regulator_disable(adc->reg); + + return 0; } static const struct of_device_id adc128_of_match[] = { @@ -220,6 +225,7 @@ static struct spi_driver adc128_driver = { .acpi_match_table = ACPI_PTR(adc128_acpi_match), }, .probe = adc128_probe, + .remove = adc128_remove, .id_table = adc128_id, }; module_spi_driver(adc128_driver);