From patchwork Tue Sep 14 21:35:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12494907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB8F4C433EF for ; Tue, 14 Sep 2021 21:38:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8425A60E8B for ; Tue, 14 Sep 2021 21:38:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8425A60E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=mNnHEKRk5dnMwF8J9lPPVm3U5bBxGVrUggOXp+lvexI=; b=OaHiR9hi/yTXRj IMAPeR0XLGfwr8KUPqlTRISNSivyW4l6igI6MZ9dJYdU4fqKf9RV/ig6fbkxmojS0da7S0qU3Em12 j0tQPK0ElqeDHgm97sBYkrD6lDGwn4avPypYJLvY0aupGmDdtzdudSnu8NJbY/aVjgvLxNVGANpsV 1cpQ7o+s79AaZbSmDDU4lAWSjUVWlo8Lsyu3gP5HuMQWKj8m1N991gfzqIPTzaqC638h0tLqRb4zh gFLkAocTduSvS8OzhEEfDQF0CoKdFdf0f6pL6r44evsuBvGtPChefEwH04f8hFMcSP6EJMuVkOGfB es6gh9g3ndtBbXlKABNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG6E-00792C-RS; Tue, 14 Sep 2021 21:36:19 +0000 Received: from mail-qv1-xf2c.google.com ([2607:f8b0:4864:20::f2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG6A-00790q-Kt; Tue, 14 Sep 2021 21:36:15 +0000 Received: by mail-qv1-xf2c.google.com with SMTP id 62so605547qvb.11; Tue, 14 Sep 2021 14:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TM7n1dna53Y+KIAaPOy7ZFMjIdGf78aBP+tCGyC56Vg=; b=DAC1/pVsNhGIcvBmDc9SeGCceDyR50hfxd+iKWA/tz5Vo1SNNSZT0AAOBvDUjXQra3 eZvPTp9ko9mZyp64jH3sdV5Dht380B+OfR0YsRKUguudovbd7d/DIgkfrRBT+KkpQZJh 9TITi118J4Ah3TXRLEZmM0HYFPCL66PLUjAW2j+VWmooUta6tHTi6clOy4FLp8oHfRLO IiSbHzatBpg8dIv05lja0Ank4V56S6OSBNxEdAneqVRcC3O1yPzQ5HYhhAzyIW4EsGP7 idqPpGhEJmhugxPKOGzL85st/rmX3qXO/5AuDoCENlbRti0m628kg3uBUt+ukVqkxC5S mJhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TM7n1dna53Y+KIAaPOy7ZFMjIdGf78aBP+tCGyC56Vg=; b=vvkXHQ1Zr9KIJ4RP7kLZ5Hv5wxuUcvftL67WoOks/WXJCsQj7z7icfR3Uaja/3owp6 0Az4Lr2Ml8qUfFH9ReQs7K/BdD+hgOBV3kHmpAFTMqGY6NpkmyEQdii1XD3Z24gAlnhe oGy3n9SoAK382IKC+k9hU4Rc11JAH7o4ZI4ocG8uKNh1kZ2CsV9z6atCHtdygc/X8/Pw EkgxbsEKmuBuiBN0+eJFSHRVx7UbZlyI/zfOV0m3zFeSprrjnU1hXnqs3ppLopR101K5 nAUeMi5gVUGeQFX4CYDT8jrLfErancApz4lrgxPtVgejmPYPI4Vo+ArOLQXESI1XkD5z g1Dg== X-Gm-Message-State: AOAM531HgtLdI/nzGoeWRyqW5qxQEsju0In+pmn2/BR2cGj1rtZcJXwk DMFMli5N38mixK/+U0M9h/c= X-Google-Smtp-Source: ABdhPJz2Zop7j8KONtVZ0sRJ5q7df0Ka9HDAi4ufXlIgii5Kyy9dx1qoT8OkUBU9HJovOF8haJu1VQ== X-Received: by 2002:a05:6214:12eb:: with SMTP id w11mr7840443qvv.10.1631655372329; Tue, 14 Sep 2021 14:36:12 -0700 (PDT) Received: from localhost.localdomain ([191.84.239.65]) by smtp.gmail.com with ESMTPSA id o7sm6716611qtw.87.2021.09.14.14.36.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 14:36:12 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 1/8] staging: vchiq_arm: replace sleep() with usleep_range() Date: Tue, 14 Sep 2021 18:35:26 -0300 Message-Id: <20210914213532.396654-1-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_143614_725588_23C77657 X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org usleep_range() should be used instead of sleep() when sleepings range from 10 us to 20 ms, [1]. Reported by checkpatch.pl [1] Documentation/timers/timers-howto.txt --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index b25369a13452..0214ae37e01f 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -824,7 +824,7 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size, if (status != VCHIQ_RETRY) break; - msleep(1); + usleep_range(1000, 1100); } return status; @@ -861,7 +861,7 @@ enum vchiq_status vchiq_bulk_receive(unsigned int handle, void *data, if (status != VCHIQ_RETRY) break; - msleep(1); + usleep_range(1000, 1100); } return status; From patchwork Tue Sep 14 21:35:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12494919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0D91C433EF for ; Tue, 14 Sep 2021 21:39:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 869E160EE9 for ; Tue, 14 Sep 2021 21:39:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 869E160EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D25MDgoiLGFxI1ftsiPAPUF0IdnCh3KF73dWd/D+qhk=; b=Wblv5BJ1ynydTw t6rlF1BkQljNAWvZbrshqfxV+F7DBeLRzIMZRhoOrrHvjFjIZRN1byi6kWMfCX/A/RwhPfrks5z9m U5DKBXeyEDu9qT4YfME2Bf8VQTp42GWKmMzQ9lc2fciA+niiwiJSAbZOsD6samrMd/dIkzIlPVTL7 8OWmhzgTCWkg5dgX8P0hYvFI0oLYSulGBpoyVbpiHDEDWFslehMZ9PN08LC/2c0uwSTVaB2Zcim4g qj9JNetLoyCbq/yOXtZYqdFMPQ3XI1pWIifAmOGJ6+tBSz4h6pIzTjiZah3MBAlwZsRN0fup89Xlw eIn7ktn6eJEWL6fJwdnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG6U-00796w-1K; Tue, 14 Sep 2021 21:36:34 +0000 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG6M-00794L-7n; Tue, 14 Sep 2021 21:36:28 +0000 Received: by mail-qt1-x831.google.com with SMTP id w17so411418qta.9; Tue, 14 Sep 2021 14:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IyRke3zcaCvUrxkwEuxRyuw36uHPkdhBNLGhDbrwcms=; b=BFZ4e3QFZqkWq6SCkd3gTmnIQ/ClrJp2NiwNnrUUYIiAYKd/MkhiZ18dH1dbh44RwM smSV+nPJPHGxlNlCp07t8EIQVvJzMQjiCyZZ4Lis2qfpLhA54Qx2UFkXffL+1JhmP5ft kC80tYF3lKP6mc5j0swfdCuhOERen1owVrtvAcFB+z5QOpAh6iPkLR8OheCE1Fae83l2 e9zlk4Bf/HgxfB6gpVfu1I0XvEyv0cZ5ly1EZA4bsx1t+1p4Nh0XJBIsDWP6BayBd4g8 nudXrV7dcd4QC53lv5vbSIwG3JAkUKlrGznN/owDSkoFND+t+TuyMCvjhquTb+Nz9pVD AcDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IyRke3zcaCvUrxkwEuxRyuw36uHPkdhBNLGhDbrwcms=; b=ghdZDsfdAzCoL/LL88w40nVMV4dLUZm5eoUQ0x2aMpLvovVH0x4HlEaxCaF4/Ss9bd NibslXPapdUMhG4aM1jKSEttzkavfmENcuevWRCDHJhlG9MWQQtiq8n5/rHfixOyd6eB a9ThXQdUgvj9gPAf2JUjA/lfJobwS+hN3cZwIX6CwCc5ynVYAc41uUF5050OBXwIh0tQ Hrn/o4TeQu1RQJz+lHg+psz0xS/YwAN5KSP0Dvy3jW+QrBwuNxxtMw30gRpDfF6srGi7 dJpbEjfEM8PXth0KVUxvy80XAcYfbpQYcxgokUI7x+GKWu1RlE2IjoCI4hcgHDbiKv1I a/hA== X-Gm-Message-State: AOAM533xSrMqtBTkmLmB50v0mfC3Vuj09t4lyDaQuLekLR/fhhc7QaU5 Cv64A+WxdBATSKk5CIu+3wo= X-Google-Smtp-Source: ABdhPJxPx7cMkwVqwhbU0UVnyyPCcJ535hCicw7djpWIagSlGixEKN7MDzSpJhuFZoPqCNwkgqPIIw== X-Received: by 2002:ac8:4c89:: with SMTP id j9mr6876844qtv.78.1631655384685; Tue, 14 Sep 2021 14:36:24 -0700 (PDT) Received: from localhost.localdomain ([191.84.239.65]) by smtp.gmail.com with ESMTPSA id o7sm6716611qtw.87.2021.09.14.14.36.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 14:36:24 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 2/8] staging: vchiq_arm: cleanup code alignment issues Date: Tue, 14 Sep 2021 18:35:28 -0300 Message-Id: <20210914213532.396654-2-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210914213532.396654-1-gascoar@gmail.com> References: <20210914213532.396654-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_143626_392270_61C73516 X-CRM114-Status: GOOD ( 19.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix code alignment issues. Reported by checkpatch.pl --- .../interface/vchiq_arm/vchiq_arm.c | 208 +++++++----------- 1 file changed, 79 insertions(+), 129 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 0214ae37e01f..435f1bd68ba3 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -115,7 +115,7 @@ static DEFINE_SEMAPHORE(g_free_fragments_mutex); static enum vchiq_status vchiq_blocking_bulk_transfer(unsigned int handle, void *data, - unsigned int size, enum vchiq_bulk_dir dir); + unsigned int size, enum vchiq_bulk_dir dir); static irqreturn_t vchiq_doorbell_irq(int irq, void *dev_id) @@ -251,11 +251,8 @@ create_pagelist(char *buf, char __user *ubuf, } /* do not try and release vmalloc pages */ } else { - actual_pages = pin_user_pages_fast( - (unsigned long)ubuf & PAGE_MASK, - num_pages, - type == PAGELIST_READ, - pages); + actual_pages = pin_user_pages_fast((unsigned long)ubuf & PAGE_MASK, num_pages, + type == PAGELIST_READ, pages); if (actual_pages != num_pages) { vchiq_log_info(vchiq_arm_log_level, @@ -325,9 +322,9 @@ create_pagelist(char *buf, char __user *ubuf, /* Partial cache lines (fragments) require special measures */ if ((type == PAGELIST_READ) && - ((pagelist->offset & (g_cache_line_size - 1)) || - ((pagelist->offset + pagelist->length) & - (g_cache_line_size - 1)))) { + ((pagelist->offset & (g_cache_line_size - 1)) || + ((pagelist->offset + pagelist->length) & + (g_cache_line_size - 1)))) { char *fragments; if (down_interruptible(&g_free_fragments_sema)) { @@ -391,7 +388,7 @@ free_pagelist(struct vchiq_pagelist_info *pagelistinfo, kunmap(pages[0]); } if ((actual >= 0) && (head_bytes < actual) && - (tail_bytes != 0)) { + (tail_bytes != 0)) { memcpy((char *)kmap(pages[num_pages - 1]) + ((pagelist->offset + actual) & (PAGE_SIZE - 1) & ~(g_cache_line_size - 1)), @@ -504,9 +501,8 @@ int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) } g_dev = dev; - vchiq_log_info(vchiq_arm_log_level, - "vchiq_init - done (slots %pK, phys %pad)", - vchiq_slot_zero, &slot_phys); + vchiq_log_info(vchiq_arm_log_level, "vchiq_init - done (slots %pK, phys %pad)", + vchiq_slot_zero, &slot_phys); vchiq_call_connected_callbacks(); @@ -593,8 +589,7 @@ int vchiq_dump_platform_state(void *dump_context) char buf[80]; int len; - len = snprintf(buf, sizeof(buf), - " Platform: 2835 (VC master)"); + len = snprintf(buf, sizeof(buf), " Platform: 2835 (VC master)"); return vchiq_dump(dump_context, buf, len + 1); } @@ -617,20 +612,18 @@ int vchiq_initialise(struct vchiq_instance **instance_out) usleep_range(500, 600); } if (i == VCHIQ_INIT_RETRIES) { - vchiq_log_error(vchiq_core_log_level, - "%s: videocore not initialized\n", __func__); + vchiq_log_error(vchiq_core_log_level, "%s: videocore not initialized\n", __func__); ret = -ENOTCONN; goto failed; } else if (i > 0) { vchiq_log_warning(vchiq_core_log_level, - "%s: videocore initialized after %d retries\n", - __func__, i); + "%s: videocore initialized after %d retries\n", __func__, i); } instance = kzalloc(sizeof(*instance), GFP_KERNEL); if (!instance) { vchiq_log_error(vchiq_core_log_level, - "%s: error allocating vchiq instance\n", __func__); + "%s: error allocating vchiq instance\n", __func__); ret = -ENOMEM; goto failed; } @@ -645,8 +638,7 @@ int vchiq_initialise(struct vchiq_instance **instance_out) ret = 0; failed: - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, ret); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, ret); return ret; } @@ -659,9 +651,8 @@ void free_bulk_waiter(struct vchiq_instance *instance) list_for_each_entry_safe(waiter, next, &instance->bulk_waiter_list, list) { list_del(&waiter->list); - vchiq_log_info(vchiq_arm_log_level, - "bulk_waiter - cleaned up %pK for pid %d", - waiter, waiter->pid); + vchiq_log_info(vchiq_arm_log_level, "bulk_waiter - cleaned up %pK for pid %d", + waiter, waiter->pid); kfree(waiter); } } @@ -679,8 +670,7 @@ enum vchiq_status vchiq_shutdown(struct vchiq_instance *instance) mutex_unlock(&state->mutex); - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); free_bulk_waiter(instance); kfree(instance); @@ -700,8 +690,7 @@ enum vchiq_status vchiq_connect(struct vchiq_instance *instance) struct vchiq_state *state = instance->state; if (mutex_lock_killable(&state->mutex)) { - vchiq_log_trace(vchiq_core_log_level, - "%s: call to mutex_lock failed", __func__); + vchiq_log_trace(vchiq_core_log_level, "%s: call to mutex_lock failed", __func__); status = VCHIQ_RETRY; goto failed; } @@ -713,8 +702,7 @@ enum vchiq_status vchiq_connect(struct vchiq_instance *instance) mutex_unlock(&state->mutex); failed: - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); return status; } @@ -736,12 +724,7 @@ vchiq_add_service(struct vchiq_instance *instance, ? VCHIQ_SRVSTATE_LISTENING : VCHIQ_SRVSTATE_HIDDEN; - service = vchiq_add_service_internal( - state, - params, - srvstate, - instance, - NULL); + service = vchiq_add_service_internal(state, params, srvstate, instance, NULL); if (service) { *phandle = service->handle; @@ -750,8 +733,7 @@ vchiq_add_service(struct vchiq_instance *instance, status = VCHIQ_ERROR; } - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); return status; } @@ -770,11 +752,7 @@ vchiq_open_service(struct vchiq_instance *instance, if (!vchiq_is_connected(instance)) goto failed; - service = vchiq_add_service_internal(state, - params, - VCHIQ_SRVSTATE_OPENING, - instance, - NULL); + service = vchiq_add_service_internal(state, params, VCHIQ_SRVSTATE_OPENING, instance, NULL); if (service) { *phandle = service->handle; @@ -786,8 +764,7 @@ vchiq_open_service(struct vchiq_instance *instance, } failed: - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); return status; } @@ -809,8 +786,8 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size, VCHIQ_BULK_TRANSMIT); break; case VCHIQ_BULK_MODE_BLOCKING: - status = vchiq_blocking_bulk_transfer(handle, - (void *)data, size, VCHIQ_BULK_TRANSMIT); + status = vchiq_blocking_bulk_transfer(handle, (void *)data, size, + VCHIQ_BULK_TRANSMIT); break; default: return VCHIQ_ERROR; @@ -846,8 +823,8 @@ enum vchiq_status vchiq_bulk_receive(unsigned int handle, void *data, mode, VCHIQ_BULK_RECEIVE); break; case VCHIQ_BULK_MODE_BLOCKING: - status = vchiq_blocking_bulk_transfer(handle, - (void *)data, size, VCHIQ_BULK_RECEIVE); + status = vchiq_blocking_bulk_transfer(handle, (void *)data, size, + VCHIQ_BULK_RECEIVE); break; default: return VCHIQ_ERROR; @@ -902,8 +879,7 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, if (bulk) { /* This thread has an outstanding bulk transfer. */ /* FIXME: why compare a dma address to a pointer? */ - if ((bulk->data != (dma_addr_t)(uintptr_t)data) || - (bulk->size != size)) { + if ((bulk->data != (dma_addr_t)(uintptr_t)data) || (bulk->size != size)) { /* * This is not a retry of the previous one. * Cancel the signal when the transfer completes. @@ -916,8 +892,7 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, } else { waiter = kzalloc(sizeof(*waiter), GFP_KERNEL); if (!waiter) { - vchiq_log_error(vchiq_core_log_level, - "%s - out of memory", __func__); + vchiq_log_error(vchiq_core_log_level, "%s - out of memory", __func__); return VCHIQ_ERROR; } } @@ -925,8 +900,7 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, status = vchiq_bulk_transfer(handle, data, NULL, size, &waiter->bulk_waiter, VCHIQ_BULK_MODE_BLOCKING, dir); - if ((status != VCHIQ_RETRY) || fatal_signal_pending(current) || - !waiter->bulk_waiter.bulk) { + if ((status != VCHIQ_RETRY) || fatal_signal_pending(current) || !waiter->bulk_waiter.bulk) { struct vchiq_bulk *bulk = waiter->bulk_waiter.bulk; if (bulk) { @@ -941,9 +915,8 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, mutex_lock(&instance->bulk_waiter_list_mutex); list_add(&waiter->list, &instance->bulk_waiter_list); mutex_unlock(&instance->bulk_waiter_list_mutex); - vchiq_log_info(vchiq_arm_log_level, - "saved bulk_waiter %pK for pid %d", - waiter, current->pid); + vchiq_log_info(vchiq_arm_log_level, "saved bulk_waiter %pK for pid %d", waiter, + current->pid); } return status; @@ -963,17 +936,13 @@ add_completion(struct vchiq_instance *instance, enum vchiq_reason reason, while ((insert - instance->completion_remove) >= MAX_COMPLETIONS) { /* Out of space - wait for the client */ DEBUG_TRACE(SERVICE_CALLBACK_LINE); - vchiq_log_trace(vchiq_arm_log_level, - "%s - completion queue full", __func__); + vchiq_log_trace(vchiq_arm_log_level, "%s - completion queue full", __func__); DEBUG_COUNT(COMPLETION_QUEUE_FULL_COUNT); - if (wait_for_completion_interruptible( - &instance->remove_event)) { - vchiq_log_info(vchiq_arm_log_level, - "service_callback interrupted"); + if (wait_for_completion_interruptible(&instance->remove_event)) { + vchiq_log_info(vchiq_arm_log_level, "service_callback interrupted"); return VCHIQ_RETRY; } else if (instance->closing) { - vchiq_log_info(vchiq_arm_log_level, - "service_callback closing"); + vchiq_log_info(vchiq_arm_log_level, "service_callback closing"); return VCHIQ_SUCCESS; } DEBUG_TRACE(SERVICE_CALLBACK_LINE); @@ -1044,11 +1013,10 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, return VCHIQ_SUCCESS; vchiq_log_trace(vchiq_arm_log_level, - "%s - service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx", - __func__, (unsigned long)user_service, - service->localport, user_service->userdata, - reason, (unsigned long)header, - (unsigned long)instance, (unsigned long)bulk_userdata); + "%s - service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx", + __func__, (unsigned long)user_service, service->localport, + user_service->userdata, reason, (unsigned long)header, + (unsigned long)instance, (unsigned long)bulk_userdata); if (header && user_service->is_vchi) { spin_lock(&msg_queue_spinlock); @@ -1057,8 +1025,7 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, spin_unlock(&msg_queue_spinlock); DEBUG_TRACE(SERVICE_CALLBACK_LINE); DEBUG_COUNT(MSG_QUEUE_FULL_COUNT); - vchiq_log_trace(vchiq_arm_log_level, - "service_callback - msg queue full"); + vchiq_log_trace(vchiq_arm_log_level, "service_callback - msg queue full"); /* * If there is no MESSAGE_AVAILABLE in the completion * queue, add one @@ -1068,10 +1035,10 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, enum vchiq_status status; vchiq_log_info(vchiq_arm_log_level, - "Inserting extra MESSAGE_AVAILABLE"); + "Inserting extra MESSAGE_AVAILABLE"); DEBUG_TRACE(SERVICE_CALLBACK_LINE); - status = add_completion(instance, reason, - NULL, user_service, bulk_userdata); + status = add_completion(instance, reason, NULL, user_service, + bulk_userdata); if (status != VCHIQ_SUCCESS) { DEBUG_TRACE(SERVICE_CALLBACK_LINE); return status; @@ -1079,15 +1046,12 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, } DEBUG_TRACE(SERVICE_CALLBACK_LINE); - if (wait_for_completion_interruptible( - &user_service->remove_event)) { - vchiq_log_info(vchiq_arm_log_level, - "%s interrupted", __func__); + if (wait_for_completion_interruptible(&user_service->remove_event)) { + vchiq_log_info(vchiq_arm_log_level, "%s interrupted", __func__); DEBUG_TRACE(SERVICE_CALLBACK_LINE); return VCHIQ_RETRY; } else if (instance->closing) { - vchiq_log_info(vchiq_arm_log_level, - "%s closing", __func__); + vchiq_log_info(vchiq_arm_log_level, "%s closing", __func__); DEBUG_TRACE(SERVICE_CALLBACK_LINE); return VCHIQ_ERROR; } @@ -1238,12 +1202,10 @@ int vchiq_dump_platform_service_state(void *dump_context, len = scnprintf(buf, sizeof(buf), " instance %pK", service->instance); - if ((service->base.callback == service_callback) && - user_service->is_vchi) { - len += scnprintf(buf + len, sizeof(buf) - len, - ", %d/%d messages", - user_service->msg_insert - user_service->msg_remove, - MSG_QUEUE_SIZE); + if ((service->base.callback == service_callback) && user_service->is_vchi) { + len += scnprintf(buf + len, sizeof(buf) - len, ", %d/%d messages", + user_service->msg_insert - user_service->msg_remove, + MSG_QUEUE_SIZE); if (user_service->dequeue_pending) len += scnprintf(buf + len, sizeof(buf) - len, @@ -1276,8 +1238,7 @@ vchiq_keepalive_vchiq_callback(enum vchiq_reason reason, struct vchiq_header *header, unsigned int service_user, void *bulk_user) { - vchiq_log_error(vchiq_susp_log_level, - "%s callback reason %d", __func__, reason); + vchiq_log_error(vchiq_susp_log_level, "%s callback reason %d", __func__, reason); return 0; } @@ -1301,22 +1262,22 @@ vchiq_keepalive_thread_func(void *v) ret = vchiq_initialise(&instance); if (ret) { - vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_initialise failed %d", __func__, ret); + vchiq_log_error(vchiq_susp_log_level, "%s vchiq_initialise failed %d", __func__, + ret); goto exit; } status = vchiq_connect(instance); if (status != VCHIQ_SUCCESS) { - vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_connect failed %d", __func__, status); + vchiq_log_error(vchiq_susp_log_level, "%s vchiq_connect failed %d", __func__, + status); goto shutdown; } status = vchiq_add_service(instance, ¶ms, &ka_handle); if (status != VCHIQ_SUCCESS) { - vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_open_service failed %d", __func__, status); + vchiq_log_error(vchiq_susp_log_level, "%s vchiq_open_service failed %d", __func__, + status); goto shutdown; } @@ -1324,8 +1285,7 @@ vchiq_keepalive_thread_func(void *v) long rc = 0, uc = 0; if (wait_for_completion_interruptible(&arm_state->ka_evt)) { - vchiq_log_error(vchiq_susp_log_level, - "%s interrupted", __func__); + vchiq_log_error(vchiq_susp_log_level, "%s interrupted", __func__); flush_signals(current); continue; } @@ -1346,16 +1306,15 @@ vchiq_keepalive_thread_func(void *v) status = vchiq_use_service(ka_handle); if (status != VCHIQ_SUCCESS) { vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_use_service error %d", - __func__, status); + "%s vchiq_use_service error %d", __func__, status); } } while (rc--) { status = vchiq_release_service(ka_handle); if (status != VCHIQ_SUCCESS) { vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_release_service error %d", - __func__, status); + "%s vchiq_release_service error %d", __func__, + status); } } } @@ -1417,9 +1376,8 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, local_uc = ++arm_state->videocore_use_count; ++(*entity_uc); - vchiq_log_trace(vchiq_susp_log_level, - "%s %s count %d, state count %d", - __func__, entity, *entity_uc, local_uc); + vchiq_log_trace(vchiq_susp_log_level, "%s %s count %d, state count %d", __func__, entity, + *entity_uc, local_uc); write_unlock_bh(&arm_state->susp_res_lock); @@ -1433,8 +1391,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, if (status == VCHIQ_SUCCESS) ack_cnt--; else - atomic_add(ack_cnt, - &arm_state->ka_use_ack_count); + atomic_add(ack_cnt, &arm_state->ka_use_ack_count); } } @@ -1477,10 +1434,8 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service) --arm_state->videocore_use_count; --(*entity_uc); - vchiq_log_trace(vchiq_susp_log_level, - "%s %s count %d, state count %d", - __func__, entity, *entity_uc, - arm_state->videocore_use_count); + vchiq_log_trace(vchiq_susp_log_level, "%s %s count %d, state count %d", __func__, entity, + *entity_uc, arm_state->videocore_use_count); unlock: write_unlock_bh(&arm_state->susp_res_lock); @@ -1575,8 +1530,7 @@ vchiq_use_service(unsigned int handle) struct vchiq_service *service = find_service_by_handle(handle); if (service) { - ret = vchiq_use_internal(service->state, service, - USE_TYPE_SERVICE); + ret = vchiq_use_internal(service->state, service, USE_TYPE_SERVICE); vchiq_service_put(service); } return ret; @@ -1666,17 +1620,14 @@ vchiq_dump_service_use_state(struct vchiq_state *state) "with non-zero use-count", active_services, found); for (i = 0; i < found; i++) { - vchiq_log_warning(vchiq_susp_log_level, - "----- %c%c%c%c:%d service count %d %s", - VCHIQ_FOURCC_AS_4CHARS(service_data[i].fourcc), - service_data[i].clientid, - service_data[i].use_count, - service_data[i].use_count ? nz : ""); + vchiq_log_warning(vchiq_susp_log_level, "----- %c%c%c%c:%d service count %d %s", + VCHIQ_FOURCC_AS_4CHARS(service_data[i].fourcc), + service_data[i].clientid, service_data[i].use_count, + service_data[i].use_count ? nz : ""); } - vchiq_log_warning(vchiq_susp_log_level, - "----- VCHIQ use count count %d", peer_count); - vchiq_log_warning(vchiq_susp_log_level, - "--- Overall vchiq instance use count %d", vc_use_count); + vchiq_log_warning(vchiq_susp_log_level, "----- VCHIQ use count count %d", peer_count); + vchiq_log_warning(vchiq_susp_log_level, "--- Overall vchiq instance use count %d", + vc_use_count); kfree(service_data); } @@ -1699,10 +1650,9 @@ vchiq_check_service(struct vchiq_service *service) if (ret == VCHIQ_ERROR) { vchiq_log_error(vchiq_susp_log_level, - "%s ERROR - %c%c%c%c:%d service count %d, state count %d", __func__, - VCHIQ_FOURCC_AS_4CHARS(service->base.fourcc), - service->client_id, service->service_use_count, - arm_state->videocore_use_count); + "%s ERROR - %c%c%c%c:%d service count %d, state count %d", __func__, + VCHIQ_FOURCC_AS_4CHARS(service->base.fourcc), service->client_id, + service->service_use_count, arm_state->videocore_use_count); vchiq_dump_service_use_state(service->state); } out: @@ -1717,7 +1667,7 @@ void vchiq_platform_conn_state_changed(struct vchiq_state *state, char threadname[16]; vchiq_log_info(vchiq_susp_log_level, "%d: %s->%s", state->id, - get_conn_state_name(oldstate), get_conn_state_name(newstate)); + get_conn_state_name(oldstate), get_conn_state_name(newstate)); if (state->conn_state != VCHIQ_CONNSTATE_CONNECTED) return; From patchwork Tue Sep 14 21:35:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12494921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94EE9C433F5 for ; Tue, 14 Sep 2021 21:39:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60FFA60E8B for ; Tue, 14 Sep 2021 21:39:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 60FFA60E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LOwTrF42t+lxKq8CtBA6pwuRv7dUM8bjwY2KsB354ww=; b=L71P1jb9/fU4nR Ee0WakL3D8V+r7u8UZGE/Va6qodtsIVIpXAzKwLuMfSAU/NZDIXIvm1sLAV7eCzfgwb/XSeuUxeD7 szhpGv6FGYLDNKf/Y4qilO7vqo2uBZscaYg2a1114iMV9FLarUZNeTsHnRiSxr+30X9n5SMP7Vyqd +sM1uTIUTCF9HHXjRoHEaxLTgMEhWB5Kd457yTEzXrRnxqGzvQpduYM+TyLe1WausZxjY243wXIAT hxt4paHPWl7WPauQTnxaCE3LJJXT70K2p9wHJIwZgmr4yp1kUTOMY55AZ7JbCJn3CvB02vbUcNLtb QW1bWHd3SQVjqB5CWc7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG6l-0079ET-Ko; Tue, 14 Sep 2021 21:36:52 +0000 Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG6Z-00799v-Kw; Tue, 14 Sep 2021 21:36:40 +0000 Received: by mail-qv1-xf2f.google.com with SMTP id a13so618191qvo.9; Tue, 14 Sep 2021 14:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NYT43AQgWkXWw9PkZN5kpZUGD9/3+eOTi7mNOSzM89U=; b=IdyiQpCpSlX05iDj4TDDswyyQwy3Ko7uev0BLGA0YL+ZKgzsrWzcylhJZ+6FUFCcuA yLWXY940XkeV2te/Lu2mOD/JCgSBty0SytQrjnP+IcZwoHXStlqZLzf+yCdJwRIG4mR6 GBrBFcIUYNLrW8Wt3VGezoNBGrXoSnJRlNwKYQtL/IlMee4yU0D1Kv7YqHa8oOHWkIjv 8m0C7YYHgX1xAxsX5FW6nLycaL7HUk/av/2tcUzQ+LIVc2/9I6eeS7KI4d+r7dbr9653 EHBSdKJ9SqmeG581RBylOwHyX+NwwmUg0js/N9uPD81kyhx8q9kfhr12jWsAICRa+EvY aKkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NYT43AQgWkXWw9PkZN5kpZUGD9/3+eOTi7mNOSzM89U=; b=TTQHLSNWKxJHjxRbfCbZSRctfu1V2EnU84z8Q8VLEXiJPeGg2mV+4tc37IFpT0/bcy xv7XFTIGmA+zvibjxiF1IG3rP7Oc7725/OlXCb4miQrMRPwoPyOysofJvxaYGQij64U2 OdgsV4wFhAnucEjouYo6Ui0BubKIq1wIOYDlyG4cBjAhukGEGmiY47GO5z4za6tQi+Pq w6t3r2lOHUxdAWn0CRajYmC5QrPv4g+aAl1510c9HizW1RK0goNEyUGoXolGA1xsB0IZ viD3Xhl1FBgKzsFiRr8jMXni3Pif/0KINABOwKvdDTc6AfiD0DaP7hPrMnZSKTPcpr7q k1Fg== X-Gm-Message-State: AOAM533N/bOVxnQE2YrBJlPu+cLVai7vBBkV3mUcp+xHwWtukl8OOswZ lM3wSBgau7dItJoWjy6G0k8= X-Google-Smtp-Source: ABdhPJzpz7XV+yBcY5vgeLriCCYzEfZt9KOkoP0JcRfhwDWYH7QwH6mt6xvlSAySwJbXQL775ULqQg== X-Received: by 2002:a0c:ab4e:: with SMTP id i14mr7743350qvb.28.1631655398247; Tue, 14 Sep 2021 14:36:38 -0700 (PDT) Received: from localhost.localdomain ([191.84.239.65]) by smtp.gmail.com with ESMTPSA id o7sm6716611qtw.87.2021.09.14.14.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 14:36:37 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 3/8] staging: vchiq_arm: remove unnecessary space in cast Date: Tue, 14 Sep 2021 18:35:30 -0300 Message-Id: <20210914213532.396654-3-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210914213532.396654-1-gascoar@gmail.com> References: <20210914213532.396654-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_143639_742045_5FFD4EF3 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As reported by checkpatch.pl, no space is necessary after a cast. --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 435f1bd68ba3..f8b3997125e4 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -337,7 +337,7 @@ create_pagelist(char *buf, char __user *ubuf, down(&g_free_fragments_mutex); fragments = g_free_fragments; WARN_ON(!fragments); - g_free_fragments = *(char **) g_free_fragments; + g_free_fragments = *(char **)g_free_fragments; up(&g_free_fragments_mutex); pagelist->type = PAGELIST_READ_WITH_FRAGMENTS + (fragments - g_fragments_base) / g_fragments_size; From patchwork Tue Sep 14 21:35:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12494923 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F9BC433F5 for ; Tue, 14 Sep 2021 21:39:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88D8260E8B for ; Tue, 14 Sep 2021 21:39:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 88D8260E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UOaoyziVK274zb4DbBz96YVY8QnmsPiyKrAHqZfOiFs=; b=dmdyVdnSFCV4j7 gBsapsVC0a59C6eZyofTailNq9jjYK/U+CmFlYkvGIoSZGVOCu2Of3ABFI5occfQ2JQHFrM7+dvUJ Mbpt3wWpuoOvo5LcRsJ1aE72TrdvnQ2qK2Cbl+itgHKXKlH91Xp16+cmg8oCLpwqEn3bCjWZBsSSP l78Uj19JljAQmVREvLSWaCcMP5lCP3E2cvy/wZvBk/KZI5Cn66wXHtahxx/QNGMUhNb/3nhsaR1Rg VhkAVnBLv3pKcX8HgTGhU1PI9BJ3mltaFuM1a2trVemIjZx+ahhPZow+/eA3BxJ1yDB/7hUjIQdP3 2jI8v7TtSGFH+1ZgGaGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG73-0079Md-9s; Tue, 14 Sep 2021 21:37:09 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG6r-0079Hc-QC; Tue, 14 Sep 2021 21:37:00 +0000 Received: by mail-qv1-xf35.google.com with SMTP id u4so629939qvb.6; Tue, 14 Sep 2021 14:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=udAMjuzQQXCmw/M6tlpuan4V6V3k6IzB88Y+68k1I+A=; b=NcDjiaFrICMq2t8AiYC0QR1foMx2X9OFceglBCdJBSFSmbw8Qa764mZRGKs/hE07+N qZ8gxdnLAXMJqqymPBeQ/wU1VIiQT4OYq6nW/rC9G7yNG0MxmJl1n15JwfufsxJAHYWD ppvCyXSETWO8I9Ijqc90AgfIp5AKCuvsPAOPUEsWkbP67Qs3ECtC5/j9QnOeovvJKWLe tKCmyYTJHFVCGZZkt+eJhKIu+zqOwEtYfi9HC895+ZuNUKoMMJhm3oxAyrqeAhJhAMW+ TqvGv3ipHzryrZrGrqGfYG6DD0yXcATFLaoiFQIQ1JYT6vDqIv6XbtN482mQdKu31LBK QhJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=udAMjuzQQXCmw/M6tlpuan4V6V3k6IzB88Y+68k1I+A=; b=8DkO6cRRNjrZ4dWnJjlZjC43J8p6MPcY5T0gFcvw6jWAnc1jUfpOKbgO7YyNYKB0H0 mphQ2HmuuJZMrZC5fPfgLZLxPG/jg+02qbciuFNdld8/mTKlrROSezeg2Nr6+o+Gr1dy wG1p0pZowxwqCv2usWZNn/NP3CuA8Sid7NaOSIYk8U9Ap3rpvecs1t2on/HwTAU/YJB8 K8VHEpFEnCyDlwH/HjDhJ2kkM72tOkryh5WZVIBbOKbA3xblYpIzXZT8wRbkAsWH6ZcB 6N3nXUASkslD/19pvE7w1TlIQ0esRCmOb72GYs7aTx+rKDvXjfvxdXPDX6tWpi46SAm5 sXUw== X-Gm-Message-State: AOAM530RRO1XQY0s1yRzd/VQIlNciR8rHmL/ObSVTE49AC/FOCBbnkw+ AXGqwkRL2NoDezJnXuzGi9Q= X-Google-Smtp-Source: ABdhPJxxXWO0eizgQx1CYU83tgTd5fvuSvlhbjAtTXF9Zcp944W2+8AW/NjkFcB1YPUHP0awC269Og== X-Received: by 2002:a0c:8e05:: with SMTP id v5mr7695690qvb.25.1631655415960; Tue, 14 Sep 2021 14:36:55 -0700 (PDT) Received: from localhost.localdomain ([191.84.239.65]) by smtp.gmail.com with ESMTPSA id o7sm6716611qtw.87.2021.09.14.14.36.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 14:36:55 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 4/8] staging: vchiq_arm: clarify multiplication expressions Date: Tue, 14 Sep 2021 18:35:32 -0300 Message-Id: <20210914213532.396654-4-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210914213532.396654-1-gascoar@gmail.com> References: <20210914213532.396654-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_143657_912294_5A5BACDB X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add spaces around '*' in multiplication expressions to enhance readability. Reported by checkpatch.pl --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index f8b3997125e4..bb4035f2de65 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -466,8 +466,8 @@ int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) g_free_fragments = g_fragments_base; for (i = 0; i < (MAX_FRAGMENTS - 1); i++) { - *(char **)&g_fragments_base[i*g_fragments_size] = - &g_fragments_base[(i + 1)*g_fragments_size]; + *(char **)&g_fragments_base[i * g_fragments_size] = + &g_fragments_base[(i + 1) * g_fragments_size]; } *(char **)&g_fragments_base[i * g_fragments_size] = NULL; sema_init(&g_free_fragments_sema, MAX_FRAGMENTS); From patchwork Tue Sep 14 21:35:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12494927 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EEA4C433F5 for ; Tue, 14 Sep 2021 21:40:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 029BC60E8B for ; Tue, 14 Sep 2021 21:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 029BC60E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=99UbRhTS4xj2yOXELFsv3RY0K6CSR/ciLIL7sMfKuGo=; b=PmVtgOolAsCO0n qyaiqV+JuGCqRaKOXsnUMh7fcKktT019LjFkTFmt20bZr5lrcTdRyNTI7SMpqKXReQkdG0R3NDIAv OyeaKnkS0mBPV7gvw1Sh+9zCNEsqPuKIUdkdoYBSk1YZ42IERlBG/pewLcpyZC9Dukr4PwJYMRXJy FR3Dor7Gn+gGrT35IJ1QDtAm0XsLgaCmFInwvkBaCxKs9n2+UK6+TR2kCE+stZhS3YgpK14UYK6+M Zwrs2Y9Ql0hMa2goarBEML+mVwGYJHAPpLi136Huk7ZVnP5cmbA9+bPmqSAloJM/l/RAStzeJ5+iO Z7ic/4KSiI7AK4H6otEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG7J-0079Tb-Sg; Tue, 14 Sep 2021 21:37:26 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG73-0079Mh-BU; Tue, 14 Sep 2021 21:37:10 +0000 Received: by mail-qk1-x72f.google.com with SMTP id y144so1134997qkb.6; Tue, 14 Sep 2021 14:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QfLyoS/knpvzT0Bix+STgO/jKm0Ji7ZOPiwk0Sv8GjI=; b=f/1jHaZ/OdNGv/KlwhLXDys+VoYt45/YWHBclxzfIsx86kQOlrnyks7/zeN/m5VETJ THXTNgDk4mSFQ0ZfbP4zy/FsPKGwlDSN6rUGqaKnfoyodPwYK4TnGxesV/gzPuI8qFno iaLoquJEsKqfcUGFbjJna21//JyDGlnrHusyhLAKEPSxx1DnnjszFoMaLBYzOt63cUHM e0nqD2MD/YTgIESAWFczg5ProwoCKPeia1MuoBKa1inBY0p3iKs7W9CNI/96eHVv761X 0in2oaPcHFPEY5Xxtp9iiNc/SqDE9/ghMoYlgCsCWsyx4zqn7J0ZRTH/GH3hDiM8vSL2 cl0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QfLyoS/knpvzT0Bix+STgO/jKm0Ji7ZOPiwk0Sv8GjI=; b=UHlupXRehr1H8LLuCFQ7T1SOYP5GjqIxr2uu/Qofw4YyHZeJJzzJrKwRHIEvEOpZB2 nVkrkixCXKmf0L+GtlE7r4xEm9aDGX1tY/rk3RWEjfmN2YRNL7ysKwHSmlRA1y+Lmz8e vktWln2JkOAebS7Ni4c/cMuiZiimPrd78DnqNUNI6ry2nvHw3dg9p+F/+d9cL9b5eK9s X6RUWGCkJp3hqFeyhxgM0pF2D7rg7Xv1xjX1mK6d8xiQFZ0ghRUA5DZQrfWfFL01uhlo riLpksaeTV4vowE8+P6XeVhSvrEVC73xOMrQOgRir5ZPX5MaxjK/YzrhJIYnIi2rSmP1 xVjA== X-Gm-Message-State: AOAM531lUo37JzM565kLPggAb6x4Q6OHVajs9x1k4XJebxGbgU0UBZOG pRUwvmgTbk0Ygm5hy0FanFU= X-Google-Smtp-Source: ABdhPJxNi2vbW83hYA3Zi/244geUsgsiYd4i4UGRDtj5nMracZU/FsbqE9W9oZeSvanWxkMVCJF/Rg== X-Received: by 2002:a05:620a:290d:: with SMTP id m13mr7009333qkp.426.1631655427875; Tue, 14 Sep 2021 14:37:07 -0700 (PDT) Received: from localhost.localdomain ([191.84.239.65]) by smtp.gmail.com with ESMTPSA id o7sm6716611qtw.87.2021.09.14.14.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 14:37:07 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 5/8] staging: vchiq_arm: cleanup blank lines Date: Tue, 14 Sep 2021 18:35:34 -0300 Message-Id: <20210914213532.396654-5-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210914213532.396654-1-gascoar@gmail.com> References: <20210914213532.396654-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_143709_446364_3270BF92 X-CRM114-Status: UNSURE ( 8.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary blank lines after open braces and before close braces. Reported by checkpatch.pl --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index bb4035f2de65..ffacf1c7212b 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1218,7 +1218,6 @@ int vchiq_dump_platform_service_state(void *dump_context, struct vchiq_state * vchiq_get_state(void) { - if (!g_state.remote) pr_err("%s: g_state.remote == NULL\n", __func__); else if (g_state.remote->initialised != 1) @@ -1339,7 +1338,6 @@ vchiq_arm_init_state(struct vchiq_state *state, arm_state->state = state; arm_state->first_connect = 0; - } } From patchwork Tue Sep 14 21:35:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12494929 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16464C433EF for ; Tue, 14 Sep 2021 21:40:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D466E60EE9 for ; Tue, 14 Sep 2021 21:40:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D466E60EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xiFJq1n/tqZxZF+G7c+91fZIjHUDrmdRqhPRqs38P04=; b=1HvpVu3Qvx9yd9 EChJPRxtnYy/ECyn2RQ14wswQ9NRf7zRnM27/MJNAxkyp5azIWH6WbybPcMHbbjDM2WOy6AfI7dk1 MdKe3CQcvZO+xe3OHFSrKTehQ2+L7h41iigvym2xLKr2wzAbr7V29os8CDKznFNAIDbewNsnZxQrq BSEdrXyKzQ9g6jdDPP1FsqwLSlGOZDSF8rUVhAfGVct7AEpLLxg5RU9scDBzREk201niq4zr4b0fH oJ4rZcmXf2lWJilpXkxUSH6kHg7JJnQWi7QzP7URVWEzp3CQO6Aj0v5dTuK6IL5g1Lbhkllwqi2nH q8X9eFxmIMPsoauO4tow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG7n-0079hn-AO; Tue, 14 Sep 2021 21:37:55 +0000 Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG7c-0079d7-Vh; Tue, 14 Sep 2021 21:37:46 +0000 Received: by mail-qv1-xf31.google.com with SMTP id 62so608039qvb.11; Tue, 14 Sep 2021 14:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sN887L5dw+wolgQTxQ/Mi09l/5z12JpLwvV7NlzvMdY=; b=Om58aM4UuMcBrVCOPH8vqo0wAIVhL0KjYsQ1osJufp464nG9URvJjW+MJT57oEbCCo Cih3N0uZZwY176vyJmiIe5gkU44EEswkJORnmKmTVkxlF+NqX0Nj461cptOmAWa1RwpP DEqtK6IpSDYcpu+9CMpu0bZVWaH/fPdPgK7fxqvvTBu7/1EANsCkfnEbLHTlQ0vlKPdl qGLnKRXZIYiFgHVJHGf3PyCLd0vge+GSIGDRLKFWxwCiHPk7MxOuyi1AQw0n822tlKxK 5NOa1F0Dynan7n9SQRotwPkwRJiO0t3a6QDATqG6k9HygSlk7+PBBTZCUx4IWbMiFTqw o8Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sN887L5dw+wolgQTxQ/Mi09l/5z12JpLwvV7NlzvMdY=; b=vUxWPGhKqKoz3sBag5JO6ZONs9CzmiMHLAG2UcJn63nb1DHMcKwYSyD6JnJsD5QUpu iWwz7GRSenTc/Z4lTJLUn9ZLroIf02BbONd+/6PNTx+JOJJ7o55WOz6puHXcCB5S2KNX ZTb0jOIGn3x5ihnNIyIhtRTL7xjhpSm4CouYG3/Ph6xW2Ch+EAdrgbzGBNZQReR/hBvH ad8PrvNZDmxDeaqXhA7Y4dM/eL0uxW4uR7LMQjODXIfO6bWiiqwRR/+Av0ALEJ9uc2Oc ktgtqngaKkboAEZ13b5MxCMyrfMc/irJJ02cep7anYVzYBUFjK8WOztDeRMA/r/Pwd81 yj0A== X-Gm-Message-State: AOAM530BViCB1b2IDcHT2Ve19cPuYw8rhl2ZDw7kz3v0/5kfdaB/BYNa 7AbyO3jgLRKSV77wUiiLQ/A= X-Google-Smtp-Source: ABdhPJzMRDhqa4mXzcHqmNPW45fcwjAo/ztjQhsIyC+dpiqiuISSJw0z5wrXutsAHo27RhhOnMN28w== X-Received: by 2002:a0c:8e05:: with SMTP id v5mr7698418qvb.25.1631655463525; Tue, 14 Sep 2021 14:37:43 -0700 (PDT) Received: from localhost.localdomain ([191.84.239.65]) by smtp.gmail.com with ESMTPSA id o7sm6716611qtw.87.2021.09.14.14.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 14:37:43 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 6/8] staging: vchiq_arm: fix quoted strings split across lines Date: Tue, 14 Sep 2021 18:35:36 -0300 Message-Id: <20210914213532.396654-6-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210914213532.396654-1-gascoar@gmail.com> References: <20210914213532.396654-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_143745_116296_0BA9FF43 X-CRM114-Status: GOOD ( 10.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoted strings should not be split across lines. Quoting Documentation/process/coding-style.rst: "never break user-visible strings such as printk messages because that breaks the ability to grep for them." Reported by checkpatch.pl --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index ffacf1c7212b..72d9a6e37ae9 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1613,9 +1613,8 @@ vchiq_dump_service_use_state(struct vchiq_state *state) read_unlock_bh(&arm_state->susp_res_lock); if (only_nonzero) - vchiq_log_warning(vchiq_susp_log_level, "Too many active " - "services (%d). Only dumping up to first %d services " - "with non-zero use-count", active_services, found); + vchiq_log_warning(vchiq_susp_log_level, "Too many active services (%d). Only dumping up to first %d services with non-zero use-count", + active_services, found); for (i = 0; i < found; i++) { vchiq_log_warning(vchiq_susp_log_level, "----- %c%c%c%c:%d service count %d %s", From patchwork Tue Sep 14 21:35:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12494925 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383A7C433EF for ; Tue, 14 Sep 2021 21:39:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08BA060E8B for ; Tue, 14 Sep 2021 21:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08BA060E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PCz9ZMjJAXaiJN68sTOvnAXZVfNGLG9y+j/qe0clsHY=; b=YGdCR+Dy1Z40w6 dohK/tzVTWB4iwp1/Ik6xLZMGg2+P72YzlLDR7aDGzbgiibRoSZtP+qIgji1tNDNq4Vwnou72kJBp guWboOxWYBfOmJv7K02AM300SLc87NnsHbYTISFG33BlEbPfGU1MCcvNZv7NlJgVoYU2RdIC7GhI3 Ynxg61J6GDvygDf1hfyRz1s7lYFYGfPy+i0pydfmwlGib8TBJ0TpREFXUBry6IIDs+9ISVF+x3jvF 0C4qK7XQfcc/H5DAzrkEP5W8vwoYEVgbA2JcteAIWPsklLTFXR3BNwL4O7YBkvZfk9lsi68OuNEE1 hAgvkkBkMmvfbReDOGhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG8H-0079wy-1n; Tue, 14 Sep 2021 21:38:25 +0000 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG7s-0079kZ-OD; Tue, 14 Sep 2021 21:38:02 +0000 Received: by mail-qt1-x833.google.com with SMTP id u4so460754qta.2; Tue, 14 Sep 2021 14:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uFOWREUn6nPF1dbjd6wIX22KxI3ogfGK/7UecMqtepU=; b=jg3VVYrAF1rC/rFJAcn55n8+lDtPIjwOrXSbxG8V5B2QLbOUt9VV7nO+Z08/QlwBwb jaPT5ERNI6/m7AuT2Qnd8j2cwdOOnrONAF1DS/LJ4Aw9Ci+CpO3OIqdmU6sX/r1gQOSM 5am9GGs0z9qCbGEA4GB/SDuw7VDf1S8kbH1ICOswS6gp6b6b2Q6pAPnfSoGBfDdMmtPl rq2akVpBM93uiJbvs4Mn32n3AFfwuPJh1z4tGpwOldOZ/NzGDOz/qTBFXdqrE8ceEHtv RyzLCJpFC9tbmxuEXHwJ/+0HmXdZJrNdKUTRi7wPdjglHxvRQTqSkh+64HQOBIDC6foX GsWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uFOWREUn6nPF1dbjd6wIX22KxI3ogfGK/7UecMqtepU=; b=6t7OFmPafGl7ikN1tD/naKJxknYvu1o+vWMM/EFfgNaer6KDltw5EJ/u+4Pdj150jJ oJqwqTXEzQTx9H8Lvzc9CizvsSi77UP3N5vqnoAhpIuukgXd7PW/OnKnEsF9e5zulLAr 60XE8gvsEjvu4UKIwbgW0P/N9QA9oBJL2aEP4yC5zGR/Flw7CrP+AaoZOpnxBR6bppDr Buqan8va5/n/+Ye8FGkGsMGREDy+q67U72CKxYIfkehYLcCrvI09Xt1/BLOro44/bMeK yczsqtD9kRXrCV7StFnEgo80D/xzsd5fJTWUVO7+hwAf/R0fmSn2XI2kkY8O7wZUk4WE Y3PA== X-Gm-Message-State: AOAM532uszuQgZsqrJHbp77ytoO6qhHoM9zal2VUN9lTZxOndRtoS+zn vESkE8N+YzXAJU6kG5tvTE4= X-Google-Smtp-Source: ABdhPJz//yVjuwYxXdOob2M5XM7o6FbU9VvjnzPxZ21PXHH7WCT1xlEon7eiIWrK04qnvvcc2zU+Nw== X-Received: by 2002:ac8:7594:: with SMTP id s20mr6975586qtq.381.1631655477784; Tue, 14 Sep 2021 14:37:57 -0700 (PDT) Received: from localhost.localdomain ([191.84.239.65]) by smtp.gmail.com with ESMTPSA id o7sm6716611qtw.87.2021.09.14.14.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 14:37:57 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 7/8] staging: vchiq_arm: remove extra blank line Date: Tue, 14 Sep 2021 18:35:38 -0300 Message-Id: <20210914213532.396654-7-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210914213532.396654-1-gascoar@gmail.com> References: <20210914213532.396654-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_143800_832299_80B95BDF X-CRM114-Status: UNSURE ( 8.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary blank line. Reported by checkpatch.pl --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h index e8e39a154c74..8f5182df17b6 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h @@ -151,7 +151,6 @@ vchiq_dump_service_use_state(struct vchiq_state *state); extern struct vchiq_arm_state* vchiq_platform_get_arm_state(struct vchiq_state *state); - extern enum vchiq_status vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, enum USE_TYPE_E use_type); From patchwork Tue Sep 14 21:35:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12494931 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F7EC433F5 for ; Tue, 14 Sep 2021 21:40:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D1C260EE9 for ; Tue, 14 Sep 2021 21:40:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D1C260EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=txcdAdvhiwpCMxf8jhjNBV97TlhD1zdzPcIpB8f99sY=; b=IaVDmSreJfob07 unGtI92cvVzTYqrqHDatJgtfDVfqhLSikV6RXBjpPXlBckZF7/WsniMyx3e13xYpeMyh+Dd3xNjo5 TnpK3o8r0LjsA/uxdx0NDB8/TM5QwiTpL7YofzKSvqWWjiRxSPRj4cKcdkrBxeGMZiAzX7ndp+TAP vWTtNSK7hYmm62m0Uv0M2ocudx6jf4JgSrjCVQ3YHODY0KV1WgBOS1WgvQC+rCEMC0mvKzsztqV8M 98XXvb3XeeZ3T1Imc3tCJeIpFZYDrVlbhulqaFHzSJTOLn+zgyetBGlRo5QkgmmDsIQtVHLo+bGOQ ABjGI5kXKQGutlEVGMlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG92-007AJh-U3; Tue, 14 Sep 2021 21:39:13 +0000 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQG8M-0079zv-2q; Tue, 14 Sep 2021 21:38:31 +0000 Received: by mail-qt1-x82a.google.com with SMTP id d11so454436qtw.3; Tue, 14 Sep 2021 14:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gTyzltWgTFXOPjw+JtVdJBDzeHI6HlS3kPelko2mAhw=; b=pTJXXzRDKNPU9M1obXdrsuGlbMwi0taGqkvHnjZmaU4JR8i2I/61GJlKgJl73KlWAl 1tJeDR25y7tSKG2u7mIL/9kaEgY11SGN/Y/3Orpbt3heF0j5nu7n5BoHanImH0Bf7sFI BhiiuTQytiILqQsx+dj9HwGu4OjxuchYWvsmZWvdpZOO4K8eoxP3UF9ci2Rvl6nIU8+t rFP3s1csAXONWuyqUE+/blK9iUExireE6XvtJkCZTSgsBO5OQuOnWMY3PANTm/919Ytf pAC3048sHWVfZE5D7bqZo4VCtGhVNsExZgtXqoxHEw9pS5dQz3FOryzx9bYE7toAT+os gbmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gTyzltWgTFXOPjw+JtVdJBDzeHI6HlS3kPelko2mAhw=; b=yzqkx8Y6tGaBAWfQc1oXK4Ngobqy4oLbA8bFPMqxTXpuHVFOYYHiCWrvCEMVLJkxYX se6hE/KcDFjinIGIeuHJ97EtBNfODYwARGUwcNOeOWm41/NW2lprZ7aHgrzpfx8YNRAI E3gJtxqb9OJ4yuLqeotpZAAOHt8f/tTemMu4++RrOu9afIN025jffdqH63riWvVEQDWa xo1EdKBzELWBHeVSH35RVKu6iQnJcUSDY2tWjUMoWgg5DUg9XD1yF3hdlSCkEwBNIqDI R5ELgdBdAPmsH82e5shaFFrHiSEjlU1GwJsDRk3afK6tbz22K6e/IQ1NAeafvsjloaGZ nLgA== X-Gm-Message-State: AOAM532flBAE40rPkqYAeHpcZEmKsJ3OKyCfSb1i8Y8BH2iXx/wu8iO6 UEFkEqwztM1laVSyBOhiRg0= X-Google-Smtp-Source: ABdhPJyWMHfuCic8pX9ljyiNAr9gMqISRMOcByncvz5LKp6v6+PdH7vYTqxTcP1pVbEqgYtrKinMUw== X-Received: by 2002:ac8:4905:: with SMTP id e5mr6898010qtq.415.1631655507126; Tue, 14 Sep 2021 14:38:27 -0700 (PDT) Received: from localhost.localdomain ([191.84.239.65]) by smtp.gmail.com with ESMTPSA id o7sm6716611qtw.87.2021.09.14.14.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 14:38:26 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 8/8] staging: vchiq_arm: use __func__ to get function name in debug message Date: Tue, 14 Sep 2021 18:35:40 -0300 Message-Id: <20210914213532.396654-8-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210914213532.396654-1-gascoar@gmail.com> References: <20210914213532.396654-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_143830_173031_919E69FF X-CRM114-Status: GOOD ( 10.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Avoid hardcoded function name using "%s", __func__. This prevents potential naming conflict if the function is eventually renamed. Reported by checkpatch.pl --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 72d9a6e37ae9..2d498fb0d19f 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1025,7 +1025,7 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, spin_unlock(&msg_queue_spinlock); DEBUG_TRACE(SERVICE_CALLBACK_LINE); DEBUG_COUNT(MSG_QUEUE_FULL_COUNT); - vchiq_log_trace(vchiq_arm_log_level, "service_callback - msg queue full"); + vchiq_log_trace(vchiq_arm_log_level, "%s - msg queue full", __func__); /* * If there is no MESSAGE_AVAILABLE in the completion * queue, add one