From patchwork Wed Sep 15 20:18:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12497317 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 536F1C433F5 for ; Wed, 15 Sep 2021 20:21:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1585E60F23 for ; Wed, 15 Sep 2021 20:21:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1585E60F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=uGJzI8yAD1AF4mgVC5/WYNyzNAf9z/G5uKlqxWIvnKQ=; b=seqmJUpPb6uLs+ P1gZEPTUfQiSas+o1we2eF88zOQlQOEXPsFG9fsa/CNX4kqUYSXYjSsp0WDmYCHEvpevrUghmLiid bBhbVdRG57fTZk+mznd7/yEzehl52GLKtH//H6gEdO64E+imXtWMtPfGulQ5MBBbTcUk7/xNSLmtM Bqwc/IfT/HGbcIMKksneDeTWu31j55G+OrK7waYpaBoRB3hhUeaNynOlq7g4CvqG2sFCnrVjMsXFr +Lc5C+6XGdU3MUko1Z0XSg5R6GLbCrVnfZOv/LJxbgvXBxN8zaywZPekWGhNA24PD2cv1WRhccKd8 EK7Pz1G692uq+M/I63fQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbN2-009ppX-J4; Wed, 15 Sep 2021 20:19:04 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbMw-009po8-S5; Wed, 15 Sep 2021 20:19:01 +0000 Received: by mail-qv1-xf35.google.com with SMTP id u4so2722717qvb.6; Wed, 15 Sep 2021 13:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tXkmP1OzNV7PT3AxAD5FlqL42D9tRcrdPIr2arQBUbk=; b=SbdyKTQ7sxi0IakfPWSzbqEHLgDWbHcRDGFEzXKYyx9uWj6fMqd9m/jTNQi31Fcx++ WQm0+VFiT9QcqYenFGNl5IFsx7bOAxhwyx5CUkaj9RVs5N4ltn4/gx+2+x3CRtJ0ppSU eqjtuZZpVusksVk5PPDY4/LNLbKGNySJ6Dk6kmsRs1nMICOhQTgmdsQ4U8Ol9H74ofvG cWHtQQpLhjtM3DzE6O/mhWLKrt55sqv+Bju7HfASkrB60iNB7NgVb852KmkgF560zwyq Uf96JcALWMYgt5WFecxXUCdXXKGuiPwL6TICEa5KDz4wfD6yPkZRWDp/3aharX9BDT84 +zzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tXkmP1OzNV7PT3AxAD5FlqL42D9tRcrdPIr2arQBUbk=; b=6pLBfRFUrBOUJFYy0vbT+3GnMwQjnYtq7tRUBsK7exypySNT2VPiBJkN6qtiQPley3 3YrTFUAK4khnJxQukLOeNSEeU25ObDorlk38LkKiIbBVWLJ9N4baja0xhpVSg/92kEhZ 2JKH3M9TXLJcZQgiObzKIgeSGT53idkMhz4XSYKLfP4UtdHEw5t9byi4tuo/HhIZe31u EiEyEa89Qky9NIC0Mm5mIY4naeY7cZqWa+hphin4KHTpXSm5ffTiB15JzZAHX3Fsvuwe U0s+HSZLExdu0E9JYhqPMTRTDap9csvP969nG0Ez6viqiijxvZ7BK00Q521UWQkuVOCL 9ZJw== X-Gm-Message-State: AOAM532PS2Rkj4eTjq8//YwWCb2OqvaFX0kGX7MhyWa5b1eDaiWSF5YE ls+/z/S8WKaCZTwKl9nTyFQ= X-Google-Smtp-Source: ABdhPJzXINY8a4NR/Vwm2cuXf+l9Bq7KQyIk17w5ChQ2cDkgiGw1PnJoxXQiGhdutLsSpvljBBWJuw== X-Received: by 2002:a05:6214:238a:: with SMTP id fw10mr1656780qvb.27.1631737137304; Wed, 15 Sep 2021 13:18:57 -0700 (PDT) Received: from debianG.lan ([181.166.206.110]) by smtp.gmail.com with ESMTPSA id g8sm752834qkm.25.2021.09.15.13.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 13:18:56 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 1/7] staging: vchiq_arm: cleanup code alignment issues Date: Wed, 15 Sep 2021 17:18:18 -0300 Message-Id: <20210915201824.413202-1-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210915_131858_966012_4E244E26 X-CRM114-Status: GOOD ( 18.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix code alignment issues. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- .../interface/vchiq_arm/vchiq_arm.c | 208 +++++++----------- 1 file changed, 79 insertions(+), 129 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index b25369a13452..22de17f64ed2 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -115,7 +115,7 @@ static DEFINE_SEMAPHORE(g_free_fragments_mutex); static enum vchiq_status vchiq_blocking_bulk_transfer(unsigned int handle, void *data, - unsigned int size, enum vchiq_bulk_dir dir); + unsigned int size, enum vchiq_bulk_dir dir); static irqreturn_t vchiq_doorbell_irq(int irq, void *dev_id) @@ -251,11 +251,8 @@ create_pagelist(char *buf, char __user *ubuf, } /* do not try and release vmalloc pages */ } else { - actual_pages = pin_user_pages_fast( - (unsigned long)ubuf & PAGE_MASK, - num_pages, - type == PAGELIST_READ, - pages); + actual_pages = pin_user_pages_fast((unsigned long)ubuf & PAGE_MASK, num_pages, + type == PAGELIST_READ, pages); if (actual_pages != num_pages) { vchiq_log_info(vchiq_arm_log_level, @@ -325,9 +322,9 @@ create_pagelist(char *buf, char __user *ubuf, /* Partial cache lines (fragments) require special measures */ if ((type == PAGELIST_READ) && - ((pagelist->offset & (g_cache_line_size - 1)) || - ((pagelist->offset + pagelist->length) & - (g_cache_line_size - 1)))) { + ((pagelist->offset & (g_cache_line_size - 1)) || + ((pagelist->offset + pagelist->length) & + (g_cache_line_size - 1)))) { char *fragments; if (down_interruptible(&g_free_fragments_sema)) { @@ -391,7 +388,7 @@ free_pagelist(struct vchiq_pagelist_info *pagelistinfo, kunmap(pages[0]); } if ((actual >= 0) && (head_bytes < actual) && - (tail_bytes != 0)) { + (tail_bytes != 0)) { memcpy((char *)kmap(pages[num_pages - 1]) + ((pagelist->offset + actual) & (PAGE_SIZE - 1) & ~(g_cache_line_size - 1)), @@ -504,9 +501,8 @@ int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) } g_dev = dev; - vchiq_log_info(vchiq_arm_log_level, - "vchiq_init - done (slots %pK, phys %pad)", - vchiq_slot_zero, &slot_phys); + vchiq_log_info(vchiq_arm_log_level, "vchiq_init - done (slots %pK, phys %pad)", + vchiq_slot_zero, &slot_phys); vchiq_call_connected_callbacks(); @@ -593,8 +589,7 @@ int vchiq_dump_platform_state(void *dump_context) char buf[80]; int len; - len = snprintf(buf, sizeof(buf), - " Platform: 2835 (VC master)"); + len = snprintf(buf, sizeof(buf), " Platform: 2835 (VC master)"); return vchiq_dump(dump_context, buf, len + 1); } @@ -617,20 +612,18 @@ int vchiq_initialise(struct vchiq_instance **instance_out) usleep_range(500, 600); } if (i == VCHIQ_INIT_RETRIES) { - vchiq_log_error(vchiq_core_log_level, - "%s: videocore not initialized\n", __func__); + vchiq_log_error(vchiq_core_log_level, "%s: videocore not initialized\n", __func__); ret = -ENOTCONN; goto failed; } else if (i > 0) { vchiq_log_warning(vchiq_core_log_level, - "%s: videocore initialized after %d retries\n", - __func__, i); + "%s: videocore initialized after %d retries\n", __func__, i); } instance = kzalloc(sizeof(*instance), GFP_KERNEL); if (!instance) { vchiq_log_error(vchiq_core_log_level, - "%s: error allocating vchiq instance\n", __func__); + "%s: error allocating vchiq instance\n", __func__); ret = -ENOMEM; goto failed; } @@ -645,8 +638,7 @@ int vchiq_initialise(struct vchiq_instance **instance_out) ret = 0; failed: - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, ret); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, ret); return ret; } @@ -659,9 +651,8 @@ void free_bulk_waiter(struct vchiq_instance *instance) list_for_each_entry_safe(waiter, next, &instance->bulk_waiter_list, list) { list_del(&waiter->list); - vchiq_log_info(vchiq_arm_log_level, - "bulk_waiter - cleaned up %pK for pid %d", - waiter, waiter->pid); + vchiq_log_info(vchiq_arm_log_level, "bulk_waiter - cleaned up %pK for pid %d", + waiter, waiter->pid); kfree(waiter); } } @@ -679,8 +670,7 @@ enum vchiq_status vchiq_shutdown(struct vchiq_instance *instance) mutex_unlock(&state->mutex); - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); free_bulk_waiter(instance); kfree(instance); @@ -700,8 +690,7 @@ enum vchiq_status vchiq_connect(struct vchiq_instance *instance) struct vchiq_state *state = instance->state; if (mutex_lock_killable(&state->mutex)) { - vchiq_log_trace(vchiq_core_log_level, - "%s: call to mutex_lock failed", __func__); + vchiq_log_trace(vchiq_core_log_level, "%s: call to mutex_lock failed", __func__); status = VCHIQ_RETRY; goto failed; } @@ -713,8 +702,7 @@ enum vchiq_status vchiq_connect(struct vchiq_instance *instance) mutex_unlock(&state->mutex); failed: - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); return status; } @@ -736,12 +724,7 @@ vchiq_add_service(struct vchiq_instance *instance, ? VCHIQ_SRVSTATE_LISTENING : VCHIQ_SRVSTATE_HIDDEN; - service = vchiq_add_service_internal( - state, - params, - srvstate, - instance, - NULL); + service = vchiq_add_service_internal(state, params, srvstate, instance, NULL); if (service) { *phandle = service->handle; @@ -750,8 +733,7 @@ vchiq_add_service(struct vchiq_instance *instance, status = VCHIQ_ERROR; } - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); return status; } @@ -770,11 +752,7 @@ vchiq_open_service(struct vchiq_instance *instance, if (!vchiq_is_connected(instance)) goto failed; - service = vchiq_add_service_internal(state, - params, - VCHIQ_SRVSTATE_OPENING, - instance, - NULL); + service = vchiq_add_service_internal(state, params, VCHIQ_SRVSTATE_OPENING, instance, NULL); if (service) { *phandle = service->handle; @@ -786,8 +764,7 @@ vchiq_open_service(struct vchiq_instance *instance, } failed: - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); return status; } @@ -809,8 +786,8 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size, VCHIQ_BULK_TRANSMIT); break; case VCHIQ_BULK_MODE_BLOCKING: - status = vchiq_blocking_bulk_transfer(handle, - (void *)data, size, VCHIQ_BULK_TRANSMIT); + status = vchiq_blocking_bulk_transfer(handle, (void *)data, size, + VCHIQ_BULK_TRANSMIT); break; default: return VCHIQ_ERROR; @@ -846,8 +823,8 @@ enum vchiq_status vchiq_bulk_receive(unsigned int handle, void *data, mode, VCHIQ_BULK_RECEIVE); break; case VCHIQ_BULK_MODE_BLOCKING: - status = vchiq_blocking_bulk_transfer(handle, - (void *)data, size, VCHIQ_BULK_RECEIVE); + status = vchiq_blocking_bulk_transfer(handle, (void *)data, size, + VCHIQ_BULK_RECEIVE); break; default: return VCHIQ_ERROR; @@ -902,8 +879,7 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, if (bulk) { /* This thread has an outstanding bulk transfer. */ /* FIXME: why compare a dma address to a pointer? */ - if ((bulk->data != (dma_addr_t)(uintptr_t)data) || - (bulk->size != size)) { + if ((bulk->data != (dma_addr_t)(uintptr_t)data) || (bulk->size != size)) { /* * This is not a retry of the previous one. * Cancel the signal when the transfer completes. @@ -916,8 +892,7 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, } else { waiter = kzalloc(sizeof(*waiter), GFP_KERNEL); if (!waiter) { - vchiq_log_error(vchiq_core_log_level, - "%s - out of memory", __func__); + vchiq_log_error(vchiq_core_log_level, "%s - out of memory", __func__); return VCHIQ_ERROR; } } @@ -925,8 +900,7 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, status = vchiq_bulk_transfer(handle, data, NULL, size, &waiter->bulk_waiter, VCHIQ_BULK_MODE_BLOCKING, dir); - if ((status != VCHIQ_RETRY) || fatal_signal_pending(current) || - !waiter->bulk_waiter.bulk) { + if ((status != VCHIQ_RETRY) || fatal_signal_pending(current) || !waiter->bulk_waiter.bulk) { struct vchiq_bulk *bulk = waiter->bulk_waiter.bulk; if (bulk) { @@ -941,9 +915,8 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, mutex_lock(&instance->bulk_waiter_list_mutex); list_add(&waiter->list, &instance->bulk_waiter_list); mutex_unlock(&instance->bulk_waiter_list_mutex); - vchiq_log_info(vchiq_arm_log_level, - "saved bulk_waiter %pK for pid %d", - waiter, current->pid); + vchiq_log_info(vchiq_arm_log_level, "saved bulk_waiter %pK for pid %d", waiter, + current->pid); } return status; @@ -963,17 +936,13 @@ add_completion(struct vchiq_instance *instance, enum vchiq_reason reason, while ((insert - instance->completion_remove) >= MAX_COMPLETIONS) { /* Out of space - wait for the client */ DEBUG_TRACE(SERVICE_CALLBACK_LINE); - vchiq_log_trace(vchiq_arm_log_level, - "%s - completion queue full", __func__); + vchiq_log_trace(vchiq_arm_log_level, "%s - completion queue full", __func__); DEBUG_COUNT(COMPLETION_QUEUE_FULL_COUNT); - if (wait_for_completion_interruptible( - &instance->remove_event)) { - vchiq_log_info(vchiq_arm_log_level, - "service_callback interrupted"); + if (wait_for_completion_interruptible(&instance->remove_event)) { + vchiq_log_info(vchiq_arm_log_level, "service_callback interrupted"); return VCHIQ_RETRY; } else if (instance->closing) { - vchiq_log_info(vchiq_arm_log_level, - "service_callback closing"); + vchiq_log_info(vchiq_arm_log_level, "service_callback closing"); return VCHIQ_SUCCESS; } DEBUG_TRACE(SERVICE_CALLBACK_LINE); @@ -1044,11 +1013,10 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, return VCHIQ_SUCCESS; vchiq_log_trace(vchiq_arm_log_level, - "%s - service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx", - __func__, (unsigned long)user_service, - service->localport, user_service->userdata, - reason, (unsigned long)header, - (unsigned long)instance, (unsigned long)bulk_userdata); + "%s - service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx", + __func__, (unsigned long)user_service, service->localport, + user_service->userdata, reason, (unsigned long)header, + (unsigned long)instance, (unsigned long)bulk_userdata); if (header && user_service->is_vchi) { spin_lock(&msg_queue_spinlock); @@ -1057,8 +1025,7 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, spin_unlock(&msg_queue_spinlock); DEBUG_TRACE(SERVICE_CALLBACK_LINE); DEBUG_COUNT(MSG_QUEUE_FULL_COUNT); - vchiq_log_trace(vchiq_arm_log_level, - "service_callback - msg queue full"); + vchiq_log_trace(vchiq_arm_log_level, "service_callback - msg queue full"); /* * If there is no MESSAGE_AVAILABLE in the completion * queue, add one @@ -1068,10 +1035,10 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, enum vchiq_status status; vchiq_log_info(vchiq_arm_log_level, - "Inserting extra MESSAGE_AVAILABLE"); + "Inserting extra MESSAGE_AVAILABLE"); DEBUG_TRACE(SERVICE_CALLBACK_LINE); - status = add_completion(instance, reason, - NULL, user_service, bulk_userdata); + status = add_completion(instance, reason, NULL, user_service, + bulk_userdata); if (status != VCHIQ_SUCCESS) { DEBUG_TRACE(SERVICE_CALLBACK_LINE); return status; @@ -1079,15 +1046,12 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, } DEBUG_TRACE(SERVICE_CALLBACK_LINE); - if (wait_for_completion_interruptible( - &user_service->remove_event)) { - vchiq_log_info(vchiq_arm_log_level, - "%s interrupted", __func__); + if (wait_for_completion_interruptible(&user_service->remove_event)) { + vchiq_log_info(vchiq_arm_log_level, "%s interrupted", __func__); DEBUG_TRACE(SERVICE_CALLBACK_LINE); return VCHIQ_RETRY; } else if (instance->closing) { - vchiq_log_info(vchiq_arm_log_level, - "%s closing", __func__); + vchiq_log_info(vchiq_arm_log_level, "%s closing", __func__); DEBUG_TRACE(SERVICE_CALLBACK_LINE); return VCHIQ_ERROR; } @@ -1238,12 +1202,10 @@ int vchiq_dump_platform_service_state(void *dump_context, len = scnprintf(buf, sizeof(buf), " instance %pK", service->instance); - if ((service->base.callback == service_callback) && - user_service->is_vchi) { - len += scnprintf(buf + len, sizeof(buf) - len, - ", %d/%d messages", - user_service->msg_insert - user_service->msg_remove, - MSG_QUEUE_SIZE); + if ((service->base.callback == service_callback) && user_service->is_vchi) { + len += scnprintf(buf + len, sizeof(buf) - len, ", %d/%d messages", + user_service->msg_insert - user_service->msg_remove, + MSG_QUEUE_SIZE); if (user_service->dequeue_pending) len += scnprintf(buf + len, sizeof(buf) - len, @@ -1276,8 +1238,7 @@ vchiq_keepalive_vchiq_callback(enum vchiq_reason reason, struct vchiq_header *header, unsigned int service_user, void *bulk_user) { - vchiq_log_error(vchiq_susp_log_level, - "%s callback reason %d", __func__, reason); + vchiq_log_error(vchiq_susp_log_level, "%s callback reason %d", __func__, reason); return 0; } @@ -1301,22 +1262,22 @@ vchiq_keepalive_thread_func(void *v) ret = vchiq_initialise(&instance); if (ret) { - vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_initialise failed %d", __func__, ret); + vchiq_log_error(vchiq_susp_log_level, "%s vchiq_initialise failed %d", __func__, + ret); goto exit; } status = vchiq_connect(instance); if (status != VCHIQ_SUCCESS) { - vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_connect failed %d", __func__, status); + vchiq_log_error(vchiq_susp_log_level, "%s vchiq_connect failed %d", __func__, + status); goto shutdown; } status = vchiq_add_service(instance, ¶ms, &ka_handle); if (status != VCHIQ_SUCCESS) { - vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_open_service failed %d", __func__, status); + vchiq_log_error(vchiq_susp_log_level, "%s vchiq_open_service failed %d", __func__, + status); goto shutdown; } @@ -1324,8 +1285,7 @@ vchiq_keepalive_thread_func(void *v) long rc = 0, uc = 0; if (wait_for_completion_interruptible(&arm_state->ka_evt)) { - vchiq_log_error(vchiq_susp_log_level, - "%s interrupted", __func__); + vchiq_log_error(vchiq_susp_log_level, "%s interrupted", __func__); flush_signals(current); continue; } @@ -1346,16 +1306,15 @@ vchiq_keepalive_thread_func(void *v) status = vchiq_use_service(ka_handle); if (status != VCHIQ_SUCCESS) { vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_use_service error %d", - __func__, status); + "%s vchiq_use_service error %d", __func__, status); } } while (rc--) { status = vchiq_release_service(ka_handle); if (status != VCHIQ_SUCCESS) { vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_release_service error %d", - __func__, status); + "%s vchiq_release_service error %d", __func__, + status); } } } @@ -1417,9 +1376,8 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, local_uc = ++arm_state->videocore_use_count; ++(*entity_uc); - vchiq_log_trace(vchiq_susp_log_level, - "%s %s count %d, state count %d", - __func__, entity, *entity_uc, local_uc); + vchiq_log_trace(vchiq_susp_log_level, "%s %s count %d, state count %d", __func__, entity, + *entity_uc, local_uc); write_unlock_bh(&arm_state->susp_res_lock); @@ -1433,8 +1391,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, if (status == VCHIQ_SUCCESS) ack_cnt--; else - atomic_add(ack_cnt, - &arm_state->ka_use_ack_count); + atomic_add(ack_cnt, &arm_state->ka_use_ack_count); } } @@ -1477,10 +1434,8 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service) --arm_state->videocore_use_count; --(*entity_uc); - vchiq_log_trace(vchiq_susp_log_level, - "%s %s count %d, state count %d", - __func__, entity, *entity_uc, - arm_state->videocore_use_count); + vchiq_log_trace(vchiq_susp_log_level, "%s %s count %d, state count %d", __func__, entity, + *entity_uc, arm_state->videocore_use_count); unlock: write_unlock_bh(&arm_state->susp_res_lock); @@ -1575,8 +1530,7 @@ vchiq_use_service(unsigned int handle) struct vchiq_service *service = find_service_by_handle(handle); if (service) { - ret = vchiq_use_internal(service->state, service, - USE_TYPE_SERVICE); + ret = vchiq_use_internal(service->state, service, USE_TYPE_SERVICE); vchiq_service_put(service); } return ret; @@ -1666,17 +1620,14 @@ vchiq_dump_service_use_state(struct vchiq_state *state) "with non-zero use-count", active_services, found); for (i = 0; i < found; i++) { - vchiq_log_warning(vchiq_susp_log_level, - "----- %c%c%c%c:%d service count %d %s", - VCHIQ_FOURCC_AS_4CHARS(service_data[i].fourcc), - service_data[i].clientid, - service_data[i].use_count, - service_data[i].use_count ? nz : ""); + vchiq_log_warning(vchiq_susp_log_level, "----- %c%c%c%c:%d service count %d %s", + VCHIQ_FOURCC_AS_4CHARS(service_data[i].fourcc), + service_data[i].clientid, service_data[i].use_count, + service_data[i].use_count ? nz : ""); } - vchiq_log_warning(vchiq_susp_log_level, - "----- VCHIQ use count count %d", peer_count); - vchiq_log_warning(vchiq_susp_log_level, - "--- Overall vchiq instance use count %d", vc_use_count); + vchiq_log_warning(vchiq_susp_log_level, "----- VCHIQ use count count %d", peer_count); + vchiq_log_warning(vchiq_susp_log_level, "--- Overall vchiq instance use count %d", + vc_use_count); kfree(service_data); } @@ -1699,10 +1650,9 @@ vchiq_check_service(struct vchiq_service *service) if (ret == VCHIQ_ERROR) { vchiq_log_error(vchiq_susp_log_level, - "%s ERROR - %c%c%c%c:%d service count %d, state count %d", __func__, - VCHIQ_FOURCC_AS_4CHARS(service->base.fourcc), - service->client_id, service->service_use_count, - arm_state->videocore_use_count); + "%s ERROR - %c%c%c%c:%d service count %d, state count %d", __func__, + VCHIQ_FOURCC_AS_4CHARS(service->base.fourcc), service->client_id, + service->service_use_count, arm_state->videocore_use_count); vchiq_dump_service_use_state(service->state); } out: @@ -1717,7 +1667,7 @@ void vchiq_platform_conn_state_changed(struct vchiq_state *state, char threadname[16]; vchiq_log_info(vchiq_susp_log_level, "%d: %s->%s", state->id, - get_conn_state_name(oldstate), get_conn_state_name(newstate)); + get_conn_state_name(oldstate), get_conn_state_name(newstate)); if (state->conn_state != VCHIQ_CONNSTATE_CONNECTED) return; From patchwork Wed Sep 15 20:18:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12497321 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5958C433EF for ; Wed, 15 Sep 2021 20:21:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 885BE60E54 for ; Wed, 15 Sep 2021 20:21:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 885BE60E54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n9/+VOyfXsfopuamGTsCTfLjDIu9mJJipsEUzA3jvy0=; b=NmV1vCMCyMwxyQ a9maOgGYgQGW7HVyPpVb+O+QfKGMjmKLnUM9GDdiIxKKE5/mte2ceX7tL8g+wnkir3pVF9EP+fL2q TeHXeXNx7IMq85JlA+T6i8M0vCRbeE7Avm37n/hoZ9sC/H504FWnSnxZ9GSn2RS3Tt41gHjZx5WQf 1WDZ7NilmUl3N7Mlgr+c8zkPE04ocV+Z6ImcQ+6EVKOErzKrnrBrTG2ydqagDtTJYDeeRAtDeIolG YPZ8VI/Dsxd0EI4H2HYqtI+8b+/J7hqxbmJlRS//7gnAArV6IckmI6LCfHahDVbatDzSyVmU6F5jN CT5dSLzvxDBmLB3p6sMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbNG-009pu5-BW; Wed, 15 Sep 2021 20:19:18 +0000 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbMz-009poR-AX; Wed, 15 Sep 2021 20:19:02 +0000 Received: by mail-qk1-x730.google.com with SMTP id y144so4924076qkb.6; Wed, 15 Sep 2021 13:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mfYd+b856xF2znmD8vgv1lw332UND5JAV7Y9/ZlVnqk=; b=k7fZAN97lE5ze7C04Wg6etzrSao88Z9OtgDKyk/eluPgGMtFifQZMQwiQa6TBClJkg 31YNla82F1B5i60Pq5+IgcQuOht1Nv+bgVJqG5zb0kQRVbtpB0fu1I0d4+XVJILfh0D4 8VVDLb4dlpEq1aJCz3aw2gWMjC4wkPjgEIe4LwYqj0oDIzqhXHobAzYWo3KkiF6y27av SObKjSxZ5dZ45MnSZRepS7RTTB5AMqw7K0eYsBSfY0N1QuxDgu8D2YuvFpaDW2A1sguK JUdgKWqPAVE7amr2JqNXhkUImtOIfu5xSGAh9KykCzMpYgqSyMmIOTn9QxRiTbzJRGB7 kQ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mfYd+b856xF2znmD8vgv1lw332UND5JAV7Y9/ZlVnqk=; b=XT+B9BkIs/ZYW3ZZDFQJRmVACe5t31z32XDE3LJzdOQ6UEZlQLlm25hxf6O2iJfZA2 9Ju+fB9KML0Ap9eL15mwz5mPcAgVHf9gP8HsrXFFo5LQsH3lKDBaSup2Q8cK3cuuSwex LXN3sRNLET51Cbzy+T5tVnZCEacT/RlwOMcifGRO4FImknAwQ/RUEqiOFYnroJQnpRLA hmUIo1PLSsl1cxeYQj36rtvg4kfjxsyeIZVlXl4UcFhcs4Jx0W0nK8eqzlv8nzb9K+XR DcHX7cuKJQUDSXLKP+VxYm7h/bUdeWxne3Dr/JLuM2/1zpBt+n1wwOFoJVgfn9wXW8kq uVAA== X-Gm-Message-State: AOAM531TDkJRJGLCE7qpfYNPbXyXoHGlHN7TU7tb0najMObaarwJOKb9 F+gURceZfB1v0vOgBONsrfU= X-Google-Smtp-Source: ABdhPJzgD5iWxrGAhpj9ZBFHXfLXvzfkcHSZDD9ZwGxbqTm4bk4nk6PvrPyvHDkf0W86eoXiz2RBNw== X-Received: by 2002:a37:9947:: with SMTP id b68mr1828225qke.56.1631737140010; Wed, 15 Sep 2021 13:19:00 -0700 (PDT) Received: from debianG.lan ([181.166.206.110]) by smtp.gmail.com with ESMTPSA id g8sm752834qkm.25.2021.09.15.13.18.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 13:18:59 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 2/7] staging: vchiq_arm: remove unnecessary space in cast Date: Wed, 15 Sep 2021 17:18:19 -0300 Message-Id: <20210915201824.413202-2-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210915201824.413202-1-gascoar@gmail.com> References: <20210915201824.413202-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210915_131901_407352_7F638F23 X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As reported by checkpatch.pl, no space is necessary after a cast. Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 22de17f64ed2..e8b84b2b1ac3 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -337,7 +337,7 @@ create_pagelist(char *buf, char __user *ubuf, down(&g_free_fragments_mutex); fragments = g_free_fragments; WARN_ON(!fragments); - g_free_fragments = *(char **) g_free_fragments; + g_free_fragments = *(char **)g_free_fragments; up(&g_free_fragments_mutex); pagelist->type = PAGELIST_READ_WITH_FRAGMENTS + (fragments - g_fragments_base) / g_fragments_size; From patchwork Wed Sep 15 20:18:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12497319 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9FFAC433F5 for ; Wed, 15 Sep 2021 20:21:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9040B60F3A for ; Wed, 15 Sep 2021 20:21:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9040B60F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hXjY/L1/Zb408dYa22jP719pOnkzGFoW1WK3tycFQlM=; b=PpDz1yKDVBNucZ 5297BnrvyZA5ZuGRnkUqEnbXFYtark/19tHd3F0ZdDhDzSUslwGwBTIDYwqh1kqPjTxNOja0Dl7dZ QReLRcWj/n77XMrT7OYoO7CclBOcvaWvHRdp/IN0pDbH7RBYZUlynXl81+cCNxRrsa9/gcJqlbhDJ AGh1XxeVwv0WMzTljdr4QS3eVgnwlzKoB7PZvdoZfwriyYcGNsGh287j32/zTAIy4sIOgAlJjEPCg 0hmjH2gWxRIolB9wmKMJezcnniIUxciI33rU7JdFBRe3BiYTM9PaySWtTd0npkk6TgqHQhJeIKG0q y/GZKhcxJIm/qM7APp/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbNU-009pys-OR; Wed, 15 Sep 2021 20:19:32 +0000 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbN2-009ppH-PU; Wed, 15 Sep 2021 20:19:06 +0000 Received: by mail-qt1-x830.google.com with SMTP id r21so3520186qtw.11; Wed, 15 Sep 2021 13:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mKpje/Y92jR84VIMNNbzSjTlUCixt6FDWJQ+8cv/w1Q=; b=gSiuigEIwU1wjsEmm18oxIpET62h6EDABgcWUonBTQvBUPtHtnzv45eDDfKkXVBjIc ZeaZVNJw9hoKhK/oZX0yy/P3HOTruOIYv5f//lDBEiDNEagMYy1P19902oEvqR3ur3lP NziIAcie8NFs/skCe2cnkvn2pLxQnYH0auim7siVOOmzmZAPaclDVYrmGutjYQnWoi6v vSHo8AjaVpRZ+veCE/fv803jVCAWc7o/918wFZBuOqhFL0XI4J2vu5cQHgDM/s0jgnPK SC3zYj8SoNM/2FeFex7oigyxTxaYlj7aXVJfAQ2VpLzZx0ungRDBl6nhF19eRVpuOS7S xL2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mKpje/Y92jR84VIMNNbzSjTlUCixt6FDWJQ+8cv/w1Q=; b=uLdZq1SeZOO0gsAaxKZpm5/O/IrFZwxqXsB3+PJqImqiQNVPTJkwcz7IedjrHlA3r3 /W0tOKolvMZKbjXCi4YMjRpkPbqwkJJI9cg5kBB8kZULw1qnoVFyiIxfytCoZtzm2N2D T/0VFSErBO1wZdBjtGXsHeBS6yvGig4KWYfOfhaMU3lBB/wP99uRDj5HI+Hy5l2NXPAD wcIAHR3Y5U/mmVnMnvZahneBNYGmy+JyY0DHU3qfdwPwXnm+BJ6T4h3fY6O984eTtMBP 4H0A/fG+zS9H2KpxNa7SGpS3xUvGS2Sk2HJMRsoKV+ojv2DUwoyoin+jeVx42mrEWacK RHvQ== X-Gm-Message-State: AOAM533umXuQQ+GIvaJLM811mwzmv0QWB7AAVDYR99q78moXY4B6En3G TqIWrOciHl+ArcB7k9rYnWE= X-Google-Smtp-Source: ABdhPJzH6iLvJ6Y6ofAT6FP6w2noAViWq+EhkXChEKeGsyWBbsMwf4pHBh+lNzuex90XiKgeFTU1ag== X-Received: by 2002:ac8:5194:: with SMTP id c20mr1751717qtn.68.1631737142661; Wed, 15 Sep 2021 13:19:02 -0700 (PDT) Received: from debianG.lan ([181.166.206.110]) by smtp.gmail.com with ESMTPSA id g8sm752834qkm.25.2021.09.15.13.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 13:19:02 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 3/7] staging: vchiq_arm: clarify multiplication expressions Date: Wed, 15 Sep 2021 17:18:20 -0300 Message-Id: <20210915201824.413202-3-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210915201824.413202-1-gascoar@gmail.com> References: <20210915201824.413202-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210915_131904_891994_B79D9575 X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add spaces around '*' in multiplication expressions to enhance readability. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index e8b84b2b1ac3..9464a4777ff6 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -466,8 +466,8 @@ int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) g_free_fragments = g_fragments_base; for (i = 0; i < (MAX_FRAGMENTS - 1); i++) { - *(char **)&g_fragments_base[i*g_fragments_size] = - &g_fragments_base[(i + 1)*g_fragments_size]; + *(char **)&g_fragments_base[i * g_fragments_size] = + &g_fragments_base[(i + 1) * g_fragments_size]; } *(char **)&g_fragments_base[i * g_fragments_size] = NULL; sema_init(&g_free_fragments_sema, MAX_FRAGMENTS); From patchwork Wed Sep 15 20:18:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12497327 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0AC3C433EF for ; Wed, 15 Sep 2021 20:22:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8020E61029 for ; Wed, 15 Sep 2021 20:22:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8020E61029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AIwpkKODvEE9jbZHJXzYlmMXUsrHkfaMu5LSWWn1Q6I=; b=hHYhwmIsDDscU4 870xHIW2ewgOnz+d0lQLj4ot+4gMXGvG3C3SKpsMHimLspfr6Np0cSfeVsU8mGjUfXDITUHQ3ci/I Fj2TMpCo55lRvUFspKaU9RRYwvVRQ8yM1qksW+8yjQ7BTNaunkqu+ZYpXMWNTzd7iZI0ttqOoFJeV IiVxMgsHCKWzSxQqWsmgWcSWY0JwSaCynm1jinaD/H1seuSDOQbTos+hlTTfbZptJseTwK2PkIGR0 uHLPX6RE4yaGdYanWeSMOpZDhe1UXjqx7qQ8zkxiruU07KzHWvBa3KssJzRebC3gPt4LCRtuITW/i JueAW2WisWUgD8lsG6yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbNg-009q29-B1; Wed, 15 Sep 2021 20:19:44 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbN4-009ppu-QJ; Wed, 15 Sep 2021 20:19:08 +0000 Received: by mail-qk1-x735.google.com with SMTP id a10so4880883qka.12; Wed, 15 Sep 2021 13:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b700IZOvcmDVrq+0HZ+RP1WwJQWxcExsUcbv+nvnXKY=; b=qvHmIw3rsiOmJNvQnovoM0eSxf60ZOF3NN7bXJBhMKTXA5AZMTxHsB2LVjXld7utC9 AhyY9FxPd9Ug9poqLYuFD9UxFZjFqBjtuUMxAF5Vixoq9VZKDOolaWEKJDTjvDw0wEG9 zGLALbltQ63z8cHWnCD86kXsj++MFG7cuHNBOm+KC17g2fvCp3fdaL0bnWJPqpTkJeyc dz9BNi1qdEblD43b4H5QgQ3ugJD7U9aBdczHMi79wgNg+5W5ugDf8isf8QjsLz/cUV9k ODxCDfYCxEBQqQWumFCo5xWpd0ghL4ANHajmOQIu8/GkCROwbw7auSVvqsWwDJ8b+S0A Wisg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b700IZOvcmDVrq+0HZ+RP1WwJQWxcExsUcbv+nvnXKY=; b=uTL6+9Lxht43C0lI4/69lbR8YgUEOky7v5G29HwlpaoPOylvaR0C4Ljnc8VwU7UNTi qF7pJzcJIjeoAEBIFPsTMwtijEKY4R1cM5d8gkppnESzvXr9iVLNLPkIqfQGzwAEpecs yofqONXZxnqWxDubnwYibgwmp55RAY8vl9AaEAZwOOzptJtfJilLrUdIwFMdmRM0w2CQ zJtAY8c92rKlU3M9QBByd1d+TXX7Iqc2tZ9pAC89q/Y1evoXTcDv1f/tb0nyVeWm3WZi qGNyGiJQuFXYwMOvlAq+GwAH+tS2SNeA9AikX/ZiqpaL6PjMrtKv+JFfizsgLa66snGa hXQw== X-Gm-Message-State: AOAM531wmbhlpqYyHyULnKsXIwmAp0TbHYEKWYFeUeRbffIbi1H0ytBX TBS1gsDOGnNhBhtPRkMug2c= X-Google-Smtp-Source: ABdhPJzmRHxWO920nngdRsWvz7XJcu2fOsLeeXM1AJ5dnkZrzjyb14Hm86NHvlwr1RDYeC+Xu1I+uw== X-Received: by 2002:a05:620a:bc5:: with SMTP id s5mr1771242qki.47.1631737145479; Wed, 15 Sep 2021 13:19:05 -0700 (PDT) Received: from debianG.lan ([181.166.206.110]) by smtp.gmail.com with ESMTPSA id g8sm752834qkm.25.2021.09.15.13.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 13:19:05 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 4/7] staging: vchiq_arm: cleanup blank lines Date: Wed, 15 Sep 2021 17:18:21 -0300 Message-Id: <20210915201824.413202-4-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210915201824.413202-1-gascoar@gmail.com> References: <20210915201824.413202-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210915_131906_901107_8CF97634 X-CRM114-Status: UNSURE ( 8.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary blank lines after open braces and before close braces. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 9464a4777ff6..778540faaa1c 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1218,7 +1218,6 @@ int vchiq_dump_platform_service_state(void *dump_context, struct vchiq_state * vchiq_get_state(void) { - if (!g_state.remote) pr_err("%s: g_state.remote == NULL\n", __func__); else if (g_state.remote->initialised != 1) @@ -1339,7 +1338,6 @@ vchiq_arm_init_state(struct vchiq_state *state, arm_state->state = state; arm_state->first_connect = 0; - } } From patchwork Wed Sep 15 20:18:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12497323 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 316BFC433EF for ; Wed, 15 Sep 2021 20:22:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF5EC60E54 for ; Wed, 15 Sep 2021 20:22:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EF5EC60E54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/M5eScxIcReyM/dXCzJ0Eyh8xawifPTPQ5v+K4pDCRs=; b=AsNCFktW9C4yOv HpoObXKvMEUMqwYKVntCZemlO3Ha2ajl92dCaUtpOfn1yfDX4pPWGo7QRM6EDH0QLTcp56rozaNSF L0R0L6onm34/i8Al6jdkuuf2yR1yqxALEMvRjKIqJs/3oY0dNNtCm6OuvVGdyL9vMRiem/gfROK4B fv7qIaKhVkdYT3aftOAcn5uthBgMys97AVRLKipyMY5IYgGxSFr7pahG15qGXgn4LKNJVwwTnoGqc v6b9g9HNta5fNJDeoyV4Rw6lS1fnMm149qi+eQCgRfQkTjsNdrzIhhE3Ry6JEP2kMmhX1mfm6arWm XKIlZCLuhKPv7ePupEug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbNs-009q6I-RA; Wed, 15 Sep 2021 20:19:57 +0000 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbN7-009pr9-Fu; Wed, 15 Sep 2021 20:19:10 +0000 Received: by mail-qk1-x731.google.com with SMTP id f22so4933259qkm.5; Wed, 15 Sep 2021 13:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eNeXjhvCGZPX2nOcWVH9hj3paV16QHjNZaxjtD37JKc=; b=g3OY89RCjR/ZGNoaOqhwVZXTsShvf+4AgqRiex9BxVvvDDGOxenuubTn8Mm0zFpxlP vhjhH6r6IMvoDpkKeOD7854wV7ZjqnRes5liPmP0Z7eREmGwaB6v3dauUdBmRCy74rVg uqjYewRfe/6Gg1DF4qqpH3cjb3p3QMpMgZEtMkEGQxvxHgDM8NzcLelILaSg+NAxJitD JsfxtuD/hreiPf0fn96PTFzV0kpbqEk9e/xz/evXzHjJiq4S87rqBTUMArzSh1EmTW8G 1/29JD7LhFCTx6EdMfxsaBd1OSCpY1QNMm5VhxyQetbHlPlR0gm2SaF34N+/ORufHfm5 Px9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eNeXjhvCGZPX2nOcWVH9hj3paV16QHjNZaxjtD37JKc=; b=4a/4QyBVl8G1CDevwFOr4TEj8Dc9w9mL1gS0gqR6crVGtOMbyT1E0TBwkZVbfQkmuW fxaaDxT7KuNQz1i4DBiGsVLmkOqqQcm7V9jNwmJZFUqWb/5ZFoz91dG27GcXIcYwM3WR sqhOTKx6PrX9iIoxfzVwCBOenyHwtzOuz4TkQ6N4n8CVX+ixGYcx9s4RUDWKoi82weFm ZbDCzTeASbGQnekIkRVtl/7mD1Q6/0vvgczUk2iZrkaHjszKjOlDefzleJptiCQnQgnZ Ut+YYhiwrH5ZocscHRPSvi2cw10bPFj9At7DV+JhzQualBjpzz70NxUQuvFupArQUf31 zcLA== X-Gm-Message-State: AOAM531eX7yxdTky/l+HIFC7ma85GNAYlMDFbL3O+TvwbUTf85ui9z26 2V7f2ysdyh0+dRGWHUP+WeA= X-Google-Smtp-Source: ABdhPJyanF71gCbC8J2WEmeT+/Yhmt/G/LTPzMgphfSx8n8Wl1RiJa07g2Q3QxjqOURzIhVZPbh41Q== X-Received: by 2002:a05:620a:129c:: with SMTP id w28mr1754188qki.359.1631737148148; Wed, 15 Sep 2021 13:19:08 -0700 (PDT) Received: from debianG.lan ([181.166.206.110]) by smtp.gmail.com with ESMTPSA id g8sm752834qkm.25.2021.09.15.13.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 13:19:07 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 5/7] staging: vchiq_arm: fix quoted strings split across lines Date: Wed, 15 Sep 2021 17:18:22 -0300 Message-Id: <20210915201824.413202-5-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210915201824.413202-1-gascoar@gmail.com> References: <20210915201824.413202-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210915_131909_579580_58FB2C90 X-CRM114-Status: GOOD ( 10.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoted strings should not be split across lines. As put it in Documentation/process/coding-style.rst: "never break user-visible strings such as printk messages because that breaks the ability to grep for them." Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 778540faaa1c..3225f0738ef9 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1613,9 +1613,8 @@ vchiq_dump_service_use_state(struct vchiq_state *state) read_unlock_bh(&arm_state->susp_res_lock); if (only_nonzero) - vchiq_log_warning(vchiq_susp_log_level, "Too many active " - "services (%d). Only dumping up to first %d services " - "with non-zero use-count", active_services, found); + vchiq_log_warning(vchiq_susp_log_level, "Too many active services (%d). Only dumping up to first %d services with non-zero use-count", + active_services, found); for (i = 0; i < found; i++) { vchiq_log_warning(vchiq_susp_log_level, "----- %c%c%c%c:%d service count %d %s", From patchwork Wed Sep 15 20:18:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12497325 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F239BC433EF for ; Wed, 15 Sep 2021 20:22:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3D3861029 for ; Wed, 15 Sep 2021 20:22:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C3D3861029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AuBMlczcX0IYT1v/KQwBf16V4ADdd54FPDtGZdrI5w8=; b=VU4nFxJl01LEE5 VgnCwrubUBY3WPQp6WSl41XUgLpOUop90HLCpGheVM+pY11o2EuHewnVpWG1bHSoPXrnFcioZimbU TfAsrE5rXEG5TWMLVGOotVw2UriCD4vVODzbQ5zaye302EKNWbofTtWf7QS0qGkc7sOlRDYvd//Fd znsBQFiPCUnBlVYHZDdRZKMevLVE7oW9etbTYhsor4nxaD9XFCfwK3vpsFacW9BFc6PuvNjIVHyDS A/+0VgegTeFIBRh+oPedRUDrBPFmhHYcCH13ATrXxANRr+DQakOehWo5WqRNyJbCYJRFc8bLkePoF vNWwl5vy8Nmh+CTfqfeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbO7-009qBH-PB; Wed, 15 Sep 2021 20:20:12 +0000 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbNA-009prs-5G; Wed, 15 Sep 2021 20:19:13 +0000 Received: by mail-qk1-x732.google.com with SMTP id a10so4881242qka.12; Wed, 15 Sep 2021 13:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IjkKpbsOxtTLRzIMIRjss6tASIT031WBS0F4FaC661o=; b=NsR01QR1nDuiFpi9f+jX2Vt5AXHErqLS4DoCkeN1aYkVfSCLubVO5nk3E1duUnwA7y XRoKx30/JUaooaSWxQKFyLuDy/xwfyoQ0PUuFFDGxsBU63xh69T0Lgh3PYiH2bAgH0hD wLieKG/lrcfStyVIr5Xx8s1wDnyS2Osb0+hEza/a+bgLsBjBqau10PV7sRaI1Rrq+tmA WWX/nWntsqnffvdq100PkRCWsXoL15NxaREdfimqT8XOSw439TGvlECD1nQHGzRrIbW0 8XX+/frzSur16a9Qck9QgOJ9Q2actIuTomn5LvCHAw8wIah2vpWGaoE/RwpBvbK8gIgt 2usg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IjkKpbsOxtTLRzIMIRjss6tASIT031WBS0F4FaC661o=; b=OOy7AEydC97w/F1FrXBAeyV1v9ZO0H2Ihh2qZPfYxke+GFrSjAgkwl8VJHZ59a/7JB aKeBp+ay31UYYlW8PkNwtBjmyYgk+jVgLtnmnHSNkakRqWyml6fBXbp8pvmFDTWTzKBf 2iyw9EmfQVZJ/Pdb3P8Of6wor5XrN3EG1EqleCly1R0oKZc796ZsZ6Cgkm9X8r+J1CLF V7slyZUxGIc/QDylPiJb86Y5V92v3H3pP+5xkI2dMz4uOJGNGogV0H+C4GmmNYVijjPw NdS5k7u6Pt/8CoZbFRZVpDREU7Loxd3YaONq4sZYvwq4Mx5eHkhoxJJNpy7LVtwdmAh0 WFWg== X-Gm-Message-State: AOAM5303t+64SLNV9FK4r2SxQN8EzZqoFiJaKg5qKAaA7tCFUb/PTd+D xUcSrJTaF3xjcza5SVubB4o= X-Google-Smtp-Source: ABdhPJzGaVaPmN/ZRRmux31NxHdMbfPHZSvr8nFu9oEOEurSgh/CvDC6wjBAoBgHgNZaDd0P6VjFNw== X-Received: by 2002:ae9:c007:: with SMTP id u7mr1838430qkk.271.1631737150846; Wed, 15 Sep 2021 13:19:10 -0700 (PDT) Received: from debianG.lan ([181.166.206.110]) by smtp.gmail.com with ESMTPSA id g8sm752834qkm.25.2021.09.15.13.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 13:19:10 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 6/7] staging: vchiq_arm: remove extra blank line Date: Wed, 15 Sep 2021 17:18:23 -0300 Message-Id: <20210915201824.413202-6-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210915201824.413202-1-gascoar@gmail.com> References: <20210915201824.413202-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210915_131912_243185_C11922AB X-CRM114-Status: UNSURE ( 8.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary blank line. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h index e8e39a154c74..8f5182df17b6 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h @@ -151,7 +151,6 @@ vchiq_dump_service_use_state(struct vchiq_state *state); extern struct vchiq_arm_state* vchiq_platform_get_arm_state(struct vchiq_state *state); - extern enum vchiq_status vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, enum USE_TYPE_E use_type); From patchwork Wed Sep 15 20:18:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12497329 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB16C433F5 for ; Wed, 15 Sep 2021 20:22:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27E3E60FDA for ; Wed, 15 Sep 2021 20:22:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 27E3E60FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o9MqlkrDNq57gGn0Si4SBhJEz8r6Cerb+Dkv5bJEnx4=; b=pFYejCUZ9meVok ccCc9RP7cEP1JI6ftkap3BJYREUt9nn8l5yGNWfkHvEhgqCbu0yCVDciYhP8WeF2I49tq9z8QtLjA VGHIDoJkEcvTyd/OqaTovcoGntF3ECBEcKOPNEvHhu/ZaRBGjq9fQsmh1fIHJuruiiOEWjM5O4XkE SwC8cRi1S4V4Ct1JHTlmwGRAb1poZwgVF3jj5setuZgJoYMjPQ7mnvD6vs+bV31rGwvLRBlWgZpUk uDkkHMB1q89qH8ovIhBTuXZuTg8UGOl1ScIOgTc/PUMqyQXcTIZ6hKLDEf72dGclS1qV/fvb29wnd 4RxxwPoqRjo3AVA9qIRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbOP-009qIj-BO; Wed, 15 Sep 2021 20:20:29 +0000 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQbND-009psi-1Y; Wed, 15 Sep 2021 20:19:16 +0000 Received: by mail-qt1-x82f.google.com with SMTP id u21so3544321qtw.8; Wed, 15 Sep 2021 13:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h/GsHeyvvkKJdskTxdNmQ/rhjzzyIPbBxi6Rx6oGxp0=; b=OPLjVdWj/J6qm2GAbb9pCHOHcNwy/EUQDdiWSwEfafPVyJzDOdHnIfhn3wJIZLw8tv O72oEqxtXbhBgHf+0NjMZT9HyH4iJe+yyEVsIvqUzuLGkZUL7lnJD1g8e+81dn74PN2s 5s+EgXdbDDy+xXgxe5ulH3dSFjiIoN6fJ6PAYB9U5wQ6x+jkDksnBnK8mcwc3K8cYuJZ zgGolzYS4dMIpWyxawfgKfRNVVGv/bOMUEIoDROubFDF9QY/G7GNPs+883u463uGKDLg G8616MvtX89q0g/+/BHVXTLcMjzeo8/gdtKyhvHfdw64cqb2/giPgLHSgMhZKnMinyNN Ddmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h/GsHeyvvkKJdskTxdNmQ/rhjzzyIPbBxi6Rx6oGxp0=; b=ktGepln0LW05Ui/r1HSltar4gfSXPOvvU7zTLJlOo6A5W0Vr5aXhQyrCcTZwWZviq4 nEuxtcG6Yq84oedujIRwSAsluvQpJi73rtt46aYfvKv9biack/969CzeMpXEnRKBFazX sfil2iY4Z9m3RRvd/+eYjNxZDvDWS9D6gMyeCy8DnABVsfiqgjCeum2ZACpuPDFYSSoN leOI65KYlgOGvXmZjK/AxN1S8w9gNfqosMtfAjz4+veRmJYv7/uOy/Iz5ohfetgcRFst 9bPAGc0u3fYeAKYKpWn/1Lyc8EO7ZMQ8oxHbDbAZLO6peAF2Zt8z6s8DYf8yeKUg8DY+ mKpw== X-Gm-Message-State: AOAM531ftATIowTmsS2tVX21Y6ME9Cy16BfUNWq/dsizJxLMAxQy3BwU 5D506bg+uyvJKsRRP/fZrSk= X-Google-Smtp-Source: ABdhPJxZ1EBd1dS8DIl61uigIBDjQDvMDAwA6xYfYIZQ2gxXT9JtaQR3cQE41+4hbxcJ3UUEh6sbcw== X-Received: by 2002:a05:622a:44e:: with SMTP id o14mr1717786qtx.33.1631737153540; Wed, 15 Sep 2021 13:19:13 -0700 (PDT) Received: from debianG.lan ([181.166.206.110]) by smtp.gmail.com with ESMTPSA id g8sm752834qkm.25.2021.09.15.13.19.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 13:19:13 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 7/7] staging: vchiq_arm: use __func__ to get function name in debug message Date: Wed, 15 Sep 2021 17:18:24 -0300 Message-Id: <20210915201824.413202-7-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210915201824.413202-1-gascoar@gmail.com> References: <20210915201824.413202-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210915_131915_159604_E4069B65 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Avoid hardcoded function name using "%s", __func__. This prevents potential naming conflict if the function is eventually renamed. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 3225f0738ef9..fcff2e5bd73f 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1025,7 +1025,7 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, spin_unlock(&msg_queue_spinlock); DEBUG_TRACE(SERVICE_CALLBACK_LINE); DEBUG_COUNT(MSG_QUEUE_FULL_COUNT); - vchiq_log_trace(vchiq_arm_log_level, "service_callback - msg queue full"); + vchiq_log_trace(vchiq_arm_log_level, "%s - msg queue full", __func__); /* * If there is no MESSAGE_AVAILABLE in the completion * queue, add one