From patchwork Fri Sep 17 03:28:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Changbin Du X-Patchwork-Id: 12500941 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0409EC433EF for ; Fri, 17 Sep 2021 03:28:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B2E4D6103C for ; Fri, 17 Sep 2021 03:28:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B2E4D6103C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4801A6B0072; Thu, 16 Sep 2021 23:28:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43021900002; Thu, 16 Sep 2021 23:28:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F86A6B0074; Thu, 16 Sep 2021 23:28:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 23F876B0072 for ; Thu, 16 Sep 2021 23:28:34 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DF26B181CE29B for ; Fri, 17 Sep 2021 03:28:33 +0000 (UTC) X-FDA: 78595632906.16.B0CC7A3 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf14.hostedemail.com (Postfix) with ESMTP id AA9E06001983 for ; Fri, 17 Sep 2021 03:28:33 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id p12-20020a17090adf8c00b0019c959bc795so724268pjv.1 for ; Thu, 16 Sep 2021 20:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Tu3a1Jctb+y1+7cxgmrLpvSnXHcTL/tz3Dc1kAZAv0Q=; b=giZQkmV4Kzeopwo0M5oTuJlcGAU7l4owc5drUG/GlrbB0pmiSt+SmyGfIhroFF6v7F cuQO36118jy4rxW3tjXuyx9Pkn8sjC5odSZVModBvy4CqK7JeKy39AbGkILrdLxQu4nX G28co+YDLcGWmyw8sAd/ZsBPDhyaaWkysrHGAy+Vw4LWQ9m39Aqebh6jsoNJt0wMvqgl YJumhGkX85KMPJawyznLHrDOMBRF9eomtTIBz7oEwcuNh5dUHbfm0QrGzvKOKhrWHu9X 9eTcbUCCVgwjbtA7B9ypJebQ9E4M5xf5WrP8oCTmIfjGxSU4jCqgMaaoFGDmT51KhT5A ozDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Tu3a1Jctb+y1+7cxgmrLpvSnXHcTL/tz3Dc1kAZAv0Q=; b=z05arVvAwDp7sIgFBSEVcR4wqrbTAQrGDlNyCBGwJT1P7Adggdanecyg4nNYV3/Kwz pSSDLDd3EVaE9mRc3KXKXUvd4tuIuhai2pUR2BoV5dO3st/eyK9pOZP3+mI6CuSYtT7I vU0c3aNWeIEwNlPFF5nTHElgZr3E4RH8fFO8aPtarkZ9pLZRQ3TWFSpEIPuzFLzzOBqf 3U0KGtVBkqtEtPVUeJu8TokhythCgrXV+fOEwKDLdSgUvXh0a+RUl5vXykHMY+MZVyfT lnOLA00qUR20RlMtQwEpCQix/eBA9Ah9qGEIz+2tmd44AhG+E/HLZ4aqcr3fPJRxWEed dluA== X-Gm-Message-State: AOAM531rMcKhXZC6FDsFRvlyMonQEhcovcDwuo11nTHT3wI9soQdbPcG xyrhBCkQcw3fvCg9AvaZseM= X-Google-Smtp-Source: ABdhPJz2bEGG6f7nr6dbKWY8Ybdsi/dwfvsT4DDF+mw1vZtbAFvZs4eqXGGsVKY6EdtEooWMFFDJaw== X-Received: by 2002:a17:90a:cc02:: with SMTP id b2mr9871214pju.160.1631849312742; Thu, 16 Sep 2021 20:28:32 -0700 (PDT) Received: from WRT-WX9.lan ([141.164.41.4]) by smtp.gmail.com with ESMTPSA id n19sm4288047pfa.60.2021.09.16.20.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 20:28:32 -0700 (PDT) From: Changbin Du To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Changbin Du Subject: [PATCH] tools/vm/page-types: remove dependency on opt_file for idle page tracking Date: Fri, 17 Sep 2021 11:28:26 +0800 Message-Id: <20210917032826.10669-1-changbin.du@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=giZQkmV4; spf=pass (imf14.hostedemail.com: domain of changbin.du@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=changbin.du@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AA9E06001983 X-Stat-Signature: zxsg79sn8k3tfjr7sypqbn8c3oxrt8cf X-HE-Tag: 1631849313-796072 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Idle page tracking can also be used for process address space, not only file mappings. Without this change, using with '-i' option for process address space encounters below errors reported. $ sudo ./page-types -p $(pidof bash) -i mark page idle: Bad file descriptor mark page idle: Bad file descriptor mark page idle: Bad file descriptor mark page idle: Bad file descriptor mark page idle: Bad file descriptor mark page idle: Bad file descriptor .... Signed-off-by: Changbin Du --- tools/vm/page-types.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c index 0517c744b04e..f62f10c988db 100644 --- a/tools/vm/page-types.c +++ b/tools/vm/page-types.c @@ -1331,7 +1331,7 @@ int main(int argc, char *argv[]) if (opt_list && opt_list_mapcnt) kpagecount_fd = checked_open(PROC_KPAGECOUNT, O_RDONLY); - if (opt_mark_idle && opt_file) + if (opt_mark_idle) page_idle_fd = checked_open(SYS_KERNEL_MM_PAGE_IDLE, O_RDWR); if (opt_list && opt_pid)