From patchwork Sun Sep 19 21:59:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12504461 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11933C433F5 for ; Sun, 19 Sep 2021 22:09:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB26460F5B for ; Sun, 19 Sep 2021 22:09:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB26460F5B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uGJzI8yAD1AF4mgVC5/WYNyzNAf9z/G5uKlqxWIvnKQ=; b=hq35XIr5bfyftx cP/m1tn5U6BRtUQvIJLKheAGFFHuVeukhQwWjb4KGVP4/jcFjQMHDxDEJ97YfbrLmpH1e0t1edgQA P5DlE99lx/amtbkAuC8JwPhLaStXEIrEBk7rCg2ltbXUFv33rwfMhqYJFGR084TFLSsvVfxYZR5Tp 5wJ2BZ+P96wWq2e6NFP7k5AbOn+1ap6n40chbcpaAPx5sls0JCSqolIp1yikJ6Q2cRqpG9ox2e9Lc EKCKOB9kJ5FpEo15H1W4FFP51/8oGX8j//fUkxJSDTKGlra7MPUu7Inm+OJgbtCQbYO+ZMLfFuLDC UKEJAISj8kxJ0YwB8axw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4xM-000IO3-If; Sun, 19 Sep 2021 22:06:40 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4x8-000IJS-St; Sun, 19 Sep 2021 22:06:30 +0000 Received: by mail-qk1-x72f.google.com with SMTP id p4so36194662qki.3; Sun, 19 Sep 2021 15:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tXkmP1OzNV7PT3AxAD5FlqL42D9tRcrdPIr2arQBUbk=; b=ki/Ta0J1UvIBpKG254LdfM7MDCeYWZolwuRGnleeUlVrwcpOT00ozev986hSGmpdcn JggPJvRJAg8erzoMKkbtbdCwSG/DkGZJG9vjUU6mWcxu07/VhtERRF4jvCXSCTksbE9Q t4+3pmbNS/esoA2UrvO83Sg60F0RxKSUa1zgSRn0giwiKfIXrmysjxeNTr/4ZDvRmXZO /XfF7S6ca73A2IC+cv6d8957vftH035eHMWWK2tW+UziH6cNOxp4UNwUKpFqR/ARgoYK KucqSb3olbZLKAfja8DeQRpW2uCp1BBwb0j2VNDK2PBU0IwDUtUGKdztCPBQwcmeYGcd uq6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tXkmP1OzNV7PT3AxAD5FlqL42D9tRcrdPIr2arQBUbk=; b=BuUvWktJWpoXNk18uAvslhZD6z8bbSvkzjMSNjBi49k6mF12SPIndxi9H8B4Vftoif UUcZxQrx2DiARP4sZbEP7uoZElEJYTBYoMxeAZsYBREmr6J1v06TVztRgY9JS6IMBHEV M1/4ThqyKHP6M7PuxL59p3CUD7jLzGowArIII3svwXVuQBfSQOPKp+imRB+X4j2WkNnw WZY/Kkk2JrXxXiHPmDKeR8UrJkLkvR8mkfNQKifxEykNZzjs9m5mYU1bsiRmK4U13ORz 6QELXO/ds+CZc4vl5zVkem44VFPR1KmuQDnlUsSAl/yQAwBcLjeS1RbU+AKvcLUGbe/n G7dQ== X-Gm-Message-State: AOAM531PiJdDsLNkLbR92aN07q+QZjmGVpwB9z1S8ZJ/82SHiSQ43vFj /JDD8Z9T1HbCYNIGKyzL3CU= X-Google-Smtp-Source: ABdhPJylW+dJGRQCR4IUxkvBe64UCjylJyebSsOsTvw3p+TDiifBJaeHDlsfcpOSWNMSDadGkireng== X-Received: by 2002:a37:9eca:: with SMTP id h193mr8194042qke.127.1632089185655; Sun, 19 Sep 2021 15:06:25 -0700 (PDT) Received: from localhost.localdomain ([191.84.236.195]) by smtp.gmail.com with ESMTPSA id t23sm246313qkj.31.2021.09.19.15.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 15:06:24 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 1/7] staging: vchiq_arm: cleanup code alignment issues Date: Sun, 19 Sep 2021 18:59:08 -0300 Message-Id: <20210919215914.539805-2-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210919215914.539805-1-gascoar@gmail.com> References: <20210919215914.539805-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_150628_026766_BCF91A5C X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix code alignment issues. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- .../interface/vchiq_arm/vchiq_arm.c | 208 +++++++----------- 1 file changed, 79 insertions(+), 129 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index b25369a13452..22de17f64ed2 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -115,7 +115,7 @@ static DEFINE_SEMAPHORE(g_free_fragments_mutex); static enum vchiq_status vchiq_blocking_bulk_transfer(unsigned int handle, void *data, - unsigned int size, enum vchiq_bulk_dir dir); + unsigned int size, enum vchiq_bulk_dir dir); static irqreturn_t vchiq_doorbell_irq(int irq, void *dev_id) @@ -251,11 +251,8 @@ create_pagelist(char *buf, char __user *ubuf, } /* do not try and release vmalloc pages */ } else { - actual_pages = pin_user_pages_fast( - (unsigned long)ubuf & PAGE_MASK, - num_pages, - type == PAGELIST_READ, - pages); + actual_pages = pin_user_pages_fast((unsigned long)ubuf & PAGE_MASK, num_pages, + type == PAGELIST_READ, pages); if (actual_pages != num_pages) { vchiq_log_info(vchiq_arm_log_level, @@ -325,9 +322,9 @@ create_pagelist(char *buf, char __user *ubuf, /* Partial cache lines (fragments) require special measures */ if ((type == PAGELIST_READ) && - ((pagelist->offset & (g_cache_line_size - 1)) || - ((pagelist->offset + pagelist->length) & - (g_cache_line_size - 1)))) { + ((pagelist->offset & (g_cache_line_size - 1)) || + ((pagelist->offset + pagelist->length) & + (g_cache_line_size - 1)))) { char *fragments; if (down_interruptible(&g_free_fragments_sema)) { @@ -391,7 +388,7 @@ free_pagelist(struct vchiq_pagelist_info *pagelistinfo, kunmap(pages[0]); } if ((actual >= 0) && (head_bytes < actual) && - (tail_bytes != 0)) { + (tail_bytes != 0)) { memcpy((char *)kmap(pages[num_pages - 1]) + ((pagelist->offset + actual) & (PAGE_SIZE - 1) & ~(g_cache_line_size - 1)), @@ -504,9 +501,8 @@ int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) } g_dev = dev; - vchiq_log_info(vchiq_arm_log_level, - "vchiq_init - done (slots %pK, phys %pad)", - vchiq_slot_zero, &slot_phys); + vchiq_log_info(vchiq_arm_log_level, "vchiq_init - done (slots %pK, phys %pad)", + vchiq_slot_zero, &slot_phys); vchiq_call_connected_callbacks(); @@ -593,8 +589,7 @@ int vchiq_dump_platform_state(void *dump_context) char buf[80]; int len; - len = snprintf(buf, sizeof(buf), - " Platform: 2835 (VC master)"); + len = snprintf(buf, sizeof(buf), " Platform: 2835 (VC master)"); return vchiq_dump(dump_context, buf, len + 1); } @@ -617,20 +612,18 @@ int vchiq_initialise(struct vchiq_instance **instance_out) usleep_range(500, 600); } if (i == VCHIQ_INIT_RETRIES) { - vchiq_log_error(vchiq_core_log_level, - "%s: videocore not initialized\n", __func__); + vchiq_log_error(vchiq_core_log_level, "%s: videocore not initialized\n", __func__); ret = -ENOTCONN; goto failed; } else if (i > 0) { vchiq_log_warning(vchiq_core_log_level, - "%s: videocore initialized after %d retries\n", - __func__, i); + "%s: videocore initialized after %d retries\n", __func__, i); } instance = kzalloc(sizeof(*instance), GFP_KERNEL); if (!instance) { vchiq_log_error(vchiq_core_log_level, - "%s: error allocating vchiq instance\n", __func__); + "%s: error allocating vchiq instance\n", __func__); ret = -ENOMEM; goto failed; } @@ -645,8 +638,7 @@ int vchiq_initialise(struct vchiq_instance **instance_out) ret = 0; failed: - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, ret); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, ret); return ret; } @@ -659,9 +651,8 @@ void free_bulk_waiter(struct vchiq_instance *instance) list_for_each_entry_safe(waiter, next, &instance->bulk_waiter_list, list) { list_del(&waiter->list); - vchiq_log_info(vchiq_arm_log_level, - "bulk_waiter - cleaned up %pK for pid %d", - waiter, waiter->pid); + vchiq_log_info(vchiq_arm_log_level, "bulk_waiter - cleaned up %pK for pid %d", + waiter, waiter->pid); kfree(waiter); } } @@ -679,8 +670,7 @@ enum vchiq_status vchiq_shutdown(struct vchiq_instance *instance) mutex_unlock(&state->mutex); - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); free_bulk_waiter(instance); kfree(instance); @@ -700,8 +690,7 @@ enum vchiq_status vchiq_connect(struct vchiq_instance *instance) struct vchiq_state *state = instance->state; if (mutex_lock_killable(&state->mutex)) { - vchiq_log_trace(vchiq_core_log_level, - "%s: call to mutex_lock failed", __func__); + vchiq_log_trace(vchiq_core_log_level, "%s: call to mutex_lock failed", __func__); status = VCHIQ_RETRY; goto failed; } @@ -713,8 +702,7 @@ enum vchiq_status vchiq_connect(struct vchiq_instance *instance) mutex_unlock(&state->mutex); failed: - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); return status; } @@ -736,12 +724,7 @@ vchiq_add_service(struct vchiq_instance *instance, ? VCHIQ_SRVSTATE_LISTENING : VCHIQ_SRVSTATE_HIDDEN; - service = vchiq_add_service_internal( - state, - params, - srvstate, - instance, - NULL); + service = vchiq_add_service_internal(state, params, srvstate, instance, NULL); if (service) { *phandle = service->handle; @@ -750,8 +733,7 @@ vchiq_add_service(struct vchiq_instance *instance, status = VCHIQ_ERROR; } - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); return status; } @@ -770,11 +752,7 @@ vchiq_open_service(struct vchiq_instance *instance, if (!vchiq_is_connected(instance)) goto failed; - service = vchiq_add_service_internal(state, - params, - VCHIQ_SRVSTATE_OPENING, - instance, - NULL); + service = vchiq_add_service_internal(state, params, VCHIQ_SRVSTATE_OPENING, instance, NULL); if (service) { *phandle = service->handle; @@ -786,8 +764,7 @@ vchiq_open_service(struct vchiq_instance *instance, } failed: - vchiq_log_trace(vchiq_core_log_level, - "%s(%p): returning %d", __func__, instance, status); + vchiq_log_trace(vchiq_core_log_level, "%s(%p): returning %d", __func__, instance, status); return status; } @@ -809,8 +786,8 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size, VCHIQ_BULK_TRANSMIT); break; case VCHIQ_BULK_MODE_BLOCKING: - status = vchiq_blocking_bulk_transfer(handle, - (void *)data, size, VCHIQ_BULK_TRANSMIT); + status = vchiq_blocking_bulk_transfer(handle, (void *)data, size, + VCHIQ_BULK_TRANSMIT); break; default: return VCHIQ_ERROR; @@ -846,8 +823,8 @@ enum vchiq_status vchiq_bulk_receive(unsigned int handle, void *data, mode, VCHIQ_BULK_RECEIVE); break; case VCHIQ_BULK_MODE_BLOCKING: - status = vchiq_blocking_bulk_transfer(handle, - (void *)data, size, VCHIQ_BULK_RECEIVE); + status = vchiq_blocking_bulk_transfer(handle, (void *)data, size, + VCHIQ_BULK_RECEIVE); break; default: return VCHIQ_ERROR; @@ -902,8 +879,7 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, if (bulk) { /* This thread has an outstanding bulk transfer. */ /* FIXME: why compare a dma address to a pointer? */ - if ((bulk->data != (dma_addr_t)(uintptr_t)data) || - (bulk->size != size)) { + if ((bulk->data != (dma_addr_t)(uintptr_t)data) || (bulk->size != size)) { /* * This is not a retry of the previous one. * Cancel the signal when the transfer completes. @@ -916,8 +892,7 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, } else { waiter = kzalloc(sizeof(*waiter), GFP_KERNEL); if (!waiter) { - vchiq_log_error(vchiq_core_log_level, - "%s - out of memory", __func__); + vchiq_log_error(vchiq_core_log_level, "%s - out of memory", __func__); return VCHIQ_ERROR; } } @@ -925,8 +900,7 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, status = vchiq_bulk_transfer(handle, data, NULL, size, &waiter->bulk_waiter, VCHIQ_BULK_MODE_BLOCKING, dir); - if ((status != VCHIQ_RETRY) || fatal_signal_pending(current) || - !waiter->bulk_waiter.bulk) { + if ((status != VCHIQ_RETRY) || fatal_signal_pending(current) || !waiter->bulk_waiter.bulk) { struct vchiq_bulk *bulk = waiter->bulk_waiter.bulk; if (bulk) { @@ -941,9 +915,8 @@ vchiq_blocking_bulk_transfer(unsigned int handle, void *data, unsigned int size, mutex_lock(&instance->bulk_waiter_list_mutex); list_add(&waiter->list, &instance->bulk_waiter_list); mutex_unlock(&instance->bulk_waiter_list_mutex); - vchiq_log_info(vchiq_arm_log_level, - "saved bulk_waiter %pK for pid %d", - waiter, current->pid); + vchiq_log_info(vchiq_arm_log_level, "saved bulk_waiter %pK for pid %d", waiter, + current->pid); } return status; @@ -963,17 +936,13 @@ add_completion(struct vchiq_instance *instance, enum vchiq_reason reason, while ((insert - instance->completion_remove) >= MAX_COMPLETIONS) { /* Out of space - wait for the client */ DEBUG_TRACE(SERVICE_CALLBACK_LINE); - vchiq_log_trace(vchiq_arm_log_level, - "%s - completion queue full", __func__); + vchiq_log_trace(vchiq_arm_log_level, "%s - completion queue full", __func__); DEBUG_COUNT(COMPLETION_QUEUE_FULL_COUNT); - if (wait_for_completion_interruptible( - &instance->remove_event)) { - vchiq_log_info(vchiq_arm_log_level, - "service_callback interrupted"); + if (wait_for_completion_interruptible(&instance->remove_event)) { + vchiq_log_info(vchiq_arm_log_level, "service_callback interrupted"); return VCHIQ_RETRY; } else if (instance->closing) { - vchiq_log_info(vchiq_arm_log_level, - "service_callback closing"); + vchiq_log_info(vchiq_arm_log_level, "service_callback closing"); return VCHIQ_SUCCESS; } DEBUG_TRACE(SERVICE_CALLBACK_LINE); @@ -1044,11 +1013,10 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, return VCHIQ_SUCCESS; vchiq_log_trace(vchiq_arm_log_level, - "%s - service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx", - __func__, (unsigned long)user_service, - service->localport, user_service->userdata, - reason, (unsigned long)header, - (unsigned long)instance, (unsigned long)bulk_userdata); + "%s - service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx", + __func__, (unsigned long)user_service, service->localport, + user_service->userdata, reason, (unsigned long)header, + (unsigned long)instance, (unsigned long)bulk_userdata); if (header && user_service->is_vchi) { spin_lock(&msg_queue_spinlock); @@ -1057,8 +1025,7 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, spin_unlock(&msg_queue_spinlock); DEBUG_TRACE(SERVICE_CALLBACK_LINE); DEBUG_COUNT(MSG_QUEUE_FULL_COUNT); - vchiq_log_trace(vchiq_arm_log_level, - "service_callback - msg queue full"); + vchiq_log_trace(vchiq_arm_log_level, "service_callback - msg queue full"); /* * If there is no MESSAGE_AVAILABLE in the completion * queue, add one @@ -1068,10 +1035,10 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, enum vchiq_status status; vchiq_log_info(vchiq_arm_log_level, - "Inserting extra MESSAGE_AVAILABLE"); + "Inserting extra MESSAGE_AVAILABLE"); DEBUG_TRACE(SERVICE_CALLBACK_LINE); - status = add_completion(instance, reason, - NULL, user_service, bulk_userdata); + status = add_completion(instance, reason, NULL, user_service, + bulk_userdata); if (status != VCHIQ_SUCCESS) { DEBUG_TRACE(SERVICE_CALLBACK_LINE); return status; @@ -1079,15 +1046,12 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, } DEBUG_TRACE(SERVICE_CALLBACK_LINE); - if (wait_for_completion_interruptible( - &user_service->remove_event)) { - vchiq_log_info(vchiq_arm_log_level, - "%s interrupted", __func__); + if (wait_for_completion_interruptible(&user_service->remove_event)) { + vchiq_log_info(vchiq_arm_log_level, "%s interrupted", __func__); DEBUG_TRACE(SERVICE_CALLBACK_LINE); return VCHIQ_RETRY; } else if (instance->closing) { - vchiq_log_info(vchiq_arm_log_level, - "%s closing", __func__); + vchiq_log_info(vchiq_arm_log_level, "%s closing", __func__); DEBUG_TRACE(SERVICE_CALLBACK_LINE); return VCHIQ_ERROR; } @@ -1238,12 +1202,10 @@ int vchiq_dump_platform_service_state(void *dump_context, len = scnprintf(buf, sizeof(buf), " instance %pK", service->instance); - if ((service->base.callback == service_callback) && - user_service->is_vchi) { - len += scnprintf(buf + len, sizeof(buf) - len, - ", %d/%d messages", - user_service->msg_insert - user_service->msg_remove, - MSG_QUEUE_SIZE); + if ((service->base.callback == service_callback) && user_service->is_vchi) { + len += scnprintf(buf + len, sizeof(buf) - len, ", %d/%d messages", + user_service->msg_insert - user_service->msg_remove, + MSG_QUEUE_SIZE); if (user_service->dequeue_pending) len += scnprintf(buf + len, sizeof(buf) - len, @@ -1276,8 +1238,7 @@ vchiq_keepalive_vchiq_callback(enum vchiq_reason reason, struct vchiq_header *header, unsigned int service_user, void *bulk_user) { - vchiq_log_error(vchiq_susp_log_level, - "%s callback reason %d", __func__, reason); + vchiq_log_error(vchiq_susp_log_level, "%s callback reason %d", __func__, reason); return 0; } @@ -1301,22 +1262,22 @@ vchiq_keepalive_thread_func(void *v) ret = vchiq_initialise(&instance); if (ret) { - vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_initialise failed %d", __func__, ret); + vchiq_log_error(vchiq_susp_log_level, "%s vchiq_initialise failed %d", __func__, + ret); goto exit; } status = vchiq_connect(instance); if (status != VCHIQ_SUCCESS) { - vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_connect failed %d", __func__, status); + vchiq_log_error(vchiq_susp_log_level, "%s vchiq_connect failed %d", __func__, + status); goto shutdown; } status = vchiq_add_service(instance, ¶ms, &ka_handle); if (status != VCHIQ_SUCCESS) { - vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_open_service failed %d", __func__, status); + vchiq_log_error(vchiq_susp_log_level, "%s vchiq_open_service failed %d", __func__, + status); goto shutdown; } @@ -1324,8 +1285,7 @@ vchiq_keepalive_thread_func(void *v) long rc = 0, uc = 0; if (wait_for_completion_interruptible(&arm_state->ka_evt)) { - vchiq_log_error(vchiq_susp_log_level, - "%s interrupted", __func__); + vchiq_log_error(vchiq_susp_log_level, "%s interrupted", __func__); flush_signals(current); continue; } @@ -1346,16 +1306,15 @@ vchiq_keepalive_thread_func(void *v) status = vchiq_use_service(ka_handle); if (status != VCHIQ_SUCCESS) { vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_use_service error %d", - __func__, status); + "%s vchiq_use_service error %d", __func__, status); } } while (rc--) { status = vchiq_release_service(ka_handle); if (status != VCHIQ_SUCCESS) { vchiq_log_error(vchiq_susp_log_level, - "%s vchiq_release_service error %d", - __func__, status); + "%s vchiq_release_service error %d", __func__, + status); } } } @@ -1417,9 +1376,8 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, local_uc = ++arm_state->videocore_use_count; ++(*entity_uc); - vchiq_log_trace(vchiq_susp_log_level, - "%s %s count %d, state count %d", - __func__, entity, *entity_uc, local_uc); + vchiq_log_trace(vchiq_susp_log_level, "%s %s count %d, state count %d", __func__, entity, + *entity_uc, local_uc); write_unlock_bh(&arm_state->susp_res_lock); @@ -1433,8 +1391,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, if (status == VCHIQ_SUCCESS) ack_cnt--; else - atomic_add(ack_cnt, - &arm_state->ka_use_ack_count); + atomic_add(ack_cnt, &arm_state->ka_use_ack_count); } } @@ -1477,10 +1434,8 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service) --arm_state->videocore_use_count; --(*entity_uc); - vchiq_log_trace(vchiq_susp_log_level, - "%s %s count %d, state count %d", - __func__, entity, *entity_uc, - arm_state->videocore_use_count); + vchiq_log_trace(vchiq_susp_log_level, "%s %s count %d, state count %d", __func__, entity, + *entity_uc, arm_state->videocore_use_count); unlock: write_unlock_bh(&arm_state->susp_res_lock); @@ -1575,8 +1530,7 @@ vchiq_use_service(unsigned int handle) struct vchiq_service *service = find_service_by_handle(handle); if (service) { - ret = vchiq_use_internal(service->state, service, - USE_TYPE_SERVICE); + ret = vchiq_use_internal(service->state, service, USE_TYPE_SERVICE); vchiq_service_put(service); } return ret; @@ -1666,17 +1620,14 @@ vchiq_dump_service_use_state(struct vchiq_state *state) "with non-zero use-count", active_services, found); for (i = 0; i < found; i++) { - vchiq_log_warning(vchiq_susp_log_level, - "----- %c%c%c%c:%d service count %d %s", - VCHIQ_FOURCC_AS_4CHARS(service_data[i].fourcc), - service_data[i].clientid, - service_data[i].use_count, - service_data[i].use_count ? nz : ""); + vchiq_log_warning(vchiq_susp_log_level, "----- %c%c%c%c:%d service count %d %s", + VCHIQ_FOURCC_AS_4CHARS(service_data[i].fourcc), + service_data[i].clientid, service_data[i].use_count, + service_data[i].use_count ? nz : ""); } - vchiq_log_warning(vchiq_susp_log_level, - "----- VCHIQ use count count %d", peer_count); - vchiq_log_warning(vchiq_susp_log_level, - "--- Overall vchiq instance use count %d", vc_use_count); + vchiq_log_warning(vchiq_susp_log_level, "----- VCHIQ use count count %d", peer_count); + vchiq_log_warning(vchiq_susp_log_level, "--- Overall vchiq instance use count %d", + vc_use_count); kfree(service_data); } @@ -1699,10 +1650,9 @@ vchiq_check_service(struct vchiq_service *service) if (ret == VCHIQ_ERROR) { vchiq_log_error(vchiq_susp_log_level, - "%s ERROR - %c%c%c%c:%d service count %d, state count %d", __func__, - VCHIQ_FOURCC_AS_4CHARS(service->base.fourcc), - service->client_id, service->service_use_count, - arm_state->videocore_use_count); + "%s ERROR - %c%c%c%c:%d service count %d, state count %d", __func__, + VCHIQ_FOURCC_AS_4CHARS(service->base.fourcc), service->client_id, + service->service_use_count, arm_state->videocore_use_count); vchiq_dump_service_use_state(service->state); } out: @@ -1717,7 +1667,7 @@ void vchiq_platform_conn_state_changed(struct vchiq_state *state, char threadname[16]; vchiq_log_info(vchiq_susp_log_level, "%d: %s->%s", state->id, - get_conn_state_name(oldstate), get_conn_state_name(newstate)); + get_conn_state_name(oldstate), get_conn_state_name(newstate)); if (state->conn_state != VCHIQ_CONNSTATE_CONNECTED) return; From patchwork Sun Sep 19 21:59:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12504463 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 261F8C433F5 for ; Sun, 19 Sep 2021 22:09:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E357460F5B for ; Sun, 19 Sep 2021 22:09:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E357460F5B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n9/+VOyfXsfopuamGTsCTfLjDIu9mJJipsEUzA3jvy0=; b=nghq48ZjM/No++ LAb+LTXbbA0wvYDN579KxF0BxIlsDC+UHwxwrj+yhIJckjJXC4yf0uO/cZssT1MxXZs3WZwHMTou+ kQXiPbBrGyJWhRhNCoqQstQt5bu0VXDdVLxmq+eUhOgSwqLbXiGtlZJfk1Xj9u0w5WgwfiLafSumm b8BfHq8zlBAxoCJNH29kbpYqVnBVZ5uOmJPURVLdgYiLmPSYAYyicelWUrUgyINLPZkBFwExzVE7Y 7ii9X99TXOueoKtFquHa9zKOxB32nd5eBap13HVvtSx1NPoOBhFUFirdOmuS9/fDaglA0HNa63sOK me+uVVVYu2GwIMmzZsKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4xX-000IRT-2g; Sun, 19 Sep 2021 22:06:51 +0000 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4xB-000IJp-6v; Sun, 19 Sep 2021 22:06:31 +0000 Received: by mail-qk1-x72b.google.com with SMTP id p4so36194985qki.3; Sun, 19 Sep 2021 15:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mfYd+b856xF2znmD8vgv1lw332UND5JAV7Y9/ZlVnqk=; b=TDZhgdW8zLMG4mDcHV/Zk+TwCyZCwnIeriU66Z0y9XH4I0JyJPVn5dpiG2eIiAuvAm 7spVm4H9aAPIjvSK0Gi6c26LeW4UB2dANItBEQKllplYbrX7LiouHNr8gZL/2AoG1rtC XQLT00cJX9sSiumqdDZdO1qpA0sqcoIvegZd3nzzFYKdX0I8EcelYHt4o1iqmKbZ2E+d yLZRQ5jgtelwwrJY2DpylI70CvliUYdgaDpEDMNMJu9Mwfpoe8EmOxCr9hseIHEyO3s7 mQeGGMtp69BrC0+jO3uVAw2Kp8Xmf2qvIxmj36EPzdOsTlLSTrxtxEFSYjsUfLNVYjYu gfHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mfYd+b856xF2znmD8vgv1lw332UND5JAV7Y9/ZlVnqk=; b=6Gd+LTc0FTnOMhzPN3gGJ0tLzwWBIg5ZQpYABEI2Sh/J7T1xFCksvZGKgbKBoYfa2b moD35ZEfcX0Qg3FdWaevYsmdCw3yORgMCJIzpNux7rexLcQaazKau9t2L3KBrwKT2Pw1 3PUs7rXgfgEZWqFHt62Ay3dBnmgf6+UsM/Pf4h0I3kY/2Th8q0BTbWKVs5Dyfu1B+dhr EqYhuIK2EU+LLVLfK5af+dGv3Nc+kBj4e377CYP/ytSV7Rw69x0Ier5+6ZFH2toFW+BW IJ2K9MtT69AlF9ZseD6v97oyea3kF0K9zh4rb/fMkNaiB4gAIXjcbP0Gb9m42ckIc5u4 ZPaQ== X-Gm-Message-State: AOAM533tFdQZZhVr+GnDCy3t+tpmxXbCumsdXL5x1pZ09HGakBXdDiQu 9uMVzjPj64HK3qdAGZgWc4c= X-Google-Smtp-Source: ABdhPJy/Vbacm+ffq+LhaTjLNEMcyDWPIpyl3Ny1MP8EuvNHAUQS0ECA9s22fIt0gJkTxam81+97/g== X-Received: by 2002:ae9:e897:: with SMTP id a145mr3323482qkg.297.1632089188284; Sun, 19 Sep 2021 15:06:28 -0700 (PDT) Received: from localhost.localdomain ([191.84.236.195]) by smtp.gmail.com with ESMTPSA id t23sm246313qkj.31.2021.09.19.15.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 15:06:27 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 2/7] staging: vchiq_arm: remove unnecessary space in cast Date: Sun, 19 Sep 2021 18:59:09 -0300 Message-Id: <20210919215914.539805-3-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210919215914.539805-1-gascoar@gmail.com> References: <20210919215914.539805-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_150629_341842_FC0CEBE9 X-CRM114-Status: GOOD ( 11.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As reported by checkpatch.pl, no space is necessary after a cast. Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 22de17f64ed2..e8b84b2b1ac3 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -337,7 +337,7 @@ create_pagelist(char *buf, char __user *ubuf, down(&g_free_fragments_mutex); fragments = g_free_fragments; WARN_ON(!fragments); - g_free_fragments = *(char **) g_free_fragments; + g_free_fragments = *(char **)g_free_fragments; up(&g_free_fragments_mutex); pagelist->type = PAGELIST_READ_WITH_FRAGMENTS + (fragments - g_fragments_base) / g_fragments_size; From patchwork Sun Sep 19 21:59:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12504467 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94965C433EF for ; Sun, 19 Sep 2021 22:09:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59FBB60F9C for ; Sun, 19 Sep 2021 22:09:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 59FBB60F9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hXjY/L1/Zb408dYa22jP719pOnkzGFoW1WK3tycFQlM=; b=tq98nYR5HJd2Li 57k0Aco5HFG1wsahXP1MRbiYmW7fCydbgmHTDP/jB+wl3kh/gf9ooZOV5jzHTJPh7EPUMXe/LSBPY I978/2lfmrKXt3HJ8PaMCUOusb0sDRkIJkAUTlsxl2/0xn0dDyvpHi863WNOnz/J4kYuH0hIUkaIJ p62u5ABrGFylb7/m/lV0MNR6FhcU6Vmj6MfX1lXnSlG7BpCmWkcK7sbrNJEVx7/gRvxZuoTZ9Lzce iWWbrSjxN2IBu9X+OiT+boi61AeGmtQHTedckxqJUgaib9MZbzffoW/ihRYza0HXBe265LG0A/KkC zM4CjasV/f3rVkQ9P1fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4xk-000ITj-AD; Sun, 19 Sep 2021 22:07:04 +0000 Received: from mail-qv1-xf33.google.com ([2607:f8b0:4864:20::f33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4xD-000IL2-Tq; Sun, 19 Sep 2021 22:06:33 +0000 Received: by mail-qv1-xf33.google.com with SMTP id z12so10014995qvx.5; Sun, 19 Sep 2021 15:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mKpje/Y92jR84VIMNNbzSjTlUCixt6FDWJQ+8cv/w1Q=; b=MawK2iJeLSjzey9cfpgZFpypwtawe4w+nousG5KvG26e+uw+bUs1IzP1D73/yt1L99 0zshOirhW47/7sYHwjLDtg/NtQQ4hatop0WAY++cbPpffjV/qzK+H295wZHG60frStqs Fb9qFyfz3SfkpCqIvnEL6+QcO79A9BXWdP13kQFilelU4wZQ4v68UwI7EQ4YIPJi4omY 3DvlyBS86P1YCKHi1GfbMTBPibVU+AoRdwRn/0eLTGv9QLl2fxLPafqMsXznMaP+A0ei pqITHkBhsKMI6gnlTxgimQwLoPVJUsad8b4XCh1eOoPQup+Pu3PFLp6joOVl4cu7+N8D FVGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mKpje/Y92jR84VIMNNbzSjTlUCixt6FDWJQ+8cv/w1Q=; b=RqE39HJCG2xJ4b3XCix4aHyc0KN42DZPO/XWfZ49k8WH9zyXQtqeIWDSL9lMu0Lipl cLEOHrc754FsDp1szcdlh4JJ35WZLI6OIPVZxNw096zFRUASfS73P1Zje6VuP5Aa8qwb gxpEGUZrmvLwWStsITJ8A/tUfLx4CPtR85qCHIzp1S1AlKWUlV6kWNddrL84mJwYeHfq ngNi6OqXdkZ9oO3rIB+R/NQa7BALrkp3OOiz3M7lp2TwcHQdpSEEEocVea8PpNvy0Mfp 2C0CW9+0Zcmp/BAlLP8SxgF7EG0aeBt7jUwzofb6z40WXhz7Puf3uquENlAq65oWh3Jd UFAA== X-Gm-Message-State: AOAM533RdUle3yGRdwJLaincQ9yLa9KmNlkaB7zrwDj051bM2z1M9JB2 jxfD49ue5QJLFC3clGlJIGY= X-Google-Smtp-Source: ABdhPJzbcP5EilKkmcub8FPrk1SASVA5fhYZpcc0aOEdoFaCI6DKYOs5D3IyNUN833zLkq3fd1xSzg== X-Received: by 2002:a05:6214:1593:: with SMTP id m19mr22329365qvw.36.1632089190983; Sun, 19 Sep 2021 15:06:30 -0700 (PDT) Received: from localhost.localdomain ([191.84.236.195]) by smtp.gmail.com with ESMTPSA id t23sm246313qkj.31.2021.09.19.15.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 15:06:30 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 3/7] staging: vchiq_arm: clarify multiplication expressions Date: Sun, 19 Sep 2021 18:59:10 -0300 Message-Id: <20210919215914.539805-4-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210919215914.539805-1-gascoar@gmail.com> References: <20210919215914.539805-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_150632_006954_74D5B103 X-CRM114-Status: GOOD ( 10.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add spaces around '*' in multiplication expressions to enhance readability. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index e8b84b2b1ac3..9464a4777ff6 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -466,8 +466,8 @@ int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) g_free_fragments = g_fragments_base; for (i = 0; i < (MAX_FRAGMENTS - 1); i++) { - *(char **)&g_fragments_base[i*g_fragments_size] = - &g_fragments_base[(i + 1)*g_fragments_size]; + *(char **)&g_fragments_base[i * g_fragments_size] = + &g_fragments_base[(i + 1) * g_fragments_size]; } *(char **)&g_fragments_base[i * g_fragments_size] = NULL; sema_init(&g_free_fragments_sema, MAX_FRAGMENTS); From patchwork Sun Sep 19 21:59:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12504471 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E61EC433F5 for ; Sun, 19 Sep 2021 22:09:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7B786101B for ; Sun, 19 Sep 2021 22:09:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E7B786101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AIwpkKODvEE9jbZHJXzYlmMXUsrHkfaMu5LSWWn1Q6I=; b=CaRQ57sNiDjFe8 fyA3cCswoI6Mu+FRDQk3zTr1xI3OMAbyfDFBk2XNlt4v6+x9ENbsxsWuCv7OHeL0io/LkZYtqiRPY Hu9Xu5JYOcs+i0ZOKwCVF45Mq3gwihhnM3POeAYmuYSjl7CpsMlxu06fcWE1QVz0mXwpxJ5pTIC4A awF0hDiQnFv+2COxbXUj7XYjcOvxanWtWE1oe56cjICQ7nBFiMju/+MjG80osneYpyDhgpAHO7Gpd ANg3Rb2tCOtyvi9GqmvKo8kV/pCzwSKy2abyHuaQljsbqHtx4+DtLcYVdHT9Rm7yM2gDl0sY/u7yh ZWLIZ6UT2jScQaeM+SsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4xv-000IXQ-8z; Sun, 19 Sep 2021 22:07:15 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4xG-000IM8-H1; Sun, 19 Sep 2021 22:06:35 +0000 Received: by mail-qv1-xf35.google.com with SMTP id jo30so10032133qvb.3; Sun, 19 Sep 2021 15:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b700IZOvcmDVrq+0HZ+RP1WwJQWxcExsUcbv+nvnXKY=; b=Vp8vCU0BfQKHWL7fU64lnVUwpF1PWnTE97HCEbS8ZbUW2Y3rSjVbgVoYwrPtbyKs4l VB3ncPyVjF7MwxRIMgjllDLrZ3EY5D8bRiWQy1StUdgvFxmbKurFt+m52GG4uVlhyX99 l7nN4e+pK8BwYfbrbU/B2Y5JbVpesXCuHwcEiiPksMRFMvsqZ8mO8v/AQxaZH/UGOxFm HcXLre04c6B8lgTJETWEVs86rdcwll8EKBxGLBacSE+Be8DCcWkx/4WWQ+KOvfLpQplu JvLJUYNuB0y7LPCKa7OvpPNGawJNZ3U7HeZS+YLgpvOdfuhcWeO/0YhD19aeQ1qkgIcK 5ftg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b700IZOvcmDVrq+0HZ+RP1WwJQWxcExsUcbv+nvnXKY=; b=ITD6fz2DVjoYIfNmsHYz2LEibqfZXwGbKiawrJmLugrfFor1oofBkgHgtiypL1CuXv zpKEcFoL2x5YnmSAMd+uFKUEJNd/+yTFInueGU0XJN4lNtC/CjdsHQ6bVRmniEyNbQbi +SXC1zAjK5IWvCxKOWueIczxzp2J4OzpPXRfrTT/18Tj8R7qf9Jy5dPtaDiy6NJwNjk7 6tXovz/fTFYOQKd9UL+MfkSiKUbVZXzLYVUvYzjWvUDC1VIZKXyDE+ZsuxbMj1kohRXk vbCyXk6oyckpGxXIIq0c2A2LHqD6j/DScRSrFXHGsyDLjMTSPjwH2Rjddl0TuRrZhzsG dDYQ== X-Gm-Message-State: AOAM532H3vLaZS6Lz1UWw7+XUKL4fxeKuR7o5TC66gTmJ1dZ+eG1FWqY LlhsBVnBHaozKxBCxqXcWbk= X-Google-Smtp-Source: ABdhPJyvkDxySbpKskXmjexAAElJnXfWuNwqFgXqy/i6V9jE8lprk/H9LTY87IBm7g1/8+7a1D0KKw== X-Received: by 2002:ad4:45c3:: with SMTP id v3mr22656038qvt.41.1632089193618; Sun, 19 Sep 2021 15:06:33 -0700 (PDT) Received: from localhost.localdomain ([191.84.236.195]) by smtp.gmail.com with ESMTPSA id t23sm246313qkj.31.2021.09.19.15.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 15:06:33 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 4/7] staging: vchiq_arm: cleanup blank lines Date: Sun, 19 Sep 2021 18:59:11 -0300 Message-Id: <20210919215914.539805-5-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210919215914.539805-1-gascoar@gmail.com> References: <20210919215914.539805-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_150634_621389_92573455 X-CRM114-Status: UNSURE ( 9.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary blank lines after open braces and before close braces. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 9464a4777ff6..778540faaa1c 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1218,7 +1218,6 @@ int vchiq_dump_platform_service_state(void *dump_context, struct vchiq_state * vchiq_get_state(void) { - if (!g_state.remote) pr_err("%s: g_state.remote == NULL\n", __func__); else if (g_state.remote->initialised != 1) @@ -1339,7 +1338,6 @@ vchiq_arm_init_state(struct vchiq_state *state, arm_state->state = state; arm_state->first_connect = 0; - } } From patchwork Sun Sep 19 21:59:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12504469 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED8AC433EF for ; Sun, 19 Sep 2021 22:09:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BEAD60F9C for ; Sun, 19 Sep 2021 22:09:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9BEAD60F9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/M5eScxIcReyM/dXCzJ0Eyh8xawifPTPQ5v+K4pDCRs=; b=SN2je/zNHTijnu 0+tttOlCqnOQL71I9LZ18pv/5o98JrQid6/q8/qDNKdYCNp8YJi4hPbqvT/yvvYMZ7om/I+DLumhE OX5jl37c0encjjie6ISTi6rvjYBds3ossMl6GjAGtnJ2Dv6FI/gkviC/gz8g8WJOTIq6S60AB7OAX FCvI36BpPztYF1+grkK2MHaOA+ZWx72c/e5Hxhllt2sNtlc5Cjz1OLECzhSji1HRN5tzs+JEnh57r bqkQu++QSAw0sjms6rxMdb4O+bqIpH0RpuvVHSGl4wm4NeHfVsVWkMQNzd9BvF0TOeDLivoGsPMWv dc6eIfDtpnL6GLQsz4JA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4y7-000Iav-7w; Sun, 19 Sep 2021 22:07:27 +0000 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4xJ-000IMn-8J; Sun, 19 Sep 2021 22:06:38 +0000 Received: by mail-qt1-x82a.google.com with SMTP id w17so13797160qta.9; Sun, 19 Sep 2021 15:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eNeXjhvCGZPX2nOcWVH9hj3paV16QHjNZaxjtD37JKc=; b=bdju8P1JNCtH4FfOsfKw7jhE+FYFlGhixvqUVUw+RqDWnnBJqcVQ7uHC8HY/n67igG NmbK0lxIa97y48TrV5uezSA9uY1aLC/7M9ewytY/DgBeWukMZoOB7OBpP1e3qDuUxzUb f37HvE6PLVO3RPAUj1vJnOa1F/hWZ2uSscEuaJUJZ/aiMyirrS0zEBuCbt7xAeX/2Mj6 AC0LZ7Bu50G6OwF4FAAPzp3V5EXNhwUczqT9CfsU52E9pJEaEa/BMHLWwJIbbOU4iFDI xWA5VfWik7ivuD4hlfuDZ3Hc22O/5tG0i67yJy088RHZv3FN+8SUDUUgLBvMedDVwPjB KT7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eNeXjhvCGZPX2nOcWVH9hj3paV16QHjNZaxjtD37JKc=; b=msH4GMrxN9J8rScHueiK4PYmve+MHHbAzCCcSV1f+eSweDuijR3bRVyMfDiGxvmmjP 6CdVRPsdPPHFdeFZIKdzrhtqGKsTGIxF3oxJVNIiYWw1E2RidUhq4f4EDLycuhOzMyMX 4Dvpe2ujFgF1SCy5KPhN8I+FNIzbJ5nHPsrPCsNK8qlJ9zoDrWSZuisZ3lp669+4V6bT 6VqrNjp/Aae6adjxzagxSHADRiZrWwjbLO5b8RnzNYJ7wUeyWBbULEF+Y8VDjOljs4AL y/2iwFOr0HqPt+f1hajVMfFVIfWp+yS8rROx7ihRCMRObnsW4cfvEeCBLD0Bz1K7oPa3 fBvw== X-Gm-Message-State: AOAM531BrhJidQtv0q/PdwJIqFfJC/takgtbHKWLUbOvGiCI3Uel8Xgq lm/vr+bmT5gnGuanvVLLV50= X-Google-Smtp-Source: ABdhPJwtILmiTO6cTMW/YTNJdEBI3XfCBQKbiBaQpwYLShtu+IbVkdLRc8b2tAot/kzdA8IX1g3bgw== X-Received: by 2002:ac8:7c8d:: with SMTP id y13mr638530qtv.27.1632089196296; Sun, 19 Sep 2021 15:06:36 -0700 (PDT) Received: from localhost.localdomain ([191.84.236.195]) by smtp.gmail.com with ESMTPSA id t23sm246313qkj.31.2021.09.19.15.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 15:06:35 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 5/7] staging: vchiq_arm: fix quoted strings split across lines Date: Sun, 19 Sep 2021 18:59:12 -0300 Message-Id: <20210919215914.539805-6-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210919215914.539805-1-gascoar@gmail.com> References: <20210919215914.539805-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_150637_353013_F92BD25E X-CRM114-Status: GOOD ( 10.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoted strings should not be split across lines. As put it in Documentation/process/coding-style.rst: "never break user-visible strings such as printk messages because that breaks the ability to grep for them." Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 778540faaa1c..3225f0738ef9 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1613,9 +1613,8 @@ vchiq_dump_service_use_state(struct vchiq_state *state) read_unlock_bh(&arm_state->susp_res_lock); if (only_nonzero) - vchiq_log_warning(vchiq_susp_log_level, "Too many active " - "services (%d). Only dumping up to first %d services " - "with non-zero use-count", active_services, found); + vchiq_log_warning(vchiq_susp_log_level, "Too many active services (%d). Only dumping up to first %d services with non-zero use-count", + active_services, found); for (i = 0; i < found; i++) { vchiq_log_warning(vchiq_susp_log_level, "----- %c%c%c%c:%d service count %d %s", From patchwork Sun Sep 19 21:59:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12504465 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD55C433EF for ; Sun, 19 Sep 2021 22:09:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 111E060F5B for ; Sun, 19 Sep 2021 22:09:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 111E060F5B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AuBMlczcX0IYT1v/KQwBf16V4ADdd54FPDtGZdrI5w8=; b=01a7+2vevre7ct AfmN8nCIF2jWChXcp5NfIhTpTgBl9fEpatDBYWUwc8JCAD7wTMG1xWGFd0sDzS8duNE3HjYlm/Wi5 WylJBN6p05Wrl9A0MxjI19+1TXy0Cl9OuN60kDdz9yCsBZuHTfKfZO2V6ks4/APdCPvA2xI4WcKMb HLMfKOA4FDafCoLg19dwgxMKPsMq99gQzjHSegVCiwEgQE0Mz7oGldOCNS+c6YQVVps+Aqzby/Aki zVDbwH5yYcCNDIOCHWKetjA+zpsvSIctppEstQhhxQAZQy7wm72hCbdvjq9xPYHyhEEDb4ESrwoWX o6J1JNk6FrLzexNqoOVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4yL-000If5-Ii; Sun, 19 Sep 2021 22:07:41 +0000 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4xM-000IO7-1H; Sun, 19 Sep 2021 22:06:41 +0000 Received: by mail-qk1-x730.google.com with SMTP id 73so31171307qki.4; Sun, 19 Sep 2021 15:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IjkKpbsOxtTLRzIMIRjss6tASIT031WBS0F4FaC661o=; b=XAeOLV6BqNjq9EWbsR0tUxpnuA2trCD6twKtXiP6b+wl5coPS29WULQcpwcxCVTvPK ebBE4TcKwer/1lhoni/vME6bsNX9QVYzqV/TU+9mqmJqApuUj5fzDCuLBx52AjXiS26I bCvSgZ0BoijMDw9OsUbb6TtMqaldXR4v9dPdihNcYKol/J3grtDmz3viohVSBSMiXeNL 5j4coQufHZo7sjO/ZV1HzUWFqVWtHDqhbaDiSuhVC5cqy6fUUfP2TL4QlTZZMQyjT2vy 4GvgJ0xOr6m8YPjNw08MoP5Vtw7CoP/zpqgdWnPIqnpdHCYJ4fO+N3R9RrUpDHXIuSHp HiFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IjkKpbsOxtTLRzIMIRjss6tASIT031WBS0F4FaC661o=; b=7uE+MrFay7xZ/5uARbrrTj7Z2OFPoEnsReJF4Uv+IumzdGHFC1cEdnXI+oKCBNiq5s /ZWkh9e7GGFZ0j0gNLMk4ZSOV3tvMqBVbChwE71FVjadWicbr1ZilBzfKfzWCMxWTEl2 R3GdvrG4X7BoSgKigAVQiS/oT91HRbE/EvHfT6QXb0oZbP8WjLIPeVpswShNF9od9/8C 8rcM+t7yhSu3PFCcoOL3vJwo66whxL3x0FlwSP4cQ21IQwCFQJ6TQRLeEmAbvKMPxEGQ gmdTTE81Kt4uyFU4a+dxlhR0vC4pcbHIgxFcmWP8M8+Lenkvm1XUNAsu5d+I2l8o+5qE GJ3g== X-Gm-Message-State: AOAM533quDfHP1WWINKQfXEDjhhdoUYMo+vJUzGSmbrqgq+FGprtdxzt yraDJ6CoFcYBilmywF/DsxI= X-Google-Smtp-Source: ABdhPJz1CWgnIroJXybinJQzMbOF2B23vgwlHdCljMO+VE+W8hT0mUE2aP6wnNPYMAnp/J3/Q3kmpA== X-Received: by 2002:a05:620a:191e:: with SMTP id bj30mr20635687qkb.319.1632089199017; Sun, 19 Sep 2021 15:06:39 -0700 (PDT) Received: from localhost.localdomain ([191.84.236.195]) by smtp.gmail.com with ESMTPSA id t23sm246313qkj.31.2021.09.19.15.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 15:06:38 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 6/7] staging: vchiq_arm: remove extra blank line Date: Sun, 19 Sep 2021 18:59:13 -0300 Message-Id: <20210919215914.539805-7-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210919215914.539805-1-gascoar@gmail.com> References: <20210919215914.539805-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_150640_130608_2D507A39 X-CRM114-Status: UNSURE ( 8.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary blank line. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h index e8e39a154c74..8f5182df17b6 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h @@ -151,7 +151,6 @@ vchiq_dump_service_use_state(struct vchiq_state *state); extern struct vchiq_arm_state* vchiq_platform_get_arm_state(struct vchiq_state *state); - extern enum vchiq_status vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, enum USE_TYPE_E use_type); From patchwork Sun Sep 19 21:59:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12504473 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A47EC433F5 for ; Sun, 19 Sep 2021 22:10:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14FA460F9C for ; Sun, 19 Sep 2021 22:10:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 14FA460F9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o9MqlkrDNq57gGn0Si4SBhJEz8r6Cerb+Dkv5bJEnx4=; b=ldcLEempaoCVyZ k5/r8Ojb5JygtprooR4od6uSFD0OYZlCOY6pGH4KXvEcUYbrRXV6r2h97fSucuPI8ppRM1Fcx8MY5 r1SBXOSkJtyfwzYKO6MixR3pAUEMT8Sma8aDh7VQAusHzXdGPSHaJrPINHIqcRbX69eMBILweheOA RLPEqljTP55EbDpxuLsYJndgZKiYp0fnC6dfAiL8aeFF7F4TvNjNTSxlFbXxbco5gnDkM+UsFHRhz rrKB8K7+LoBxPAR9z+E9FxFzZiFSZmCY5NTT/NlITg7DgvIiO4oVMRvHTw83SwpSWQ39FWwXdffGA +gU07UM/d9ZOuIGnSlvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4yl-000Iqu-64; Sun, 19 Sep 2021 22:08:07 +0000 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS4xO-000IPN-JJ; Sun, 19 Sep 2021 22:06:44 +0000 Received: by mail-qk1-x72c.google.com with SMTP id i132so7765902qke.1; Sun, 19 Sep 2021 15:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h/GsHeyvvkKJdskTxdNmQ/rhjzzyIPbBxi6Rx6oGxp0=; b=EwRZXHZ2ZxDHgukg6GrKwx/vTr0nhMBZQfpi+FrmLDNCeENzzH1sf4puo5sCKCq/M+ HkVrHJZtzMqa0US0pWeKBUMJgBO97pz3vFKIjj4aVl9KBsTT6x2Gdsd9yHFQlpFbA25B C7j2njdMeNH8sWHr2jONX+rLKoF4/IsZ29y9KLEoJ04xyaTFJBkJxXmqrfp2TW4rf49w Tj40Usf5WWP7bG2Oz4uptbmmFvpgVzr5KcvV44BVZTUYVYaSczVw3PcR/iTAzEaP8VRg SPuMDj/9C5oYnWGm60WEhEPcDYhAk/e4HdOo9Bc/ugArvAWNzHHk5sG8fOR6XMl12Wf0 UTBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h/GsHeyvvkKJdskTxdNmQ/rhjzzyIPbBxi6Rx6oGxp0=; b=VGPj59jp1ClQGoRQq9LzQkN02QDy6qw6UOhYa49096mjKsypVXnJvTrKRgKVMdv4NB SIa1bfk9u7pHoF2nYkDHSl3PgfnYOhYgx+iohJkLhh5PCa6WKbV4d6U+47aKe7TTDGis zKIhELYAgW75U4/lj/zj6QUoFzJeSW7OQh7+wJm96KklekWxbPqDsCbXciZ/s+NWffGm OxIuHBRlIWU2fZ77pibEG9v18ip2cG6HrfMsHA9lOqKNhjdfgRKDE8uv4At1XqDiYU61 tco5VKzZphRMupWu0Qb9ob+9CGzmbdpaYHR/Fe6XC6EVMI97yOjy85Q5444qlFO6+PEC zV4A== X-Gm-Message-State: AOAM530jOlVo+zTqqIIb9BOcNdU+jsbw/2KiCpvaOsurk5vkaMvj+3pg qAOFOFqy3bZ7YmJ0huEnhoA= X-Google-Smtp-Source: ABdhPJyfsmmaw+e54+EKhacYU+CLQadhZShHYn6/qVyVc1PUf6FwE2BQXyPk/MBkIkFJiEBXwFX08w== X-Received: by 2002:a37:f515:: with SMTP id l21mr21014533qkk.234.1632089201692; Sun, 19 Sep 2021 15:06:41 -0700 (PDT) Received: from localhost.localdomain ([191.84.236.195]) by smtp.gmail.com with ESMTPSA id t23sm246313qkj.31.2021.09.19.15.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 15:06:41 -0700 (PDT) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 7/7] staging: vchiq_arm: use __func__ to get function name in debug message Date: Sun, 19 Sep 2021 18:59:14 -0300 Message-Id: <20210919215914.539805-8-gascoar@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210919215914.539805-1-gascoar@gmail.com> References: <20210919215914.539805-1-gascoar@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_150642_699176_3D10EEA6 X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Avoid hardcoded function name using "%s", __func__. This prevents potential naming conflict if the function is eventually renamed. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 3225f0738ef9..fcff2e5bd73f 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1025,7 +1025,7 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, spin_unlock(&msg_queue_spinlock); DEBUG_TRACE(SERVICE_CALLBACK_LINE); DEBUG_COUNT(MSG_QUEUE_FULL_COUNT); - vchiq_log_trace(vchiq_arm_log_level, "service_callback - msg queue full"); + vchiq_log_trace(vchiq_arm_log_level, "%s - msg queue full", __func__); /* * If there is no MESSAGE_AVAILABLE in the completion * queue, add one