From patchwork Thu Sep 23 19:08:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 12513573 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5328DC433EF for ; Thu, 23 Sep 2021 19:08:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A4A961211 for ; Thu, 23 Sep 2021 19:08:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242833AbhIWTKL (ORCPT ); Thu, 23 Sep 2021 15:10:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240205AbhIWTKK (ORCPT ); Thu, 23 Sep 2021 15:10:10 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9881C061574 for ; Thu, 23 Sep 2021 12:08:38 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id i25so30431845lfg.6 for ; Thu, 23 Sep 2021 12:08:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=TLST3SPqcGieuCbYOxlGrPHCkSaka+mZR5JFkpnYR30=; b=L8dGdTWJb6H0nbKN+C91nssM6wBlcv9N02s6qAVXBtOM743WdSFZ8jEvm0tm5vczcW 080n1O2KuHRAx8aLq2T7kr3FLnueKg1hNE2IE7wnwDdYOfJFN1u56Wr51FzPjZG+/gST Iu5w57DiuBMoxsBoK0k2+8B1VOZXBdjmR56PQ87eM+p2EezNpPJvZCEILayXjKbw3186 3+jj7htQrl3VO4e1qJavmXwBYnzBvafYZcV3hydSFrDq9E3VXDkAgZolpX8F8cdxHLCT 8gp31yywnc4VwhC2Kj74RWg4Brp3gmrd5lFLf1EIOf1TXKNKRcNDirHSaB1OtXlcY9Sv OmgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=TLST3SPqcGieuCbYOxlGrPHCkSaka+mZR5JFkpnYR30=; b=voZy9J85SAYDWH3fhOrKXyCh9FlmzqEtYeR8uOlUIDYjseyLXsGtC5X7UuaNISrZ/m XzP7Gwc5r/SSQKWTOEAMWh0nMtvvieAknSDUadSKkO1Tis2cwMNQzibmqdKNxV5RLUCE TNFw346brNTpHm0dbrABGhdbiWW9b4iUCI8BkMGeCSsCdvlbjae0HtTghPj0ao1OWXho 3uDEEkEDQKU+zmm755MSLRFdUHD6O+DdYn1M1VnVBysKPuHkfe/CXdIDi4DZl7TUxfIs /xvWVycA7O5S2JqTRMqjvJNves9/JdpCHlhc+1zbxG926UPV+1XJS0kwtc3IMeprasIs qlnQ== X-Gm-Message-State: AOAM5306AKvECuRV0MSZdGpsAX3VLj2ReDXyOwcy5bmBiSPC8U/aEOGq UMhYmPgBpw0QOugjkSz1q5bxXO7wiWuxwB1I/4q0103P X-Google-Smtp-Source: ABdhPJwrjLKArQqYzormlIIscFjxS3ZXuvO3OABegJRQ4dolms3NMJkxuNRVUOZgfeYsYX1MO4NCUuCReEGDEn91O7M= X-Received: by 2002:ac2:44b6:: with SMTP id c22mr5682653lfm.601.1632424116721; Thu, 23 Sep 2021 12:08:36 -0700 (PDT) MIME-Version: 1.0 References: <163214005516.2945267.7000234432243167892.stgit@warthog.procyon.org.uk> In-Reply-To: <163214005516.2945267.7000234432243167892.stgit@warthog.procyon.org.uk> From: Steve French Date: Thu, 23 Sep 2021 14:08:25 -0500 Message-ID: Subject: Fwd: [RFC PATCH] fscache, 9p, afs, cifs, nfs: Deal with some warnings from W=1 To: CIFS , David Howells Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Updated patch (just including the cifs change) to avoid merge conflicts. Tentatively merged into cifs-2.6.git for-next ---------- Forwarded message --------- From: David Howells Date: Mon, Sep 20, 2021 at 9:39 AM Subject: [RFC PATCH] fscache, 9p, afs, cifs, nfs: Deal with some warnings from W=1 To: Cc: Jeff Layton , Dominique Martinet , Marc Dionne , Steve French , Trond Myklebust , Anna Schumaker , Mauro Carvalho Chehab , , , , , , , Deal with some warnings generated from make W=1: (1) Add/remove/fix kerneldoc parameters descriptions. (2) afs_sillyrename() isn't an API functions, so remove the kerneldoc annotation. (3) The fscache object CREATE_OBJECT work state isn't used, so remove it. (4) Move __add_fid() from between v9fs_fid_add() and its comment. (5) 9p's caches_show() doesn't really make sense as an API function, show remove the kerneldoc annotation. It's also not prefixed with 'v9fs_'. (6) Remove the kerneldoc annotation on cifs_match_ipdaddr() as it's not fully documented. (7) Turn cifs' rqst_page_get_length()'s banner comment into a kerneldoc comment. It should probably be prefixed with "cifs_" though. Signed-off-by: David Howells cc: Jeff Layton cc: Dominique Martinet cc: Marc Dionne cc: Steve French cc: Trond Myklebust cc: Anna Schumaker cc: Mauro Carvalho Chehab cc: v9fs-developer@lists.sourceforge.net cc: linux-afs@lists.infradead.org cc: linux-cifs@vger.kernel.org cc: linux-nfs@vger.kernel.org cc: linux-fsdevel@vger.kernel.org cc: linux-doc@vger.kernel.org --- fs/9p/fid.c | 14 +++++++------- fs/9p/v9fs.c | 8 +++----- fs/9p/vfs_addr.c | 13 +++++++++---- fs/9p/vfs_file.c | 33 ++++++++++++--------------------- fs/9p/vfs_inode.c | 24 ++++++++++++++++-------- fs/9p/vfs_inode_dotl.c | 11 +++++++++-- fs/afs/dir_silly.c | 4 ++-- fs/cifs/connect.c | 14 +++++++++++++- fs/cifs/misc.c | 14 ++++++++++++-- fs/fscache/object.c | 2 +- fs/fscache/operation.c | 3 +++ fs/nfs_common/grace.c | 1 - 12 files changed, 87 insertions(+), 54 deletions(-) From 03ab9cb982b622239cc2542ce7617b98a9ea159e Mon Sep 17 00:00:00 2001 From: David Howells Date: Mon, 20 Sep 2021 13:14:15 +0100 Subject: [PATCH] cifs: Deal with some warnings from W=1 Deal with some warnings generated from make W=1: (1) Add/remove/fix kerneldoc parameters descriptions. (2) Turn cifs' rqst_page_get_length()'s banner comment into a kerneldoc comment. It should probably be prefixed with "cifs_" though. Signed-off-by: David Howells Signed-off-by: Steve French --- fs/cifs/misc.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c index 03da00eb7c04..f2916b51652a 100644 --- a/fs/cifs/misc.c +++ b/fs/cifs/misc.c @@ -590,6 +590,7 @@ void cifs_put_writer(struct cifsInodeInfo *cinode) /** * cifs_queue_oplock_break - queue the oplock break handler for cfile + * @cfile: The file to break the oplock on * * This function is called from the demultiplex thread when it * receives an oplock break for @cfile. @@ -1065,6 +1066,9 @@ setup_aio_ctx_iter(struct cifs_aio_ctx *ctx, struct iov_iter *iter, int rw) /** * cifs_alloc_hash - allocate hash and hash context together + * @name: The name of the crypto hash algo + * @shash: Where to put the pointer to the hash algo + * @sdesc: Where to put the pointer to the hash descriptor * * The caller has to make sure @sdesc is initialized to either NULL or * a valid context. Both can be freed via cifs_free_hash(). @@ -1103,6 +1107,8 @@ cifs_alloc_hash(const char *name, /** * cifs_free_hash - free hash and hash context together + * @shash: Where to find the pointer to the hash algo + * @sdesc: Where to find the pointer to the hash descriptor * * Freeing a NULL hash or context is safe. */ @@ -1118,8 +1124,10 @@ cifs_free_hash(struct crypto_shash **shash, struct sdesc **sdesc) /** * rqst_page_get_length - obtain the length and offset for a page in smb_rqst - * Input: rqst - a smb_rqst, page - a page index for rqst - * Output: *len - the length for this page, *offset - the offset for this page + * @rqst: The request descriptor + * @page: The index of the page to query + * @len: Where to store the length for this page: + * @offset: Where to store the offset for this page */ void rqst_page_get_length(struct smb_rqst *rqst, unsigned int page, unsigned int *len, unsigned int *offset) @@ -1152,6 +1160,8 @@ void extract_unc_hostname(const char *unc, const char **h, size_t *len) /** * copy_path_name - copy src path to dst, possibly truncating + * @dst: The destination buffer + * @src: The source name * * returns number of bytes written (including trailing nul) */ -- 2.30.2