From patchwork Mon Sep 27 04:48:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 12519085 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8799BC433FE for ; Mon, 27 Sep 2021 04:49:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6382A610E8 for ; Mon, 27 Sep 2021 04:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232638AbhI0Eus (ORCPT ); Mon, 27 Sep 2021 00:50:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232526AbhI0Euq (ORCPT ); Mon, 27 Sep 2021 00:50:46 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4597C061604 for ; Sun, 26 Sep 2021 21:49:08 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id d13-20020a17090ad3cd00b0019e746f7bd4so9171151pjw.0 for ; Sun, 26 Sep 2021 21:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5Q6nf8LqPhvSki/U84FqSlnRaUL+lc1QseYK12PdV5o=; b=yH7ocNJoNnGbreRdSzpzAaX3MbEHhAM4lHvCdNiZ/rIgjhzwD6JQGTv6FgV/p4A+8c 8duNd3qs3jhMGodK3rkRMxa6CdbZ5LafPySRP5endGozYT0awQKqLlHoEoCoBfrLkdLa xVshzimso3M1rqxe2XdU0OQd8gekKOr6yFKbYlN2eeEekS4xUzp3HkUBhsw521UHEBjZ a9WpSeT7TtgqiQ509ueMLjm1ER/MffOo2Yp9eXl11mT0ecu1S4C1Pre5M09BRI/FuI0M Gn/Vv1/StIe0NGCGnZLeXiCm1R+7DxriXDU0Ekv6aTovlu4zb6hb3IVPcILEvktSY1na Jwng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5Q6nf8LqPhvSki/U84FqSlnRaUL+lc1QseYK12PdV5o=; b=YdER8c9PnIwPG7LiGDJixuJS7S3NOVSrjAYq4J5u/JhFLwaegybKFYJIwbFKoFqjF8 cmkVDo1Yo8pucjxUBvKx+IVyV2vCcVOpmwuQXLP35E8kB9iDVKMSWhwKViMEoQjns/M+ kwBcOHuMFXaymH6qfVX8ArGAqk2OKIXxdYCBHPt+waMRoi4roSrqrBsRrRQnsQrdNIJf tkEN2lQPfPGYxPuICXKOPghDVfVHccwdD5EVKotrvd37QvDu8RZ0MrTyLl7co5vEzoOU ojy60pR0afXKOQ7y9fgQJzHb2CgwZbjf75w+v/H+iwsnJ9nsFFCippWuc8yOlOlaV9YW DVaA== X-Gm-Message-State: AOAM533FtlQKMLzwPZFv4PfkEu6Y1ITdDOKUdrNiFPGVU+M63GaZQ7vg uwXlmSNasxtxgyttboCK826VWA== X-Google-Smtp-Source: ABdhPJwkzSU4ZWtYPxP/n0kCmKKaF1DQSnpTU9fLFUk9N7cPC2nX2IGuA4LOp1p3/jcmrw0WzdKAnQ== X-Received: by 2002:a17:902:934c:b0:13d:c685:229b with SMTP id g12-20020a170902934c00b0013dc685229bmr20786774plp.25.1632718148423; Sun, 26 Sep 2021 21:49:08 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id o8sm14550651pjh.19.2021.09.26.21.49.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 21:49:08 -0700 (PDT) From: Shawn Guo To: Vinod Koul , Bjorn Andersson Cc: Manu Gautam , AngeloGioacchino Del Regno , Konrad Dybcio , Jeffrey Hugo , Jami Kettunen , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH 1/3] dt-bindings: phy: qcom,qusb2: Add missing vdd-supply Date: Mon, 27 Sep 2021 12:48:22 +0800 Message-Id: <20210927044824.30246-2-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210927044824.30246-1-shawn.guo@linaro.org> References: <20210927044824.30246-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Besides vdda-pll and vdda-phy-dpdm, vdd-supply is a required supply for PHY digital circuit operation. Add it for correctness and completeness. Signed-off-by: Shawn Guo --- Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml index 48ae604b2194..96e31f582fc9 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml @@ -51,6 +51,10 @@ properties: - const: ref - const: iface + vdda-supply: + description: + Phandle to 0.9V regulator supply to PHY digital circuit. + vdda-pll-supply: description: Phandle to 1.8V regulator supply to PHY refclk pll block. @@ -157,6 +161,7 @@ required: - "#phy-cells" - clocks - clock-names + - vdd-supply - vdda-pll-supply - vdda-phy-dpdm-supply - resets @@ -175,6 +180,7 @@ examples: <&gcc GCC_RX1_USB2_CLKREF_CLK>; clock-names = "cfg_ahb", "ref"; + vdd-supply = <&pm8994_l28>; vdda-pll-supply = <&pm8994_l12>; vdda-phy-dpdm-supply = <&pm8994_l24>; From patchwork Mon Sep 27 04:48:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 12519087 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19285C433FE for ; Mon, 27 Sep 2021 04:49:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2357610E8 for ; Mon, 27 Sep 2021 04:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232663AbhI0Euv (ORCPT ); Mon, 27 Sep 2021 00:50:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232614AbhI0Eut (ORCPT ); Mon, 27 Sep 2021 00:50:49 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A14FC061570 for ; Sun, 26 Sep 2021 21:49:12 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id x4so3413456pln.5 for ; Sun, 26 Sep 2021 21:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yqut9De+8qKtl1UwHb70hm3Lp+Eib/4T+4ZznburE20=; b=B+jaGLcWqs5eaW1Zz7HJ5ZpRIcABigLjJ8jgI3gc+6UyUZjhZznJvDGZwWows5qK7f cY/lLDnR9u0gryCmklGfZBYrI7DA0WpJeIrw8jHh+0et3FA5mJ8LC31xZR7ioYrI/NUq tJ6umUpk+UlGiqx5W3/We8pZNrxG49sAft3lpk83nZXxMtBnyjML+dBv0529ys2RMu8Q kKOgczBrg52oLdBTPR4HkyjZQ+UVbbc+mqikypJ9EBAn9wsipLagu2FmLMOU33KKOFr0 jOZRMvpfhgLTnkcII6Fo+jOEGRFt+8Sua16G5fhS2ehhza9fmiYA6YdAoI/3a0lpSUuG OKPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yqut9De+8qKtl1UwHb70hm3Lp+Eib/4T+4ZznburE20=; b=D0iWHrLRIQtul5HPQVsHovQ73XRxBaPWBmZk0Ihp0TyEDlwGJnHnlx9QtWl1n9IyUb NM/V0fwT55dCLXxOxsLqXnu2zTcHLnkpNGUU2z7MT2lULfOIR9fYPg30A8LfbemwjHGg CV9rUbk0SqbVPzieBdSuys8RA4CesbL0hekoMWnT8CVT+Sobg4r9PJKC2LHoQVoC3Rkh b2HU1EPJ6GWjIHFeqVzobIiT7v5iu6SVyxstZpR4FJmFtFqs+bXabX0b1bF4ef8Ck9ZG sqm/pugMHSu3VbZKBUebsz8i23PVz3B70RNyEig2trl+r7IX0qGu5e575Wncw4UVSlCp i2iA== X-Gm-Message-State: AOAM532wpFDInOikFIpqjy2vTH80mHVfMNOtDWWuXAM9/yF0IMt62Ko6 34XPtQFEZtoDfylJbOUKV+Lwcg== X-Google-Smtp-Source: ABdhPJzMdnW6OyUR+AHbSPpIu8fhtS0rEKQu96QW1RDDYE24xE1zJyIXGuqw/N9ORjpMtMCsdJWKkg== X-Received: by 2002:a17:902:d34d:b0:13e:25e6:f732 with SMTP id l13-20020a170902d34d00b0013e25e6f732mr4337542plk.58.1632718151608; Sun, 26 Sep 2021 21:49:11 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id o8sm14550651pjh.19.2021.09.26.21.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 21:49:11 -0700 (PDT) From: Shawn Guo To: Vinod Koul , Bjorn Andersson Cc: Manu Gautam , AngeloGioacchino Del Regno , Konrad Dybcio , Jeffrey Hugo , Jami Kettunen , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH 2/3] phy: qcom-qusb2: Add missing vdd supply Date: Mon, 27 Sep 2021 12:48:23 +0800 Message-Id: <20210927044824.30246-3-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210927044824.30246-1-shawn.guo@linaro.org> References: <20210927044824.30246-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Per downstream kernel, beside vdda-pll and vdda-phy-dpdm, vdd is also a required supply for QUSB2 PHY digital circuit operation. The driver works right now likely because firmware already sets it up. Add it for correctness and completeness. Signed-off-by: Shawn Guo --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c index ae063a8b3e28..7a8e4333babe 100644 --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c @@ -371,7 +371,7 @@ static const struct qusb2_phy_cfg sm6115_phy_cfg = { }; static const char * const qusb2_phy_vreg_names[] = { - "vdda-pll", "vdda-phy-dpdm", + "vdd", "vdda-pll", "vdda-phy-dpdm", }; #define QUSB2_NUM_VREGS ARRAY_SIZE(qusb2_phy_vreg_names) From patchwork Mon Sep 27 04:48:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 12519089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF01BC433FE for ; Mon, 27 Sep 2021 04:49:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D68C06115C for ; Mon, 27 Sep 2021 04:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232673AbhI0Eu4 (ORCPT ); Mon, 27 Sep 2021 00:50:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232654AbhI0Eux (ORCPT ); Mon, 27 Sep 2021 00:50:53 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77AB8C061765 for ; Sun, 26 Sep 2021 21:49:15 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id m21so16562510pgu.13 for ; Sun, 26 Sep 2021 21:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KEllPcS5Xq9Pyinz9uhBulFqCz5TInIHturtjFlsWfM=; b=WM2EeIm1wj8U7p3dSs4qT1PBkVz95JLECHhhF76wdghwMNg0xNB2164OkwndSL6yFy ur6UlW4JHnNVOkf66Lny3SA+LVU3RiiwUp89aiT7fV5ytTRM/yAKQpDBZBhF+EfQhgjx lp9s+Fxo/090Xkf7r1hOGAhxW4DgznTqwvVbJdfNatbeWO8O4qxO4djgj1KRKtIkzMVb iWD+KrDhsFw4mAzDjlkl2j8FRSbZT4wL0uJhcJkCKfgJdqFziFLz/MF7+7G3cA5sAe41 8sRv5yZIadb6pjbbwP4pC+SOqBEcltI8WLmeJyS4wUXrQnotTiLCx74jGROSGaQshpys MDLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KEllPcS5Xq9Pyinz9uhBulFqCz5TInIHturtjFlsWfM=; b=ltpkHcSXBIHHpIx0bSXAznUwSt1kgffx0kbYR0tZ3kdQuMXc7U3cnAWwYbr6xAOm0l RBU5vd3d/aUesBsrn9RuV+JPj0sGjRJk0dFp7SgoKT5ybGbpIY2Fc0eknrKIQhaEl8os EBcOKTFppSuggZQitmxF3czq8y18dgXsQUWhHlcabfGYLxvhoIJ4mozX6A5ILpbPHHjB /xGusu8kF5nFsu/YMdmTfsh4Q3L96V4saPchOPE4JYjQyKwXAlqG5M6Sh1uPYVBcc0/9 Rlpf6dS+IoOMoIUb+34iPZ87QII2N5yzaK0TPz4R6D/AFMZ148kO6KK33KxWnwrnDcPV yFgw== X-Gm-Message-State: AOAM533qXHztvuc5RFRYcomlTBcSQcS/o4J3lMoaEOWyAeLLJGxiv0Ka 7RLuyb1F0y+burN23y5B0TOUkQ== X-Google-Smtp-Source: ABdhPJz6318vaYRozdHnWkfE6r+tiX+DIdW2eKCEVjnV+8J6EOsiAgQ4pN3xc8K+59T8+3apfAllAw== X-Received: by 2002:a62:5584:0:b0:44b:62ec:1ac1 with SMTP id j126-20020a625584000000b0044b62ec1ac1mr13348937pfb.2.1632718155039; Sun, 26 Sep 2021 21:49:15 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id o8sm14550651pjh.19.2021.09.26.21.49.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 21:49:14 -0700 (PDT) From: Shawn Guo To: Vinod Koul , Bjorn Andersson Cc: Manu Gautam , AngeloGioacchino Del Regno , Konrad Dybcio , Jeffrey Hugo , Jami Kettunen , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH 3/3] arm64: dts: qcom: Add missing vdd-supply for QUSB2 PHY Date: Mon, 27 Sep 2021 12:48:24 +0800 Message-Id: <20210927044824.30246-4-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210927044824.30246-1-shawn.guo@linaro.org> References: <20210927044824.30246-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org QUSB2 PHY requires vdd-supply for digital circuit operation. Add it for platforms that miss it. Signed-off-by: Shawn Guo --- arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 2 ++ arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi | 1 + 4 files changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi index 51e17094d7b1..d9826ce27e50 100644 --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi @@ -230,6 +230,7 @@ &hsusb_phy1 { status = "okay"; + vdd-supply = <&vreg_l28a_0p925>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; }; @@ -237,6 +238,7 @@ &hsusb_phy2 { status = "okay"; + vdd-supply = <&vreg_l28a_0p925>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; }; diff --git a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi index 507396c4d23b..61ea6d4ef8ac 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi @@ -184,6 +184,7 @@ &hsusb_phy1 { status = "okay"; + vdd-supply = <&pm8994_l28>; vdda-pll-supply = <&pm8994_l12>; vdda-phy-dpdm-supply = <&pm8994_l24>; }; diff --git a/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi b/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi index 125d7923d713..4f823974559b 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi @@ -102,6 +102,7 @@ &qusb2phy { status = "okay"; + vdd-supply = <&vreg_l1a_0p875>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; }; diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi index 0f5c7828a901..243f4ee5da8c 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi @@ -260,6 +260,7 @@ &qusb2phy { status = "okay"; + vdd-supply = <&vreg_l1a_0p875>; vdda-pll-supply = <&vreg_l12a_1p8>; vdda-phy-dpdm-supply = <&vreg_l24a_3p075>; };