From patchwork Wed Dec 12 00:27:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Tan X-Patchwork-Id: 10725357 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 22E8D1751 for ; Wed, 12 Dec 2018 00:28:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 119122B3AC for ; Wed, 12 Dec 2018 00:28:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 063712B3E3; Wed, 12 Dec 2018 00:28:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 479B62B3AC for ; Wed, 12 Dec 2018 00:28:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726240AbeLLA2J (ORCPT ); Tue, 11 Dec 2018 19:28:09 -0500 Received: from mail-qk1-f202.google.com ([209.85.222.202]:36838 "EHLO mail-qk1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbeLLA2J (ORCPT ); Tue, 11 Dec 2018 19:28:09 -0500 Received: by mail-qk1-f202.google.com with SMTP id h68so14719995qke.3 for ; Tue, 11 Dec 2018 16:28:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=mN4BgtUBZ4FvzSrh9D4SUZoioucnkAFI6BA+YHYFnyo=; b=LplTsu9Nj4eBwyvtRKj9kPKqbwqO6tZQ1rVZOK8YDV9QV0cR6klTxEtlfqSWzlIjvM FUzwjY3W37fAtNCp3iaN2BC+9CyX3lULSAv/0oV06gWkdWoM+qp2FBIqAHnimZVXrroT K1qLmAfnPRiCPv7DnA8iwKpWKB+CDt6B9sjHxoVEEICGJphzwhYxLWJso7oHEItqsXiR DGekXC17DeHE8nPYJQTEDi9pjbufu8zVW2X1H+hwAG5vWv6sFZZkiI4o3iOwjq5U+Bvw oNu2+AYpSLdthcPOjCYiKEr6zTCnWxCfHy0RQrStLrnmDGfQZT1RlkoznoFL4uWZMbiZ 0fDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=mN4BgtUBZ4FvzSrh9D4SUZoioucnkAFI6BA+YHYFnyo=; b=OQfJJC05zHrKMdG1BWiJ5laSHE1KdAkerekHl0FlOHGEYv6PMdJ1/OyK13r8H3WQXg 0sz0P+cgAcg/3nw25pmpAu9DN0wwxZbN51uqVd8aXEYv4g5HON+BxclCA142QP/LuT1J aPIr5peJyF3bLXxHF7/gFek2Q2OO3klg7d0853PjL1Y+quRTzI5ojIY/Heuo2rvXDSVG bd1WPvzIUxcoaNGfFOKI4MDop93BEfm34KOvlog4AX2AoxUozGtukhwPv6fjpAk4uiLr KIal26y1XgYBHTjLkeqVMeGanTKbIsJyCtW23yh8WGvBkH9yuCffY2fZ6/bpOqFEuACn bjuA== X-Gm-Message-State: AA+aEWZ2zS8v47VwUIg6lruTW/+XD6BNL9ZUMKjFePMuOAnjtjWoFC9r EkdukKPf04W9YYcYrjfIeHpXG8wrCHgP1z7DnJO57Ezr4p6IQfZMS0gx5Yh50ykaB4IOYQMjyFj SmfTa/Gk+Xcx6k9jSHz4wFAJoPhp9H899BBhYpGX5q6aHPVIfCWtxdsD1Yw3+/acqxcoamhNF89 Tc X-Google-Smtp-Source: AFSGD/VV01EV1npHZ8XC1ZKZvRPczolk6FbBvUHZ9V/ktV182J/t1si8kD883kOo2hzZrcx00uBNobO5FAMUFIjMlDq5 X-Received: by 2002:ac8:2a78:: with SMTP id l53mr13741642qtl.44.1544574487014; Tue, 11 Dec 2018 16:28:07 -0800 (PST) Date: Tue, 11 Dec 2018 16:27:56 -0800 In-Reply-To: Message-Id: <33bae6445998e4928aa45c15726667590947c422.1544573604.git.jonathantanmy@google.com> Mime-Version: 1.0 References: <20181211212135.21126-2-avarab@gmail.com> X-Mailer: git-send-email 2.19.0.271.gfe8321ec05.dirty Subject: [PATCH 1/3] squash this into your patch From: Jonathan Tan To: git@vger.kernel.org Cc: Jonathan Tan , avarab@gmail.com, peff@peff.net Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Jonathan Tan --- t/t5539-fetch-http-shallow.sh | 12 ++++++++---- t/t5541-http-push-smart.sh | 10 ++++++++-- t/t5551-http-fetch-smart.sh | 23 +++++++++++++++-------- t/t5570-git-daemon.sh | 2 +- 4 files changed, 32 insertions(+), 15 deletions(-) diff --git a/t/t5539-fetch-http-shallow.sh b/t/t5539-fetch-http-shallow.sh index 5fbf67c446..996ce060cd 100755 --- a/t/t5539-fetch-http-shallow.sh +++ b/t/t5539-fetch-http-shallow.sh @@ -67,7 +67,8 @@ test_expect_success 'no shallow lines after receiving ACK ready' ' cd clone && git checkout --orphan newnew && test_commit new-too && - GIT_TRACE_PACKET="$TRASH_DIRECTORY/trace" git fetch --depth=2 && + GIT_TRACE_PACKET="$TRASH_DIRECTORY/trace" env --unset=GIT_TEST_PROTOCOL_VERSION \ + git fetch --depth=2 && grep "fetch-pack< ACK .* ready" ../trace && ! grep "fetch-pack> done" ../trace ) @@ -114,7 +115,8 @@ test_expect_success 'shallow clone exclude tag two' ' ' test_expect_success 'fetch exclude tag one' ' - git -C shallow12 fetch --shallow-exclude one origin && + env --unset=GIT_TEST_PROTOCOL_VERSION \ + git -C shallow12 fetch --shallow-exclude one origin && git -C shallow12 log --pretty=tformat:%s origin/master >actual && test_write_lines three two >expected && test_cmp expected actual @@ -128,14 +130,16 @@ test_expect_success 'fetching deepen' ' test_commit two && test_commit three && mv .git "$HTTPD_DOCUMENT_ROOT_PATH/shallow-deepen.git" && - git clone --depth 1 $HTTPD_URL/smart/shallow-deepen.git deepen && + env --unset=GIT_TEST_PROTOCOL_VERSION \ + git clone --depth 1 $HTTPD_URL/smart/shallow-deepen.git deepen && mv "$HTTPD_DOCUMENT_ROOT_PATH/shallow-deepen.git" .git && test_commit four && git -C deepen log --pretty=tformat:%s master >actual && echo three >expected && test_cmp expected actual && mv .git "$HTTPD_DOCUMENT_ROOT_PATH/shallow-deepen.git" && - git -C deepen fetch --deepen=1 && + env --unset=GIT_TEST_PROTOCOL_VERSION \ + git -C deepen fetch --deepen=1 && git -C deepen log --pretty=tformat:%s origin/master >actual && cat >expected <<-\EOF && four diff --git a/t/t5541-http-push-smart.sh b/t/t5541-http-push-smart.sh index 5475afc052..20f1308578 100755 --- a/t/t5541-http-push-smart.sh +++ b/t/t5541-http-push-smart.sh @@ -45,14 +45,20 @@ test_expect_success 'no empty path components' ' # In the URL, add a trailing slash, and see if git appends yet another # slash. cd "$ROOT_PATH" && - git clone $HTTPD_URL/smart/test_repo.git/ test_repo_clone && + # Other protocol versions may make different requests, so perform this + # clone with protocol v0. + env --unset=GIT_TEST_PROTOCOL_VERSION \ + git clone $HTTPD_URL/smart/test_repo.git/ test_repo_clone && check_access_log exp ' test_expect_success 'clone remote repository' ' rm -rf test_repo_clone && - git clone $HTTPD_URL/smart/test_repo.git test_repo_clone && + # Other protocol versions may make different requests, so perform this + # clone with protocol v0. + env --unset=GIT_TEST_PROTOCOL_VERSION \ + git clone $HTTPD_URL/smart/test_repo.git test_repo_clone && ( cd test_repo_clone && git config push.default matching ) diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh index 8630b0cc39..56fd9351a6 100755 --- a/t/t5551-http-fetch-smart.sh +++ b/t/t5551-http-fetch-smart.sh @@ -43,7 +43,8 @@ test_expect_success 'clone http repository' ' < Cache-Control: no-cache, max-age=0, must-revalidate < Content-Type: application/x-git-upload-pack-result EOF - GIT_TRACE_CURL=true git clone --quiet $HTTPD_URL/smart/repo.git clone 2>err && + GIT_TRACE_CURL=true env --unset=GIT_TEST_PROTOCOL_VERSION \ + git clone --quiet $HTTPD_URL/smart/repo.git clone 2>err && test_cmp file clone/file && tr '\''\015'\'' Q >file && git commit -a -m two && git push public && - (cd clone && git pull) && + (cd clone && env --unset=GIT_TEST_PROTOCOL_VERSION git pull) && test_cmp file clone/file ' @@ -143,7 +144,8 @@ test_expect_success 'clone from auth-only-for-push repository' ' test_expect_success 'clone from auth-only-for-objects repository' ' echo two >expect && set_askpass user@host pass@host && - git clone --bare "$HTTPD_URL/auth-fetch/smart/repo.git" half-auth && + env --unset=GIT_TEST_PROTOCOL_VERSION \ + git clone --bare "$HTTPD_URL/auth-fetch/smart/repo.git" half-auth && expect_askpass both user@host && git --git-dir=half-auth log -1 --format=%s >actual && test_cmp expect actual @@ -151,7 +153,8 @@ test_expect_success 'clone from auth-only-for-objects repository' ' test_expect_success 'no-op half-auth fetch does not require a password' ' set_askpass wrong && - git --git-dir=half-auth fetch && + env --unset=GIT_TEST_PROTOCOL_VERSION \ + git --git-dir=half-auth fetch && expect_askpass none ' @@ -187,7 +190,8 @@ test_expect_success 'create namespaced refs' ' ' test_expect_success 'smart clone respects namespace' ' - git clone "$HTTPD_URL/smart_namespace/repo.git" ns-smart && + env --unset=GIT_TEST_PROTOCOL_VERSION \ + git clone "$HTTPD_URL/smart_namespace/repo.git" ns-smart && echo namespaced >expect && git --git-dir=ns-smart/.git log -1 --format=%s >actual && test_cmp expect actual @@ -214,7 +218,8 @@ test_expect_success 'cookies stored in http.cookiefile when http.savecookies set EOF git config http.cookiefile cookies.txt && git config http.savecookies true && - git ls-remote $HTTPD_URL/smart_cookies/repo.git master && + env --unset=GIT_TEST_PROTOCOL_VERSION \ + git ls-remote $HTTPD_URL/smart_cookies/repo.git master && tail -3 cookies.txt | sort >cookies_tail.txt && test_cmp expect_cookies.txt cookies_tail.txt ' @@ -306,7 +311,8 @@ test_expect_success 'test allowreachablesha1inwant with unreachable' ' git init --bare test_reachable.git && git -C test_reachable.git remote add origin "$HTTPD_URL/smart/repo.git" && - test_must_fail git -C test_reachable.git fetch origin "$(git rev-parse HEAD)" + test_must_fail env --unset=GIT_TEST_PROTOCOL_VERSION \ + git -C test_reachable.git fetch origin "$(git rev-parse HEAD)" ' test_expect_success 'test allowanysha1inwant with unreachable' ' @@ -325,7 +331,8 @@ test_expect_success 'test allowanysha1inwant with unreachable' ' git init --bare test_reachable.git && git -C test_reachable.git remote add origin "$HTTPD_URL/smart/repo.git" && - test_must_fail git -C test_reachable.git fetch origin "$(git rev-parse HEAD)" && + test_must_fail env --unset=GIT_TEST_PROTOCOL_VERSION \ + git -C test_reachable.git fetch origin "$(git rev-parse HEAD)" && git -C "$server" config uploadpack.allowanysha1inwant 1 && git -C test_reachable.git fetch origin "$(git rev-parse HEAD)" diff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh index 7466aad111..4a2a937bb0 100755 --- a/t/t5570-git-daemon.sh +++ b/t/t5570-git-daemon.sh @@ -190,7 +190,7 @@ test_expect_success 'daemon log records all attributes' ' EOF >daemon.log && GIT_OVERRIDE_VIRTUAL_HOST=localhost \ - git -c protocol.version=1 \ + env --unset=GIT_TEST_PROTOCOL_VERSION git -c protocol.version=1 \ ls-remote "$GIT_DAEMON_URL/interp.git" && grep -i extended.attribute daemon.log | cut -d" " -f2- >actual && test_cmp expect actual From patchwork Wed Dec 12 00:27:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Tan X-Patchwork-Id: 10725361 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A9602112E for ; Wed, 12 Dec 2018 00:28:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9914E2B3AC for ; Wed, 12 Dec 2018 00:28:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8D8EE2B3E3; Wed, 12 Dec 2018 00:28:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 375ED2B3AC for ; Wed, 12 Dec 2018 00:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726248AbeLLA2M (ORCPT ); Tue, 11 Dec 2018 19:28:12 -0500 Received: from mail-yb1-f201.google.com ([209.85.219.201]:40545 "EHLO mail-yb1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbeLLA2K (ORCPT ); Tue, 11 Dec 2018 19:28:10 -0500 Received: by mail-yb1-f201.google.com with SMTP id i15-v6so10716047ybp.7 for ; Tue, 11 Dec 2018 16:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=AYod6JPQO4bReuwQzGcTE4hHgdq++Ph1Uub7o1mqHqk=; b=U8w6OFLJx3WRIqy+pOtVwaiVlEU5Tl5pG5C1k4IKpmoy4va5MwQROLOqFJlh3jyDkP vYHaDrp865iy/olujDdPOeRuIxDgFMYMjamxjFFZfL5smnPO0aYddSrHWW8dxkZbHOV5 VFrsd4VcTlX0RitRep8F36VRTk/djew57fMGAPEAHoufsRrIP3nBmdWGK5sBoP0VtTDT D17IEzxUDpqDOiE645XTusaygv6n3rbrjrPEckKBB8a+YttLd6YxFcqfvIC7fJUIoE21 uZ8eWy/Vnyf7/O76fyDj+b8etLHf8GTcfZiCYCxr1fdzMH6DMx8uFiNEkmAVru0HY9Lx 9TPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=AYod6JPQO4bReuwQzGcTE4hHgdq++Ph1Uub7o1mqHqk=; b=d/hIDhx3OAKqJpFF+ku6imJ86X267GDu7NiK/FVrOwjUU0mTLHD/F/DHeMSNBLdzuw A9hjh6x5S4Bqvsgj2WjIi52/QiKJMxHspZTrQ3rUHDsIWTT41N0HzRdv6y5ZLjtcfmUN aFEQwHVINlGYkdL+bSxY7z2fRktqUSzJg0ychPwV3+/KERHriMLQkHxKDdtbN56UgFqe toRS87fkFKGSjRbg1GRC9cCGCSMzAjUVnNnAafD0ALJmJy0zPQ4jDPpkwblQqxjtRtGF /M8B+C8h/VWkVf6m4S5CESDM4fkWEfacINz9rgtOFKsY/8AvRzz2HIcylw0Sfg7RVhTM gyEA== X-Gm-Message-State: AA+aEWY0W56TOE8ipDXrKNLzxCl5lEOzRkHf5UTd+8hdYkDdGpKwHXc+ hk37wZitSAEMkLH6J4Bnp/MMmzCLm3V+8NHly/dwvWxw73zQH1Z/TrEp3FF83UMnHRC/thB9UYU vronLfK3FkLSFD8XLzG07BbVeGi3p6CAVku3+ex/7sKmvCBGZZkQMHrXo7GuTVi+hS6QC4Z2v/Q 4S X-Google-Smtp-Source: AFSGD/U7CwJgWWlJlVDyj9qRwF7BRwZKYwkTO9iozVid+638jAKiAKCn9b8ME2C2Jjg9B9/uSaptKvZT8ta3vfDHBtNu X-Received: by 2002:a25:b945:: with SMTP id s5-v6mr10530495ybm.63.1544574489222; Tue, 11 Dec 2018 16:28:09 -0800 (PST) Date: Tue, 11 Dec 2018 16:27:57 -0800 In-Reply-To: Message-Id: Mime-Version: 1.0 References: <20181211212135.21126-2-avarab@gmail.com> X-Mailer: git-send-email 2.19.0.271.gfe8321ec05.dirty Subject: [PATCH 2/3] builtin/fetch-pack: support protocol version 2 From: Jonathan Tan To: git@vger.kernel.org Cc: Jonathan Tan , avarab@gmail.com, peff@peff.net Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, if support for running Git's entire test suite with protocol v2 were added, some tests would fail because the fetch-pack CLI command dies if it encounters protocol v2. To avoid this, teach fetch-pack support for protocol v2. Signed-off-by: Jonathan Tan --- builtin/fetch-pack.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c index 63e69a5801..f6a513495e 100644 --- a/builtin/fetch-pack.c +++ b/builtin/fetch-pack.c @@ -55,6 +55,7 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix) struct oid_array shallow = OID_ARRAY_INIT; struct string_list deepen_not = STRING_LIST_INIT_DUP; struct packet_reader reader; + enum protocol_version version; fetch_if_missing = 0; @@ -219,9 +220,11 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix) PACKET_READ_CHOMP_NEWLINE | PACKET_READ_GENTLE_ON_EOF); - switch (discover_version(&reader)) { + version = discover_version(&reader); + switch (version) { case protocol_v2: - die("support for protocol v2 not implemented yet"); + get_remote_refs(fd[1], &reader, &ref, 0, NULL, NULL); + break; case protocol_v1: case protocol_v0: get_remote_heads(&reader, &ref, 0, NULL, &shallow); @@ -231,7 +234,7 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix) } ref = fetch_pack(&args, fd, conn, ref, dest, sought, nr_sought, - &shallow, pack_lockfile_ptr, protocol_v0); + &shallow, pack_lockfile_ptr, version); if (pack_lockfile) { printf("lock %s\n", pack_lockfile); fflush(stdout); From patchwork Wed Dec 12 00:27:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Tan X-Patchwork-Id: 10725359 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 778481751 for ; Wed, 12 Dec 2018 00:28:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6689D2B3AC for ; Wed, 12 Dec 2018 00:28:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5AE632B3E3; Wed, 12 Dec 2018 00:28:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBC482B3AC for ; Wed, 12 Dec 2018 00:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726254AbeLLA2N (ORCPT ); Tue, 11 Dec 2018 19:28:13 -0500 Received: from mail-yb1-f202.google.com ([209.85.219.202]:33585 "EHLO mail-yb1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726241AbeLLA2M (ORCPT ); Tue, 11 Dec 2018 19:28:12 -0500 Received: by mail-yb1-f202.google.com with SMTP id 71so1227962ybl.0 for ; Tue, 11 Dec 2018 16:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=cco+aX2k3xjHNJc2XrfLGcjMlpuGltb1Uy9Q+8bLsEg=; b=e2LCPBT0rPcAKuh3QRS3wI+ducqyjl17usRW4/1YwEFBdBcOUyo2+/2OQLGrNqLDa0 JB4cBxh03Os3+1sqX37M+vDi9k0LHnQHPvNVgJDjTePNlRYyyMdbdHqK/IXbrt2mJ9Aa l18zTQKlfVrbOwKse7mBC1qcSxwfRds0S9CdR90fGNFQseDIHuLEPWwCNlL4SlDomZfB n1HGhXX2ErsR7L+G6OaOOsxmROBkmtigxJt17gdsmbGZopbweDOXBoYz+UYMX9vveJAf ahcvGhdPKDuFMRQdkVR+U+0tv0SBWoX9YmMbCOFXF5Goi6ta1mYwa69Jgx/CkwwRptK1 8dBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=cco+aX2k3xjHNJc2XrfLGcjMlpuGltb1Uy9Q+8bLsEg=; b=euuAVd1LrMTVGV7xuhTCKsQwM0wZHefSEWhGKRK19WJxIC7udhedQN0hxny65Y0W9e GqqLsHu3YGg6wRvvbL6pjjHpFAO7CaQS9qy9N0nTvqK2BSuGmYVatvlxveQ+tIpKE1Rt AyGqnXEXF8v7aSCt1fPGEcBlXaWSHiHjAc1TO24GkhsjSbE0yB0wtcD4iNr8CRITRxI2 qt/dluMF2Chdj9XiWVriRBSJs9j/JLzWO9mmLEb2s4Du+aIvO0gNVq2SS5uuvg5IgXU6 ehV/l/i3A0VQYjJKOmNNXcMBCiFVfncnqkx2vtgFFcQ7WXPTsbGkKwFKi390J36FjnJb BaRA== X-Gm-Message-State: AA+aEWZ1LuK9qHTTOSiLv48R9GCztzE748CD8PepnQTsY3j/jOtldqyH toK3YrpdFnjL1zjXH9qKwHMpTvaxh7yr+bG+K78D6BjQW3a41AG8JPonF64VbYCy6JMqWUWbGwb chzrj9nDJ6a+sM+NYApK3ukneSgHw8IUOamW4K4fShDiDuZyeMNs0HzIJpI4VG1849vqoXXIJ2f tC X-Google-Smtp-Source: AFSGD/VVLXxIwMcVMZYsZ+9s6IS2v3rECfi0Oh+p5l5YMrXGijIwoEiYQ2Mw/rRv63KCU/IP8WbMSq3v7y5K8/cN8/BW X-Received: by 2002:a81:9195:: with SMTP id i143mr11112235ywg.6.1544574491641; Tue, 11 Dec 2018 16:28:11 -0800 (PST) Date: Tue, 11 Dec 2018 16:27:58 -0800 In-Reply-To: Message-Id: <378905b2ce5790cb406b950a3be530859368b1fe.1544573604.git.jonathantanmy@google.com> Mime-Version: 1.0 References: <20181211212135.21126-2-avarab@gmail.com> X-Mailer: git-send-email 2.19.0.271.gfe8321ec05.dirty Subject: [PATCH 3/3] also squash this into your patch From: Jonathan Tan To: git@vger.kernel.org Cc: Jonathan Tan , avarab@gmail.com, peff@peff.net Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Jonathan Tan --- t/t5500-fetch-pack.sh | 13 +++++++------ t/t5616-partial-clone.sh | 3 +-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/t/t5500-fetch-pack.sh b/t/t5500-fetch-pack.sh index 9c18875c9c..a5a8f348a2 100755 --- a/t/t5500-fetch-pack.sh +++ b/t/t5500-fetch-pack.sh @@ -41,8 +41,7 @@ pull_to_client () { test_expect_success "$number pull" ' ( cd client && - GIT_TEST_PROTOCOL_VERSION=0 \ - git fetch-pack -k -v .. $heads && + git fetch-pack -k -v .. $heads && case "$heads" in *A*) @@ -441,7 +440,6 @@ test_expect_success 'setup tests for the --stdin parameter' ' ' test_expect_success 'fetch refs from cmdline' ' - sane_unset GIT_TEST_PROTOCOL_VERSION && ( cd client && git fetch-pack --no-progress .. $(cat ../input) @@ -630,7 +628,10 @@ test_expect_success 'fetch-pack cannot fetch a raw sha1 that is not advertised a test_commit -C server 6 && git init client && - test_must_fail git -C client fetch-pack ../server \ + + # Other protocol versions (e.g. 2) allow fetching an unadvertised + # object, so run this test with the default protocol version (0). + test_must_fail env --unset=GIT_TEST_PROTOCOL_VERSION git -C client fetch-pack ../server \ $(git -C server rev-parse refs/heads/master^) 2>err && test_i18ngrep "Server does not allow request for unadvertised object" err ' @@ -790,7 +791,7 @@ test_expect_success 'shallow clone exclude tag two' ' ' test_expect_success 'fetch exclude tag one' ' - git -C shallow12 fetch --shallow-exclude one origin && + env --unset=GIT_TEST_PROTOCOL_VERSION git -C shallow12 fetch --shallow-exclude one origin && git -C shallow12 log --pretty=tformat:%s origin/master >actual && test_write_lines three two >expected && test_cmp expected actual @@ -808,7 +809,7 @@ test_expect_success 'fetching deepen' ' git -C deepen log --pretty=tformat:%s master >actual && echo three >expected && test_cmp expected actual && - git -C deepen fetch --deepen=1 && + env --unset=GIT_TEST_PROTOCOL_VERSION git -C deepen fetch --deepen=1 && git -C deepen log --pretty=tformat:%s origin/master >actual && cat >expected <<-\EOF && four diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh index feedf84ce1..336f02a41a 100755 --- a/t/t5616-partial-clone.sh +++ b/t/t5616-partial-clone.sh @@ -144,8 +144,7 @@ test_expect_success 'manual prefetch of missing objects' ' sort >observed.oids && test_line_count = 6 observed.oids && - GIT_TEST_PROTOCOL_VERSION=0 \ - git -C pc1 fetch-pack --stdin "file://$(pwd)/srv.bare" revs &&