From patchwork Tue Oct 19 06:52:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12568769 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7402C433EF for ; Tue, 19 Oct 2021 06:53:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86ADC61177 for ; Tue, 19 Oct 2021 06:53:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 86ADC61177 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 10D536E8A5; Tue, 19 Oct 2021 06:53:06 +0000 (UTC) Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 302666E12E for ; Tue, 19 Oct 2021 06:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1634626376; x=1666162376; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LEsOShHi53FwhvjjCf5twbUdvETtYuAw3EERG3UwX5A=; b=UDMxrO0nAnw7B8+kZvAZ6z3OeAQYwF8z7TQ0t3HOJHNzzbecc9oAJRxX Z4ap3melHRnz0uFNWqrmeuLW78M11mkGj5JEslU/5JojzL+abUzr5+q+3 va11s9dnCmVGGKrW3NXsB9ogg72yJzjXvdBo8obfsP1Ck+v4QlYeQVlst Hgq/F8DdtJ8/KTPJzbIvHGl32vypYKQTNSf6EqyA7GMFmJHS6he9fG+QN hhWDp/lJWp0IOMyzgA0/ibZgmdVPGhe+ZL08RMGBloSWlmJQMBPV0M/z9 JrU/MtowkqyL0ieP/3TlNPBRHPAmGKZR8LczxJ7dRVzYJ9R8+iEcVOdcj w==; X-IronPort-AV: E=Sophos;i="5.85,383,1624312800"; d="scan'208";a="20119997" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 19 Oct 2021 08:52:52 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 19 Oct 2021 08:52:52 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 19 Oct 2021 08:52:52 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1634626372; x=1666162372; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LEsOShHi53FwhvjjCf5twbUdvETtYuAw3EERG3UwX5A=; b=HuYEUGluTbcDMagJYu21BPDNW1UC1AMYO9jpzLwH7M23bthPSTG2xtju XSwnqgItG4KYD8gkxQ0nVTHNI1ogcYf7RvZDAJNY/4Ih6XYO5PT/RM5UB BpeVHIyccTA7BX4p6uY68yq+c6urb22vNec3N/moNniZHXab2mG4K8NX9 W5AwXH9Lsrn8ZMTF9opp8wQeneXDrxpHwHU2V3ghZmrahCKQwojyTuSGC xhuglY98k9y+GQ3wtYGStXy4nZ/CVGvddO45GJy2+BJmai64rBs7JSjak GHFxz3/bnoNZB0MSV61FdZbeN7bCzE9wO+Hl2yl1+JX4jCnGMVR7xxSf2 w==; X-IronPort-AV: E=Sophos;i="5.85,383,1624312800"; d="scan'208";a="20119996" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 19 Oct 2021 08:52:52 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 53FF8280075; Tue, 19 Oct 2021 08:52:52 +0200 (CEST) From: Alexander Stein To: David Airlie , Daniel Vetter , Rob Herring , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Alexander Stein Subject: [PATCH v3 1/4] dt-bindings: display: bridge: sn65dsi83: Make enable GPIO optional Date: Tue, 19 Oct 2021 08:52:36 +0200 Message-Id: <20211019065239.969988-2-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211019065239.969988-1-alexander.stein@ew.tq-group.com> References: <20211019065239.969988-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Laurent Pinchart The SN65DSI8x EN signal may be tied to VCC, or otherwise controlled by means not available to the kernel. Make the GPIO optional. Signed-off-by: Laurent Pinchart Signed-off-by: Alexander Stein Acked-by: Rob Herring --- .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index 07b20383cbca..a5779bf17849 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml @@ -93,7 +93,6 @@ properties: required: - compatible - reg - - enable-gpios - ports allOf: From patchwork Tue Oct 19 06:52:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12568767 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69EE2C433EF for ; Tue, 19 Oct 2021 06:53:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 160E96115B for ; Tue, 19 Oct 2021 06:53:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 160E96115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DDD56E8A4; Tue, 19 Oct 2021 06:53:00 +0000 (UTC) Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23D386E5B2 for ; Tue, 19 Oct 2021 06:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1634626377; x=1666162377; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OexUDrCO45DT7y8Xa3ppCIZxrceYdrcYeP4z6z7CHck=; b=YJABcKgySqeoquDrAWslF+huzF/Mv/CRbbufm/6p75W1swSDJyTqNF4+ FeuqL3maVo6GrEFPmlPkKjqB3LEp8WJllXq3akJxo2IVT1Vcy7j06iWI6 /fL5eN2hRCq5T2cl1BRpZEeB39qs+J48ITdg4I29uqumIMMj4evaZb3vG jlS0e59vTYLTbJnNZ6DQ85RbWuI9j+cFBeE65ayWa6XmMTHZQgr7fdkO3 TjHiPxTrD4eu5rMSDqotEeDwhArFlYczo9CYJqpawRHvIQ8e4ip01jDQq 5lMXvPiT6bF7gyZv8Mx6UJDPA5Bk+RUkWnba5pxzkxrN6B2Dvvh9UqijV Q==; X-IronPort-AV: E=Sophos;i="5.85,383,1624312800"; d="scan'208";a="20119999" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 19 Oct 2021 08:52:52 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 19 Oct 2021 08:52:53 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 19 Oct 2021 08:52:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1634626372; x=1666162372; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OexUDrCO45DT7y8Xa3ppCIZxrceYdrcYeP4z6z7CHck=; b=RVb0cOlijvaAElciX3+E/nmSL5AY41/ydYk99Y5ag9lytwloO4TrixPR 9rsTiqdeyQNO4zc7tW35daq2K3um8tTlw7X0vrkgltKAub2l6IGFd83UW ymOMd90zXUkH8eLF+muKEeTbj5VGcANadN7/EJpFnYli6sGDDS1guK77+ RiloZJU6F5DzBuuurGZxArza6XpuVR3UjISOAaaDJIIR+iqYmcXyp+rT0 IlPz5p+QvdNgQBJbtmRSZ/Ro2R/yCbgR/kPJJ1mVFoZga5503WI9g525D OWW60Iyv2cwz73n5Xi3Hrrs63WkHvy0ZVPWm7r0+A0csTrCIOIx2Jtrs3 g==; X-IronPort-AV: E=Sophos;i="5.85,383,1624312800"; d="scan'208";a="20119998" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 19 Oct 2021 08:52:52 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 8ACF8280065; Tue, 19 Oct 2021 08:52:52 +0200 (CEST) From: Alexander Stein To: David Airlie , Daniel Vetter , Rob Herring , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Alexander Stein , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Laurent Pinchart , Sam Ravnborg Subject: [PATCH v3 2/4] drm/bridge: ti-sn65dsi83: Make enable GPIO optional Date: Tue, 19 Oct 2021 08:52:37 +0200 Message-Id: <20211019065239.969988-3-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211019065239.969988-1-alexander.stein@ew.tq-group.com> References: <20211019065239.969988-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The enable signal may not be controllable by the kernel. Make it optional. This is a similar to commit bbda1704fc15 ("drm/bridge: ti-sn65dsi86: Make enable GPIO optional") Reviewed-by: Laurent Pinchart Reviewed-by: Sam Ravnborg Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index a32f70bc68ea..9072342566f3 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -671,7 +671,8 @@ static int sn65dsi83_probe(struct i2c_client *client, model = id->driver_data; } - ctx->enable_gpio = devm_gpiod_get(ctx->dev, "enable", GPIOD_OUT_LOW); + ctx->enable_gpio = devm_gpiod_get_optional(ctx->dev, "enable", + GPIOD_OUT_LOW); if (IS_ERR(ctx->enable_gpio)) return PTR_ERR(ctx->enable_gpio); From patchwork Tue Oct 19 06:52:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12568771 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09698C433F5 for ; Tue, 19 Oct 2021 06:53:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEE0A61177 for ; Tue, 19 Oct 2021 06:53:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BEE0A61177 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA0476E8A7; Tue, 19 Oct 2021 06:53:09 +0000 (UTC) Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id EEECF6E8A5 for ; Tue, 19 Oct 2021 06:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1634626381; x=1666162381; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=afCJuCSTbn7eVZ8BU0m5iuowBOerKVpcXOZ8UxaZTaA=; b=jJp6RyMWA2xQMPz0DkdMKAeSSs1Rxsyq0+VfR74J6Dbcg5pZjKaUZz2K 65EIUu1ToAElVQeaYi3f5WdSGDDHZev9hHa23/10y10Ah1dLxyJ7g7Ygk EdkSGJTB6C2S/uXIDa6yat+5wRJOpELH4/fn744ZO918RvfHWep9QsxVm WbonlEDxP9Z7ZsBCilAFPbGCoOLFI/2Zy8aoeKaR6jyZ8q7bjaVOdkN8b Bbp8dMlxaSx00g1qrQAJoLLsjACdt9GL/g/9GsFeH6LniQYAtSyK18hza VEVAOXFXcm8MJW4ZGe21zRaF3+0d97acDpS8+BYvPKuGWp96Wgw5HVx4t w==; X-IronPort-AV: E=Sophos;i="5.85,383,1624312800"; d="scan'208";a="20120010" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 19 Oct 2021 08:52:57 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 19 Oct 2021 08:52:57 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 19 Oct 2021 08:52:57 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1634626377; x=1666162377; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=afCJuCSTbn7eVZ8BU0m5iuowBOerKVpcXOZ8UxaZTaA=; b=qZKcnAJcqgUt8pWRYKm6RrPoVVl6A4J8I1CtZaKJ3+KRN/gWrUu6zMwH pYiZyrRAUMd4xqI+pCZswRF2Scp66uIh4Vvo3fOHF0uOdPV15AwgmU25A aBz+n4NHn14lR4PoKUyuY7SHKx8m/kKTnVWssQiZ+XdN5bxxEHZxICchF Z7N/cVGAM2yfs3r73rPmaiduJdo0BQMS0RVM2YqagZGGoZ08p21HY7IHX d4it4GOi6sfjzQJL2iFwmlAxaFEgBcE+S7skX3nPgoFAQSUZt4if6o8NO i9Bs6jikVAq+l+E+7RUx7KguLdHwRZ5gdYcx8MqvtHyR1mR826JdId8MH w==; X-IronPort-AV: E=Sophos;i="5.85,383,1624312800"; d="scan'208";a="20120000" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 19 Oct 2021 08:52:53 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id C7281280075; Tue, 19 Oct 2021 08:52:52 +0200 (CEST) From: Alexander Stein To: David Airlie , Daniel Vetter , Rob Herring , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Alexander Stein , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Sam Ravnborg Subject: [PATCH v3 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings Date: Tue, 19 Oct 2021 08:52:38 +0200 Message-Id: <20211019065239.969988-4-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211019065239.969988-1-alexander.stein@ew.tq-group.com> References: <20211019065239.969988-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add a VCC regulator which needs to be enabled before the EN pin is released. Reviewed-by: Sam Ravnborg Signed-off-by: Alexander Stein Acked-by: Rob Herring Reviewed-by: Laurent Pinchart --- .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index a5779bf17849..f1e4f149ccb4 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml @@ -32,6 +32,9 @@ properties: maxItems: 1 description: GPIO specifier for bridge_en pin (active high). + vcc-supply: + description: A 1.8V power supply (see regulator/regulator.yaml). + ports: $ref: /schemas/graph.yaml#/properties/ports @@ -134,6 +137,7 @@ examples: reg = <0x2d>; enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>; + vcc-supply = <®_sn65dsi83_1v8>; ports { #address-cells = <1>; From patchwork Tue Oct 19 06:52:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12568765 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7565C4332F for ; Tue, 19 Oct 2021 06:53:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66D336115B for ; Tue, 19 Oct 2021 06:53:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 66D336115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E8526E5B2; Tue, 19 Oct 2021 06:53:00 +0000 (UTC) Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id F09236E8A5 for ; Tue, 19 Oct 2021 06:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1634626378; x=1666162378; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Lg3tuBpYiD/5+hEhYgxgN3r0gs7N1LQRS6hKHorT0gY=; b=AQqqRAFRHnpU/wf9sFmKN/qvoU+PXBQp2A8TivE5xHBd30MXJZpoqnbW YS0UIx8NQ9gQrxyjqZcUOtLaVMhOUy0La/+T+cZEG+5TkgFtscYZdmZ6p JwTn1DMlATrVhtZZk4BTYnMatHDiLtPMItBjzNeDp8mkjAJcIWAZ0Q0F7 Jv6d8kRUMhitOB18inMEK8+FdlEzjr1VIkZSOUCYDAy5Z6B+UOhRtSgld GChuUxiKbF/bnVjJxMfrR2Dc78Bs6HGgzNEtYAU7IYlpiGSkNcl77EgX+ F7iiM9zaaaN6f353GeMCLXIU3ofJbvHXJJnClA/ofABbXwIhXkosdgrCu g==; X-IronPort-AV: E=Sophos;i="5.85,383,1624312800"; d="scan'208";a="20120008" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 19 Oct 2021 08:52:57 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 19 Oct 2021 08:52:57 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 19 Oct 2021 08:52:57 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1634626377; x=1666162377; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Lg3tuBpYiD/5+hEhYgxgN3r0gs7N1LQRS6hKHorT0gY=; b=P59FJZQvZeWHCD5+99nY71skpnfWL9Rvb1Lf1mrc6yeR41aFhNTPz0vd mdpH22sI8cYflfG6LzZx5y+eEQnHijkO+fjcNvDvCVvGkykAIItL+nHpB 25r6HGPnqdQD3Re0OJG/Z7JwbpEUn8+sD5HC0MLxnhK3QXIoyS2I5uQey 9Gf270yKmXR73eISeW8hS5811Q5j///pRNRatImO7IEFQOFYFeP2kBfCk jh0WEng28MecjnWP6NpskS98A74FNdxwkR+WuXgeT+xCfiMVee+1XnkWd 8S2rehI2+ohjR1x5U/MKCe+X2Q/cF+NX+KYrKPd9O73krqUzqklemlK+B g==; X-IronPort-AV: E=Sophos;i="5.85,383,1624312800"; d="scan'208";a="20120001" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 19 Oct 2021 08:52:53 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 09634280065; Tue, 19 Oct 2021 08:52:53 +0200 (CEST) From: Alexander Stein To: David Airlie , Daniel Vetter , Rob Herring , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Alexander Stein , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Sam Ravnborg Subject: [PATCH v3 4/4] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support Date: Tue, 19 Oct 2021 08:52:39 +0200 Message-Id: <20211019065239.969988-5-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211019065239.969988-1-alexander.stein@ew.tq-group.com> References: <20211019065239.969988-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" VCC needs to be enabled before releasing the enable GPIO. Reviewed-by: Sam Ravnborg Signed-off-by: Alexander Stein Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 9072342566f3..c55c45d5d29a 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -33,6 +33,7 @@ #include #include #include +#include #include #include @@ -143,6 +144,7 @@ struct sn65dsi83 { struct mipi_dsi_device *dsi; struct drm_bridge *panel_bridge; struct gpio_desc *enable_gpio; + struct regulator *vcc; int dsi_lanes; bool lvds_dual_link; bool lvds_dual_link_even_odd_swap; @@ -292,6 +294,11 @@ static void sn65dsi83_atomic_pre_enable(struct drm_bridge *bridge, struct drm_bridge_state *old_bridge_state) { struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge); + int ret; + + ret = regulator_enable(ctx->vcc); + if (ret) + dev_err(ctx->dev, "Failed to enable vcc: %i\n", ret); /* * Reset the chip, pull EN line low for t_reset=10ms, @@ -536,9 +543,14 @@ static void sn65dsi83_atomic_post_disable(struct drm_bridge *bridge, struct drm_bridge_state *old_bridge_state) { struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge); + int ret; /* Put the chip in reset, pull EN line low. */ gpiod_set_value(ctx->enable_gpio, 0); + + ret = regulator_disable(ctx->vcc); + if (ret) + dev_err(ctx->dev, "Failed to disable vcc: %i\n", ret); } static enum drm_mode_status @@ -647,6 +659,12 @@ static int sn65dsi83_parse_dt(struct sn65dsi83 *ctx, enum sn65dsi83_model model) ctx->panel_bridge = panel_bridge; + ctx->vcc = devm_regulator_get(dev, "vcc"); + if (IS_ERR(ctx->vcc)) + return dev_err_probe(dev, PTR_ERR(ctx->vcc), + "Failed to get supply 'vcc': %pe\n", + ctx->vcc); + return 0; }