From patchwork Tue Oct 19 13:12:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Stratiienko X-Patchwork-Id: 12569849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC35EC433EF for ; Tue, 19 Oct 2021 13:14:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B72AB61374 for ; Tue, 19 Oct 2021 13:14:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B72AB61374 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/P1G/xA+abbh4QXq2pMPp8wUCr3l1FNps6xnsjtc0zg=; b=UWwhjQyB2FXc2i jueLoXz16YJGxjWs3zMVVR4c9wQ+Z3PqbyJQCytnkbgi6jU3fI61XLiHBEbTuzCMmpj+BHgRhxzFg Tu0gh9FNSe4c5CU3APChXmLWWZCXT6CZrfOzvNyKpsWvfrObqCMdzqZZ37Yvh76tAcAt303NL0oJX ExNkTyYpBw8cghoVFtIlBaZYz/EoISyq0tVugC+EbZvW28o/qE4PpIrrO6ob+6ZriYMDW+93Fi9rX wSaJwOJh5J+PE5iOYt79+uUPEUxHBnEsozp+wfuubvcqwb8OpVkG2fBkRgRJbROptJiGsAECXsgK/ uUwRhNRC5bu6cIzPVjjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcovS-001N5p-14; Tue, 19 Oct 2021 13:13:06 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcovO-001N3e-My for linux-arm-kernel@lists.infradead.org; Tue, 19 Oct 2021 13:13:04 +0000 Received: by mail-ed1-x535.google.com with SMTP id t16so12892938eds.9 for ; Tue, 19 Oct 2021 06:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iBrOklT6wRz3+4Sv0nSOix/uEw45k7IhgJcWd50H2V4=; b=deOrvOSZJ7Ax/hHX/I0bj/ua6fjX1rP1DhOlu075couX1a3c1NVd1vCXiKTksJ8yXW qp4uXHhYMHHGxeF0zRIXPw9gurIoJ3aRUNnKbOAe8ArOMSk57YGOgDvnqpZIjI5pEo4Z cNOwb5tFsa/EZb+qlgBK9hUuhTQpDnP7tE1vX1OxMa5fUH/G9FCb1T2XFaA3XjPmvKVd dPYjOPOJrqXvXlcYtNWa+RaDM/Y8Rn+1e9mqNRVeUb4kvgVK7Ntrb0cdAT9Ackzt55Vo Nf7tiQol+2HlOzjTdRwPlexTUAyoCtbWQg81M4LN82vslZ3ear0azg0nfJ7vueyiZAuk 6H/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iBrOklT6wRz3+4Sv0nSOix/uEw45k7IhgJcWd50H2V4=; b=tXstff49mtOxgxhkLghMxO8NmWlVGI/ppTHKJULwE3M4pj42l/mt+1+Mqq31MCKSor 3tu+6DaS1VJvJ6x4BMqLSbY/geqVO5G0BidepbBgdtKO1I74cKATaKTHsu6gMOTxw+gd WoTD27fe4ydlpEMBh8EdtWyptxEhrcVkboj+q/caSXBU+yF9HwMv8qn7JRGcn8sH46m4 /n9t69oqqxLfHf0kIM6PH2JLk++L2J5sq3I/P+YFBt7U8+nW7OoeniWd0TWHzooLEKcd WpYG0OJMn3xhHYzEXDTtcVaIrqkyZ7PuGTF0ifDnQy5JrxZLYeMKOa3id60N6FeVBNn0 BKUQ== X-Gm-Message-State: AOAM530U9IBL/wR4j6wUInZ6JN4zqJdAglE3fPWTXuRWO3fzOc2i+h2M VRCS6JkKikrZF39gEtCmG0I= X-Google-Smtp-Source: ABdhPJzP6RuvLFjU20H2PG1567GaG8/B+U9ZCxaQnE9gpZ3riwQ97C9SC3UHkFwm4W7diIY+IG7Xpg== X-Received: by 2002:a17:906:e104:: with SMTP id gj4mr36909389ejb.358.1634649169355; Tue, 19 Oct 2021 06:12:49 -0700 (PDT) Received: from roman-Latitude-3400.. (178-133-75-113.mobile.vf-ua.net. [178.133.75.113]) by smtp.gmail.com with ESMTPSA id g2sm11334590edq.81.2021.10.19.06.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 06:12:48 -0700 (PDT) From: Roman Stratiienko To: linux-sunxi@lists.linux.dev Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, jernej.skrabec@gmail.com, wens@csie.org, mripard@kernel.org, b-liu@ti.com, megous@megous.com, Roman Stratiienko Subject: [PATCH] usb: musb: sunxi: Don't print error on MUSB_ULPI_BUSCONTROL access Date: Tue, 19 Oct 2021 16:12:44 +0300 Message-Id: <20211019131244.1568560-1-r.stratiienko@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_061302_776357_39622F84 X-CRM114-Status: GOOD ( 11.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Error message appears during suspend, where musb driver is storing the register state in musb_save_context(): ``` musb-sunxi 1c19000.usb: Error unknown readb offset 112 ``` Print warning instead to avoid confusion. Signed-off-by: Roman Stratiienko --- drivers/usb/musb/sunxi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c index f3f76f2ac63f9b..961c858fb349e1 100644 --- a/drivers/usb/musb/sunxi.c +++ b/drivers/usb/musb/sunxi.c @@ -440,6 +440,10 @@ static u8 sunxi_musb_readb(void __iomem *addr, u32 offset) return 0xde; return readb(addr + SUNXI_MUSB_CONFIGDATA); + case MUSB_ULPI_BUSCONTROL: + dev_warn(sunxi_musb->controller->parent, + "sunxi-musb does not have ULPI bus control register\n"); + return 0; /* Offset for these is fixed by sunxi_musb_busctl_offset() */ case SUNXI_MUSB_TXFUNCADDR: case SUNXI_MUSB_TXHUBADDR: @@ -494,6 +498,10 @@ static void sunxi_musb_writeb(void __iomem *addr, unsigned offset, u8 data) return writeb(data, addr + SUNXI_MUSB_TXFIFOSZ); case MUSB_RXFIFOSZ: return writeb(data, addr + SUNXI_MUSB_RXFIFOSZ); + case MUSB_ULPI_BUSCONTROL: + dev_warn(sunxi_musb->controller->parent, + "sunxi-musb does not have ULPI bus control register\n"); + return; /* Offset for these is fixed by sunxi_musb_busctl_offset() */ case SUNXI_MUSB_TXFUNCADDR: case SUNXI_MUSB_TXHUBADDR: