From patchwork Wed Nov 3 12:45:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kushal Kothari X-Patchwork-Id: 12600767 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28486C433EF for ; Wed, 3 Nov 2021 12:45:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC03F610A8 for ; Wed, 3 Nov 2021 12:45:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC03F610A8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 562DD6B006C; Wed, 3 Nov 2021 08:45:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 511676B0071; Wed, 3 Nov 2021 08:45:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D9CA940007; Wed, 3 Nov 2021 08:45:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 300476B006C for ; Wed, 3 Nov 2021 08:45:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E44D95CBB9 for ; Wed, 3 Nov 2021 12:45:29 +0000 (UTC) X-FDA: 78767589978.02.B45D279 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf26.hostedemail.com (Postfix) with ESMTP id 41D6420019C0 for ; Wed, 3 Nov 2021 12:45:30 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id x64so2190803pfd.6 for ; Wed, 03 Nov 2021 05:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Y2nSdHgQfwg8AfD5xMlGZZ/kVCHjM8ptgo0r0VuianE=; b=aQPZScxUmVjCRzlQXRTFdCH5gp2ztq0r6esSpLRy+kIDyERPZDmCSrcZ/ja5Kbx//E znsm/D78DODY9jj8LScuX51+XhiIeHn/rJ0PWIedRIoFVgywDwyT4FF/6rPrH5qESVXA qwyFuv+R4IXVYmimi2u0QvW4R4Cr98jeZYHhjJQ9ljy/d1sVJYBvJRFBzKAK3Z/lhNjr 7fEGuMOaeR5En7ELQ8QtX5aQ/xzBhlysXM7oosXPTaDl7EO+TCss9AB60m9BbhOX4CGC r2MpMlTiY9CJ6riN3qRPX67BTzyc+VRasMQKCFkmDgt9cAMry6+qA1cDg59yV2Qt0+YV SHxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Y2nSdHgQfwg8AfD5xMlGZZ/kVCHjM8ptgo0r0VuianE=; b=LkM+Pq05QLs9RkKkr86wpZg+M+QL2H5VSu0M/yvbrsd2RQSKo1W8yjmJecEh5Y9u+D zaqd4QUX7SKmBvZS69Gei3s//s+nL7lsX+QechvhM5vh13GoizlNPLq+c3lEi92HAwjo CJ04XmR9NGMozm24Wf+sVTT+7gR6PoSmvQb4PwMPMat7OthDL8vk4TwoqkOQFkPYKeGd JJ6WWZMf8RkyY/GMQEXGfjy+E2L2fbq9pizMS5Py5PscDISe4Z25pS8DZLjr0ty334Rl FZhCnMGUF1RaK0df/vKL/LKlcT9PDg3TqEA+6jlOcGHq4pU3Jvce+w7muPUgAKY7MNAo 2iwQ== X-Gm-Message-State: AOAM5313isvdjCj2MNAoX4dvantOHaVjVAsvx/2bmv3dOZB0rkrY+1mP LSHFJAqx6Cr4IrBFI8zpBfo= X-Google-Smtp-Source: ABdhPJwDk4qWexpr+V0Fh42A8OX7yL6sR8mptZHDoR7vislj6OWKaB1/Pufw8wmmTw6zx5g72wUALQ== X-Received: by 2002:a63:2147:: with SMTP id s7mr30086807pgm.140.1635943528451; Wed, 03 Nov 2021 05:45:28 -0700 (PDT) Received: from kushal ([115.96.218.96]) by smtp.gmail.com with ESMTPSA id 1sm2206743pfm.163.2021.11.03.05.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 05:45:28 -0700 (PDT) From: Kushal Kothari To: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mike.rapoport@gmail.com, kushalkothari2850@gmail.com Cc: Kushal Kothari Subject: [PATCH v2] mm: Fix ERROR:do not initialise statics to 0 or NULL in memblock.c Date: Wed, 3 Nov 2021 18:15:23 +0530 Message-Id: <20211103124523.10670-1-kushalkothari285@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 41D6420019C0 X-Stat-Signature: zeebq4ipy88o351we1gouc6aht4y7ras Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aQPZScxU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of kushalkothari285@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=kushalkothari285@gmail.com X-Rspamd-Server: rspam01 X-HE-Tag: 1635943530-275115 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The default value of static variable is zero and bool is false so not need to set it here. This patch fixes this ERROR in memblock.c Error found with checkpatch.pl. Signed-off-by: Kushal Kothari --- Changes in v2: Correct the subject line and remove which isn't necessary mm/memblock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 5c3503c98b2f..9e2b7c1dbd03 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -152,10 +152,10 @@ static __refdata struct memblock_type *memblock_memory = &memblock.memory; } while (0) static int memblock_debug __initdata_memblock; -static bool system_has_some_mirror __initdata_memblock = false; +static bool system_has_some_mirror __initdata_memblock; static int memblock_can_resize __initdata_memblock; -static int memblock_memory_in_slab __initdata_memblock = 0; -static int memblock_reserved_in_slab __initdata_memblock = 0; +static int memblock_memory_in_slab __initdata_memblock; +static int memblock_reserved_in_slab __initdata_memblock; static enum memblock_flags __init_memblock choose_memblock_flags(void) {