From patchwork Wed Nov 3 20:46:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 12601575 X-Patchwork-Delegate: kieran@bingham.xyz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C396CC433EF for ; Wed, 3 Nov 2021 20:46:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2D356113B for ; Wed, 3 Nov 2021 20:46:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229893AbhKCUsu (ORCPT ); Wed, 3 Nov 2021 16:48:50 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:57807 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbhKCUsu (ORCPT ); Wed, 3 Nov 2021 16:48:50 -0400 Received: (Authenticated sender: jacopo@jmondi.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 86D9D200005; Wed, 3 Nov 2021 20:46:11 +0000 (UTC) From: Jacopo Mondi To: Kieran Bingham , Laurent Pinchart , =?utf-8?q?Nik?= =?utf-8?q?las_S=C3=B6derlund?= Cc: Jacopo Mondi , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH 1/2] media: max9271: Fail loudly on bus read errors Date: Wed, 3 Nov 2021 21:46:53 +0100 Message-Id: <20211103204654.223699-2-jacopo+renesas@jmondi.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211103204654.223699-1-jacopo+renesas@jmondi.org> References: <20211103204654.223699-1-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Read errors were silently going ignored. Fail louder to make sure such errors are visible. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/max9271.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c index ff86c8c4ea61..aa9ab6831574 100644 --- a/drivers/media/i2c/max9271.c +++ b/drivers/media/i2c/max9271.c @@ -30,7 +30,7 @@ static int max9271_read(struct max9271_device *dev, u8 reg) ret = i2c_smbus_read_byte_data(dev->client, reg); if (ret < 0) - dev_dbg(&dev->client->dev, + dev_err(&dev->client->dev, "%s: register 0x%02x read failed (%d)\n", __func__, reg, ret); From patchwork Wed Nov 3 20:46:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 12601577 X-Patchwork-Delegate: kieran@bingham.xyz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD586C43217 for ; Wed, 3 Nov 2021 20:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C30A361139 for ; Wed, 3 Nov 2021 20:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230460AbhKCUsv (ORCPT ); Wed, 3 Nov 2021 16:48:51 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:39851 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230395AbhKCUsv (ORCPT ); Wed, 3 Nov 2021 16:48:51 -0400 Received: (Authenticated sender: jacopo@jmondi.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id BF54C200008; Wed, 3 Nov 2021 20:46:12 +0000 (UTC) From: Jacopo Mondi To: Kieran Bingham , Laurent Pinchart , =?utf-8?q?Nik?= =?utf-8?q?las_S=C3=B6derlund?= Cc: Jacopo Mondi , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH 2/2] media: max9271: Ignore busy loop read errors Date: Wed, 3 Nov 2021 21:46:54 +0100 Message-Id: <20211103204654.223699-3-jacopo+renesas@jmondi.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211103204654.223699-1-jacopo+renesas@jmondi.org> References: <20211103204654.223699-1-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Valid pixel clock detection is performed by spinning on a register read, which if repeated too frequently might fail. As the error is not fatal ignore it instead of bailing out to continue spinning until the timeout completion. Also relax the time between bus transactions and slightly increase the wait interval to mitigate the failure risk. Signed-off-by: Jacopo Mondi Reviewed-by: Niklas Söderlund --- drivers/media/i2c/max9271.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.33.1 diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c index aa9ab6831574..5c4248de64c2 100644 --- a/drivers/media/i2c/max9271.c +++ b/drivers/media/i2c/max9271.c @@ -55,7 +55,7 @@ static int max9271_write(struct max9271_device *dev, u8 reg, u8 val) /* * max9271_pclk_detect() - Detect valid pixel clock from image sensor * - * Wait up to 10ms for a valid pixel clock. + * Wait up to 15ms for a valid pixel clock. * * Returns 0 for success, < 0 for pixel clock not properly detected */ @@ -64,15 +64,15 @@ static int max9271_pclk_detect(struct max9271_device *dev) unsigned int i; int ret; - for (i = 0; i < 100; i++) { + for (i = 0; i < 10; i++) { ret = max9271_read(dev, 0x15); if (ret < 0) - return ret; + continue; if (ret & MAX9271_PCLKDET) return 0; - usleep_range(50, 100); + usleep_range(1000, 1500); } dev_err(&dev->client->dev, "Unable to detect valid pixel clock\n");