From patchwork Mon Dec 17 04:47:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anson Huang X-Patchwork-Id: 10732737 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3271417E1 for ; Mon, 17 Dec 2018 04:47:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1574429461 for ; Mon, 17 Dec 2018 04:47:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 051E52957B; Mon, 17 Dec 2018 04:47:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77F6F29461 for ; Mon, 17 Dec 2018 04:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731464AbeLQErs (ORCPT ); Sun, 16 Dec 2018 23:47:48 -0500 Received: from mail-eopbgr00072.outbound.protection.outlook.com ([40.107.0.72]:16754 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726318AbeLQErs (ORCPT ); Sun, 16 Dec 2018 23:47:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7HrGtdLoy8eZg+UzIOy5JjS9CUThJU9X1tHxfNm1eY8=; b=G9kIZJQ1jJVfQ84fvf/agtlp8pw42WRRi2uOJ5KNtja3UY43KZa9dXMrAq6taqZ6mtiWW61K7+fTVxkzO8kbrdZ517V1WkQL9CM5p2ZMdLVVfU/FxD9EKIhnzU6O5GcX7GO/Ot9zy7AR+wWqlO/7a+q7bmaw8pXKc6n1vUhDTE0= Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com (52.134.72.18) by DB3PR0402MB3721.eurprd04.prod.outlook.com (52.134.67.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.19; Mon, 17 Dec 2018 04:47:43 +0000 Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::adf8:f49d:deb4:58fd]) by DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::adf8:f49d:deb4:58fd%3]) with mapi id 15.20.1425.021; Mon, 17 Dec 2018 04:47:43 +0000 From: Anson Huang To: "jic23@kernel.org" , "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "olivier.moysan@st.com" , "masneyb@onstation.org" , "broonie@kernel.org" , "peda@axentia.se" , "rtresidd@electromag.com.au" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "festevam@gmail.com" , "preid@electromag.com.au" CC: dl-linux-imx Subject: [PATCH V5 1/2] dt-bindings: iio: magnetometer: add dt-bindings for freescale mag3110 Thread-Topic: [PATCH V5 1/2] dt-bindings: iio: magnetometer: add dt-bindings for freescale mag3110 Thread-Index: AQHUlcOklc5L75Ok4Ei6u4K1KZWdZQ== Date: Mon, 17 Dec 2018 04:47:40 +0000 Message-ID: <1545021679-4025-1-git-send-email-Anson.Huang@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK2PR06CA0011.apcprd06.prod.outlook.com (2603:1096:202:2e::23) To DB3PR0402MB3916.eurprd04.prod.outlook.com (2603:10a6:8:10::18) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB3PR0402MB3721;6:lcqHEl/ob14wBoc5/6DkUDVMIUmxBFKVRIiueK5eZQ8fSxlZ2miiOrvqiRsyZqRhIWN60BFb6VpXLi6SMMGmMG1mfLaUAjVTDlbIh1HW98Sdl5t5nOqlICrojnXZndV3gPB6csbJwCiikNOpQ91qgaHZq7TXGJSn+h+9fk9/dv+zw2z9BemAxgZ4Xue2+QLUOFM4cPypf901oJbh3oY5C9OsBDNhWmKgxi5jpDxUqDXILWwVcB7fWae7nCIgnXW1ldfen5CxDf30Hf8yggbSg5xQ5gYh3WAkrD6WEFjF42etF+6MWdPnz223FJlQ5LSyIY1SPaA+v9wtHl9FGIzeuwGwcfxUOAxrFY8DzzCdAgIQPb5/MDpJXRmqMffKb53AVRUqVvf4LDmpkakCBgxf8HnQCcnC3jskBmIRTyrzlw0dDpCeBy3mLEFq6CgNV9thTAhaSYxB/XQSzTcBIXoC+Q==;5:v+2f8pVNiM7F53pyLa0/oO/7TKiCd4qSFLSvoJ8d95D6/Z14G8UHKMz1QKtxMfsNz/Yyuld17me2IDyokGXJYnA3sH0Y6p3GpQaPy6OHDlPsR2jMTlW0mnYPcJ/UdyXpNadZ+3H9A9VDOG3GLT1chEi6HZ3kdE64AvFlB4H1Utg=;7:AUVXT0TX7uLgMYYkF8ZZM1GA3CepcEDEvOBvm6zVMJK4k5aK2LxcDxu7q/ZneKezCQ+fdLfG7YjR0/j/yHrXKg+yJHs2nt3Q+QowzBNfzsiZRQA5lUxWFPoyDVA0jzi1EbEFtwvGsuUc4Z8M+bP4Og== x-ms-office365-filtering-correlation-id: a367056e-8949-466c-e283-08d663dac5f1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:DB3PR0402MB3721; x-ms-traffictypediagnostic: DB3PR0402MB3721: authentication-results: spf=none (sender IP is ) smtp.mailfrom=anson.huang@nxp.com; x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(3230021)(999002)(5005020)(6040522)(2401047)(8121501046)(3002001)(10201501046)(3231475)(944501520)(52105112)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:DB3PR0402MB3721;BCL:0;PCL:0;RULEID:;SRVR:DB3PR0402MB3721; x-forefront-prvs: 08897B549D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(376002)(366004)(136003)(39860400002)(396003)(189003)(199004)(97736004)(256004)(8676002)(39060400002)(81156014)(4326008)(6512007)(105586002)(53936002)(305945005)(7416002)(486006)(2501003)(476003)(106356001)(2616005)(478600001)(5660300001)(66066001)(71200400001)(71190400001)(36756003)(6116002)(3846002)(386003)(6506007)(7736002)(2906002)(50226002)(8936002)(25786009)(6436002)(52116002)(316002)(86362001)(6486002)(575784001)(99286004)(68736007)(186003)(102836004)(14454004)(81166006)(26005)(14444005)(2201001)(110136005)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR0402MB3721;H:DB3PR0402MB3916.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: YsNroGOQSBMk94eJWmCb6q2NGOOpu8J4Zwe+43P/COcFZdiES2lp+PGP52QSzJKJlyOd9vxpkJeomZpAsGG0ePgp8jnQtPC7eR5IhwFUA6XesOsKuzjCHzu50VchxjlZnGZgw23rtssU1qemfnMJ6asBlAfVrWNg+I7692MCJcJ26kBFiNCjeApOlEYQs0ZsupvtLetK9/R5Xok5hN3VVbxMS6DIQCNeYITk0ifaF1coZ6qwrEptobvjkhZxEChfNTf0Pyaa0xdGwCRrE6WyyT1BeH2DXADAixDZbMio2mwHQIEAvETg+8VaHkAdZ9Vn spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a367056e-8949-466c-e283-08d663dac5f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2018 04:47:43.3555 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3721 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add Freescale MAG3110 dt-bindings and remove it from trivial-devices dt-bingding doc. Signed-off-by: Anson Huang Acked-by: Jonathan Cameron --- .../bindings/iio/magnetometer/mag3110.txt | 27 ++++++++++++++++++++++ .../devicetree/bindings/trivial-devices.txt | 1 - 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/mag3110.txt diff --git a/Documentation/devicetree/bindings/iio/magnetometer/mag3110.txt b/Documentation/devicetree/bindings/iio/magnetometer/mag3110.txt new file mode 100644 index 0000000..bdd40bc --- /dev/null +++ b/Documentation/devicetree/bindings/iio/magnetometer/mag3110.txt @@ -0,0 +1,27 @@ +* FREESCALE MAG3110 magnetometer sensor + +Required properties: + + - compatible : should be "fsl,mag3110" + - reg : the I2C address of the magnetometer + +Optional properties: + + - interrupts: the sole interrupt generated by the device + + Refer to interrupt-controller/interrupts.txt for generic interrupt client + node bindings. + + - vdd-supply: phandle to the regulator that provides power to the sensor. + - vddio-supply: phandle to the regulator that provides power to the sensor's IO. + +Example: + +magnetometer@e { + compatible = "fsl,mag3110"; + reg = <0x0e>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c3_mag3110_int>; + interrupt-parent = <&gpio3>; + interrupts = <16 IRQ_TYPE_EDGE_RISING>; +}; diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt index 6ab001f..5f086ac 100644 --- a/Documentation/devicetree/bindings/trivial-devices.txt +++ b/Documentation/devicetree/bindings/trivial-devices.txt @@ -43,7 +43,6 @@ domintech,dmard10 DMARD10: 3-axis Accelerometer epson,rx8010 I2C-BUS INTERFACE REAL TIME CLOCK MODULE epson,rx8581 I2C-BUS INTERFACE REAL TIME CLOCK MODULE emmicro,em3027 EM Microelectronic EM3027 Real-time Clock -fsl,mag3110 MAG3110: Xtrinsic High Accuracy, 3D Magnetometer fsl,mma7660 MMA7660FC: 3-Axis Orientation/Motion Detection Sensor fsl,mma8450 MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer fsl,mpl3115 MPL3115: Absolute Digital Pressure Sensor From patchwork Mon Dec 17 04:47:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anson Huang X-Patchwork-Id: 10732739 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BCBA214DE for ; Mon, 17 Dec 2018 04:48:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC47829461 for ; Mon, 17 Dec 2018 04:48:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9EF272957B; Mon, 17 Dec 2018 04:48:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 00E8929461 for ; Mon, 17 Dec 2018 04:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbeLQErx (ORCPT ); Sun, 16 Dec 2018 23:47:53 -0500 Received: from mail-eopbgr00086.outbound.protection.outlook.com ([40.107.0.86]:62722 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726318AbeLQErx (ORCPT ); Sun, 16 Dec 2018 23:47:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kNm4RnV+zl/5wzKObQa9uQrxpz5i+W2tM/VRsNexTo8=; b=Ll43saOlG1Rn3crsEcYVNVtmFhEFh7nlMHYF+/XMpLJL4M3WhlSEDLFuDIHOeTheSDJqP/nCgyO/mpslnNc1M9kc7AfTJfIW6Jw8paAAElZQ7xqVYDhVzrTiy7+PqjPl01JqVXOoLFVH7ml5GO/s8SolKgVnj9QyiVrTwACwhZU= Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com (52.134.72.18) by DB3PR0402MB3721.eurprd04.prod.outlook.com (52.134.67.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.19; Mon, 17 Dec 2018 04:47:49 +0000 Received: from DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::adf8:f49d:deb4:58fd]) by DB3PR0402MB3916.eurprd04.prod.outlook.com ([fe80::adf8:f49d:deb4:58fd%3]) with mapi id 15.20.1425.021; Mon, 17 Dec 2018 04:47:49 +0000 From: Anson Huang To: "jic23@kernel.org" , "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "olivier.moysan@st.com" , "masneyb@onstation.org" , "broonie@kernel.org" , "peda@axentia.se" , "rtresidd@electromag.com.au" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "festevam@gmail.com" , "preid@electromag.com.au" CC: dl-linux-imx Subject: [PATCH V5 2/2] iio: magnetometer: mag3110: add vdd/vddio regulator operation support Thread-Topic: [PATCH V5 2/2] iio: magnetometer: mag3110: add vdd/vddio regulator operation support Thread-Index: AQHUlcOp9VjSnhNIRk+OC0KV2BawtQ== Date: Mon, 17 Dec 2018 04:47:49 +0000 Message-ID: <1545021679-4025-2-git-send-email-Anson.Huang@nxp.com> References: <1545021679-4025-1-git-send-email-Anson.Huang@nxp.com> In-Reply-To: <1545021679-4025-1-git-send-email-Anson.Huang@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK2PR06CA0011.apcprd06.prod.outlook.com (2603:1096:202:2e::23) To DB3PR0402MB3916.eurprd04.prod.outlook.com (2603:10a6:8:10::18) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB3PR0402MB3721;6:lxeNj9/56Yq6AQbt0OxCSSZoooxIAiUKz7AwTq9SjhmskXNwjgg0UDsem6b2pYtQm7Jqt4oTpaLcvmBVlOUkIJplFDOYaNM493haA0EUuF+6zdg62WyLtddY8ekNZMZLfao1+JTN0KSrUfXu9eJNy/hwa1FLyU0mydyWU1UFee+l/i5u6V1bcyALtbRYBHv8DkSHqIzDfXZKrqOLGwi1C4H8aNnZQK1RycpWJrQPW0RQLHEXjHwwuvSTYs8RqCVjaDMOiVD2hluLByNuJgns+rzLdDNZXRD5gCDNZzni6I661x+KgJ5RCgh3EaXpq3Ycwnw2kufC0nL4HJ5JxInoMORlF3UVILMjfYMrF16KfsUQAN/9fuJ4KCLEZrOYxMUlbKDi0U8TQ5duxEfsYPfMWx4SMKQJrbRL3upZd43l6G30f5lgxKHhz5JXJ+R4SkQjbQEYmD+wCBRJt2vdAPm7uA==;5:xFeq5XNU0Hkm9kDYouxW+MoVFaooieh8lw9Cssq2Nnw3Zund/sKZexlEyrotfrx1q7gpz8eSqE7uC1lqQHTxPcbbq+C8cg/26GTK2wJF4aXkrR4sq68OBAumTYKlPNxsJfO17vsT3a/4RXDgMhngJFGlQFOUbSyat7R8JFJIDt8=;7:En6eq6QDWded7U2Iz4cjD2BZ3oZzp4hYqSx4jk1yAsO1gb6UjDro3Hud2g9ulCfBu4k7SPn5jFxDl7R8w2bJ2DjshKsdPgxc3wm5Kzl0IUp9ua3rYUJsVrKIYb/uawhS74KPGVP3+5n46k5dkL5QDw== x-ms-office365-filtering-correlation-id: 2db0ae84-9b20-467d-40df-08d663dacb89 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:DB3PR0402MB3721; x-ms-traffictypediagnostic: DB3PR0402MB3721: authentication-results: spf=none (sender IP is ) smtp.mailfrom=anson.huang@nxp.com; x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(3230021)(999002)(5005020)(6040522)(2401047)(8121501046)(3002001)(10201501046)(3231475)(944501520)(52105112)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:DB3PR0402MB3721;BCL:0;PCL:0;RULEID:;SRVR:DB3PR0402MB3721; x-forefront-prvs: 08897B549D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(376002)(366004)(136003)(39860400002)(396003)(54534003)(189003)(199004)(97736004)(256004)(8676002)(39060400002)(81156014)(4326008)(6512007)(105586002)(53936002)(305945005)(7416002)(486006)(2501003)(476003)(106356001)(2616005)(478600001)(5660300001)(66066001)(71200400001)(11346002)(446003)(71190400001)(36756003)(76176011)(6116002)(3846002)(386003)(6506007)(7736002)(2906002)(50226002)(8936002)(25786009)(6436002)(52116002)(316002)(86362001)(6486002)(99286004)(68736007)(186003)(102836004)(14454004)(81166006)(26005)(14444005)(2201001)(110136005)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR0402MB3721;H:DB3PR0402MB3916.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Ie5GHKnQpJ5rvegT8+C/BgfUfCnxq/rdBpfc24HOhkcC4oZqteN8830f2eDX+9Iudc74Pxl8O+sG01Ao51IC/qAcBgzhW+BSelLG2seyUodkzm4FERIMQYZyt3XAl/zEv/iidOQh+92nuERj3K4P6VDyzmr+fXyTRlWwv5jSZl/XX0+05MCf0Q0/QMkS8ALm+0Y7SrisORKaa06lpDjro4DgYRNzUnzQzF6a48njK5hcwxG5PNWUCZKwVNVW/UGGbLxHwZEm1ljxQnoiDsr5Ku9BWJ+3kcxKuAuOWM5tFAjQSMucnBFRB4/wX7zfmhw4 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2db0ae84-9b20-467d-40df-08d663dacb89 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2018 04:47:49.3818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3721 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The magnetometer's power supplies could be controllable on some platforms, such as i.MX6Q-SABRESD board, the mag3110's power supplies are controlled by a GPIO fixed regulator, need to make sure the regulators are enabled before any communication with mag3110, this patch adds vdd/vddio regulator operation support. Signed-off-by: Anson Huang --- ChangeLog since V4: - using devm_regulator_get() instead of devm_regulator_get_optional() since the regulator is there always, if dtb does NOT specify one, regulator framework will assign dummy regulator for it --- drivers/iio/magnetometer/mag3110.c | 92 ++++++++++++++++++++++++++++++++++---- 1 file changed, 84 insertions(+), 8 deletions(-) diff --git a/drivers/iio/magnetometer/mag3110.c b/drivers/iio/magnetometer/mag3110.c index f063355..32660ce 100644 --- a/drivers/iio/magnetometer/mag3110.c +++ b/drivers/iio/magnetometer/mag3110.c @@ -20,6 +20,7 @@ #include #include #include +#include #define MAG3110_STATUS 0x00 #define MAG3110_OUT_X 0x01 /* MSB first */ @@ -56,6 +57,8 @@ struct mag3110_data { struct mutex lock; u8 ctrl_reg1; int sleep_val; + struct regulator *vdd_reg; + struct regulator *vddio_reg; }; static int mag3110_request(struct mag3110_data *data) @@ -469,17 +472,48 @@ static int mag3110_probe(struct i2c_client *client, struct iio_dev *indio_dev; int ret; - ret = i2c_smbus_read_byte_data(client, MAG3110_WHO_AM_I); - if (ret < 0) - return ret; - if (ret != MAG3110_DEVICE_ID) - return -ENODEV; - indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; data = iio_priv(indio_dev); + + data->vdd_reg = devm_regulator_get(&client->dev, "vdd"); + if (IS_ERR(data->vdd_reg)) { + ret = PTR_ERR(data->vdd_reg); + if (ret != -EPROBE_DEFER) + dev_err(&client->dev, "failed to get VDD regulator!\n"); + return ret; + } + + ret = regulator_enable(data->vdd_reg); + if (ret) { + dev_err(&client->dev, "failed to enable VDD regulator!\n"); + return ret; + } + + data->vddio_reg = devm_regulator_get(&client->dev, "vddio"); + if (IS_ERR(data->vddio_reg)) { + ret = PTR_ERR(data->vddio_reg); + if (ret != -EPROBE_DEFER) + dev_err(&client->dev, "failed to get VDDIO regulator!\n"); + goto disable_regulator_vdd; + } + + ret = regulator_enable(data->vddio_reg); + if (ret) { + dev_err(&client->dev, "failed to enable VDDIO regulator!\n"); + goto disable_regulator_vdd; + } + + ret = i2c_smbus_read_byte_data(client, MAG3110_WHO_AM_I); + if (ret < 0) + goto disable_regulators; + if (ret != MAG3110_DEVICE_ID) { + ret = -ENODEV; + goto disable_regulators; + } + data->client = client; mutex_init(&data->lock); @@ -499,7 +533,7 @@ static int mag3110_probe(struct i2c_client *client, ret = mag3110_change_config(data, MAG3110_CTRL_REG1, data->ctrl_reg1); if (ret < 0) - return ret; + goto disable_regulators; ret = i2c_smbus_write_byte_data(client, MAG3110_CTRL_REG2, MAG3110_CTRL_AUTO_MRST_EN); @@ -520,16 +554,24 @@ static int mag3110_probe(struct i2c_client *client, iio_triggered_buffer_cleanup(indio_dev); standby_on_error: mag3110_standby(iio_priv(indio_dev)); +disable_regulators: + regulator_disable(data->vddio_reg); +disable_regulator_vdd: + regulator_disable(data->vdd_reg); + return ret; } static int mag3110_remove(struct i2c_client *client) { struct iio_dev *indio_dev = i2c_get_clientdata(client); + struct mag3110_data *data = iio_priv(indio_dev); iio_device_unregister(indio_dev); iio_triggered_buffer_cleanup(indio_dev); mag3110_standby(iio_priv(indio_dev)); + regulator_disable(data->vddio_reg); + regulator_disable(data->vdd_reg); return 0; } @@ -537,14 +579,48 @@ static int mag3110_remove(struct i2c_client *client) #ifdef CONFIG_PM_SLEEP static int mag3110_suspend(struct device *dev) { - return mag3110_standby(iio_priv(i2c_get_clientdata( + struct mag3110_data *data = iio_priv(i2c_get_clientdata( + to_i2c_client(dev))); + int ret; + + ret = mag3110_standby(iio_priv(i2c_get_clientdata( to_i2c_client(dev)))); + if (ret) + return ret; + + ret = regulator_disable(data->vddio_reg); + if (ret) { + dev_err(dev, "failed to disable VDDIO regulator\n"); + return ret; + } + + ret = regulator_disable(data->vdd_reg); + if (ret) { + dev_err(dev, "failed to disable VDD regulator\n"); + return ret; + } + + return 0; } static int mag3110_resume(struct device *dev) { struct mag3110_data *data = iio_priv(i2c_get_clientdata( to_i2c_client(dev))); + int ret; + + ret = regulator_enable(data->vdd_reg); + if (ret) { + dev_err(dev, "failed to enable VDD regulator\n"); + return ret; + } + + ret = regulator_enable(data->vddio_reg); + if (ret) { + dev_err(dev, "failed to enable VDDIO regulator\n"); + regulator_disable(data->vdd_reg); + return ret; + } return i2c_smbus_write_byte_data(data->client, MAG3110_CTRL_REG1, data->ctrl_reg1);