From patchwork Mon Dec 17 12:33:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Neukum X-Patchwork-Id: 10733295 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0C06313BF for ; Mon, 17 Dec 2018 12:33:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F005C29D83 for ; Mon, 17 Dec 2018 12:33:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E1EE929D95; Mon, 17 Dec 2018 12:33:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B50E629D83 for ; Mon, 17 Dec 2018 12:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732630AbeLQMdQ (ORCPT ); Mon, 17 Dec 2018 07:33:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:33762 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732628AbeLQMdQ (ORCPT ); Mon, 17 Dec 2018 07:33:16 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E8099AE24; Mon, 17 Dec 2018 12:33:14 +0000 (UTC) Message-ID: <1545049985.17601.6.camel@suse.com> Subject: serious doubts concerning a7d57abcc8a5bdeb53bbf8e87558e8e0a2c2a29d ("xhci: workaround CSS timeout on AMD SNPS 3.0 xHC") From: Oliver Neukum To: Sandeep Singh Cc: linux-usb@vger.kernel.org, nsaenzjulienne@suse.de, gregkh@linuxfoundation.org Date: Mon, 17 Dec 2018 13:33:05 +0100 X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, this patch contains the following section: index 260b259b72bc..c3515bad5dbb 100644 The placement of the broken_suspend flag seems to break every usage of the priv member of struct xhci_hcd. Are you sure that is a good idea? Regards Oliver --- a/drivers/usb/host/xhci.h +++ b/drivers/usb/host/xhci.h @@ -1850,6 +1850,7 @@ struct xhci_hcd { #define XHCI_ZERO_64B_REGS BIT_ULL(32) #define XHCI_DEFAULT_PM_RUNTIME_ALLOW BIT_ULL(33) #define XHCI_RESET_PLL_ON_DISCONNECT BIT_ULL(34) +#define XHCI_SNPS_BROKEN_SUSPEND BIT_ULL(35) unsigned int num_active_eps; unsigned int limit_active_eps; @@ -1879,6 +1880,8 @@ struct xhci_hcd { void *dbc; /* platform-specific data -- must come last */ unsigned long priv[0] __aligned(sizeof(s64)); + /* Broken Suspend flag for SNPS Suspend resume issue */ + u8 broken_suspend; }; /* Platform specific overrides to generic XHCI hc_driver ops */