From patchwork Tue Nov 23 14:07:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12634237 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 882DFC433FE for ; Tue, 23 Nov 2021 14:10:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 553F81682; Tue, 23 Nov 2021 15:09:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 553F81682 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637676599; bh=dCX+uGdbpQ8tWYrHKk7w4kEbK30LKGVN/wnefIjHOTc=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=T+XnyO0w963l498oJvQxDOKHhAGBAc8UUYDpHPN6CQWGE+nTAnbTLWsdzGG2LOO/M j3NhJBjoO3scCax1KO3U273ojJUOnlrDvlSmJgvuuJOgHylSAGcGxWNBq+yPRnWana 2Csk2p9w7lQJf7cwCT1tYRCmEcHm0hIVlSqgcEms= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9826EF804EB; Tue, 23 Nov 2021 15:08:23 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 510B9F8049E; Tue, 23 Nov 2021 15:08:17 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2056.outbound.protection.outlook.com [40.107.94.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D067DF800E7 for ; Tue, 23 Nov 2021 15:08:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D067DF800E7 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="jxrfvKJ2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZlhcIxgHbDnDBy82Z1JEPt+8+rR6naX6zS48PpL5XZPM4td7+GLXaQCH9ObP9nGk+1o3G+kxCCy3mFSlxUTB3duR/Eszt/Fb7p5U6xoucxuHF4d2CeGcD21EQoygq3QwlvDjx31YGjQ+ZooT4PQ0/Jts7hkcRsUbbR2Zeew7wBTulTFtHJHd3ZZTvITPSgqNuQ4tfe6EK04/nUIh4hxABjPwYUB6tHycWy6YncNAN3DPqiQAe334sHSyKPoToh6QbwJpa8lsHjNiKT0NJd8r6+mu5WFROKwVoQqiCRw2g8eZFAcGOFJSKyOHsp3Ku1CKEoV5RhIqq/AI1qifhH/PzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VtAtEDbZjKim3rmtX8lxKLp/G0Xkhs2YL+72nKHHQ/s=; b=H4e05SmQ6RC7EycFQ+/xLXdv//CKVDK1IIh4f/k4U/PeWsf3KE1SGLoS+gVBF7LqqAqQN8hOiUmroxMaOxsqNHK86Y1wU2clyZFbjkGuqB2ozmUp/ErtSI1259KQO8Yz4qLDNXWIUQgxJTINDcGnkJbo1ikLwf7/jcwZ1Sbpmn+OInYaclrd0BTspUI70gsxMSOSZn6abvv4DmeP5JKSGBkwPQqbXIt/ghFRptbYqFrs/3oIxgPDA2mRdeMom3Gm9ynldDns/AigZuSfPGDy16dLAd/Xap6J11C1jaWQHeEn9ESohePG7GGcBpn+1O8p5rTGXA4uBGEp4LQjp99BbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.36) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VtAtEDbZjKim3rmtX8lxKLp/G0Xkhs2YL+72nKHHQ/s=; b=jxrfvKJ2QKcETlHX9PJfvW3PAVRwhQvhcrS41ccAr5h7rxRtsYCurxk83xBjMtzMzkhh3yIFxZO40ubisZjXK8vFlGNmdEO8SbnYxcIh79ymLtUAQx/uVptBvXflPRr14mUrqE35ttcGqumbWrwd/J/WAf2LhJmD0yyNgbq5TS7Cd/4oCswH/WW0yXlmz4bvzpCtsMWzK30XeQ3mEJ8O2qZsWZCjlmn2bdQG2t6OsqtDe3UWw6DLyL/Z/KQgutWmoArfNc97gBnVh+xILux5+fKN34Jhwh41cVcZb2kAb3yVCZmUERFf58QGksA/cYKlOUNHqAGYwKvaHRY5QCcieQ== Received: from MWHPR18CA0044.namprd18.prod.outlook.com (2603:10b6:320:31::30) by DM5PR12MB2582.namprd12.prod.outlook.com (2603:10b6:4:b5::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.19; Tue, 23 Nov 2021 14:08:04 +0000 Received: from CO1NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:320:31:cafe::ba) by MWHPR18CA0044.outlook.office365.com (2603:10b6:320:31::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21 via Frontend Transport; Tue, 23 Nov 2021 14:08:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.36) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.36 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.36; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.36) by CO1NAM11FT061.mail.protection.outlook.com (10.13.175.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 14:08:03 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 23 Nov 2021 14:08:03 +0000 Received: from audio.nvidia.com (172.20.187.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 23 Nov 2021 06:08:00 -0800 From: Sameer Pujar To: , , , Subject: [PATCH 1/6] ASoC: tegra: Balance runtime PM count Date: Tue, 23 Nov 2021 19:37:34 +0530 Message-ID: <1637676459-31191-2-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1637676459-31191-1-git-send-email-spujar@nvidia.com> References: <1637676459-31191-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0805cfd1-82d4-47b9-102a-08d9ae8aaa6f X-MS-TrafficTypeDiagnostic: DM5PR12MB2582: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1775; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YJr8Ay0MD7RhMgPVCns4GXgybV9wMchGMh5Ly3k9dZG4OpNB1fxTWQ0jWfjUbudAQhVT9jpbmtP5vRlTCLkkdqY0Wm9BXaSvX1xgE5JO4nwYMfPiz4m0uaMwIqKYrHjDE/72RdwFtKjezrlzIOFsrQkIOXdVLSQOvkteQqQa3BrpP/yzvOW2Oy/ZkoGIxzvWlKQenCXBW1u6e7euW1ohceFxSDtL4g4Y0+SbgoN+8BCwCmy1ZjyqBpMKP4xnRKd8UaUz5pKtAY5ij936TnhnFYmxfOBw46B3EsmbZ70a/QCbc8fk1b6v1bvmglYvfC5XLW3KHXbBBgFGcPhjwacPI5NLKEsKu0Kift+W3fLtGCSIZdGHtnJ0SNPzEk3uPe5N9LeRPWGslde1Xm/cRLu6JR5zMZI1Ws5mUBTswD7WpGBEyA93VMVEokC1/RcokVoO+ZNLNhS4cqeR3FaQmkLmjRIhdSg9/AZ5Iu3vlrXadSXulQdggAi0oDckUJQkMRtdYS4XXiIpeEc1eRAv7zI1XRvcWOI2VfX5ZCCx0gNzHM/kAjbYgt0veRr3qcFv1EKHWVp0EGWfEiRvc07DksZQoVa/SEt7VISToIOhpJV5lBnfhdOrKOd4/xXV9k+uW7q988lCBpPkfUUsD9kgjzFAPpXm2ajcqsypGwmufl5KsbgU/RMwUHeu0tHTVLkxCRUPxVH19UB7/cnPcoCWjbw24g== X-Forefront-Antispam-Report: CIP:216.228.112.36; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid05.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(36756003)(47076005)(54906003)(83380400001)(8936002)(82310400004)(336012)(186003)(508600001)(2616005)(7636003)(26005)(70586007)(2906002)(70206006)(86362001)(7696005)(5660300002)(356005)(4326008)(110136005)(8676002)(6666004)(316002)(36860700001)(36906005)(426003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 14:08:03.6221 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0805cfd1-82d4-47b9-102a-08d9ae8aaa6f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.36]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2582 Cc: alsa-devel@alsa-project.org, Sameer Pujar , linux-kernel@vger.kernel.org, stable@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" After successful application of volume/mute settings via mixer control put calls, the control returns without balancing the runtime PM count. This makes device to be always runtime active. Fix this by allowing control to reach pm_runtime_put() call. Fixes: e539891f9687 ("ASoC: tegra: Add Tegra210 based MVC driver") Cc: stable@vger.kernel.org Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra210_mvc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/tegra/tegra210_mvc.c b/sound/soc/tegra/tegra210_mvc.c index ae00570..c9859e1 100644 --- a/sound/soc/tegra/tegra210_mvc.c +++ b/sound/soc/tegra/tegra210_mvc.c @@ -164,7 +164,7 @@ static int tegra210_mvc_put_mute(struct snd_kcontrol *kcontrol, if (err < 0) goto end; - return 1; + err = 1; end: pm_runtime_put(cmpnt->dev); @@ -236,7 +236,7 @@ static int tegra210_mvc_put_vol(struct snd_kcontrol *kcontrol, TEGRA210_MVC_VOLUME_SWITCH_MASK, TEGRA210_MVC_VOLUME_SWITCH_TRIGGER); - return 1; + err = 1; end: pm_runtime_put(cmpnt->dev); From patchwork Tue Nov 23 14:07:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12634239 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DE9DC433F5 for ; Tue, 23 Nov 2021 14:10:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4E65B1690; Tue, 23 Nov 2021 15:09:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4E65B1690 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637676604; bh=Wh/3ygNUgU40VxleS3sA2AglRgcNpajgxLGSWdzLP9Y=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PhN/NQjXm53KkMl8uDMoQowygho/Q5bsBWSHY8q4z1DElECEN3huvKzL/UruW3e4S /YKwGbXkb3QQr2nbSr18Z/R2nihDdZ+PzZjN4w1yhYDRxzUaB6p41yccLmRGKRpBNr AxapU+m8l+ZwcIlhEIi1OnQrPS6B2Es4yCuoZjpc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 54F79F804FB; Tue, 23 Nov 2021 15:08:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E99A9F804F1; Tue, 23 Nov 2021 15:08:23 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2067.outbound.protection.outlook.com [40.107.237.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A3088F804B1 for ; Tue, 23 Nov 2021 15:08:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A3088F804B1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fRT/Kxft" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mST+NzEPmLVDv4cIOcHdDt1j6VeZB+Kd9lGUqF2DiyYHJghOElEEyWdIHtcrtoBBKiVMMiiDnQ+SECas8pbrbK1CRZkY8C06Bjg/0po35Sog/xK4n6jC3h+LWgWaE/l5DFn+mZnoQe3mw9AS6dEp1Iro4qx5JfS4pHH7ujO5UMcC+WgJhhTNSdRnZ5HHXGaX5SDO2JoaZvvjKwkwmRs2TuLMjxTY7DhYWsA5DpYtMtRrSGAubM7Ca2oEDjd5IKvmazorQBtWU+gswrVlzkjZeodn5p8fyLM2Y5V87LLMvQ8S5d4DZE8JSz00RI99MZUC5+R0hlnMpVn8LCHxEcveGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1BVQqbO/azsP7xH9wz7q70yDkNkHpn5tWo3o3k6/IXE=; b=eBJMru0p9E2UHRpLCE8C51V0vbGmbQ8Pfv9vJd/z2thpdM7XqOSokQnTkM/2/l42vNuupX401SbbFfOJGb/Z3Ldp94aVXl9fJW/MTSsNLL4QbtNWQCleFG4ll30kZ5VO/ozFAJYLIEOsuAQphJ4ljy0G1ndPYcJJYUiABqJWYnNqu1lx7blfzPlFrr4Q0Bkflvgfa9hpwukHvQ+TA06BydWzg9nYuTRSpPBj/Jafe2q8UkYxhsa9STx5IjHbNAl7dFOzkSxC3ih6XgfI0PDO+JunKvjfq03Hxif6th2rCKCdn5VbRrS69J/e30pxncIx3R9aqFUQ5a7HDHOU1Gn4Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.32) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1BVQqbO/azsP7xH9wz7q70yDkNkHpn5tWo3o3k6/IXE=; b=fRT/KxftfCBhHIAy8OWIvpkJYgieB1QHM6i8rglYRxfXR7JNq0aqczRil0O5+QQaOjVY6te7c4GDDHtDRr0IUUNMxhS6Ny6JtyTZadcYbmnAs1dQjQkFe3xpiZlp4m9wt+eymMqqHa7B+/lfFOgOO6DYphU6B0ob3eny99AuujD1nXtRsSG7G/2olVp8obquN1LsL0dc+ylrXE3WnrUmbPf2I6yFsCicJUyq0Jasqhg317FNc0K1nfkszb6VgcALshsGP5lQxCgLF8HFyfNZQMawW2+CZ9l16vVXyTKJs8T1m0bQalq2lTqTwpOAI6HjnbzxmRvMBhHm4XtMt9I4GQ== Received: from MW4PR04CA0038.namprd04.prod.outlook.com (2603:10b6:303:6a::13) by BYAPR12MB2870.namprd12.prod.outlook.com (2603:10b6:a03:12d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov 2021 14:08:07 +0000 Received: from CO1NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6a:cafe::b6) by MW4PR04CA0038.outlook.office365.com (2603:10b6:303:6a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Tue, 23 Nov 2021 14:08:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.32) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.32 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.32; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.32) by CO1NAM11FT031.mail.protection.outlook.com (10.13.174.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 14:08:07 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 23 Nov 2021 06:08:06 -0800 Received: from audio.nvidia.com (172.20.187.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 23 Nov 2021 06:08:03 -0800 From: Sameer Pujar To: , , , Subject: [PATCH 2/6] ASoC: tegra: Use normal system sleep for SFC Date: Tue, 23 Nov 2021 19:37:35 +0530 Message-ID: <1637676459-31191-3-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1637676459-31191-1-git-send-email-spujar@nvidia.com> References: <1637676459-31191-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b30f193-d12d-4158-813d-08d9ae8aac7f X-MS-TrafficTypeDiagnostic: BYAPR12MB2870: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R9tVB4i3pS2WbUxg8hHpXMjyTv5jMK6XSVUJJ/wop/mldxDIDYPLmwgNhMlvOkBWC+Q9BomToMWcifa8aJcYQlCuZt5peeCqBGoCe1PYWzQM1x/K/1KMhZMEt39QzrrLDBCd1ZM0lcs9ubmQNeJzNlmYJoP6mYBdEuDfwaTsPXOO4h7P8ZuendY20ZRkGYTCNMCpwwWmegMnZ2qYDVT7nKoi+cBQmknzcFj7VDFuaJ0n6G0s7/z9y6gZOUIKlulIQIJHiakSBEu05z8PLHUVBu6XBrcQToQr9b3VreZ+dkfaOC00dqYvXO7mCkVZGajALAGLOC1txFTmHJpYgWml+yHcnpxwqA/47WBNTDmxpmWLcFfSPsDtXHJiwD1x+inUFPv+vA9tFyLHgCh16R4FFmXg5FSYG/EN0ZscpNGxLwLToCYzbNZifcpI7WKYoWHEIULJFFk9N8LFDNo1hV9KKp1Bhj1/ZscwxcYkOBynA9g1YeR1e3yznq6yMMRkx5FKj++25V2i0Ziw7IMZRdNCvXU1c5SFnZ8pMEQuzcKn9MhpZHtzNjSC7BvPiAxWk33aszC/o+Ok1yDTD++ZtXww0/V+en7dzdD7lea5jeJ0U//THOpQ4iEVG7x42IWQ5VfJ5xRFtTOQ14e8UU/gBRW6HhihzJQk67stS4MsSZuItAKV5mHonrKqrzzAmdhNfom1aYMCfVHXd7I926lrp92jCw== X-Forefront-Antispam-Report: CIP:216.228.112.32; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid01.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(5660300002)(2906002)(86362001)(110136005)(356005)(83380400001)(6666004)(8676002)(8936002)(7636003)(70206006)(186003)(70586007)(2616005)(7696005)(47076005)(36756003)(36860700001)(4326008)(426003)(54906003)(508600001)(82310400004)(336012)(26005)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 14:08:07.1273 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b30f193-d12d-4158-813d-08d9ae8aac7f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.32]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2870 Cc: alsa-devel@alsa-project.org, Sameer Pujar , linux-kernel@vger.kernel.org, stable@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The driver currently subscribes for a late system sleep call. The initcall_debug log shows that suspend call for SFC device happens after the parent device (AHUB). This seems to cause suspend failure on Jetson TX2 platform. Also there is no use of having late system sleep specifically for SFC device. Fix the order by using normal system sleep. Fixes: b2f74ec53a6c ("ASoC: tegra: Add Tegra210 based SFC driver") Cc: stable@vger.kernel.org Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra210_sfc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/tegra/tegra210_sfc.c b/sound/soc/tegra/tegra210_sfc.c index 955cecd..af33bf2 100644 --- a/sound/soc/tegra/tegra210_sfc.c +++ b/sound/soc/tegra/tegra210_sfc.c @@ -3602,8 +3602,8 @@ static int tegra210_sfc_platform_remove(struct platform_device *pdev) static const struct dev_pm_ops tegra210_sfc_pm_ops = { SET_RUNTIME_PM_OPS(tegra210_sfc_runtime_suspend, tegra210_sfc_runtime_resume, NULL) - SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, - pm_runtime_force_resume) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; static struct platform_driver tegra210_sfc_driver = { From patchwork Tue Nov 23 14:07:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12634241 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05839C433EF for ; Tue, 23 Nov 2021 14:10:32 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DE08E1680; Tue, 23 Nov 2021 15:09:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DE08E1680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637676631; bh=USR0sRk2eF03MlfUPRit3WfckUnVbY8QRCgzvvyNX84=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=S+C9ngM0Jl4AlSC7ItxRMhNhyoutVbzP5Z8dywNlpjllQ/1FqB66i1iW+0fRSh+Oj TdY8vHu4e1v+aHKkgoKhhgjU/Mp6ivNFAHJJpOllFKOrimoDlw8JFYVAYwUpKM5D4h DoTAFKB4YwyH4Fh6l20bFre9KfjdpezyGOHQfhW8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3704EF804F1; Tue, 23 Nov 2021 15:08:27 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 46F15F804FF; Tue, 23 Nov 2021 15:08:26 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2069.outbound.protection.outlook.com [40.107.95.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4E30CF804F1 for ; Tue, 23 Nov 2021 15:08:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4E30CF804F1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="tuz7AGCZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1+hqR7ldbCF5jvtV7h1Mk+mCrFHApF0MDL+kNAazcacpM1U2gIAdSstZ5CFvKa9UUpXDagvcHOVhbGpeSavltHc8cPm/c+aiitOMURElNeOL69SjTdzPDCfmhpU+HM3eD5xHjhWDjd5tMfcoN+0u74J5/nP/MXBYCNVHMbCoamYW0DrjiBx79bHtxUh6pg33Nnydv6za7kZ3t3pz+YMBYTaBSyAhCnQU+5LtAPLMVb43D5Dngfj+lN5RkWSacKdY7yR43FOuIfgEMXruCThReygUFZTSywZ2y+leih59uo4T7woxhSfuiFAXw8Na54cB8WDwDP+jps9PDB0tG24ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1zvqjdBOifEyewf9xaPflazK2Q3w0w9Jyb8+pb3YUY=; b=i55VUlg2Il3yB13nZH/pRIVs5jGMuwW6CAO1AM6JveQPJow7R9qmmyTZ2DOMxXY4J0NqjnzHPr40XhAzwIm58lUEX9eX30JyTST99L++PUX7FLDPR2BmY0J5AVFySD2N9I/6lcaxEd35xZ1ktpThWVhkuqbuhv62vw4a8ZosnBDpwl+D3CkCfYbPl8QHuicyPJkCGsa+iuPeuXUB1ia6qx6tO2D2eSZQu8agcIoDOksY6c6YJJzKmAPT0T6p5YXqi7nMDLsuvMLCsI4ZquJWR3v/jUpCLFsZ0LmmwLn67At1WoDrB7b5sFybJnJXLR41xoP2VLFBXfSyl4NvEq3+7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1zvqjdBOifEyewf9xaPflazK2Q3w0w9Jyb8+pb3YUY=; b=tuz7AGCZ44K16ERb2MGA1ytzv7pIr+h65IGji60GuLftzTug+0z0uKXHKKa3XQr45hS+S+ro/PA+on0KKcJN+Vd5oaMLYG2de75TWvNPIsK3QJO4joZjDXfnqtjEPmfr6zWLWf4UwMoDnJynGINAui3IBeRp0/2F/Xe3NLbTXXy4IWWJoezZJFkA3RPl0vQibSJ5k+WVNJp3t8llFHc98ugdGA1LuWblL2MfJqVdms3sf1jlzhH6AECYvmf2eQOji+K75ODlaYy+HAscCuG9WDZLIV70PKVZ13Nam9H+xBmhtOx+2dK8yX6xi1KK3Uamz9YXSj2sCxG7JGbvN12IJw== Received: from MWHPR21CA0067.namprd21.prod.outlook.com (2603:10b6:300:db::29) by BL0PR12MB4755.namprd12.prod.outlook.com (2603:10b6:208:82::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Tue, 23 Nov 2021 14:08:11 +0000 Received: from CO1NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:300:db:cafe::68) by MWHPR21CA0067.outlook.office365.com (2603:10b6:300:db::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.5 via Frontend Transport; Tue, 23 Nov 2021 14:08:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT063.mail.protection.outlook.com (10.13.175.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 14:08:10 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 23 Nov 2021 14:08:09 +0000 Received: from audio.nvidia.com (172.20.187.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 23 Nov 2021 06:08:06 -0800 From: Sameer Pujar To: , , , Subject: [PATCH 3/6] ASoC: tegra: Use normal system sleep for MVC Date: Tue, 23 Nov 2021 19:37:36 +0530 Message-ID: <1637676459-31191-4-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1637676459-31191-1-git-send-email-spujar@nvidia.com> References: <1637676459-31191-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b4ded4f-1099-4b30-f8bc-08d9ae8aae73 X-MS-TrafficTypeDiagnostic: BL0PR12MB4755: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H3PPRfIc/iEIU+nPqOIjCQtxxjZfU1ZEIsFQIC0oxz3iSDNL3L2+CVR69E09pp5m1XXMhmvUu1XJ9iNg4HjCT8LGz9Fy2VFUIkuKLR3K/SvVDiJnkPIU2L5AJeSaBsuETGrNP45djTMGrpEEvtRyyrVYuNL2C8QAukYjfyV23eVPwEJR9+m4MyOEwslSy8pgDX+cf4YZ+7tpQKdnQSifRlctFeSFb3QijeVLJ40TG9hooy9gfLP43tpJRqtzG/T+JTuzJyeihMsRBXGVH5W5gKVjH2zXtR5afkljJqHxfhLoPxxc9/QjQBA/fGX0+VMGqDVdGf6Kw9RjLDw/FXxk/63o8DV/yxPuXs8sOYSKxhag5C/ztzj7w2aZB3boKKWfK2RCCP6PZZbo5MuUjlFNhx7c3myRHgYZBOx6cgviRj4dPLdbRMMmI27IlZkT6I3SfAslMJWT9977G6VaCf2cVo++4E9GUPu4uuuxve5E4puqCWDbp009qauAv1c0B8YZw0HF/HwaHALVFouTFQg8kaCzym3gMcssMEegjyQUDJ93AnYqWhvYLUrSSpGlfouN2Wm6/P/XRGZzDy87uJnWV0bnE7AJEmLykrZEEl8OLkIW3YtXWQUvEJb+PY6lHAwKdcf+5MU678Cn4rHew/4s13fSn0sYhSvkp4kijBABwlVOstEDKhQhoj2xZtJVyElyQrF849n430XWxgdI4iEHZw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(426003)(47076005)(356005)(7636003)(36756003)(2616005)(83380400001)(2906002)(70206006)(70586007)(508600001)(8936002)(7696005)(6666004)(316002)(5660300002)(36860700001)(86362001)(8676002)(54906003)(26005)(186003)(336012)(4326008)(82310400004)(110136005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 14:08:10.4112 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b4ded4f-1099-4b30-f8bc-08d9ae8aae73 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4755 Cc: alsa-devel@alsa-project.org, Sameer Pujar , linux-kernel@vger.kernel.org, stable@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The driver currently subscribes for a late system sleep call. The initcall_debug log shows that suspend call for MVC device happens after the parent device (AHUB). This seems to cause suspend failure on Jetson TX2 platform. Also there is no use of having late system sleep specifically for MVC device. Fix the order by using normal system sleep. Fixes: e539891f9687 ("ASoC: tegra: Add Tegra210 based MVC driver") Cc: stable@vger.kernel.org Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra210_mvc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/tegra/tegra210_mvc.c b/sound/soc/tegra/tegra210_mvc.c index c9859e1..93cbeb6 100644 --- a/sound/soc/tegra/tegra210_mvc.c +++ b/sound/soc/tegra/tegra210_mvc.c @@ -641,8 +641,8 @@ static int tegra210_mvc_platform_remove(struct platform_device *pdev) static const struct dev_pm_ops tegra210_mvc_pm_ops = { SET_RUNTIME_PM_OPS(tegra210_mvc_runtime_suspend, tegra210_mvc_runtime_resume, NULL) - SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, - pm_runtime_force_resume) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; static struct platform_driver tegra210_mvc_driver = { From patchwork Tue Nov 23 14:07:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12634245 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C9B7C433F5 for ; Tue, 23 Nov 2021 14:11:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7E96E167D; Tue, 23 Nov 2021 15:10:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7E96E167D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637676679; bh=uKdWmmR8TevLZCl8+IbwImjBhKHuNHdfuK+2GKp0V+U=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Z1RqUvtO4DV74dye19oQqfD3CG1Fkj0P1wd+81GIpRatazW1AYEdDEC310jxCH6vx m+xfKcu3bGGE5+bxC/b1ncAgQwNv1mBtTLf3UpSDud1+tspWmkhZvOYA10YZF7pSW1 CRsALedxQs/NrIHDeQMKbbcY4bJRvcPitJErkc4Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7061DF8051A; Tue, 23 Nov 2021 15:08:34 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1FD29F8051B; Tue, 23 Nov 2021 15:08:31 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2041.outbound.protection.outlook.com [40.107.243.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9D1F3F804ED for ; Tue, 23 Nov 2021 15:08:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9D1F3F804ED Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="UtPVfdaB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PFing0uk8KXA70EZHdJC1K7tPVAP3DG0en+bOVtd/Q0E5TDQmfEk1V8HXlNfm2drMUUMWHBodeyfsZBLgTuVr1i8wZBFAuv+2YSirir0Hozp0j+mkwMAYBnCegjJN480BoMBJdnOWxLE3okAh2eWQ1lgVhyo+KTcQTnaM9xDC0bIictDIw86d+YSRmIwma5+xYQTmahv3DC35QMZkEO8ulaDM0QV9/ARghuK8PyLaw2wiulP+EYE0xIhg3p0f0Zz18nlflbz+pQggmz1x2a8YRVGSRiT98TnAEYa/6yrmQCTwvH4QTb59kbbur1QQ3l4GEl1lLMm7BWlNHf1OI3QAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=88HRFlndMgZw+NFWlebp3u5EBaZ3SzxrTK56uBzL46s=; b=iJ/Ma2yNvECQC82vMsox6mIp95hnH7vfEI+xdPAUUhzE9rBDx0v9jwJMSSvmK9xVst9ykOLtnmQozuwBIkKg9Cbbgot1BV821wStENWbdmkV8w1UMwL71gsv+IGOcaowfUuw6nfK9rLvJ67om+wf7qzhC9IPGVdtHflYcjBo7g8qBG6cPYlGZUFNiC66tTlZIQ6eHyZt1oru6aIF9bDgHe4+vVCymNVqnybf4RsP5jvaziPAec5qxV1NfJBDNWvOk5JAZ/YSGTHaewmYB3jLWz7SEf8Tpyvco/6LWM8KrpG1boMgRLuC4PJfUfeYQxnQVDn+eoqSN+eAx6Sb9WK/5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.36) smtp.rcpttodomain=perex.cz smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=88HRFlndMgZw+NFWlebp3u5EBaZ3SzxrTK56uBzL46s=; b=UtPVfdaBrJoGnpECjGv5Q88ndZMx+uEoJjLQ6FeKGYisDKKTfoUZOASJBMX5SsuFi/ULVUUkWvuR/yDMEgNn1vND3AVXXwcCo5CgMFJaXi29Gra+QJS8nXK84cryND4BBPGGyEMGqUuastTv1/XSdbPa/EfMPYcRyDODBoqDceMRIsKOMbIlfRur4Uu629ZmIiDwINcmVGDr6EwgvOorzutWpJOIEk5Mjtranerl0s7xKDuw+4YURYYNuuHKJUMj05lkHJeKBK0UUCjlasLmqf6RIDU4C/rW1vmrsol/iXGlwiqc0SO/mXw/NbKCXmvmR3xfvzjOa8YDlS8c73qsmw== Received: from CO2PR05CA0071.namprd05.prod.outlook.com (2603:10b6:102:2::39) by DM5PR12MB2455.namprd12.prod.outlook.com (2603:10b6:4:b7::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Tue, 23 Nov 2021 14:08:14 +0000 Received: from CO1NAM11FT060.eop-nam11.prod.protection.outlook.com (2603:10b6:102:2:cafe::9d) by CO2PR05CA0071.outlook.office365.com (2603:10b6:102:2::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.19 via Frontend Transport; Tue, 23 Nov 2021 14:08:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.36) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.36 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.36; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.36) by CO1NAM11FT060.mail.protection.outlook.com (10.13.175.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 14:08:13 +0000 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 23 Nov 2021 14:08:13 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 23 Nov 2021 14:08:12 +0000 Received: from audio.nvidia.com (172.20.187.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 23 Nov 2021 06:08:09 -0800 From: Sameer Pujar To: , , , Subject: [PATCH 4/6] ASoC: tegra: Use normal system sleep for Mixer Date: Tue, 23 Nov 2021 19:37:37 +0530 Message-ID: <1637676459-31191-5-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1637676459-31191-1-git-send-email-spujar@nvidia.com> References: <1637676459-31191-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a81f014c-5068-48e6-7c3c-08d9ae8ab043 X-MS-TrafficTypeDiagnostic: DM5PR12MB2455: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3E0WSbZNCr6kKt1HsPM0lHdnOLjX9cmJ2aoblHs92Rvb0UEz2XIcXfV423al83yNmc9QinlAOhoUJA+by29U6ZKCsDuHYOG/jmxkDIkFswXA5yGpB0yyhMgxjAVO0BRx4/OpTFPAiyxXirxq7fythd9GVWLkFcaVGEyl3u/F2fYWuszI5oSvoiiswzQXgB4pGv/qCY49xtmzsUO6bFVMF1HgPNNB6Xb4QAZtFWeIvE/Pk7hmz/FE11DnUBpsKLMonyH6jxOWWPO1RFfs37TUrxrVNRdE06fsFGGX7YSxGGLMYh7AJXbE22NdVUNWCeI+iY6mUqRL6dOTOB9pWtlBBaPMzvzacY/R1SuX2DSuqOrca2YJwFBygN0e2jB+8arX6M0aTbzBEyx8PDr4hWviRMCiN4qrJx6n/pPhypNCOxdC5qLGo1jIDBfZ3Hliv2RuBlr5WLflhE+fp7WqhfeaL4jdOoWBd1WrndNLBjH0y1FrBPr6oayaCd3prxHF/KywVuqv/S7XlPOPPKQgduTOI3XIcRMnh1VEWsiUj9WdDwPMaWDUEQmZYEoyJXvYSnt/cK2blUdOwqTEAo7QLIPjil9ppwOP7kaSlN+nZccoTA2P3LO5+rmyONHBNCgRVRwQjXcJ18+KaBvFRPNAaKzkxFC4/B+254o397YIWN6vKqU5yK7DvClg0FrJGKDjZZl4/xkRUA4ZOOQYdIzy5XS3hg== X-Forefront-Antispam-Report: CIP:216.228.112.36; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid05.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(26005)(36860700001)(7696005)(186003)(508600001)(336012)(2616005)(54906003)(86362001)(7636003)(8936002)(36756003)(83380400001)(316002)(110136005)(36906005)(70206006)(8676002)(2906002)(70586007)(6666004)(356005)(5660300002)(47076005)(426003)(82310400004)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 14:08:13.4499 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a81f014c-5068-48e6-7c3c-08d9ae8ab043 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.36]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT060.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2455 Cc: alsa-devel@alsa-project.org, Sameer Pujar , linux-kernel@vger.kernel.org, stable@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The driver currently subscribes for a late system sleep call. The initcall_debug log shows that suspend call for Mixer device happens after the parent device (AHUB). This seems to cause suspend failure on Jetson TX2 platform. Also there is no use of having late system sleep specifically for Mixer device. Fix the order by using normal system sleep. Fixes: 05bb3d5ec64a ("ASoC: tegra: Add Tegra210 based Mixer driver") Cc: stable@vger.kernel.org Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra210_mixer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/tegra/tegra210_mixer.c b/sound/soc/tegra/tegra210_mixer.c index 6fb041c..9513034 100644 --- a/sound/soc/tegra/tegra210_mixer.c +++ b/sound/soc/tegra/tegra210_mixer.c @@ -670,8 +670,8 @@ static int tegra210_mixer_platform_remove(struct platform_device *pdev) static const struct dev_pm_ops tegra210_mixer_pm_ops = { SET_RUNTIME_PM_OPS(tegra210_mixer_runtime_suspend, tegra210_mixer_runtime_resume, NULL) - SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, - pm_runtime_force_resume) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; static struct platform_driver tegra210_mixer_driver = { From patchwork Tue Nov 23 14:07:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12634243 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40177C433F5 for ; Tue, 23 Nov 2021 14:10:53 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0C0361687; Tue, 23 Nov 2021 15:10:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0C0361687 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637676651; bh=aFzUvJkokdbBnY8yaYFnk96BliL4alVu0+PUAp5GWLw=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AxJQTYABYCgfnDcwXJv3K8QO7DkjqduDwftdODb48b0278DFUBijMEI5v+RHlBnoe vghQKHiIdCI0EJ/0o/3ci0aFCmzFyW593TrcNHTX2ORI688Mjaa4HsZLHQjWlIKKqW OJiy783hM+DKPhP8JzDU4hQPn3bZae8Qx0IH4j7g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E67F4F80508; Tue, 23 Nov 2021 15:08:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 949E1F8050F; Tue, 23 Nov 2021 15:08:28 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2047.outbound.protection.outlook.com [40.107.92.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 14327F804B1 for ; Tue, 23 Nov 2021 15:08:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 14327F804B1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="f5LNDJES" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f9vA1dJvY8MM+zu064hrL6qVd2VepbkRV2ldL2wQKTcWfrJzb9gJ7c2qxcBaNDhY3kOZmp5ThcvGXi7J51TE0U8TAnPiMo6ji6JG8MUrN5pnSiYoBNPn1ep061Ka9IU6s1WrVkC1zhj7jqSM1qWUn6j04N+jbWQinRlwFIMrXDbVYbYoL6SRX7YMQr/Dksi90aL1Tx3umG2toQY4geE4Tgk0pjouUbHBXvnORtxwlVNrA8U9+dgrV3zFzfPzM+lDfITjkw+SEhfJ5H6vg2sCGSDBcGeDYn9ZkqwJrB6MMHjvp7IpvX/uU4VI5X5GYvzNq3nOzUTsoIg6iBpFyNLYzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tt/jDR0plueoUqBk8rYHPumqYY9Hk+gpqr5Z8SgzxMg=; b=ewMDM6ubx38OnlV4F539/vsCCf3+B5jKSWNrdVlkEK91kr7kKA5LcnBc8CK4qbVvj//qcbQgc/rCnuU4vnu5AtAkm3TnSal+pNrXPUMWeFCJT8Hkz/7A1W/wa3Qs9a9Zo1ptm2IYTx0qhDAweoLJ1w14yinO9wrTxzg5KqTAWJ05kdMuYHcLtrRYLaidwZCZ6ZUbyoyPeDGPt/iKxDafX9kdVmaHhtpe5H+SK/JsnvM4s3PZ2Ve8dvOKDa5mX5RW+/QHGzuHteMFDLiaoY6Bsf+oZHR3di1MXHZAZdVfcXjGmmCEqW95poht+0H7wtUDqebvC8l8iKCn38zOqGdVpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.32) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tt/jDR0plueoUqBk8rYHPumqYY9Hk+gpqr5Z8SgzxMg=; b=f5LNDJESBBmz73AWWsAytD6VSO38urLgVVhoQWKaXI2P5XAZGF6xTFR/yIsvBNnJs/m/phG4hYESaQLvE/z8UyLTOxJ1xCyn/4flPJdg7Cshn29CIn/63GgMsNq5ud7RtuoF6odeqF9+ntsQnHjarSbFtknxXHurgpH0ppqu1RURUtpSNTYxuNU7cAJEPsQ7f7r+lgcjX9+pDLZgLrUACl23BW8WMA0RLMh9TATWhVRHEHXnUoDG10MJLoHh1q3yxMoyqQBagbZTOJVntxrjwFu2Yzn7sDfsdM96W9p+cWJQ9u4Ji4CWTE1WFj8UMZq+o8tgZQoapzkROwqU/cPEBA== Received: from MWHPR14CA0002.namprd14.prod.outlook.com (2603:10b6:300:ae::12) by MN2PR12MB3790.namprd12.prod.outlook.com (2603:10b6:208:164::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Tue, 23 Nov 2021 14:08:17 +0000 Received: from CO1NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:300:ae:cafe::ee) by MWHPR14CA0002.outlook.office365.com (2603:10b6:300:ae::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 14:08:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.32) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.32 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.32; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.32) by CO1NAM11FT055.mail.protection.outlook.com (10.13.175.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 14:08:16 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 23 Nov 2021 06:08:15 -0800 Received: from audio.nvidia.com (172.20.187.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 23 Nov 2021 06:08:13 -0800 From: Sameer Pujar To: , , , Subject: [PATCH 5/6] ASoC: tegra: Use normal system sleep for AMX Date: Tue, 23 Nov 2021 19:37:38 +0530 Message-ID: <1637676459-31191-6-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1637676459-31191-1-git-send-email-spujar@nvidia.com> References: <1637676459-31191-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f20eff0b-6bcf-4360-08df-08d9ae8ab20c X-MS-TrafficTypeDiagnostic: MN2PR12MB3790: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q+T0fXJbeBM6oIoCLsFp8EgEigeXK9U2DAMkbEKApOBD3Taqd4Z2WhfNuBFwZO2J/GnXuEH9RuwvLzp+7gZVmydwVy9CnV3tIqoFRT2pDPppxmhMRORkcd763El+/K9RxiFf74gXrYrMIO8NyF1bI6FY/TBQtzJbUWt7t0jHUhNh85cRhIw5uoKrswvPjC5qxicygtjzYfAv9F1GKlXsPayDoxpv5vFHNP/EJvrqgdQsI1fNmBeFVYJIp26o375+2+YwLcN6LEHwNi3G34e4hs1UspRCaH+rUrDsBefyEIKKmfZRj5gaoTA9ivv8Y3JIkP3PKgZhLRIbWiGtYDbU1urav3Nt+HjhlHsnLyUYpqcynrUhq4HatveqFhn1NqGhDCsmhI4CtRJgQvH9EZSVYZ3EvUbbhVH+BtNbNbC6Ei1ZhAT0ggcuFGM4OeaVlT+/aLij0ymWR4brLi5xbjAHodjOJUaPmkwnd1M1UwLeQb0hfgEtuzp4ULZUxOEn7pGqARbqLKPfdEFzmIadiezCgu4/gTzTeFznOyrxrQJ27aS+OK8PVj5a3xV8NATRSyFWzVTYKNDEkS5+QSyVU/7Iu/32MqadgUGVD8JrvSHLFlQ7L33AVTaGUdn+dGc21Gpepzz1E4lpLP0OBmLV5g+t27LfQyiyar2j3nWZ1KMu1GnIJAg2iLEcVQ6tFmus0YUgNuc6engbK77UvCakUnDkcQ== X-Forefront-Antispam-Report: CIP:216.228.112.32; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid01.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(2616005)(336012)(186003)(26005)(426003)(4326008)(110136005)(356005)(54906003)(6666004)(82310400004)(83380400001)(5660300002)(7696005)(316002)(2906002)(508600001)(36860700001)(8936002)(86362001)(8676002)(36756003)(70586007)(47076005)(70206006)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 14:08:16.4429 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f20eff0b-6bcf-4360-08df-08d9ae8ab20c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.32]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3790 Cc: alsa-devel@alsa-project.org, Sameer Pujar , linux-kernel@vger.kernel.org, stable@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The driver currently subscribes for a late system sleep call. The initcall_debug log shows that suspend call for AMX device happens after the parent device (AHUB). This seems to cause suspend failure on Jetson TX2 platform. Also there is no use of having late system sleep specifically for AMX device. Fix the order by using normal system sleep. Fixes: 77f7df346c45 ("ASoC: tegra: Add Tegra210 based AMX driver") Cc: stable@vger.kernel.org Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra210_amx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/tegra/tegra210_amx.c b/sound/soc/tegra/tegra210_amx.c index 86ad550..a10d616 100644 --- a/sound/soc/tegra/tegra210_amx.c +++ b/sound/soc/tegra/tegra210_amx.c @@ -587,8 +587,8 @@ static int tegra210_amx_platform_remove(struct platform_device *pdev) static const struct dev_pm_ops tegra210_amx_pm_ops = { SET_RUNTIME_PM_OPS(tegra210_amx_runtime_suspend, tegra210_amx_runtime_resume, NULL) - SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, - pm_runtime_force_resume) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; static struct platform_driver tegra210_amx_driver = { From patchwork Tue Nov 23 14:07:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sameer Pujar X-Patchwork-Id: 12634247 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D5C5C433EF for ; Tue, 23 Nov 2021 14:11:42 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0BA391679; Tue, 23 Nov 2021 15:10:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0BA391679 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637676700; bh=P+M/9k01T0PuqH7qOnUC2C/FEYlYdMVK76wOm7jAr7M=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jQilB7P1kpg1B7MDlyyJYMcRm5LniSzHBGiVR9EX1/T+k8h8YPWWKlhChe0jeRtgJ zzcRRhcDFnW/ZesCCL76EB+8OGy7g2IE59zx10Wy2d5uQkCfFoRD+BpfwdgD//t1l8 2DnJNo7qF/ovaUwaHTtpACWfdTwJX4NW1yO/YA10= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A5A82F804AB; Tue, 23 Nov 2021 15:09:36 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9824BF804AB; Tue, 23 Nov 2021 15:09:34 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2047.outbound.protection.outlook.com [40.107.96.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 118F7F80507 for ; Tue, 23 Nov 2021 15:08:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 118F7F80507 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="WjZSDnjP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WEZjtI0HT3gRqIVoVTb+7ERDbRIGXyoK/Vdc4dY9wROdADfG231bEFWOpyM+IBiMQulhw7674wd8XeSLiIuubRWJbUSRtBRl3EN3m8ei63U3FBPaDdl/Ng9RVh0V0R7XFF5hsKcU0WPiSTnrNRWH+5BMW1ZVEnWJ4ewzdwwQJ6wV7lWv5CF7gY351xkqEHiHRFYAVKPoQ4fsDGVZTjQf/FAuGmfkviymedAc6dPBPt9UYLrzv6u7K1KvVCm8QQrsKfPEUxbZ4Nt2pS7+IrngmAu3jthEcY5bYWZ+vp9b3lQ1LRYqYWTq+VhNKxjMAKO4EWjNzKz2AJal+1iApSOU7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bPRrGyNhCl8uFotwftWP6yziSsSLGlkVrguUbOHeRvI=; b=UWzjlgbE2jEKzkCtuC7LB5rPK7GTq5EqR7gx1kWFvKw6Zv7qNO4v8oO39m0urdWGJQaBzPUe6s8MCEcpJgOJSORZr4EE5vkkgBqbBMAvagLlG6Vh7IV2ppsIPbj1Bo2KebB1n9HU2UllkG9LhB2QMGQvBIxwt+wPY6+9B+e/zKvsQPTcFw6Mvk0AmEMMBdyeYp3SHN7Lj50zEFBNiZ4ACUX9b7W+tk3NwS+0d5aVU8COrrVg40YEvfmgV3wfgIfvZgPbyjWq4ApQw4dPVZplQFYkgvVMWPHDAZLL+VmULFmo6AzPZWvjpWQN7/zBs18AIGkERe+MKZjBzzDNgIP6KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bPRrGyNhCl8uFotwftWP6yziSsSLGlkVrguUbOHeRvI=; b=WjZSDnjPllf1uBkz5oePDH3Azlb98kdu//QtABZwMvoiHeo/cZJeZM6FJY5Fz4HDKoQFzFNDGgze61DimQmD8MdrdSgQHR9KZ/bkdETEEoJgZLD0JjrO74KmFlL/HIyyCcM9JjAz+7sRgr8kxpDhnwgci1FMgMTmLrcg7SeO3FeSkKwH0UZXM0UYMSXqlIHt4cvxY8jtE2++PZKbdQVfgwqz+JCa7Hqo1SGzTHqd/5I1C+Kkkwuuc4jyvXiDUXZPe300COT57CDLjb+06hm96x4DKYyNqUGgBAXw6BdldzQkRc7ozzFeHyXmBflzQ0H1GbLsw9vSfIXb5yh8ClIhAA== Received: from MWHPR13CA0003.namprd13.prod.outlook.com (2603:10b6:300:16::13) by BN9PR12MB5258.namprd12.prod.outlook.com (2603:10b6:408:11f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Tue, 23 Nov 2021 14:08:21 +0000 Received: from CO1NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:300:16:cafe::9a) by MWHPR13CA0003.outlook.office365.com (2603:10b6:300:16::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.13 via Frontend Transport; Tue, 23 Nov 2021 14:08:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT067.mail.protection.outlook.com (10.13.174.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 14:08:20 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 23 Nov 2021 14:08:18 +0000 Received: from audio.nvidia.com (172.20.187.6) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 23 Nov 2021 06:08:16 -0800 From: Sameer Pujar To: , , , Subject: [PATCH 6/6] ASoC: tegra: Use normal system sleep for ADX Date: Tue, 23 Nov 2021 19:37:39 +0530 Message-ID: <1637676459-31191-7-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1637676459-31191-1-git-send-email-spujar@nvidia.com> References: <1637676459-31191-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b5f21540-525b-4024-d71a-08d9ae8ab490 X-MS-TrafficTypeDiagnostic: BN9PR12MB5258: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s4WjAGFzduXIFsUuoq4v2goEGXeTwy8SNtFL3qYSrnhsu5vsaB8WWYa0yvb90LauZ8q0cME+jqPN3wFYVs4sQ0oPtbbqsK0a9C0sfW6pA6O7YXSSoTS+rttYcEj9wkVwma3paGucpM8PjF6h3W/M+IMJrC8fmmH4Ga8OKCyahAiOtMm86DFZ/ZEVURVuZhN4TggM2QuL06WIKiz3KIE8mr8bdBupz7/YMw/EF0YWQpEWR8Jgq9jpDdR6WR321GqFcrHCttC2R5xiw91U9wUveCPTrFjwb2VzecYBl3UoxOzZZs0RHSpeujBr/yc61zJAJoKBFamOihKtIv/56CgJOiG27rT6LIZwCAWUpKgmvf8Kd5sqe0PffTZvoU+BJIfznWa/qifBPwWAhKkm00Y1lmUX5H4w4LZwGNV/sYZpf+ripZ6dGUfsYETCTTrwNF9tNCbfHG1Bwt12Rm+Y+OTIYS8dDCYE5Wz+DECTX2utJlcQuVhN/xgHCdfuFP/o/l/dQVSMRDs2dRqJGSdHjY5NqYStXMcki8ofrVfDKmj0YVjlG5h1ydaf3KmzTlI9ZoqNJEQqfY/tQ4x1naGHRjGYpxkGQVAjUEl5P8P/+a8SOoh9qUWcgfsC70Qi/6qLzDp1gg7idrojpiOUonayZHKwA6S2uHZo6kdPr8BNwjZf6O13CNhEXABETdUBBEKaQZarksG9NROzgW7Q9gpbYxtFCQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(186003)(36860700001)(356005)(8936002)(2906002)(7696005)(86362001)(36756003)(8676002)(7636003)(4326008)(316002)(508600001)(426003)(2616005)(5660300002)(70206006)(83380400001)(26005)(54906003)(336012)(110136005)(6666004)(70586007)(82310400004)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2021 14:08:20.6727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5f21540-525b-4024-d71a-08d9ae8ab490 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5258 Cc: alsa-devel@alsa-project.org, Sameer Pujar , linux-kernel@vger.kernel.org, stable@vger.kernel.org, jonathanh@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The driver currently subscribes for a late system sleep call. The initcall_debug log shows that suspend call for ADX device happens after the parent device (AHUB). This seems to cause suspend failure on Jetson TX2 platform. Also there is no use of having late system sleep specifically for ADX device. Fix the order by using normal system sleep. Fixes: a99ab6f395a9 ("ASoC: tegra: Add Tegra210 based ADX driver") Cc: stable@vger.kernel.org Signed-off-by: Sameer Pujar --- sound/soc/tegra/tegra210_adx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/tegra/tegra210_adx.c b/sound/soc/tegra/tegra210_adx.c index 035e24e..69fabf9 100644 --- a/sound/soc/tegra/tegra210_adx.c +++ b/sound/soc/tegra/tegra210_adx.c @@ -518,8 +518,8 @@ static int tegra210_adx_platform_remove(struct platform_device *pdev) static const struct dev_pm_ops tegra210_adx_pm_ops = { SET_RUNTIME_PM_OPS(tegra210_adx_runtime_suspend, tegra210_adx_runtime_resume, NULL) - SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, - pm_runtime_force_resume) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; static struct platform_driver tegra210_adx_driver = {