From patchwork Tue Dec 7 14:03:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 12661923 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A49D4C433F5 for ; Tue, 7 Dec 2021 14:03:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237533AbhLGOHJ (ORCPT ); Tue, 7 Dec 2021 09:07:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237518AbhLGOHI (ORCPT ); Tue, 7 Dec 2021 09:07:08 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDF3DC061746 for ; Tue, 7 Dec 2021 06:03:37 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id e3so57543762edu.4 for ; Tue, 07 Dec 2021 06:03:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4QaFJr9Kj7W1E5J0O0glmrUNqwId/EqvnwB8+dCfYBU=; b=QrCmwezXgDffYu3BYDFeZy4MmR2Bcvm/db80gHwidFga+NwxX3y+rcY846l2UQdA9F uQR0l0gkJConYz8JyaPYkdCoeqml2PcMm+HRWvsJ5OWJhLEjTKwnQ1993B2TwqJaIUJC qVgrZQQF08nhrZuXpSeha15CpfCFQetTqqcHCEzMRpX+ftTjhR+0igzGere/eweQRSp7 0h2rssfxGJvXtnkAusZ6KIle3uX41hQL5XG6+dLl+EiIukCFtIxUGd7JROI1RBLDef55 PC2ei026in6pMihQjWFpxRsYT07bIokDyl5DnDr9XlIOUrBe/y4SjW5nROtUmeJX/moX /W6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4QaFJr9Kj7W1E5J0O0glmrUNqwId/EqvnwB8+dCfYBU=; b=3r8Ic/DGuEuZWzKO6h0aRlwX32zQlHnBpTLvIT3fSfellNbiXDdGSVQj/z50CZ1Dh3 ITuNm+zudFKQVSWtiuaWl4DShNLtW1sUxs6XAbHKQXeUrSAxqEciqyerheDjObgIzdM5 OH4mNMtrIUVk0ah6AgF0S+vUYVmdVeF0bhaYtNuJMtPyn7Sz3dp67KUHcd0CS7RqdqAN 2TjRJB9jvRiyHCZenb6Z21nOEMk6LeMnQQ4BWm34IEoUryci+8IyfpcCGdSzGDBSloRf uRiCO0THHwT6jtrLN31XsSxVFCc4QfNrJMr0DPHpqShZRka0axlzBm2PnbVUQ/bWfnup N8dA== X-Gm-Message-State: AOAM533Uri+9xaB1Jb9IAjsXLwY6EIFQAIGWW5XzlaUEdiCXKq+11+fq ibyLrBOYft50rmMGMgs+yOcckg== X-Google-Smtp-Source: ABdhPJzbnSFGpYaz1Y0yAN5niqLJAa8lYqVYXK9DdlHCE5yqsGkSEplPM3PLY6SPPooXRSpN84dB7Q== X-Received: by 2002:a17:906:ae48:: with SMTP id lf8mr53950076ejb.451.1638885816143; Tue, 07 Dec 2021 06:03:36 -0800 (PST) Received: from localhost ([31.134.121.151]) by smtp.gmail.com with ESMTPSA id sg17sm8644501ejc.72.2021.12.07.06.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 06:03:35 -0800 (PST) From: Sam Protsenko To: Rob Herring , Masahiro Yamada , Michal Marek Cc: Nick Desaulniers , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH] kbuild: Report enabled nodes with duplicated address Date: Tue, 7 Dec 2021 16:03:34 +0200 Message-Id: <20211207140334.10461-1-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Duplicated unit address is a normal case, as long as no more than one node using that address is enabled. Having duplicated addresses is already allowed by '-Wno-unique_unit_address' in DTC_FLAGS. But two simultaneously enabled nodes sharing the same address is usually incorrect. Add '-Wunique_unit_address_if_enabled' flag to report warnings for such case when doing "make dtbs_check". Signed-off-by: Sam Protsenko Reported-by: Rob Herring Suggested-by: Rob Herring --- NOTE: After applying this patch, a lot of warnings appear on "make dtbs_check". I'm not completely sure if it's ok, so feel free to Nack. scripts/Makefile.lib | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index ce6142238835..2f00c996d2e3 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -315,7 +315,8 @@ DTC_FLAGS += -Wno-unit_address_vs_reg \ -Wno-alias_paths \ -Wno-graph_child_address \ -Wno-simple_bus_reg \ - -Wno-unique_unit_address + -Wno-unique_unit_address \ + -Wunique_unit_address_if_enabled endif ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)