From patchwork Fri Dec 10 04:28:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 12668635 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E448C433F5 for ; Fri, 10 Dec 2021 04:29:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236622AbhLJEcp (ORCPT ); Thu, 9 Dec 2021 23:32:45 -0500 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:49759 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234318AbhLJEco (ORCPT ); Thu, 9 Dec 2021 23:32:44 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0V-7Yjgd_1639110530; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0V-7Yjgd_1639110530) by smtp.aliyun-inc.com(127.0.0.1); Fri, 10 Dec 2021 12:29:08 +0800 From: Yang Li To: rafael@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, daniel.lezcano@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next 1/2] cpuidle: Fix kernel-doc Date: Fri, 10 Dec 2021 12:28:48 +0800 Message-Id: <20211210042849.79924-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Fix function name in sysfs.c kernel-doc comment to remove a warning found by running scripts/kernel-doc, which is caused by using 'make W=1'. drivers/cpuidle/sysfs.c:512: warning: expecting prototype for cpuidle_remove_driver_sysfs(). Prototype was for cpuidle_remove_state_sysfs() instead Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/cpuidle/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c index 469e18547d06..e708e593db88 100644 --- a/drivers/cpuidle/sysfs.c +++ b/drivers/cpuidle/sysfs.c @@ -505,7 +505,7 @@ static int cpuidle_add_state_sysfs(struct cpuidle_device *device) } /** - * cpuidle_remove_driver_sysfs - removes the cpuidle states sysfs attributes + * cpuidle_remove_state_sysfs - removes the cpuidle states sysfs attributes * @device: the target device */ static void cpuidle_remove_state_sysfs(struct cpuidle_device *device) From patchwork Fri Dec 10 04:30:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 12668637 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C5BBC433FE for ; Fri, 10 Dec 2021 04:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234517AbhLJEeG (ORCPT ); Thu, 9 Dec 2021 23:34:06 -0500 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:48663 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232860AbhLJEeG (ORCPT ); Thu, 9 Dec 2021 23:34:06 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R741e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0V-78H3N_1639110627; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0V-78H3N_1639110627) by smtp.aliyun-inc.com(127.0.0.1); Fri, 10 Dec 2021 12:30:29 +0800 From: Yang Li To: rafael@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, daniel.lezcano@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next 2/2] cpuidle: add put_device() after of_find_device_by_node() Date: Fri, 10 Dec 2021 12:30:24 +0800 Message-Id: <20211210043024.80884-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This was found by coccicheck: ./drivers/cpuidle/cpuidle-qcom-spm.c:129:1-7: ERROR: missing put_device; call of_find_device_by_node on line 103, but without a corresponding object release within this function. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/cpuidle/cpuidle-qcom-spm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpuidle/cpuidle-qcom-spm.c b/drivers/cpuidle/cpuidle-qcom-spm.c index 01e77913a414..3952ea600122 100644 --- a/drivers/cpuidle/cpuidle-qcom-spm.c +++ b/drivers/cpuidle/cpuidle-qcom-spm.c @@ -111,6 +111,7 @@ static int spm_cpuidle_register(struct device *cpuidle_dev, int cpu) return -ENOMEM; data->spm = dev_get_drvdata(&pdev->dev); + put_device(&pdev->dev); if (!data->spm) return -EINVAL;