From patchwork Mon Dec 13 08:09:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jian-Hong Pan X-Patchwork-Id: 12673197 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D4EC433F5 for ; Mon, 13 Dec 2021 08:11:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232769AbhLMILj (ORCPT ); Mon, 13 Dec 2021 03:11:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbhLMILj (ORCPT ); Mon, 13 Dec 2021 03:11:39 -0500 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F88CC06173F for ; Mon, 13 Dec 2021 00:11:39 -0800 (PST) Received: by mail-pg1-x536.google.com with SMTP id q16so13851875pgq.10 for ; Mon, 13 Dec 2021 00:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessos.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bcoQMqd+/7idFnoLa/h3loZdpkZ7uYITYIobfbm2fno=; b=FtLB4DFgjXiXbPPZmctl9E3CBZhMrLsdASxfimI2fewhXgqjOQ98jbXCY19GSfQQJ9 BTEg9+ixPdR/FTmGYvlYaAovkYXF3mV28BLfxxu4XJEdZj5V6iU7uNQWyQEi6PNfuSN1 kKspFKlbcEwjGxzYbx8LdAuoAhbH6lc2JqQHa8iOLDP8dXHNhs6Kyo16C/YUgCs8g73f eBdG5Mu/waxbSwnUpMROW5cbPHcXKW+DkE0MqylHf4GgsQOQ0duxE6l8oEHBteIhOBvP 473RAkg+lHfNdIyNiSlKqxicdDVjDv5DbYnYZol3jHCSQguVJKCL/sOdpS/0bIG4hu8n bHDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bcoQMqd+/7idFnoLa/h3loZdpkZ7uYITYIobfbm2fno=; b=xXpTh7i1BSK81kYfAf/dNt8nCZ7K8+6QSCPDxudIWFHC0Vr6oQeNFyQklgnT3uu8pk O5d6sdZaYryZXQZis6Nb1M+z0QWrESmtIvGHLFhCcIFUAs8Lijvk5CJVwC6dlgDC5FMb TfdqmcB/aAxiER22bVMx0jpGnPNaxBwzxMJ9CgnZbrawy1KfNioLYbFa2ZYjvI2CWP+T lSE8nth4V+qoRc9VuIsAe1wnhHG98Wta3krS0QWcx4UB0gxOu2ZtN3Uko7SssrGfL9PA qE5V1UxsRzAKrfaw+0CE9h25M2aEGar/rzQasD+IKSq3kjXEYyht7Bx5LCRIAvEqDgEE R/Fg== X-Gm-Message-State: AOAM532VJ8NdYi3qFHGkaPibhIQ63qZalV+H9UvlZgExei+ph378Lj9e DCgXqe56ZFLLNwQUiZ3nkQ1beA== X-Google-Smtp-Source: ABdhPJzJfbSUnqsF2VuNRqwFqUzId12IVk3eBZOc+GRGAyTmqs+N/+kfbVZmf4ft6xhp7UPlcKsxaQ== X-Received: by 2002:a63:8bca:: with SMTP id j193mr13933826pge.293.1639383098719; Mon, 13 Dec 2021 00:11:38 -0800 (PST) Received: from starnight.localdomain (123-204-46-122.static.seed.net.tw. [123.204.46.122]) by smtp.googlemail.com with ESMTPSA id p15sm6097378pjh.1.2021.12.13.00.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 00:11:38 -0800 (PST) From: Jian-Hong Pan To: Ping-Ke Shih , Po-Hao Huang , Kai-Heng Feng , Yan-Hsuan Chuang , Kalle Valo Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux@endlessos.org, Jian-Hong Pan Subject: [PATCH] rtw88: pci: turn off PCI ASPM during NAPI polling Date: Mon, 13 Dec 2021 16:09:09 +0800 Message-Id: <20211213080908.80723-1-jhp@endlessos.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The system on the machines equipped with RTL8821CE freezes randomly until the PCI ASPM is disabled during NAPI poll function. Link: https://www.spinics.net/lists/linux-wireless/msg218387.html Fixes: 9e2fd29864c5 ("rtw88: add napi support") Signed-off-by: Jian-Hong Pan --- drivers/net/wireless/realtek/rtw88/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c index a7a6ebfaa203..a6fdddecd37d 100644 --- a/drivers/net/wireless/realtek/rtw88/pci.c +++ b/drivers/net/wireless/realtek/rtw88/pci.c @@ -1658,6 +1658,7 @@ static int rtw_pci_napi_poll(struct napi_struct *napi, int budget) priv); int work_done = 0; + rtw_pci_link_ps(rtwdev, false); while (work_done < budget) { u32 work_done_once; @@ -1681,6 +1682,7 @@ static int rtw_pci_napi_poll(struct napi_struct *napi, int budget) if (rtw_pci_get_hw_rx_ring_nr(rtwdev, rtwpci)) napi_schedule(napi); } + rtw_pci_link_ps(rtwdev, true); return work_done; }