From patchwork Mon Dec 20 05:37:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edwin Chiu X-Patchwork-Id: 12687135 X-Patchwork-Delegate: daniel.lezcano@linaro.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1730C433EF for ; Mon, 20 Dec 2021 05:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234196AbhLTFhc (ORCPT ); Mon, 20 Dec 2021 00:37:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234164AbhLTFha (ORCPT ); Mon, 20 Dec 2021 00:37:30 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE600C061574; Sun, 19 Dec 2021 21:37:30 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id f125so8432751pgc.0; Sun, 19 Dec 2021 21:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=CyUHQURqnG0Cbk3YChc98g2xsw1FYRao5iS256syH0A=; b=WbFzvQ1hONQsyHiwqV6Zlrk3667b1DO8lhdslisAkvySv0fV3nJsOqK5v8BC72aAD6 gspLlOgFtAExQQr5CbFO9nPhqNnPlQ9kxziBXoS3MgkaDyHAcRhikdDF+VnM8e8pdnJv uVUKG0N82E0DHiqrajuOzplKf6SB+e3t/fXUaS5/Ij88w3fgmUQO5HfFqRJRkTYq5N2M FER/NaF0KAAYAwchgeHfs0ZKpM8PFhw/LKcF8vLzSCwFKSz2GyIPBx+peFYXafHbNfdp RM1+cC58BeH6bImq4YjEgdJFUJmPw9+4yU+gSDKczwlPFkI/JHvq3Gl9uUKcJB6rS+vO aILg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=CyUHQURqnG0Cbk3YChc98g2xsw1FYRao5iS256syH0A=; b=E6ptvXJsWEnifgTPDGwf56CY6fGhfVPYFJI1NOGqiKM+9kDAhdZphPRsCGY2YNigjF XTjgAbsfu8w5jzFrUOrwcc2ZMbYK/i08nbpMirvvln34/DRknjXaGeux9uC/cYf88eAJ disYtfoGkHlF0gz2jFCk4aIVdvy2PO54UOW3N/PpFrch1dANZYl7Im0/lylrkLw7Z2nn 9XDS3qIPOaQFE6kbkL6HnTg13nj2nnBOWfKBFef6gRKG4Z4LicXsIODHJzce01SOPPnT cPdnegXgfp3PvrBncwinldYivP49j7kDk5+C6cU1yCEQU21YR6lzriy5Tss96gZFwBiw d9Iw== X-Gm-Message-State: AOAM530HO4/WivrZCux37g1ci5ZnJ5HIsagHPPRxyFyTMwOuvvM0tzct O4fbdLDRpMKTK/E44H7lkP0= X-Google-Smtp-Source: ABdhPJwgxAQ8JB4bPDb/MN2P/h1QtS8uNuNzYfhrvM4GH13O0WyOCYTmksD0ZMTUZYD1CM7VWMh3Yw== X-Received: by 2002:a63:2bc1:: with SMTP id r184mr13345119pgr.426.1639978649944; Sun, 19 Dec 2021 21:37:29 -0800 (PST) Received: from scdiu3.sunplus.com ([113.196.136.192]) by smtp.googlemail.com with ESMTPSA id d3sm7491501pfv.192.2021.12.19.21.37.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Dec 2021 21:37:29 -0800 (PST) From: Edwin Chiu To: robh+dt@kernel.org, edwin.chiu@sunplus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org Cc: Edwin Chiu Subject: [PATCH v2 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml Date: Mon, 20 Dec 2021 13:37:31 +0800 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Add the compatible string for cpuidle state on sp7021 Signed-off-by: Edwin Chiu --- Changes in v2 - Align email address of sob and sender .../bindings/arm/sunplus/sunplus,idle-state.yaml | 55 ++++++++++++++++++++++ MAINTAINERS | 5 ++ 2 files changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml diff --git a/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml b/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml new file mode 100644 index 0000000..649e953 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) Sunplus Co., Ltd. 2021 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/sunplus/sunplus,idle-state.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sunplus cpuidle state + +maintainers: + - edwin.chiu + +description: | + Sunplus SOC cpuidle state + +properties: + compatible: + const: arm,idle-state + + entry-latency-us: + description: + Worst case latency in microseconds required to enter the idle state. + + exit-latency-us: + description: + Worst case latency in microseconds required to exit the idle state. + The exit-latency-us duration may be guaranteed only after + entry-latency-us has passed. + + min-residency-us: + description: + Minimum residency duration in microseconds, inclusive of preparation + and entry, for this idle state to be considered worthwhile energy wise + (refer to section 2 of this document for a complete description). + +required: + - compatible + - entry-latency-us + - exit-latency-us + - min-residency-us + +additionalProperties: true + +examples: + - | + idle-states { + CLUSTER_SLEEP_BIG: cluster-sleep-big { + compatible = "arm,idle-state"; + entry-latency-us = <8000>; + exit-latency-us = <700>; + min-residency-us = <9000>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 3b79fd4..41957c7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17945,6 +17945,11 @@ L: netdev@vger.kernel.org S: Maintained F: drivers/net/ethernet/dlink/sundance.c +SUNPLUS CPUIDLE DRIVER +M: Edwin Chiu +S: Maintained +F: Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml + SUPERH M: Yoshinori Sato M: Rich Felker From patchwork Mon Dec 20 05:37:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edwin Chiu X-Patchwork-Id: 12687137 X-Patchwork-Delegate: daniel.lezcano@linaro.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0ED3C433F5 for ; Mon, 20 Dec 2021 05:37:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234110AbhLTFhf (ORCPT ); Mon, 20 Dec 2021 00:37:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234203AbhLTFhd (ORCPT ); Mon, 20 Dec 2021 00:37:33 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBFF7C06173F; Sun, 19 Dec 2021 21:37:32 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id m1so6691365pfk.8; Sun, 19 Dec 2021 21:37:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=/A4FxTGuXFwYz/xsUZ22sXeXxiNGABemQ9DKbnTDmTw=; b=dpGAbpvd53zkq4WoupKR689xs7nAz5NJUzjk62aO/jr+VD2H0O10IKRRF5s51aI0Ye CHYKf8gjabtUuAlcaYurruAi4qvYPEiXXHH4lsv6RzVhQ0GkcepNsqj2H5uTAbZrMoEa RtMPsA+7TdalIFsgBbifB7iq5x1N8PT5Yv0Q/VVF2OI0t5UYS/XZs9vBqtYAGWaleFfN nturIKgCqQeSTpODpy4H8wSTHRDvuMH6S3fGeFsU0/F8NsfXlihwJB0UjAc0l8/FweT8 2LdGRMaPP94Tlg5JuDu/tcFL47l6/NdWdRw9PyjDT6dhVLrjpufMslw+YNavteNagUei rRgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=/A4FxTGuXFwYz/xsUZ22sXeXxiNGABemQ9DKbnTDmTw=; b=12Tq7lU3+SymvD6fysdKH2VuLcyiSJ54e0xx92rfwMP4HqFoi2y0BDgcuNnAKqduhw ealVIuXjuzuWxD7rA2S/0R0Ywotek2YXTsUtPDHlvCPUhbtQ/TKLj0IKsbtuZ2B0/zCn 7yKcI1UbcbVR3SxcyHgC9wpn4coxNmhPzJgQKB3i8tMld//b5s0+gtPTRUnyHX1K/Sj1 c157FEQmdOhFil396Goa+gPTSvi/xoESWep7/IvfAXOVcXfafbx0RWcty/U6OFUc1T9r +7tpQ/vU955B8bJ6RbRRjLkWuhP7laUBgnJ7QdtLFcN5cU1Xi3TzHNXDfefJUMa/fkRV Aymg== X-Gm-Message-State: AOAM531gifbZDcS0tzzJKPVGPV51bG5HXOqZUq74tHvsnOluxZCHDFw5 b7ATizqg/0lDCBnwf7jza3o= X-Google-Smtp-Source: ABdhPJyyi+pgRGxbuMODVunil6Ewn3yDkmTV+Y+z08p4EJnMNtxuVX2C5TVb0yxql/1wwotw4/2UgQ== X-Received: by 2002:a63:81c3:: with SMTP id t186mr13590212pgd.150.1639978652250; Sun, 19 Dec 2021 21:37:32 -0800 (PST) Received: from scdiu3.sunplus.com ([113.196.136.192]) by smtp.googlemail.com with ESMTPSA id d3sm7491501pfv.192.2021.12.19.21.37.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Dec 2021 21:37:31 -0800 (PST) From: Edwin Chiu To: robh+dt@kernel.org, edwin.chiu@sunplus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org Cc: Edwin Chiu Subject: [PATCH v2 2/2] cpuidle:sunplus:create cpuidle driver for sunplus sp7021 Date: Mon, 20 Dec 2021 13:37:32 +0800 Message-Id: <6092f5f372851e2d6bf12b4b23209558038b9fda.1639971376.git.edwinchiu0505tw@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Create cpuidle driver for sunplus sp7021 chip Signed-off-by: Edwin Chiu --- Changes in v2 - Rearrangement #include sequence - Change // to /*~*/ - Align author email address to same as sob MAINTAINERS | 4 + drivers/cpuidle/Kconfig.arm | 7 + drivers/cpuidle/Makefile | 1 + drivers/cpuidle/cpuidle-sunplus.c | 180 ++++++++++++++++++++++++++ include/linux/platform_data/cpuidle-sunplus.h | 13 ++ 5 files changed, 205 insertions(+) create mode 100644 drivers/cpuidle/cpuidle-sunplus.c create mode 100644 include/linux/platform_data/cpuidle-sunplus.h diff --git a/MAINTAINERS b/MAINTAINERS index 41957c7..c5eab79 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17949,6 +17949,10 @@ SUNPLUS CPUIDLE DRIVER M: Edwin Chiu S: Maintained F: Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml +F: drivers/cpuidle/Kconfig.arm +F: drivers/cpuidle/Makefile +F: drivers/cpuidle/cpuidle-sunplus.c +F: include/linux/platform_data/cpuidle-sunplus.h SUPERH M: Yoshinori Sato diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm index 334f83e..ad9956c 100644 --- a/drivers/cpuidle/Kconfig.arm +++ b/drivers/cpuidle/Kconfig.arm @@ -117,3 +117,10 @@ config ARM_QCOM_SPM_CPUIDLE The Subsystem Power Manager (SPM) controls low power modes for the CPU and L2 cores. It interface with various system drivers to put the cores in low power modes. + +config ARM_SUNPLUS_CPUIDLE + bool "CPU Idle Driver For SUNPLUS SoCs" + depends on !ARM64 + select DT_IDLE_STATES + help + Select this to enable cpuidle on SP7021 processors. diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile index 26bbc5e..0a020d1 100644 --- a/drivers/cpuidle/Makefile +++ b/drivers/cpuidle/Makefile @@ -25,6 +25,7 @@ obj-$(CONFIG_ARM_PSCI_CPUIDLE) += cpuidle-psci.o obj-$(CONFIG_ARM_PSCI_CPUIDLE_DOMAIN) += cpuidle-psci-domain.o obj-$(CONFIG_ARM_TEGRA_CPUIDLE) += cpuidle-tegra.o obj-$(CONFIG_ARM_QCOM_SPM_CPUIDLE) += cpuidle-qcom-spm.o +obj-$(CONFIG_ARM_SUNPLUS_CPUIDLE) += cpuidle-sunplus.o ############################################################################### # MIPS drivers diff --git a/drivers/cpuidle/cpuidle-sunplus.c b/drivers/cpuidle/cpuidle-sunplus.c new file mode 100644 index 0000000..88671e6 --- /dev/null +++ b/drivers/cpuidle/cpuidle-sunplus.c @@ -0,0 +1,180 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * ARM/ARM64 generic CPU idle driver. + * + */ +#define pr_fmt(fmt) "CPUidle arm: " fmt + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "dt_idle_states.h" + +static int sp7021_wfi_finisher(unsigned long flags) +{ + cpu_v7_do_idle(); /* idle to WFI */ + + return -1; +} + +static int sp7021_enter_idle_state(struct cpuidle_device *dev, + struct cpuidle_driver *drv, int idx) +{ + int ret; + + /* if idx=0, call cpu_do_idle() */ + if (!idx) { + cpu_v7_do_idle(); + return idx; + } + + /* if idx>0, call cpu_suspend() */ + ret = cpu_pm_enter(); + if (!ret) { + /* + * Pass idle state index to cpuidle_suspend which in turn + * will call the CPU ops suspend protocol with idle index as a + * parameter. + */ + ret = cpu_suspend(idx, sp7021_wfi_finisher); + } + cpu_pm_exit(); + + return ret ? -1:idx; +} + +static struct cpuidle_driver sp7021_idle_driver __initdata = { + .name = "sp7021_idle", + .owner = THIS_MODULE, + /* + * State at index 0 is standby wfi and considered standard + * on all ARM platforms. If in some platforms simple wfi + * can't be used as "state 0", DT bindings must be implemented + * to work around this issue and allow installing a special + * handler for idle state index 0. + */ + .states[0] = { + .enter = sp7021_enter_idle_state, + .exit_latency = 1, + .target_residency = 1, + .power_usage = UINT_MAX, + .name = "WFI", + .desc = "ARM WFI", + } +}; + +static const struct of_device_id sp7021_idle_state_match[] __initconst = { + { .compatible = "arm,idle-state", + .data = sp7021_enter_idle_state }, + { }, +}; + +/* + * arm_idle_init - Initializes arm cpuidle driver + * + * Initializes arm cpuidle driver for all CPUs, if any CPU fails + * to register cpuidle driver then rollback to cancel all CPUs + * registration. + */ +static int __init sp7021_idle_init(void) +{ + int cpu, ret; + struct cpuidle_driver *drv; + struct cpuidle_device *dev; + + drv = kmemdup(&sp7021_idle_driver, sizeof(*drv), GFP_KERNEL); + if (!drv) + return -ENOMEM; + + drv->cpumask = (struct cpumask *)cpumask_of(cpu); + /* + * Initialize idle states data, starting at index 1. This + * driver is DT only, if no DT idle states are detected (ret + * == 0) let the driver initialization fail accordingly since + * there is no reason to initialize the idle driver if only + * wfi is supported. + */ + ret = dt_init_idle_driver(drv, sp7021_idle_state_match, 1); + if (ret <= 0) + return ret ? : -ENODEV; + + ret = cpuidle_register_driver(drv); + if (ret) { + pr_err("Failed to register cpuidle driver\n"); + return ret; + } + + /* + * Call arch CPU operations in order to initialize + * idle states suspend back-end specific data + */ + for_each_possible_cpu(cpu) { + /* + * Skip the cpuidle device initialization if the reported + * failure is a HW misconfiguration/breakage (-ENXIO) + */ + if (ret == -ENXIO) + continue; + + if (ret) { + pr_err("CPU %d failed to init idle CPU ops\n", cpu); + goto out_fail; + } + dev = kzalloc(sizeof(*dev), GFP_KERNEL); + if (!dev) { + ret = -ENOMEM; + goto out_fail; + } + dev->cpu = cpu; + + ret = cpuidle_register_device(dev); + if (ret) { + pr_err("Failed to register cpuidle device for CPU %d\n", cpu); + kfree(dev); + goto out_fail; + } + } + + return 0; + +out_fail: + while (--cpu >= 0) { + dev = per_cpu(cpuidle_devices, cpu); + cpuidle_unregister_device(dev); + kfree(dev); + } + cpuidle_unregister_driver(drv); + + return ret; +} + +static int __init idle_init(void) +{ + int ret; + + if (of_machine_is_compatible("sunplus,sp7021-achip")) { + sp7021_idle_init(); + ret = 0; + } else + ret = -1; + + if (ret) { + pr_err("failed to cpuidle init\n"); + return ret; + } + + return ret; +} +device_initcall(idle_init); + +MODULE_AUTHOR("Edwin Chiu "); +MODULE_DESCRIPTION("Sunplus sp7021 cpuidle driver"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/platform_data/cpuidle-sunplus.h b/include/linux/platform_data/cpuidle-sunplus.h new file mode 100644 index 0000000..d63efad --- /dev/null +++ b/include/linux/platform_data/cpuidle-sunplus.h @@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#ifndef __CPUIDLE_SP7021_H +#define __CPUIDLE_SP7021_H + +extern int cpu_v7_do_idle(void); + +#endif