From patchwork Wed Dec 22 00:11:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Glen Choo X-Patchwork-Id: 12690713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C929C433EF for ; Wed, 22 Dec 2021 00:11:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbhLVALx (ORCPT ); Tue, 21 Dec 2021 19:11:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238309AbhLVALu (ORCPT ); Tue, 21 Dec 2021 19:11:50 -0500 Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F4D6C061574 for ; Tue, 21 Dec 2021 16:11:50 -0800 (PST) Received: by mail-pl1-x64a.google.com with SMTP id e10-20020a17090301ca00b001491f26bcd4so55106plh.23 for ; Tue, 21 Dec 2021 16:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=wX1jQrxCOlbCTcPN51LfEt4goIZ/oVCB2kXtWmDLtFY=; b=C77It54n62Ek9DuMt/Bu0UMZCNAy0izoZdtDhbNAk4yy4ToQpJ/fMiBoeAO1m1QvS3 upR9MSbP2Jwc2q2YStSbEIstUl+2CbORbWeu4wnLsMYyaY6IdhQ8z/sbW2RG9skbPALD iZXes7AQQmLhlC3NyMRoF4ZzId5eKjhEWYfW2PwUTshtV1mHUGvRD8k7RZMAOEaN9LsP Z5idBTOkrVsFnJmF1umy4ajcnr3+5EwAEKbmrQW1CAeHvezSfBow+MHsYnsRY7yk5EPk 2ATZ1nwrbtVgcK1LVNabG+J5bhNwfJiB3IfYDl6tHwOVn9oKUyDZ/fz6duqVHDX/QEHR MsLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=wX1jQrxCOlbCTcPN51LfEt4goIZ/oVCB2kXtWmDLtFY=; b=BuG8gdTX+C1r67SSk3R1ObBSV4KE1B/cDg0r7GfRuPyA+tn7cDZ5KjXl6dNL1iiHt6 hTver/EJpqis1IhjLBlS+Wft84q1XEa+vFSqtoWslSWJMj7MX69l4nBw3Fd9QuvO4q91 bFzBmrojJjB5p7LW3w1Tm1zCMUuzP4rc1GLKIwfYOIa42RCXpzfZqgT4hBfptyPeDHab qMxDDuIwJxRHpxTGWQdxFSpvuHHYYr+0LQo2tJwGU0pxLPURJi86r2ZOzI6K9SKY5X6l Z1lbKssPFaQiZs1f9oJW4cLpoTwBoSngUEDY4B4F6RJFQdwOc7ClU8t7HYrqH+ejr2uO Cfdg== X-Gm-Message-State: AOAM532bkpeIGdfXQIVH0NQhOCxJ2jhQHXlSfL3+Pb4MWjMoiN9ljdLg jvFWh0OmMPcHz7qyGdAP6z7xSj+uxSu7HaDGc2HItmSeLAwEytetk0qCZOGcPAE7mvoL2FuY0py SbZqYPOzdREh7L+Q1gc2nwUouaAn5a4cPBgobmd3UiemSQuA2yu7hwEKu9y3ofZE= X-Google-Smtp-Source: ABdhPJzjSeOvaVx8zqQ6RFsjTmItkOIiZ8+qALQRvSWp6KDesx+LtMwafD0+T65mLJtq3DIJnTaOXwW/+46X5A== X-Received: from chooglen.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:26d9]) (user=chooglen job=sendgmr) by 2002:a17:902:c215:b0:148:af14:6e96 with SMTP id 21-20020a170902c21500b00148af146e96mr491053pll.80.1640131909965; Tue, 21 Dec 2021 16:11:49 -0800 (PST) Date: Tue, 21 Dec 2021 16:11:32 -0800 In-Reply-To: <20211222001134.28933-1-chooglen@google.com> Message-Id: <20211222001134.28933-2-chooglen@google.com> Mime-Version: 1.0 References: <20211217000235.68996-1-chooglen@google.com> <20211222001134.28933-1-chooglen@google.com> X-Mailer: git-send-email 2.34.1.307.g9b7440fafd-goog Subject: [PATCH v3 1/3] builtin/fetch: use goto cleanup in cmd_fetch() From: Glen Choo To: git@vger.kernel.org Cc: Glen Choo , Jonathan Tan , Junio C Hamano Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Replace an early return with 'goto cleanup' in cmd_fetch() so that the string_list is always cleared. The string_list_clear() call is purely cleanup; the string_list was not reused. Signed-off-by: Glen Choo --- builtin/fetch.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/builtin/fetch.c b/builtin/fetch.c index f7abbc31ff..eab73d7417 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -2076,7 +2076,8 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) gtransport->smart_options->acked_commits = &acked_commits; } else { warning(_("Protocol does not support --negotiate-only, exiting.")); - return 1; + result = 1; + goto cleanup; } if (server_options.nr) gtransport->server_options = &server_options; @@ -2132,8 +2133,6 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) strvec_clear(&options); } - string_list_clear(&list, 0); - prepare_repo_settings(the_repository); if (fetch_write_commit_graph > 0 || (fetch_write_commit_graph < 0 && @@ -2151,5 +2150,7 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) if (enable_auto_gc) run_auto_maintenance(verbosity < 0); + cleanup: + string_list_clear(&list, 0); return result; } From patchwork Wed Dec 22 00:11:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Glen Choo X-Patchwork-Id: 12690715 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4AC1C433F5 for ; Wed, 22 Dec 2021 00:11:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238952AbhLVALy (ORCPT ); Tue, 21 Dec 2021 19:11:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239057AbhLVALw (ORCPT ); Tue, 21 Dec 2021 19:11:52 -0500 Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98361C061574 for ; Tue, 21 Dec 2021 16:11:52 -0800 (PST) Received: by mail-pl1-x64a.google.com with SMTP id m15-20020a170902bb8f00b0014382b67873so56430pls.19 for ; Tue, 21 Dec 2021 16:11:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=Ahvy+SY6KIwEv/qUeGDTeL0R3FlvQuyn/9DiUntmS3E=; b=TFNqYiS5KUwwB3O0/zkLCwdy6vcWz1+rcVPOpEZiKtZ3AhbwtC0cAnzZybC1iUK74I /YfdY05epGioxcm1E4LX9OtFSLbRmgqYizMgojK5VBaoXpvF9WRx1ngVjHMBxjDS8xXU LEmmekKUTG1hPBwuVWz3jBR/1Cwv9fP8sLB5R037o7LgH45b5JVnfOyyQvDxcyCLq16C XuAV0Lr/1y+8NVR34cJtRtdh2K6GJ097C1Xfozvrhp14YmwX04WiomIyj8N/HXnDJzR8 AWuA/HUYM9JHWjtICrKhip5WPYHGh6saviXdy8dhhAAnZgWfXQeHLpzIU4LX/8clRBI6 sW2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Ahvy+SY6KIwEv/qUeGDTeL0R3FlvQuyn/9DiUntmS3E=; b=jAdy8W5oGQ2Gu7P8xN0Fnanmpy8iDTZieYJS/jN5c5L8C76tnQocLHGLanxsU/EDBR ixFIwNLKzZJO6miJU5McchRAaHXIrkYhmUTTz8e2UAv+5iwF4Ciyfg3cFLVEIAlxwL2i xUzbM+S3Mfi0MxmbM4Xal4uyGHNFFhF0AzqILOUx9EC+2l04AWd3Q+1FrKcTIH2FSdRa ECH99TMsM/EKzUPdhzjbcZknqznlrEj4rwWaBVDOzhsApqjCZxFfAl0+K05hfyxkEiSn 3d2OIiMZdbFYf7VVNH3IOSRr+EkoGzlQqb0yUFOwS3O1hpVtfLWgFO82DFeUglaP0NOw u1gA== X-Gm-Message-State: AOAM530HLqYZKLIZUe78k3z4bVSi5ZyijbDAcQE7T+GWELyRKjC+bIwH Z9Sl8+8U1K0GOqc9OvcNaRpPDEKgqBpd9Jobyez0c5yjO8vdv7BdFBjTDEiWy4dK4QN9WoSGe0K uj8GHveLANrgWkMufRcbtwbbItKLnbCS4CGuPHF9UojkldrXfQzngroLwU5BnIlY= X-Google-Smtp-Source: ABdhPJyhXokdSW33LvY//VBijtUry7x7LPl87dHdMiz1r/549qESvBpzrRRAppt0txxGSdXeDUf3rVSq0WKI+A== X-Received: from chooglen.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:26d9]) (user=chooglen job=sendgmr) by 2002:a63:7986:: with SMTP id u128mr687085pgc.204.1640131911993; Tue, 21 Dec 2021 16:11:51 -0800 (PST) Date: Tue, 21 Dec 2021 16:11:33 -0800 In-Reply-To: <20211222001134.28933-1-chooglen@google.com> Message-Id: <20211222001134.28933-3-chooglen@google.com> Mime-Version: 1.0 References: <20211217000235.68996-1-chooglen@google.com> <20211222001134.28933-1-chooglen@google.com> X-Mailer: git-send-email 2.34.1.307.g9b7440fafd-goog Subject: [PATCH v3 2/3] builtin/fetch: skip unnecessary tasks when using --negotiate-only From: Glen Choo To: git@vger.kernel.org Cc: Glen Choo , Jonathan Tan , Junio C Hamano Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org cmd_fetch() performs certain tasks with the assumption that objects are fetched, but `git fetch --negotiate-only` does not fetch objects, as its name implies. This is results in behavior that is unnecessary at best, and incorrect at worst: * Submodules are updated if enabled by recurse.submodules=true, but negotiation fetch doesn't actually update the repo, so this doesn't make sense (introduced in [1]). * Commit graphs will be written if enabled by fetch.writeCommitGraph=true. But according to Documentation/config/fetch.txt [2], this should only be done if a pack-file is downloaded. * gc is run, but according to [3], we only do this because we expect `git fetch` to introduce objects. Instead of disabling these tasks piecemeal, make cmd_fetch() return early if we know for certain that objects will not be fetched. We can return early whenever objects are not fetched, but for now this only considers --negotiate-only. A similar optimization would be to skip irrelevant tasks in `git fetch --dry-run`. This optimization was not done in this commit because a dry run will actually fetch objects; we'd presumably still want to recurse into submodules and run gc. [1] 7dce19d374 (fetch/pull: Add the --recurse-submodules option, 2010-11-12) [2] 50f26bd035 (fetch: add fetch.writeCommitGraph config setting, 2019-09-02) [3] 131b8fcbfb (fetch: run gc --auto after fetching, 2013-01-26) Signed-off-by: Glen Choo --- builtin/fetch.c | 20 ++++++++++++++++++++ t/t5516-fetch-push.sh | 12 ++++++++++++ 2 files changed, 32 insertions(+) diff --git a/builtin/fetch.c b/builtin/fetch.c index eab73d7417..883bb1b10c 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -1996,6 +1996,15 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) argc = parse_options(argc, argv, prefix, builtin_fetch_options, builtin_fetch_usage, 0); + + if (negotiate_only) { + /* + * --negotiate-only should never recurse into + * submodules, so there is no need to read .gitmodules. + */ + recurse_submodules = RECURSE_SUBMODULES_OFF; + } + if (recurse_submodules != RECURSE_SUBMODULES_OFF) { int *sfjc = submodule_fetch_jobs_config == -1 ? &submodule_fetch_jobs_config : NULL; @@ -2113,6 +2122,17 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) result = fetch_multiple(&list, max_children); } + /* + * Skip irrelevant tasks because we know objects were not + * fetched. + * + * NEEDSWORK: as a future optimization, we can return early + * whenever objects were not fetched e.g. if we already have all + * of them. + */ + if (negotiate_only) + goto cleanup; + if (!result && (recurse_submodules != RECURSE_SUBMODULES_OFF)) { struct strvec options = STRVEC_INIT; int max_children = max_jobs; diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh index 8212ca56dc..732031085e 100755 --- a/t/t5516-fetch-push.sh +++ b/t/t5516-fetch-push.sh @@ -229,6 +229,18 @@ test_expect_success 'push with negotiation proceeds anyway even if negotiation f test_i18ngrep "push negotiation failed" err ' +test_expect_success 'push with negotiation does not attempt to fetch submodules' ' + mk_empty submodule_upstream && + test_commit -C submodule_upstream submodule_commit && + git submodule add ./submodule_upstream submodule && + mk_empty testrepo && + git push testrepo $the_first_commit:refs/remotes/origin/first_commit && + test_commit -C testrepo unrelated_commit && + git -C testrepo config receive.hideRefs refs/remotes/origin/first_commit && + git -c submodule.recurse=true -c protocol.version=2 -c push.negotiate=1 push testrepo refs/heads/main:refs/remotes/origin/main 2>err && + ! grep "Fetching submodule" err +' + test_expect_success 'push without wildcard' ' mk_empty testrepo && From patchwork Wed Dec 22 00:11:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Glen Choo X-Patchwork-Id: 12690717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44039C433EF for ; Wed, 22 Dec 2021 00:11:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239007AbhLVALz (ORCPT ); Tue, 21 Dec 2021 19:11:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239036AbhLVALy (ORCPT ); Tue, 21 Dec 2021 19:11:54 -0500 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3060C061747 for ; Tue, 21 Dec 2021 16:11:54 -0800 (PST) Received: by mail-pg1-x54a.google.com with SMTP id l6-20020a633e06000000b0034006440151so294818pga.23 for ; Tue, 21 Dec 2021 16:11:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=XHSrS/kaPjwKPsSMYQe+nrPRwX9vLd5MnW4hyX7se7I=; b=fGy4/siwJEyZo5dmyv0P4aVvJjE85AT7I3l6TTfwfTBjLN8JI7XsyS5QcPe8ykXfeu 0Ug+zeAVWjkYQ0QCzCE63FqjP4bXaMP/Bjn25uM6IhXWoFQ8MykM8xPjETkuv7yUBdxv 6Nwc0xsRr9es/quzB9CIbi6f+6M2RlSGIn1M10OGNzi3mvXVDzkxST7MwrASilf/lD95 yyguazl7I7zdlGfv4wg6iMcs3wx5+hYKCdyFBJAba6pNQ2d0I3eQQIMP4n6dwDPp80TK dgCJQk2d018SBeRuKTfdjF6CvyMrSQkmfvncJ3BrpFMEo1/op8DEg7LObm+dpJiUM3Uc oIkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=XHSrS/kaPjwKPsSMYQe+nrPRwX9vLd5MnW4hyX7se7I=; b=31PvvvYK8SPtMNPIigIr6owjf8TcwTkKJqS3Nh9wOMQdy2hHkGU28Z/rbfBrvNvlTw 2/zo3TsKUGzwyKsL8ybs4c3XMYFYDouWRph7bkZHWy+pgJqd1AGwVc8JxsnYeI8ERghz +CWbFUMOVLQDzGoel1IFmwiDAaHp8y+1+5CkhIpHe/BXKD8WveSkbnFYOZoj2bwRpQG6 GUjjSxXHXlbnyEcJ1ZPWAds7xxOgUnJZAFfxZWApxraBoYQ53joyVwH2js8iUp6ISNKB wDuTO35acJH2sjV/J7Wr8LY1FJVVQROwVrvXGARLrwdG2xUxkxuK/hS/W5OdmlFrrq39 0cAg== X-Gm-Message-State: AOAM530p7e/vGGi0hAi3qltTy3o2GzKUnMk/kf2Fa8kz8VJL2sjx1v3x NDJnitYvScr7k9TG6tsuNem46q7NzvCLvbzF0n0C0SKk63qQe5T+4eYuNn8cV2wIRUGhW936iAZ GzUaNIPA5rj2QM+dUWN0UZqqarCNSu1mdodY4dOTFizNtCNvvqDyHMCiTSZYmUDk= X-Google-Smtp-Source: ABdhPJw7Tfq0R7oJ9qbn+4eqii5fXXjrG/VC4LQjsRszT/9MNVFwxU90//qVtohtNLINe6Qkn+1yrIITTeiLpA== X-Received: from chooglen.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:26d9]) (user=chooglen job=sendgmr) by 2002:a17:903:2348:b0:141:d60b:ee90 with SMTP id c8-20020a170903234800b00141d60bee90mr404571plh.15.1640131914028; Tue, 21 Dec 2021 16:11:54 -0800 (PST) Date: Tue, 21 Dec 2021 16:11:34 -0800 In-Reply-To: <20211222001134.28933-1-chooglen@google.com> Message-Id: <20211222001134.28933-4-chooglen@google.com> Mime-Version: 1.0 References: <20211217000235.68996-1-chooglen@google.com> <20211222001134.28933-1-chooglen@google.com> X-Mailer: git-send-email 2.34.1.307.g9b7440fafd-goog Subject: [PATCH v3 3/3] builtin/fetch: die on --negotiate-only and --recurse-submodules From: Glen Choo To: git@vger.kernel.org Cc: Glen Choo , Jonathan Tan , Junio C Hamano Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The previous commit ignores the value of --recurse-submodules if --negotiate-only is given. Since non "no" values of --recurse-submodules are not supported with --negotiate-only, make cmd_fetch() check for this invalid combination and die. This is unlikely to affect internal usage of --negotiate-only, but it may be helpful for users. We may also want to discourage users from using --negotiate-only altogether because it was not intended for them. Signed-off-by: Glen Choo --- Documentation/fetch-options.txt | 1 + builtin/fetch.c | 24 ++++++++++++++++++------ t/t5702-protocol-v2.sh | 17 +++++++++++++++++ 3 files changed, 36 insertions(+), 6 deletions(-) diff --git a/Documentation/fetch-options.txt b/Documentation/fetch-options.txt index e967ff1874..81a100d593 100644 --- a/Documentation/fetch-options.txt +++ b/Documentation/fetch-options.txt @@ -71,6 +71,7 @@ configuration variables documented in linkgit:git-config[1], and the ancestors of the provided `--negotiation-tip=*` arguments, which we have in common with the server. + +This is incompatible with `--recurse-submodules[=yes|on-demand]`. Internally this is used to implement the `push.negotiate` option, see linkgit:git-config[1]. diff --git a/builtin/fetch.c b/builtin/fetch.c index 883bb1b10c..54f970130e 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -75,6 +75,7 @@ static struct transport *gtransport; static struct transport *gsecondary; static const char *submodule_prefix = ""; static int recurse_submodules = RECURSE_SUBMODULES_DEFAULT; +static int recurse_submodules_explicit = RECURSE_SUBMODULES_DEFAULT; static int recurse_submodules_default = RECURSE_SUBMODULES_ON_DEMAND; static int shown_url = 0; static struct refspec refmap = REFSPEC_INIT_FETCH; @@ -166,7 +167,7 @@ static struct option builtin_fetch_options[] = { N_("prune remote-tracking branches no longer on remote")), OPT_BOOL('P', "prune-tags", &prune_tags, N_("prune local tags no longer on remote and clobber changed tags")), - OPT_CALLBACK_F(0, "recurse-submodules", &recurse_submodules, N_("on-demand"), + OPT_CALLBACK_F(0, "recurse-submodules", &recurse_submodules_explicit, N_("on-demand"), N_("control recursive fetching of submodules"), PARSE_OPT_OPTARG, option_fetch_parse_recurse_submodules), OPT_BOOL(0, "dry-run", &dry_run, @@ -1997,12 +1998,23 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) argc = parse_options(argc, argv, prefix, builtin_fetch_options, builtin_fetch_usage, 0); + if (recurse_submodules_explicit != RECURSE_SUBMODULES_DEFAULT) + recurse_submodules = recurse_submodules_explicit; + if (negotiate_only) { - /* - * --negotiate-only should never recurse into - * submodules, so there is no need to read .gitmodules. - */ - recurse_submodules = RECURSE_SUBMODULES_OFF; + switch (recurse_submodules_explicit) { + case RECURSE_SUBMODULES_OFF: + case RECURSE_SUBMODULES_DEFAULT: { + /* + * --negotiate-only should never recurse into + * submodules, so there is no need to read .gitmodules. + */ + recurse_submodules = RECURSE_SUBMODULES_OFF; + break; + } + default: + die(_("--negotiate-only and --recurse-submodules cannot be used together")); + } } if (recurse_submodules != RECURSE_SUBMODULES_OFF) { diff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh index d527cf6c49..d099c46499 100755 --- a/t/t5702-protocol-v2.sh +++ b/t/t5702-protocol-v2.sh @@ -628,6 +628,23 @@ test_expect_success 'usage: --negotiate-only without --negotiation-tip' ' test_cmp err.expect err.actual ' +test_expect_success 'usage: --negotiate-only with --recurse-submodules' ' + SERVER="server" && + URI="file://$(pwd)/server" && + + setup_negotiate_only "$SERVER" "$URI" && + + cat >err.expect <<-\EOF && + fatal: --negotiate-only and --recurse-submodules cannot be used together + EOF + + test_must_fail git -c protocol.version=2 -C client fetch \ + --negotiate-only \ + --recurse-submodules \ + origin 2>err.actual && + test_cmp err.expect err.actual +' + test_expect_success 'file:// --negotiate-only' ' SERVER="server" && URI="file://$(pwd)/server" &&