From patchwork Mon Nov 22 02:55:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathew McBride X-Patchwork-Id: 12693256 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05AFCC433EF for ; Mon, 22 Nov 2021 02:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=RTw9hlazXTB6/jGp0Os37XfAI4qflmHB1yH5KiUoxk8=; b=zr6OqXl8MS9Mi7 xImlkoBKgXAkC0DKfLFK49+wq+Hkfo+Egr+1QUWroFmAs51cWjiGXJYGqScHJKyKRoCBQ/VuRgLqp 3h5SjOoICRWEweiC9FHaWVGN02HFoanRdhSJORpwzBIzw4sndhkhULs4jCqjcb6qbbtUXdmtKEL56 4sv2ihM62ZWNOUVRPMinwWSd9DOqQRs44U0YoRzdJyAdi5NsyVF0A6ItlAJHkzhJ0qh7GjM7oeXAa lBarhTJGC2ObBaux7vaWAedrSS5S6qf7INb5zLPZDhYXajoDd0o85X7sN5fi2GK7+mQ7smW0lQpIU +cK9QoW65TdwWKouPizw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mozWD-00EjlK-78; Mon, 22 Nov 2021 02:57:21 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mozW9-00Ejjw-Lr for linux-arm-kernel@lists.infradead.org; Mon, 22 Nov 2021 02:57:19 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1FFCF5C01A1; Sun, 21 Nov 2021 21:57:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 21 Nov 2021 21:57:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=traverse.com.au; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=DRVC5L3MNdlCbCaUbXt77+4Bue gyLacB1omkIW83YMg=; b=GTZF+j+4gto4z5zUfqgNeDGF8q94qKtAyN00SrJJuA uEUxFW1gLPRebv7oDEFoSg1AOT42RbXT2kd9G5LLTbVmRgRfU12yzCzxm9Bm+eF3 bJZR7apDeob2Ak0grrzsSGTQMT3YpvQF+ssH4/T/vOtzMpHKdZHpAqLDNHhQCSGY rQvw4gyz8WiY0m2SlvRSjwWwIqPR02RbqjFUpPhL4T/7tKkVTkmRI7V16MNy+rNn OKQGwSCp3G0bfRarutRhVBCQnaDvcX1t31YcfgDTTd2rhKrofTBFUNXQxC8CChlb kHxQIjxDHkvQluWbLc5/CqXS1xN8yTA6qu1j0DutAptQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=DRVC5L3MNdlCbCaUb Xt77+4BuegyLacB1omkIW83YMg=; b=YOHzAMf6PyoxfQqlBuSa8dSXygW7GTXsT FTOLMx98hSJDeDLUgj7TzjOfzmzQ2MtCdNkrkcIIDtq2tisTwqWZNeAel1M7e4fA Q/w8nZ82RKV5osSKCXbsyR4vMkVCgSIAjGpbfyqmzxVkiNwiVzRWuDmdjh+uNejX tgf5D8ziz2Lmw/zhtEgPXz9ZdvEaoCQ3JfrsGtCUw1dZ2VYcQVXT2hlZSZ/fO8Pu 2+oSKBDSgV60I33TWQTD3BTr6aDAmiD0834iuyKSP7DX3iL5O4X9t5MLw6B1UxSF yZ8Ex06NzkkzrrX94UbE/399FKA+8OMcEkYpMS75M9+mc8MZqoZKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeefgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepofgrthhhvgifucfo tgeurhhiuggvuceomhgrthhtsehtrhgrvhgvrhhsvgdrtghomhdrrghuqeenucggtffrrg htthgvrhhnpefgkeehgfeiheffteduheevveduuedttdetieffuefgveeutddttdegleef keelvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrghtthesthhrrghvvghrshgvrdgtohhmrdgruh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 21 Nov 2021 21:57:07 -0500 (EST) From: Mathew McBride To: Shawn Guo , Li Yang , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Rob Herring Cc: Mathew McBride , stable@vger.kernel.org Subject: [PATCH] arm64: dts: ten64: remove redundant interrupt declaration for gpio-keys Date: Mon, 22 Nov 2021 02:55:54 +0000 Message-Id: <20211122025554.15338-1-matt@traverse.com.au> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211121_185717_841275_3499A54D X-CRM114-Status: UNSURE ( 7.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org gpio-keys already 'inherits' the interrupts from the controller of the specified GPIO, so having another declaration is redundant. On >=v5.15 this started causing an oops under gpio_keys_probe as the IRQ was already claimed. Signed-off-by: Mathew McBride Fixes: 418962eea358 ("arm64: dts: add device tree for Traverse Ten64 (LS1088A)") Cc: stable@vger.kernel.org --- arch/arm64/boot/dts/freescale/fsl-ls1088a-ten64.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-ten64.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-ten64.dts index 3063851c2fb9..d3f03dcbb8c3 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-ten64.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-ten64.dts @@ -38,7 +38,6 @@ buttons { powerdn { label = "External Power Down"; gpios = <&gpio1 17 GPIO_ACTIVE_LOW>; - interrupts = <&gpio1 17 IRQ_TYPE_EDGE_FALLING>; linux,code = ; }; @@ -46,7 +45,6 @@ powerdn { admin { label = "ADMIN button"; gpios = <&gpio3 8 GPIO_ACTIVE_HIGH>; - interrupts = <&gpio3 8 IRQ_TYPE_EDGE_RISING>; linux,code = ; }; };